bookie_accounting 2.0.0 → 2.0.1

data/spec/senders/standalone_spec.rb

@@ -8,7 +8,7 @@ require 'pacct'
 module Bookie
   module Senders
     module Standalone
-      
+
     end
   end
 end
@@ -16,26 +16,24 @@ end
 describe Bookie::Senders::Standalone do
   let(:config) { Bookie::Config.new('snapshot/pacct_test_config.json') }
   let(:sender) { Bookie::Sender.new(config) }
-  
+
   it "correctly yields jobs" do
     sender.each_job('snapshot/pacct') do |job|
-      job.class.should eql Pacct::Entry
-      job.user_name.should eql 'root'
+      expect(job.class).to eql Pacct::Entry
+      expect(job.user_name).to eql 'root'
     end
   end
-  
+
   it "has the correct system type name" do
-    sender.system_type_name.should eql 'Standalone'
+    expect(sender.system_type_name).to eql 'Standalone'
   end
-  
+
   it "has the correct memory stat type" do
-    sender.memory_stat_type.should eql :avg
+    expect(sender.memory_stat_type).to eql :avg
   end
 end
 
 describe Pacct::Entry do
-  it "has a to_record method" do
-    Pacct::Entry.new.respond_to?(:to_record).should eql true
-  end
+  it { expect(Pacct::Entry.new).to respond_to(:to_record) }
 end
 

data/spec/senders/torque_cluster_spec.rb

@@ -6,38 +6,38 @@ require 'bookie/senders/torque_cluster.rb'
 module Bookie
   module Senders
     module TorqueCluster
-      
+
     end
   end
 end
 
 module Torque
   class Job
-  
+
   end
-  
+
   class JobLog
-  
+
   end
 end
 
 describe Bookie::Senders::TorqueCluster do
   let(:config) { Bookie::Config.new('snapshot/test_config.json') }
   let(:sender) { Bookie::Sender.new(config) }
-  
+
   it "correctly yields jobs" do
     sender.each_job('snapshot/torque') do |job|
-      job.class.should eql Torque::Job
-      job.user_name.should eql 'blm768'
+      expect(job.class).to eql Torque::Job
+      expect(job.user_name).to eql 'blm768'
     end
   end
-  
+
   it "has the correct system type name" do
-    sender.system_type_name.should eql 'TORQUE cluster'
+    expect(sender.system_type_name).to eql 'TORQUE cluster'
   end
-  
+
   it "has the correct memory stat type" do
-    sender.memory_stat_type.should eql :max
+    expect(sender.memory_stat_type).to eql :max
   end
 end
 
@@ -49,43 +49,43 @@ describe Torque::JobLog do
   before(:each) do
     @log = Torque::JobLog.new('snapshot/torque')
   end
-  
+
   it "throws an error if the file does not exist" do
-    expect { Torque::JobLog.new('snapshot/abc') }.to raise_error
+    expect { Torque::JobLog.new('snapshot/abc') }.to raise_error(Errno::ENOENT)
   end
-  
+
   it "correctly reads data" do
     n = 0
     @log.each_job do |job|
-      job.user_name.should eql "blm768"
-      job.group_name.should eql "test"
-      job.start_time.should eql Time.at(1349679573)
-      job.wall_time.should eql 67
-      job.cpu_time.should eql 63
-      job.physical_memory.should eql 139776
-      job.virtual_memory.should eql 173444
-      job.memory.should eql job.physical_memory + job.virtual_memory
-      job.exit_code.should eql 0
+      expect(job.user_name).to eql "blm768"
+      expect(job.group_name).to eql "test"
+      expect(job.start_time).to eql Time.at(1349679573)
+      expect(job.wall_time).to eql 67
+      expect(job.cpu_time).to eql 63
+      expect(job.physical_memory).to eql 139776
+      expect(job.virtual_memory).to eql 173444
+      expect(job.memory).to eql job.physical_memory + job.virtual_memory
+      expect(job.exit_code).to eql 0
       n += 1
     end
     #One of the entries in the file is not a job end entry and should be skipped.
-    n.should eql 1
+    expect(n).to eql 1
   end
-  
+
   it "can read data more than once" do
     2.times do
       n = 0
       @log.each_job do |job|
         n += 1
       end
-      n.should eql 1
+      expect(n).to eql 1
     end
   end
-  
+
   it "correctly parses durations" do
-    @log.send(:parse_duration, "01:02:03").should eql 3723
+    expect(@log.send(:parse_duration, "01:02:03")).to eql 3723
   end
-  
+
   it "raises errors when lines are invalid" do
     log = Torque::JobLog.new('snapshot/torque_invalid_lines')
     expect { log.each_job }.to raise_error(
@@ -100,8 +100,8 @@ describe Torque::JobLog do
       )
     end
   end
-  
+
   it "correctly calculates the filename for a date" do
-    Torque::JobLog.filename_for_date(Date.new(2012, 1, 3)).should eql Torque::torque_root + '/server_priv/accounting/20120103'
+    expect(Torque::JobLog.filename_for_date(Date.new(2012, 1, 3))).to eql Torque::torque_root + '/server_priv/accounting/20120103'
   end
 end

metadata

@@ -1,97 +1,69 @@
 --- !ruby/object:Gem::Specification
 name: bookie_accounting
 version: !ruby/object:Gem::Version
-  version: 2.0.0
+  version: 2.0.1
 platform: ruby
 authors:
 - Ben Merritt
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-10-03 00:00:00.000000000 Z
+date: 2016-02-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: json
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: mysql2
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: pacct
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: protected_attributes
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: spreadsheet
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 description: A simple system to consolidate and analyze process accounting records
@@ -104,7 +76,7 @@ executables:
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
+- ".gitignore"
 - Gemfile
 - LICENSE
 - README.md
@@ -162,7 +134,6 @@ files:
 - spec/senders/standalone_spec.rb
 - spec/senders/torque_cluster_spec.rb
 - spec/spec_helper.rb
-- todo.txt
 homepage: https://github.com/blm768/bookie/
 licenses:
 - MIT
@@ -173,17 +144,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.3
+rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
 summary: A simple system to consolidate and analyze process accounting records

data/todo.txt

@@ -1,13 +0,0 @@
-Replace deprecated find_by_* methods with find_by!(:attribute => value).
-Allow configuration of date boundary to midnight in local time zone?
-Make sure all source files have the required "require"s
-Use "let" in RSpect tests
-Replace 3600 with 2.hours, etc.
-Also clear out other "magic" numbers.
-Split some tests up.
-Validate uniqueness?
-Unit test uniqueness constraints?
-Use optimistic concurrency control?
-Make units more independent.
-Make unit test success more independent.
-