bookie_accounting 1.0.0 → 1.1.0

data/spec/database_spec.rb

@@ -19,20 +19,32 @@ module Helpers
     summaries
   end
   
-  def test_relations(job, relations)
+  def test_job_relations(job, relations)
+    #Make sure all relations with the same value have the same object_id:
     rels = [job.user, job.user.group, job.system, job.system.system_type]
+    unbound_object_id = Object.instance_method(:object_id)
     rels.each do |r|
       if relations.include?(r)
-        old_r = relations[r]
-        old_r.should eql r
+        relations[r].should eql unbound_object_id.bind(r).call
+      else
+        relations[r] = unbound_object_id.bind(r).call
       end
-      relations[r] = r
     end
   end
+
+  def test_system_relations(system, relations)
+    t = system.system_type
+    unbound_object_id = Object.instance_method(:object_id)
+    if relations.include?(t)
+      relations[t].should eql unbound_object_id.bind(t).call
+    else
+      relations[t] = unbound_object_id.bind(t).call
+    end
+  end
+
   
   def check_job_sums(js_sum, j_sum)
-    js_sum[:num_jobs].should eql j_sum[:jobs].length
-    [:cpu_time, :memory_time, :successful].each do |field|
+    [:cpu_time, :memory_time].each do |field|
       js_sum[field].should eql j_sum[field]
     end
     true
@@ -94,7 +106,6 @@ describe Bookie::Database do
   describe Bookie::Database::Job do
     before(:each) do
       @jobs = Bookie::Database::Job
-      @base_time = @jobs.first.start_time
     end
     
     it "correctly sets end times" do
@@ -184,18 +195,18 @@ describe Bookie::Database do
     end
     
     it "correctly filters by start time" do
-      jobs = @jobs.by_start_time_range(@base_time ... @base_time + 3600 * 2 + 1)
+      jobs = @jobs.by_start_time_range(base_time ... base_time + 3600 * 2 + 1)
       jobs.length.should eql 3
-      jobs = @jobs.by_start_time_range(@base_time + 1 ... @base_time + 3600 * 2)
+      jobs = @jobs.by_start_time_range(base_time + 1 ... base_time + 3600 * 2)
       jobs.length.should eql 1
       jobs = @jobs.by_start_time_range(Time.at(0) ... Time.at(3))
       jobs.length.should eql 0
     end
     
     it "correctly filters by end time" do
-      jobs = @jobs.by_end_time_range(@base_time ... @base_time + 3600 * 2 + 1)
+      jobs = @jobs.by_end_time_range(base_time ... base_time + 3600 * 2 + 1)
       jobs.length.should eql 2
-      jobs = @jobs.by_end_time_range(@base_time + 1 ... @base_time + 3600 * 2)
+      jobs = @jobs.by_end_time_range(base_time + 1 ... base_time + 3600 * 2)
       jobs.length.should eql 1
       jobs = @jobs.by_end_time_range(Time.at(0) ... Time.at(3))
       jobs.length.should eql 0
@@ -203,24 +214,30 @@ describe Bookie::Database do
     
     describe "#by_time_range_inclusive" do
       it "correctly filters by inclusive time range" do
-        jobs = @jobs.by_time_range_inclusive(@base_time ... @base_time + 3600 * 2 + 1)
-        jobs.length.should eql 3
-        jobs = @jobs.by_time_range_inclusive(@base_time + 1 ... @base_time + 3600 * 2 - 1)
-        jobs.length.should eql 2
-        jobs = @jobs.by_time_range_inclusive(Time.at(0) ... Time.at(3))
+        jobs = @jobs.by_time_range_inclusive(base_time ... base_time + 3600 * 2 + 1)
+        jobs.count.should eql 3
+        jobs = @jobs.by_time_range_inclusive(base_time + 1 ... base_time + 3600 * 2)
+        jobs.count.should eql 2
+        jobs = @jobs.by_time_range_inclusive(base_time ... base_time)
         jobs.length.should eql 0
+        jobs = @jobs.by_time_range_inclusive(base_time .. base_time + 3600 * 2)
+        jobs.count.should eql 3
+        jobs = @jobs.by_time_range_inclusive(base_time .. base_time)
+        jobs.count.should eql 1
       end
       
-      it "correctly handles inverted ranges" do
-        t = Date.new(2012).to_time
-        jobs = @jobs.by_time_range_inclusive(t ... t - 1)
-        jobs.count.should eql 0
+      it "correctly handles empty/inverted ranges" do
+        t = base_time
+        (-1 .. 0).each do |offset|
+          jobs = @jobs.by_time_range_inclusive(t ... t + offset)
+          jobs.count.should eql 0
+        end
       end
     end
     
     it "correctly chains filters" do
       jobs = @jobs.by_user_name("test")
-      jobs = jobs.by_start_time_range(@base_time + 3600 ... @base_time + 3601)
+      jobs = jobs.by_start_time_range(base_time + 3600 ... base_time + 3601)
       jobs.length.should eql 1
       jobs[0].user.group.name.should eql "default"
     end
@@ -229,19 +246,23 @@ describe Bookie::Database do
       it "loads all relations" do
         jobs = Bookie::Database::Job.limit(5)
         relations = {}
-        jobs.all_with_relations.each do |job|
-          test_relations(job, relations)
+        jobs = jobs.all_with_relations
+        Bookie::Database::User.expects(:new).never
+        Bookie::Database::Group.expects(:new).never
+        Bookie::Database::System.expects(:new).never
+        Bookie::Database::SystemType.expects(:new).never
+        jobs.each do |job|
+          test_job_relations(job, relations)
         end
       end
     end
     
     describe "#summary" do
       before(:all) do
-        Time.expects(:now).returns(Time.local(2012) + 36000 * 4).at_least_once
-        @base_time = Time.local(2012)
+        Time.expects(:now).returns(base_time + 36000 * 4).at_least_once
         @jobs = Bookie::Database::Job
         @length = @jobs.all.length
-        @summary = Helpers::create_summaries(@jobs, Time.local(2012))
+        @summary = Helpers::create_summaries(@jobs, base_time)
       end
       
       it "produces correct summary totals" do
@@ -259,8 +280,7 @@ describe Bookie::Database do
         clipped_jobs.should eql 25
         @summary[:clipped][:cpu_time].should eql clipped_jobs * 100 - 50
         @summary[:clipped][:memory_time].should eql clipped_jobs * 200 * 3600 - 100 * 3600
-        #Luckily for us, rounding down gives us the right answer. This is a bit fragile, though.
-        @summary[:clipped][:successful].should eql clipped_jobs / 2
+        @summary[:clipped][:successful].should eql clipped_jobs / 2 + 1
       end
       
       it "correctly handles summaries of empty sets" do
@@ -285,29 +305,17 @@ describe Bookie::Database do
         end
       end
       
-      it "only considers finished jobs to be successful" do
-        begin
-          job = Bookie::Database::Job.create!(
-            :user => Bookie::Database::User.first,
-            :system => Bookie::Database::System.first,
-            :command_name => '',
-            :cpu_time => 100,
-            :start_time => Time.local(2013),
-            :wall_time => 3600 * 24 * 2,
-            :memory => 10000,
-            :exit_code => 0
-          )
-          @jobs.summary(job.start_time ... job.start_time + 3600 * 24)[:successful].should eql 0
-        ensure
-          job.delete if job
-        end
-      end
-    
-      
       it "correctly handles inverted ranges" do
         @jobs.summary(Time.now() ... Time.now() - 1).should eql @summary[:empty]
         @jobs.summary(Time.now() .. Time.now() - 1).should eql @summary[:empty]
       end
+
+      it "distinguishes between inclusive and exclusive ranges" do
+        sum = @jobs.summary(base_time ... base_time + 3600)
+        sum[:jobs].length.should eql 1
+        sum = @jobs.summary(base_time .. base_time + 3600)
+        sum[:jobs].length.should eql 2
+      end
     end
     
     it "validates fields" do
@@ -316,7 +324,7 @@ describe Bookie::Database do
         :system => Bookie::Database::System.first,
         :command_name => '',
         :cpu_time => 100,
-        :start_time => Time.local(2012),
+        :start_time => base_time,
         :wall_time => 1000,
         :memory => 10000,
         :exit_code => 0
@@ -356,7 +364,6 @@ describe Bookie::Database do
                   :system => system,
                   :command_name => command_name,
                   :date => date,
-                  :num_jobs => 0,
                   :cpu_time => 0,
                   :memory_time => 0,
                   :successful => 0
@@ -375,6 +382,16 @@ describe Bookie::Database do
           sum.date.should eql d
         end
       end
+
+      it "correctly filters by date range" do
+        d = Date.new(2012)
+        sums = Bookie::Database::JobSummary
+        sums.by_date_range(d .. d).count.should eql sums.by_date(d).count
+        sums.by_date_range(d ... d).count.should eql 0
+        sums.by_date_range(d + 1 .. d).count.should eql 0
+        sums.by_date_range(d .. d + 1).count.should eql sums.by_date(d).count + sums.by_date(d + 1).count
+        sums.by_date_range(d ... d + 1).count.should eql sums.by_date(d).count
+      end
       
       it "correctly filters by user" do
         u = Bookie::Database::User.first
@@ -450,14 +467,13 @@ describe Bookie::Database do
         Bookie::Database::JobSummary.delete_all
         s = Bookie::Database::JobSummary.find_or_new(Date.new(2012), 1, 1, 'vi')
         s.persisted?.should eql false
-        s.num_jobs = 0
         s.cpu_time = 0
         s.memory_time = 0
-        s.successful = 0
         s.save!
       end
       
       it "uses the old summary if present" do
+        #Uses the JobSummary created in the previous test
         s = Bookie::Database::JobSummary.find_or_new(Date.new(2012), 1, 1, 'vi')
         s.persisted?.should eql true
       end
@@ -470,7 +486,7 @@ describe Bookie::Database do
       
       it "produces correct summaries" do
         d = Date.new(2012)
-        range = d.to_time ... (d + 1).to_time
+        range = base_time ... base_time + 1.days
         Bookie::Database::JobSummary.summarize(d)
         sums = Bookie::Database::JobSummary.all
         found_sums = Set.new
@@ -481,74 +497,106 @@ describe Bookie::Database do
           check_job_sums(sum, sum_2)
           found_sums.add([sum.user.id, sum.system.id, sum.command_name])
         end
-        #Is it producing all of the values needed?
+        #Is it catching all of the combinations of categories?
         Bookie::Database::Job.by_time_range_inclusive(range).select('user_id, system_id, command_name').uniq.all.each do |values|
           values = [values.user_id, values.system_id, values.command_name]
           found_sums.include?(values).should eql true
         end
       end
+      
+      it "creates dummy summaries when there are no jobs" do
+        d = Date.new(2012) + 5
+        Bookie::Database::JobSummary.summarize(d)
+        sums = Bookie::Database::JobSummary.by_date(d).all
+        sums.length.should eql 1
+        sum = sums[0]
+        sum.cpu_time.should eql 0
+        sum.memory_time.should eql 0
+
+        #Check the case where there are no users or no systems:
+        Bookie::Database::JobSummary.delete_all
+        [Bookie::Database::User, Bookie::Database::System].each do |klass|
+          #This will cause nested transactions, but we *should* be OK.
+          Bookie::Database::JobSummary.transaction do
+            klass.delete_all
+            Bookie::Database::JobSummary.summarize(d)
+            Bookie::Database::JobSummary.by_date(d).count.should eql 0
+            raise ActiveRecord::Rollback
+          end
+        end
+      end
     end
   
     describe "#summary" do
       before(:each) do
         Bookie::Database::JobSummary.delete_all
-        t = (Date.new(2012) + 3).to_time
+        t = base_time + 2.days
         Time.expects(:now).at_least(0).returns(t)
       end
       
-      #To do: test inclusive ranges?
       it "produces correct summaries" do
         #To consider: flesh out some more?
-        date_start = Date.new(2012)
-        date_end = date_start
-        date_bound = date_start + 3
-        while date_start < date_bound
-          while date_end < date_bound
-            range = date_start ... date_end
-            time_range = date_start.to_time ... date_end.to_time
-            sum1 = Bookie::Database::JobSummary.summary(:range => range)
-            sum2 = Bookie::Database::Job.summary(time_range)
-            check_job_sums(sum1, sum2)
-            Bookie::Database::JobSummary.summary(:range => time_range).should eql sum1
-            date_end += 1
+        time_start = base_time
+        time_end = time_start
+        time_bound = time_start + 3.days
+        while time_start < time_bound
+          while time_end < time_bound
+            [true, false].each do |exclude_end|
+              time_range = Range.new(time_start, time_end, exclude_end)
+              sum1 = Bookie::Database::JobSummary.summary(:range => time_range)
+              sum2 = Bookie::Database::Job.summary(time_range)
+              check_job_sums(sum1, sum2)
+            end
+            time_end += 1.days
           end
-          date_start += 1
+          time_start += 1.days
         end
-        date_start = Date.new(2012)
-        time_start = date_start.to_time
-        time_end = (date_start + 1).to_time
+        time_start = base_time
+        time_end = time_start + 1.days
         [0, -7200, 7200].each do |offset_begin|
           [0, -7200, 7200].each do |offset_end|
-            range_offset = time_start + offset_end ... time_end + offset_end
-            sum1 = Bookie::Database::JobSummary.summary(:range => range_offset)
-            sum2 = Bookie::Database::Job.summary(range_offset)
-            check_job_sums(sum1, sum2)
+            [true, false].each do |exclude_end|
+              range_offset = Range.new(time_start + offset_end, time_end + offset_end, exclude_end)
+              sum1 = Bookie::Database::JobSummary.summary(:range => range_offset)
+              sum2 = Bookie::Database::Job.summary(range_offset)
+              check_job_sums(sum1, sum2)
+            end
           end
         end
       end
-      
-      def check_time_bounds
-        date_min = Date.new(2012)
-        date_max = date_min + 1
+
+      it "distinguishes between inclusive and exclusive ranges" do
+        Summary = Bookie::Database::JobSummary
+        sum = Summary.summary(:range => (base_time ... base_time + 3600 * 2))
+        sum[:num_jobs].should eql 2
+        sum = Summary.summary(:range => (base_time .. base_time + 3600 * 2))
+        sum[:num_jobs].should eql 3
+      end
+
+      def check_time_bounds(time_max = base_time + 1.days)
+        time_min = base_time
         check_job_sums(Bookie::Database::JobSummary.summary, Bookie::Database::Job.summary)
-        Bookie::Database::JobSummary.order(:date).first.date.should eql date_min
-        Bookie::Database::JobSummary.order('date DESC').first.date.should eql date_max
+        Bookie::Database::JobSummary.order(:date).first.date.should eql time_min.to_date
+        Bookie::Database::JobSummary.order('date DESC').first.date.should eql time_max.utc.to_date
       end
       
       it "correctly finds the default time bounds" do
+        #The last daily summary in this range isn't cached because Time.now could be partway through a day.
         check_time_bounds
         systems = Bookie::Database::System.active_systems
         Bookie::Database::JobSummary.delete_all
         #Check the case where all systems are decommissioned.
+        end_times = {}
         begin
           systems.each do |sys|
-            sys.end_time = Time.now
+            end_times[sys.id] = sys.end_time
+            sys.end_time = base_time + 2.days
             sys.save!
           end
           check_time_bounds
         ensure
           systems.each do |sys|
-            sys.end_time = nil
+            sys.end_time = end_times[sys.id]
             sys.save!
           end
         end
@@ -570,8 +618,8 @@ describe Bookie::Database do
       
       it "correctly handles filtered summaries" do
         filters = {
-          :user_name => 'blm',
-          :group_name => 'blm',
+          :user_name => 'test',
+          :group_name => 'admin',
           :command_name => 'vi',
         }
         filters.each do |filter, value|
@@ -584,7 +632,7 @@ describe Bookie::Database do
       end
       
       it "correctly handles inverted ranges" do
-        t = Date.new(2012).to_time
+        t = base_time
         Bookie::Database::JobSummary.summary(:range => t .. t - 1).should eql({
           :num_jobs => 0,
           :cpu_time => 0,
@@ -594,9 +642,16 @@ describe Bookie::Database do
       end
       
       it "caches summaries" do
+        Bookie::Database::JobSummary.summary
+        Bookie::Database::JobSummary.expects(:summarize).never
+        range = base_time ... base_time + 1.days
+        Bookie::Database::JobSummary.summary(:range => range)
+      end
+
+      it "uses the cached summaries" do
         Bookie::Database::JobSummary.summary
         Bookie::Database::Job.expects(:summary).never
-        range = Date.new(2012) ... Date.new(2012) + 1
+        range = base_time ... base_time + 1.days
         Bookie::Database::JobSummary.summary(:range => range)
       end
     end
@@ -607,12 +662,10 @@ describe Bookie::Database do
         :system => Bookie::Database::System.first,
         :command_name => '',
         :date => Date.new(2012),
-        :num_jobs => 1,
         :cpu_time => 100,
         :memory_time => 1000000,
-        :successful => 1,
       }
-      
+
       sum = Bookie::Database::JobSummary.new(fields)
       sum.valid?.should eql true
       
@@ -622,7 +675,7 @@ describe Bookie::Database do
         job.valid?.should eql false
       end
       
-      [:cpu_time, :memory_time, :successful].each do |field|
+      [:cpu_time, :memory_time].each do |field|
         job = Bookie::Database::JobSummary.new(fields)
         m = job.method("#{field}=".intern)
         m.call(-1)
@@ -725,6 +778,10 @@ describe Bookie::Database do
   end
   
   describe Bookie::Database::System do
+    before(:each) do
+      @systems = Bookie::Database::System
+    end
+
     it "correctly finds active systems" do
       Bookie::Database::System.active_systems.length.should eql 3
     end
@@ -741,14 +798,47 @@ describe Bookie::Database do
         Bookie::Database::System.by_system_type(t).length.should eql 2
       end
     end
-    
+
+    describe "#all_with_relations" do
+      it "loads all relations" do
+        systems = Bookie::Database::System.limit(5)
+        relations = {}
+        systems = systems.all_with_relations
+        Bookie::Database::SystemType.expects(:new).never
+        systems.each do |system|
+          test_system_relations(system, relations)
+        end
+      end
+    end
+
+    describe "#by_time_range_inclusive" do
+      it "correctly filters by inclusive time range" do
+        systems = @systems.by_time_range_inclusive(base_time ... base_time + 36000 * 2 + 1)
+        systems.count.should eql 3
+        systems = @systems.by_time_range_inclusive(base_time + 1 ... base_time + 36000 * 2)
+        systems.count.should eql 2
+        systems = @systems.by_time_range_inclusive(base_time ... base_time)
+        systems.length.should eql 0
+        systems = @systems.by_time_range_inclusive(base_time .. base_time + 36000 * 2)
+        systems.count.should eql 3
+        systems = @systems.by_time_range_inclusive(base_time .. base_time)
+        systems.count.should eql 1
+      end
+      
+      it "correctly handles empty/inverted ranges" do
+        (-1 .. 0).each do |offset|
+          systems = @systems.by_time_range_inclusive(base_time ... base_time + offset)
+          systems.count.should eql 0
+        end
+      end
+    end
+
     describe "#summary" do
       before(:all) do
-        Time.expects(:now).returns(Time.local(2012) + 3600 * 40).at_least_once
-        @base_time = Time.local(2012)
+        Time.expects(:now).returns(base_time + 3600 * 40).at_least_once
         @systems = Bookie::Database::System
-        @summary = Helpers::create_summaries(@systems, Time.local(2012))
-        @summary_wide = @systems.summary(Time.local(2012) - 3600 ... Time.local(2012) + 3600 * 40 + 3600)
+        @summary = Helpers::create_summaries(@systems, base_time)
+        @summary_wide = @systems.summary(base_time - 3600 ... base_time + 3600 * 40 + 3600)
       end
       
       it "produces correct summaries" do
@@ -761,18 +851,23 @@ describe Bookie::Database do
         avg_mem = Float(1000000 * system_total_wall_time / (3600 * 40))
         clipped_avg_mem = Float(1000000 * system_clipped_wall_time) / (3600 * 25 - 1800)
         wide_avg_mem = Float(1000000 * system_wide_wall_time) / (3600 * 42)
+        @summary[:all][:systems].length.should eql 4
         @summary[:all][:avail_cpu_time].should eql system_total_cpu_time
         @summary[:all][:avail_memory_time].should eql 1000000 * system_total_wall_time
         @summary[:all][:avail_memory_avg].should eql avg_mem
+        @summary[:all_constrained][:systems].length.should eql 4
         @summary[:all_constrained][:avail_cpu_time].should eql system_total_cpu_time
         @summary[:all_constrained][:avail_memory_time].should eql 1000000 * system_total_wall_time
         @summary[:all_constrained][:avail_memory_avg].should eql avg_mem
+        @summary[:clipped][:systems].length.should eql 3
         @summary[:clipped][:avail_cpu_time].should eql clipped_cpu_time
         @summary[:clipped][:avail_memory_time].should eql system_clipped_wall_time * 1000000
         @summary[:clipped][:avail_memory_avg].should eql clipped_avg_mem
+        @summary_wide[:systems].length.should eql 4
         @summary_wide[:avail_cpu_time].should eql system_wide_cpu_time
         @summary_wide[:avail_memory_time].should eql 1000000 * system_wide_wall_time
         @summary_wide[:avail_memory_avg].should eql wide_avg_mem
+        @summary[:empty][:systems].length.should eql 0
         @summary[:empty][:avail_cpu_time].should eql 0
         @summary[:empty][:avail_memory_time].should eql 0
         @summary[:empty][:avail_memory_avg].should eql 0.0
@@ -785,7 +880,7 @@ describe Bookie::Database do
           end
           summary_all_systems_ended = @systems.summary()
           summary_all_systems_ended.should eql @summary[:all]
-          summary_all_systems_ended = @systems.summary(Time.local(2012) ... Time.now + 3600)
+          summary_all_systems_ended = @systems.summary(base_time ... Time.now + 3600)
           s2 = @summary[:all].dup
           s2[:avail_memory_avg] = Float(1000000 * system_total_wall_time) / (3600 * 41)
           summary_all_systems_ended.should eql s2
@@ -800,7 +895,7 @@ describe Bookie::Database do
       end
       
       it "correctly handles inverted ranges" do
-        t = Date.new(2012).to_time
+        t = base_time
         @systems.summary(t ... t - 1).should eql @summary[:empty]
         @systems.summary(t .. t - 1).should eql @summary[:empty]
       end
@@ -825,16 +920,16 @@ describe Bookie::Database do
       it "finds the correct system" do
         Bookie::Database::System.find_current(@sender_2).id.should eql 2
         Bookie::Database::System.find_current(@sender_2, Time.now).id.should eql 2
-        Bookie::Database::System.find_current(@sender_1, Date.new(2012, 1, 1).to_time).id.should eql 1
+        Bookie::Database::System.find_current(@sender_1, base_time).id.should eql 1
       end
       
       it "correctly detects the lack of a matching system" do
         expect {
-          Bookie::Database::System.find_current(@sender_1, Date.new(2011, 1, 1).to_time)
+          Bookie::Database::System.find_current(@sender_1, base_time - 1.years)
         }.to raise_error(/^There is no system with hostname 'test1' in the database at /)
         @config_t1.expects(:hostname).at_least_once.returns('test1000')
         expect {
-          Bookie::Database::System.find_current(@sender_1, Date.new(2012, 1, 1).to_time)
+          Bookie::Database::System.find_current(@sender_1, base_time)
         }.to raise_error(/^There is no system with hostname 'test1000' in the database at /)
       end
       
@@ -876,7 +971,7 @@ describe Bookie::Database do
         :cores => 2,
         :memory => 1000000,
         :system_type => Bookie::Database::SystemType.first,
-        :start_time => Time.local(2012)
+        :start_time => base_time
       }
       
       Bookie::Database::System.new(fields).valid?.should eql true
@@ -901,7 +996,7 @@ describe Bookie::Database do
       end
       
       system = Bookie::Database::System.new(fields)
-      system.end_time = Time.local(2012)
+      system.end_time = base_time
       system.valid?.should eql true
       system.end_time += 5
       system.valid?.should eql true
@@ -970,3 +1065,4 @@ describe Bookie::Database do
     end
   end
 end
+

data/spec/extensions_spec.rb

@@ -0,0 +1,25 @@
+require 'spec_helper'
+
+describe Range do
+  describe "#normalized" do
+    it "correctly normalizes" do
+      (1 .. 2).normalized.should eql(1 .. 2)
+      (1 .. 1).normalized.should eql(1 .. 1)
+      (1 ... 1).normalized.should eql(1 ... 1)
+      (1 .. 0).normalized.should eql(1 ... 1)
+      (1 ... 0).normalized.should eql( 1 ... 1 )
+    end
+  end
+
+  describe "empty?" do
+    it "correctly determines emptiness" do
+      (1 .. 2).empty?.should eql false
+      (1 .. 1).empty?.should eql false
+      (1 ... 2).empty?.should eql false
+      (1 ... 1).empty?.should eql true
+      (1 .. 0).empty?.should eql true
+      (1 ... 0).empty?.should eql true
+    end
+  end
+end
+