book-value 0.0.3 → 0.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ed291369351306ff8e17eba798235e353214752282ae1b9b48a5174366664ba6
-  data.tar.gz: a34bf2c5abdd71e46237096ee49199619bf0f7c033c4a32b049f72d61b24cfe2
+  metadata.gz: f13ec585d50646d3083b25f0d66fd48a18846260bf43142240ac2900264abfef
+  data.tar.gz: b296783edf3d9a4e8eae476df35a35e7c6df43550125820c1de2c450c275fe6f
 SHA512:
-  metadata.gz: e20a91c25c2975525f2f10cd29d07ce39832b9bd4569d812fc600fa77e43c05108c1523981a13e3e723459b42c0e349cdbf2d0f04994dd41ffc0efea3fa64b2b
-  data.tar.gz: 017ad5d8a9757fd8433b154d5869162c271c2b43bb6c8457d2722d0cda76c2fe6f94f1c1a57eb4bf3bac146bd8eed8c4a1ffe20092ec4369e1561c8c7f2402c7
+  metadata.gz: b01ba337b241e8182df07035e54630cc8faaad0b9dd04393bc2cb95cb4261f984ac2ee9cbd8852413b1293adf7ebb110dae69dfb23b089bd7526b1d2b10f1f48
+  data.tar.gz: 23087867bb8eeb3066fbbd128c395abbef11453f23baeb9db07beac84b55b0f837809db1c77496339f4f33b8f6bbaa140c53dc2a15a9458d218f31cd70fd13ed

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    book-value (0.0.1)
+    book-value (0.0.5)
       active_attr (~> 0.15.4)
       httparty (~> 0.21.0)
       nokogiri (~> 1.14.0)

data/lib/book-value/client.rb

@@ -38,33 +38,32 @@ module BookValue
       options
     end
 
-    # TODO: Fix model to try `-`
     def car_features(make, model)
-      process_model(model) do |model_name|
+      checkbox_options = {}
+
+      process_model(model).each do |model_name|
         raw_page = authorise_and_send(http_method: :get, command: "calculate/#{make.downcase}/#{model_name}")
-        next if raw_page == {}
 
         doc = Nokogiri::HTML(raw_page['body'])
 
-        checkbox_options = {}
-
         doc.css(".list-group li div").each do |checkbox|
           input_of_child = checkbox.children.find { |child| child.name == 'input' }
           label_of_child = checkbox.children.find { |child| child.name == 'label' }
 
           checkbox_options[input_of_child[:name]] = label_of_child.children.first.to_s
         end
-
-        return checkbox_options
       end
+
+      checkbox_options
     end
 
     # Features are just the list of features
     # condition_score is between 1-10, 10 is perfect, 1 is bad
     def get_book_value(make, model, features, mileage, year, condition_score = 10)
-      process_model(model) do |model_name|
-        feature_params = ""
+      output = ''
+      feature_params = ''
 
+      process_model(model).each do |model_name|
         features.each do |feature_id|
           feature_params = "#{feature_params}#{feature_id}=on&"
         end
@@ -72,9 +71,8 @@ module BookValue
         feature_params = feature_params[0..-2]
 
         milage_form_page = authorise_and_send(http_method: :post, payload: feature_params, command: "calculate/#{make.downcase}/#{model_name}")
-        next if milage_form_page == {}
-
         condition_url = milage_form_page['headers']['location']
+        next unless condition_url
 
         _condition_page = HTTParty.post(condition_url, body: "mileage=#{mileage}&year=#{year}")
 
@@ -82,8 +80,11 @@ module BookValue
         book_value_page = HTTParty.post(book_value_url, body: "condition_score=#{condition_score}")
 
         doc = Nokogiri::HTML(book_value_page.body)
-        return doc.at('h4').text
+
+        output = doc.at('h4').text
       end
+
+      output
     end
 
     private
@@ -138,7 +139,8 @@ module BookValue
       {
         'start_time' => start_time,
         'end_time' => end_time,
-        'total_time' => total_time
+        'total_time' => total_time,
+        'ok' => response.ok?
       }
     end
 

data/lib/book-value/version.rb

@@ -1,3 +1,3 @@
 module BookValue
-  VERSION = '0.0.3'
+  VERSION = '0.0.5'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: book-value
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.5
 platform: ruby
 authors:
 - trex22
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2023-03-16 00:00:00.000000000 Z
+date: 2023-03-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: httparty