book-value 0.0.1 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3486778f29f7596a49211757edad68992313807f0fc2ada242dfcea365f2b358
-  data.tar.gz: f209f2f4c05e4eba2bfdb61e61652acb0d8b52a54abe21acf9e5a326b68dd202
+  metadata.gz: ed291369351306ff8e17eba798235e353214752282ae1b9b48a5174366664ba6
+  data.tar.gz: a34bf2c5abdd71e46237096ee49199619bf0f7c033c4a32b049f72d61b24cfe2
 SHA512:
-  metadata.gz: 83a23f501ef44bd7cbccdd8316073719d459137d9bf6060e04df998ef6ba074845f171935cf6511de6fec222e11703f58137af66477c880efcd266b2aa121c91
-  data.tar.gz: 21a9eac0b5cc840dc92b74245f27bbd3b2d774b0336cd8acfebf71b89cd0f7eb8787f9b7d3a57dc3cb9139c2f609ed2fa6363f4e6958cf94e184de2927503c23
+  metadata.gz: e20a91c25c2975525f2f10cd29d07ce39832b9bd4569d812fc600fa77e43c05108c1523981a13e3e723459b42c0e349cdbf2d0f04994dd41ffc0efea3fa64b2b
+  data.tar.gz: 017ad5d8a9757fd8433b154d5869162c271c2b43bb6c8457d2722d0cda76c2fe6f94f1c1a57eb4bf3bac146bd8eed8c4a1ffe20092ec4369e1561c8c7f2402c7

data/README.md

@@ -31,7 +31,7 @@ Or install it yourself as:
   client = BookValue::Client.new
 
   # Some example calls
-  client.car_models
+  client.car_makes
   client.car_models(make)
   client.car_features(make, model)
   client.get_book_value(make, model, features, mileage, year, condition_score)

data/lib/book-value/client.rb

@@ -38,50 +38,60 @@ module BookValue
       options
     end
 
+    # TODO: Fix model to try `-`
     def car_features(make, model)
-      raw_page = authorise_and_send(http_method: :get, command: "calculate/#{make.downcase}/#{model.downcase.gsub(' ', '')}")
-      doc = Nokogiri::HTML(raw_page['body'])
+      process_model(model) do |model_name|
+        raw_page = authorise_and_send(http_method: :get, command: "calculate/#{make.downcase}/#{model_name}")
+        next if raw_page == {}
 
-      raw_page = authorise_and_send(http_method: :get, command: "calculate/#{make.downcase}/#{model.downcase.gsub(' ', '')}")
-      doc = Nokogiri::HTML(raw_page['body'])
+        doc = Nokogiri::HTML(raw_page['body'])
 
-      checkbox_options = {}
+        checkbox_options = {}
 
-      doc.css(".list-group li div").each do |checkbox|
-        input_of_child = checkbox.children.find { |child| child.name == 'input' }
-        label_of_child = checkbox.children.find { |child| child.name == 'label' }
+        doc.css(".list-group li div").each do |checkbox|
+          input_of_child = checkbox.children.find { |child| child.name == 'input' }
+          label_of_child = checkbox.children.find { |child| child.name == 'label' }
 
-        checkbox_options[input_of_child[:name]] = label_of_child.children.first.to_s
-      end
+          checkbox_options[input_of_child[:name]] = label_of_child.children.first.to_s
+        end
 
-      checkbox_options
+        return checkbox_options
+      end
     end
 
     # Features are just the list of features
     # condition_score is between 1-10, 10 is perfect, 1 is bad
-    def get_book_value(make, model, features, mileage, year, condition_score)
-      feature_params = ""
+    def get_book_value(make, model, features, mileage, year, condition_score = 10)
+      process_model(model) do |model_name|
+        feature_params = ""
 
-      features.each do |feature_id|
-        feature_params = "#{feature_params}#{feature_id}=on&"
-      end
+        features.each do |feature_id|
+          feature_params = "#{feature_params}#{feature_id}=on&"
+        end
 
-      feature_params = feature_params[0..-2]
+        feature_params = feature_params[0..-2]
 
-      milage_form_page = authorise_and_send(http_method: :post, payload: feature_params, command: "calculate/#{make.downcase}/#{model.downcase.gsub(' ', '')}")
-      condition_url = milage_form_page['headers']['location']
+        milage_form_page = authorise_and_send(http_method: :post, payload: feature_params, command: "calculate/#{make.downcase}/#{model_name}")
+        next if milage_form_page == {}
 
-      _condition_page = HTTParty.post(condition_url, body: "mileage=#{mileage}&year=#{year}")
+        condition_url = milage_form_page['headers']['location']
 
-      book_value_url = condition_url.gsub('/4', '/5')
-      book_value_page = HTTParty.post(book_value_url, body: "condition_score=#{condition_score}")
+        _condition_page = HTTParty.post(condition_url, body: "mileage=#{mileage}&year=#{year}")
 
-      doc = Nokogiri::HTML(book_value_page.body)
-      doc.at('h4').text
+        book_value_url = condition_url.gsub('/4', '/5')
+        book_value_page = HTTParty.post(book_value_url, body: "condition_score=#{condition_score}")
+
+        doc = Nokogiri::HTML(book_value_page.body)
+        return doc.at('h4').text
+      end
     end
 
     private
 
+    def process_model(model)
+      [model.downcase.gsub(' ', ''), model.downcase.gsub(' ', '-')]
+    end
+
     def img_path(name)
       "#{base_path}/data/makes/#{snake_case(name)}"
     end

data/lib/book-value/version.rb

@@ -1,3 +1,3 @@
 module BookValue
-  VERSION = '0.0.1'
+  VERSION = '0.0.3'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: book-value
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.3
 platform: ruby
 authors:
 - trex22
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2023-03-15 00:00:00.000000000 Z
+date: 2023-03-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: httparty