boojs 0.0.30 → 0.0.31

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 8afbb0e166580c67fdc4952b918827224e90a09e
-  data.tar.gz: 0e358c78333c5630542df9a918200f6ab188be6a
+  metadata.gz: 96ee4c56f3d5b80a75b2d084e1c56039dc834e5f
+  data.tar.gz: e044ad6d195d8565faeed8838fd2c8d2bb83a9a4
 SHA512:
-  metadata.gz: 5899ff5185e76d0a1130172f2b0453994faa4c2201bdaf46ed9798c60bf9c7cf713ffa0fdf668715d91d1d4262842d053f1ba1dd936a03a6202c683e39c17e20
-  data.tar.gz: e18edf2f45f15c15d079894c0598e290c4f376827432b855972487bc2d76300b4722cc9ceab16e2c6c273fee651300278923e4bb3caf30c6c2111fdc1d284a69
+  metadata.gz: 16d8523cbe1210b08f194ebee09fc74be614163fced0f057e5cabfe650ea377ec012752e7cd7659ae9ef122d07488b2ad9671a4a9a277a58ef4c8e02351bf03f
+  data.tar.gz: 618c00d39140585d135f05e39745fe43208c48f95dceff18a6a58855dd5aeb32ed993bd56f2cf78b5c5ae0f2a57eb3808617c507d73dbf8563e320a479cb8e08

data/lib/boojs/version.rb

@@ -1,3 +1,3 @@
 module BooJS
-  VERSION = '0.0.30'
+  VERSION = '0.0.31'
 end

data/lib/boojs.rb

@@ -149,13 +149,6 @@ module BooJS
         puts p.pid
       end
 
-      #Tell stdout that we did restart
-      if pipe_restart
-        pipe_restart = false
-        puts "$__RESTART_OK__"
-        $stdout.flush
-      end
-
       loop do
         rr, _ = select([p, STDIN]); e = rr[0]
         #PhantomJS has written something
@@ -164,7 +157,17 @@ module BooJS
 
           if res =~ /STDIN_PORT/
             port = res.split(" ")[1].to_i
-            start_server(port, @input_sender_r)
+            unless @in_port
+              start_server(@input_sender_r)
+            end
+            @in_port = port
+
+            #Tell stdout that we did restart
+            if pipe_restart
+              pipe_restart = false
+              puts "$__RESTART_OK__"
+              $stdout.flush
+            end
           else
             puts res
             $stdout.flush
@@ -175,6 +178,8 @@ module BooJS
         if e == STDIN
           res = e.readline
           if res == "$__RESTART__\n"
+            #You must wait several seconds for fsync
+            sleep 2
             pipe_restart = true
             raise PipeRestart
           else
@@ -195,14 +200,14 @@ module BooJS
     exit 1
   end
 
-  def self.start_server port, pipe
+  def self.start_server pipe
     #Server that manages inputs
     Thread.new do
       begin
         loop do
           rr, __ = IO.select([@input_sender_r], []); e = rr[0]
 
-          uri = URI.parse("http://localhost:#{port}")
+          uri = URI.parse("http://localhost:#{@in_port}")
           Net::HTTP.post_form(uri, {:str => e.readline})
         end
       rescue Exception => e

data/spec/persist_spec.rb

@@ -51,17 +51,29 @@ RSpec.describe "Persist" do
 
   end
 
-  it "Does persist during restarts" do
+  it "Does persist localStorage during restarts, but not variables" do
     Open3.popen3 "ruby -Ilib ./bin/boojs" do |i, o, e, t|
       begin
-        i.puts "localStorage.setItem('foo', 'bar');"
+        secret = SecureRandom.hex
+        i.puts "localStorage.setItem('#{secret}', '#{secret}');"
+        i.puts "var x = 3;"
+        i.puts "console.log(typeof x === 'undefined');"
+        res = o.readline
+        expect(res).to eq("false\n")
+
+        #Now restart
         i.puts "$__RESTART__"
         res = o.readline
         expect(res).to eq("$__RESTART_OK__\n")
 
-        i.puts "console.log(localStorage.getItem('foo'))"
+        i.puts "console.log(localStorage.getItem('#{secret}'))"
         res = o.readline
-        expect(res).to eq("bar\n")
+        expect(res).to eq("#{secret}\n")
+
+        #X should no longer be set as we restart
+        i.puts "console.log(typeof x === 'undefined');"
+        res = o.readline
+        expect(res).to eq("true\n")
       ensure
         begin
           Process.kill :INT, t[:pid]

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: boojs
 version: !ruby/object:Gem::Version
-  version: 0.0.30
+  version: 0.0.31
 platform: ruby
 authors:
 - seo