bolt_rb 0.2.1 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 98c7fbaaad567ebdc0dee109df68cbb084cbaba4d532138b37e518e96893a23a
-  data.tar.gz: d5cbcffc369f50cf85211ec54ed77e2b3cefababccd4d52b2da0c624527de54f
+  metadata.gz: 4e218118e1e764bfe65750f32f82c4671e3c1f777dfe50420889ba51758c179f
+  data.tar.gz: a39610870555d4bade286a77431583c5944bfbad836854368776e6f236b9ffc7
 SHA512:
-  metadata.gz: 858c0cbf0ef13c010fa11594ffca9d5aa4949f0c4b8bc4d660b98faed05a76a0b65977f8bb7f9b6291a726d9f5d7f3527bd1876007d3e56a838f3a1109969aa1
-  data.tar.gz: 9f7a90ce248a549729598d80af6a3495ed491d45c9a25c7d0226b19dac6e8ae8be3b3d46afa3b3bbb78cbf7ace90e9a7181fde7a985b22f62aa28c23f203a058
+  metadata.gz: 4cdbcce81133b4e5fb4720ce93e82ac041f1ae84db8b2e17f3bf4bab3a98dafad0a00e26c6def32f51d1709b0641c46de9acc51982acd77a0f6ddd21f123fcb8
+  data.tar.gz: 35b7cc610cd8ade5ce7900f6ad2d55d548a68c318487388e24f65245619e1f1dc4340b87405de6f2576bd8a9b3b51dbd3606153b873f9b8973813999566f3d1a

data/lib/bolt_rb/socket_mode/client.rb

@@ -25,6 +25,8 @@ module BoltRb
     class Client
       SLACK_API_URL = 'https://slack.com/api/apps.connections.open'
       RECONNECT_DELAY = 5
+      # If no messages received in this many seconds, assume zombie socket
+      CONNECTION_STALE_THRESHOLD = 45
 
       # @return [String] The Slack app-level token
       attr_reader :app_token
@@ -42,6 +44,7 @@ module BoltRb
         @running = false
         @websocket = nil
         @message_handlers = []
+        @last_message_at = nil
       end
 
       # Registers a handler for incoming messages
@@ -104,11 +107,18 @@ module BoltRb
 
         while @running
           sleep 0.1
+
+          # Check for zombie socket - library reports open but no messages received
+          if connection_stale?
+            logger.warn "[SocketMode] Connection stale (no messages in #{CONNECTION_STALE_THRESHOLD}s), forcing reconnect"
+            force_reconnect
+          end
+
           reconnect_if_needed
 
           # Periodic heartbeat to confirm the loop is alive
           if Time.now - last_heartbeat >= heartbeat_interval
-            logger.debug "[SocketMode] Heartbeat: connected=#{connected?}, websocket_open=#{@websocket&.open?}"
+            logger.debug "[SocketMode] Heartbeat: connected=#{connected?}, websocket_open=#{@websocket&.open?}, last_msg=#{@last_message_at&.strftime('%H:%M:%S') || 'never'}"
             last_heartbeat = Time.now
           end
         end
@@ -128,6 +138,31 @@ module BoltRb
         connect_with_retry
       end
 
+      # Checks if the connection appears stale (zombie socket)
+      #
+      # Returns true if we have an apparently open connection but haven't
+      # received any messages in CONNECTION_STALE_THRESHOLD seconds
+      #
+      # @return [Boolean]
+      def connection_stale?
+        return false unless @websocket&.open?
+        return false if @last_message_at.nil?
+
+        Time.now - @last_message_at > CONNECTION_STALE_THRESHOLD
+      end
+
+      # Forces a reconnection by closing the current socket
+      #
+      # Used when we detect a zombie socket that reports open but isn't
+      # actually receiving messages
+      #
+      # @return [void]
+      def force_reconnect
+        @websocket&.close
+        @last_message_at = nil
+        # reconnect_if_needed will pick this up on the next loop iteration
+      end
+
       # Attempts to connect with retry logic
       #
       # @return [void]
@@ -207,6 +242,7 @@ module BoltRb
       #
       # @return [void]
       def handle_open
+        @last_message_at = Time.now
         logger.info '[SocketMode] Connected to Slack'
       end
 
@@ -215,10 +251,21 @@ module BoltRb
       # @param msg [WebSocket::Client::Simple::Message] The message
       # @return [void]
       def handle_message(msg)
-        logger.debug "[SocketMode] Raw message received: #{msg.data&.truncate(200) || '(nil)'}"
+        # Track message receipt for connection health monitoring
+        @last_message_at = Time.now
+
+        # Handle WebSocket protocol-level ping frames (Opcode 0x9)
+        # Must respond with pong frame echoing the same payload
+        if msg.type == :ping
+          handle_websocket_ping(msg.data)
+          return
+        end
+
+        raw_data = msg.data
+        logger.debug "[SocketMode] Raw message received (type=#{msg.type}): #{raw_data.nil? ? '(nil)' : raw_data[0, 200]}"
 
-        # Skip nil, empty, or non-JSON data (like WebSocket ping/pong frames)
-        return if msg.data.nil? || msg.data.empty? || !msg.data.start_with?('{')
+        # Skip nil, empty, or non-JSON data
+        return if raw_data.nil? || raw_data.empty? || !raw_data.start_with?('{')
 
         data = JSON.parse(msg.data)
 
@@ -264,7 +311,7 @@ module BoltRb
         logger.info "[SocketMode] WebSocket closed: #{event}"
       end
 
-      # Handles Slack Socket Mode ping message
+      # Handles Slack Socket Mode JSON ping message
       #
       # Responds with a pong message echoing back the num field
       # @param data [Hash] The ping message data
@@ -275,7 +322,21 @@ module BoltRb
         pong = { 'type' => 'pong' }
         pong['num'] = data['num'] if data['num']
         @websocket.send(pong.to_json)
-        logger.debug "[SocketMode] Responded to ping#{data['num'] ? " (num: #{data['num']})" : ''}"
+        logger.debug "[SocketMode] Sent pong response#{data['num'] ? " (num: #{data['num']})" : ''}"
+      end
+
+      # Handles WebSocket protocol-level ping frames (Opcode 0x9)
+      #
+      # Per WebSocket RFC 6455, we must respond with a pong frame (Opcode 0xA)
+      # that echoes back the exact payload from the ping frame.
+      # @param payload [String] The ping frame payload to echo back
+      # @return [void]
+      def handle_websocket_ping(payload)
+        return unless @websocket&.open?
+
+        logger.debug "[SocketMode] WebSocket ping received: '#{payload}'"
+        @websocket.send(payload, type: :pong)
+        logger.debug "[SocketMode] Sent WebSocket pong frame: '#{payload}'"
       end
 
       # Sends an acknowledgement for an event

data/lib/bolt_rb/version.rb

@@ -1,4 +1,4 @@
 # lib/bolt_rb/version.rb
 module BoltRb
-  VERSION = '0.2.1'
+  VERSION = '0.3.0'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: bolt_rb
 version: !ruby/object:Gem::Version
-  version: 0.2.1
+  version: 0.3.0
 platform: ruby
 authors:
 - Jon Whitcraft