bolognese 1.9.12 → 2.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 809d529a1ec99aa9653b7532586134862f896e46338e33fd97ea54da86dd0ed1
-  data.tar.gz: 85532735a718977631655c991d2c545a9974e091e5d656ab389b953b6d608165
+  metadata.gz: 23ccf372b59b7d9c8919ec7ad7137eef6e99512eed488977e847f938f389aa2f
+  data.tar.gz: 390e56023d57e637a52776a98dcd0bea4fa0acd8b8459ced05cbc6785f69fe0a
 SHA512:
-  metadata.gz: 013f57c1d908072881e9736c29e2e623cc0b311789450a20abeb0930f2dd754a9c09cf5b69cca8647b5561ace43dec33ffe6623424f5c1e79eb5f59defc74edc
-  data.tar.gz: 22e534387e3a579ded5f1d4da6fa46193e44169c5df2c6eb2a8a7f7fd3ba1218ecd59f74e540be67125a1dc6ab49cbf817dbaca430d26c3d3c06e2507fe127e1
+  metadata.gz: 3a7364a75d69846ada1320bc0e8954b72695216d2807ec39ab1694ac4d120d97806addb9ceed8b9da8c1eb06ae28740cf6d2c118cb76a05e15ca993bf81ad470
+  data.tar.gz: 6281527f6b312d398a96b9f1df9be55de991f6ac939417131633b24ddaa24741c3b86c3b2e4e73408ca1350e0b17addf9439ae30dff998bc6dda07e8c4459db7

data/.github/workflows/build.yml

@@ -5,33 +5,5 @@ on:
     branches:
       - "master"
 jobs:
-  build:
-    runs-on: ubuntu-latest
-    env:
-      SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}
-    steps:
-    - uses: actions/checkout@v2
-    - name: Set up Ruby 2.6
-      uses: actions/setup-ruby@v1
-      with:
-        ruby-version: 2.6.x
-
-    - name: Build and test
-      run: |
-        gem install bundler
-        bundle install
-        bundle exec rspec
-
-    - name: Publish code coverage
-      uses: paambaati/codeclimate-action@v2.7.4
-      env:
-        CC_TEST_REPORTER_ID: ${{ secrets.CC_TEST_REPORTER_ID }}
-
-    - name: Notify Slack
-      uses: adamkdean/simple-slack-notify@1.0.4
-      with:
-        channel: '#ops'
-        username: 'GitHub Actions'
-        color: 'good'
-        text: 'A new version of the bolognese gem has been built.'
-
+  ci:
+    uses: ./.github/workflows/ci.yml

data/.github/workflows/ci.yml

@@ -0,0 +1,22 @@
+name: Run Tests
+on:
+  workflow_call:
+
+jobs:
+  test:
+    strategy:
+      fail-fast: false
+      matrix:
+        ruby: ["2.6", "2.7", "3.0", "3.1"]
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@v3
+    - name: Set up Ruby ${{matrix.ruby}}
+      uses: ruby/setup-ruby@v1
+      with:
+        ruby-version: ${{matrix.ruby}}
+        bundler-cache: true
+
+    - name: Run tests
+      run: |
+        bundle exec rspec

data/.github/workflows/pull-request.yml

@@ -0,0 +1,9 @@
+name: Pull Request - Run Tests
+
+on:
+  pull_request:
+    branches:
+      - master
+jobs:
+  ci:
+    uses: ./.github/workflows/ci.yml

data/.github/workflows/release.yml

@@ -4,28 +4,21 @@ on:
   release:
     types: [published]
 jobs:
+  ci:
+    uses: ./.github/workflows/ci.yml
   build:
+    needs: ci
     runs-on: ubuntu-latest
-    env:
-      SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}
     steps:
-    - uses: actions/checkout@v2
+    - uses: actions/checkout@v3
     - name: Set up Ruby 2.6
-      uses: actions/setup-ruby@v1
+      uses: ruby/setup-ruby@v1
       with:
-        ruby-version: 2.6.x
+        ruby-version: "2.6"
 
-    - name: Build and test
+    - name: Build
       run: |
-        gem install bundler
         bundle install
-        bundle exec rspec spec
-
-    - name: Code Climate Test Reporter
-      uses: aktions/codeclimate-test-reporter@v1
-      with:
-        codeclimate-test-reporter-id: ${{ secrets.CC_TEST_REPORTER_ID }}
-        command: after-build
 
     - name: Publish to RubyGems
       run: |
@@ -37,11 +30,3 @@ jobs:
         gem push *.gem
       env:
         GEM_HOST_API_KEY: "${{secrets.RUBYGEMS_AUTH_TOKEN}}"
-
-    - name: Notify Slack
-      uses: adamkdean/simple-slack-notify@1.0.4
-      with:
-        channel: '#ops'
-        username: 'GitHub Actions'
-        color: 'good'
-        text: 'A new version of the bolognese gem has been released.'

data/.gitignore

@@ -57,3 +57,4 @@ coverage/
 !.env.travis
 
 .vscode
+.ruby-version

data/CHANGELOG.md

@@ -1,5 +1,76 @@
 # Changelog
 
+## [1.10.0](https://github.com/datacite/bolognese/tree/1.10.0) (2022-10-14)
+
+[Full Changelog](https://github.com/datacite/bolognese/compare/1.9.18...1.10.0)
+
+**Merged pull requests:**
+
+- Add DFG-to-FOS mappings utility function [\#147](https://github.com/datacite/bolognese/pull/147) ([jrhoads](https://github.com/jrhoads))
+- Test against multiple versions of ruby \(2.6, 2.7, 3.0, and 3.1\) [\#141](https://github.com/datacite/bolognese/pull/141) ([jrhoads](https://github.com/jrhoads))
+
+## [1.9.18](https://github.com/datacite/bolognese/tree/1.9.18) (2022-10-11)
+
+[Full Changelog](https://github.com/datacite/bolognese/compare/1.9.17...1.9.18)
+
+**Fixed bugs:**
+
+- Fix related items handling to not include elements when they are blank [\#140](https://github.com/datacite/bolognese/issues/140)
+- Related Items error out if RelatedItemIdentifier is nil [\#139](https://github.com/datacite/bolognese/issues/139)
+
+**Merged pull requests:**
+
+- bump version number [\#145](https://github.com/datacite/bolognese/pull/145) ([digitaldogsbody](https://github.com/digitaldogsbody))
+- Fix relatedItems handling [\#144](https://github.com/datacite/bolognese/pull/144) ([digitaldogsbody](https://github.com/digitaldogsbody))
+- Fixes normalization behavior that omitted non-URL funding identifiers when reading from DataCite XML. Adds normalization for Crossref Funder ID and ROR funderIdentifierTypes. [\#143](https://github.com/datacite/bolognese/pull/143) ([codycooperross](https://github.com/codycooperross))
+- Including a schemeURI with a nameIdentifier that is a URL will concat… [\#137](https://github.com/datacite/bolognese/pull/137) ([codycooperross](https://github.com/codycooperross))
+
+## [1.9.17](https://github.com/datacite/bolognese/tree/1.9.17) (2022-07-04)
+
+[Full Changelog](https://github.com/datacite/bolognese/compare/1.9.16...1.9.17)
+
+## [1.9.16](https://github.com/datacite/bolognese/tree/1.9.16) (2022-07-04)
+
+[Full Changelog](https://github.com/datacite/bolognese/compare/1.9.15...1.9.16)
+
+## [1.9.15](https://github.com/datacite/bolognese/tree/1.9.15) (2022-07-04)
+
+[Full Changelog](https://github.com/datacite/bolognese/compare/1.9.14...1.9.15)
+
+**Merged pull requests:**
+
+- Fix issue Bracco 521 [\#138](https://github.com/datacite/bolognese/pull/138) ([richardhallett](https://github.com/richardhallett))
+
+## [1.9.14](https://github.com/datacite/bolognese/tree/1.9.14) (2022-05-25)
+
+[Full Changelog](https://github.com/datacite/bolognese/compare/1.9.13...1.9.14)
+
+**Merged pull requests:**
+
+- Update critical dependencies [\#134](https://github.com/datacite/bolognese/pull/134) ([jrhoads](https://github.com/jrhoads))
+
+## [1.9.13](https://github.com/datacite/bolognese/tree/1.9.13) (2022-01-06)
+
+[Full Changelog](https://github.com/datacite/bolognese/compare/1.9.12...1.9.13)
+
+**Fixed bugs:**
+
+- Schema 4 RelatedItems does not allow relatedItem without relatedItemIdentifier [\#118](https://github.com/datacite/bolognese/issues/118)
+
+**Closed issues:**
+
+- How to use "bolognese help \[COMMAND\]"?  [\#129](https://github.com/datacite/bolognese/issues/129)
+- Move nokogiri dependency up to dependency \>= 1.12.5 [\#127](https://github.com/datacite/bolognese/issues/127)
+
+**Merged pull requests:**
+
+- update nokogiri to latest, including updating maremma [\#130](https://github.com/datacite/bolognese/pull/130) ([orangewolf](https://github.com/orangewolf))
+- mapping for DFG-to-OECD [\#125](https://github.com/datacite/bolognese/pull/125) ([kjgarza](https://github.com/kjgarza))
+
+## [1.9.12](https://github.com/datacite/bolognese/tree/1.9.12) (2021-08-19)
+
+[Full Changelog](https://github.com/datacite/bolognese/compare/1.9.11...1.9.12)
+
 ## [1.9.11](https://github.com/datacite/bolognese/tree/1.9.11) (2021-08-17)
 
 [Full Changelog](https://github.com/datacite/bolognese/compare/1.9.10...1.9.11)

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    bolognese (1.9.12)
+    bolognese (2.0.0)
       activesupport (>= 4.2.5)
       benchmark_methods (~> 0.7)
       bibtex-ruby (>= 5.1.0)
@@ -11,7 +11,6 @@ PATH
       concurrent-ruby (~> 1.1, >= 1.1.5)
       csl-styles (~> 1.0, >= 1.0.1.10)
       edtf (~> 3.0, >= 3.0.4)
-      faraday (~> 0.17.3)
       gender_detector (~> 0.1.2)
       iso8601 (~> 0.9.1)
       json-ld-preloaded (~> 3.1, >= 3.1.3)
@@ -19,7 +18,7 @@ PATH
       loofah (~> 2.0, >= 2.0.3)
       maremma (>= 4.9.4, < 5)
       namae (~> 1.0)
-      nokogiri (~> 1.11.2)
+      nokogiri (>= 1.13.2, < 1.14)
       oj (~> 3.10)
       oj_mimic_json (~> 1.0, >= 1.0.1)
       postrank-uri (~> 1.0, >= 1.0.18)
@@ -30,26 +29,26 @@ PATH
 GEM
   remote: https://rubygems.org/
   specs:
-    activesupport (6.1.4)
+    activesupport (6.1.7.3)
       concurrent-ruby (~> 1.0, >= 1.0.2)
       i18n (>= 1.6, < 2)
       minitest (>= 5.1)
       tzinfo (~> 2.0)
       zeitwerk (~> 2.3)
-    addressable (2.8.0)
-      public_suffix (>= 2.0.2, < 5.0)
-    amazing_print (1.3.0)
+    addressable (2.8.1)
+      public_suffix (>= 2.0.2, < 6.0)
     benchmark_methods (0.7)
     bibtex-ruby (6.0.0)
       latex-decode (~> 0.0)
     builder (3.2.4)
+    byebug (11.1.3)
     citeproc (1.0.10)
       namae (~> 1.0)
     citeproc-ruby (1.1.14)
       citeproc (~> 1.0, >= 1.0.9)
       csl (~> 1.6)
     colorize (0.8.1)
-    concurrent-ruby (1.1.9)
+    concurrent-ruby (1.2.2)
     crack (0.4.5)
       rexml
     crass (1.0.6)
@@ -58,76 +57,87 @@ GEM
       rexml
     csl-styles (1.0.1.11)
       csl (~> 1.0)
-    diff-lcs (1.4.4)
+    diff-lcs (1.5.0)
     docile (1.4.0)
-    ebnf (2.1.3)
-      amazing_print (~> 1.2)
+    ebnf (2.3.3)
       htmlentities (~> 4.3)
-      rdf (~> 3.1)
+      rdf (~> 3.2)
       scanf (~> 1.0)
-      sxp (~> 1.1)
-      unicode-types (~> 1.6)
-    edtf (3.0.6)
-      activesupport (>= 3.0, < 7.0)
+      sxp (~> 1.2)
+      unicode-types (~> 1.8)
+    edtf (3.1.1)
+      activesupport (>= 3.0, < 8.0)
     excon (0.71.1)
-    faraday (0.17.4)
-      multipart-post (>= 1.2, < 3)
+    faraday (2.7.6)
+      faraday-net_http (>= 2.0, < 3.1)
+      ruby2_keywords (>= 0.0.4)
     faraday-encoding (0.0.5)
       faraday
-    faraday_middleware (0.14.0)
-      faraday (>= 0.7.4, < 1.0)
+    faraday-excon (2.1.0)
+      excon (>= 0.27.4)
+      faraday (~> 2.0)
+    faraday-follow_redirects (0.3.0)
+      faraday (>= 1, < 3)
+    faraday-gzip (0.1.0)
+      faraday (>= 1.0)
+      zlib (~> 2.1)
+    faraday-multipart (1.0.4)
+      multipart-post (~> 2)
+    faraday-net_http (3.0.2)
     gender_detector (0.1.2)
       unicode_utils (>= 1.3.0)
     haml (5.2.2)
       temple (>= 0.8.0)
       tilt
-    hamster (3.0.0)
-      concurrent-ruby (~> 1.0)
     hashdiff (1.0.1)
     htmlentities (4.3.4)
-    i18n (1.8.10)
+    i18n (1.14.1)
       concurrent-ruby (~> 1.0)
     iso8601 (0.9.1)
-    json (2.5.1)
-    json-canonicalization (0.2.1)
-    json-ld (3.1.9)
+    json (2.6.2)
+    json-canonicalization (0.3.2)
+    json-ld (3.2.5)
       htmlentities (~> 4.3)
-      json-canonicalization (~> 0.2)
+      json-canonicalization (~> 0.3, >= 0.3.2)
       link_header (~> 0.0, >= 0.0.8)
-      multi_json (~> 1.14)
-      rack (~> 2.0)
-      rdf (~> 3.1)
-    json-ld-preloaded (3.1.6)
-      json-ld (~> 3.1)
-      rdf (~> 3.1)
+      multi_json (~> 1.15)
+      rack (>= 2.2, < 4)
+      rdf (~> 3.2, >= 3.2.10)
+    json-ld-preloaded (3.2.2)
+      json-ld (~> 3.2)
+      rdf (~> 3.2)
     jsonlint (0.3.0)
       oj (~> 3)
       optimist (~> 3)
-    latex-decode (0.3.2)
+    latex-decode (0.4.0)
     link_header (0.0.8)
-    loofah (2.12.0)
+    loofah (2.21.3)
       crass (~> 1.0.2)
-      nokogiri (>= 1.5.9)
-    maremma (4.9.5)
+      nokogiri (>= 1.12.0)
+    maremma (4.9.9)
       activesupport (>= 4.2.5)
       addressable (>= 2.3.6)
       builder (~> 3.2, >= 3.2.2)
       excon (~> 0.71.0)
-      faraday (~> 0.17.3)
-      faraday-encoding (~> 0.0.4)
-      faraday_middleware (~> 0.14.0)
-      nokogiri (~> 1.11.2)
+      faraday (>= 2.0)
+      faraday-encoding (~> 0.0.5)
+      faraday-excon (~> 2.1.0)
+      faraday-follow_redirects (~> 0.3.0)
+      faraday-gzip (~> 0.1.0)
+      faraday-multipart (~> 1.0.4)
+      nokogiri (>= 1.13.1, < 1.14.0)
       oj (>= 2.8.3)
       oj_mimic_json (~> 1.0, >= 1.0.1)
-    mini_portile2 (2.5.3)
-    minitest (5.14.4)
+    matrix (0.4.2)
+    mini_portile2 (2.8.0)
+    minitest (5.18.0)
     multi_json (1.15.0)
-    multipart-post (2.1.1)
+    multipart-post (2.3.0)
     namae (1.1.1)
-    nokogiri (1.11.7)
-      mini_portile2 (~> 2.5.0)
+    nokogiri (1.13.9)
+      mini_portile2 (~> 2.8.0)
       racc (~> 1.4)
-    oj (3.13.2)
+    oj (3.14.2)
     oj_mimic_json (1.0.1)
     optimist (3.0.1)
     postrank-uri (1.0.24)
@@ -135,74 +145,77 @@ GEM
       nokogiri (>= 1.8.0)
       public_suffix (>= 2.0.0, < 2.1)
     public_suffix (2.0.5)
-    racc (1.5.2)
-    rack (2.2.3)
+    racc (1.6.0)
+    rack (2.2.4)
     rack-test (0.8.3)
       rack (>= 1.0, < 3)
     rake (12.3.3)
-    rdf (3.1.15)
-      hamster (~> 3.0)
+    rdf (3.2.11)
       link_header (~> 0.0, >= 0.0.8)
-    rdf-aggregate-repo (3.1.0)
-      rdf (~> 3.1)
-    rdf-rdfa (3.1.3)
-      haml (~> 5.2)
+    rdf-aggregate-repo (3.2.1)
+      rdf (~> 3.2)
+    rdf-rdfa (3.2.2)
+      haml (>= 5.2, < 7)
       htmlentities (~> 4.3)
-      rdf (~> 3.1, >= 3.1.13)
-      rdf-aggregate-repo (~> 3.1)
-      rdf-vocab (~> 3.1, >= 3.1.11)
-      rdf-xsd (~> 3.1)
-    rdf-rdfxml (3.1.1)
+      rdf (~> 3.2)
+      rdf-aggregate-repo (~> 3.2)
+      rdf-vocab (~> 3.2)
+      rdf-xsd (~> 3.2)
+    rdf-rdfxml (3.2.1)
+      haml (~> 5.2)
       htmlentities (~> 4.3)
-      rdf (~> 3.1)
-      rdf-rdfa (~> 3.1)
-      rdf-xsd (~> 3.1)
-    rdf-turtle (3.1.3)
-      ebnf (~> 2.1)
-      rdf (~> 3.1, >= 3.1.8)
-    rdf-vocab (3.1.14)
-      rdf (~> 3.1, >= 3.1.12)
-    rdf-xsd (3.1.1)
-      rdf (~> 3.1)
+      rdf (~> 3.2)
+      rdf-rdfa (~> 3.2)
+      rdf-xsd (~> 3.2)
+    rdf-turtle (3.2.1)
+      ebnf (~> 2.3)
+      rdf (~> 3.2)
+    rdf-vocab (3.2.6)
+      rdf (~> 3.2, >= 3.2.4)
+    rdf-xsd (3.2.1)
+      rdf (~> 3.2)
       rexml (~> 3.2)
     rexml (3.2.5)
-    rspec (3.10.0)
-      rspec-core (~> 3.10.0)
-      rspec-expectations (~> 3.10.0)
-      rspec-mocks (~> 3.10.0)
-    rspec-core (3.10.1)
-      rspec-support (~> 3.10.0)
-    rspec-expectations (3.10.1)
+    rspec (3.11.0)
+      rspec-core (~> 3.11.0)
+      rspec-expectations (~> 3.11.0)
+      rspec-mocks (~> 3.11.0)
+    rspec-core (3.11.0)
+      rspec-support (~> 3.11.0)
+    rspec-expectations (3.11.1)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.10.0)
-    rspec-mocks (3.10.2)
+      rspec-support (~> 3.11.0)
+    rspec-mocks (3.11.1)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.10.0)
-    rspec-support (3.10.2)
+      rspec-support (~> 3.11.0)
+    rspec-support (3.11.1)
     rspec-xsd (0.1.0)
       nokogiri (~> 1.6)
       rspec (~> 3)
+    ruby2_keywords (0.0.5)
     scanf (1.0.0)
     simplecov (0.17.1)
       docile (~> 1.1)
       json (>= 1.8, < 3)
       simplecov-html (~> 0.10.0)
     simplecov-html (0.10.2)
-    sxp (1.1.0)
-      rdf (~> 3.1)
-    temple (0.8.2)
-    thor (1.1.0)
-    tilt (2.0.10)
-    tzinfo (2.0.4)
+    sxp (1.2.4)
+      matrix (~> 0.4)
+      rdf (~> 3.2)
+    temple (0.10.2)
+    thor (1.2.2)
+    tilt (2.2.0)
+    tzinfo (2.0.6)
       concurrent-ruby (~> 1.0)
-    unicode-types (1.6.0)
+    unicode-types (1.8.0)
     unicode_utils (1.4.0)
     vcr (3.0.3)
-    webmock (3.13.0)
-      addressable (>= 2.3.6)
+    webmock (3.18.1)
+      addressable (>= 2.8.0)
       crack (>= 0.3.2)
       hashdiff (>= 0.4.0, < 2.0.0)
-    zeitwerk (2.4.2)
+    zeitwerk (2.6.8)
+    zlib (2.1.1)
 
 PLATFORMS
   ruby
@@ -210,6 +223,7 @@ PLATFORMS
 DEPENDENCIES
   bolognese!
   bundler (>= 1.0)
+  byebug
   hashdiff (>= 1.0.0.beta1, < 2.0.0)
   rack-test (~> 0)
   rake (~> 12.0)
@@ -220,4 +234,4 @@ DEPENDENCIES
   webmock (~> 3.0, >= 3.0.1)
 
 BUNDLED WITH
-   2.2.26
+   2.4.20

data/bolognese.gemspec

@@ -13,12 +13,12 @@ Gem::Specification.new do |s|
   s.version       = Bolognese::VERSION
   s.extra_rdoc_files = ["README.md"]
   s.license       = 'MIT'
-  s.required_ruby_version = '~> 2.3'
+  s.required_ruby_version = ['>=2.3']
 
   # Declare dependencies here, rather than in the Gemfile
   s.add_dependency 'maremma', '>= 4.9.4', '< 5'
-  s.add_dependency 'faraday', '~> 0.17.3'
-  s.add_dependency 'nokogiri', '~> 1.11.2'
+  #s.add_dependency 'faraday', '~> 0.17.3'
+  s.add_dependency 'nokogiri', '>= 1.13.2', '< 1.14'
   s.add_dependency 'loofah', '~> 2.0', '>= 2.0.3'
   s.add_dependency 'builder', '~> 3.2', '>= 3.2.2'
   s.add_dependency 'activesupport', '>= 4.2.5'
@@ -49,6 +49,7 @@ Gem::Specification.new do |s|
   s.add_development_dependency 'webmock', '~> 3.0', '>= 3.0.1'
   s.add_development_dependency 'simplecov', '0.17.1'
   s.add_development_dependency 'hashdiff', ['>= 1.0.0.beta1', '< 2.0.0']
+  s.add_development_dependency 'byebug'
 
   s.require_paths = ["lib"]
   s.files       = `git ls-files`.split($/)

data/lib/bolognese/author_utils.rb

@@ -30,20 +30,21 @@ module Bolognese
       name_type = parse_attributes(author.fetch("creatorName", nil), content: "nameType", first: true) || parse_attributes(author.fetch("contributorName", nil), content: "nameType", first: true)
 
       name_identifiers = Array.wrap(author.fetch("nameIdentifier", nil)).map do |ni|
+        ni["__content__"] = ni["__content__"].strip
         if ni["nameIdentifierScheme"] == "ORCID"
           {
             "nameIdentifier" => normalize_orcid(ni["__content__"]),
             "schemeUri" => "https://orcid.org",
             "nameIdentifierScheme" => "ORCID" }.compact
-        elsif ni["schemeURI"].present?
+        elsif ni["nameIdentifierScheme"] == "ROR"
           {
-            "nameIdentifier" => ni["schemeURI"].to_s + ni["__content__"].to_s,
-            "schemeUri" => ni["schemeURI"].to_s,
-            "nameIdentifierScheme" => ni["nameIdentifierScheme"] }.compact
+            "nameIdentifier" => normalize_ror(ni["__content__"]),
+            "schemeUri" => "https://ror.org",
+            "nameIdentifierScheme" => "ROR" }.compact
         else
           {
             "nameIdentifier" => ni["__content__"],
-            "schemeUri" => nil,
+            "schemeUri" => ni.fetch("schemeURI", nil),
             "nameIdentifierScheme" => ni["nameIdentifierScheme"] }.compact
         end
       end.presence
@@ -144,16 +145,28 @@ module Bolognese
           affiliation_identifier_scheme = nil
           scheme_uri = nil
         else
+          scheme_uri = a["schemeURI"]
           if a["affiliationIdentifier"].present?
             affiliation_identifier = a["affiliationIdentifier"]
             if a["schemeURI"].present?
               schemeURI = a["schemeURI"].end_with?("/") ? a["schemeURI"] : a["schemeURI"] + "/"
             end
             affiliation_identifier = !affiliation_identifier.to_s.start_with?("https://") && schemeURI.present? ? normalize_id(schemeURI + affiliation_identifier) : normalize_id(affiliation_identifier)
+            # The normalize_id(affiliation_identifier) method currently discards affiliation identifiers that don't start with a URL, 
+            # for example: affiliation_identifier = "05bp8ka05".
+            # To address this issue, we are introducing the following change to handle such affiliation identifiers.
+            # when `normalize_id` method could not normalize, it returns nil, hence we have following condition
+            if affiliation_identifier.nil?
+              if a["affiliationIdentifierScheme"] == "ROR"
+                scheme_uri = "https://ror.org"
+                affiliation_identifier = normalize_ror(a["affiliationIdentifier"])
+              else
+                affiliation_identifier = a["affiliationIdentifier"]
+              end
+            end
           end
           name = a["__content__"].to_s.squish.presence
           affiliation_identifier_scheme = a["affiliationIdentifierScheme"]
-          scheme_uri = a["SchemeURI"]
         end
 
         { "name" => name,