bolognese 1.5.1 → 1.5.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 977d6a120d66d33a10188cfe1b5a36d898fed7ce44c8a4768cf87cba40ffe8a8
-  data.tar.gz: 70c0750b9a4f20bde9a97debf3645c6cddc3b0e46a33c330fa408e9014af8050
+  metadata.gz: 7413d213ae269aa084d46d5867668971910d9021a3fa452e168d62b8b1d33008
+  data.tar.gz: 309d2d0c3499a017c8f8db72f5fe20e915a2f7e63ea3621ffa933052d0d799d8
 SHA512:
-  metadata.gz: 97cd5c4e5c0bcee84083c74c6f17c7e7993a0bdf8e059527fce8d3e0cea13cb65d6bbe63df0c06621893268a8f6996952ecb82ed8243b7e31a91c7d35a9cc7e3
-  data.tar.gz: f33e063f45ea1bc1231bc8baba76cdfda740d604bc3895b5b178d18cea68c3f486c2be6abb46494c317df564116d7d5ae406c5e6c7fc2a652f0cb7556c9fe1fd
+  metadata.gz: 2bde36f5547716fc6df9ec63a2dce8ba9b2a09c7d6498ed2340a3a5ca4277453e53b60bec3237ca1d83ed170eb5e4b555d0388220e1af4f1a3455e69ac8e26c4
+  data.tar.gz: 3c5fe251b5ffb17b77f1353e7b853e9da8244383ab80e71bd00b65bb43ffb511651fbd92bf165cc9035f8009a89e6bb92a70662a6c199ca4a20fbdc4be2a60db

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    bolognese (1.5.1)
+    bolognese (1.5.2)
       activesupport (>= 4.2.5)
       benchmark_methods (~> 0.7)
       bibtex-ruby (>= 5.1.0)

data/lib/bolognese/readers/crossref_reader.rb

@@ -229,11 +229,14 @@ module Bolognese
         (Array.wrap(person) + Array.wrap(organization)).select { |a| a["contributor_role"] == contributor_role }.map do |a|
           name_identifiers = normalize_orcid(parse_attributes(a["ORCID"])).present? ? [{ "nameIdentifier" => normalize_orcid(parse_attributes(a["ORCID"])), "nameIdentifierScheme" => "ORCID", "schemeUri"=>"https://orcid.org" }] : nil
           if a["surname"].present? || a["given_name"].present? || name_identifiers.present?
+            given_name = parse_attributes(a["given_name"])
+            family_name = parse_attributes(a["surname"])
+
             { "nameType" => "Personal",
               "nameIdentifiers" => name_identifiers,
-              "name" => [a["surname"], a["given_name"]].join(", "),
-              "givenName" => a["given_name"],
-              "familyName" => a["surname"],
+              "name" => [family_name, given_name].compact.join(", "),
+              "givenName" => given_name,
+              "familyName" => family_name,
               "affiliation" => Array.wrap(a["affiliation"]).map { |a| { "name" => a }}.presence,
               "contributorType" => contributor_role == "editor" ? "Editor" : nil }.compact
           else

data/lib/bolognese/version.rb

@@ -1,3 +1,3 @@
 module Bolognese
-  VERSION = "1.5.1"
+  VERSION = "1.5.2"
 end

data/spec/fixtures/vcr_cassettes/Bolognese_Metadata/get_crossref_metadata/empty_given_name.yml

@@ -0,0 +1,91 @@
+---
+http_interactions:
+- request:
+    method: get
+    uri: https://doi.org/ra/10.1111
+    body:
+      encoding: US-ASCII
+      string: ''
+    headers:
+      User-Agent:
+      - Mozilla/5.0 (compatible; Maremma/4.6; mailto:info@datacite.org)
+      Accept:
+      - text/html,application/json,application/xml;q=0.9, text/plain;q=0.8,image/png,*/*;q=0.5
+  response:
+    status:
+      code: 200
+      message: ''
+    headers:
+      Date:
+      - Sun, 23 Feb 2020 15:32:53 GMT
+      Content-Type:
+      - application/json;charset=UTF-8
+      Connection:
+      - keep-alive
+      Set-Cookie:
+      - __cfduid=d85993bd559f395e4c4e2957534a5ca8c1582471973; expires=Tue, 24-Mar-20
+        15:32:53 GMT; path=/; domain=.doi.org; HttpOnly; SameSite=Lax; Secure
+      Cf-Cache-Status:
+      - DYNAMIC
+      Expect-Ct:
+      - max-age=604800, report-uri="https://report-uri.cloudflare.com/cdn-cgi/beacon/expect-ct"
+      Strict-Transport-Security:
+      - max-age=31536000; includeSubDomains; preload
+      Server:
+      - cloudflare
+      Cf-Ray:
+      - 569a414abfa397c6-FRA
+    body:
+      encoding: ASCII-8BIT
+      string: |-
+        [
+          {
+            "DOI": "10.1111",
+            "RA": "Crossref"
+          }
+        ]
+    http_version: 
+  recorded_at: Sun, 23 Feb 2020 15:32:53 GMT
+- request:
+    method: get
+    uri: https://api.crossref.org/works/10.1111/j.1865-1682.2010.01171.x/transform/application/vnd.crossref.unixsd+xml
+    body:
+      encoding: US-ASCII
+      string: ''
+    headers:
+      User-Agent:
+      - Mozilla/5.0 (compatible; Maremma/4.6; mailto:info@datacite.org)
+      Accept:
+      - text/xml
+  response:
+    status:
+      code: 200
+      message: OK
+    headers:
+      Link:
+      - <http://dx.doi.org/10.1111/j.1865-1682.2010.01171.x>; rel="canonical", <https://api.wiley.com/onlinelibrary/tdm/v1/articles/10.1111%2Fj.1865-1682.2010.01171.x>;
+        version="vor"; rel="item", <http://doi.wiley.com/10.1002/tdm_license_1.1>;
+        version="tdm"; rel="license"
+      Access-Control-Allow-Origin:
+      - "*"
+      Access-Control-Allow-Headers:
+      - X-Requested-With
+      Content-Length:
+      - '10180'
+      Server:
+      - http-kit
+      Date:
+      - Sun, 23 Feb 2020 15:32:54 GMT
+      X-Rate-Limit-Limit:
+      - '50'
+      X-Rate-Limit-Interval:
+      - 1s
+      Connection:
+      - close
+    body:
+      encoding: ASCII-8BIT
+      string: !binary |-
+        <?xml version="1.0" encoding="UTF-8"?>
<crossref_result xmlns="http://www.crossref.org/qrschema/3.0" version="3.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://www.crossref.org/qrschema/3.0 http://www.crossref.org/schemas/crossref_query_output3.0.xsd">
  <query_result>
    <head>
      <doi_batch_id>none</doi_batch_id>
    </head>
    <body>
      <query status="resolved">
        <doi type="journal_article">10.1111/j.1865-1682.2010.01171.x</doi>
        <crm-item name="publisher-name" type="string">Wiley</crm-item>
        <crm-item name="prefix-name" type="string">Wiley (Blackwell Publishing)</crm-item>
        <crm-item name="member-id" type="number">311</crm-item>
        <crm-item name="citation-id" type="number">44741199</crm-item>
        <crm-item name="journal-id" type="number">72345</crm-item>
        <crm-item name="deposit-timestamp" type="number">20101111220640437</crm-item>
        <crm-item name="owner-prefix" type="string">10.1111</crm-item>
        <crm-item name="last-update" type="date">2019-03-05T09:22:24Z</crm-item>
        <crm-item name="created" type="date">2010-09-29T06:03:26Z</crm-item>
        <crm-item name="citedby-count" type="number">11</crm-item>
        <doi_record>
          <crossref xmlns="http://www.crossref.org/xschema/1.1" xsi:schemaLocation="http://www.crossref.org/xschema/1.1 http://doi.crossref.org/schemas/unixref1.1.xsd">
            <journal>
              <journal_metadata language="en">
                <full_title>Transboundary and Emerging Diseases</full_title>
                <issn>18651674</issn>
              </journal_metadata>
              <journal_issue>
                <publication_date media_type="print">
                  <month>12</month>
                  <year>2010</year>
                </publication_date>
                <journal_volume>
                  <volume>57</volume>
                </journal_volume>
                <issue>6</issue>
                <doi_data>
                  <doi>10.1111/jva.2010.57.issue-6</doi>
                  <resource>http://doi.wiley.com/10.1111/jva.2010.57.issue-6</resource>
                </doi_data>
              </journal_issue>
              <journal_article publication_type="full_text">
                <titles>
                  <title>Serological Evidence of Brucella abortus Prevalence in Punjab Province, Pakistan - A Cross-Sectional Study</title>
                  <subtitle>Serological Evidence of B. abortus Prevalence in Punjab</subtitle>
                </titles>
                <contributors>
                  <person_name contributor_role="author" sequence="first">
                    <given_name>M.</given_name>
                    <surname>Abubakar</surname>
                  </person_name>
                  <person_name contributor_role="author" sequence="additional">
                    <given_name>M.</given_name>
                    <surname>Javed Arshed</surname>
                  </person_name>
                  <person_name contributor_role="author" sequence="additional">
                    <given_name>M.</given_name>
                    <surname>Hussain</surname>
                  </person_name>
                  <person_name contributor_role="author" sequence="additional">
                    <given_name> </given_name>
                    <surname>Ehtisham-ul-Haq</surname>
                  </person_name>
                  <person_name contributor_role="author" sequence="additional">
                    <given_name>Q.</given_name>
                    <surname>Ali</surname>
                  </person_name>
                </contributors>
                <publication_date media_type="print">
                  <month>12</month>
                  <year>2010</year>
                </publication_date>
                <publication_date media_type="online">
                  <month>09</month>
                  <day>29</day>
                  <year>2010</year>
                </publication_date>
                <pages>
                  <first_page>443</first_page>
                  <last_page>447</last_page>
                </pages>
                <ai:program xmlns:ai="http://www.crossref.org/AccessIndicators.xsd" name="AccessIndicators">
                  <ai:license_ref applies_to="tdm" start_date="2015-09-01">http://doi.wiley.com/10.1002/tdm_license_1.1</ai:license_ref>
                </ai:program>
                <doi_data>
                  <doi>10.1111/j.1865-1682.2010.01171.x</doi>
                  <resource>http://doi.wiley.com/10.1111/j.1865-1682.2010.01171.x</resource>
                  <collection property="text-mining">
                    <item>
                      <resource content_version="vor">https://api.wiley.com/onlinelibrary/tdm/v1/articles/10.1111%2Fj.1865-1682.2010.01171.x</resource>
                    </item>
                  </collection>
                </doi_data>
                <citation_list>
                  <citation key="10.1111/j.1865-1682.2010.01171.x-BIB1|cit1">
                    <author>Al-Majali</author>
                    <cYear>2009</cYear>
                    <doi provider="crossref">10.4142/jvs.2009.10.1.61</doi>
                    <article_title>Sero-prevalence and risk factors for bovine brucellosis in Jordan</article_title>
                    <journal_title>J. Vet. Sci.</journal_title>
                    <volume>10</volume>
                    <first_page>61</first_page>
                  </citation>
                  <citation key="10.1111/j.1865-1682.2010.01171.x-BIB2|cit2">
                    <author>Al-Sous</author>
                    <cYear>2004</cYear>
                    <article_title>Neurobrucellosis: clinical and neuroimaging correlation</article_title>
                    <journal_title>AJNR Am. J. Neuroradiol.</journal_title>
                    <volume>25</volume>
                    <first_page>395</first_page>
                  </citation>
                  <citation key="10.1111/j.1865-1682.2010.01171.x-BIB12|cit3">
                    <author>Amen</author>
                    <cYear>2005</cYear>
                    <doi provider="crossref">10.4142/jvs.2005.6.3.223</doi>
                    <article_title>Prevalence of Brucella antibodies in sera of cows in Bangladesh</article_title>
                    <journal_title>J. Vet. Sci.</journal_title>
                    <volume>6</volume>
                    <first_page>223</first_page>
                  </citation>
                  <citation key="10.1111/j.1865-1682.2010.01171.x-BIB3|cit4">
                    <author>Brahmabhatt</author>
                    <cYear>2009</cYear>
                    <article_title>Seroprevalence of brucella spp. in buffaloes in the central Gujarat region of India</article_title>
                    <journal_title>Buffalo Bull.</journal_title>
                    <volume>28</volume>
                    <first_page>73</first_page>
                  </citation>
                  <citation key="10.1111/j.1865-1682.2010.01171.x-BIB4|cit5">
                    <author>Comerci</author>
                    <cYear>2006</cYear>
                    <doi provider="crossref">10.1128/JB.188.5.1929-1934.2006</doi>
                    <article_title>Brucella abortus synthesizes phosphatidylcholine from choline provided by the host</article_title>
                    <journal_title>J. Bacteriol.</journal_title>
                    <volume>188</volume>
                    <first_page>1929</first_page>
                  </citation>
                  <citation key="10.1111/j.1865-1682.2010.01171.x-BIB5|cit6">
                    <author>Hussain</author>
                    <cYear>2008</cYear>
                    <article_title>Seroprevalence of Brucellosis in human, cattle, and buffalo populations in Pakistan</article_title>
                    <journal_title>Turk. J. Vet. Ani. Sci.</journal_title>
                    <volume>32</volume>
                    <first_page>315</first_page>
                  </citation>
                  <citation key="10.1111/j.1865-1682.2010.01171.x-BIB7|cit7">
                    <author>Nasir</author>
                    <cYear>2004</cYear>
                    <article_title>Prevalence of brucellosis in animals at government and private farms in Punjab</article_title>
                    <journal_title>Pak. Vet. J.</journal_title>
                    <volume>24</volume>
                    <first_page>144</first_page>
                  </citation>
                  <citation key="10.1111/j.1865-1682.2010.01171.x-BIB8|cit8">
                    <author>Nielsen</author>
                    <cYear>1994</cYear>
                    <article_title>Advances in the diagnosis of bovine brucellosis: use of enzyme immunoassays</article_title>
                    <journal_title>Genet. Eng. Biotechnol.</journal_title>
                    <volume>14</volume>
                    <first_page>25</first_page>
                  </citation>
                  <citation key="10.1111/j.1865-1682.2010.01171.x-BIB9|cit9">
                    <author>Pappas</author>
                    <cYear>2006</cYear>
                    <doi provider="crossref">10.1016/S1473-3099(06)70382-6</doi>
                    <article_title>The new global map of human brucellosis</article_title>
                    <journal_title>Lancet Infect. Dis.</journal_title>
                    <volume>6</volume>
                    <first_page>91</first_page>
                  </citation>
                  <citation key="10.1111/j.1865-1682.2010.01171.x-BIB10|cit10">
                    <author>Sewell</author>
                    <cYear>1990</cYear>
                    <volume_title>Animal Diseases in the Tropics</volume_title>
                  </citation>
                </citation_list>
              </journal_article>
            </journal>
          </crossref>
        </doi_record>
      </query>
    </body>
  </query_result>
</crossref_result>
+    http_version: 
+  recorded_at: Sun, 23 Feb 2020 15:32:54 GMT
+recorded_with: VCR 3.0.3

data/spec/readers/crossref_reader_spec.rb

@@ -501,6 +501,22 @@ describe Bolognese::Metadata, vcr: true do
       expect(subject.date_registered).to eq("2017-05-24T02:10:18Z")
     end
 
+    it "empty given name" do
+      input = "https://doi.org/10.1111/J.1865-1682.2010.01171.X"
+      subject = Bolognese::Metadata.new(input: input)
+      expect(subject.valid?).to be true
+      expect(subject.identifiers).to eq([{"identifier"=>"https://doi.org/10.1111/j.1865-1682.2010.01171.x", "identifierType"=>"DOI"}])
+      expect(subject.url).to eq("http://doi.wiley.com/10.1111/j.1865-1682.2010.01171.x")
+      expect(subject.types).to eq("bibtex"=>"article", "citeproc"=>"article-journal", "resourceType"=>"JournalArticle", "resourceTypeGeneral"=>"Text", "ris"=>"JOUR", "schemaOrg"=>"ScholarlyArticle")
+      expect(subject.creators.length).to eq(5)
+      expect(subject.creators[3]).to eq("familyName"=>"Ehtisham-ul-Haq", "givenName"=>" ", "name"=>"Ehtisham-ul-Haq,  ", "nameType"=>"Personal")
+      expect(subject.titles).to eq([{"title"=>"Serological Evidence of Brucella abortus Prevalence in Punjab Province, Pakistan - A Cross-Sectional Study"}])
+      expect(subject.rights_list).to eq([{"rightsUri"=>"http://doi.wiley.com/10.1002/tdm_license_1.1"}])
+      expect(subject.dates).to eq([{"date"=>"2010-12", "dateType"=>"Issued"}, {"date"=>"2019-03-05T09:22:24Z", "dateType"=>"Updated"}])
+      expect(subject.publication_year).to eq("2010")
+      expect(subject.publisher).to eq("Wiley")
+    end
+
     it "journal article with" do
       input = "https://doi.org/10.1111/nph.14619"
       subject = Bolognese::Metadata.new(input: input)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: bolognese
 version: !ruby/object:Gem::Version
-  version: 1.5.1
+  version: 1.5.2
 platform: ruby
 authors:
 - Martin Fenner
@@ -887,6 +887,7 @@ files:
 - spec/fixtures/vcr_cassettes/Bolognese_Metadata/get_crossref_metadata/dataset.yml
 - spec/fixtures/vcr_cassettes/Bolognese_Metadata/get_crossref_metadata/dataset_usda.yml
 - spec/fixtures/vcr_cassettes/Bolognese_Metadata/get_crossref_metadata/date_in_future.yml
+- spec/fixtures/vcr_cassettes/Bolognese_Metadata/get_crossref_metadata/empty_given_name.yml
 - spec/fixtures/vcr_cassettes/Bolognese_Metadata/get_crossref_metadata/error_unknown.yml
 - spec/fixtures/vcr_cassettes/Bolognese_Metadata/get_crossref_metadata/jj.yml
 - spec/fixtures/vcr_cassettes/Bolognese_Metadata/get_crossref_metadata/journal_article.yml