bogus 0.1.5 → 0.1.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 5692979cf19268250f0bd23067c79beca39210f9
-  data.tar.gz: eace904b3205850ab8a3359453d4fe1236e120fe
+  metadata.gz: 4056fb1f5ddc7c47b6e82b777c0d220caff62b21
+  data.tar.gz: 3cc4493f6798d729ddc5b14bc9460a1c35632b88
 SHA512:
-  metadata.gz: f8be32e8fbc29928cc5f517c10bf6602dee35910e0c2768d83ec0db7c8a62bdd993cc84482aec9d26dd4ecce2f096f80ac0c9bc8ed2c7f6092bf0e570c7fcf54
-  data.tar.gz: b12ed7d4b58170ff5f7180f559c054817ff7b84476808355d822b7d5270a34083d77f10996036d17d5a45f6da2da80b4e7e4de065e32ab65f244960b1fec43f5
+  metadata.gz: c010976d4a8cdf3a2222f467bf41db819bea5178107c8fee3f907cb3648942c15e37f255d49d3bf0d367156a2ff716dff1f56705dbe727ca2571eaeb6702469b
+  data.tar.gz: bb1aa720bdd300d3b2ecc6b471f62673ed702deec6159e0e53658f2e3d6a33d5cfc55bdbc60b7418cc12f174e8eda0ac44f823701a85a3efa7657bb43981c0dd

data/.rspec

@@ -0,0 +1 @@
+--color

data/.travis.yml

@@ -4,4 +4,5 @@ rvm:
   - 2.0
   - 2.1.1
   - jruby-19mode
+  - rbx
 script: bundle exec rspec spec && bundle exec cucumber --tag ~@wip

data/Gemfile

@@ -2,5 +2,3 @@ source "http://rubygems.org"
 
 # Specify your gem's dependencies in bogus.gemspec
 gemspec
-
-gem 'minitest', require: false

data/Guardfile

@@ -1,7 +1,7 @@
 # A sample Guardfile
 # More info at https://github.com/guard/guard#readme
 
-guard 'rspec', all_after_pass: true, all_on_start: true do
+guard 'rspec', cmd: 'bundle exec rspec', all_after_pass: true, all_on_start: true do
   watch(%r{^spec/.+_spec\.rb$})
   watch(%r{^lib/(.+)\.rb$})     { |m| "spec/#{m[1]}_spec.rb" }
   watch('spec/spec_helper.rb')  { "spec" }

data/bogus.gemspec

@@ -32,9 +32,9 @@ Gem::Specification.new do |s|
   s.add_development_dependency 'guard-ctags-bundler'
   s.add_development_dependency 'growl'
   s.add_development_dependency 'libnotify'
-  s.add_development_dependency 'rr'
   s.add_development_dependency 'relish'
   s.add_development_dependency 'coveralls'
+  s.add_development_dependency 'wwtd'
 
   s.add_development_dependency 'activerecord', '>= 3', '< 5'
   s.add_development_dependency 'activerecord-nulldb-adapter'

data/features/changelog.md

@@ -1,3 +1,11 @@
+## 0.1.6
+
+- Removed dependency on Coveralls::SimpleCov::Formatter (thanks to Ken Dreyer)
+- Made all tests pass on Rubinious
+- Updated tests to use RSpec Mocks instead of RR in unit tests
+- Updated tests to use RSpec 3
+- Fixed described_class in RSpec 3.*
+
 ## 0.1.5
 
 - Made it possible to use fake objects in case/when statements (override ===)

data/features/contract_tests/contract_tests_mocks.feature

@@ -77,7 +77,7 @@ Feature: Contract tests with mocks
 
         library.checkout("Moby Dick")
 
-        expect(library.has_book?("Moby Dick")).to be_false
+        expect(library.has_book?("Moby Dick")).to be(false)
       end
     end
     """
@@ -95,11 +95,11 @@ Feature: Contract tests with mocks
       it "allows checking out books that are in the inventory" do
         library.return("Moby Dick")
 
-        expect(library.has_book?("Moby Dick")).to be_true
+        expect(library.has_book?("Moby Dick")).to be(true)
       end
 
       it "does not allow checking out unavailable books" do
-        expect(library.has_book?("Moby Dick")).to be_false
+        expect(library.has_book?("Moby Dick")).to be(false)
       end
 
       it "marks books as unavailable after they are checked out" do
@@ -107,7 +107,7 @@ Feature: Contract tests with mocks
 
         library.checkout("Moby Dick")
 
-        expect(library.has_book?("Moby Dick")).to be_false
+        expect(library.has_book?("Moby Dick")).to be(false)
       end
     end
     """

data/features/contract_tests/contract_tests_stubs.feature

@@ -90,7 +90,7 @@ Feature: Contract tests with stubs
 
         library.checkout("Moby Dick")
 
-        expect(library.has_book?("Moby Dick")).to be_false
+        expect(library.has_book?("Moby Dick")).to be(false)
       end
     end
     """
@@ -108,11 +108,11 @@ Feature: Contract tests with stubs
       it "allows checking out books that are in the inventory" do
         library.return("Moby Dick")
 
-        expect(library.has_book?("Moby Dick")).to be_true
+        expect(library.has_book?("Moby Dick")).to be(true)
       end
 
       it "does not allow checking out unavailable books" do
-        expect(library.has_book?("Moby Dick")).to be_false
+        expect(library.has_book?("Moby Dick")).to be(false)
       end
 
       it "marks books as unavailable after they are checked out" do
@@ -120,7 +120,7 @@ Feature: Contract tests with stubs
 
         library.checkout("Moby Dick")
 
-        expect(library.has_book?("Moby Dick")).to be_false
+        expect(library.has_book?("Moby Dick")).to be(false)
       end
     end
     """

data/features/contract_tests/custom_overwritten_class.feature

@@ -95,11 +95,11 @@ Feature: Customizing the overwritten class
       it "allows checking out books that are in the inventory" do
         library.return("Moby Dick")
 
-        expect(library.has_book?("Moby Dick")).to be_true
+        expect(library.has_book?("Moby Dick")).to be(true)
       end
 
       it "does not allow checking out unavailable books" do
-        expect(library.has_book?("Moby Dick")).to be_false
+        expect(library.has_book?("Moby Dick")).to be(false)
       end
 
       it "marks books as unavailable after they are checked out" do
@@ -107,7 +107,7 @@ Feature: Customizing the overwritten class
 
         library.checkout("Moby Dick")
 
-        expect(library.has_book?("Moby Dick")).to be_false
+        expect(library.has_book?("Moby Dick")).to be(false)
       end
     end
     """

data/features/fakes/fake_objects.feature

@@ -60,7 +60,7 @@ Feature: Faking existing classes
       fake(:library)
 
       it "does something" do
-        expect(Student.learn(library)).to be_true
+        expect(Student.learn(library)).to be(true)
       end
     end
     """
@@ -140,7 +140,7 @@ Feature: Faking existing classes
       fake(:library)
 
       it "is identified as Library" do
-        expect(library?(library)).to be_true
+        expect(library?(library)).to be(true)
       end
     end
     """

data/lib/bogus/core_ext.rb

@@ -1,5 +1,5 @@
 # This monkey patch should not break Ruby compatibility
-# but is necessary because MRI, insead of calling object.kind_of?(module),
+# but is necessary because MRI, instead of calling object.kind_of?(module),
 # calls the C function, which implements kind_of. This makes
 # using fake objects in switch cases produce unexpected results:
 #
@@ -15,7 +15,11 @@
 class Module
   # don't warn about redefining === method
   Bogus::Support.supress_warnings do
+    alias :__trequals__ :===
+
     def ===(object)
+      # BasicObjects do not have kind_of? method
+      return __trequals__(object) unless Object.__trequals__(object)
       object.kind_of?(self)
     end
   end

data/lib/bogus/rspec/syntax.rb

@@ -8,6 +8,9 @@ module Bogus
     def_delegators :context, :before, :after, :described_class
 
     def described_class=(value)
+      # for new RSpec (> 3.0)
+      context.metadata[:described_class] = value
+      # for old RSpec (< 3.0)
       context.example.metadata[:example_group][:described_class] = value
     end
 

data/lib/bogus/version.rb

@@ -1,3 +1,3 @@
 module Bogus
-  VERSION = "0.1.5"
+  VERSION = "0.1.6"
 end

data/spec/bogus/bugs/rbx_instance_eval_bug_spec.rb

@@ -0,0 +1,20 @@
+require 'spec_helper'
+
+describe Bogus do
+  class SampleForRbxInstanceEval < BasicObject
+    def x
+      3
+    end
+  end
+
+  it "doesn't break #instance_eval on RBX" do
+    result = SampleForRbxInstanceEval.new.instance_eval{x}
+    expect(result).to eq(3)
+  end
+
+  it "does not break === with the monkey patch" do
+    expect(SampleForRbxInstanceEval === SampleForRbxInstanceEval.new).to be(true)
+    expect(BasicObject === SampleForRbxInstanceEval.new).to be(true)
+    expect(Bogus === SampleForRbxInstanceEval.new).to be(false)
+  end
+end

data/spec/bogus/bugs/rbx_jruby_stub_on_class_spec.rb

@@ -0,0 +1,45 @@
+require 'spec_helper'
+
+class ExampleForRbxJRubyBug
+  def self.bar(argument)
+    argument
+  end
+
+  def self.foo(argument)
+    argument
+  end
+
+  def initialize(*args)
+    args
+  end
+end
+
+describe ExampleForRbxJRubyBug do
+  before do
+    extend Bogus::MockingDSL
+  end
+
+  context '.bar' do
+    specify 'stubbing class twice in example' do
+      stub(ExampleForRbxJRubyBug).bar('same_argument')
+      stub(ExampleForRbxJRubyBug).bar('same_argument')
+    end
+  end
+
+  context '.foo' do
+    specify 'stubbing class once in example' do
+      stub(ExampleForRbxJRubyBug).foo('same_argument')
+    end
+
+    specify 'stubbing class once in another example' do
+      stub(ExampleForRbxJRubyBug).foo('same_argument')
+    end
+  end
+
+  context '.new' do
+    before  { stub(ExampleForRbxJRubyBug).new(any_args) }
+
+    specify { ExampleForRbxJRubyBug.new(1, 2, 3) }
+    specify { ExampleForRbxJRubyBug.new(1, 2, 3) }
+  end
+end

data/spec/bogus/contracts/adds_contract_verification_spec.rb

@@ -37,7 +37,7 @@ describe Bogus::AddsContractVerification do
     it "verifies the contract in after_suite" do
       syntax.run_after_suite
 
-      expect(verifies_contracts).to have_received.verify(:some_fake)
+      expect(verifies_contracts).to have_received(:verify).with(:some_fake)
     end
   end
 
@@ -49,17 +49,17 @@ describe Bogus::AddsContractVerification do
 
   let(:overwritten_class) { :the_overwritten_class }
 
-  let(:adds_recording) { stub }
-  let(:verifies_contracts) { stub }
-  let(:converts_name_to_class) { stub }
+  let(:adds_recording) { double }
+  let(:verifies_contracts) { double }
+  let(:converts_name_to_class) { double }
   let(:syntax) { FakeSyntax.new(described_class) }
 
   let(:adds_contract_verification) { isolate(Bogus::AddsContractVerification) }
 
   before do
-    stub(adds_recording).add { overwritten_class }
-    stub(verifies_contracts).verify
-    stub(converts_name_to_class).convert { ClassGuessedFromFakeName }
+    allow(adds_recording).to receive(:add) { overwritten_class }
+    allow(verifies_contracts).to receive(:verify)
+    allow(converts_name_to_class).to receive(:convert) { ClassGuessedFromFakeName }
   end
 
   context "with described_class" do
@@ -87,7 +87,7 @@ describe Bogus::AddsContractVerification do
     it "adds recording to described_class" do
       syntax.run_before
 
-      expect(adds_recording).to have_received.add(:some_fake, SomeClass)
+      expect(adds_recording).to have_received(:add).with(:some_fake, SomeClass)
     end
   end
 
@@ -119,7 +119,7 @@ describe Bogus::AddsContractVerification do
     it "adds recording to custom class" do
       syntax.run_before
 
-      expect(adds_recording).to have_received.add(:some_fake, ClassToOverwrite)
+      expect(adds_recording).to have_received(:add).with(:some_fake, ClassToOverwrite)
     end
   end
 
@@ -148,7 +148,7 @@ describe Bogus::AddsContractVerification do
     it "adds recording to class based on fake name" do
       syntax.run_before
 
-      expect(adds_recording).to have_received.add(:some_fake, ClassGuessedFromFakeName)
+      expect(adds_recording).to have_received(:add).with(:some_fake, ClassGuessedFromFakeName)
     end
   end
 end

data/spec/bogus/contracts/adds_recording_spec.rb

@@ -9,16 +9,16 @@ describe Bogus::AddsRecording do
     end
   end
 
-  let(:create_proxy_class) { stub }
-  let(:overwrites_classes) { stub }
-  let(:overwritten_classes) { stub }
+  let(:create_proxy_class) { double }
+  let(:overwrites_classes) { double }
+  let(:overwritten_classes) { double }
 
   let(:adds_recording) { isolate(Bogus::AddsRecording) }
 
   before do
-    stub(create_proxy_class).call { Object }
-    stub(overwrites_classes).overwrite
-    stub(overwritten_classes).add
+    allow(create_proxy_class).to receive(:call) { Object }
+    allow(overwrites_classes).to receive(:overwrite)
+    allow(overwritten_classes).to receive(:add)
   end
 
   before do
@@ -26,15 +26,15 @@ describe Bogus::AddsRecording do
   end
 
   it "creates the proxy" do
-    expect(create_proxy_class).to have_received.call(:library, SampleModule::Library)
+    expect(create_proxy_class).to have_received(:call).with(:library, SampleModule::Library)
   end
 
   it "swaps the classes" do
-    expect(overwrites_classes).to have_received.overwrite('SampleModule::Library', Object)
+    expect(overwrites_classes).to have_received(:overwrite).with('SampleModule::Library', Object)
   end
 
   it "records the overwritten class, so that it can be later restored" do
-    expect(overwritten_classes).to have_received.add("SampleModule::Library", SampleModule::Library)
+    expect(overwritten_classes).to have_received(:add).with("SampleModule::Library", SampleModule::Library)
   end
 
   it "returns the proxy class" do

data/spec/bogus/contracts/interactions_repository_spec.rb

@@ -10,43 +10,43 @@ describe Bogus::InteractionsRepository do
   it "considers the interaction recorded if it was recorded previously" do
     interactions_repository.record(:foo, :bar, 1, 2, 3)
 
-    expect(recorded?(:foo, :bar, 1, 2, 3)).to be_true
+    expect(recorded?(:foo, :bar, 1, 2, 3)).to be(true)
   end
 
   it "considers the interaction recorded if it returned the same value as passed block" do
     interactions_repository.record(:foo, :bar) { "a result" }
     interaction = Bogus::Interaction.new(:bar, []) { "a result" }
 
-    expect(interactions_repository.recorded?(:foo, interaction)).to be_true
+    expect(interactions_repository.recorded?(:foo, interaction)).to be(true)
   end
 
   it "does not consider any interactions recorded prior to any recordings" do
-    expect(recorded?(:foo, :bar, 1)).to be_false
+    expect(recorded?(:foo, :bar, 1)).to be(false)
   end
 
   it "does not consider the interaction recorded with a different fake name"  do
     interactions_repository.record(:baz, :bar, 1)
 
-    expect(recorded?(:foo, :bar, 1)).to be_false
+    expect(recorded?(:foo, :bar, 1)).to be(false)
   end
 
   it "does not consider the interaction recorded with a different method name" do
     interactions_repository.record(:foo, :baz, 1)
 
-    expect(recorded?(:foo, :bar, 1)).to be_false
+    expect(recorded?(:foo, :bar, 1)).to be(false)
   end
 
   it "does not consider the interaction recorded with different method arguments" do
     interactions_repository.record(:foo, :bar, 1, 2)
 
-    expect(recorded?(:foo, :bar, 1)).to be_false
+    expect(recorded?(:foo, :bar, 1)).to be(false)
   end
 
   it "returns a list of interactions for given fake" do
     interactions_repository.record(:foo, :bar, 1, 2)
 
     interactions = interactions_repository.for_fake(:foo)
-    expect(interactions).to have(1).item
+    expect(interactions.size).to eq(1)
     expect(interactions.first.method).to eq :bar
     expect(interactions.first.args).to eq [1, 2]
   end
@@ -54,36 +54,36 @@ describe Bogus::InteractionsRepository do
   it "ignores arguments if the checked interaction has any_args" do
     interactions_repository.record(:foo, :bar, 1)
 
-    expect(recorded?(:foo, :bar, Bogus::AnyArgs)).to be_true
+    expect(recorded?(:foo, :bar, Bogus::AnyArgs)).to be(true)
   end
 
   it "takes method name into account when matching interaction with wildcard arguments" do
     interactions_repository.record(:foo, :baz, 1)
 
-    expect(recorded?(:foo, :bar, Bogus::AnyArgs)).to be_false
+    expect(recorded?(:foo, :bar, Bogus::AnyArgs)).to be(false)
   end
 
   it "ignores arguments if the recorded interaction was recorded with wildcard argument" do
     interactions_repository.record(:foo, :bar, 1, 2)
 
-    expect(recorded?(:foo, :bar, 1, Bogus::Anything)).to be_true
+    expect(recorded?(:foo, :bar, 1, Bogus::Anything)).to be(true)
   end
 
   it "takes other arguments into account when matching interactions with wildcards" do
     interactions_repository.record(:foo, :bar, 1, 2)
 
-    expect(recorded?(:foo, :bar, 2, Bogus::Anything)).to be_false
+    expect(recorded?(:foo, :bar, 2, Bogus::Anything)).to be(false)
   end
 
   it "ignores arguments if the checked interaction has any_args" do
     interactions_repository.record(:foo, :bar, 1, 2)
 
-    expect(recorded?(:foo, :bar, 1, Bogus::Anything)).to be_true
+    expect(recorded?(:foo, :bar, 1, Bogus::Anything)).to be(true)
   end
 
   it "takes method name into account when matching interaction with wildcard arguments" do
     interactions_repository.record(:foo, :baz, 1, 2)
 
-    expect(recorded?(:foo, :bar, 1, Bogus::Anything)).to be_false
+    expect(recorded?(:foo, :bar, 1, Bogus::Anything)).to be(false)
   end
 end