bogus 0.1.0 → 0.1.1

data/features/fakes/duck_types.feature

@@ -21,7 +21,7 @@ Feature: Faking duck types
       end
 
   Background:
-    Given a file named "foo.rb" with:
+    Given a file named "loggers.rb" with:
     """ruby
     class DatabaseLogger
       def error(message); end
@@ -56,6 +56,8 @@ Feature: Faking duck types
   Scenario: Copying instance methods
     Then spec file with following content should pass:
     """ruby
+    require_relative 'loggers'
+
     describe "make_duck" do
       let(:duck) { make_duck(DatabaseLogger, NetworkLogger, 
                             DevNullLogger) }
@@ -94,6 +96,8 @@ Feature: Faking duck types
   Scenario: Faking duck types
     Then spec file with following content should pass:
     """ruby
+    require_relative 'loggers'
+
     describe "fake with multiple classes" do
       fake(:logger) { [DatabaseLogger, 
                       NetworkLogger, 
@@ -110,7 +114,7 @@ Feature: Faking duck types
     """
 
   Scenario: Globally configured duck types
-    Then spec file with following content should pass:
+    Given a file named "fakes.rb" with:
     """ruby
     Bogus.fakes do
       logger_implementations = proc{ [DatabaseLogger, 
@@ -119,6 +123,12 @@ Feature: Faking duck types
 
       fake :logger, class: logger_implementations
     end
+    """
+
+    Then spec file with following content should pass:
+    """ruby
+    require_relative 'fakes'
+    require_relative 'loggers'
 
     describe "fake with multiple classes" do
       fake(:logger)

data/features/fakes/fake_objects.feature

@@ -26,7 +26,7 @@ Feature: Faking existing classes
       let(:foo) { fake(:foo, bar: "value") }
 
   Background:
-    Given a file named "foo.rb" with:
+    Given a file named "library.rb" with:
     """ruby
     class Library
       def checkout(book)
@@ -38,7 +38,10 @@ Feature: Faking existing classes
       def self.look_up(book)
       end
     end
+    """
 
+    Given a file named "student.rb" with:
+    """ruby
     class Student
       def self.learn(library = Library.new)
         library.checkout("hello world")
@@ -50,6 +53,9 @@ Feature: Faking existing classes
   Scenario: Calling methods that exist on real object
     Then spec file with following content should pass:
     """ruby
+    require_relative 'student'
+    require_relative 'library'
+
     describe Student do
       fake(:library)
 
@@ -79,6 +85,8 @@ Feature: Faking existing classes
   Scenario: Fakes which are classes
     Then spec file with following content should pass:
     """ruby
+    require_relative 'library'
+
     describe "library class fake" do
       fake(:library, as: :class)
 
@@ -99,6 +107,8 @@ Feature: Faking existing classes
   Scenario: Fakes with inline return values
     Then spec file with following content should pass:
     """ruby
+    require_relative 'library'
+
     describe "library class fake" do
       let(:library) { fake(:library, checkout: "checked out", 
                                      return_book: "returned") }

data/features/fakes/global_fake_configuration.feature

@@ -18,7 +18,7 @@ Feature: Global fake configuration
   in your spec helper, or a file required from it.
 
   Background:
-    Given a file named "foo.rb" with:
+    Given a file named "public_library.rb" with:
     """ruby
     class PublicLibrary
       def self.books_by_author(name)
@@ -39,6 +39,7 @@ Feature: Global fake configuration
     Then spec file with following content should pass:
     """ruby
     require_relative "fakes"
+    require_relative "public_library"
 
     describe "The library fake" do
       fake(:library)
@@ -64,6 +65,7 @@ Feature: Global fake configuration
     Then spec file with following content should pass:
     """ruby
     require_relative "fakes"
+    require_relative "public_library"
 
     describe "The library fake" do
       fake(:library, books_by_author: ["Some Book"])
@@ -78,6 +80,7 @@ Feature: Global fake configuration
     Then spec file with following content should pass:
     """ruby
     require_relative "fakes"
+    require_relative "public_library"
 
     describe "The library fake" do
       it "can be overridden in the helper" do

data/features/readme.md

@@ -37,8 +37,8 @@ Bogus makes your test doubles more assertive. They will no longer be too shy to
 Let's reexamine our previous example, this time Bogus-style:
 
     it "returns the average score" do
-      students = fake(:students, get: [5, 9])
-      scores = fake(:scores, all: ["John", "Mary"])
+      scores = fake(:scores, get: [5, 9])
+      students = fake(:students, all: ["John", "Mary"])
 
       report_card = ReportCard.new(scores, students)
 

data/features/safe_stubbing/argument_matchers.feature

@@ -3,7 +3,7 @@ Feature: Argument matchers
   Bogus supports some argument matchers for use, when you don't really care about exact equality of arguments passed in or spied on.
 
   Background:
-    Given a file named "foo.rb" with:
+    Given a file named "catalog.rb" with:
     """ruby
     class Catalog
       def self.books_by_author_and_title(author, title)
@@ -14,17 +14,47 @@ Feature: Argument matchers
   Scenario: Stubbing methods with any arguments
     Then the following test should pass:
     """ruby
+    require_relative 'catalog'
+
     stub(Catalog).books_by_author_and_title(any_args) { :some_book }
 
-    Catalog.books_by_author_and_title("Mark Twain", "Tom Sawyer").should == :some_book
+    Catalog.books_by_author_and_title("Arthur Conan Doyle", "Sherlock Holmes").should == :some_book
     """
 
   Scenario: Stubbing methods with some wildcard arguments
     Then the following test should pass:
     """ruby
+    require_relative 'catalog'
+
+    stub(Catalog).books_by_author_and_title(any_args) { :some_book }
     stub(Catalog).books_by_author_and_title("Mark Twain", anything) { :twains_book }
 
     Catalog.books_by_author_and_title("Mark Twain", "Tom Sawyer").should == :twains_book
     Catalog.books_by_author_and_title("Mark Twain", "Huckleberry Finn").should == :twains_book
+    Catalog.books_by_author_and_title("Arthur Conan Doyle", "Sherlock Holmes").should == :some_book
+    """
+
+  Scenario: Stubbing methods with proc argument matcher
+    Then the following test should pass:
+    """ruby
+    require_relative 'catalog'
+
+    stub(Catalog).books_by_author_and_title(any_args) { :some_book }
+    stub(Catalog).books_by_author_and_title(with{|author| author =~ /Twain/ }) { :twains_book }
+
+    Catalog.books_by_author_and_title("Mark Twain", "Tom Sawyer").should == :twains_book
+    Catalog.books_by_author_and_title("M. Twain", "Huckleberry Finn").should == :twains_book
+    Catalog.books_by_author_and_title("Arthur Conan Doyle", "Sherlock Holmes").should == :some_book
     """
 
+  Scenario: Stubbing methods with argument type matcher
+    Then the following test should pass:
+    """ruby
+    require_relative 'catalog'
+
+    stub(Catalog).books_by_author_and_title(any_args) { :some_book }
+    stub(Catalog).books_by_author_and_title(any(String), any(String)) { :twains_book }
+
+    Catalog.books_by_author_and_title("Mark Twain", "Tom Sawyer").should == :twains_book
+    Catalog.books_by_author_and_title("M. Twain", :other_book).should == :some_book
+    """

data/features/safe_stubbing/safe_mocking.feature

@@ -15,7 +15,7 @@ Feature: Safe mocking
   You can only mock methods that actually exist on an object. It will also work with methods that the object `responds_to?`, but (obviously) without being able to check the method signature.
 
   Background:
-    Given a file named "foo.rb" with:
+    Given a file named "library.rb" with:
     """ruby
     class Library
       def checkout(book)
@@ -26,8 +26,9 @@ Feature: Safe mocking
   Scenario: Mocking methods that exist on real object
     Then spec file with following content should pass:
     """ruby
-    describe Library do
+    require_relative 'library'
 
+    describe Library do
       it "does something" do
         library = Library.new
         mock(library).checkout("some book") { :checked_out }
@@ -40,6 +41,8 @@ Feature: Safe mocking
   Scenario: Mocking methods that do not exist on real object
     Then spec file with following content should fail:
     """ruby
+    require_relative 'library'
+    
     describe Library do
       it "does something" do
         library = Library.new
@@ -52,6 +55,8 @@ Feature: Safe mocking
   Scenario: Mocking methods with wrong number of arguments
     Then spec file with following content should fail:
     """ruby
+    require_relative 'library'
+
     describe Library do
       it "does something" do
         library = Library.new
@@ -64,6 +69,8 @@ Feature: Safe mocking
   Scenario: Mocks require the methods to be called
     Then spec file with following content should fail:
     """ruby
+    require_relative 'library'
+
     describe Library do
       it "does something" do
         library = Library.new

data/features/safe_stubbing/safe_stubbing.feature

@@ -7,7 +7,7 @@ Feature: Safe stubbing
       stub(object).method_name(arg1, arg2, ...) { return_value }
 
   Background:
-    Given a file named "foo.rb" with:
+    Given a file named "library.rb" with:
     """ruby
     class Library
       def checkout(book)
@@ -18,8 +18,9 @@ Feature: Safe stubbing
   Scenario: Stubbing methods that exist on real object
     Then spec file with following content should pass:
     """ruby
-    describe Library do
+    require_relative 'library'
 
+    describe Library do
       it "does something" do
         library = Library.new
         stub(library).checkout("some book") { :checked_out }
@@ -32,6 +33,8 @@ Feature: Safe stubbing
   Scenario: Stubbing methods that do not exist on real object
     Then spec file with following content should fail:
     """ruby
+    require_relative 'library'
+
     describe Library do
       it "does something" do
         library = Library.new
@@ -43,6 +46,8 @@ Feature: Safe stubbing
   Scenario: Stubbing methods with wrong number of arguments
     Then spec file with following content should fail:
     """ruby
+    require_relative 'library'
+
     describe Library do
       it "does something" do
         library = Library.new
@@ -54,6 +59,8 @@ Feature: Safe stubbing
   Scenario: Stubs allow the methods to be called
     Then spec file with following content should pass:
     """ruby
+    require_relative 'library'
+
     describe Library do
       it "does something" do
         library = Library.new
@@ -65,6 +72,8 @@ Feature: Safe stubbing
   Scenario: Stubbing methods multiple times
     Then spec file with following content should fail:
     """ruby
+    require_relative 'library'
+
     describe Library do
       it "stubbing with too many arguments" do
         library = Library.new

data/features/safe_stubbing/spies.feature

@@ -5,14 +5,17 @@ Feature: Spies
   Typically, stubbing libraries force you to first stub a method, so that you can later make sure it was called. However, if you use fakes, Bogus lets you verify that a method was called (or not) without stubbing it first.
 
   Background:
-    Given a file named "foo.rb" with:
+    Given a file named "library.rb" with:
     """ruby
     class Library
       def checkout(book)
         # marks book as checked out
       end
     end
+    """
 
+    Given a file named "student.rb" with:
+    """ruby
     class Student
       def initialize(library)
         @library = library
@@ -29,6 +32,9 @@ Feature: Spies
   Scenario: Ensuring methods were called
     Then spec file with following content should pass:
     """ruby
+    require_relative 'student'
+    require_relative 'library'
+
     describe Student do
       fake(:library)
 
@@ -46,6 +52,9 @@ Feature: Spies
   Scenario: Spying on methods that do not exist
     Then spec file with following content should fail:
     """ruby
+    require_relative 'student'
+    require_relative 'library'
+
     describe Student do
       fake(:library)
 
@@ -62,6 +71,9 @@ Feature: Spies
   Scenario: Spying on methods with wrong number of arguments
     Then spec file with following content should fail:
     """ruby
+    require_relative 'student'
+    require_relative 'library'
+
     describe Student do
       fake(:library)
 
@@ -79,6 +91,9 @@ Feature: Spies
   Scenario: Spying on previously stubbed methods
     Then spec file with following content should pass:
     """ruby
+    require_relative 'student'
+    require_relative 'library'
+
     describe Student do
       fake(:library)
 
@@ -91,3 +106,39 @@ Feature: Spies
       end
     end
     """
+
+  Scenario: Spying on attribute writers
+    Given a file named "canvas.rb" with:
+    """ruby
+    class Canvas
+      def background_color=(color)
+        # do something complicated
+      end
+    end
+    """
+
+    Given a file named "popup.rb" with:
+    """ruby
+    class Popup
+      def self.alert(message, canvas)
+        canvas.background_color = "red"
+        # display message
+      end
+    end
+    """
+   
+    Then spec file with following content should pass:
+    """ruby
+    require_relative 'canvas'
+    require_relative 'popup'
+
+    describe Popup do
+      fake(:canvas)
+
+      it "sets the background to red" do
+        Popup.alert("No such file!", canvas)
+
+        canvas.should have_received(:background_color=, "red")
+      end
+    end
+    """

data/features/step_definitions/rspec_steps.rb

@@ -6,7 +6,6 @@ Given /^a spec file named "([^"]*)" with:$/ do |file_name, string|
     Given a file named "#{file_name}" with:
     """ruby
     require 'bogus/rspec'
-    require_relative 'foo'
 
     #{string}
     """
@@ -26,7 +25,7 @@ Then /^all the specs should pass$/ do
 end
 
 When /^I run spec with the following content:$/ do |string|
-  file_name = 'foo_spec.rb'
+  file_name = "foo_#{rand(1000000)}_spec.rb"
 
   steps %Q{
     Given a spec file named "#{file_name}" with:

data/features/support/env.rb

@@ -1,5 +1,24 @@
 require 'aruba/cucumber'
+require 'aruba/jruby'
 
 Before('@known_bug') do
   pending("This scenario fails because of a known bug")
 end
+
+Before do |scenario|
+  dir_name = "scenario-#{rand(1_000_000)}"
+  create_dir(dir_name)
+  cd(dir_name)
+end
+
+Before do
+  @aruba_timeout_seconds = 60
+end
+
+if RUBY_PLATFORM == 'java' && ENV['TRAVIS']
+  Aruba.configure do |config|
+    config.before_cmd do
+      set_env('JAVA_OPTS', "#{ENV['JAVA_OPTS']} -d64")
+    end
+  end
+end

data/lib/bogus/active_record_accessors.rb

@@ -7,7 +7,7 @@ module Bogus
 
     takes :klass, :instance_methods
 
-    def_delegators :instance_methods, :remove, :define
+    def_delegators :model_methods, :remove, :define
 
     def all
       return [] unless klass < ActiveRecord::Base
@@ -20,8 +20,8 @@ module Bogus
 
     private
 
-    def instance_methods
-      @instance_methods.call(klass)
+    def model_methods
+      instance_methods.call(klass)
     end
 
     def all_attributes
@@ -29,7 +29,7 @@ module Bogus
     end
 
     def missing_attributes
-      all_attributes - instance_methods.all
+      all_attributes - model_methods.all
     end
 
     class Attribute < Struct.new(:name)