bnet_scraper 0.3.1 → 0.4.0

data/spec/starcraft2/league_scraper_spec.rb

@@ -1,77 +1,43 @@
 require 'spec_helper'
 
 describe BnetScraper::Starcraft2::LeagueScraper do
-  let(:url) { "http://us.battle.net/sc2/en/profile/2377239/1/Demon/ladder/12345" }
+  let(:url) { "http://us.battle.net/sc2/en/profile/2377239/1/Demon/ladder/134659" }
   subject { BnetScraper::Starcraft2::LeagueScraper.new(url: url) }
 
   it_behaves_like 'an SC2 Scraper' do
     let(:scraper_class) { BnetScraper::Starcraft2::LeagueScraper }
-    let(:subject) { scraper_class.new(url: "http://us.battle.net/sc2/en/profile/2377239/1/Demon/ladder/12345") }
+    let(:subject) { scraper_class.new(url: "http://us.battle.net/sc2/en/profile/2377239/1/Demon/ladder/134659") }
   end
 
   describe '#initialize' do
     it 'should dissect the league_id from the URL' do
-      subject.league_id.should == '12345'
+      subject.league_id.should == '134659'
     end
   end
 
   describe '#scrape' do
-    it 'should set the season value' do
-      subject.season.should be_nil
-      subject.scrape
-      subject.season.should == '6'
-    end
-
-    it 'should set the name' do
-      subject.name.should be_nil 
-      subject.scrape
-      subject.name.should == 'Aleksander Pepper'
-    end
-
-    it 'should set the divison' do
-      subject.division.should be_nil
-      subject.scrape
-      subject.division.should == 'Diamond'
-    end
-
-    it 'should set the size' do
-      subject.size.should be_nil
-      subject.scrape
-      subject.size.should == '4v4'
-    end
-
-    it 'should set if player is random' do
-      subject.random.should be_nil
-      subject.scrape
-      subject.random.should be_false 
-    end
-
-    it 'should call output' do
-      subject.should_receive(:output)
-      subject.scrape
-    end
-
-    it 'should raise InvalidProfileError when response is 404' do
-      url = 'http://us.battle.net/sc2/en/profile/2377239/1/SomeDude/leagues/12345' 
-      scraper = BnetScraper::Starcraft2::LeagueScraper.new(url: url)
-      expect { scraper.scrape }.to raise_error(BnetScraper::InvalidProfileError)
-    end
-  end
-
-  describe '#output' do
-    it 'should return a hash of league data' do
-      expected = {
-        season: '6',
-        name: 'Aleksander Pepper',
-        division: 'Diamond',
-        size: '4v4',
-        random: false,
-        bnet_id: '2377239',
-        account: 'Demon'
-      }
-
-      subject.scrape
-      subject.output.should == expected
+    context 'valid profile' do
+      before do
+        VCR.use_cassette('demon_leagues') do
+          subject.scrape
+        end
+      end
+
+      its(:season) { should == '2013 Season 1' }
+      its(:name) { should == 'Kalathi Echo' }
+      its(:division) { should == 'Platinum' }
+      its(:size) { should == '1v1' }
+      its(:random) { should be_false }
+    end
+
+    context 'invalid profile' do
+      it 'should raise InvalidProfileError' do
+        VCR.use_cassette('invalid_leagues') do
+          url = 'http://us.battle.net/sc2/en/profile/2377239/1/SomeDude/leagues/12345' 
+          scraper = BnetScraper::Starcraft2::LeagueScraper.new(url: url)
+          expect { scraper.scrape }.to raise_error(BnetScraper::InvalidProfileError)
+        end
+      end
     end
   end
 end

data/spec/starcraft2/league_spec.rb

@@ -0,0 +1,43 @@
+require 'spec_helper'
+
+describe BnetScraper::Starcraft2::League do
+  let(:href) { 'http://us.battle.net/sc2/en/profile/2377239/1/Demon/ladder/134659' }
+  let(:league) { BnetScraper::Starcraft2::League.new href: href }
+  subject { league }
+
+  it 'scrapes if name is not set' do
+    VCR.use_cassette('demon_leagues') do
+      league.name.should == 'Kalathi Echo'
+    end
+  end
+
+  it 'scrapes if season is not set' do
+    VCR.use_cassette('demon_leagues') do
+      league.season.should == '2013 Season 1'
+    end
+  end
+
+  it 'scrapes if division is not set' do
+    VCR.use_cassette('demon_leagues') do
+      league.division.should == 'Platinum'
+    end
+  end
+
+  it 'scrapes if size is not set' do
+    VCR.use_cassette('demon_leagues') do
+      league.size.should == '1v1'
+    end
+  end
+
+  it 'scrapes if bnet_id is not set' do
+    VCR.use_cassette('demon_leagues') do
+      league.bnet_id.should == '2377239'
+    end
+  end
+
+  it 'scrapes if account is not set' do
+    VCR.use_cassette('demon_leagues') do
+      league.account.should == 'Demon'
+    end
+  end
+end

data/spec/starcraft2/match_history_scraper_spec.rb

@@ -2,7 +2,8 @@ require 'spec_helper'
 
 describe BnetScraper::Starcraft2::MatchHistoryScraper do
   let(:url) { 'http://us.battle.net/sc2/en/profile/2377239/1/Demon/matches' }
-  subject { BnetScraper::Starcraft2::MatchHistoryScraper.new(url: url) }
+  let(:scraper) { BnetScraper::Starcraft2::MatchHistoryScraper.new(url: url) }
+  subject { scraper }
 
   it_behaves_like 'an SC2 Scraper' do
     let(:scraper_class) { BnetScraper::Starcraft2::MatchHistoryScraper }
@@ -11,49 +12,28 @@ describe BnetScraper::Starcraft2::MatchHistoryScraper do
 
   describe '#scrape' do
 
-    before :each do
-      subject.scrape
+    before do
+      VCR.use_cassette('demon_matches') do
+        scraper.scrape
+      end
     end
+    
+    its(:matches) { should have(25).matches }
 
-    it 'sets the matches to an array of match data' do
-      subject.matches.should have(25).matches
-    end
-
-    it 'should set the name of the map for each match' do
-      subject.matches[0][:map_name].should == 'Bx Monobattle - Sand Canyon (Fix)'
-    end
-
-    it 'should set the type of the match for each match' do
-      subject.matches[0][:type].should == 'Custom'
-    end
-
-    it 'should set the outcome of each match' do
-      subject.matches[0][:outcome].should == :win
-    end
-
-    it 'should set the match date of each match' do
-      subject.matches[0][:date].should == '3/12/2012'
+    describe 'each match' do
+      subject { scraper.matches[0] }
+      its(:map_name) { should == 'Cloud Kingdom LE' }
+      its(:type) { should == '1v1' }
+      its(:outcome) { should == :win }
+      its(:date) { should == '2/20/2013' }
     end
 
     it 'should raised InvalidProfileError when response is 404' do
-      url = 'http://us.battle.net/sc2/en/profile/2377239/1/SomeDude/matches'
-      scraper = BnetScraper::Starcraft2::MatchHistoryScraper.new(url: url)
-      expect { scraper.scrape }.to raise_error(BnetScraper::InvalidProfileError)
-    end
-  end
-
-  describe '#output' do
-    before :each do
-      subject.scrape
-    end
-
-    it 'should return a hash of the scraped match data' do
-      expected = {
-        matches:  subject.matches,
-        wins:     subject.wins,
-        losses:   subject.losses
-      }
-      subject.output.should == expected
+      VCR.use_cassette('invalid_matches') do
+        url = 'http://us.battle.net/sc2/en/profile/2377239/1/SomeDude/matches'
+        scraper = BnetScraper::Starcraft2::MatchHistoryScraper.new(url: url)
+        expect { scraper.scrape }.to raise_error(BnetScraper::InvalidProfileError)
+      end
     end
   end
 end

data/spec/starcraft2/profile_scraper_spec.rb

@@ -6,73 +6,70 @@ describe BnetScraper::Starcraft2::ProfileScraper do
     let(:subject) { scraper_class.new(url: 'http://us.battle.net/sc2/en/profile/2377239/1/Demon/') }
   end
 
-  subject { BnetScraper::Starcraft2::ProfileScraper.new(bnet_id: '2377239', account: 'Demon') }
+  let(:scraper) { BnetScraper::Starcraft2::ProfileScraper.new(bnet_id: '2377239', account: 'Demon') }
 
   describe '#get_profile_data' do
     before do
-      subject.get_profile_data
+      VCR.use_cassette('demon_profile', record: :new_episodes) do
+        scraper.get_profile_data
+      end
     end
 
-    its(:race) { should == 'Protoss' }
-    its(:achievement_points) { should == '3660' }
-    its(:current_solo_league) { should == 'Not Yet Ranked' }
+    subject { scraper.profile }
+
+    its(:achievement_points) { should == '3680' }
+    its(:current_solo_league) { should == 'Platinum' }
     its(:highest_solo_league) { should == 'Platinum' }
-    its(:current_team_league) { should == 'Not Yet Ranked' }
-    its(:highest_team_league) { should == 'Diamond' }
-    its(:career_games) { should == '1568' }
-    its(:games_this_season) { should == '0' }
-    its(:most_played) { should == '4v4' }
+    its(:current_team_league) { should == 'Diamond' }
+    its(:highest_team_league) { should == 'Master' }
+    its(:career_games) { should == '1719' }
+    its(:games_this_season) { should == '114' }
+    its(:portrait) { should == 'Mohandar' }
+    its(:terran_swarm_level) { should == 0 }
+    its(:protoss_swarm_level) { should == 0 }
+    its(:zerg_swarm_level) { should == 0 }
 
     context 'first league ever' do
-      subject { BnetScraper::Starcraft2::ProfileScraper.new url: 'http://us.battle.net/sc2/en/profile/3513522/1/Heritic/' }
+      let(:scraper) { BnetScraper::Starcraft2::ProfileScraper.new url: 'http://us.battle.net/sc2/en/profile/3513522/1/Heritic/' }
 
-      before do
-        subject.scrape
+      subject do
+        VCR.use_cassette('new_league', record: :new_episodes) do
+          scraper.scrape
+        end
       end
 
       its(:current_solo_league) { should == 'Bronze' }
       its(:highest_solo_league) { should == 'Bronze' }
-      its(:current_team_league) { should == 'Silver' }
+      its(:current_team_league) { should == 'Bronze' }
       its(:highest_team_league) { should == 'Silver' }
     end
   end
 
   describe 'get_league_list' do
-    it 'should set an array of leagues' do
-      subject.should have(0).leagues
-      subject.get_league_list
-
-      subject.should have(12).leagues
+    before do
+      VCR.use_cassette('demon_profile_leagues') do
+        scraper.get_league_list
+      end
     end
+
+    subject { scraper.profile.leagues }
+    it { should have(8).leagues }
   end
 
   describe '#scrape' do
-    it 'should call get_profile_data' do
-      subject.should_receive(:get_profile_data)
-      subject.scrape
-    end
-
-    it 'should call get_league_list' do
-      subject.should_receive(:get_league_list)
-      subject.scrape
-    end
-
-
-
-    it 'should call output' do
-      subject.should_receive(:output)
-      subject.scrape
-    end
-
     it 'should return InvalidProfileError if response is 404' do
-      scraper = BnetScraper::Starcraft2::ProfileScraper.new url: 'http://us.battle.net/sc2/en/profile/2377239/1/SomeDude/'
-      expect { scraper.scrape }.to raise_error(BnetScraper::InvalidProfileError)
+      VCR.use_cassette('profile_invalid') do
+        scraper = BnetScraper::Starcraft2::ProfileScraper.new url: 'http://us.battle.net/sc2/en/profile/2377239/1/SomeDude/'
+        expect { scraper.scrape }.to raise_error(BnetScraper::InvalidProfileError)
+      end
     end
 
     context 'account that has not laddered' do
       let(:scraper) {BnetScraper::Starcraft2::ProfileScraper.new(url: 'http://us.battle.net/sc2/en/profile/3354437/1/ClarkeKent/') }
       before do
-        scraper.scrape
+        VCR.use_cassette('profile_not_laddered') do
+          scraper.scrape
+        end
       end
       
       it 'should have an empty array of leagues' do
@@ -80,106 +77,4 @@ describe BnetScraper::Starcraft2::ProfileScraper do
       end
     end
   end
-
-  describe '#output' do
-    it 'should extract profile data from the response' do
-      expected = {
-        bnet_id: '2377239',
-        account: 'Demon',
-        bnet_index: 1,
-        race: 'Protoss',
-        career_games: '1568',
-        games_this_season: '0',
-        highest_solo_league: 'Platinum',
-        current_solo_league: 'Not Yet Ranked',
-        highest_team_league: 'Diamond',
-        current_team_league: 'Not Yet Ranked',
-        most_played: '4v4',
-        achievement_points: '3660',
-        portrait: 'Mohandar',
-        leagues: [
-          {
-            name: "1v1 Platinum Rank 95", 
-            id: "96905",
-            href: "http://us.battle.net/sc2/en/profile/2377239/1/Demon/ladder/96905#current-rank"
-          }, 
-          {
-            name: "2v2 Random Platinum ...", 
-            id: "96716",
-            href: "http://us.battle.net/sc2/en/profile/2377239/1/Demon/ladder/96716#current-rank"
-          },
-          {
-            name: "2v2 Diamond Rank 45",
-            id: "98162",
-            href: "http://us.battle.net/sc2/en/profile/2377239/1/Demon/ladder/98162#current-rank"
-          }, 
-          {
-            name: "2v2 Silver Rank 8",
-            id: "97369", 
-            href: "http://us.battle.net/sc2/en/profile/2377239/1/Demon/ladder/97369#current-rank"
-          },
-          {
-            name: "3v3 Random Gold Rank...",
-            id: "96828",
-            href: "http://us.battle.net/sc2/en/profile/2377239/1/Demon/ladder/96828#current-rank"
-          }, 
-          {
-            name: "3v3 Diamond Rank 56",
-            id: "97985",
-            href: "http://us.battle.net/sc2/en/profile/2377239/1/Demon/ladder/97985#current-rank"
-          }, 
-          {
-            name: "3v3 Silver Rank 5",
-            id: "98523", 
-            href: "http://us.battle.net/sc2/en/profile/2377239/1/Demon/ladder/98523#current-rank"
-          },
-          {
-            name: "3v3 Platinum Rank 88", 
-            id: "96863",
-            href: "http://us.battle.net/sc2/en/profile/2377239/1/Demon/ladder/96863#current-rank"
-          },
-          {
-            name: "3v3 Gold Rank 75", 
-            id: "97250", 
-            href: "http://us.battle.net/sc2/en/profile/2377239/1/Demon/ladder/97250#current-rank"
-          },
-          {
-            name: "4v4 Random Platinum ...",
-            id: "96830",
-            href: "http://us.battle.net/sc2/en/profile/2377239/1/Demon/ladder/96830#current-rank"
-          },
-          {
-            name: "4v4 Gold Rank 38",
-            id: "98336", 
-            href: "http://us.battle.net/sc2/en/profile/2377239/1/Demon/ladder/98336#current-rank"
-          },
-          {
-            name: "4v4 Diamond Rank 54",
-            id: "98936", 
-            href: "http://us.battle.net/sc2/en/profile/2377239/1/Demon/ladder/98936#current-rank"
-          } 
-        ]
-      }
-
-      subject.output.should == { 
-        bnet_id: '2377239', 
-        account: 'Demon',
-        bnet_index: 1,
-        race: nil,
-        career_games: nil,
-        games_this_season: nil,
-        most_played: nil,
-        highest_solo_league: nil, 
-        current_solo_league: nil, 
-        highest_team_league: nil,
-        current_team_league: nil,
-        achievement_points: nil, 
-        leagues: [],
-        portrait: nil
-      }
-
-      subject.scrape
-      subject.output.should == expected
-    end
-  end
 end

data/spec/starcraft2/profile_spec.rb

@@ -0,0 +1,46 @@
+require 'spec_helper'
+
+describe BnetScraper::Starcraft2::Profile do
+  let(:url) { 'http://us.battle.net/sc2/en/profile/2377239/1/Demon/' }
+  let(:profile) { BnetScraper::Starcraft2::Profile.new url: url  }
+  subject { profile }
+
+  its(:swarm_levels) { should be_instance_of Hash }
+  its(:swarm_levels) { should have_key :zerg }
+  its(:swarm_levels) { should have_key :protoss }
+  its(:swarm_levels) { should have_key :terran }
+
+  it 'retrieves achievements when first accessed' do
+    VCR.use_cassette('demon_achievements') do
+      profile.achievements.should have_key(:recent)
+      profile.achievements.should have_key(:showcase)
+      profile.achievements.should have_key(:progress)
+    end
+  end
+
+  it 'sends recent_achievements to achievements hash' do
+    VCR.use_cassette('demon_achievements') do
+      profile.recent_achievements.should == profile.achievements[:recent]
+    end
+  end
+
+  it 'sends progress_achievements to achievements hash' do
+    VCR.use_cassette('demon_achievements') do
+      profile.progress_achievements.should == profile.achievements[:progress]
+    end
+  end
+
+  it 'sends showcase_achievements to achievements hash' do
+    VCR.use_cassette('demon_achievements') do
+      profile.showcase_achievements.should == profile.achievements[:showcase]
+    end
+  end
+
+  it 'retrieves match history when first accessed' do
+    VCR.use_cassette('demon_match_history') do
+      profile.match_history.should have(25).matches
+      profile.match_history.first.should be_instance_of BnetScraper::Starcraft2::Match
+    end
+  end
+
+end