bnet_scraper 0.3.0 → 0.3.1

data/CHANGELOG.md

@@ -1,5 +1,10 @@
 # Changelog!
 
+## 0.3.1 (Sep 24 2012)
+
+* Throws BnetScraper::InvalidProfileError when instantiating a scraper with poorly
+formatted profile URL
+
 ## 0.3.0 (Sep 22 2012)
 
 * Adds portrait name scraping to ProfileScraper

data/bnet_scraper.gemspec

@@ -3,7 +3,7 @@ $:.push File.expand_path("../lib", __FILE__)
 
 Gem::Specification.new do |s|
   s.name        = "bnet_scraper"
-  s.version     = "0.3.0"
+  s.version     = "0.3.1"
   s.authors     = ["Andrew Nordman"]
   s.email       = ["anordman@majorleaguegaming.com"]
   s.homepage    = "https://github.com/agoragames/bnet_scraper/"

data/lib/bnet_scraper/starcraft2/base_scraper.rb

@@ -20,11 +20,15 @@ module BnetScraper
       def initialize options = {}
         if options[:url]
           extracted_data = options[:url].match(/http:\/\/(.+)\/sc2\/(.+)\/profile\/(.+)\/(\d{1})\/(.[^\/]+)\//)
-          @region     = REGION_DOMAINS[extracted_data[1]]
-          @bnet_id    = extracted_data[3]
-          @bnet_index = extracted_data[4]
-          @account    = extracted_data[5]
-          @url        = options[:url]
+          if extracted_data
+            @region     = REGION_DOMAINS[extracted_data[1]]
+            @bnet_id    = extracted_data[3]
+            @bnet_index = extracted_data[4]
+            @account    = extracted_data[5]
+            @url        = options[:url]
+          else
+            raise BnetScraper::InvalidProfileError, "URL provided does not match Battle.net format"
+          end
         elsif options[:bnet_id] && options[:account]
           @bnet_id  = options[:bnet_id]
           @account  = options[:account]

data/spec/starcraft2/base_scraper_spec.rb

@@ -6,6 +6,12 @@ describe BnetScraper::Starcraft2::BaseScraper do
     let(:subject) { scraper_class.new(url: 'http://us.battle.net/sc2/en/profile/2377239/1/Demon/') }
   end
 
+  it 'raises InvalidProfileError on poorly formatted URL' do
+    expect {
+      BnetScraper::Starcraft2::BaseScraper.new url: 'mangled_url'
+    }.to raise_error BnetScraper::InvalidProfileError
+  end
+
   describe '#scrape' do
     it 'should raise an error calling scrape' do
       expect { subject.scrape }.to raise_error NotImplementedError

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: bnet_scraper
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.3.1
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-09-22 00:00:00.000000000 Z
+date: 2012-09-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri
-  requirement: &70190591320380 !ruby/object:Gem::Requirement
+  requirement: &70113957192020 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,10 +21,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *70190591320380
+  version_requirements: *70113957192020
 - !ruby/object:Gem::Dependency
   name: faraday
-  requirement: &70190591319800 !ruby/object:Gem::Requirement
+  requirement: &70113957191500 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -32,10 +32,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *70190591319800
+  version_requirements: *70113957191500
 - !ruby/object:Gem::Dependency
   name: rake
-  requirement: &70190591319280 !ruby/object:Gem::Requirement
+  requirement: &70113957190940 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -43,10 +43,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70190591319280
+  version_requirements: *70113957190940
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &70190591318580 !ruby/object:Gem::Requirement
+  requirement: &70113957190320 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -54,10 +54,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70190591318580
+  version_requirements: *70113957190320
 - !ruby/object:Gem::Dependency
   name: fakeweb
-  requirement: &70190591317300 !ruby/object:Gem::Requirement
+  requirement: &70113957189160 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -65,7 +65,7 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70190591317300
+  version_requirements: *70113957189160
 description: BnetScraper is a Nokogiri-based scraper of Battle.net profile information.
   Currently this only includes Starcraft2.
 email:
@@ -127,7 +127,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -114027561748751341
+      hash: 1434413349311613347
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -136,7 +136,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -114027561748751341
+      hash: 1434413349311613347
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.17