bmo 0.8.7 → 0.8.8

checksums.yaml

@@ -1,7 +1,15 @@
 ---
-SHA1:
-  metadata.gz: c4d72c31c7bd2a3ec83e27806b6a40b2f7c3664a
-  data.tar.gz: dbca42a10a817f492a6ca357415015cf7d44bf53
+!binary "U0hBMQ==":
+  metadata.gz: !binary |-
+    NmM2NWMzOTM5MDFkZmZkNzVjODQ2NWM0NWQ2ODE5NWZhMTI0OGZkYw==
+  data.tar.gz: !binary |-
+    MTE0Y2NmMzMyOGU5NDE4ZThhN2M1Zjk5YThkNTY4OWI0YTI2NWFjMA==
 SHA512:
-  metadata.gz: 60f95aa5be2336adc688bba51b8969ba9284f2eabdcfd0bed93d0aa72e0160bef559cd9bc4e034cf4ce26d7f26c6ab50ddffbcd3f92e1cc408236d6bed3c1c36
-  data.tar.gz: adb4edba935e088a19b9f139b6d52ce6056b53d55b9d0fbb03b384277fa830c7ccbee8913dcb75fd7e401b938d4b279fe91db06ac06adca0ff55075c38d2a6da
+  metadata.gz: !binary |-
+    NjZkN2I2NzI4YzIyZjkyNjFlZmNlOTMwNjhkNjkzNmVhNDY5OWI5Y2YxNTBh
+    MTRkN2M2MWNlMDM5ODQyZDVmNmU1N2NjMWM3MmUwNGZjYTAyOWJkN2Q4NzE3
+    NmQxNjUyOTA5OWYwMDRjZmIyZDI2NjY3OTRkM2E4Y2Q2YjY0MjQ=
+  data.tar.gz: !binary |-
+    OGE1NDQ4ZjdmZDNjMDBkNjNmMjM0NDU4OWY3ZTIxNGE5MzMwZTA1YmM3YWRh
+    YjllMGEzODkyNWViYTkwMmY4MWJjMGQ3OWRkNmRkYjc3ZDg1NTgwNTc5MGU2
+    NjkyOTk1ODRjNjQwMTY1YWY5ODMxMjRhNmM1NmRjMGFlYTBjNTU=

data/Gemfile.lock

@@ -26,7 +26,7 @@ GIT
 PATH
   remote: .
   specs:
-    bmo (0.8.6)
+    bmo (0.8.7)
       equalizer (~> 0.0.0)
       faraday (> 0.8.0)
 

data/README.md

@@ -56,11 +56,11 @@ Default Params :
 ```ruby
 BMO.configuration do |config|
   config.apns.gateway_host  = 'gateway.push.apple.com'
-  config.apns.gateway_port  =  2195
-  config.apns.feedback_host =  'feedback.push.apple.com'
-  config.apns.feedback_port =  2196
-  config.apns.cert_path     =  nil
-  config.apns.cert_pass     =  nil
+  config.apns.gateway_port  = 2195
+  config.apns.feedback_host = 'feedback.push.apple.com'
+  config.apns.feedback_port = 2196
+  config.apns.cert_path     = nil
+  config.apns.cert_pass     = nil
 end
 ```
 
@@ -92,7 +92,7 @@ BMO.configuration do |config|
 end
 ```
 
-You should set the api_key.
+You should set the api_key. It uses Faraday internally, so just set your regular http_proxy environment variable if need to configure a proxy.
 
 ## License
 

data/lib/bmo/apns/client.rb

@@ -64,8 +64,6 @@ module BMO
         end
       end
 
-      private
-
       # Handle the Feedback Object
       #
       # @!attribute time [Time] Time when the device was notified

data/lib/bmo/apns/connection.rb

@@ -16,7 +16,7 @@ module BMO
       #   a pure TCPSocket. It then yields the socket and handles the closing
       #
       # @return The yielded return
-      def connect(&block)
+      def connect
         socket = cert_path ? ssl_socket : tcp_socket
 
         yielded = yield socket

data/lib/bmo/apns/notification.rb

@@ -31,8 +31,6 @@ module BMO
         payload.validate!
       end
 
-      private
-
       # The Payload contains the data sent to Apple
       class Payload
         class PayloadTooLarge < Exception; end
@@ -53,10 +51,9 @@ module BMO
         end
 
         def validate!
-          if to_package.size > MAX_BYTE_SIZE
-            str = <<-EOS
-              Payload size should be less than #{Payload::MAX_BYTE_SIZE} bytes
-            EOS
+          if to_package.bytesize > MAX_BYTE_SIZE
+            str = "Payload byte size (#{to_package.bytesize})" \
+              " should be less than #{Payload::MAX_BYTE_SIZE} bytes"
             fail PayloadTooLarge, str
           end
           true
@@ -82,7 +79,7 @@ module BMO
 
         def validate!
           unless token =~ /^[a-z0-9]{64}$/i
-            fail(MalformedDeviceToken, 'Malformed Device Token')
+            fail(MalformedDeviceToken, "Malformed Device Token : #{token}")
           end
           true
         end

data/lib/bmo/gcm/connection.rb

@@ -9,7 +9,7 @@ module BMO
         @api_key            = api_key
       end
 
-      def connect(&block)
+      def connect
         faraday_connection.post(gateway_url) do |request|
           request.headers.merge!(content_type: 'application/json',
                                  authorization: "key=#{api_key}")

data/lib/bmo/gcm/notification.rb

@@ -24,8 +24,6 @@ module BMO
         payload.validate!
       end
 
-      private
-
       # The Payload contains the data sent to Apple
       class Payload
         # Error Raised when the payload packaged > MAX_BYTE_SIZE
@@ -47,7 +45,7 @@ module BMO
         end
 
         def validate!
-          if to_package.size > MAX_BYTE_SIZE
+          if to_package.bytesize > MAX_BYTE_SIZE
             str = <<-EOS
               Payload size should be less than #{Payload::MAX_BYTE_SIZE} bytes
             EOS

data/lib/bmo/version.rb

@@ -1,5 +1,5 @@
 # encoding: utf-8
 # Main BMO module, version get right here
 module BMO
-  VERSION = '0.8.7'.freeze
+  VERSION = '0.8.8'.freeze
 end

data/spec/bmo/apns/notification_spec.rb

@@ -3,52 +3,19 @@
 require File.dirname(__FILE__) + '../../../spec_helper'
 
 describe BMO::APNS::Notification::DeviceToken do
-  describe '#token' do
-    it 'returns the token' do
-      device_token     = described_class.new('abc')
-      expect(device_token.token).to eq('abc')
-    end
-  end
-
-  describe '#==' do
-    it 'returns true for equal device token' do
-      device_token     = described_class.new('abc')
-      device_token_bis = described_class.new('abc')
-      expect(device_token == device_token_bis).to be_true
-    end
-
-    it 'returns true for equal device token' do
-      device_token     = described_class.new('abc')
-      device_token_bis = described_class.new('abc')
-      expect(device_token).to eq(device_token_bis)
-    end
-
-    it 'returns false for equal device token' do
-      device_token     = described_class.new('abc')
-      device_token_bis = described_class.new('def')
-      expect(device_token).to_not eq(device_token_bis)
-    end
-
-    it 'returns true for equal device token' do
-      device_token     = described_class.new('abc')
-      device_token_bis = described_class.new('def')
-      expect(device_token == device_token_bis).to be_false
-    end
-  end
-
   describe '#validate!' do
     it 'returns true if the token is 64 chars' do
       device_token = described_class.new('a' * 64)
       expect(device_token.validate!).to be_true
     end
 
-    it 'returns false if the token is not 64 chars' do
+    it 'raises an error if the token is not 64 chars' do
       device_token = described_class.new('a' * 63)
       expect { device_token.validate! }.to raise_error(
         BMO::APNS::Notification::DeviceToken::MalformedDeviceToken)
     end
 
-    it 'returns false if the token contains a special char' do
+    it 'raises an error if the token contains a special char' do
       device_token = described_class.new(('a' * 63) + '"')
       expect { device_token.validate! }.to raise_error(
         BMO::APNS::Notification::DeviceToken::MalformedDeviceToken)
@@ -78,4 +45,16 @@ describe BMO::APNS::Notification::Payload do
     payload = described_class.new('Jake' => 'The Dog')
     expect(payload).to eq(described_class.new(Jake: 'The Dog'))
   end
+
+  describe '#validate!' do
+    it 'returns true if the payload is valid' do
+      payload = described_class.new(apns: 'a' * 200)
+      expect(payload.validate!).to be_true
+    end
+    it 'raises an error if the payload is too large' do
+      payload = described_class.new(apns: 'a' * 256)
+      expect { payload.validate! }.to raise_error(
+        BMO::APNS::Notification::Payload::PayloadTooLarge)
+    end
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: bmo
 version: !ruby/object:Gem::Version
-  version: 0.8.7
+  version: 0.8.8
 platform: ruby
 authors:
 - Antoine Lyset
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-02-24 00:00:00.000000000 Z
+date: 2014-08-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: equalizer
@@ -28,14 +28,14 @@ dependencies:
   name: faraday
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>'
+    - - ! '>'
       - !ruby/object:Gem::Version
         version: 0.8.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>'
+    - - ! '>'
       - !ruby/object:Gem::Version
         version: 0.8.0
 - !ruby/object:Gem::Dependency
@@ -56,14 +56,14 @@ dependencies:
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
 description: Push notifications to iOS and Android devices
@@ -106,17 +106,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.1.11
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: Push notifications to iOS and Android devices