bloom_remit_client 0.13.0 → 0.16.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 3b3aba46f146685d2eb407b1cb2e0ab5c059e357
-  data.tar.gz: 06446a803900371021256cf1114cf56f8002615f
+SHA256:
+  metadata.gz: '004937907860669c021508a70c07195e00d0ca70dde5077b22528d25229a626e'
+  data.tar.gz: 4e9ea25dd2e7ae3c18491eac7bea98b1a8fb75a42a71a41b8e57a4b78e6d4918
 SHA512:
-  metadata.gz: e43eb42d4c7b9d33eb86f9b2a0d11713a8a1b1bcd43a9391029bb49ebe84497b25466586b8ec56f620060108710abea9bf07c1b00142a492d8209a32155c85f0
-  data.tar.gz: 72153f6ba82278624584fe9016dbe900b4d79742fac8b8dea487501d617f5a035c02f33448fa17d8811e325cfbc31214383b5b98c71e56a85ce185065326158c
+  metadata.gz: 4b14558a559a026896d45a4c423d899f5f8e7f8eae1e1dd2ce6d8e86d88133ec1491d979f4db5ac91a6c5a8eac065929cdf0f36d195386e17fc1af536e2dd1ce
+  data.tar.gz: 71aa7d7d1db260fb1eb02339d01231dc48a3b911be1898a0c3b3906ebe4af31170fad104835be3a5ab5f7ec24968eb57930c8949c9bc84d8735c4f0cd1370d1c

data/.github/workflows/push.yml

@@ -0,0 +1,27 @@
+name: Ruby Gem
+
+on:
+  pull_request:
+    branches:
+      - master
+  push:
+    branches:
+      - master
+
+jobs:
+  test:
+
+    runs-on: ubuntu-latest
+
+    steps:
+    - uses: actions/checkout@v2
+    - name: Set up Ruby
+      uses: ruby/setup-ruby@v1
+      with:
+        ruby-version: 2.7.2
+    - name: Bundle install
+      run: bundle install
+    - name: Copy spec config
+      run: cp spec/config.yml{.sample,}
+    - name: Run tests
+      run: bundle exec rspec

data/.ruby-version

@@ -1 +1 @@
-ruby-2.3.1
+ruby-2.7.2

data/CHANGELOG.md

@@ -2,6 +2,33 @@
 All notable changes to this project will be documented in this file.
 This project adheres to [Semantic Versioning](http://semver.org/).
 
+## [0.16.2] - 2020-01-26
+### Changed
+- `CreateTxnPreviewResponse#errors` change from `Hash` to `Array`
+
+## [0.16.1] - 2020-01-19
+### Changed
+- Allow nil for both `partner_id` and `api_secret
+
+## [0.16.0] - 2020-01-18
+### Changed
+- Removed all API methods (complete overhaul)
+
+### Added
+- `#create_txn` to create transactions
+- `#create_txn_preview` to determine fees, eta, and max amount of a transaction
+
+## [0.15.0] - 2017-04-26
+### Changed
+- Production domain is now `www.bloomremit.net`
+- Marked `pending` the failing specs:
+  - create payment
+  - fetch credits
+
+## [0.14.0] - 2016-10-05
+### Added
+- Factories: `bloom_remit_client_responses_recipients_create`, `bloom_remit_client_responses_recipients_list`
+
 ## [0.13.0] - 2016-10-05
 ### Added
 - Add `#recipient_list` to list the recipients of a sender

data/Gemfile

@@ -5,4 +5,5 @@ gemspec
 
 gem "pry"
 gem "pry-byebug"
-gem "virtus-matchers", github: "g5/virtus-matchers"
+
+gem "message_bus_client_worker", github: "bloom-solutions/message_bus_client_worker", branch: "feat-subscribe"

data/README.md

@@ -22,6 +22,67 @@ Or install it yourself as:
 
 See `spec/functional` for examples.
 
+To subscribe to transaction updates, configure the following (in an initializer if you're using Rails):
+
+```ruby
+MessageBusClientWorker.configure do |c|
+  c.subscriptions = {
+    "https://bloomremit.net" => {
+      headers: {
+        # TOKEN here is a Base64.strict_encode64 string composed of
+        # your PARTNER_ID and API_SECRET joined by a colon character
+        "Authorization" => "Basic #{TOKEN}"
+      },
+      channels: {
+        "/v2/txns" => { processor: "ProcessBloomRemitTxnUpdate" },
+      }
+    },
+  }
+
+  # Consider changing MessageBusClientWorker to incrementally add subscriptions
+  # and not overwrite like above. Warn if a host is already defined.
+  # If we do this, then we can add a helper method to this gem, that adds the sub:
+  # BloomRemitClient.configure do |c|
+  #   c.partner_id = ENV["BLOOM_REMIT_PARTNER_ID"]
+  #   c.api_secret = ENV["BLOOM_REMIT_API_SECRET"]
+  #   c.on_txn_update = "ProcessBloomRemitTxnUpdate" # setting this will trigger the MBCW subscription
+  # end
+  c.subscribe(
+    "https://bloomremit.net" => {
+      headers: { "Authorization" => "Basic #{TOKEN}" },
+      channels: {
+        "/v2/txns" => { processor: "ProcessBloomRemitTxnUpdate" },
+      }
+    },
+  )
+end
+```
+
+```ruby
+BloomRemitClient.configure do |c|
+  c.partner_id = ENV["BLOOM_REMIT_PARTNER_ID"]
+  c.api_secret = ENV["BLOOM_REMIT_API_SECRET"]
+  c.on_txn_update = "ProcessBloomRemitTxnUpdate"
+end
+
+BloomRemitClient.configure_message_bus_client_worker!
+```
+
+Make sure `MessageBusClientWorker` (the gem used underneath this gem) is enqueued at an interval, so your app will continually fetch updates. See [Staying subscribed](https://github.com/bloom-solutions/message_bus_client_worker#staying-subscribed) in MessageBusClientWorker. Note that you will need to have Sidekiq for `MessageBusClientWorker` to function.
+
+Somewhere in your app, define `ProcessBloomRemitTxnUpdates` to update your own database:
+
+```ruby
+class ProcessBloomRemitTxnUpdates
+  def self.call(remote_txn)
+    # remote_txn passed to you is an instance of BloomRemitClient::Txn model
+    if withdrawal = Withdrawal.find_by(id: remote_txn.client_external_id)
+      withdrawal.update(status: remote_txn.status)
+    end
+  end
+end
+```
+
 ## Factories
 
 To make testing easier, you may `require 'bloom_remit_client/factories'` in your app.

data/bloom_remit_client.gemspec

@@ -26,17 +26,17 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
 
-  spec.add_dependency "activemodel"
   spec.add_dependency "activesupport"
-  spec.add_dependency "httparty"
-  spec.add_dependency "addressable"
+  spec.add_dependency "api_client_base"
+  spec.add_dependency "typhoeus"
+  spec.add_dependency "message_bus_client_worker"
 
-  spec.add_development_dependency "bundler", "~> 1.12"
+  spec.add_development_dependency "bundler", "~> 2.0"
   spec.add_development_dependency "rake", "~> 10.0"
   spec.add_development_dependency "rspec", "~> 3.0"
   spec.add_development_dependency "vcr"
   spec.add_development_dependency 'faker'
   spec.add_development_dependency "webmock"
   spec.add_development_dependency "dotenv"
-  spec.add_development_dependency "shoulda-matchers"
+  spec.add_development_dependency "virtus-matchers"
 end

data/lib/bloom_remit_client.rb

@@ -1,66 +1,56 @@
 # frozen_string_literal: true
-require 'virtus'
-require 'httparty'
-require 'active_model'
+require "api_client_base"
 require 'active_support/core_ext/hash/indifferent_access'
 require 'active_support/core_ext/object/try'
+require "message_bus_client_worker"
 require 'bloom_remit_client/coercers/indifferent_hash'
-require 'bloom_remit_client/coercers/path'
-require 'bloom_remit_client/concerns/has_base_authentification'
 require "bloom_remit_client/version"
 require "bloom_remit_client/client"
-require "bloom_remit_client/models/biller"
-require "bloom_remit_client/models/deposit_strategy"
-require "bloom_remit_client/models/user"
-require "bloom_remit_client/models/payment"
-require "bloom_remit_client/models/remittance"
-require "bloom_remit_client/models/credit"
-require "bloom_remit_client/models/recipient"
+require "bloom_remit_client/models/txn"
+require "bloom_remit_client/models/txn_preview"
 require "bloom_remit_client/requests"
-require "bloom_remit_client/requests/url_builder"
-require "bloom_remit_client/requests/requests_sender"
-require "bloom_remit_client/requests/base"
-require "bloom_remit_client/requests/credit/list"
-require "bloom_remit_client/requests/credit/history"
-require "bloom_remit_client/requests/rate/show"
-require "bloom_remit_client/requests/billers/list"
-require "bloom_remit_client/requests/deposit_strategies/list"
-require "bloom_remit_client/requests/senders/create"
-require "bloom_remit_client/requests/payments/create"
-require "bloom_remit_client/requests/remittances/create"
-require "bloom_remit_client/requests/recipients/create"
-require "bloom_remit_client/requests/recipients/list"
-require "bloom_remit_client/requests/remittances/calculate"
-require "bloom_remit_client/requests/txns/create"
-require "bloom_remit_client/responses/base"
-require "bloom_remit_client/responses/billers/list"
-require "bloom_remit_client/responses/deposit_strategies/list"
-require "bloom_remit_client/responses/senders/create"
-require "bloom_remit_client/responses/payments/create"
-require "bloom_remit_client/responses/remittances/create"
-require "bloom_remit_client/responses/recipients/create"
-require "bloom_remit_client/responses/recipients/list"
-require "bloom_remit_client/responses/remittances/calculate"
-require "bloom_remit_client/responses/txns/create"
+require "bloom_remit_client/requests/base_request"
+require "bloom_remit_client/requests/create_txn_request"
+require "bloom_remit_client/requests/create_txn_preview_request"
+require "bloom_remit_client/responses/base_response"
+require "bloom_remit_client/responses/create_txn_response"
+require "bloom_remit_client/responses/create_txn_preview_response"
 
 module BloomRemitClient
-  PRODUCTION = 'api.bloom.solutions'
-  STAGING = 'bloomremit-staging.herokuapp.com'
 
-  class << self
-    attr_accessor :host
-    attr_accessor :sandbox
+  PRODUCTION = 'https://www.bloomremit.net'
+  STAGING = 'https://staging.bloomremit.net'
 
-    def new(args={})
-      client_args = {}
-      client_args[:host] = self.host if self.host.present?
-      client_args[:sandbox] = self.sandbox if self.sandbox.present?
-      client_args.merge!(args)
+  include APIClientBase::Base.module
 
-      client = Client.new(client_args)
-      raise ArgumentError, client.errors.full_messages if client.invalid?
-      client
+  TXN_UPDATES_CHANNEL = "/v2/txns".freeze
+
+  with_configuration do
+    has :host, classes: String, default: STAGING
+    has :partner_id, classes: [String, NilClass]
+    has :api_secret, classes: [String, NilClass]
+    has :on_txn_update, classes: [String, NilClass]
+  end
+
+  def self.configure_message_bus_client_worker!
+    if configuration.on_txn_update.blank?
+      fail "`on_txn_update` must be defined"
     end
 
+    token = [
+      configuration.partner_id,
+      configuration.api_secret,
+    ].join(":")
+    token = Base64.strict_encode64(token)
+
+    MessageBusClientWorker.subscribe(configuration.host, {
+      headers: {
+        "HTTP_AUTHORIZATION" => "Basic #{token}"
+      },
+      channels: {
+        TXN_UPDATES_CHANNEL => { processor: configuration.on_txn_update },
+      }
+    })
   end
+
 end

data/lib/bloom_remit_client/client.rb

@@ -1,144 +1,17 @@
 # frozen_string_literal: true
 module BloomRemitClient
   class Client
-    include Virtus.model
-    include ActiveModel::Validations
+    include APIClientBase::Client.module(default_opts: :default_opts)
 
-    attribute :api_token, String
+    attribute :partner_id, String
     attribute :api_secret, String
-    attribute :agent_id, String
     attribute :host, String, lazy: true, default: :default_host
-    attribute :sandbox, Boolean, default: true
 
-    validates :host, presence: true
-    validates :sandbox, inclusion: { in: [true, false] }
+    api_action :create_txn
+    api_action :create_txn_preview
 
-    # GET
-    # /api/v1/partners/:api_token/credits
-    # Parameters: none
-    def credits(params = {})
-      request_params = params.merge(access_params)
-      request = Requests::Credit::List.new(request_params)
-      request.call!
-    end
-
-    # GET
-    # /api/v1/partners/:api_token/credits/history
-    # Parameters: none
-    def credits_history(params = {})
-      request_params = params.merge(access_params)
-      request = Requests::Credit::History.new(request_params)
-      request.call!
-    end
-
-    # GET
-    # /api/v1/rates
-    # Parameters:
-    #   partner_id:
-    #     String, required
-    #     API token
-    #   api_secret:
-    #     String, required
-    #   currency:
-    #     One of: [USDPHP, USDUSD, USDKRW, USDAUD, USDCAD, USDJPY, USDNZD, USDSGD, USDHKD,
-    #              USDCNY, USDEUR, USDVND, USDSAR, USDTWD, USDQAR, USDKWD, USDAED, USDGBP,
-    #              USDMYR, USDINR, USDIDR, USDBTC],
-    #     optional
-    def rates(params = {})
-      request_params = params.merge(access_params)
-      request = Requests::Rate::Show.new(request_params)
-      request.call!
-    end
-
-    def billers(params={})
-      request_params = params.merge(access_params)
-      request = Requests::Billers::List.new(request_params)
-      raw_response = request.call!
-      Responses::Billers::List.new(raw_response: raw_response)
-    end
-
-    def create_sender(sender_params={})
-      params = {sender: sender_params}
-      request_params = params.merge(default_params).merge(access_params)
-      request = Requests::Senders::Create.new(request_params)
-      raw_response = request.call!
-      Responses::Senders::Create.new(raw_response: raw_response)
-    end
-
-    def create_payment(payment_params={})
-      params = {payment: payment_params}.
-        merge(sender_id: payment_params[:sender_id])
-      request_params = params.merge(default_params).merge(access_params)
-      request = Requests::Payments::Create.new(request_params)
-      raw_response = request.call!
-      Responses::Payments::Create.new(raw_response: raw_response)
-    end
-
-    def create_recipient(recipient_params={})
-      params = {recipient: recipient_params}.
-        merge(sender_id: recipient_params[:sender_id])
-      request_params = params.merge(default_params).merge(access_params)
-      request = Requests::Recipients::Create.new(request_params)
-      raw_response = request.call!
-      Responses::Recipients::Create.new(raw_response: raw_response)
-    end
-
-    def recipient_list(recipient_params={})
-      request_params = recipient_params.merge(access_params)
-      request = Requests::Recipients::List.new(request_params)
-      raw_response = request.call!
-      Responses::Recipients::List.new(raw_response: raw_response)
-    end
-
-    def create_remittance(remittance_params={})
-      params = {remittance: remittance_params}.
-        merge(sender_id: remittance_params[:sender_id]).
-        merge(recipient_id: remittance_params[:recipient_id])
-      request_params = params.merge(default_params).merge(access_params)
-      request = Requests::Remittances::Create.new(request_params)
-      raw_response = request.call!
-      Responses::Remittances::Create.new(raw_response: raw_response)
-    end
-
-    def calculate_remittance(calculate_params={})
-      params = access_params.merge(calculate_params)
-      request = Requests::Remittances::Calculate.new(params)
-      raw_response = request.call!
-      Responses::Remittances::Calculate.new(raw_response: raw_response)
-    end
-
-    def deposit_strategies_list
-      request_params = access_params
-      request = Requests::DepositStrategies::List.new(request_params)
-      raw_response = request.call!
-      Responses::DepositStrategies::List.new(raw_response: raw_response)
-    end
-
-    def create_txn(txn_params={})
-      params = {txn: txn_params}.merge(
-        sender_id: txn_params[:sender_id],
-        recipient_id: txn_params[:recipient_id],
-      )
-      request_params = params.merge(default_params).merge(access_params)
-      request = Requests::Txns::Create.new(request_params)
-      raw_response = request.call!
-      Responses::Txns::Create.new(raw_response: raw_response)
-    end
-
-    private
-
-    # Should overwrite any other `:api_token`, `:api_secret`
-    def access_params
-      @access_params ||= attributes.slice(:host, :api_token, :api_secret)
-    end
-
-    def default_params
-      @default_params ||= attributes.slice(:agent_id)
-    end
-
-    def default_host
-      return BloomRemitClient::STAGING if self.sandbox.nil? || self.sandbox
-      BloomRemitClient::PRODUCTION
+    def default_opts
+      { host: host, partner_id: partner_id, api_secret: api_secret }
     end
 
   end

data/lib/bloom_remit_client/factories.rb

@@ -25,4 +25,27 @@ FactoryGirl.define do
     body { {"json" => "value"} }
   end
 
+  factory(:bloom_remit_client_responses_recipients_create, {
+    class: "BloomRemitClient::Responses::Recipients::Create",
+  }) do
+    success true
+    body { {"json" => "value"} }
+  end
+
+  factory(:bloom_remit_client_responses_recipients_list, {
+    class: "BloomRemitClient::Responses::Recipients::List",
+  }) do
+    success true
+    recipients do
+      [
+        build(:bloom_remit_client_recipient),
+        build(:bloom_remit_client_recipient),
+      ]
+    end
+  end
+
+  factory :bloom_remit_client_recipient, class: "BloomRemitClient::Recipient" do
+    id { SecureRandom.uuid }
+  end
+
 end