bloom_remit 0.2.1 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 719f89bbf5856431f18ebe7c3950dd10f68f0a76
-  data.tar.gz: 98a247d1cde20c61b91751b41673c5c9a18267a0
+  metadata.gz: 531182e14ce01cc26b8d22289c39e93b166e1e86
+  data.tar.gz: 8d1888fe7681b257dd8db0660241a4dd7cd513ce
 SHA512:
-  metadata.gz: 628c4dfa4f89d444be0670ac3a5cb0465549b9dd0ce413c2043a607c92afdba3af4c960127851b6a0ee225cdcd7af7b5d5b09d07ff334abc4c0ab08223d4fb60
-  data.tar.gz: 9ef5f0d779febd3e6318a9e35155145b7d620b2b397401619f6788f39a906314c45da16b38c39ef8d745b6f4430e671af5e5e540e1a7e05ba9d1aad092ac134c
+  metadata.gz: f68751ada937788bda344ab7e7ee27f08442b87f056cc2621db0163f4631041c719140ca08bacd5fba2da3f6c989d68e800baa80fc0c97e9c2c6164f2fec4440
+  data.tar.gz: 375a3ccba4528c9f026377c0aa9ad32abff5b88c46f93b2bd6e4e6f66a81111677f7fb46da2484b3f2daaa1728d787c38e1ad58cb679439975dba09f40c80614

data/app/concepts/bloom_remit/txns/contracts/create.rb

@@ -12,6 +12,9 @@ module BloomRemit
         property :target_slug
         property :owner_id
         property :owner_type
+        property :external_id
+
+        validates :external_id, presence: true
 
       end
     end

data/app/services/bloom_remit/create_txn.rb

@@ -1,7 +1,15 @@
 module BloomRemit
   class CreateTxn
 
-    def self.call(target_slug:, sender:, owner:, amount:, account_name:, account_id:)
+    def self.call(
+      target_slug:,
+      sender:,
+      owner:,
+      amount:,
+      account_name:,
+      account_id:,
+      external_id:
+    )
       Txns::Operations::Create.(txn: {
         sender_id: sender.id,
         sender_type: sender.class.base_class.name,
@@ -11,6 +19,7 @@ module BloomRemit
         target_slug: target_slug,
         owner_id: owner.id,
         owner_type: owner.class.base_class.name,
+        external_id: external_id,
       })
     end
 

data/app/services/bloom_remit/txns/post.rb

@@ -21,6 +21,7 @@ module BloomRemit
           payout_method: txn.target_slug,
           paid_in_orig_currency: txn.amount,
           receivable_in_dest_currency: txn.amount,
+          external_id: txn.external_id,
         )
       end
 

data/db/migrate/20160808081300_add_external_id_to_txns.rb

@@ -0,0 +1,6 @@
+class AddExternalIdToTxns < ActiveRecord::Migration
+  def change
+    add_column :bloom_remit_txns, :external_id, :string, null: false
+    add_index :bloom_remit_txns, :external_id
+  end
+end

data/lib/bloom_remit/factories/txn.rb

@@ -4,6 +4,7 @@ FactoryGirl.define do
     target_slug "TARGET_SLUG"
     amount 2500
     secret { SecureRandom.uuid }
+    external_id { SecureRandom.hex(12) }
   end
 
 end

data/lib/bloom_remit/version.rb

@@ -1,3 +1,3 @@
 module BloomRemit
-  VERSION = "0.2.1"
+  VERSION = "0.3.0"
 end

data/spec/concepts/bloom_remit/txns/contracts/create_spec.rb

@@ -0,0 +1,16 @@
+require 'rails_helper'
+
+module BloomRemit
+  module Txns
+    module Contracts
+      RSpec.describe Create, type: %i[model] do
+
+        describe "validations" do
+          subject { described_class.new(Txn.new) }
+          it { is_expected.to validate_presence_of(:external_id) }
+        end
+
+      end
+    end
+  end
+end

data/spec/concepts/bloom_remit/txns/operations/create_spec.rb

@@ -8,6 +8,7 @@ module BloomRemit
         let(:user) { create(:bloom_remit_dummy_sub_user) }
         let(:biller) { create(:bloom_remit_dummy_biller, slug: "PLDT") }
         let(:payment) { create(:bloom_remit_dummy_sub_payment) }
+        let(:external_id) { SecureRandom.hex(12) }
 
         it "creates a txn with a secret and enqueues the PayoutJob" do
           op = described_class.(txn: {
@@ -19,6 +20,7 @@ module BloomRemit
             account_id: "Hooli X",
             owner_id: payment.id,
             owner_type: payment.class.base_class.name,
+            external_id: external_id,
           })
           txn = op.model
           expect(txn.target_slug).to eq biller.slug
@@ -27,6 +29,7 @@ module BloomRemit
           expect(txn.account_name).to eq "028109090"
           expect(txn.account_id).to eq "Hooli X"
           expect(txn.owner).to eq payment
+          expect(txn.external_id).to eq external_id
           expect(PayoutJob).to have_enqueued_job(txn.id)
         end
 

data/spec/dummy/db/schema.rb

@@ -11,7 +11,7 @@
 #
 # It's strongly recommended that you check this file into your version control system.
 
-ActiveRecord::Schema.define(version: 20160806054012) do
+ActiveRecord::Schema.define(version: 20160808081300) do
 
   # These are extensions that must be enabled in order to support this database
   enable_extension "plpgsql"
@@ -40,8 +40,10 @@ ActiveRecord::Schema.define(version: 20160806054012) do
     t.string  "target_slug",              null: false
     t.string  "owner_id"
     t.string  "owner_type"
+    t.string  "external_id",              null: false
   end
 
+  add_index "bloom_remit_txns", ["external_id"], name: "index_bloom_remit_txns_on_external_id", using: :btree
   add_index "bloom_remit_txns", ["owner_id", "owner_type"], name: "index_bloom_remit_txns_on_owner_id_and_owner_type", using: :btree
 
   create_table "payments", force: :cascade do |t|

data/spec/dummy/log/development.log

@@ -1630,4 +1630,84 @@ WHERE c.contype = 'f'
   AND t1.relname = 'users'
   AND t3.nspname = ANY (current_schemas(false))
 ORDER BY c.conname
+
+  ActiveRecord::SchemaMigration Load (1.4ms)  SELECT "schema_migrations".* FROM "schema_migrations"
+Migrating to AddExternalIdToTxns (20160808081300)
+   (0.1ms)  BEGIN
+   (14.0ms)  ALTER TABLE "bloom_remit_txns" ADD "external_id" character varying NOT NULL
+   (8.8ms)  CREATE  INDEX  "index_bloom_remit_txns_on_external_id" ON "bloom_remit_txns"  ("external_id")
+  SQL (1.7ms)  INSERT INTO "schema_migrations" ("version") VALUES ($1)  [["version", "20160808081300"]]
+   (0.6ms)  COMMIT
+  ActiveRecord::SchemaMigration Load (0.1ms)  SELECT "schema_migrations".* FROM "schema_migrations"
+   (2.1ms)  SELECT t2.oid::regclass::text AS to_table, a1.attname AS column, a2.attname AS primary_key, c.conname AS name, c.confupdtype AS on_update, c.confdeltype AS on_delete
+FROM pg_constraint c
+JOIN pg_class t1 ON c.conrelid = t1.oid
+JOIN pg_class t2 ON c.confrelid = t2.oid
+JOIN pg_attribute a1 ON a1.attnum = c.conkey[1] AND a1.attrelid = t1.oid
+JOIN pg_attribute a2 ON a2.attnum = c.confkey[1] AND a2.attrelid = t2.oid
+JOIN pg_namespace t3 ON c.connamespace = t3.oid
+WHERE c.contype = 'f'
+  AND t1.relname = 'billers'
+  AND t3.nspname = ANY (current_schemas(false))
+ORDER BY c.conname
+
+   (1.9ms)  SELECT t2.oid::regclass::text AS to_table, a1.attname AS column, a2.attname AS primary_key, c.conname AS name, c.confupdtype AS on_update, c.confdeltype AS on_delete
+FROM pg_constraint c
+JOIN pg_class t1 ON c.conrelid = t1.oid
+JOIN pg_class t2 ON c.confrelid = t2.oid
+JOIN pg_attribute a1 ON a1.attnum = c.conkey[1] AND a1.attrelid = t1.oid
+JOIN pg_attribute a2 ON a2.attnum = c.confkey[1] AND a2.attrelid = t2.oid
+JOIN pg_namespace t3 ON c.connamespace = t3.oid
+WHERE c.contype = 'f'
+  AND t1.relname = 'bloom_remit_billers'
+  AND t3.nspname = ANY (current_schemas(false))
+ORDER BY c.conname
+
+   (2.0ms)  SELECT t2.oid::regclass::text AS to_table, a1.attname AS column, a2.attname AS primary_key, c.conname AS name, c.confupdtype AS on_update, c.confdeltype AS on_delete
+FROM pg_constraint c
+JOIN pg_class t1 ON c.conrelid = t1.oid
+JOIN pg_class t2 ON c.confrelid = t2.oid
+JOIN pg_attribute a1 ON a1.attnum = c.conkey[1] AND a1.attrelid = t1.oid
+JOIN pg_attribute a2 ON a2.attnum = c.confkey[1] AND a2.attrelid = t2.oid
+JOIN pg_namespace t3 ON c.connamespace = t3.oid
+WHERE c.contype = 'f'
+  AND t1.relname = 'bloom_remit_responses'
+  AND t3.nspname = ANY (current_schemas(false))
+ORDER BY c.conname
+
+   (2.5ms)  SELECT t2.oid::regclass::text AS to_table, a1.attname AS column, a2.attname AS primary_key, c.conname AS name, c.confupdtype AS on_update, c.confdeltype AS on_delete
+FROM pg_constraint c
+JOIN pg_class t1 ON c.conrelid = t1.oid
+JOIN pg_class t2 ON c.confrelid = t2.oid
+JOIN pg_attribute a1 ON a1.attnum = c.conkey[1] AND a1.attrelid = t1.oid
+JOIN pg_attribute a2 ON a2.attnum = c.confkey[1] AND a2.attrelid = t2.oid
+JOIN pg_namespace t3 ON c.connamespace = t3.oid
+WHERE c.contype = 'f'
+  AND t1.relname = 'bloom_remit_txns'
+  AND t3.nspname = ANY (current_schemas(false))
+ORDER BY c.conname
+
+   (1.9ms)  SELECT t2.oid::regclass::text AS to_table, a1.attname AS column, a2.attname AS primary_key, c.conname AS name, c.confupdtype AS on_update, c.confdeltype AS on_delete
+FROM pg_constraint c
+JOIN pg_class t1 ON c.conrelid = t1.oid
+JOIN pg_class t2 ON c.confrelid = t2.oid
+JOIN pg_attribute a1 ON a1.attnum = c.conkey[1] AND a1.attrelid = t1.oid
+JOIN pg_attribute a2 ON a2.attnum = c.confkey[1] AND a2.attrelid = t2.oid
+JOIN pg_namespace t3 ON c.connamespace = t3.oid
+WHERE c.contype = 'f'
+  AND t1.relname = 'payments'
+  AND t3.nspname = ANY (current_schemas(false))
+ORDER BY c.conname
+
+   (2.3ms)  SELECT t2.oid::regclass::text AS to_table, a1.attname AS column, a2.attname AS primary_key, c.conname AS name, c.confupdtype AS on_update, c.confdeltype AS on_delete
+FROM pg_constraint c
+JOIN pg_class t1 ON c.conrelid = t1.oid
+JOIN pg_class t2 ON c.confrelid = t2.oid
+JOIN pg_attribute a1 ON a1.attnum = c.conkey[1] AND a1.attrelid = t1.oid
+JOIN pg_attribute a2 ON a2.attnum = c.confkey[1] AND a2.attrelid = t2.oid
+JOIN pg_namespace t3 ON c.connamespace = t3.oid
+WHERE c.contype = 'f'
+  AND t1.relname = 'users'
+  AND t3.nspname = ANY (current_schemas(false))
+ORDER BY c.conname