blogit 0.4.8 → 0.5.0

data/spec/helpers/blogit/application_helper_spec.rb

@@ -1,14 +1,14 @@
 require "spec_helper"
 
 describe Blogit::ApplicationHelper do
-  
+
   describe "format_content" do
-        
+
     it "should convert markdown text to html if conf is :markdown" do
       Blogit.configure { |c| c.default_parser = :markdown }
       helper.format_content("## Hello\n\nWorld").should match(/<h2>Hello<\/h2>\n\n<p>World<\/p>/)
     end
-    
+
     it "should convert textile text to html if conf is :textile" do
       Blogit.configure { |c| c.default_parser = :textile }
       helper.format_content("h1. Hello\n\nWorld").should == "<h1>Hello</h1>\n<p>World</p>"
@@ -19,16 +19,71 @@ describe Blogit::ApplicationHelper do
       helper.format_content("<h1>Hello</h1>\n\n<p>World</p>").should == "<h1>Hello</h1>\n\n<p>World</p>"
     end
 
-    
+
   end
-  
+
   describe :actions do
-    
+
     it "should create a div with class 'actions'" do
       helper.actions do
         "hello"
       end.should == %{<div class="actions">hello</div>}
     end
-    
+
+  end
+
+  describe "main app's named routes" do
+
+
+    # rspec generates a helper by mixin in the tested helper and the application
+    # helper. But this is not what is being done by rails inside an engine.
+    # This mockery is more like the real thing
+    class MainAppApplicationHelperBench
+      def dummy_thing_path
+        "/dummy_thing"
+      end
+      def dummy_thing_url
+        "http://host/dummy_thing"
+      end
+      def secret
+      end
+    end
+    class BlogitApplicationHelperBench
+      include Blogit::ApplicationHelper
+
+      def main_app
+        MainAppApplicationHelperBench.new
+      end
+    end
+
+    let(:raw_helper) { BlogitApplicationHelperBench.new }
+
+    it "should not know named routes of the main app if not configured" do
+      Blogit.configure {|c| c.inline_main_app_named_routes = false }
+
+      lambda { raw_helper.dummy_thing_path }.should raise_error(NoMethodError)
+      lambda { raw_helper.dummy_thing_url }.should raise_error(NoMethodError)
+    end
+
+    it "should know named routes of the main app" do
+      Blogit.configure {|c| c.inline_main_app_named_routes = true }
+
+      raw_helper.dummy_thing_path.should == "/dummy_thing"
+      raw_helper.dummy_thing_url.should == "http://host/dummy_thing"
+    end
+
+    it "should not know anything but named routes of the main app" do
+      Blogit.configure {|c| c.inline_main_app_named_routes = true }
+
+      lambda { raw_helper.secret }.should raise_error(NoMethodError)
+    end
+
+    it "should not know other routes" do
+      Blogit.configure {|c| c.inline_main_app_named_routes = true }
+
+      lambda { raw_helper.junk_path }.should raise_error(NoMethodError)
+      lambda { raw_helper.junk_url }.should raise_error(NoMethodError)
+    end
+
   end
-end
+end

data/spec/helpers/blogit/posts_helper_spec.rb

@@ -1,14 +1,122 @@
+# -*- coding: utf-8 -*-
 require "spec_helper"
 
 describe Blogit::PostsHelper do
-  
+
   describe :blog_post_tag do
-    
+
     it "should create a tag element and give it a 'blog_post... prefixed class" do
       helper.blog_post_tag(:div, "hello", id: "blog_div", class: "other_class").should == %{<div class="other_class blog_post_div" id="blog_div">hello</div>}
-      helper.blog_post_tag(:li, "hello", id: "blog_li").should == %{<li class="blog_post_li" id="blog_li">hello</li>}      
+      helper.blog_post_tag(:li, "hello", id: "blog_li").should == %{<li class="blog_post_li" id="blog_li">hello</li>}
+    end
+
+  end
+
+  describe :comments_for do
+    let(:post) { FactoryGirl.create :post }
+
+    it "should be empty if comments are not configured" do
+      Blogit.configure do |config|
+        config.include_comments = :no
+      end
+
+      helper.comments_for(post).should == ""
+    end
+
+    it "should be full html when comments use active record" do
+      Blogit.configure do |config|
+        config.include_comments = :active_record
+      end
+
+      comment = Blogit::Comment.new
+      Blogit::Comment.expects(:new).returns(comment)
+      helper.expects(:render).with(partial: "blogit/posts/active_record_comments", locals: {post: post, comment: comment})
+      helper.comments_for(post)
+    end
+  end
+
+  describe :share_bar_for do
+    let(:post) { FactoryGirl.create :post }
+
+    it "should be empty if not configured" do
+      Blogit.configure do |config|
+        config.include_share_bar = false
+      end
+
+      helper.share_bar_for(post).should == ""
+    end
+
+    it "should render a share bar if configured" do
+      Blogit.configure do |config|
+        config.include_share_bar = true
+      end
+
+      helper.expects(:render).with(partial: "blogit/posts/share_bar", locals: {post: post}).returns(share_bar_html='<div id="share-bar">...</div>')
+      helper.share_bar_for(post).should == share_bar_html
     end
-    
   end
-  
-end
+
+  describe :blog_post_archive do
+
+    before :each do
+      Post.delete_all
+    end
+    after :each do
+      Post.delete_all
+    end
+
+
+    it "should create an ul tag tree with years, monthes and articles" do
+      dec_2011 = FactoryGirl.create(:post, title: "Great post 1", created_at: Time.new(2011, 12, 25))
+      july_2012_1 = FactoryGirl.create(:post, title: "Great Post 2", created_at: Time.new(2012,7,14))
+      july_2012_2 = FactoryGirl.create(:post, title: "Great Post 3", created_at: Time.new(2012,7,28))
+      sept_2012 = FactoryGirl.create(:post, title: "Great Post 4", created_at: Time.new(2012,9, 3))
+
+      year_css = "archive-years"
+      month_css = "archive-month"
+      post_css = "archive-post"
+
+      helper.blog_posts_archive_tag(year_css, month_css, post_css).should == ["<ul class=\"#{year_css}\">",
+                                                                                "<li><a onclick=\"toggleBrothersDisplay(this, 'UL')\">2011</a>",
+                                                                                  "<ul class=\"#{month_css}\">",
+                                                                                    "<li><a onclick=\"toggleBrothersDisplay(this, 'UL')\">December</a>",
+                                                                                      "<ul class=\"#{post_css}\">",
+                                                                                        "<li><a href=\"#{blogit.post_path(dec_2011)}\">#{dec_2011.title}</a></li>",
+                                                                                      "</ul>",
+                                                                                    "</li>",
+                                                                                  "</ul>",
+                                                                                "</li>",
+                                                                                "<li><a onclick=\"toggleBrothersDisplay(this, 'UL')\">2012</a>",
+                                                                                  "<ul class=\"#{month_css}\">",
+                                                                                    "<li><a onclick=\"toggleBrothersDisplay(this, 'UL')\">July</a>",
+                                                                                      "<ul class=\"#{post_css}\">",
+                                                                                        "<li><a href=\"#{blogit.post_path(july_2012_1)}\">#{july_2012_1.title}</a></li>",
+                                                                                        "<li><a href=\"#{blogit.post_path(july_2012_2)}\">#{july_2012_2.title}</a></li>",
+                                                                                      "</ul>",
+                                                                                    "</li>",
+                                                                                    "<li><a onclick=\"toggleBrothersDisplay(this, 'UL')\">September</a>",
+                                                                                      "<ul class=\"#{post_css}\">",
+                                                                                        "<li><a href=\"#{blogit.post_path(sept_2012)}\">#{sept_2012.title}</a></li>",
+                                                                                      "</ul>",
+                                                                                    "</li>",
+                                                                                  "</ul>",
+                                                                                "</li>",
+                                                                              "</ul>"].join
+    end
+
+    it "should escape html in titles" do
+      post = FactoryGirl.create(:post, title: ">Great Post with html characters<", created_at: Time.new(2012,9, 3))
+
+      archive_tag = helper.blog_posts_archive_tag('y','m','p')
+
+      archive_tag.should_not include(post.title)
+      archive_tag.should include(CGI.escape_html(post.title))
+    end
+
+    it "should be a safe html string" do
+      helper.blog_posts_archive_tag('y','m','p').should be_html_safe
+    end
+
+  end
+
+end

data/spec/lib/blogit/parsers/markdown_parser_spec.rb

@@ -11,13 +11,17 @@ describe Blogit::Parsers::MarkdownParser do
 
   describe "code highlighting" do
 
-    let(:parser) { 
-      Blogit::Parsers::MarkdownParser.new("## Header\n\n``` ruby\nputs 'hello world'\n```") 
+    let(:parser) {
+      Blogit::Parsers::MarkdownParser.new("## Header\n\n``` ruby\nputs 'hello world'\n```")
     }
 
+    it "requires pymentize to run" do
+      system("pygmentize > /dev/null").should equal(true), "It seems that pygmentize is not installed on your system"
+    end
+
     it "should highlight code if highlight_code_syntax is true" do
       Blogit::configuration.highlight_code_syntax = true
-      parser.parsed.should =~ 
+      parser.parsed.should =~
       Regexp.new("<h2>Header</h2>\n<div class=\"highlight\"><pre><span class=\"nb\">puts</span> <span class=\"s1\">&#39;hello world&#39;</span>\n</pre>\n</div>\n")
     end
 

data/spec/lib/configuration_spec.rb

@@ -1,41 +1,65 @@
 require "spec_helper"
 
 describe Blogit::Configuration do
-  
+
   let(:blog_configuration) { @blog_configuration = Blogit::Configuration.new }
+
+  it "should set :include_comments to :active_record" do
+    blog_configuration.include_comments.should == :active_record
+  end
+
+  it "should set :disqus_shortname to blank" do
+    blog_configuration.disqus_shortname.should == ""
+  end
   
-  it "should set :include_comments to true" do
-    blog_configuration.include_comments.should be_true
+  it "should print a warning to the console if disqus_shortname is set but include_comments is not disqus" do
+    blog_configuration.expects(:warn)
+    blog_configuration.include_comments = :active_record
+    blog_configuration.disqus_shortname = "bodacious"
+  end
+
+  it "should print a warning to the console if twitter_username is set but include_share_bar is false" do
+    blog_configuration.expects(:warn)
+    blog_configuration.include_share_bar = true
+    blog_configuration.twitter_username = "bodacious"
+  end
+
+  it "should set :include_share_bar to false" do
+    blog_configuration.include_share_bar.should == false
+  end
+
+  it "should set :twitter_username to blank" do
+    blog_configuration.twitter_username.should == ""
   end
 
   it "should set :current_blogger_method to :current_user" do
     blog_configuration.current_blogger_method.should eql(:current_user)
   end
-  
+
   it "should set :blogger_display_name_method to :username" do
     blog_configuration.blogger_display_name_method.should eql(:username)
   end
-  
+
   it "should set :posts_per_page to 5" do
     blog_configuration.posts_per_page.should eql(5)
   end
-  
+
   it "should set :authentication_method to :login_required" do
     blog_configuration.authentication_method.should == :login_required
   end
-  
+
   it "should set datetime format to :short" do
     blog_configuration.datetime_format.should == :short
   end
-  
+
   it "should set author_edits_only to false" do
     blog_configuration.author_edits_only.should be_false
   end
-  
+
   it "should set ajax comments to true" do
     blog_configuration.ajax_comments.should be_true
   end
-  
+
   it "should set include admin actions to true" do
     blog_configuration.include_admin_actions.should be_true
   end
@@ -43,7 +67,7 @@ describe Blogit::Configuration do
   it "should set include admin links to true" do
     blog_configuration.include_admin_links.should be_true
   end
-  
+
   it "should set page caching to false by default" do
     blog_configuration.cache_pages.should be_false
   end
@@ -51,14 +75,14 @@ describe Blogit::Configuration do
   it "should set default_parser to :markdown" do
     blog_configuration.default_parser.should eql(:markdown)
   end
-  
+
   it "should return default_parser as class with default_parser_class" do
     blog_configuration.default_parser = :textile
     blog_configuration.default_parser_class.should eql(Blogit::Parsers::TextileParser)
   end
-  
+
   it "should set redcarpet default options" do
-    blog_configuration.redcarpet_options.should == 
+    blog_configuration.redcarpet_options.should ==
       {
         hard_wrap: true,
         filter_html: true,
@@ -68,15 +92,15 @@ describe Blogit::Configuration do
         gh_blockcode: true
       }
   end
-  
+
   it "should set highlight_code_syntax to true" do
     blog_configuration.highlight_code_syntax.should be_true
   end
-  
+
   it "should set rss_feed_title to 'Rails engine name Blog Posts'" do
     blog_configuration.rss_feed_title.should eql "#{Rails.application.engine_name.titleize} Blog Posts"
   end
-  
+
   it "should set rss_feed_description to 'Rails engine name Blog Posts'" do
     blog_configuration.rss_feed_description.should eql "#{Rails.application.engine_name.titleize} Blog Posts"
   end
@@ -84,5 +108,5 @@ describe Blogit::Configuration do
   it "should set rss_feed_language to 'Rails engine name Blog Posts'" do
     blog_configuration.rss_feed_language.should eql "en"
   end
-  
-end
+
+end

data/spec/models/blogit/post_spec.rb

@@ -1,19 +1,19 @@
 require "spec_helper"
 
 describe Blogit::Post do
-  
+
   context "should not be valid" do
-    
+
     context "if blogger" do
-      
+
       it "is nil" do
         @blog_post = Blogit::Post.new
         @blog_post.should_not be_valid
         @blog_post.should have(1).error_on(:blogger_id)
       end
-      
+
     end
-    
+
     context "if title" do
       before do
         @blog_post = Blogit::Post.new
@@ -35,9 +35,9 @@ describe Blogit::Post do
       it "is longer than 66 characters" do
         @blog_post.title = "a" * 67
       end
-            
+
     end
-    
+
     context "if body" do
       before do
         @blog_post = Blogit::Post.new
@@ -47,47 +47,47 @@ describe Blogit::Post do
         @blog_post.should_not be_valid
         @blog_post.errors[:body].should_not be_blank
       end
-      
+
       it "is blank" do
         # defined above
       end
-      
+
       it "is shorter than 10 characters" do
         @blog_post.body = "a" * 9
       end
-      
+
     end
-    
+
   end
-  
-  context "with Blogit.configuration.comments == true" do
-    it "should have many comments if " do
+
+  context "with Blogit.configuration.comments == active_record" do
+    it "should allow comments" do
       Blogit.configure do |config|
-        # this should be true by default anyway
-        config.include_comments = true
+        # this should be :active_record by default anyway
+        config.include_comments = :active_record
       end
       User.blogs
       @blog_post = Blogit::Post.new
-      lambda { @blog_post.comments }.should_not raise_exception(NoMethodError)
+      lambda { @blog_post.comments }.should_not raise_exception(RuntimeError)
     end
-    
+
   end
-  
+
   describe "blogger_display_name" do
-    
+
     before :all do
       User.blogs
     end
-    
+
     let(:user) { User.create! username: "Jeronimo", password: "password" }
-    
+
     it "should return the display name of the blogger if set" do
       @post = user.blog_posts.build
       @post.blogger_display_name.should == "Jeronimo"
       Blogit.configuration.blogger_display_name_method = :password
       @post.blogger_display_name.should == "password"
     end
-    
+
     it "should return an empty string if blogger doesn't exist" do
       Blogit.configuration.blogger_display_name_method = :username
       @post = Blogit::Post.new
@@ -99,55 +99,53 @@ describe Blogit::Post do
       @post = user.blog_posts.build
       lambda { @post.blogger_display_name }.should raise_exception(Blogit::ConfigurationError)
     end
-    
+
   end
-  
+
   describe "scopes" do
-        
+
     describe :for_index do
-      
+
       before :all do
         Blogit::Post.destroy_all
         15.times { |i| create :post, created_at: i.days.ago }
       end
-      
+
       it "should order posts by created_at DESC" do
         Blogit::Post.for_index.first.should == Blogit::Post.order("created_at DESC").first
       end
-      
+
       it "should paginate posts in blocks of 5" do
         Blogit::Post.for_index.count.should == 5
       end
-      
+
       it "should accept page no as an argument" do
         Blogit::Post.for_index(2).should == Blogit::Post.order("created_at DESC").offset(5).limit(5)
       end
-      
+
       it "should change the no of posts per page if paginates_per is set" do
         Blogit::Post.paginates_per 3
         Blogit::Post.for_index.count.should eql(3)
       end
-      
-      
+
+
+    end
+
+
+  end
+
+
+  describe "with Blogit.configuration.comments != active_record" do
+
+    it "should not allow comments" do
+      Blogit.configure do |config|
+        config.include_comments = :no
+      end
+      User.blogs
+      @blog_post = Blogit::Post.new
+      lambda { @blog_post.comments }.should raise_exception(RuntimeError)
     end
-    
-    
+
   end
-  
-
-  # TODO: Find a better way to test this
-  # describe "with Blogit.configuration.comments == false" do
-  # 
-  #   it "should not have many comments if Blogit.configuration.comments == false" do
-  #     Blogit.configure do |config|
-  #       # this should be true by default anyway
-  #       config.include_comments = false
-  #     end
-  #     User.blogs
-  #     @blog_post = Blogit::Post.new
-  #     lambda { @blog_post.comments }.should raise_exception(NoMethodError)
-  #   end
-  # 
-  # end
-  
-end
+
+end