blobby 1.1.0 → 1.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 0910a3f2446d9f9eb7cad9f724c8df57cc5d85ac
-  data.tar.gz: 2c26dc843a4a15c5894209b590f5b4d01078af14
+SHA256:
+  metadata.gz: 67ca328dc05a4815849e20344653b233411a73d1484105ce915f34d96a9cbf70
+  data.tar.gz: 8e8ab7afbf19d10d34bf21f289a5892ac9e82de52386a8da500681848a70b80b
 SHA512:
-  metadata.gz: 9c49f221a912ebbc99a8fadfa2e3643d98c004c1e040e0c0a87368a69c6050bd7a2581ce6824841a91343a8ec67ef8f915a91f16c28a97d5f8830d4d51661304
-  data.tar.gz: 86eeb3dd9fdfecd3864dc92d16ef087c38947cec898be4cdc5e02483b86eb6e108a0227121fafb40d1206126f9e10fe5d733c59a37c9bbe794e394081a1378ed
+  metadata.gz: 8eb1a0c469b4a48df3f6ac73d16e6f2abff3d570b9ac7816b3362c07156bdb794c5ac568d4c31d23045e3e42619553b8d5bbcc948e8d1f5656903ea265543ef6
+  data.tar.gz: b10329fb3b4068503e1e3062d7644687274a5ce62f823db786055f54f97d3a3f2c58a273dd082efff1b6a7d5f411c47b1bdd897617ccc85c51bb06bfdd325513

data/.rubocop.yml

@@ -1,17 +1,32 @@
-Eval:
-  Exclude:
-    - "Rakefile"
-    - "**/version.rb"
+AllCops:
+  TargetRubyVersion: 2.4
 
-Metrics/AbcSize:
+Layout/EmptyLinesAroundBlockBody:
+  Enabled: false
+
+Layout/EmptyLinesAroundClassBody:
+  EnforcedStyle: empty_lines
+
+Layout/EmptyLinesAroundModuleBody:
   Enabled: false
 
-Metrics/LineLength:
+Layout/LineLength:
   Max: 120
 
+Metrics/AbcSize:
+  Enabled: false
+
+Metrics/BlockLength:
+  Exclude:
+    - "spec/**/*"
+
 Metrics/MethodLength:
   Max: 30
 
+Naming/FileName:
+  Exclude:
+    - "bin/*"
+
 Style/ClassAndModuleChildren:
   EnforcedStyle: nested
   Exclude:
@@ -21,23 +36,9 @@ Style/Documentation:
   Exclude:
     - "spec/**/*"
 
-Style/EmptyLinesAroundBlockBody:
+Style/FormatStringToken:
   Enabled: false
 
-Style/EmptyLinesAroundClassBody:
-  EnforcedStyle: empty_lines
-
-Style/EmptyLinesAroundModuleBody:
-  Enabled: false
-
-Style/Encoding:
-  EnforcedStyle: when_needed
-  Enabled: true
-
-Style/FileName:
-  Exclude:
-    - "bin/*"
-
 Style/HashSyntax:
   EnforcedStyle: hash_rockets
 

data/.travis.yml

@@ -1,5 +1,5 @@
 language: ruby
 rvm:
-  - 2.0.0
-  - 2.1.5
-  - 2.2.0
+  - 2.4
+  - 2.5
+  - 2.6

data/CHANGES.md

@@ -1,3 +1,7 @@
+## 1.1.1 (2020-01-02)
+
+* Refresh dependencies and minor cleanup.
+
 ## 1.1.0 (2016-05-22)
 
 * Add `Blobby.store` factory-method.

data/Gemfile

@@ -1,10 +1,13 @@
+# frozen_string_literal: true
+
 source "https://rubygems.org"
 
 # Runtime dependencies in blobby.gemspec
 gemspec
 
 # Development/test dependencies below
-gem "rake", "~> 10.0"
-gem "rspec", "~> 3.1"
+gem "rake", "~> 13.0"
+gem "rspec", "~> 3.9"
+gem "rubocop", "~> 0.78.0"
+gem "sham_rack", "~> 1.4.1"
 gem "sinatra"
-gem "sham_rack", "~> 1.3.5"

data/README.md

@@ -6,7 +6,7 @@ This gem provides a standard interface for storing big chunks of data.
 
 ## Usage
 
-It supports popular BLOBs operations such as reading:
+It supports popular BLOB operations such as reading:
 
     store["key"].read
 

data/Rakefile

@@ -1,4 +1,5 @@
 #!/usr/bin/env rake
+# frozen_string_literal: true
 
 require "bundler"
 
@@ -11,3 +12,9 @@ task "default" => "spec"
 RSpec::Core::RakeTask.new(:spec) do |t|
   t.rspec_opts = ["--colour"]
 end
+
+require "rubocop/rake_task"
+
+RuboCop::RakeTask.new
+
+task "default" => "rubocop"

data/blobby.gemspec

@@ -1,4 +1,6 @@
-$LOAD_PATH << File.expand_path("../lib", __FILE__)
+# frozen_string_literal: true
+
+$LOAD_PATH << File.expand_path("lib", __dir__)
 require "blobby/version"
 
 Gem::Specification.new do |gem|

data/lib/blobby.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "blobby/filesystem_store"
 require "blobby/http_store"
 require "blobby/in_memory_store"
@@ -20,6 +22,7 @@ module Blobby
       uri = URI(uri)
       factory = store_factories[uri.scheme]
       fail ArgumentError, "unknown store type: #{uri}" if factory.nil?
+
       factory.from_uri(uri)
     end
 

data/lib/blobby/abstract_store.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "blobby/key_constraint"
 
 module Blobby
@@ -48,11 +50,11 @@ module Blobby
       end
 
       def write(content)
-        if content.respond_to?(:read)
-          content = content.read
-        else
-          content = content.to_str.dup
-        end
+        content = if content.respond_to?(:read)
+                    content.read
+                  else
+                    content.to_str.dup
+                  end
         content = content.force_encoding("BINARY") if content.respond_to?(:force_encoding)
         @hash[key] = content
         nil

data/lib/blobby/composite_store.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Blobby
 
   # Compose a number of stores.
@@ -24,6 +26,7 @@ module Blobby
 
     attr_reader :stores
 
+    # Represents an object in the store.
     class StoredObject
 
       def initialize(objects)

data/lib/blobby/fake_success_store.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "blobby/key_constraint"
 
 module Blobby
@@ -15,6 +17,7 @@ module Blobby
       StoredObject.new
     end
 
+    # Handle to an object in the store.
     class StoredObject
 
       def exists?

data/lib/blobby/filesystem_store.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "blobby/key_constraint"
 require "fileutils"
 require "forwardable"
@@ -40,6 +42,7 @@ module Blobby
       ->(key) { key }
     end
 
+    # Represents an object in the store.
     class StoredObject
 
       def initialize(path, umask)
@@ -106,16 +109,16 @@ module Blobby
 
         tmp = nil
         begin
-          tmp = tmp_path.open(File::CREAT | File::EXCL | File::WRONLY, 0666)
+          tmp = tmp_path.open(File::CREAT | File::EXCL | File::WRONLY, 0o666)
           tmp.binmode
         rescue Errno::ENOENT
-          FileUtils.mkdir_p(store_dir.to_s, :mode => apply_umask(0777))
+          FileUtils.mkdir_p(store_dir.to_s, :mode => apply_umask(0o777))
           retry
         end
 
         begin
           yield tmp
-          tmp.chmod(apply_umask(0666)) unless using_default_umask?
+          tmp.chmod(apply_umask(0o666)) unless using_default_umask?
         ensure
           tmp.close
         end
@@ -125,6 +128,7 @@ module Blobby
           tmp_path.rename(store_path)
         rescue Errno::ESTALE
           raise unless first_try
+
           first_try = false
           now = Time.now
           File.utime(now, now, store_dir.to_s)

data/lib/blobby/http_store.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "blobby/key_constraint"
 require "net/http"
 
@@ -25,7 +27,7 @@ module Blobby
       with_http_connection do
         true
       end
-    rescue
+    rescue StandardError
       false
     end
 
@@ -42,6 +44,7 @@ module Blobby
         end
       rescue *retryable_exceptions => e
         raise e if remaining_retry_intervals.empty?
+
         sleep(remaining_retry_intervals.shift) && retry
       end
     end
@@ -52,12 +55,13 @@ module Blobby
       [EOFError, Errno::ECONNRESET]
     end
 
-    def retry_intervals(n)
+    def retry_intervals(count)
       # exponential backoff: [0.5, 1, 2, 4, 8, ...]
       scaling_factor = (0.5 + Kernel.rand * 0.1) # a little random avoids throbbing
-      Array.new(n) { |i| (2**i) * scaling_factor }
+      Array.new(count) { |i| (2**i) * scaling_factor }
     end
 
+    # Represents an object in the store.
     class StoredObject
 
       def initialize(store, key)
@@ -78,15 +82,14 @@ module Blobby
         with_http_connection do |http, path|
           http.request_get(path) do |response|
             case response
-            when Net::HTTPNotFound then
+            when Net::HTTPNotFound
               return nil
-            when Net::HTTPSuccess then
+            when Net::HTTPSuccess
               if block_given?
                 response.read_body(&block)
                 return nil
-              else
-                return response.read_body
               end
+              return response.read_body
             end
             response.error!
           end
@@ -94,11 +97,11 @@ module Blobby
       end
 
       def write(content)
-        if content.respond_to?(:read)
-          content = content.read
-        else
-          content = content.dup
-        end
+        content = if content.respond_to?(:read)
+                    content.read
+                  else
+                    content.dup
+                  end
         with_http_connection do |http, path|
           put = Net::HTTP::Put.new(path)
           put.body = content
@@ -115,9 +118,9 @@ module Blobby
           delete = Net::HTTP::Delete.new(path)
           response = http.request(delete)
           case response
-          when Net::HTTPSuccess then
+          when Net::HTTPSuccess
             true
-          when Net::HTTPNotFound then
+          when Net::HTTPNotFound
             false
           else
             response.error!

data/lib/blobby/in_memory_store.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "blobby/key_constraint"
 
 module Blobby
@@ -23,6 +25,7 @@ module Blobby
       StoredObject.new(@hash, key)
     end
 
+    # Represents an object in the store.
     class StoredObject
 
       def initialize(hash, key)
@@ -47,11 +50,11 @@ module Blobby
       end
 
       def write(content)
-        if content.respond_to?(:read)
-          content = content.read
-        else
-          content = content.to_str.dup
-        end
+        content = if content.respond_to?(:read)
+                    content.read
+                  else
+                    content.to_str.dup
+                  end
         content = content.force_encoding("BINARY") if content.respond_to?(:force_encoding)
         @hash[key] = content
         nil

data/lib/blobby/key_constraint.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "uri"
 
 module Blobby

data/lib/blobby/key_transforming_store.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "blobby/key_constraint"
 require "fileutils"
 require "forwardable"

data/lib/blobby/logging_store.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Blobby
 
   # A store decorator that logs writes and deletes
@@ -28,6 +30,7 @@ module Blobby
     attr_reader :store
     attr_reader :store_name
 
+    # Represents an object in the store.
     class StoredObject
 
       def initialize(object, callbacks = {})

data/lib/blobby/version.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Blobby
-  VERSION = "1.1.0"
+  VERSION = "1.1.1"
 end

data/spec/blobby/composite_store_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 require "blobby/composite_store"

data/spec/blobby/fake_success_store_spec.rb

@@ -1,4 +1,4 @@
-# encoding: UTF-8
+# frozen_string_literal: true
 
 require "spec_helper"
 

data/spec/blobby/filesystem_store_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 require "blobby/filesystem_store"
@@ -17,7 +19,7 @@ describe Blobby::FilesystemStore do
   around(:each) do |example|
     original_umask = File.umask
     begin
-      File.umask(0077) # something stupid
+      File.umask(0o077) # something stupid
       example.run
     ensure
       File.umask(original_umask)
@@ -46,13 +48,20 @@ describe Blobby::FilesystemStore do
     it "should have correct contents" do
       expect do
         subject[key].write(content)
-      end.to change { File.read(expected_file_path) rescue nil }.from(nil).to(content)
+      end.to change {
+               begin
+                        File.read(expected_file_path)
+               rescue StandardError
+                 nil
+                      end
+             } .from(nil).to(content)
     end
 
     it "retries if renaming throws an ESTALE" do
       raise_stack = [Errno::ESTALE]
       expect_any_instance_of(Pathname).to receive(:rename).twice do |_args|
         fail(raise_stack.shift) unless raise_stack.empty?
+
         1
       end
       expect { subject[key].write(content) }.to_not raise_error
@@ -98,9 +107,9 @@ describe Blobby::FilesystemStore do
   context "when the directory isn't writable" do
 
     around do |example|
-      FileUtils.chmod(0500, @tmpdir)
+      FileUtils.chmod(0o500, @tmpdir)
       example.run
-      FileUtils.chmod(0700, @tmpdir)
+      FileUtils.chmod(0o700, @tmpdir)
     end
 
     it { is_expected.not_to be_available }
@@ -110,9 +119,9 @@ describe Blobby::FilesystemStore do
   context "when the directory isn't readable" do
 
     around do |example|
-      FileUtils.chmod(0300, @tmpdir)
+      FileUtils.chmod(0o300, @tmpdir)
       example.run
-      FileUtils.chmod(0700, @tmpdir)
+      FileUtils.chmod(0o700, @tmpdir)
     end
 
     it { is_expected.not_to be_available }
@@ -156,17 +165,17 @@ describe Blobby::FilesystemStore do
   end
 
   def mode_string_of(path)
-    format("0%o", path.stat.mode & 0777)
+    format("0%o", path.stat.mode & 0o777)
   end
 
   context "with a umask of 0027" do
 
     subject do
-      described_class.new(@tmpdir, :umask => 0027)
+      described_class.new(@tmpdir, :umask => 0o027)
     end
 
     it "has the specified umask" do
-      expect(subject.umask).to eq(0027)
+      expect(subject.umask).to eq(0o027)
     end
 
     describe "#write" do
@@ -189,7 +198,7 @@ describe Blobby::FilesystemStore do
 
   context "without an explicit umask" do
 
-    let(:system_umask) { 0024 }
+    let(:system_umask) { 0o024 }
 
     around(:each) do |example|
       original_umask = File.umask

data/spec/blobby/http_store_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 require "ostruct"
@@ -10,7 +12,7 @@ require "sham_rack"
 describe Blobby::HttpStore do
 
   let(:backing_store) do
-    Hash.new
+    {}
   end
 
   class FakeStorageService < Sinatra::Base
@@ -58,7 +60,7 @@ describe Blobby::HttpStore do
   let(:http_storage_host) { "storeit.com" }
 
   before do
-    ShamRack.mount(fake_storage_service, http_storage_host)
+    ShamRack.at(http_storage_host).mount(fake_storage_service)
   end
 
   after do

data/spec/blobby/in_memory_store_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 require "blobby/in_memory_store"

data/spec/blobby/key_transforming_store_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 require "blobby/filesystem_store"
@@ -7,7 +9,7 @@ require "tmpdir"
 
 describe Blobby::KeyTransformingStore do
 
-  let(:memory) { Hash.new }
+  let(:memory) { {} }
 
   subject do
     described_class.new(Blobby::InMemoryStore.new(memory)) { |key| key }

data/spec/blobby/logging_store_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 require "blobby/in_memory_store"

data/spec/blobby/store_behaviour.rb

@@ -1,4 +1,4 @@
-# encoding: UTF-8
+# frozen_string_literal: true
 
 require "spec_helper"
 
@@ -100,7 +100,7 @@ shared_examples_for Blobby::Store do
 
       context "for UTF-8 content" do
 
-        let(:content) { "SN☃WMAN".freeze }
+        let(:content) { "SN☃WMAN" }
 
         before do
           stored_object.write(content)

data/spec/blobby_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 require "blobby"

data/spec/spec_helper.rb

@@ -1 +1,3 @@
+# frozen_string_literal: true
+
 ENV["RACK_ENV"] = "test"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: blobby
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 1.1.1
 platform: ruby
 authors:
 - Mike Williams
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-05-22 00:00:00.000000000 Z
+date: 2020-01-01 00:00:00.000000000 Z
 dependencies: []
 description: 
 email:
@@ -67,7 +67,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.1
+rubygems_version: 2.7.6
 signing_key: 
 specification_version: 4
 summary: Various ways of storing BLOBs