blinky 0.0.3 → 0.0.4

data/lib/device_recipes/delcom_engineering/visual_indicator_gen_two.rb

@@ -2,27 +2,27 @@ module Blinky
   module DelcomEngineering
     module VisualIndicator
       module GenerationII
-             
+
         def success! 
           set_colour("\x01") 
         end
-      
+
         def failure!  
           set_colour("\x02") 
         end
-      
+
         def building!  
           set_colour("\x04")
         end
-      
+
         def warning!
           set_colour("\x07")
         end
-      
+
         def off!
           set_colour("\x00")  
         end
-      
+
         private
         def set_colour colour
           @handle.usb_control_msg(0x21, 0x09, 0x0635, 0x000, "\x65\x0C#{colour}\xFF\x00\x00\x00\x00", 0)

data/spec/acceptance_spec.rb

@@ -2,16 +2,16 @@ require File.join(File.dirname(__FILE__), '/spec_helper')
 
 module Blinky 
   describe "Blinky" do
-    
+
     describe "that has a supported device connected" do
-  
+
       before(:each) do
-        @supported_device = OpenStruct.new(:idVendor => 0x2000, :idProduct => 0x2222)       
+        @supported_device = double("supported device",:idVendor => 0x2000, :idProduct => 0x2222)       
         self.connected_devices = [
-          OpenStruct.new(:idVendor => 0x1234, :idProduct => 0x5678),
+          double("unsupported device A",:idVendor => 0x1234, :idProduct => 0x5678),
           @supported_device,
-          OpenStruct.new(:idVendor => 0x5678, :idProduct => 0x1234)     
-          ]
+          double("unsupported device B",:idVendor => 0x5678, :idProduct => 0x1234)     
+        ]
         @blinky = Blinky.new("#{File.dirname(__FILE__)}/fixtures")
       end
 
@@ -24,7 +24,7 @@ module Blinky
         @supported_device.should_receive(:indicate_success)
         @blinky.light.success!                  
       end
-      
+
       it "can provide a light that can show where it is" do
         @supported_device.should_receive(:indicate_failure).ordered
         @supported_device.should_receive(:indicate_success).ordered
@@ -40,111 +40,111 @@ module Blinky
 
         @blinky.light.where_are_you?
       end
-      
+
     end
-    
+
     describe "that supports two devices from the same vendor" do
-      
-       it "can provide a light that can control the first device" do
-         supported_device_one = OpenStruct.new(:idVendor => 0x1000, :idProduct => 0x1111)       
-         self.connected_devices = [supported_device_one]
-         @blinky = Blinky.new("#{File.dirname(__FILE__)}/fixtures")
-         supported_device_one.should_receive(:indicate_success)
-         @blinky.light.success!                  
-       end
-
-        it "can provide a light that can control the second device" do
-          supported_device_two = OpenStruct.new(:idVendor => 0x1000, :idProduct => 0x2222)       
-          self.connected_devices = [supported_device_two]
-          @blinky = Blinky.new("#{File.dirname(__FILE__)}/fixtures")
-          supported_device_two.should_receive(:indicate_success)
-          @blinky.light.success!                 
-        end
-     end
-              
+
+      it "can provide a light that can control the first device" do
+        supported_device_one = double("supported device one", :idVendor => 0x1000, :idProduct => 0x1111)       
+        self.connected_devices = [supported_device_one]
+        @blinky = Blinky.new("#{File.dirname(__FILE__)}/fixtures")
+        supported_device_one.should_receive(:indicate_success)
+        @blinky.light.success!                  
+      end
+
+      it "can provide a light that can control the second device" do
+        supported_device_two = double("supported device two", :idVendor => 0x1000, :idProduct => 0x2222)       
+        self.connected_devices = [supported_device_two]
+        @blinky = Blinky.new("#{File.dirname(__FILE__)}/fixtures")
+        supported_device_two.should_receive(:indicate_success)
+        @blinky.light.success!                 
+      end
+    end
+
     describe "that has no supported devices connected" do
 
       before(:each) do
         @devices = [
-          OpenStruct.new(:idVendor => 0x1234, :idProduct => 0x5678),
-          OpenStruct.new(:idVendor => 0x5678, :idProduct => 0x1234)     
-          ]
-          self.connected_devices= @devices
+          double("unsupported device", :idVendor => 0x1234, :idProduct => 0x5678),
+          double("unsupported device", :idVendor => 0x5678, :idProduct => 0x1234)     
+        ]
+        self.connected_devices= @devices
+      end
+
+      it "will complain" do
+        exception = Exception.new("foo")
+        NoSupportedDevicesFound.should_receive(:new).with(@devices).and_return(exception)
+        lambda{Blinky.new("#{File.dirname(__FILE__)}/fixtures")}.should raise_error("foo")                
+      end
+
+    end
+
+    describe "that has no supported devices connected - but does have one from the same vendor" do
+
+      before(:each) do
+        @devices = [
+          double("unsupported device from known vendor", :idVendor => 0x1000, :idProduct => 0x5678),
+          double("unsupported device", :idVendor => 0x5678, :idProduct => 0x1234)     
+        ]
+        self.connected_devices= @devices
       end
-      
+
       it "will complain" do
         exception = Exception.new("foo")
         NoSupportedDevicesFound.should_receive(:new).with(@devices).and_return(exception)
         lambda{Blinky.new("#{File.dirname(__FILE__)}/fixtures")}.should raise_error("foo")                
       end
-      
-     end
- 
-     describe "that has no supported devices connected - but does have one from the same vendor" do
-
-       before(:each) do
-         @devices = [
-           OpenStruct.new(:idVendor => 0x1000, :idProduct => 0x5678),
-           OpenStruct.new(:idVendor => 0x5678, :idProduct => 0x1234)     
-           ]
-           self.connected_devices= @devices
-       end
-
-       it "will complain" do
-         exception = Exception.new("foo")
-         NoSupportedDevicesFound.should_receive(:new).with(@devices).and_return(exception)
-         lambda{Blinky.new("#{File.dirname(__FILE__)}/fixtures")}.should raise_error("foo")                
-       end
-
-      end
-             
-      describe "that has two supported devices connected" do
-
-        before(:each) do
-          @supported_device_one = OpenStruct.new(:idVendor => 0x1000, :idProduct => 0x1111)  
-          @supported_device_two = OpenStruct.new(:idVendor => 0x2000, :idProduct => 0x2222)      
-          
-          self.connected_devices = [
-            OpenStruct.new(:idVendor => 0x1234, :idProduct => 0x5678),
-            @supported_device_one,
-            @supported_device_two    
-            ]
-          @blinky = Blinky.new("#{File.dirname(__FILE__)}/fixtures")
-        end
-
-        it "will provide two lights" do
-          @blinky.light.should_not be_nil
-          @blinky.lights.length.should == 2
-        end
-
-        it "can provide lights that can control thedevices" do
-           @supported_device_one.should_receive(:indicate_success)
-           @supported_device_two.should_receive(:indicate_success)
-           @blinky.lights[0].success! 
-           @blinky.lights[1].success!                 
-        end
-      end
-        
-      describe "that provides a light that is asked to watch a supported CI server" do
-
-        before(:each) do      
-          self.connected_devices = [OpenStruct.new(:idVendor => 0x1000, :idProduct => 0x1111)]
-          @light = Blinky.new("#{File.dirname(__FILE__)}/fixtures").light
-        end
-
-        it "can receive call backs from the server" do
-          @light.should_receive(:notify_build_status)
-          @light.watch_mock_ci_server                  
-        end
-
-      end
- 
-     def connected_devices= devices
-             devices.each do |device|
-               device.stub!(:usb_open).and_return(device)
-             end
-             USB.stub!(:devices).and_return(devices)
-     end
-     
-   end   
+
+    end
+
+    describe "that has two supported devices connected" do
+
+      before(:each) do
+        @supported_device_one = double("supported device A",:idVendor => 0x1000, :idProduct => 0x1111)  
+        @supported_device_two = double("supported device B",:idVendor => 0x2000, :idProduct => 0x2222)      
+
+        self.connected_devices = [
+          double("unsupported device", :idVendor => 0x1234, :idProduct => 0x5678),
+          @supported_device_one,
+          @supported_device_two    
+        ]
+        @blinky = Blinky.new("#{File.dirname(__FILE__)}/fixtures")
+      end
+
+      it "will provide two lights" do
+        @blinky.light.should_not be_nil
+        @blinky.lights.length.should == 2
+      end
+
+      it "can provide lights that can control thedevices" do
+        @supported_device_one.should_receive(:indicate_success)
+        @supported_device_two.should_receive(:indicate_success)
+        @blinky.lights[0].success! 
+        @blinky.lights[1].success!                 
+      end
+    end
+
+    describe "that provides a light that is asked to watch a supported CI server" do
+
+      before(:each) do      
+        self.connected_devices = [double("device",:idVendor => 0x1000, :idProduct => 0x1111)]
+        @light = Blinky.new("#{File.dirname(__FILE__)}/fixtures").light
+      end
+
+      it "can receive call backs from the server" do
+        @light.should_receive(:notify_build_status)
+        @light.watch_mock_ci_server                  
+      end
+
+    end
+
+    def connected_devices= devices
+      devices.each do |device|
+        device.stub!(:usb_open).and_return(device)
+      end
+      USB.stub!(:devices).and_return(devices)
+    end
+
+  end   
 end

data/spec/blinky_spec.rb

@@ -4,7 +4,7 @@ Dir["#{File.dirname(__FILE__)}/fixtures/ci_server_plugins/**/*.rb"].each { |f| r
 
 module Blinky 
   describe "Blinky" do
-    
+
     it "will construct a light factory with the available plugins and recipes" do
       expected_plugins = [MockCiServer]
       expected_recipes = {
@@ -14,19 +14,19 @@ module Blinky
       LightFactory.should_receive(:detect_lights).with( expected_plugins, expected_recipes).and_return([])
       Blinky.new("#{File.dirname(__FILE__)}/fixtures")
     end
-    
+
     it "will make lights from the light factory available" do
-       expected_plugins = [MockCiServer]
-       expected_recipes = {
-         0x1000 => { 0x2222 => AenimaEngineering::ModelEulogy,  0x1111 => AenimaEngineering::Model462 },
-         0x2000 => { 0x2222 => FragileEngineering::ModelWretched }
-       }
-       lights = ["light one", "light two"]
-       LightFactory.should_receive(:detect_lights).and_return(lights)
-       blinky = Blinky.new("#{File.dirname(__FILE__)}/fixtures")
-       
-       blinky.lights.should eql lights
-       blinky.light.should == "light one"
-     end
+      expected_plugins = [MockCiServer]
+      expected_recipes = {
+        0x1000 => { 0x2222 => AenimaEngineering::ModelEulogy,  0x1111 => AenimaEngineering::Model462 },
+        0x2000 => { 0x2222 => FragileEngineering::ModelWretched }
+      }
+      lights = ["light one", "light two"]
+      LightFactory.should_receive(:detect_lights).and_return(lights)
+      blinky = Blinky.new("#{File.dirname(__FILE__)}/fixtures")
+
+      blinky.lights.should eql lights
+      blinky.light.should == "light one"
+    end
   end
 end

data/spec/ci_server_plugins/test_server_plugin_spec.rb

@@ -1,34 +1,34 @@
 require File.join(File.dirname(__FILE__), '..', '/spec_helper')
 require 'ci_server_plugins/test_server_plugin'
 module Blinky
-  
-    class StubBlinky
+
+  class StubBlinky
+  end
+
+  describe "TestCiServer" do
+
+    before(:each) do
+      @blinky = StubBlinky.new
+      @blinky.extend(TestCiServer)
     end
-  
-    describe "TestCiServer" do
-      
-      before(:each) do
-       @blinky = StubBlinky.new
-       @blinky.extend(TestCiServer)
-      end
-      
-      it "cycles through all possible statuses" do
-         @blinky.should_receive(:building!).ordered
-         @blinky.should_receive(:sleep).ordered
-         @blinky.should_receive(:failure!).ordered
-         @blinky.should_receive(:sleep).ordered
-         @blinky.should_receive(:building!).ordered
-         @blinky.should_receive(:sleep).ordered
-         @blinky.should_receive(:warning!).ordered
-         @blinky.should_receive(:sleep).ordered
-         @blinky.should_receive(:building!).ordered
-         @blinky.should_receive(:sleep).ordered
-         @blinky.should_receive(:success!).ordered
-         @blinky.should_receive(:sleep).ordered
-         @blinky.should_receive(:off!).ordered
-         
-         @blinky.watch_test_server
-      end
-      
-    end  
+
+    it "cycles through all possible statuses" do
+      @blinky.should_receive(:building!).ordered
+      @blinky.should_receive(:sleep).ordered
+      @blinky.should_receive(:failure!).ordered
+      @blinky.should_receive(:sleep).ordered
+      @blinky.should_receive(:building!).ordered
+      @blinky.should_receive(:sleep).ordered
+      @blinky.should_receive(:warning!).ordered
+      @blinky.should_receive(:sleep).ordered
+      @blinky.should_receive(:building!).ordered
+      @blinky.should_receive(:sleep).ordered
+      @blinky.should_receive(:success!).ordered
+      @blinky.should_receive(:sleep).ordered
+      @blinky.should_receive(:off!).ordered
+
+      @blinky.watch_test_server
+    end
+
+  end  
 end

data/spec/fixtures/ci_server_plugins/mock_ci_server.rb

@@ -1,7 +1,7 @@
 module Blinky
   module MockCiServer              
-      def watch_mock_ci_server 
-        notify_build_status
-      end      
+    def watch_mock_ci_server 
+      notify_build_status
+    end      
   end
 end

data/spec/fixtures/device_recipes/aenima_engineering/model_462.rb

@@ -1,11 +1,11 @@
 module Blinky
   module AenimaEngineering
     module Model462
-           
+
       def success! 
         @handle.indicate_success
       end
-            
+
     end
   end
 end

data/spec/fixtures/device_recipes/aenima_engineering/model_eulogy.rb

@@ -1,11 +1,11 @@
 module Blinky
   module AenimaEngineering
     module ModelEulogy
-           
+
       def success! 
         @handle.indicate_success
       end
-            
+
     end
   end
 end

data/spec/fixtures/device_recipes/fragile_engineering/wretched.rb

@@ -1,19 +1,19 @@
 module Blinky
   module FragileEngineering
     module ModelWretched
-           
+
       def success! 
         @handle.indicate_success
       end
-      
+
       def failure!  
-       @handle.indicate_failure
+        @handle.indicate_failure
       end
 
       def off!
         @handle.turn_off 
       end
-            
+
     end
   end
 end

data/spec/light_factory_spec.rb

@@ -1,64 +1,64 @@
 require File.join(File.dirname(__FILE__), '/spec_helper')
 
 module Blinky 
-  
+
   module RecipeOne
   end
 
   module RecipeTwo
   end  
-  
+
   describe "LightFactory" do
-    
+
     before do
-      
-      @device_one =  OpenStruct.new(:idVendor => 0x1234, :idProduct => 0x5678)
-      @device_two =  OpenStruct.new(:idVendor => 0x5678, :idProduct => 0x1234) 
+
+      @device_one =  double("device one", :idVendor => 0x1234, :idProduct => 0x5678)
+      @device_two =  double("device two",:idVendor => 0x5678, :idProduct => 0x1234) 
       @connected_devices = [@device_one, @device_two]
       self.connected_devices = @connected_devices
 
       @plugins = [MockCiPlugin]
     end
-    
+
     it "will build a light for each connected device for which we have a recipe" do
-       recipes = Hash.new({})
-       recipes[0x1234] = {0x5678 => RecipeOne}
-       recipes[0x5678] = {0x1234 => RecipeTwo}
-       
-       Light.should_receive(:new).with(@device_one, RecipeOne , @plugins).and_return("light one")
-       Light.should_receive(:new).with(@device_two, RecipeTwo , @plugins).and_return("light two")
-
-       lights = LightFactory.detect_lights(@plugins, recipes)
-       lights.should include "light one"
-       lights.should include "light two"
-     end     
-     
-     it "will not build a light for a connected device for which we have no recipe" do
-       recipes = Hash.new({})
-       recipes[0x1234] = {0x5678 => RecipeOne}
- 
-       Light.stub!(:new).and_return("no recipe light")
-       Light.should_receive(:new).with(@device_one, RecipeOne , @plugins).and_return("light one")
-
-       lights = LightFactory.detect_lights(@plugins, recipes)
-       lights.should eql ["light one"]
-     end
-     
-     it "will complain if there are no connected lights for which we have a recipe" do
-       recipes = Hash.new({})
-       recipes[0x9999] = {0x9999 => RecipeOne}
-
-       exception = Exception.new("foo")
-       NoSupportedDevicesFound.should_receive(:new).with(@connected_devices).and_return(exception)
-       lambda{LightFactory.detect_lights(@plugins, recipes)}.should raise_error("foo")
-     end
-   
-     def connected_devices= devices
-             devices.each do |device|
-               device.stub!(:usb_open).and_return(device)
-             end
-             USB.stub!(:devices).and_return(devices)
-     end
-     
+      recipes = Hash.new({})
+      recipes[0x1234] = {0x5678 => RecipeOne}
+      recipes[0x5678] = {0x1234 => RecipeTwo}
+
+      Light.should_receive(:new).with(@device_one, RecipeOne , @plugins).and_return("light one")
+      Light.should_receive(:new).with(@device_two, RecipeTwo , @plugins).and_return("light two")
+
+      lights = LightFactory.detect_lights(@plugins, recipes)
+      lights.should include "light one"
+      lights.should include "light two"
+    end     
+
+    it "will not build a light for a connected device for which we have no recipe" do
+      recipes = Hash.new({})
+      recipes[0x1234] = {0x5678 => RecipeOne}
+
+      Light.stub!(:new).and_return("no recipe light")
+      Light.should_receive(:new).with(@device_one, RecipeOne , @plugins).and_return("light one")
+
+      lights = LightFactory.detect_lights(@plugins, recipes)
+      lights.should eql ["light one"]
+    end
+
+    it "will complain if there are no connected lights for which we have a recipe" do
+      recipes = Hash.new({})
+      recipes[0x9999] = {0x9999 => RecipeOne}
+
+      exception = Exception.new("foo")
+      NoSupportedDevicesFound.should_receive(:new).with(@connected_devices).and_return(exception)
+      lambda{LightFactory.detect_lights(@plugins, recipes)}.should raise_error("foo")
+    end
+
+    def connected_devices= devices
+      devices.each do |device|
+        device.stub!(:usb_open).and_return(device)
+      end
+      USB.stub!(:devices).and_return(devices)
+    end
+
   end
 end