blinkist-airbrake-scrubber 4.0.1 → 4.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a083d817fd9131687fae2c4b94df7ec28ae87195ae51d3aa113405d1cdf664b7
-  data.tar.gz: b88f7ceef737368005585566571902f9982b403b0caeac275a91b01509fd6325
+  metadata.gz: 481351d1dcfaacbac3c90de8d56a3ec874ffa06ad7a594d28e8c2d836ad9017d
+  data.tar.gz: ef6af4052741c1608fa7ebefaacaca7590d33b1a5eaf97dc82c6698d080145b8
 SHA512:
-  metadata.gz: 46dead51e7abc95c97e5021117cf257c55f94205f4208cf6ecec2d5ad27ed4ee0dd49b01a3d9f96db803c47adc8650c9c7915b4868f0dcef5b966ab12accfac4
-  data.tar.gz: dfd1426d7e9296c82101ede7879268a6ba24dfd582d9971f3949bb2720be3136b5e0c071fa9c743ae71efdd786df8536a4f09f8f2d58f5c2059caf6c00edaf52
+  metadata.gz: 0e94893b4853f603fe92f21bbcadeaf281585cfd153b6fc458a6178e5331bd9da24b1842b6de2e4a3fefc8ea066b1519ff253c3351dd820fda2eb4768a4e236f
+  data.tar.gz: 71cdc6db850e77c69cff4010507a7c2977664bd46c70d62a9fef6b800a25ac8f48966791528755d2656c97566c71b51e7ebf52bf7442ffd760fd3325290a39ff

data/Gemfile

@@ -10,6 +10,7 @@ group :test do
   gem "forgery"
   gem "simplecov"
   gem "dotenv"
+  gem "rspec_junit_formatter"
 end
 
 group :development, :test do

data/lib/blinkist-airbrake-scrubber.rb

@@ -15,7 +15,7 @@ end
 module Blinkist
   module AirbrakeScrubber
     FILTERED  = '[Filtered]'
-    SCRUBBERS = [ MessageEmail, ParamsEmail, ParamsPassword ]
+    SCRUBBERS = [ MessageEmail, ParamsEmail, ParamsPassword, ParamsTokens ]
 
     # Override original Airbrake.configure
     def configure(*args, &block)

data/lib/blinkist-airbrake-scrubber/scrubbers/message_email.rb

@@ -11,7 +11,7 @@ module Blinkist
       end # def self.scrub!
 
       def self.scrub(message)
-        message.gsub(REGEXP, FILTERED)
+        message.gsub(REGEXP, FILTERED) if message
       end
 
     end

data/lib/blinkist-airbrake-scrubber/scrubbers/params_tokens.rb

@@ -0,0 +1,17 @@
+module Blinkist
+  module AirbrakeScrubber
+    class ParamsTokens
+
+      def self.scrub!
+        ::Airbrake.add_filter do |notice|
+          notice[:params] = DeepTraversal.new(notice[:params]).traverse do |key, value|
+            value = FILTERED if %w( facebook_access_token google_id_token ).include?(key.to_s)
+            value
+          end
+          notice
+        end
+      end # def self.scrub!
+
+    end
+  end
+end

data/lib/blinkist-airbrake-scrubber/version.rb

@@ -1,7 +1,7 @@
 module Blinkist
   module AirbrakeScrubber
 
-    VERSION = "4.0.1"
+    VERSION = "4.1.1"
 
   end
 end

data/spec/specs/lib/blinkist-airbrake-scrubber/scrubbers/params_tokens_spec.rb

@@ -0,0 +1,56 @@
+require 'spec_helper'
+
+describe Blinkist::AirbrakeScrubber::ParamsTokens do
+  let(:notice) {
+    Airbrake.build_notice(
+      Exception.new('whatever'),
+      { google_id_token: 'blahblah', facebook_access_token: 'whatever', param: 'whatever' }
+    )
+  }
+
+  describe "Structure" do
+    it "has scrub! method" do
+      expect(described_class).to respond_to(:scrub!)
+    end
+  end
+
+  describe "self.scrub!" do
+    it "adds the filter" do
+      expect(Airbrake).to receive(:add_filter)
+      described_class::scrub!
+    end
+
+    it "scrubs the google_id_token from the params hash" do
+      Airbrake.notice_notifier.instance_variable_get(:@filter_chain).refine(notice)
+      expect(notice[:params][:google_id_token]).to eq(Blinkist::AirbrakeScrubber::FILTERED)
+    end
+
+    it "scrubs the deep-nested google_id_token from the params hash" do
+      notice = Airbrake.build_notice(
+        Exception.new('whatever'),
+        { google_id_token: 'bahblah', deeply: { nested: { google_id_token: 'blhablah' } } }
+      )
+
+      Airbrake.notice_notifier.instance_variable_get(:@filter_chain).refine(notice)
+      expect(notice[:params][:google_id_token]).to eq(Blinkist::AirbrakeScrubber::FILTERED)
+      expect(notice[:params][:deeply][:nested][:google_id_token]).to eq(Blinkist::AirbrakeScrubber::FILTERED)
+    end
+
+    it "scrubs the facebook_access_token from the params hash" do
+      Airbrake.notice_notifier.instance_variable_get(:@filter_chain).refine(notice)
+      expect(notice[:params][:facebook_access_token]).to eq(Blinkist::AirbrakeScrubber::FILTERED)
+    end
+
+    it "scrubs the deep-nested facebook_access_token from the params hash" do
+      notice = Airbrake.build_notice(
+        Exception.new('whatever'),
+        { facebook_access_token: 'bahblah', deeply: { nested: { facebook_access_token: 'blhablah' } } }
+      )
+
+      Airbrake.notice_notifier.instance_variable_get(:@filter_chain).refine(notice)
+      expect(notice[:params][:facebook_access_token]).to eq(Blinkist::AirbrakeScrubber::FILTERED)
+      expect(notice[:params][:deeply][:nested][:facebook_access_token]).to eq(Blinkist::AirbrakeScrubber::FILTERED)
+    end
+  end
+
+end

data/spec/specs/version_spec.rb

@@ -12,7 +12,7 @@ describe Blinkist::AirbrakeScrubber::VERSION do
 
   it 'equals 4.0.1 for auto-check purposes' do
     version = Blinkist::AirbrakeScrubber::VERSION
-    expect(version).to eq '4.0.1'
+    expect(version).to eq '4.1.1'
   end
 
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: blinkist-airbrake-scrubber
 version: !ruby/object:Gem::Version
-  version: 4.0.1
+  version: 4.1.1
 platform: ruby
 authors:
 - Paweł Komarnicki
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-04-09 00:00:00.000000000 Z
+date: 2019-08-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: airbrake
@@ -44,6 +44,7 @@ files:
 - lib/blinkist-airbrake-scrubber/scrubbers/message_email.rb
 - lib/blinkist-airbrake-scrubber/scrubbers/params_email.rb
 - lib/blinkist-airbrake-scrubber/scrubbers/params_password.rb
+- lib/blinkist-airbrake-scrubber/scrubbers/params_tokens.rb
 - lib/blinkist-airbrake-scrubber/version.rb
 - spec/spec_helper.rb
 - spec/specs/lib/blinkist-airbrake-scrubber/airbrake_spec.rb
@@ -51,6 +52,7 @@ files:
 - spec/specs/lib/blinkist-airbrake-scrubber/scrubbers/message_email_spec.rb
 - spec/specs/lib/blinkist-airbrake-scrubber/scrubbers/params_email_spec.rb
 - spec/specs/lib/blinkist-airbrake-scrubber/scrubbers/params_password_spec.rb
+- spec/specs/lib/blinkist-airbrake-scrubber/scrubbers/params_tokens_spec.rb
 - spec/specs/lib/blinkist_airbrake_scrubber_spec.rb
 - spec/specs/version_spec.rb
 homepage: https://github.com/blinkist/airbrake-scrubber
@@ -84,5 +86,6 @@ test_files:
 - spec/specs/lib/blinkist-airbrake-scrubber/scrubbers/message_email_spec.rb
 - spec/specs/lib/blinkist-airbrake-scrubber/scrubbers/params_email_spec.rb
 - spec/specs/lib/blinkist-airbrake-scrubber/scrubbers/params_password_spec.rb
+- spec/specs/lib/blinkist-airbrake-scrubber/scrubbers/params_tokens_spec.rb
 - spec/specs/lib/blinkist_airbrake_scrubber_spec.rb
 - spec/specs/version_spec.rb