blinkist-airbrake-scrubber 2.0.0 → 2.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 26b04669e1e76ff52a36ac1314e6271d0f17c573
-  data.tar.gz: 26e55291dfc186dcd8cef6e7258280af6cfac602
+  metadata.gz: b85ab4bf932163ef87c58a0213d5a66eedcba189
+  data.tar.gz: 672688d23f9af0da1b52ae0eba8db74612810677
 SHA512:
-  metadata.gz: 6a175c197481afe6e2c2d2d859aa5dfc00a398a844026800f457573ca535273bede664e5d409cd60bd31f0cc249dd17f995186bc15fbc44529bd1f3f21755873
-  data.tar.gz: d3932da443ff99c942f11605ccf4fec33098a14b85c2bb0ce6ca9e53c1d17cf07f97998e43f9c53657f6c6a70dd1b9a5425f8307d98343ddf9c6b8a2b77f3697
+  metadata.gz: 88453a2053ff065c9e41a841ee984436c625dac0934dba868442faf547d00128657f3c45abeda6773b234e3a0cd903a4c897f750a73d40c9eb96ea4ea6350047
+  data.tar.gz: c5db35d6b008865fb28bf78dab40eff29aa379a53852fb1cd26cef618b72581c774deb8590ed2176c38e334dac4df172d696a4a97d43817763bd619af95f6aac

data/lib/blinkist-airbrake-scrubber/scrubbers/message_email.rb

@@ -6,10 +6,15 @@ module Blinkist
 
         def self.scrub!
           ::Airbrake.add_filter do |notice|
-            notice[:errors].each { |error| error[:message].gsub!(REGEXP, FILTERED) }
+            # Cannot do gsub! coz of frozen literals
+            notice[:errors].each { |error| error[:message] = scrub(error[:message]) }
           end
         end # def self.scrub!
 
+        def self.scrub(message)
+          message.gsub(REGEXP, FILTERED)
+        end
+
       end
     end
   end

data/lib/blinkist-airbrake-scrubber/version.rb

@@ -1,7 +1,7 @@
 module Blinkist
   module Airbrake
     module Scrubber
-      VERSION = "2.0.0"
+      VERSION = "2.0.1"
     end
   end
 end

data/spec/specs/lib/blinkist-airbrake-scrubber/scrubbers/message_email_spec.rb

@@ -23,7 +23,7 @@ describe Blinkist::Airbrake::Scrubber::MessageEmail do
 
   # It's ridiculously hard to peek into Airbrake::Notice
   # Instead verify the functionality here
-  describe "scrubber functionality" do
+  describe ".scrub" do
     let(:filtered)  { Blinkist::Airbrake::Scrubber::FILTERED }
     let(:regexp)    { described_class::REGEXP }
 
@@ -36,14 +36,14 @@ describe Blinkist::Airbrake::Scrubber::MessageEmail do
       it "filters out valid emails" do
         puts "Verifying: #{ valid_emails.join ', ' }"
         valid_emails.each do |email|
-          expect(email.gsub(regexp, filtered)).to eq(filtered)
+          expect(described_class.scrub(email)).to eq(filtered)
         end
       end
 
       it "filters out invalid emails" do
         puts "Verifying: #{ invalid_emails.join ', ' }"
         invalid_emails.each do |email|
-          expect(email.gsub(regexp, filtered)).to eq(filtered)
+          expect(described_class.scrub(email)).to eq(filtered)
         end
       end
     end
@@ -55,7 +55,7 @@ describe Blinkist::Airbrake::Scrubber::MessageEmail do
         puts "Verifying: #{ valid_emails.join ', ' }"
         valid_emails.each do |email|
           content = text.gsub('EMAIL', email)
-          expect(content.gsub(regexp, filtered)).to eq(text.gsub('EMAIL', filtered))
+          expect(described_class.scrub(content)).to eq(text.gsub('EMAIL', filtered))
         end
       end
 
@@ -63,10 +63,19 @@ describe Blinkist::Airbrake::Scrubber::MessageEmail do
         puts "Verifying: #{ invalid_emails.join ', ' }"
         invalid_emails.each do |email|
           content = text.gsub('EMAIL', email)
-          expect(content.gsub(regexp, filtered)).to eq(text.gsub('EMAIL', filtered))
+          expect(described_class.scrub(content)).to eq(text.gsub('EMAIL', filtered))
         end
       end
     end
+
+    context "Anything that is a frozen string" do
+      subject { described_class.scrub text }
+      let(:text) { "Error bla bla bla test@example.org bla bla bla".freeze }
+
+      it "filters out email" do
+        expect(subject).to eq(text.gsub('test@example.org', filtered))
+      end
+    end
   end
 
 end

data/spec/specs/version_spec.rb

@@ -10,9 +10,9 @@ describe Blinkist::Airbrake::Scrubber::VERSION do
     expect(version.instance_of?(String)).to be true
   end
 
-  it 'equals 2.0.0 for auto-check purposes' do
+  it 'equals 2.0.1 for auto-check purposes' do
     version = Blinkist::Airbrake::Scrubber::VERSION
-    expect(version).to eq '2.0.0'
+    expect(version).to eq '2.0.1'
   end
 
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: blinkist-airbrake-scrubber
 version: !ruby/object:Gem::Version
-  version: 2.0.0
+  version: 2.0.1
 platform: ruby
 authors:
 - Paweł Komarnicki
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-05-23 00:00:00.000000000 Z
+date: 2018-05-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: airbrake