blather 0.2.1 → 0.2.2

data/spec/blather/core_ext/libxml_spec.rb

@@ -0,0 +1,58 @@
+require File.join(File.dirname(__FILE__), *%w[.. .. spec_helper])
+
+describe 'LibXML::XML::Node' do
+  it 'aliases #name to #element_name' do
+    node = LibXML::XML::Node.new 'foo'
+    node.must_respond_to :element_name
+    node.element_name.must_equal node.name
+  end
+
+  it 'aliases #name= to #element_name=' do
+    node = LibXML::XML::Node.new 'foo'
+    node.must_respond_to :element_name=
+    node.element_name.must_equal node.name
+    node.element_name = 'bar'
+    node.element_name.must_equal 'bar'
+  end
+end
+
+describe 'LibXML::XML::Attributes' do
+  it 'provides a helper to remove a specified attribute' do
+    attrs = LibXML::XML::Node.new('foo').attributes
+    attrs['foo'] = 'bar'
+    attrs['foo'].must_equal 'bar'
+    attrs.remove 'foo'
+    attrs['foo'].must_be_nil
+
+    attrs['foo'] = 'bar'
+    attrs['foo'].must_equal 'bar'
+    attrs.remove :foo
+    attrs['foo'].must_be_nil
+  end
+
+  it 'allows symbols as hash keys' do
+    attrs = LibXML::XML::Node.new('foo').attributes
+    attrs['foo'] = 'bar'
+
+    attrs['foo'].must_equal 'bar'
+    attrs[:foo].must_equal 'bar'
+  end
+
+  it 'removes an attribute when set to nil' do
+    attrs = LibXML::XML::Node.new('foo').attributes
+    attrs['foo'] = 'bar'
+
+    attrs['foo'].must_equal 'bar'
+    attrs['foo'] = nil
+    attrs['foo'].must_be_nil
+  end
+
+  it 'allows attribute values to change' do
+    attrs = LibXML::XML::Node.new('foo').attributes
+    attrs['foo'] = 'bar'
+
+    attrs['foo'].must_equal 'bar'
+    attrs['foo'] = 'baz'
+    attrs['foo'].must_equal 'baz'
+  end
+end

data/spec/blather/errors/sasl_error_spec.rb

@@ -0,0 +1,56 @@
+require File.join(File.dirname(__FILE__), *%w[.. .. spec_helper])
+
+def sasl_error_node(err_name = 'aborted')
+  node = XMPPNode.new 'failure'
+  node.namespace = 'urn:ietf:params:xml:ns:xmpp-sasl'
+
+  node << XMPPNode.new(err_name)
+  node
+end
+
+describe 'Blather::SASLError' do
+  it 'can import a node' do
+    SASLError.must_respond_to :import
+    e = SASLError.import sasl_error_node
+    e.must_be_kind_of SASLError
+  end
+
+  it 'knows what class to instantiate' do
+    e = SASLError.import sasl_error_node
+    e.must_be_instance_of SASLError::Aborted
+  end
+
+  describe 'when instantiated' do
+    before do
+      @err_name = 'mechanism-too-weak'
+      @err = SASLError.import sasl_error_node(@err_name)
+    end
+
+    it 'provides a err_name attribute' do
+      @err.must_respond_to :err_name
+      @err.err_name.must_equal @err_name
+    end
+  end
+
+  describe 'each XMPP SASL error type' do
+    %w[ aborted
+        incorrect-encoding
+        invalid-authzid
+        invalid-mechanism
+        mechanism-too-weak
+        not-authorized
+        temporary-auth-failure
+    ].each do |error_type|
+      it "provides a class for #{error_type}" do
+        e = SASLError.import sasl_error_node(error_type)
+        klass = error_type.gsub(/^\w/) { |v| v.upcase }.gsub(/\-(\w)/) { |v| v.delete('-').upcase }
+        e.must_be_instance_of eval("SASLError::#{klass}")
+      end
+
+      it "registers #{error_type} in the handler heirarchy" do
+        e = SASLError.import sasl_error_node(error_type)
+        e.handler_heirarchy.must_equal ["sasl_#{error_type.gsub('-','_').gsub('_error','')}_error".to_sym, :sasl_error, :error]
+      end
+    end
+  end
+end

data/spec/blather/errors/stanza_error_spec.rb

@@ -0,0 +1,148 @@
+require File.join(File.dirname(__FILE__), *%w[.. .. spec_helper])
+
+def stanza_error_node(type = 'cancel', error = 'internal-server-error', msg = nil)
+  node = Stanza::Message.new 'error@jabber.local', 'test message', :error
+  XML::Document.new.root = node
+
+  error_node = XMPPNode.new('error')
+  error_node['type'] = type.to_s
+  
+  err = XMPPNode.new(error)
+  err.namespace = 'urn:ietf:params:xml:ns:xmpp-stanzas'
+  error_node << err
+
+  if msg
+    text = XMPPNode.new('text')
+    text.namespace = 'urn:ietf:params:xml:ns:xmpp-stanzas'
+    text << msg
+    error_node << text
+  end
+
+  extra = XMPPNode.new('extra-error')
+  extra.namespace = 'blather:stanza:error'
+  extra << 'Blather Error'
+  error_node << extra
+
+  node << error_node
+  node
+end
+
+describe 'Blather::StanzaError' do
+  it 'can import a node' do
+    StanzaError.must_respond_to :import
+    e = StanzaError.import stanza_error_node
+    e.must_be_kind_of StanzaError
+  end
+
+  it 'knows what class to instantiate' do
+    e = StanzaError.import stanza_error_node
+    e.must_be_instance_of StanzaError::InternalServerError
+  end
+
+  describe 'valid types' do
+    before { @original = Stanza::Message.new 'error@jabber.local', 'test message', :error }
+
+    it 'ensures type is one of Stanza::Message::VALID_TYPES' do
+      lambda { StanzaError.new @original, :invalid_type_name }.must_raise(Blather::ArgumentError)
+
+      StanzaError::VALID_TYPES.each do |valid_type|
+        msg = StanzaError.new @original, valid_type
+        msg.type.must_equal valid_type
+      end
+    end
+  end
+
+  describe 'when instantiated' do
+    before do
+      @type = 'cancel'
+      @err_name = 'internal-server-error'
+      @msg = 'the server has experienced a misconfiguration'
+      @err = StanzaError.import stanza_error_node(@type, @err_name, @msg)
+    end
+
+    it 'provides a type attribute' do
+      @err.must_respond_to :type
+      @err.type.must_equal @type.to_sym
+    end
+
+    it 'provides a err_name attribute' do
+      @err.must_respond_to :err_name
+      @err.err_name.must_equal @err_name
+    end
+
+    it 'provides a text attribute' do
+      @err.must_respond_to :text
+      @err.text.must_equal @msg
+    end
+
+    it 'provides a reader to the original node' do
+      @err.must_respond_to :original
+      @err.original.must_be_instance_of Stanza::Message
+    end
+
+    it 'provides an extras attribute' do
+      @err.must_respond_to :extras
+      @err.extras.must_be_instance_of Array
+      @err.extras.first.element_name.must_equal 'extra-error'
+    end
+
+    it 'describes itself' do
+      @err.to_s.must_match(/#{@err_name}/)
+      @err.to_s.must_match(/#{@msg}/)
+
+      @err.inspect.must_match(/#{@err_name}/)
+      @err.inspect.must_match(/#{@msg}/)
+    end
+
+    it 'can be turned into xml' do
+      @err.must_respond_to :to_xml
+      control = "<body>test message</body>\n<error>\n<internal-server-error xmlns=\"urn:ietf:params:xml:ns:xmpp-stanzas\"/>\n<text xmlns=\"urn:ietf:params:xml:ns:xmpp-stanzas\">the server has experienced a misconfiguration</text>\n<extra-error xmlns=\"blather:stanza:error\">Blather Error</extra-error>\n</error>\n</message>".split("\n")
+      test = @err.to_xml.split("\n")
+      test_msg = test.shift
+      test.must_equal control
+
+      test_msg.must_match(/<message[^>]*id="#{@err.original.id}"/)
+      test_msg.must_match(/<message[^>]*from="error@jabber\.local"/)
+      test_msg.must_match(/<message[^>]*type="error"/)
+    end
+  end
+
+  describe 'each XMPP stanza error type' do
+    %w[ bad-request
+        conflict
+        feature-not-implemented
+        forbidden
+        gone
+        internal-server-error
+        item-not-found
+        jid-malformed
+        not-acceptable
+        not-allowed
+        not-authorized
+        payment-required
+        recipient-unavailable
+        redirect
+        registration-required
+        remote-server-not-found
+        remote-server-timeout
+        resource-constraint
+        service-unavailable
+        subscription-required
+        undefined-condition
+        unexpected-request
+      ].each do |error_type|
+        it "provides a class for #{error_type}" do
+          e = StanzaError.import stanza_error_node(:cancel, error_type)
+          klass = error_type.gsub(/^\w/) { |v| v.upcase }.gsub(/\-(\w)/) { |v| v.delete('-').upcase }
+          e.must_be_instance_of eval("StanzaError::#{klass}")
+        end
+
+        it "registers #{error_type} in the handler heirarchy" do
+          e = StanzaError.import stanza_error_node(:cancel, error_type)
+          e.handler_heirarchy.must_equal ["stanza_#{error_type.gsub('-','_').gsub('_error','')}_error".to_sym, :stanza_error, :error]
+        end
+      end
+  end
+end
+
+

data/spec/blather/errors/stream_error_spec.rb

@@ -0,0 +1,114 @@
+require File.join(File.dirname(__FILE__), *%w[.. .. spec_helper])
+
+def stream_error_node(error = 'internal-server-error', msg = nil)
+  node = XMPPNode.new('stream:error')
+  XML::Document.new.root = node
+  
+  err = XMPPNode.new(error)
+  err.namespace = 'urn:ietf:params:xml:ns:xmpp-streams'
+  node << err
+
+  if msg
+    text = XMPPNode.new('text')
+    text.namespace = 'urn:ietf:params:xml:ns:xmpp-streams'
+    text << msg
+    node << text
+  end
+
+  extra = XMPPNode.new('extra-error')
+  extra.namespace = 'blather:stream:error'
+  extra << 'Blather Error'
+
+  node << extra
+  node
+end
+
+describe 'Blather::StreamError' do
+  it 'can import a node' do
+    StreamError.must_respond_to :import
+    e = StreamError.import stream_error_node
+    e.must_be_kind_of StreamError
+  end
+
+  it 'knows what class to instantiate' do
+    e = StreamError.import stream_error_node
+    e.must_be_instance_of StreamError::InternalServerError
+  end
+end
+
+describe 'Blather::StreamError when instantiated' do
+  before do
+    @err_name = 'internal-server-error'
+    @msg = 'the server has experienced a misconfiguration'
+    @err = StreamError.import stream_error_node(@err_name, @msg)
+  end
+
+  it 'provides a err_name attribute' do
+    @err.must_respond_to :err_name
+    @err.err_name.must_equal @err_name
+  end
+
+  it 'provides a text attribute' do
+    @err.must_respond_to :text
+    @err.text.must_equal @msg
+  end
+
+  it 'provides an extras attribute' do
+    @err.must_respond_to :extras
+    @err.extras.must_be_instance_of Array
+    @err.extras.size.must_equal 1
+    @err.extras.first.element_name.must_equal 'extra-error'
+  end
+
+  it 'describes itself' do
+    @err.to_s.must_match(/#{@type}/)
+    @err.to_s.must_match(/#{@msg}/)
+
+    @err.inspect.must_match(/#{@type}/)
+    @err.inspect.must_match(/#{@msg}/)
+  end
+
+  it 'can be turned into xml' do
+    @err.must_respond_to :to_xml
+    @err.to_xml.must_equal "<stream:error>\n<internal-server-error xmlns=\"urn:ietf:params:xml:ns:xmpp-streams\"/>\n<text xmlns=\"urn:ietf:params:xml:ns:xmpp-streams\">the server has experienced a misconfiguration</text>\n<extra-error xmlns=\"blather:stream:error\">Blather Error</extra-error>\n</stream:error>"
+  end
+end
+
+describe 'Each XMPP stream error type' do
+  %w[ bad-format
+      bad-namespace-prefix
+      conflict
+      connection-timeout
+      host-gone
+      host-unknown
+      improper-addressing
+      internal-server-error
+      invalid-from
+      invalid-id
+      invalid-namespace
+      invalid-xml
+      not-authorized
+      policy-violation
+      remote-connection-failed
+      resource-constraint
+      restricted-xml
+      see-other-host
+      system-shutdown
+      undefined-condition
+      unsupported-encoding
+      unsupported-stanza-type
+      unsupported-version
+      xml-not-well-formed
+    ].each do |error_type|
+      it "provides a class for #{error_type}" do
+        e = StreamError.import stream_error_node(error_type)
+        klass = error_type.gsub(/^\w/) { |v| v.upcase }.gsub(/\-(\w)/) { |v| v.delete('-').upcase }
+        e.must_be_instance_of eval("StreamError::#{klass}")
+      end
+
+      it "registers #{error_type} in the handler heirarchy" do
+        e = StreamError.import stream_error_node(error_type)
+        e.handler_heirarchy.must_equal ["stream_#{error_type.gsub('-','_').gsub('_error','')}_error".to_sym, :stream_error, :error]
+      end
+    end
+end

data/spec/blather/errors_spec.rb

@@ -0,0 +1,40 @@
+require File.join(File.dirname(__FILE__), *%w[.. spec_helper])
+
+describe 'Blather::BlatherError' do
+  it 'is handled by :error' do
+    BlatherError.new.handler_heirarchy.must_equal [:error]
+  end
+end
+
+describe 'Blather::ParseError' do
+  before { @error = ParseError.new('</generate-parse-error>"') }
+
+  it 'is registers with the handler heirarchy' do
+    @error.handler_heirarchy.must_equal [:parse_error, :error]
+  end
+
+  it 'contains the error message' do
+    @error.must_respond_to :message
+    @error.message.must_equal '</generate-parse-error>"'
+  end
+end
+
+describe 'Blather::TLSFailure' do
+  it 'is registers with the handler heirarchy' do
+    TLSFailure.new.handler_heirarchy.must_equal [:tls_failure, :error]
+  end
+end
+
+describe 'Blather::UnknownResponse' do
+  before { @error = UnknownResponse.new(XMPPNode.new('foo-bar')) }
+
+  it 'is registers with the handler heirarchy' do
+    @error.handler_heirarchy.must_equal [:unknown_response_error, :error]
+  end
+
+  it 'holds on to a copy of the failure node' do
+    @error.must_respond_to :node
+    @error.node.element_name.must_equal 'foo-bar'
+  end
+end
+

data/spec/blather/jid_spec.rb

@@ -76,13 +76,6 @@ describe 'Blather::JID' do
     JID.new('n', 'd').to_s.must_equal 'n@d'
   end
 
-  it 'falls back to basic ruby if idn gem is not present' do
-    JID.const_set 'USE_STRINGPREP', false
-    jid = JID.new 'AB#$cdE@&^FE'
-    jid.node.must_equal 'ab#$cde'
-    jid.domain.must_equal '&^fe'
-  end
-
   it 'provides a #stripped? helper' do
     jid = JID.new 'a@b/c'
     jid.must_respond_to :stripped?

data/spec/blather/roster_item_spec.rb

@@ -77,4 +77,9 @@ describe 'Blather::RosterItem' do
     @i.status = @p
     @i.status = @p2
   end
+
+  it 'initializes groups to [nil] if the item is not part of a group' do
+    i = RosterItem.new 'n@d'
+    i.groups.must_equal [nil]
+  end
 end

data/spec/blather/roster_spec.rb

@@ -19,24 +19,24 @@ describe 'Blather::Roster' do
   it 'processes @stanzas with remove requests' do
     s = @roster['n@d/0r']
     s.subscription = :remove
-    proc { @roster.process(s.to_stanza) }.must_change('@roster.items', :length, :by => -1)
+    proc { @roster.process(s.to_stanza) }.must_change('@roster.items.length', :by => -1)
   end
 
   it 'processes @stanzas with add requests' do
     s = Stanza::Iq::Roster::RosterItem.new('a@b/c').to_stanza
-    proc { @roster.process(s) }.must_change('@roster.items', :length, :by => 1)
+    proc { @roster.process(s) }.must_change('@roster.items.length', :by => 1)
   end
 
   it 'allows a jid to be pushed' do
     jid = 'a@b/c'
-    proc { @roster.push(jid) }.must_change('@roster.items', :length, :by => 1)
+    proc { @roster.push(jid) }.must_change('@roster.items.length', :by => 1)
     @roster[jid].wont_be_nil
   end
 
   it 'allows an item to be pushed' do
     jid = 'a@b/c'
     item = RosterItem.new(JID.new(jid))
-    proc { @roster.push(item) }.must_change('@roster.items', :length, :by => 1)
+    proc { @roster.push(item) }.must_change('@roster.items.length', :by => 1)
     @roster[jid].wont_be_nil
   end
 
@@ -45,7 +45,7 @@ describe 'Blather::Roster' do
     item = RosterItem.new(JID.new(jid))
     jid2 = 'd@e/f'
     item2 = RosterItem.new(JID.new(jid2))
-    proc { @roster << item << item2 }.must_change('@roster.items', :length, :by => 2)
+    proc { @roster << item << item2 }.must_change('@roster.items.length', :by => 2)
     @roster[jid].wont_be_nil
     @roster[jid2].wont_be_nil
   end
@@ -58,7 +58,7 @@ describe 'Blather::Roster' do
   end
 
   it 'removes a JID' do
-    proc { @roster.delete 'n@d' }.must_change('@roster.items', :length, :by => -1)
+    proc { @roster.delete 'n@d' }.must_change('@roster.items.length', :by => -1)
   end
 
   it 'sends a @roster removal over the wire' do