blacklight 9.0.0 → 9.1.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- checksums.yaml +4 -4
- data/.env +3 -3
- data/.github/matrix.json +12 -18
- data/.github/workflows/lint.yml +1 -1
- data/.github/workflows/test.yml +4 -3
- data/.rubocop.yml +72 -7
- data/.rubocop_todo.yml +142 -268
- data/Gemfile +1 -1
- data/README.md +2 -9
- data/VERSION +1 -1
- data/app/assets/builds/blacklight.css +37 -23
- data/app/assets/images/blacklight/logo-dark.svg +184 -0
- data/app/assets/images/blacklight/logo.svg +184 -0
- data/app/assets/javascripts/blacklight/blacklight.esm.js +128 -45
- data/app/assets/javascripts/blacklight/blacklight.esm.js.map +1 -1
- data/app/assets/javascripts/blacklight/blacklight.js +128 -45
- data/app/assets/javascripts/blacklight/blacklight.js.map +1 -1
- data/app/assets/stylesheets/blacklight/_balanced_list.scss +1 -1
- data/app/assets/stylesheets/blacklight/_bootstrap_overrides.scss +17 -0
- data/app/assets/stylesheets/blacklight/_constraints.scss +2 -2
- data/app/assets/stylesheets/blacklight/_facets.scss +14 -10
- data/app/assets/stylesheets/blacklight/_header.scss +0 -4
- data/app/assets/stylesheets/blacklight/blacklight_defaults.scss +5 -9
- data/app/components/blacklight/facets/inclusive_constraint_component.html.erb +1 -1
- data/app/components/blacklight/icons/checkmark_component.rb +16 -0
- data/app/components/blacklight/icons/circle_half_component.rb +16 -0
- data/app/components/blacklight/icons/moon_stars_component.rb +17 -0
- data/app/components/blacklight/icons/sun_component.rb +16 -0
- data/app/components/blacklight/metadata_field_component.rb +1 -1
- data/app/components/blacklight/search_navbar_component.html.erb +1 -1
- data/app/components/blacklight/theme_switcher_component.html.erb +31 -0
- data/app/components/blacklight/theme_switcher_component.rb +6 -0
- data/app/components/blacklight/top_navbar_component.html.erb +1 -1
- data/app/controllers/concerns/blacklight/bookmarks.rb +8 -14
- data/app/controllers/concerns/blacklight/catalog.rb +9 -10
- data/app/controllers/concerns/blacklight/controller.rb +54 -11
- data/app/controllers/concerns/blacklight/guest_user.rb +51 -0
- data/app/controllers/concerns/blacklight/search_context.rb +1 -1
- data/app/controllers/concerns/blacklight/search_history.rb +3 -1
- data/app/controllers/concerns/blacklight/searchable.rb +18 -0
- data/app/helpers/blacklight/layout_helper_behavior.rb +7 -0
- data/app/javascript/blacklight-frontend/color_theme_switcher.js +85 -0
- data/app/javascript/blacklight-frontend/index.js +2 -0
- data/app/models/concerns/blacklight/document/dublin_core.rb +2 -2
- data/app/models/concerns/blacklight/document.rb +1 -1
- data/app/models/concerns/blacklight/user.rb +36 -0
- data/app/presenters/blacklight/field_presenter.rb +1 -1
- data/app/presenters/blacklight/rendering/microdata.rb +1 -0
- data/app/services/blacklight/bookmarks_search_builder.rb +4 -4
- data/app/services/blacklight/search_service.rb +46 -33
- data/app/values/blacklight/types.rb +1 -1
- data/app/views/catalog/_email_form.html.erb +3 -3
- data/app/views/catalog/_home_text.html.erb +1 -1
- data/app/views/catalog/_sms_form.html.erb +4 -4
- data/app/views/catalog/index.rss.builder +4 -4
- data/app/views/catalog/opensearch.json.jbuilder +3 -0
- data/app/views/catalog/opensearch.xml.builder +2 -2
- data/app/views/layouts/blacklight/base.html.erb +13 -1
- data/app/views/shared/_user_util_links.html.erb +18 -5
- data/blacklight.gemspec +3 -3
- data/config/locales/blacklight.ar.yml +5 -0
- data/config/locales/blacklight.ca.yml +5 -0
- data/config/locales/blacklight.de.yml +6 -2
- data/config/locales/blacklight.en.yml +5 -0
- data/config/locales/blacklight.es.yml +5 -0
- data/config/locales/blacklight.fr.yml +5 -0
- data/config/locales/blacklight.hu.yml +5 -0
- data/config/locales/blacklight.it.yml +6 -2
- data/config/locales/blacklight.nl.yml +5 -0
- data/config/locales/blacklight.pt-BR.yml +6 -2
- data/config/locales/blacklight.sq.yml +5 -0
- data/config/locales/blacklight.zh.yml +5 -0
- data/lib/blacklight/component.rb +1 -1
- data/lib/blacklight/configuration/action_config_map_entry.rb +31 -0
- data/lib/blacklight/configuration/display_field.rb +1 -0
- data/lib/blacklight/configuration/field.rb +6 -6
- data/lib/blacklight/configuration/fields.rb +1 -1
- data/lib/blacklight/configuration/sort_field.rb +2 -2
- data/lib/blacklight/configuration.rb +30 -19
- data/lib/blacklight/parameters.rb +1 -1
- data/lib/blacklight/search_builder.rb +58 -19
- data/lib/blacklight/search_state.rb +4 -0
- data/lib/blacklight/solr/request.rb +8 -1
- data/lib/blacklight/solr/response/group_response.rb +1 -1
- data/lib/blacklight/solr/response/spelling.rb +8 -8
- data/lib/blacklight/solr/response.rb +2 -21
- data/lib/blacklight/solr/search_builder_behavior.rb +3 -9
- data/lib/blacklight.rb +2 -2
- data/lib/generators/blacklight/assets/importmap_generator.rb +2 -2
- data/lib/generators/blacklight/assets_generator.rb +1 -1
- data/lib/generators/blacklight/controller_generator.rb +1 -1
- data/lib/generators/blacklight/document_generator.rb +1 -1
- data/lib/generators/blacklight/install_generator.rb +6 -4
- data/lib/generators/blacklight/models_generator.rb +1 -1
- data/lib/generators/blacklight/search_builder_generator.rb +1 -1
- data/lib/generators/blacklight/solr_generator.rb +1 -1
- data/lib/generators/blacklight/templates/catalog_controller.rb +20 -1
- data/lib/generators/blacklight/templates/solr/conf/schema.xml +264 -178
- data/lib/generators/blacklight/templates/solr/conf/solrconfig.xml +6 -14
- data/lib/generators/blacklight/test_support_generator.rb +1 -1
- data/lib/generators/blacklight/user_generator.rb +66 -5
- data/lib/railties/blacklight.rake +4 -4
- data/package.json +2 -2
- data/spec/components/blacklight/document/action_component_spec.rb +1 -1
- data/spec/components/blacklight/document/group_component_spec.rb +1 -1
- data/spec/components/blacklight/document_component_spec.rb +9 -9
- data/spec/components/blacklight/facet_component_spec.rb +2 -2
- data/spec/components/blacklight/facets/index_navigation_component_spec.rb +1 -2
- data/spec/components/blacklight/facets/list_component_spec.rb +1 -1
- data/spec/components/blacklight/facets/suggest_component_spec.rb +1 -2
- data/spec/components/blacklight/metadata_field_component_spec.rb +26 -0
- data/spec/components/blacklight/skip_link_component_spec.rb +2 -2
- data/spec/controllers/application_controller_spec.rb +71 -0
- data/spec/controllers/bookmarks_controller_spec.rb +18 -5
- data/spec/controllers/catalog_controller_spec.rb +7 -5
- data/spec/features/advanced_search_spec.rb +29 -16
- data/spec/features/alternate_controller_spec.rb +4 -4
- data/spec/features/axe_spec.rb +34 -22
- data/spec/features/bookmarks_spec.rb +13 -13
- data/spec/features/dark_mode_spec.rb +42 -0
- data/spec/features/did_you_mean_spec.rb +27 -27
- data/spec/features/facet_missing_spec.rb +3 -3
- data/spec/features/record_view_spec.rb +14 -14
- data/spec/features/search_context_spec.rb +8 -8
- data/spec/features/search_filters_spec.rb +16 -16
- data/spec/features/search_formats_spec.rb +2 -2
- data/spec/features/search_history_spec.rb +11 -11
- data/spec/features/search_pagination_spec.rb +17 -17
- data/spec/features/search_results_spec.rb +3 -3
- data/spec/features/search_sort_spec.rb +4 -4
- data/spec/features/search_spec.rb +20 -20
- data/spec/helpers/blacklight/url_helper_behavior_spec.rb +15 -15
- data/spec/helpers/blacklight_helper_spec.rb +1 -1
- data/spec/helpers/catalog_helper_spec.rb +7 -7
- data/spec/integration/generators/blacklight/user_generator_spec.rb +60 -0
- data/spec/lib/blacklight/search_state/pivot_filter_field_spec.rb +1 -1
- data/spec/models/blacklight/configurable_spec.rb +1 -1
- data/spec/models/blacklight/configuration_spec.rb +0 -19
- data/spec/models/blacklight/document/dublin_core_spec.rb +2 -2
- data/spec/models/blacklight/facet_paginator_spec.rb +1 -1
- data/spec/models/blacklight/search_builder_spec.rb +15 -3
- data/spec/models/blacklight/solr/repository_spec.rb +10 -2
- data/spec/models/blacklight/solr/search_builder_behavior_spec.rb +3 -5
- data/spec/models/blacklight/user_spec.rb +32 -5
- data/spec/models/bookmark_spec.rb +1 -1
- data/spec/models/record_mailer_spec.rb +8 -8
- data/spec/models/search_spec.rb +1 -1
- data/spec/models/solr_document_spec.rb +4 -0
- data/spec/presenters/blacklight/index_presenter_spec.rb +1 -0
- data/spec/presenters/blacklight/rendering/pipeline_spec.rb +1 -0
- data/spec/presenters/blacklight/show_presenter_spec.rb +1 -0
- data/spec/presenters/blacklight/thumbnail_presenter_spec.rb +1 -0
- data/spec/services/blacklight/search_service_spec.rb +7 -7
- data/spec/spec_helper.rb +3 -12
- data/spec/support/features/session_helpers.rb +13 -4
- data/spec/support/features/turbo_helpers.rb +13 -0
- data/spec/support/features.rb +2 -0
- data/spec/support/user_helpers.rb +24 -0
- data/spec/test_app_templates/lib/generators/test_app_generator.rb +1 -1
- data/spec/views/catalog/_document.html.erb_spec.rb +4 -4
- data/spec/views/catalog/_paginate_compact.html.erb_spec.rb +2 -2
- data/spec/views/catalog/_sort_and_per_page.html.erb_spec.rb +5 -5
- data/spec/views/catalog/index.html.erb_spec.rb +2 -2
- data/spec/views/catalog/show.html.erb_spec.rb +3 -4
- data/spec/views/shared/_user_util_links.html.erb_spec.rb +56 -0
- data/template.demo.rb +2 -1
- metadata +30 -22
- data/.hound.yml +0 -4
- data/.jshintrc +0 -22
- data/app/assets/images/blacklight/logo.png +0 -0
data/.rubocop_todo.yml
CHANGED
|
@@ -1,6 +1,6 @@
|
|
|
1
1
|
# This configuration was generated by
|
|
2
2
|
# `rubocop --auto-gen-config`
|
|
3
|
-
# on 2025-
|
|
3
|
+
# on 2025-12-19 18:28:16 UTC using RuboCop version 1.82.0.
|
|
4
4
|
# The point is for the user to remove these configuration records
|
|
5
5
|
# one by one as the offenses are removed from the code base.
|
|
6
6
|
# Note that changes in the inspected code, or installation of new
|
|
@@ -8,98 +8,57 @@
|
|
|
8
8
|
|
|
9
9
|
# Offense count: 4
|
|
10
10
|
# This cop supports safe autocorrection (--autocorrect).
|
|
11
|
-
Capybara/CurrentPathExpectation:
|
|
11
|
+
Capybara/RSpec/CurrentPathExpectation:
|
|
12
12
|
Exclude:
|
|
13
|
-
-
|
|
13
|
+
- "spec/features/alternate_controller_spec.rb"
|
|
14
14
|
|
|
15
|
-
# Offense count:
|
|
16
|
-
Capybara/NegationMatcherAfterVisit:
|
|
15
|
+
# Offense count: 6
|
|
16
|
+
Capybara/RSpec/NegationMatcherAfterVisit:
|
|
17
17
|
Exclude:
|
|
18
|
-
-
|
|
19
|
-
-
|
|
20
|
-
-
|
|
21
|
-
-
|
|
22
|
-
-
|
|
23
|
-
- 'spec/features/sitelinks_search_box_spec.rb'
|
|
18
|
+
- "spec/features/bookmarks_spec.rb"
|
|
19
|
+
- "spec/features/facets_spec.rb"
|
|
20
|
+
- "spec/features/modal_spec.rb"
|
|
21
|
+
- "spec/features/record_view_spec.rb"
|
|
22
|
+
- "spec/features/search_context_spec.rb"
|
|
24
23
|
|
|
25
24
|
# Offense count: 13
|
|
26
|
-
Capybara/VisibilityMatcher:
|
|
25
|
+
Capybara/RSpec/VisibilityMatcher:
|
|
27
26
|
Exclude:
|
|
28
|
-
-
|
|
29
|
-
-
|
|
30
|
-
-
|
|
31
|
-
|
|
32
|
-
# Offense count: 1
|
|
33
|
-
# This cop supports safe autocorrection (--autocorrect).
|
|
34
|
-
# Configuration parameters: AllowedMethods, AllowedPatterns.
|
|
35
|
-
Lint/AmbiguousBlockAssociation:
|
|
36
|
-
Exclude:
|
|
37
|
-
- 'lib/blacklight/solr/search_builder_behavior.rb'
|
|
38
|
-
|
|
39
|
-
# Offense count: 4
|
|
40
|
-
# This cop supports safe autocorrection (--autocorrect).
|
|
41
|
-
Lint/AmbiguousOperator:
|
|
42
|
-
Exclude:
|
|
43
|
-
- 'spec/helpers/blacklight/url_helper_behavior_spec.rb'
|
|
44
|
-
- 'spec/helpers/blacklight_helper_spec.rb'
|
|
45
|
-
- 'spec/models/blacklight/facet_paginator_spec.rb'
|
|
46
|
-
- 'spec/services/blacklight/search_service_spec.rb'
|
|
47
|
-
|
|
48
|
-
# Offense count: 43
|
|
49
|
-
# This cop supports safe autocorrection (--autocorrect).
|
|
50
|
-
Lint/AmbiguousRegexpLiteral:
|
|
51
|
-
Exclude:
|
|
52
|
-
- 'spec/controllers/catalog_controller_spec.rb'
|
|
53
|
-
- 'spec/features/alternate_controller_spec.rb'
|
|
54
|
-
- 'spec/helpers/blacklight/url_helper_behavior_spec.rb'
|
|
55
|
-
- 'spec/helpers/catalog_helper_spec.rb'
|
|
56
|
-
- 'spec/models/record_mailer_spec.rb'
|
|
57
|
-
- 'spec/views/catalog/_document.html.erb_spec.rb'
|
|
58
|
-
- 'spec/views/catalog/_sort_and_per_page.html.erb_spec.rb'
|
|
59
|
-
- 'spec/views/catalog/index.html.erb_spec.rb'
|
|
60
|
-
- 'spec/views/catalog/show.html.erb_spec.rb'
|
|
27
|
+
- "spec/features/facets_spec.rb"
|
|
28
|
+
- "spec/features/search_filters_spec.rb"
|
|
29
|
+
- "spec/helpers/blacklight_helper_spec.rb"
|
|
61
30
|
|
|
62
31
|
# Offense count: 1
|
|
63
32
|
Lint/BinaryOperatorWithIdenticalOperands:
|
|
64
33
|
Exclude:
|
|
65
|
-
-
|
|
34
|
+
- "spec/models/blacklight/document/active_model_shim_spec.rb"
|
|
66
35
|
|
|
67
36
|
# Offense count: 14
|
|
68
37
|
# Configuration parameters: AllowedMethods.
|
|
69
38
|
# AllowedMethods: enums
|
|
70
39
|
Lint/ConstantDefinitionInBlock:
|
|
71
40
|
Exclude:
|
|
72
|
-
-
|
|
73
|
-
-
|
|
74
|
-
-
|
|
75
|
-
-
|
|
76
|
-
-
|
|
77
|
-
-
|
|
78
|
-
-
|
|
41
|
+
- "spec/controllers/bookmarks_controller_spec.rb"
|
|
42
|
+
- "spec/controllers/catalog_controller_spec.rb"
|
|
43
|
+
- "spec/models/blacklight/configurable_spec.rb"
|
|
44
|
+
- "spec/models/blacklight/document/active_model_shim_spec.rb"
|
|
45
|
+
- "spec/models/blacklight/document_spec.rb"
|
|
46
|
+
- "spec/models/blacklight/solr/document_spec.rb"
|
|
47
|
+
- "spec/presenters/blacklight/show_presenter_spec.rb"
|
|
79
48
|
|
|
80
49
|
# Offense count: 2
|
|
81
50
|
# Configuration parameters: AllowComments, AllowEmptyLambdas.
|
|
82
51
|
Lint/EmptyBlock:
|
|
83
52
|
Exclude:
|
|
84
|
-
-
|
|
85
|
-
-
|
|
53
|
+
- "app/controllers/concerns/blacklight/bookmarks.rb"
|
|
54
|
+
- "lib/blacklight/solr/search_builder_behavior.rb"
|
|
86
55
|
|
|
87
|
-
# Offense count:
|
|
56
|
+
# Offense count: 53
|
|
88
57
|
# Configuration parameters: AllowedParentClasses.
|
|
89
58
|
Lint/MissingSuper:
|
|
90
59
|
Enabled: false
|
|
91
60
|
|
|
92
|
-
# Offense count:
|
|
93
|
-
# This cop supports safe autocorrection (--autocorrect).
|
|
94
|
-
Lint/ParenthesesAsGroupedExpression:
|
|
95
|
-
Exclude:
|
|
96
|
-
- 'spec/features/did_you_mean_spec.rb'
|
|
97
|
-
- 'spec/features/search_filters_spec.rb'
|
|
98
|
-
- 'spec/features/search_pagination_spec.rb'
|
|
99
|
-
- 'spec/features/search_spec.rb'
|
|
100
|
-
- 'spec/models/blacklight/solr/repository_spec.rb'
|
|
101
|
-
|
|
102
|
-
# Offense count: 81
|
|
61
|
+
# Offense count: 80
|
|
103
62
|
# Configuration parameters: AllowedMethods, AllowedPatterns, CountRepeatedAttributes.
|
|
104
63
|
Metrics/AbcSize:
|
|
105
64
|
Max: 43
|
|
@@ -115,7 +74,7 @@ Metrics/BlockLength:
|
|
|
115
74
|
Metrics/CyclomaticComplexity:
|
|
116
75
|
Max: 13
|
|
117
76
|
|
|
118
|
-
# Offense count:
|
|
77
|
+
# Offense count: 83
|
|
119
78
|
# Configuration parameters: CountComments, CountAsOne, AllowedMethods, AllowedPatterns.
|
|
120
79
|
Metrics/MethodLength:
|
|
121
80
|
Max: 27
|
|
@@ -130,7 +89,7 @@ Metrics/ModuleLength:
|
|
|
130
89
|
Metrics/ParameterLists:
|
|
131
90
|
Max: 6
|
|
132
91
|
|
|
133
|
-
# Offense count:
|
|
92
|
+
# Offense count: 31
|
|
134
93
|
# Configuration parameters: AllowedMethods, AllowedPatterns.
|
|
135
94
|
Metrics/PerceivedComplexity:
|
|
136
95
|
Max: 14
|
|
@@ -141,20 +100,20 @@ Metrics/PerceivedComplexity:
|
|
|
141
100
|
# SupportedStylesForLeadingUnderscores: disallowed, required, optional
|
|
142
101
|
Naming/MemoizedInstanceVariableName:
|
|
143
102
|
Exclude:
|
|
144
|
-
-
|
|
145
|
-
-
|
|
146
|
-
-
|
|
103
|
+
- "app/helpers/blacklight/render_partials_helper_behavior.rb"
|
|
104
|
+
- "app/models/concerns/blacklight/document/semantic_fields.rb"
|
|
105
|
+
- "lib/blacklight/solr/response.rb"
|
|
147
106
|
|
|
148
107
|
# Offense count: 9
|
|
149
108
|
# Configuration parameters: MinNameLength, AllowNamesEndingInNumbers, AllowedNames, ForbiddenNames.
|
|
150
109
|
# AllowedNames: as, at, by, cc, db, id, if, in, io, ip, of, on, os, pp, to
|
|
151
110
|
Naming/MethodParameterName:
|
|
152
111
|
Exclude:
|
|
153
|
-
-
|
|
154
|
-
-
|
|
155
|
-
-
|
|
156
|
-
-
|
|
157
|
-
-
|
|
112
|
+
- "app/models/concerns/blacklight/document.rb"
|
|
113
|
+
- "app/presenters/blacklight/rendering/link_to_facet.rb"
|
|
114
|
+
- "lib/blacklight/nested_open_struct_with_hash_access.rb"
|
|
115
|
+
- "lib/blacklight/solr/document.rb"
|
|
116
|
+
- "lib/blacklight/solr/search_builder_behavior.rb"
|
|
158
117
|
|
|
159
118
|
# Offense count: 9
|
|
160
119
|
# Configuration parameters: EnforcedStyle, CheckMethodNames, CheckSymbols, AllowedIdentifiers, AllowedPatterns.
|
|
@@ -162,24 +121,24 @@ Naming/MethodParameterName:
|
|
|
162
121
|
# AllowedIdentifiers: TLS1_1, TLS1_2, capture3, iso8601, rfc1123_date, rfc822, rfc2822, rfc3339, x86_64
|
|
163
122
|
Naming/VariableNumber:
|
|
164
123
|
Exclude:
|
|
165
|
-
-
|
|
166
|
-
-
|
|
124
|
+
- "spec/lib/blacklight/search_state_spec.rb"
|
|
125
|
+
- "spec/models/blacklight/search_builder_spec.rb"
|
|
167
126
|
|
|
168
127
|
# Offense count: 5
|
|
169
128
|
RSpec/BeforeAfterAll:
|
|
170
129
|
Exclude:
|
|
171
|
-
-
|
|
172
|
-
-
|
|
173
|
-
-
|
|
174
|
-
-
|
|
130
|
+
- "spec/controllers/search_history_controller_spec.rb"
|
|
131
|
+
- "spec/models/blacklight/configurable_spec.rb"
|
|
132
|
+
- "spec/models/blacklight/document/dublin_core_spec.rb"
|
|
133
|
+
- "spec/models/blacklight/solr/document_spec.rb"
|
|
175
134
|
|
|
176
|
-
# Offense count:
|
|
135
|
+
# Offense count: 111
|
|
177
136
|
# Configuration parameters: Prefixes, AllowedPatterns.
|
|
178
137
|
# Prefixes: when, with, without
|
|
179
138
|
RSpec/ContextWording:
|
|
180
139
|
Enabled: false
|
|
181
140
|
|
|
182
|
-
# Offense count:
|
|
141
|
+
# Offense count: 144
|
|
183
142
|
# Configuration parameters: CountAsOne.
|
|
184
143
|
RSpec/ExampleLength:
|
|
185
144
|
Max: 33
|
|
@@ -187,78 +146,78 @@ RSpec/ExampleLength:
|
|
|
187
146
|
# Offense count: 8
|
|
188
147
|
RSpec/ExpectInHook:
|
|
189
148
|
Exclude:
|
|
190
|
-
-
|
|
149
|
+
- "spec/controllers/catalog_controller_spec.rb"
|
|
191
150
|
|
|
192
151
|
# Offense count: 107
|
|
193
152
|
# Configuration parameters: AssignmentOnly.
|
|
194
153
|
RSpec/InstanceVariable:
|
|
195
154
|
Exclude:
|
|
196
|
-
-
|
|
197
|
-
-
|
|
198
|
-
-
|
|
199
|
-
-
|
|
200
|
-
-
|
|
201
|
-
-
|
|
202
|
-
-
|
|
203
|
-
-
|
|
204
|
-
-
|
|
205
|
-
-
|
|
155
|
+
- "spec/controllers/bookmarks_controller_spec.rb"
|
|
156
|
+
- "spec/controllers/search_history_controller_spec.rb"
|
|
157
|
+
- "spec/helpers/catalog_helper_spec.rb"
|
|
158
|
+
- "spec/lib/blacklight/open_struct_with_hash_access_spec.rb"
|
|
159
|
+
- "spec/lib/tasks/blacklight_task_spec.rb"
|
|
160
|
+
- "spec/models/blacklight/configuration_spec.rb"
|
|
161
|
+
- "spec/models/blacklight/document/dublin_core_spec.rb"
|
|
162
|
+
- "spec/models/blacklight/solr/document_spec.rb"
|
|
163
|
+
- "spec/models/record_mailer_spec.rb"
|
|
164
|
+
- "spec/services/blacklight/search_service_spec.rb"
|
|
206
165
|
|
|
207
166
|
# Offense count: 4
|
|
208
167
|
RSpec/IteratedExpectation:
|
|
209
168
|
Exclude:
|
|
210
|
-
-
|
|
211
|
-
-
|
|
212
|
-
-
|
|
169
|
+
- "spec/models/blacklight/solr/response/group_response_spec.rb"
|
|
170
|
+
- "spec/models/blacklight/solr/response/group_spec.rb"
|
|
171
|
+
- "spec/models/blacklight/solr/response_spec.rb"
|
|
213
172
|
|
|
214
173
|
# Offense count: 16
|
|
215
174
|
RSpec/LeakyConstantDeclaration:
|
|
216
175
|
Exclude:
|
|
217
|
-
-
|
|
218
|
-
-
|
|
219
|
-
-
|
|
220
|
-
-
|
|
221
|
-
-
|
|
222
|
-
-
|
|
223
|
-
-
|
|
176
|
+
- "spec/controllers/bookmarks_controller_spec.rb"
|
|
177
|
+
- "spec/controllers/catalog_controller_spec.rb"
|
|
178
|
+
- "spec/models/blacklight/configurable_spec.rb"
|
|
179
|
+
- "spec/models/blacklight/document/active_model_shim_spec.rb"
|
|
180
|
+
- "spec/models/blacklight/document_spec.rb"
|
|
181
|
+
- "spec/models/blacklight/solr/document_spec.rb"
|
|
182
|
+
- "spec/presenters/blacklight/show_presenter_spec.rb"
|
|
224
183
|
|
|
225
184
|
# Offense count: 9
|
|
226
185
|
RSpec/MessageChain:
|
|
227
186
|
Exclude:
|
|
228
|
-
-
|
|
229
|
-
-
|
|
230
|
-
-
|
|
187
|
+
- "spec/controllers/bookmarks_controller_spec.rb"
|
|
188
|
+
- "spec/presenters/blacklight/field_presenter_spec.rb"
|
|
189
|
+
- "spec/views/shared/_user_util_links.html.erb_spec.rb"
|
|
231
190
|
|
|
232
191
|
# Offense count: 27
|
|
233
192
|
# Configuration parameters: EnforcedStyle.
|
|
234
193
|
# SupportedStyles: have_received, receive
|
|
235
194
|
RSpec/MessageSpies:
|
|
236
195
|
Exclude:
|
|
237
|
-
-
|
|
238
|
-
-
|
|
239
|
-
-
|
|
240
|
-
-
|
|
241
|
-
-
|
|
242
|
-
-
|
|
243
|
-
-
|
|
244
|
-
-
|
|
196
|
+
- "spec/controllers/catalog_controller_spec.rb"
|
|
197
|
+
- "spec/helpers/blacklight/configuration_helper_behavior_spec.rb"
|
|
198
|
+
- "spec/helpers/blacklight/url_helper_behavior_spec.rb"
|
|
199
|
+
- "spec/helpers/blacklight_helper_spec.rb"
|
|
200
|
+
- "spec/helpers/catalog_helper_spec.rb"
|
|
201
|
+
- "spec/models/blacklight/search_builder_spec.rb"
|
|
202
|
+
- "spec/models/blacklight/suggest_search_spec.rb"
|
|
203
|
+
- "spec/presenters/blacklight/field_presenter_spec.rb"
|
|
245
204
|
|
|
246
|
-
# Offense count:
|
|
205
|
+
# Offense count: 408
|
|
247
206
|
RSpec/MultipleExpectations:
|
|
248
207
|
Max: 16
|
|
249
208
|
|
|
250
|
-
# Offense count:
|
|
209
|
+
# Offense count: 303
|
|
251
210
|
# Configuration parameters: AllowSubject.
|
|
252
211
|
RSpec/MultipleMemoizedHelpers:
|
|
253
212
|
Max: 14
|
|
254
213
|
|
|
255
|
-
# Offense count:
|
|
214
|
+
# Offense count: 432
|
|
256
215
|
# Configuration parameters: EnforcedStyle, IgnoreSharedExamples.
|
|
257
216
|
# SupportedStyles: always, named_only
|
|
258
217
|
RSpec/NamedSubject:
|
|
259
218
|
Enabled: false
|
|
260
219
|
|
|
261
|
-
# Offense count:
|
|
220
|
+
# Offense count: 84
|
|
262
221
|
# Configuration parameters: AllowedGroups.
|
|
263
222
|
RSpec/NestedGroups:
|
|
264
223
|
Max: 5
|
|
@@ -266,53 +225,52 @@ RSpec/NestedGroups:
|
|
|
266
225
|
# Offense count: 4
|
|
267
226
|
RSpec/RepeatedDescription:
|
|
268
227
|
Exclude:
|
|
269
|
-
-
|
|
270
|
-
-
|
|
228
|
+
- "spec/features/search_results_spec.rb"
|
|
229
|
+
- "spec/helpers/catalog_helper_spec.rb"
|
|
271
230
|
|
|
272
231
|
# Offense count: 2
|
|
273
232
|
RSpec/RepeatedExample:
|
|
274
233
|
Exclude:
|
|
275
|
-
-
|
|
234
|
+
- "spec/models/blacklight/solr/document_spec.rb"
|
|
276
235
|
|
|
277
236
|
# Offense count: 2
|
|
278
237
|
RSpec/RepeatedExampleGroupDescription:
|
|
279
238
|
Exclude:
|
|
280
|
-
-
|
|
239
|
+
- "spec/services/blacklight/search_service_spec.rb"
|
|
281
240
|
|
|
282
241
|
# Offense count: 1
|
|
283
242
|
# This cop supports safe autocorrection (--autocorrect).
|
|
284
|
-
# Configuration parameters: AutoCorrect.
|
|
285
243
|
RSpec/ScatteredLet:
|
|
286
244
|
Exclude:
|
|
287
|
-
-
|
|
245
|
+
- "spec/views/catalog/index.atom.builder_spec.rb"
|
|
288
246
|
|
|
289
247
|
# Offense count: 19
|
|
290
248
|
RSpec/StubbedMock:
|
|
291
249
|
Exclude:
|
|
292
|
-
-
|
|
293
|
-
-
|
|
294
|
-
-
|
|
295
|
-
-
|
|
296
|
-
-
|
|
297
|
-
-
|
|
298
|
-
-
|
|
250
|
+
- "spec/controllers/catalog_controller_spec.rb"
|
|
251
|
+
- "spec/helpers/blacklight/configuration_helper_behavior_spec.rb"
|
|
252
|
+
- "spec/helpers/blacklight/url_helper_behavior_spec.rb"
|
|
253
|
+
- "spec/helpers/blacklight_helper_spec.rb"
|
|
254
|
+
- "spec/helpers/catalog_helper_spec.rb"
|
|
255
|
+
- "spec/models/blacklight/suggest_search_spec.rb"
|
|
256
|
+
- "spec/presenters/blacklight/field_presenter_spec.rb"
|
|
299
257
|
|
|
300
258
|
# Offense count: 1
|
|
301
259
|
RSpec/SubjectDeclaration:
|
|
302
260
|
Exclude:
|
|
303
|
-
-
|
|
261
|
+
- "spec/models/blacklight/document/cache_key_spec.rb"
|
|
304
262
|
|
|
305
263
|
# Offense count: 15
|
|
306
264
|
RSpec/SubjectStub:
|
|
307
265
|
Exclude:
|
|
308
|
-
-
|
|
309
|
-
-
|
|
310
|
-
-
|
|
311
|
-
-
|
|
312
|
-
-
|
|
313
|
-
-
|
|
266
|
+
- "spec/controllers/catalog_controller_spec.rb"
|
|
267
|
+
- "spec/lib/blacklight/search_state_spec.rb"
|
|
268
|
+
- "spec/models/blacklight/document/cache_key_spec.rb"
|
|
269
|
+
- "spec/models/blacklight/search_builder_spec.rb"
|
|
270
|
+
- "spec/presenters/blacklight/document_presenter_spec.rb"
|
|
271
|
+
- "spec/services/blacklight/search_service_spec.rb"
|
|
314
272
|
|
|
315
|
-
# Offense count:
|
|
273
|
+
# Offense count: 81
|
|
316
274
|
# Configuration parameters: IgnoreNameless, IgnoreSymbolicNames.
|
|
317
275
|
RSpec/VerifiedDoubles:
|
|
318
276
|
Enabled: false
|
|
@@ -323,62 +281,33 @@ RSpec/VerifiedDoubles:
|
|
|
323
281
|
# SupportedStyles: strict, flexible
|
|
324
282
|
Rails/Date:
|
|
325
283
|
Exclude:
|
|
326
|
-
-
|
|
284
|
+
- "spec/models/search_spec.rb"
|
|
327
285
|
|
|
328
286
|
# Offense count: 17
|
|
329
|
-
# Configuration parameters: Include.
|
|
330
|
-
# Include: **/app/helpers/**/*.rb
|
|
331
287
|
Rails/HelperInstanceVariable:
|
|
332
288
|
Exclude:
|
|
333
|
-
-
|
|
334
|
-
-
|
|
335
|
-
-
|
|
336
|
-
-
|
|
337
|
-
-
|
|
289
|
+
- "app/helpers/blacklight/catalog_helper_behavior.rb"
|
|
290
|
+
- "app/helpers/blacklight/component_helper_behavior.rb"
|
|
291
|
+
- "app/helpers/blacklight/document_helper_behavior.rb"
|
|
292
|
+
- "app/helpers/blacklight/layout_helper_behavior.rb"
|
|
293
|
+
- "app/helpers/blacklight/render_partials_helper_behavior.rb"
|
|
338
294
|
|
|
339
295
|
# Offense count: 2
|
|
340
|
-
# Configuration parameters: Include.
|
|
341
|
-
# Include: spec/**/*.rb, test/**/*.rb
|
|
342
296
|
Rails/I18nLocaleAssignment:
|
|
343
297
|
Exclude:
|
|
344
|
-
-
|
|
298
|
+
- "spec/helpers/blacklight_helper_spec.rb"
|
|
345
299
|
|
|
346
300
|
# Offense count: 1
|
|
347
301
|
Rails/OutputSafety:
|
|
348
302
|
Exclude:
|
|
349
|
-
-
|
|
303
|
+
- "app/presenters/blacklight/rendering/join.rb"
|
|
350
304
|
|
|
351
305
|
# Offense count: 11
|
|
352
306
|
Security/Eval:
|
|
353
307
|
Exclude:
|
|
354
|
-
-
|
|
355
|
-
|
|
356
|
-
# Offense count: 7
|
|
357
|
-
# This cop supports safe autocorrection (--autocorrect).
|
|
358
|
-
# Configuration parameters: EnforcedStyle.
|
|
359
|
-
# SupportedStyles: prefer_alias, prefer_alias_method
|
|
360
|
-
Style/Alias:
|
|
361
|
-
Exclude:
|
|
362
|
-
- 'app/models/concerns/blacklight/document.rb'
|
|
363
|
-
- 'app/models/concerns/blacklight/document/dublin_core.rb'
|
|
364
|
-
- 'lib/blacklight/configuration.rb'
|
|
365
|
-
- 'lib/blacklight/search_builder.rb'
|
|
366
|
-
- 'lib/blacklight/solr/response.rb'
|
|
367
|
-
- 'lib/blacklight/solr/response/group_response.rb'
|
|
368
|
-
|
|
369
|
-
# Offense count: 3
|
|
370
|
-
# This cop supports safe autocorrection (--autocorrect).
|
|
371
|
-
# Configuration parameters: EnforcedStyle, ProceduralMethods, FunctionalMethods, AllowedMethods, AllowedPatterns, AllowBracesOnProceduralOneLiners, BracesRequiredMethods.
|
|
372
|
-
# SupportedStyles: line_count_based, semantic, braces_for_chaining, always_braces
|
|
373
|
-
# ProceduralMethods: benchmark, bm, bmbm, create, each_with_object, measure, new, realtime, tap, with_object
|
|
374
|
-
# FunctionalMethods: let, let!, subject, watch
|
|
375
|
-
# AllowedMethods: lambda, proc, it
|
|
376
|
-
Style/BlockDelimiters:
|
|
377
|
-
Exclude:
|
|
378
|
-
- 'app/views/catalog/index.rss.builder'
|
|
379
|
-
- 'app/views/catalog/opensearch.xml.builder'
|
|
308
|
+
- "spec/models/blacklight/solr/response_spec.rb"
|
|
380
309
|
|
|
381
|
-
# Offense count:
|
|
310
|
+
# Offense count: 47
|
|
382
311
|
# This cop supports unsafe autocorrection (--autocorrect-all).
|
|
383
312
|
# Configuration parameters: EnforcedStyle, EnforcedStyleForClasses, EnforcedStyleForModules.
|
|
384
313
|
# SupportedStyles: nested, compact
|
|
@@ -391,60 +320,30 @@ Style/ClassAndModuleChildren:
|
|
|
391
320
|
# This cop supports unsafe autocorrection (--autocorrect-all).
|
|
392
321
|
Style/CommentedKeyword:
|
|
393
322
|
Exclude:
|
|
394
|
-
-
|
|
395
|
-
-
|
|
396
|
-
|
|
397
|
-
# Offense count: 1
|
|
398
|
-
# This cop supports safe autocorrection (--autocorrect).
|
|
399
|
-
# Configuration parameters: EnforcedStyle, SingleLineConditionsOnly, IncludeTernaryExpressions.
|
|
400
|
-
# SupportedStyles: assign_to_condition, assign_inside_condition
|
|
401
|
-
Style/ConditionalAssignment:
|
|
402
|
-
Exclude:
|
|
403
|
-
- 'lib/blacklight/solr/response/spelling.rb'
|
|
323
|
+
- "spec/controllers/catalog_controller_spec.rb"
|
|
324
|
+
- "spec/services/blacklight/search_service_spec.rb"
|
|
404
325
|
|
|
405
326
|
# Offense count: 2
|
|
406
327
|
Style/DocumentDynamicEvalDefinition:
|
|
407
328
|
Exclude:
|
|
408
|
-
-
|
|
409
|
-
-
|
|
329
|
+
- "app/builders/blacklight/action_builder.rb"
|
|
330
|
+
- "lib/blacklight/configuration/fields.rb"
|
|
410
331
|
|
|
411
|
-
# Offense count:
|
|
332
|
+
# Offense count: 142
|
|
412
333
|
# Configuration parameters: AllowedConstants.
|
|
413
334
|
Style/Documentation:
|
|
414
335
|
Enabled: false
|
|
415
336
|
|
|
416
|
-
# Offense count: 9
|
|
417
|
-
# This cop supports safe autocorrection (--autocorrect).
|
|
418
|
-
Style/ExpandPathArguments:
|
|
419
|
-
Exclude:
|
|
420
|
-
- 'Gemfile'
|
|
421
|
-
- 'lib/generators/blacklight/controller_generator.rb'
|
|
422
|
-
- 'lib/generators/blacklight/document_generator.rb'
|
|
423
|
-
- 'lib/generators/blacklight/install_generator.rb'
|
|
424
|
-
- 'lib/generators/blacklight/models_generator.rb'
|
|
425
|
-
- 'lib/generators/blacklight/search_builder_generator.rb'
|
|
426
|
-
- 'lib/generators/blacklight/solr_generator.rb'
|
|
427
|
-
- 'lib/generators/blacklight/test_support_generator.rb'
|
|
428
|
-
- 'lib/generators/blacklight/user_generator.rb'
|
|
429
|
-
|
|
430
|
-
# Offense count: 17
|
|
431
|
-
# This cop supports safe autocorrection (--autocorrect).
|
|
432
|
-
# Configuration parameters: MaxUnannotatedPlaceholdersAllowed, Mode, AllowedMethods, AllowedPatterns.
|
|
433
|
-
# SupportedStyles: annotated, template, unannotated
|
|
434
|
-
# AllowedMethods: redirect
|
|
435
|
-
Style/FormatStringToken:
|
|
436
|
-
EnforcedStyle: template
|
|
437
|
-
|
|
438
337
|
# Offense count: 6
|
|
439
338
|
# This cop supports safe autocorrection (--autocorrect).
|
|
440
339
|
# Configuration parameters: MinBodyLength, AllowConsecutiveConditionals.
|
|
441
340
|
Style/GuardClause:
|
|
442
341
|
Exclude:
|
|
443
|
-
-
|
|
444
|
-
-
|
|
445
|
-
-
|
|
446
|
-
-
|
|
447
|
-
-
|
|
342
|
+
- "app/controllers/concerns/blacklight/bookmarks.rb"
|
|
343
|
+
- "app/controllers/concerns/blacklight/catalog.rb"
|
|
344
|
+
- "app/controllers/concerns/blacklight/search_context.rb"
|
|
345
|
+
- "app/helpers/blacklight/catalog_helper_behavior.rb"
|
|
346
|
+
- "lib/blacklight/solr/search_builder_behavior.rb"
|
|
448
347
|
|
|
449
348
|
# Offense count: 32
|
|
450
349
|
# This cop supports safe autocorrection (--autocorrect).
|
|
@@ -455,15 +354,15 @@ Style/IfUnlessModifier:
|
|
|
455
354
|
# This cop supports safe autocorrection (--autocorrect).
|
|
456
355
|
Style/MultilineIfModifier:
|
|
457
356
|
Exclude:
|
|
458
|
-
-
|
|
459
|
-
-
|
|
357
|
+
- "app/views/catalog/index.atom.builder"
|
|
358
|
+
- "lib/blacklight/solr/response/facets.rb"
|
|
460
359
|
|
|
461
360
|
# Offense count: 1
|
|
462
361
|
# This cop supports safe autocorrection (--autocorrect).
|
|
463
362
|
# Configuration parameters: AllowMethodComparison, ComparisonsThreshold.
|
|
464
363
|
Style/MultipleComparison:
|
|
465
364
|
Exclude:
|
|
466
|
-
-
|
|
365
|
+
- "lib/blacklight/configuration/context.rb"
|
|
467
366
|
|
|
468
367
|
# Offense count: 8
|
|
469
368
|
# This cop supports unsafe autocorrection (--autocorrect-all).
|
|
@@ -471,70 +370,45 @@ Style/MultipleComparison:
|
|
|
471
370
|
# SupportedStyles: predicate, comparison
|
|
472
371
|
Style/NumericPredicate:
|
|
473
372
|
Exclude:
|
|
474
|
-
-
|
|
475
|
-
-
|
|
476
|
-
-
|
|
477
|
-
-
|
|
478
|
-
-
|
|
479
|
-
-
|
|
480
|
-
-
|
|
373
|
+
- "app/helpers/blacklight/catalog_helper_behavior.rb"
|
|
374
|
+
- "app/services/blacklight/search_service.rb"
|
|
375
|
+
- "lib/blacklight/search_builder.rb"
|
|
376
|
+
- "lib/blacklight/solr/facet_paginator.rb"
|
|
377
|
+
- "lib/blacklight/solr/response/facets.rb"
|
|
378
|
+
- "lib/blacklight/solr/search_builder_behavior.rb"
|
|
379
|
+
- "lib/railties/blacklight.rake"
|
|
481
380
|
|
|
482
|
-
# Offense count:
|
|
381
|
+
# Offense count: 14
|
|
483
382
|
Style/OpenStructUse:
|
|
484
383
|
Exclude:
|
|
485
|
-
-
|
|
486
|
-
-
|
|
487
|
-
-
|
|
488
|
-
-
|
|
489
|
-
-
|
|
490
|
-
-
|
|
491
|
-
-
|
|
384
|
+
- "lib/blacklight/configuration.rb"
|
|
385
|
+
- "lib/blacklight/open_struct_with_hash_access.rb"
|
|
386
|
+
- "lib/blacklight/solr/response/facets.rb"
|
|
387
|
+
- "spec/components/blacklight/facet_item_pivot_component_spec.rb"
|
|
388
|
+
- "spec/lib/blacklight/search_state/filter_field_spec.rb"
|
|
389
|
+
- "spec/models/blacklight/configuration_spec.rb"
|
|
390
|
+
- "spec/models/blacklight/solr/response_spec.rb"
|
|
492
391
|
|
|
493
392
|
# Offense count: 1
|
|
494
393
|
# This cop supports safe autocorrection (--autocorrect).
|
|
495
394
|
# Configuration parameters: AllowSafeAssignment, AllowInMultilineConditions.
|
|
496
395
|
Style/ParenthesesAroundCondition:
|
|
497
396
|
Exclude:
|
|
498
|
-
-
|
|
397
|
+
- "app/views/catalog/_document.atom.builder"
|
|
499
398
|
|
|
500
399
|
# Offense count: 1
|
|
501
400
|
# This cop supports safe autocorrection (--autocorrect).
|
|
502
401
|
# Configuration parameters: PreferredDelimiters.
|
|
503
402
|
Style/PercentLiteralDelimiters:
|
|
504
403
|
Exclude:
|
|
505
|
-
-
|
|
404
|
+
- "lib/blacklight/engine.rb"
|
|
506
405
|
|
|
507
406
|
# Offense count: 2
|
|
508
407
|
# This cop supports safe autocorrection (--autocorrect).
|
|
509
408
|
Style/RedundantParentheses:
|
|
510
409
|
Exclude:
|
|
511
|
-
-
|
|
512
|
-
-
|
|
513
|
-
|
|
514
|
-
# Offense count: 6
|
|
515
|
-
# This cop supports safe autocorrection (--autocorrect).
|
|
516
|
-
# Configuration parameters: EnforcedStyle.
|
|
517
|
-
# SupportedStyles: implicit, explicit
|
|
518
|
-
Style/RescueStandardError:
|
|
519
|
-
Exclude:
|
|
520
|
-
- 'lib/blacklight.rb'
|
|
521
|
-
- 'lib/blacklight/configuration/fields.rb'
|
|
522
|
-
- 'lib/railties/blacklight.rake'
|
|
523
|
-
|
|
524
|
-
# Offense count: 6
|
|
525
|
-
# This cop supports safe autocorrection (--autocorrect).
|
|
526
|
-
# Configuration parameters: AllowAsExpressionSeparator.
|
|
527
|
-
Style/Semicolon:
|
|
528
|
-
Exclude:
|
|
529
|
-
- 'spec/models/blacklight/solr/repository_spec.rb'
|
|
530
|
-
- 'spec/views/catalog/_paginate_compact.html.erb_spec.rb'
|
|
531
|
-
|
|
532
|
-
# Offense count: 1
|
|
533
|
-
# This cop supports safe autocorrection (--autocorrect).
|
|
534
|
-
# Configuration parameters: AllowModifier.
|
|
535
|
-
Style/SoleNestedConditional:
|
|
536
|
-
Exclude:
|
|
537
|
-
- 'app/controllers/concerns/blacklight/controller.rb'
|
|
410
|
+
- "app/views/catalog/_document.atom.builder"
|
|
411
|
+
- "lib/railties/blacklight.rake"
|
|
538
412
|
|
|
539
413
|
# Offense count: 32
|
|
540
414
|
# This cop supports safe autocorrection (--autocorrect).
|