blacklight 8.2.2 → 8.4.0

data/spec/helpers/blacklight/url_helper_behavior_spec.rb

@@ -11,8 +11,7 @@ RSpec.describe Blacklight::UrlHelperBehavior do
   let(:parameter_class) { ActionController::Parameters }
 
   before do
-    allow(controller).to receive(:controller_name).and_return('test')
-    allow(controller).to receive(:search_state_class).and_return(Blacklight::SearchState)
+    allow(controller).to receive_messages(controller_name: 'test', search_state_class: Blacklight::SearchState)
     allow(helper).to receive(:search_action_path) do |*args|
       search_catalog_url *args
     end
@@ -112,18 +111,18 @@ RSpec.describe Blacklight::UrlHelperBehavior do
     end
 
     it "consists of the document title wrapped in a <a>" do
-      expect(helper.link_to_document(document)).to have_selector("a", text: '654321', count: 1)
+      expect(helper.link_to_document(document)).to have_css("a", text: '654321', count: 1)
     end
 
     it "accepts and returns a string label" do
-      expect(helper.link_to_document(document, 'This is the title')).to have_selector("a", text: 'This is the title', count: 1)
+      expect(helper.link_to_document(document, 'This is the title')).to have_css("a", text: 'This is the title', count: 1)
     end
 
     context 'when label is missing' do
       let(:data) { { 'id' => id } }
 
       it "returns id" do
-        expect(helper.link_to_document(document)).to have_selector("a", text: '123456', count: 1)
+        expect(helper.link_to_document(document)).to have_css("a", text: '123456', count: 1)
       end
 
       it "is html safe" do
@@ -142,7 +141,7 @@ RSpec.describe Blacklight::UrlHelperBehavior do
         let(:id) { 123_456 }
 
         it "has a link" do
-          expect(helper.link_to_document(document)).to have_selector("a")
+          expect(helper.link_to_document(document)).to have_css("a")
         end
       end
     end
@@ -154,14 +153,14 @@ RSpec.describe Blacklight::UrlHelperBehavior do
 
     it "includes the data- attributes from the options" do
       link = helper.link_to_document document, data: { x: 1 }
-      expect(link).to have_selector '[data-x]'
+      expect(link).to have_css '[data-x]'
     end
 
     it 'adds a controller-specific tracking attribute' do
       expect(helper.main_app).to receive(:track_test_path).and_return('/asdf')
       link = helper.link_to_document document, data: { x: 1 }
 
-      expect(link).to have_selector '[data-context-href="/asdf"]'
+      expect(link).to have_css '[data-context-href="/asdf"]'
     end
   end
 

data/spec/helpers/blacklight_helper_spec.rb

@@ -73,8 +73,7 @@ RSpec.describe BlacklightHelper do
     end
 
     before do
-      allow(helper).to receive(:document_presenter).and_return(presenter)
-      allow(helper).to receive(:blacklight_config).and_return(blacklight_config)
+      allow(helper).to receive_messages(document_presenter: presenter, blacklight_config: blacklight_config)
     end
 
     it "generates <link rel=alternate> tags" do
@@ -109,8 +108,8 @@ RSpec.describe BlacklightHelper do
       it "renders partials" do
         buff = String.new
         helper.render_nav_actions { |_config, item| buff << "<foo>#{item}</foo>" }
-        expect(buff).to have_selector "foo a#bookmarks_nav[href=\"/bookmarks\"]"
-        expect(buff).to have_selector "foo a span[data-role='bookmark-counter']", text: '0'
+        expect(buff).to have_css "foo a#bookmarks_nav[href=\"/bookmarks\"]"
+        expect(buff).to have_css "foo a span[data-role='bookmark-counter']", text: '0'
       end
     end
 
@@ -118,7 +117,7 @@ RSpec.describe BlacklightHelper do
       it "renders partials" do
         allow(controller).to receive(:render_bookmarks_control?).and_return(true)
         response = helper.render_index_doc_actions(document)
-        expect(response).to have_selector(".bookmark-toggle")
+        expect(response).to have_css(".bookmark-toggle")
       end
 
       it "is nil if no partials are renderable" do
@@ -138,27 +137,28 @@ RSpec.describe BlacklightHelper do
     subject { helper.opensearch_description_tag 'title', 'href' }
 
     it "has a search rel" do
-      expect(subject).to have_selector "link[rel='search']", visible: false
+      expect(subject).to have_css "link[rel='search']", visible: false
     end
 
     it "has the correct mime type" do
-      expect(subject).to have_selector "link[type='application/opensearchdescription+xml']", visible: false
+      expect(subject).to have_css "link[type='application/opensearchdescription+xml']", visible: false
     end
 
     it "has a title attribute" do
-      expect(subject).to have_selector "link[title='title']", visible: false
+      expect(subject).to have_css "link[title='title']", visible: false
     end
 
     it "has an href attribute" do
-      expect(subject).to have_selector "link[href='href']", visible: false
+      expect(subject).to have_css "link[href='href']", visible: false
     end
   end
 
   describe "#render_document_index" do
     it "renders the document index with the current view type" do
       allow(helper).to receive_messages(document_index_view_type: :current_view)
-      allow(helper).to receive(:render_document_index_with_view).with(:current_view, [], { a: 1, b: 2 })
+      allow(helper).to receive(:render_document_index_with_view)
       helper.render_document_index [], a: 1, b: 2
+      expect(helper).to have_received(:render_document_index_with_view).with(:current_view, [], { a: 1, b: 2 })
     end
   end
 
@@ -167,17 +167,15 @@ RSpec.describe BlacklightHelper do
     let(:blacklight_config) { CatalogController.blacklight_config.deep_copy }
 
     before do
-      allow(helper).to receive(:blacklight_config).and_return(blacklight_config)
       assign(:response, instance_double(Blacklight::Solr::Response, grouped?: false, start: 0))
-      allow(helper).to receive(:link_to_document).and_return('<a/>')
-      allow(helper).to receive(:render_index_doc_actions).and_return('<div/>')
+      allow(helper).to receive_messages(blacklight_config: blacklight_config, link_to_document: '<a/>', render_index_doc_actions: '<div/>')
     end
 
     it "ignores missing templates" do
       blacklight_config.view.view_type(partials: %w[index_header a b])
 
       response = helper.render_document_index_with_view :view_type, [obj1, obj1]
-      expect(response).to have_selector "div#documents"
+      expect(response).to have_css "div#documents"
     end
 
     context 'with a template partial provided by the view config' do
@@ -191,7 +189,7 @@ RSpec.describe BlacklightHelper do
         # https://github.com/rspec/rspec-rails/commit/4d65bea0619955acb15023b9c3f57a3a53183da8
         # https://github.com/rspec/rspec-rails/issues/2696
         replace_hash = { 'my/_partial.html.erb' => 'some content' }
-        if ::Rails.version.to_f >= 7.1
+        if Rails.version.to_f >= 7.1
           controller.prepend_view_path(RSpec::Rails::ViewExampleGroup::StubResolverCache.resolver_for(replace_hash))
         else
           view.view_paths.unshift(ActionView::FixtureResolver.new(replace_hash))

data/spec/helpers/catalog_helper_spec.rb

@@ -267,8 +267,7 @@ RSpec.describe CatalogHelper do
     subject { helper.render_search_to_page_title(Blacklight::SearchState.new(params, blacklight_config)) }
 
     before do
-      allow(helper).to receive(:blacklight_config).and_return(blacklight_config)
-      allow(helper).to receive(:default_search_field).and_return(Blacklight::Configuration::SearchField.new(key: 'default_search_field', display_label: 'Default'))
+      allow(helper).to receive_messages(blacklight_config: blacklight_config, default_search_field: Blacklight::Configuration::SearchField.new(key: 'default_search_field', display_label: 'Default'))
       allow(helper).to receive(:label_for_search_field).with(nil).and_return('')
     end
 
@@ -299,8 +298,7 @@ RSpec.describe CatalogHelper do
 
   describe "#document_index_view_type" do
     it "defaults to the default view" do
-      allow(helper).to receive(:document_index_views).and_return(a: 1, b: 2)
-      allow(helper).to receive(:default_document_index_view_type).and_return(:xyz)
+      allow(helper).to receive_messages(document_index_views: { a: 1, b: 2 }, default_document_index_view_type: :xyz)
       expect(helper.document_index_view_type).to eq :xyz
     end
 
@@ -310,8 +308,7 @@ RSpec.describe CatalogHelper do
     end
 
     it "uses the default view if the requested view is not available" do
-      allow(helper).to receive(:default_document_index_view_type).and_return(:xyz)
-      allow(helper).to receive(:document_index_views).and_return(a: 1, b: 2)
+      allow(helper).to receive_messages(default_document_index_view_type: :xyz, document_index_views: { a: 1, b: 2 })
       expect(helper.document_index_view_type(view: :c)).to eq :xyz
     end
 

data/spec/i18n_spec.rb

@@ -12,7 +12,8 @@ RSpec.describe 'I18n', type: :i18n do
                             "Missing #{missing_keys.leaves.count} i18n keys, run `i18n-tasks missing' to show them"
   end
 
-  pending 'does not have unused keys' do
+  it 'does not have unused keys' do
+    pending 'Many unused keys are detected'
     expect(unused_keys).to be_empty,
                            "#{unused_keys.leaves.count} unused i18n keys, run `i18n-tasks unused' to show them"
   end

data/spec/lib/blacklight/nested_open_struct_with_hash_access_spec.rb

@@ -23,7 +23,7 @@ RSpec.describe Blacklight::NestedOpenStructWithHashAccess do
 
   describe "#deep_dup" do
     it "preserves the current class" do
-      expect(described_class.new(described_class).deep_dup).to be_a_kind_of described_class
+      expect(described_class.new(described_class).deep_dup).to be_a described_class
     end
 
     it "preserves the default proc" do

data/spec/lib/blacklight/open_struct_with_hash_access_spec.rb

@@ -36,7 +36,7 @@ RSpec.describe Blacklight::OpenStructWithHashAccess do
     end
 
     it "exposes the internal hash table" do
-      expect(@h.to_h).to be_a_kind_of(Hash)
+      expect(@h.to_h).to be_a(Hash)
       expect(@h.to_h[:a]).to eq 1
     end
 

data/spec/lib/blacklight/search_state_spec.rb

@@ -37,7 +37,7 @@ RSpec.describe Blacklight::SearchState do
     end
 
     context 'with HashWithIndifferentAccess' do
-      let(:parameter_class) { HashWithIndifferentAccess }
+      let(:parameter_class) { ActiveSupport::HashWithIndifferentAccess }
 
       it 'returns the hash data' do
         expect(search_state.to_h).to eq data.with_indifferent_access
@@ -356,7 +356,7 @@ RSpec.describe Blacklight::SearchState do
   end
 
   describe "#url_for_document" do
-    let(:controller_class) { ::CatalogController.new }
+    let(:controller_class) { CatalogController.new }
     let(:doc) { SolrDocument.new }
 
     before do
@@ -375,7 +375,7 @@ RSpec.describe Blacklight::SearchState do
     end
 
     context "within bookmarks" do
-      let(:controller_class) { ::BookmarksController.new }
+      let(:controller_class) { BookmarksController.new }
 
       it "uses polymorphic routing" do
         expect(search_state.url_for_document(doc)).to eq doc
@@ -383,7 +383,7 @@ RSpec.describe Blacklight::SearchState do
     end
 
     context "within an alternative catalog controller" do
-      let(:controller_class) { ::AlternateController.new }
+      let(:controller_class) { AlternateController.new }
 
       before do
         search_state.blacklight_config.show.route = { controller: :current }

data/spec/lib/tasks/blacklight_task_spec.rb

@@ -13,7 +13,8 @@ RSpec.describe "blacklight:delete_old_searches" do
 
   it "calls Search.delete_old_searches" do
     days_old = 7
-    allow(Search).to receive(:delete_old_searches).with(days_old)
+    allow(Search).to receive(:delete_old_searches)
     @rake[@task_name].invoke(days_old)
+    expect(Search).to have_received(:delete_old_searches).with(days_old)
   end
 end

data/spec/models/blacklight/configurable_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-RSpec.describe "Blacklight::Configurable", api: true do
+RSpec.describe "Blacklight::Configurable", :api do
   describe "inheritence" do
     before(:all) do
       module TestCaseInheritence

data/spec/models/blacklight/configuration/context_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-RSpec.describe Blacklight::Configuration::Context, api: true do
+RSpec.describe Blacklight::Configuration::Context, :api do
   subject { described_class.new(context) }
 
   let(:context) { double }

data/spec/models/blacklight/configuration_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-RSpec.describe "Blacklight::Configuration", api: true do
+RSpec.describe "Blacklight::Configuration", :api do
   let(:config) do
     Blacklight::Configuration.new
   end
@@ -14,7 +14,7 @@ RSpec.describe "Blacklight::Configuration", api: true do
 
   describe "initialization" do
     it "is an OpenStructWithHashAccess" do
-      expect(config).to be_a_kind_of Blacklight::OpenStructWithHashAccess
+      expect(config).to be_a Blacklight::OpenStructWithHashAccess
     end
 
     it "accepts a block for configuration" do
@@ -30,22 +30,22 @@ RSpec.describe "Blacklight::Configuration", api: true do
 
   describe "defaults" do
     it "has a hash of default rsolr query parameters" do
-      expect(config.default_solr_params).to be_a_kind_of Hash
+      expect(config.default_solr_params).to be_a Hash
     end
 
     it "has openstruct values for show and index parameters" do
-      expect(config.show).to be_a_kind_of OpenStruct
-      expect(config.index).to be_a_kind_of OpenStruct
+      expect(config.show).to be_a OpenStruct
+      expect(config.index).to be_a OpenStruct
     end
 
     it "has ordered hashes for field configuration" do
-      expect(config.facet_fields).to be_a_kind_of Hash
-      expect(config.index_fields).to be_a_kind_of Hash
-      expect(config.show_fields).to be_a_kind_of Hash
-      expect(config.search_fields).to be_a_kind_of Hash
-      expect(config.show_fields).to be_a_kind_of Hash
-      expect(config.search_fields).to be_a_kind_of Hash
-      expect(config.sort_fields).to be_a_kind_of Hash
+      expect(config.facet_fields).to be_a Hash
+      expect(config.index_fields).to be_a Hash
+      expect(config.show_fields).to be_a Hash
+      expect(config.search_fields).to be_a Hash
+      expect(config.show_fields).to be_a Hash
+      expect(config.search_fields).to be_a Hash
+      expect(config.sort_fields).to be_a Hash
     end
   end
 
@@ -197,7 +197,7 @@ RSpec.describe "Blacklight::Configuration", api: true do
         config.add_my_custom_facet_field 'qwerty', label: "asdf"
       end
 
-      expect(config.my_custom_facet_fields['qwerty']).to be_a_kind_of(Blacklight::Configuration::FacetField)
+      expect(config.my_custom_facet_fields['qwerty']).to be_a(Blacklight::Configuration::FacetField)
     end
   end
 
@@ -352,7 +352,7 @@ RSpec.describe "Blacklight::Configuration", api: true do
       expect(config.index_fields.keys).to eq %w[some_field_display another_field_display]
     end
 
-    it "queries solr and get live values for match fields", integration: true do
+    it "queries solr and get live values for match fields", :integration do
       config.add_index_field match: /title.+sim/
       expect(config.index_fields.keys).to include "subtitle_tsim", "subtitle_vern_ssim", "title_tsim", "title_vern_ssim"
     end

data/spec/models/blacklight/document/active_model_shim_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-RSpec.describe 'Blacklight::Document::ActiveModelShim', api: true do
+RSpec.describe 'Blacklight::Document::ActiveModelShim', :api do
   class MockDocument
     include Blacklight::Document
     include Blacklight::Document::ActiveModelShim

data/spec/models/blacklight/document/cache_key_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-RSpec.describe Blacklight::Document::CacheKey, api: true do
+RSpec.describe Blacklight::Document::CacheKey, :api do
   let(:attributes) { {} }
   let(:subject) { SolrDocument.new(attributes) }
 

data/spec/models/blacklight/document_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-RSpec.describe Blacklight::Document, api: true do
+RSpec.describe Blacklight::Document, :api do
   subject do
     Class.new do
       include Blacklight::Document

data/spec/models/blacklight/facet_paginator_spec.rb

@@ -1,15 +1,15 @@
 # frozen_string_literal: true
 
-RSpec.describe Blacklight::FacetPaginator, api: true do
-  let(:f1) { Blacklight::Solr::Response::Facets::FacetItem.new(hits: '792', value: 'Book') }
-  let(:f2) { Blacklight::Solr::Response::Facets::FacetItem.new(hits: '65', value: 'Musical Score') }
-  let(:f3) { Blacklight::Solr::Response::Facets::FacetItem.new(hits: '58', value: 'Serial') }
-  let(:f4) { Blacklight::Solr::Response::Facets::FacetItem.new(hits: '48', value: 'Musical Recording') }
-  let(:f5) { Blacklight::Solr::Response::Facets::FacetItem.new(hits: '37', value: 'Microform') }
-  let(:f6) { Blacklight::Solr::Response::Facets::FacetItem.new(hits: '27', value: 'Thesis') }
-  let(:f7) { Blacklight::Solr::Response::Facets::FacetItem.new(hits: '0') }
-  let(:seven_facet_values) { [f1, f2, f3, f4, f5, f6, f7] }
-  let(:six_facet_values) { [f1, f2, f3, f4, f5, f6] }
+RSpec.describe Blacklight::FacetPaginator, :api do
+  let(:book) { Blacklight::Solr::Response::Facets::FacetItem.new(hits: '792', value: 'Book') }
+  let(:musical_score) { Blacklight::Solr::Response::Facets::FacetItem.new(hits: '65', value: 'Musical Score') }
+  let(:serial) { Blacklight::Solr::Response::Facets::FacetItem.new(hits: '58', value: 'Serial') }
+  let(:musical_recording) { Blacklight::Solr::Response::Facets::FacetItem.new(hits: '48', value: 'Musical Recording') }
+  let(:microform) { Blacklight::Solr::Response::Facets::FacetItem.new(hits: '37', value: 'Microform') }
+  let(:thesis) { Blacklight::Solr::Response::Facets::FacetItem.new(hits: '27', value: 'Thesis') }
+  let(:blank) { Blacklight::Solr::Response::Facets::FacetItem.new(hits: '0') }
+  let(:seven_facet_values) { [book, musical_score, serial, musical_recording, microform, thesis, blank] }
+  let(:six_facet_values) { [book, musical_score, serial, musical_recording, microform, thesis] }
   let(:limit) { 6 }
 
   context 'on the first page of two pages' do
@@ -42,7 +42,7 @@ RSpec.describe Blacklight::FacetPaginator, api: true do
   end
 
   context 'on the last page of two pages' do
-    subject(:paginator) { described_class.new([f7], offset: 6, limit: limit) }
+    subject(:paginator) { described_class.new([blank], offset: 6, limit: limit) }
 
     it { is_expected.not_to be_first_page }
     it { is_expected.to be_last_page }
@@ -124,7 +124,7 @@ RSpec.describe Blacklight::FacetPaginator, api: true do
     context 'when sorting by "count"' do
       subject { described_class.new([]) }
 
-      let(:params) { HashWithIndifferentAccess.new 'facet.prefix': 'A' }
+      let(:params) { ActiveSupport::HashWithIndifferentAccess.new 'facet.prefix': 'A' }
 
       it 'includes the prefix filter for "index" sorting' do
         expect(subject.params_for_resort_url('index', params)).to include 'facet.prefix': 'A'
@@ -159,7 +159,7 @@ RSpec.describe Blacklight::FacetPaginator, api: true do
   end
 
   describe "#as_json" do
-    subject { described_class.new([f1], offset: 0, limit: nil).as_json }
+    subject { described_class.new([book], offset: 0, limit: nil).as_json }
 
     it "is well structured" do
       expect(subject).to eq("items" => [{ "hits" => "792", "value" => "Book" }], "limit" => nil,
@@ -169,7 +169,7 @@ RSpec.describe Blacklight::FacetPaginator, api: true do
 
   describe "#total_pages" do
     # this method is just for API compatability with kaminari 0.16.1
-    subject { described_class.new([f1], offset: 0, limit: nil).total_pages }
+    subject { described_class.new([book], offset: 0, limit: nil).total_pages }
 
     it { is_expected.to eq -1 }
   end

data/spec/models/blacklight/icon_spec.rb

@@ -39,7 +39,7 @@ RSpec.describe Blacklight::Icon do
 
       it 'does not add title' do
         expect(Capybara.string(subject.svg))
-          .not_to have_css 'title', text: 'Test'
+          .to have_no_css 'title', text: 'Test'
       end
     end
 

data/spec/models/blacklight/search_builder_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-RSpec.describe Blacklight::SearchBuilder, api: true do
+RSpec.describe Blacklight::SearchBuilder, :api do
   subject(:builder) { described_class.new processor_chain, scope }
 
   let(:processor_chain) { [] }

data/spec/models/blacklight/solr/document_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-RSpec.describe "Blacklight::Solr::Document", api: true do
+RSpec.describe "Blacklight::Solr::Document", :api do
   class MockDocument
     include Blacklight::Solr::Document
   end
@@ -231,7 +231,7 @@ RSpec.describe "Blacklight::Solr::Document", api: true do
     end
 
     it "returns an array even for a single-value field" do
-      expect(@doc1.to_semantic_values[:title]).to be_kind_of(Array)
+      expect(@doc1.to_semantic_values[:title]).to be_a(Array)
     end
 
     it "returns complete array for a multi-value field" do
@@ -290,7 +290,7 @@ RSpec.describe "Blacklight::Solr::Document", api: true do
 
     it "plucks the MoreLikeThis results from the Solr Response" do
       expect(result).to have(1).item
-      expect(result.first).to be_a_kind_of(MockDocument)
+      expect(result.first).to be_a(MockDocument)
       expect(result.first.id).to eq 'abc'
       expect(result.first.solr_response).to eq response
     end

data/spec/models/blacklight/solr/facet_paginator_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-RSpec.describe Blacklight::Solr::FacetPaginator, api: true do
+RSpec.describe Blacklight::Solr::FacetPaginator, :api do
   let(:f1) { Blacklight::Solr::Response::Facets::FacetItem.new(hits: '792', value: 'Book') }
 
   describe "#as_json" do

data/spec/models/blacklight/solr/repository_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-RSpec.describe Blacklight::Solr::Repository, api: true do
+RSpec.describe Blacklight::Solr::Repository, :api do
   subject(:repository) do
     described_class.new blacklight_config
   end
@@ -24,12 +24,12 @@ RSpec.describe Blacklight::Solr::Repository, api: true do
       blacklight_config.document_solr_path = 'abc'
       blacklight_config.solr_path = 'xyz'
       allow(subject.connection).to receive(:send_and_receive).with('abc', anything).and_return(mock_response)
-      expect(subject.find("123")).to be_a_kind_of Blacklight::Solr::Response
+      expect(subject.find("123")).to be_a Blacklight::Solr::Response
     end
 
     it "uses a default :qt param" do
       allow(subject.connection).to receive(:send_and_receive).with('get', hash_including(params: hash_including(ids: '123'))).and_return(mock_response)
-      expect(subject.find("123", {})).to be_a_kind_of Blacklight::Solr::Response
+      expect(subject.find("123", {})).to be_a Blacklight::Solr::Response
     end
 
     context "without a document solr path configured" do
@@ -40,7 +40,7 @@ RSpec.describe Blacklight::Solr::Repository, api: true do
       it "uses the default solr path" do
         blacklight_config.solr_path = 'xyz'
         allow(subject.connection).to receive(:send_and_receive).with('xyz', anything).and_return(mock_response)
-        expect(subject.find("123")).to be_a_kind_of Blacklight::Solr::Response
+        expect(subject.find("123")).to be_a Blacklight::Solr::Response
       end
     end
 
@@ -53,14 +53,14 @@ RSpec.describe Blacklight::Solr::Repository, api: true do
       it "uses the provided :qt param" do
         blacklight_config.document_solr_request_handler = 'xyz'
         allow(subject.connection).to receive(:send_and_receive).with('select', hash_including(params: { id: '123', qt: 'abc' })).and_return(mock_response)
-        expect(subject.find("123", qt: 'abc')).to be_a_kind_of Blacklight::Solr::Response
+        expect(subject.find("123", qt: 'abc')).to be_a Blacklight::Solr::Response
       end
 
       it "uses the :qt parameter from the default_document_solr_params" do
         blacklight_config.default_document_solr_params[:qt] = 'abc'
         blacklight_config.document_solr_request_handler = 'xyz'
         allow(subject.connection).to receive(:send_and_receive).with('select', hash_including(params: { id: '123', qt: 'abc' })).and_return(mock_response)
-        expect(subject.find("123")).to be_a_kind_of Blacklight::Solr::Response
+        expect(subject.find("123")).to be_a Blacklight::Solr::Response
       end
     end
 
@@ -68,8 +68,26 @@ RSpec.describe Blacklight::Solr::Repository, api: true do
       doc_params = ActiveSupport::HashWithIndifferentAccess.new
       allow(subject.connection).to receive(:send_and_receive).with('get', anything).and_return(mock_response)
       response = subject.find("123", doc_params)
-      expect(response).to be_a_kind_of Blacklight::Solr::Response
-      expect(response.params).to be_a_kind_of ActiveSupport::HashWithIndifferentAccess
+      expect(response).to be_a Blacklight::Solr::Response
+      expect(response.params).to be_a ActiveSupport::HashWithIndifferentAccess
+    end
+  end
+
+  describe '#find_many' do
+    context 'with a configured fetch_many_documents_path' do
+      it 'uses the path' do
+        blacklight_config.fetch_many_documents_path = 'documents'
+        allow(subject.connection).to receive(:send_and_receive).with('documents', anything).and_return(mock_response)
+        expect(subject.find_many({})).to be_a Blacklight::Solr::Response
+      end
+    end
+
+    context 'without a configured fetch_many_documents_path' do
+      it 'falls back to the search path' do
+        blacklight_config.solr_path = 'xyz'
+        allow(subject.connection).to receive(:send_and_receive).with('xyz', anything).and_return(mock_response)
+        expect(subject.find_many({})).to be_a Blacklight::Solr::Response
+      end
     end
   end
 
@@ -77,24 +95,24 @@ RSpec.describe Blacklight::Solr::Repository, api: true do
     it "uses the search-specific solr path" do
       blacklight_config.solr_path = 'xyz'
       allow(subject.connection).to receive(:send_and_receive).with('xyz', anything).and_return(mock_response)
-      expect(subject.search({})).to be_a_kind_of Blacklight::Solr::Response
+      expect(subject.search({})).to be_a Blacklight::Solr::Response
     end
 
     it "uses the default solr path" do
       allow(subject.connection).to receive(:send_and_receive).with('select', anything).and_return(mock_response)
-      expect(subject.search({})).to be_a_kind_of Blacklight::Solr::Response
+      expect(subject.search({})).to be_a Blacklight::Solr::Response
     end
 
     it "uses a default :qt param" do
       blacklight_config.qt = 'xyz'
       allow(subject.connection).to receive(:send_and_receive).with('select', hash_including(params: { qt: 'xyz' })).and_return(mock_response)
-      expect(subject.search({})).to be_a_kind_of Blacklight::Solr::Response
+      expect(subject.search({})).to be_a Blacklight::Solr::Response
     end
 
     it "uses the provided :qt param" do
       blacklight_config.qt = 'xyz'
       allow(subject.connection).to receive(:send_and_receive).with('select', hash_including(params: { qt: 'abc' })).and_return(mock_response)
-      expect(subject.search(qt: 'abc')).to be_a_kind_of Blacklight::Solr::Response
+      expect(subject.search(qt: 'abc')).to be_a Blacklight::Solr::Response
     end
 
     it "preserves the class of the incoming params" do
@@ -103,8 +121,8 @@ RSpec.describe Blacklight::Solr::Repository, api: true do
       allow(subject.connection).to receive(:send_and_receive).with('select', anything).and_return(mock_response)
 
       response = subject.search(search_params)
-      expect(response).to be_a_kind_of Blacklight::Solr::Response
-      expect(response.params).to be_a_kind_of ActiveSupport::HashWithIndifferentAccess
+      expect(response).to be_a Blacklight::Solr::Response
+      expect(response.params).to be_a ActiveSupport::HashWithIndifferentAccess
     end
 
     it "calls send_and_receive with params returned from request factory method" do
@@ -183,7 +201,7 @@ RSpec.describe Blacklight::Solr::Repository, api: true do
     end
   end
 
-  describe "http_method configuration", integration: true do
+  describe "http_method configuration", :integration do
     let (:blacklight_config) { config = Blacklight::Configuration.new; config.http_method = :post; config }
 
     it "sends a post request to solr and get a response back" do

data/spec/models/blacklight/solr/request_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-RSpec.describe Blacklight::Solr::Request, api: true do
+RSpec.describe Blacklight::Solr::Request, :api do
   context 'with some solr parameter keys' do
     before do
       subject[:qt] = 'hey'

data/spec/models/blacklight/solr/response/facets_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-RSpec.describe Blacklight::Solr::Response::Facets, api: true do
+RSpec.describe Blacklight::Solr::Response::Facets, :api do
   describe Blacklight::Solr::Response::Facets::FacetField do
     describe "A field with default options" do
       subject(:field) { described_class.new "my_field", [] }
@@ -247,7 +247,7 @@ RSpec.describe Blacklight::Solr::Response::Facets, api: true do
     it "converts the query facets into a double RSolr FacetField" do
       field = subject.aggregations['my_query_facet_field']
 
-      expect(field).to be_a_kind_of Blacklight::Solr::Response::Facets::FacetField
+      expect(field).to be_a Blacklight::Solr::Response::Facets::FacetField
 
       expect(field.name).to eq 'my_query_facet_field'
       expect(field.items.size).to eq 3
@@ -316,7 +316,7 @@ RSpec.describe Blacklight::Solr::Response::Facets, api: true do
     it "converts the pivot facet into a double RSolr FacetField" do
       field = subject.aggregations['my_pivot_facet_field']
 
-      expect(field).to be_a_kind_of Blacklight::Solr::Response::Facets::FacetField
+      expect(field).to be_a Blacklight::Solr::Response::Facets::FacetField
 
       expect(field.name).to eq 'my_pivot_facet_field'