blacklight 7.8.0 → 7.8.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 103d3b133711969469b938bec955df2f26e460762dd4734574bd1aecc4fb6451
-  data.tar.gz: b483715ad76633f2cccdca1292a035a7f8714d00acd8b1f6f1a14b6f63e7cfe5
+  metadata.gz: 797fccb08c32206cbf11ab04efa5b980456a8a1ff2f949940ce68b9b29843720
+  data.tar.gz: 26608839399a44a7f33f4313337a35c5a064578daa0819cc845a601c9d058d3c
 SHA512:
-  metadata.gz: 1216b0bc9e7824cd19ac8503932f28de07a7fa9c058b762d90cf479c9c792070ccea3b48c38676d4da54b95681ff52c848a886011a86c6743bf526f74dcb4ba8
-  data.tar.gz: 92ed30878b6bd680f5ea8c8ea8e49f170aace6615f56645feae0ab383a7334d6b0a8a5a539634547f9e967b90007e28e7dbdde5712b64006e06e4ca5f64de776
+  metadata.gz: 2066cfd8c17650d43b39707f8d73c39745307eff3795875833f0a1e0c794ba92a8aae1aa061db59e5a39154332e0e5addcb3a4d4463894ccc641eee57ed40b7e
+  data.tar.gz: 3403d40968957aadb62eba71caed870704c23bbebf93f98910bba9931ca136b80d79ba411cb1852a2a48bf227e3456fd1d91fc8ecd01b7b8aad852dbb3f4ab8e

data/VERSION

@@ -1 +1 @@
-7.8.0
+7.8.1

data/app/components/blacklight/constraint_layout_component.html.erb

@@ -10,12 +10,14 @@
   <% if @remove_path.present? %>
     <%= link_to(@remove_path, class: 'btn btn-outline-secondary remove') do %>
       <span class="remove-icon">✖</span>
-      <%= if @label.blank?
+      <span class="sr-only">
+        <%= if @label.blank?
             t('blacklight.search.filters.remove.value', value: @value)
           else
             t('blacklight.search.filters.remove.label_value', label: @label, value: @value)
           end
-      %>
+        %>
+      </span>
     <% end %>
   <% end %>
 </span>

data/lib/blacklight/search_state.rb

@@ -37,6 +37,26 @@ module Blacklight
     end
     alias to_h to_hash
 
+    def to_unsafe_h
+      Deprecation.warn(self, 'Use SearchState#to_h instead of SearchState#to_unsafe_h')
+      to_hash
+    end
+
+    def method_missing(method_name, *arguments, &block)
+      if @params.respond_to?(method_name)
+        Deprecation.warn(self, "Calling `#{method_name}` on Blacklight::SearchState " \
+          'is deprecated and will be removed in Blacklight 8. Call #to_h first if you ' \
+          ' need to use hash methods (or, preferably, use your own SearchState implementation)')
+        @params.public_send(method_name, *arguments, &block)
+      else
+        super
+      end
+    end
+
+    def respond_to_missing?(method_name, include_private = false)
+      @params.respond_to?(method_name, include_private) || super
+    end
+
     # Tiny shim to make it easier to migrate raw params access to using this class
     delegate :[], to: :params
     deprecation_deprecate :[]

data/spec/components/blacklight/constraint_layout_component_spec.rb

@@ -38,7 +38,7 @@ RSpec.describe Blacklight::ConstraintLayoutComponent, type: :component do
     end
     it "has an accessible remove label" do
       expect(rendered).to have_selector(".remove") do |s|
-        expect(s).to have_content("Remove constraint my label: my value")
+        expect(s).to have_selector('.sr-only', text: 'Remove constraint my label: my value')
       end
     end
   end

data/spec/lib/blacklight/search_state_spec.rb

@@ -48,6 +48,18 @@ RSpec.describe Blacklight::SearchState do
     end
   end
 
+  describe 'interface compatibility with params' do
+    let(:params) { parameter_class.new f: { ff: ['xyz'] } }
+
+    it 'implements param methods' do
+      Deprecation.silence(described_class) do
+        expect(search_state.to_unsafe_h).to eq('f' => { 'ff' => ['xyz'] })
+        expect(search_state.fetch(:f)).to eq('ff' => ['xyz'])
+        expect(search_state.select { |k, _v,| k == 'f' }).to eq('f' => { 'ff' => ['xyz'] })
+      end
+    end
+  end
+
   describe '#query_param' do
     let(:params) { parameter_class.new q: 'xyz' }
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: blacklight
 version: !ruby/object:Gem::Version
-  version: 7.8.0
+  version: 7.8.1
 platform: ruby
 authors:
 - Jonathan Rochkind
@@ -17,7 +17,7 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2020-05-21 00:00:00.000000000 Z
+date: 2020-06-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails