blacklight 7.38.0 → 7.39.0

data/.rubocop_todo.yml

@@ -1,13 +1,13 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2020-09-24 02:12:21 UTC using RuboCop version 0.91.1.
+# on 2024-09-23 14:38:22 UTC using RuboCop version 1.66.1.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
 # Offense count: 4
-# Cop supports --auto-correct.
+# This cop supports safe autocorrection (--autocorrect).
 Capybara/CurrentPathExpectation:
   Exclude:
     - 'spec/features/alternate_controller_spec.rb'
@@ -20,8 +20,17 @@ Capybara/VisibilityMatcher:
     - 'spec/helpers/blacklight/hash_as_hidden_fields_behavior_spec.rb'
     - 'spec/helpers/blacklight_helper_spec.rb'
 
+# Offense count: 2
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: EnforcedStyleAlignWith, Severity.
+# SupportedStylesAlignWith: start_of_line, begin
+Layout/BeginEndAlignment:
+  Exclude:
+    - 'app/models/record_mailer.rb'
+    - 'spec/features/search_results_spec.rb'
+
 # Offense count: 8
-# Cop supports --auto-correct.
+# This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: EnforcedStyle, IndentOneStep, IndentationWidth.
 # SupportedStyles: case, end
 Layout/CaseIndentation:
@@ -31,26 +40,26 @@ Layout/CaseIndentation:
     - 'lib/blacklight/configuration/fields.rb'
 
 # Offense count: 2
-# Cop supports --auto-correct.
+# This cop supports safe autocorrection (--autocorrect).
 Layout/ClosingParenthesisIndentation:
   Exclude:
     - 'app/views/catalog/index.atom.builder'
 
-# Offense count: 111
-# Cop supports --auto-correct.
+# Offense count: 114
+# This cop supports safe autocorrection (--autocorrect).
 Layout/EmptyLineAfterMagicComment:
   Enabled: false
 
 # Offense count: 1
-# Cop supports --auto-correct.
+# This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: AllowAliasSyntax, AllowedMethods.
 # AllowedMethods: alias_method, public, protected, private
 Layout/EmptyLinesAroundAttributeAccessor:
   Exclude:
     - 'app/presenters/blacklight/field_presenter.rb'
 
-# Offense count: 7
-# Cop supports --auto-correct.
+# Offense count: 8
+# This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: AllowForAlignment, AllowBeforeTrailingComments, ForceEqualSignAlignment.
 Layout/ExtraSpacing:
   Exclude:
@@ -58,17 +67,10 @@ Layout/ExtraSpacing:
     - 'app/models/record_mailer.rb'
     - 'app/views/catalog/index.atom.builder'
     - 'config/routes.rb'
+    - 'spec/models/blacklight/configurable_spec.rb'
 
-# Offense count: 2
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, IndentationWidth.
-# SupportedStyles: special_inside_parentheses, consistent, align_braces
-Layout/FirstHashElementIndentation:
-  Exclude:
-    - 'lib/blacklight/configuration.rb'
-
-# Offense count: 6
-# Cop supports --auto-correct.
+# Offense count: 9
+# This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: AllowDoxygenCommentStyle, AllowGemfileRubyComment.
 Layout/LeadingCommentSpace:
   Exclude:
@@ -76,15 +78,16 @@ Layout/LeadingCommentSpace:
     - 'app/models/concerns/blacklight/configurable.rb'
     - 'app/models/concerns/blacklight/document/export.rb'
     - 'app/views/catalog/_document.atom.builder'
+    - 'lib/blacklight/solr/response/pagination_methods.rb'
 
 # Offense count: 1
-# Cop supports --auto-correct.
+# This cop supports safe autocorrection (--autocorrect).
 Layout/MultilineBlockLayout:
   Exclude:
     - 'lib/generators/blacklight/test_support_generator.rb'
 
 # Offense count: 2
-# Cop supports --auto-correct.
+# This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: symmetrical, new_line, same_line
 Layout/MultilineMethodCallBraceLayout:
@@ -92,7 +95,7 @@ Layout/MultilineMethodCallBraceLayout:
     - 'app/views/catalog/index.atom.builder'
 
 # Offense count: 9
-# Cop supports --auto-correct.
+# This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: EnforcedStyle, IndentationWidth.
 # SupportedStyles: aligned, indented, indented_relative_to_receiver
 Layout/MultilineMethodCallIndentation:
@@ -100,7 +103,7 @@ Layout/MultilineMethodCallIndentation:
     - 'lib/blacklight/search_builder.rb'
 
 # Offense count: 9
-# Cop supports --auto-correct.
+# This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: EnforcedStyle, IndentationWidth.
 # SupportedStyles: aligned, indented
 Layout/MultilineOperationIndentation:
@@ -111,42 +114,45 @@ Layout/MultilineOperationIndentation:
     - 'lib/blacklight/solr/search_builder_behavior.rb'
 
 # Offense count: 2
-# Cop supports --auto-correct.
+# This cop supports safe autocorrection (--autocorrect).
+Layout/RescueEnsureAlignment:
+  Exclude:
+    - 'app/models/record_mailer.rb'
+    - 'spec/features/search_results_spec.rb'
+
+# Offense count: 2
+# This cop supports safe autocorrection (--autocorrect).
 Layout/SpaceAfterComma:
   Exclude:
     - 'app/views/catalog/index.atom.builder'
     - 'app/views/catalog/opensearch.xml.builder'
 
-# Offense count: 1
-# Cop supports --auto-correct.
+# Offense count: 2
+# This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: AllowForAlignment.
 Layout/SpaceBeforeFirstArg:
   Exclude:
     - 'app/views/catalog/index.atom.builder'
+    - 'spec/models/blacklight/configurable_spec.rb'
 
 # Offense count: 7
-# Cop supports --auto-correct.
+# This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: EnforcedStyle.
-# SupportedStyles: space, no_space
+# SupportedStyles: space, compact, no_space
 Layout/SpaceInsideParens:
   Exclude:
     - 'app/views/catalog/_document.rss.builder'
     - 'app/views/catalog/index.atom.builder'
 
 # Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: AllowInHeredoc.
-Layout/TrailingWhitespace:
-  Exclude:
-    - 'lib/blacklight/configuration.rb'
-
-# Offense count: 1
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: AllowedMethods, AllowedPatterns.
 Lint/AmbiguousBlockAssociation:
   Exclude:
     - 'lib/blacklight/solr/search_builder_behavior.rb'
 
-# Offense count: 8
-# Cop supports --auto-correct.
+# Offense count: 9
+# This cop supports safe autocorrection (--autocorrect).
 Lint/AmbiguousOperator:
   Exclude:
     - 'spec/helpers/blacklight/facets_helper_behavior_spec.rb'
@@ -158,7 +164,7 @@ Lint/AmbiguousOperator:
     - 'spec/services/blacklight/search_service_spec.rb'
 
 # Offense count: 55
-# Cop supports --auto-correct.
+# This cop supports safe autocorrection (--autocorrect).
 Lint/AmbiguousRegexpLiteral:
   Exclude:
     - 'spec/controllers/catalog_controller_spec.rb'
@@ -173,8 +179,39 @@ Lint/AmbiguousRegexpLiteral:
     - 'spec/views/catalog/index.html.erb_spec.rb'
     - 'spec/views/catalog/show.html.erb_spec.rb'
 
-# Offense count: 29
-# Cop supports --auto-correct.
+# Offense count: 1
+Lint/BinaryOperatorWithIdenticalOperands:
+  Exclude:
+    - 'spec/models/blacklight/document/active_model_shim_spec.rb'
+
+# Offense count: 16
+# Configuration parameters: AllowedMethods.
+# AllowedMethods: enums
+Lint/ConstantDefinitionInBlock:
+  Exclude:
+    - 'lib/blacklight/engine.rb'
+    - 'spec/controllers/blacklight/search_fields_spec.rb'
+    - 'spec/controllers/bookmarks_controller_spec.rb'
+    - 'spec/controllers/catalog_controller_spec.rb'
+    - 'spec/models/blacklight/configurable_spec.rb'
+    - 'spec/models/blacklight/document/active_model_shim_spec.rb'
+    - 'spec/models/blacklight/document_spec.rb'
+    - 'spec/models/blacklight/solr/document_spec.rb'
+    - 'spec/presenters/blacklight/show_presenter_spec.rb'
+
+# Offense count: 1
+# Configuration parameters: AllowComments.
+Lint/EmptyFile:
+  Exclude:
+    - 'spec/components/blacklight/document_metadata_component_spec.rb'
+
+# Offense count: 46
+# Configuration parameters: AllowedParentClasses.
+Lint/MissingSuper:
+  Enabled: false
+
+# Offense count: 30
+# This cop supports safe autocorrection (--autocorrect).
 Lint/ParenthesesAsGroupedExpression:
   Exclude:
     - 'spec/features/did_you_mean_spec.rb'
@@ -184,58 +221,58 @@ Lint/ParenthesesAsGroupedExpression:
     - 'spec/lib/blacklight/search_state_spec.rb'
     - 'spec/models/blacklight/solr/repository_spec.rb'
 
+# Offense count: 2
+# This cop supports unsafe autocorrection (--autocorrect-all).
+# Configuration parameters: AllowedMethods.
+# AllowedMethods: instance_of?, kind_of?, is_a?, eql?, respond_to?, equal?, presence, present?
+Lint/RedundantSafeNavigation:
+  Exclude:
+    - 'app/helpers/blacklight/blacklight_helper_behavior.rb'
+    - 'lib/blacklight/solr/response/params.rb'
+
 # Offense count: 2
 Lint/ShadowingOuterLocalVariable:
   Exclude:
     - 'spec/models/blacklight/configuration_spec.rb'
 
-# Offense count: 57
-# Configuration parameters: IgnoredMethods.
+# Offense count: 87
+# Configuration parameters: AllowedMethods, AllowedPatterns, CountRepeatedAttributes.
 Metrics/AbcSize:
-  Max: 59
+  Max: 46
 
 # Offense count: 2
-# Configuration parameters: CountComments, CountAsOne, ExcludedMethods.
-# ExcludedMethods: refine
+# Configuration parameters: CountComments, CountAsOne, AllowedMethods, AllowedPatterns, inherit_mode.
+# AllowedMethods: refine
 Metrics/BlockLength:
-  Max: 30
+  Max: 29
 
-# Offense count: 1
-# Configuration parameters: CountBlocks.
-Metrics/BlockNesting:
-  Max: 4
-
-# Offense count: 2
-# Configuration parameters: CountComments, CountAsOne.
-Metrics/ClassLength:
-  Max: 169
-
-# Offense count: 26
-# Configuration parameters: IgnoredMethods.
+# Offense count: 47
+# Configuration parameters: AllowedMethods, AllowedPatterns.
 Metrics/CyclomaticComplexity:
-  Max: 14
+  Max: 17
 
-# Offense count: 61
-# Configuration parameters: CountComments, CountAsOne, ExcludedMethods.
+# Offense count: 94
+# Configuration parameters: CountComments, CountAsOne, AllowedMethods, AllowedPatterns.
 Metrics/MethodLength:
-  Max: 30
+  Max: 29
 
-# Offense count: 8
+# Offense count: 9
 # Configuration parameters: CountComments, CountAsOne.
 Metrics/ModuleLength:
-  Max: 213
+  Max: 203
 
-# Offense count: 3
-# Configuration parameters: CountKeywordArgs.
+# Offense count: 8
+# Configuration parameters: CountKeywordArgs, MaxOptionalParameters.
 Metrics/ParameterLists:
   Max: 6
 
-# Offense count: 22
-# Configuration parameters: IgnoredMethods.
+# Offense count: 40
+# Configuration parameters: AllowedMethods, AllowedPatterns.
 Metrics/PerceivedComplexity:
-  Max: 16
+  Max: 18
 
 # Offense count: 4
+# This cop supports unsafe autocorrection (--autocorrect-all).
 # Configuration parameters: EnforcedStyleForLeadingUnderscores.
 # SupportedStylesForLeadingUnderscores: disallowed, required, optional
 Naming/MemoizedInstanceVariableName:
@@ -245,34 +282,46 @@ Naming/MemoizedInstanceVariableName:
     - 'app/models/concerns/blacklight/document/semantic_fields.rb'
     - 'lib/blacklight/solr/response.rb'
 
-# Offense count: 13
+# Offense count: 10
 # Configuration parameters: MinNameLength, AllowNamesEndingInNumbers, AllowedNames, ForbiddenNames.
-# AllowedNames: at, by, db, id, in, io, ip, of, on, os, pp, to
+# AllowedNames: as, at, by, cc, db, id, if, in, io, ip, of, on, os, pp, to
 Naming/MethodParameterName:
   Exclude:
     - 'app/models/concerns/blacklight/document.rb'
     - 'app/presenters/blacklight/rendering/link_to_facet.rb'
     - 'lib/blacklight/nested_open_struct_with_hash_access.rb'
-    - 'lib/blacklight/search_state.rb'
     - 'lib/blacklight/solr/document.rb'
     - 'lib/blacklight/solr/search_builder_behavior.rb'
-    - 'spec/features/search_context_spec.rb'
-    - 'spec/features/search_results_spec.rb'
 
-# Offense count: 14
-# Configuration parameters: EnforcedStyle.
+# Offense count: 25
+# Configuration parameters: EnforcedStyle, CheckMethodNames, CheckSymbols, AllowedIdentifiers, AllowedPatterns.
 # SupportedStyles: snake_case, normalcase, non_integer
+# AllowedIdentifiers: capture3, iso8601, rfc1123_date, rfc822, rfc2822, rfc3339, x86_64
 Naming/VariableNumber:
   Exclude:
+    - 'spec/lib/blacklight/search_state_spec.rb'
+    - 'spec/models/blacklight/search_builder_spec.rb'
+    - 'spec/views/catalog/_facet_group.html.erb_spec.rb'
     - 'spec/views/catalog/_index.html.erb_spec.rb'
     - 'spec/views/catalog/_show.html.erb_spec.rb'
 
+# Offense count: 55
+# This cop supports unsafe autocorrection (--autocorrect-all).
+RSpec/BeEq:
+  Enabled: false
+
+# Offense count: 2
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: be, be_nil
+RSpec/BeNil:
+  Exclude:
+    - 'spec/models/blacklight/icon_spec.rb'
+    - 'spec/presenters/thumbnail_presenter_spec.rb'
+
 # Offense count: 9
 RSpec/BeforeAfterAll:
   Exclude:
-    - 'spec/spec_helper.rb'
-    - 'spec/rails_helper.rb'
-    - 'spec/support/**/*.rb'
     - 'spec/controllers/blacklight/search_fields_spec.rb'
     - 'spec/controllers/search_history_controller_spec.rb'
     - 'spec/helpers/blacklight/search_history_constraints_helper_behavior_spec.rb'
@@ -282,48 +331,64 @@ RSpec/BeforeAfterAll:
     - 'spec/models/blacklight/document/sms_spec.rb'
     - 'spec/models/blacklight/solr/document_spec.rb'
 
-# Offense count: 81
-# Configuration parameters: Prefixes.
-# Prefixes: when, with, without
-RSpec/ContextWording:
+# Offense count: 50
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: be_a, be_kind_of
+RSpec/ClassCheck:
   Enabled: false
 
-# Offense count: 42
-RSpec/DescribeClass:
+# Offense count: 110
+# Configuration parameters: Prefixes, AllowedPatterns.
+# Prefixes: when, with, without
+RSpec/ContextWording:
   Enabled: false
 
-# Offense count: 2
-# Configuration parameters: CustomIncludeMethods.
+# Offense count: 1
+# This cop supports unsafe autocorrection (--autocorrect-all).
+# Configuration parameters: AutoCorrect.
 RSpec/EmptyExampleGroup:
   Exclude:
-    - 'spec/helpers/blacklight_helper_spec.rb'
     - 'spec/models/blacklight/solr/search_builder_spec.rb'
 
-# Offense count: 134
-# Configuration parameters: Max.
+# Offense count: 152
+# Configuration parameters: CountAsOne.
 RSpec/ExampleLength:
-  Enabled: false
+  Max: 33
 
-# Offense count: 15
+# Offense count: 2
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: CustomTransform, IgnoredWords, DisallowedExamples.
+# DisallowedExamples: works
+RSpec/ExampleWording:
+  Exclude:
+    - 'spec/helpers/blacklight/url_helper_behavior_spec.rb'
+    - 'spec/presenters/blacklight/facet_item_presenter_spec.rb'
+
+# Offense count: 3
+# This cop supports safe autocorrection (--autocorrect).
+RSpec/ExcessiveDocstringSpacing:
+  Exclude:
+    - 'spec/helpers/blacklight_helper_spec.rb'
+    - 'spec/models/blacklight/icon_spec.rb'
+    - 'spec/models/blacklight/solr/search_builder_spec.rb'
+
+# Offense count: 11
 RSpec/ExpectInHook:
   Exclude:
     - 'spec/controllers/catalog_controller_spec.rb'
     - 'spec/helpers/blacklight/configuration_helper_behavior_spec.rb'
     - 'spec/helpers/blacklight/render_constraints_helper_behavior_spec.rb'
     - 'spec/helpers/blacklight/suggest_helper_behavior_spec.rb'
-    - 'spec/helpers/catalog_helper_spec.rb'
 
-# Offense count: 5
-# Configuration parameters: CustomTransform, IgnoreMethods, SpecSuffixOnly.
-RSpec/FilePath:
+# Offense count: 9
+# Configuration parameters: Max, AllowedIdentifiers, AllowedPatterns.
+RSpec/IndexedLet:
   Exclude:
-    - 'spec/controllers/blacklight/catalog/component_configuration_spec.rb'
-    - 'spec/helpers/blacklight/hash_as_hidden_fields_behavior_spec.rb'
-    - 'spec/models/blacklight/solr/search_builder_spec.rb'
-    - 'spec/presenters/pipeline_spec.rb'
-    - 'spec/presenters/thumbnail_presenter_spec.rb'
+    - 'spec/helpers/blacklight/facets_helper_behavior_spec.rb'
+    - 'spec/models/blacklight/facet_paginator_spec.rb'
 
-# Offense count: 191
+# Offense count: 188
 # Configuration parameters: AssignmentOnly.
 RSpec/InstanceVariable:
   Enabled: false
@@ -347,14 +412,26 @@ RSpec/LeakyConstantDeclaration:
     - 'spec/models/blacklight/solr/document_spec.rb'
     - 'spec/presenters/blacklight/show_presenter_spec.rb'
 
-# Offense count: 8
+# Offense count: 14
+# This cop supports safe autocorrection (--autocorrect).
+RSpec/MatchArray:
+  Exclude:
+    - 'spec/controllers/catalog_controller_spec.rb'
+    - 'spec/helpers/blacklight/facets_helper_behavior_spec.rb'
+    - 'spec/lib/blacklight/open_struct_with_hash_access_spec.rb'
+    - 'spec/models/blacklight/configuration_spec.rb'
+    - 'spec/models/blacklight/search_builder_spec.rb'
+    - 'spec/models/blacklight/solr/request_spec.rb'
+    - 'spec/views/catalog/index.json.jbuilder_spec.rb'
+
+# Offense count: 9
 RSpec/MessageChain:
   Exclude:
     - 'spec/controllers/bookmarks_controller_spec.rb'
     - 'spec/presenters/blacklight/field_presenter_spec.rb'
     - 'spec/views/shared/_user_util_links.html.erb_spec.rb'
 
-# Offense count: 61
+# Offense count: 57
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: have_received, receive
 RSpec/MessageSpies:
@@ -373,24 +450,56 @@ RSpec/MessageSpies:
     - 'spec/presenters/blacklight/field_presenter_spec.rb'
     - 'spec/presenters/thumbnail_presenter_spec.rb'
 
-# Offense count: 363
+# Offense count: 63
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: hash, symbol
+RSpec/MetadataStyle:
+  Enabled: false
+
+# Offense count: 437
 RSpec/MultipleExpectations:
   Max: 16
 
-# Offense count: 160
+# Offense count: 272
 # Configuration parameters: AllowSubject.
 RSpec/MultipleMemoizedHelpers:
   Max: 14
 
-# Offense count: 337
-# Configuration parameters: IgnoreSharedExamples.
+# Offense count: 417
+# Configuration parameters: EnforcedStyle, IgnoreSharedExamples.
+# SupportedStyles: always, named_only
 RSpec/NamedSubject:
   Enabled: false
 
-# Offense count: 40
+# Offense count: 57
+# Configuration parameters: AllowedGroups.
 RSpec/NestedGroups:
   Max: 5
 
+# Offense count: 5
+# Configuration parameters: AllowedPatterns.
+# AllowedPatterns: ^expect_, ^assert_
+RSpec/NoExpectationExample:
+  Exclude:
+    - 'spec/helpers/blacklight/configuration_helper_behavior_spec.rb'
+    - 'spec/helpers/blacklight/render_partials_helper_behavior_spec.rb'
+    - 'spec/helpers/blacklight_helper_spec.rb'
+    - 'spec/lib/tasks/blacklight_task_spec.rb'
+    - 'spec/views/catalog/facet.html.erb_spec.rb'
+
+# Offense count: 3
+RSpec/PendingWithoutReason:
+  Exclude:
+    - 'spec/components/blacklight/facet_item_pivot_component_spec.rb'
+    - 'spec/helpers/blacklight/search_history_constraints_helper_behavior_spec.rb'
+    - 'spec/i18n_spec.rb'
+
+# Offense count: 84
+# This cop supports unsafe autocorrection (--autocorrect-all).
+RSpec/ReceiveMessages:
+  Enabled: false
+
 # Offense count: 11
 RSpec/RepeatedDescription:
   Exclude:
@@ -411,23 +520,55 @@ RSpec/RepeatedExampleGroupDescription:
     - 'spec/services/blacklight/search_service_spec.rb'
 
 # Offense count: 4
-# Cop supports --auto-correct.
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: AutoCorrect.
 RSpec/ScatteredLet:
   Exclude:
     - 'spec/helpers/catalog_helper_spec.rb'
     - 'spec/models/blacklight/solr/search_builder_spec.rb'
     - 'spec/views/catalog/index.atom.builder_spec.rb'
 
-# Offense count: 13
+# Offense count: 5
+# Configuration parameters: Include, CustomTransform, IgnoreMethods, IgnoreMetadata.
+# Include: **/*_spec.rb
+RSpec/SpecFilePathFormat:
+  Exclude:
+    - 'spec/controllers/blacklight/catalog/component_configuration_spec.rb'
+    - 'spec/helpers/blacklight/hash_as_hidden_fields_behavior_spec.rb'
+    - 'spec/models/blacklight/solr/search_builder_spec.rb'
+    - 'spec/presenters/pipeline_spec.rb'
+    - 'spec/presenters/thumbnail_presenter_spec.rb'
+
+# Offense count: 24
+RSpec/StubbedMock:
+  Exclude:
+    - 'spec/controllers/catalog_controller_spec.rb'
+    - 'spec/helpers/blacklight/configuration_helper_behavior_spec.rb'
+    - 'spec/helpers/blacklight/facets_helper_behavior_spec.rb'
+    - 'spec/helpers/blacklight/render_constraints_helper_behavior_spec.rb'
+    - 'spec/helpers/blacklight/url_helper_behavior_spec.rb'
+    - 'spec/helpers/blacklight_helper_spec.rb'
+    - 'spec/helpers/catalog_helper_spec.rb'
+    - 'spec/models/blacklight/suggest_search_spec.rb'
+    - 'spec/presenters/blacklight/field_presenter_spec.rb'
+    - 'spec/presenters/thumbnail_presenter_spec.rb'
+
+# Offense count: 1
+RSpec/SubjectDeclaration:
+  Exclude:
+    - 'spec/models/blacklight/document/cache_key_spec.rb'
+
+# Offense count: 12
 RSpec/SubjectStub:
   Exclude:
     - 'spec/controllers/catalog_controller_spec.rb'
-    - 'spec/lib/blacklight/search_state_spec.rb'
     - 'spec/models/blacklight/document/cache_key_spec.rb'
     - 'spec/models/blacklight/search_builder_spec.rb'
+    - 'spec/presenters/blacklight/document_presenter_spec.rb'
+    - 'spec/presenters/blacklight/field_presenter_spec.rb'
     - 'spec/services/blacklight/search_service_spec.rb'
 
-# Offense count: 121
+# Offense count: 132
 # Configuration parameters: IgnoreNameless, IgnoreSymbolicNames.
 RSpec/VerifiedDoubles:
   Enabled: false
@@ -437,20 +578,22 @@ RSpec/VoidExpect:
   Exclude:
     - 'spec/lib/blacklight/configuration/facet_field_spec.rb'
 
-# Offense count: 8
-# Cop supports --auto-correct.
-Rails/ContentTag:
-  Exclude:
-    - 'app/components/blacklight/document_component.rb'
-    - 'app/components/blacklight/facet_item_pivot_component.rb'
-
 # Offense count: 4
-# Configuration parameters: EnforcedStyle.
+# This cop supports unsafe autocorrection (--autocorrect-all).
+# Configuration parameters: EnforcedStyle, AllowToTime.
 # SupportedStyles: strict, flexible
 Rails/Date:
   Exclude:
     - 'spec/models/search_spec.rb'
 
+# Offense count: 1
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: slashes, arguments
+Rails/FilePath:
+  Exclude:
+    - 'lib/blacklight/component.rb'
+
 # Offense count: 31
 # Configuration parameters: Include.
 # Include: app/helpers/**/*.rb
@@ -462,22 +605,35 @@ Rails/HelperInstanceVariable:
     - 'app/helpers/blacklight/facets_helper_behavior.rb'
     - 'app/helpers/blacklight/render_partials_helper_behavior.rb'
 
-# Offense count: 11
+# Offense count: 2
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: numeric, symbolic
+Rails/HttpStatus:
+  Exclude:
+    - 'app/controllers/concerns/blacklight/bookmarks.rb'
+
+# Offense count: 2
 Rails/OutputSafety:
   Exclude:
-    - 'app/helpers/blacklight/catalog_helper_behavior.rb'
-    - 'app/helpers/blacklight/configuration_helper_behavior.rb'
     - 'app/helpers/blacklight/icon_helper_behavior.rb'
-    - 'app/helpers/blacklight/url_helper_behavior.rb'
     - 'app/presenters/blacklight/rendering/join.rb'
 
-# Offense count: 13
+# Offense count: 14
 Security/Eval:
   Exclude:
     - 'spec/models/blacklight/solr/response_spec.rb'
 
+# Offense count: 2
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: separated, grouped
+Style/AccessorGrouping:
+  Exclude:
+    - 'lib/blacklight/search_state.rb'
+
 # Offense count: 9
-# Cop supports --auto-correct.
+# This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: prefer_alias, prefer_alias_method
 Style/Alias:
@@ -490,44 +646,46 @@ Style/Alias:
     - 'lib/blacklight/solr/response/group_response.rb'
 
 # Offense count: 3
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, ProceduralMethods, FunctionalMethods, IgnoredMethods, AllowBracesOnProceduralOneLiners, BracesRequiredMethods.
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: EnforcedStyle, ProceduralMethods, FunctionalMethods, AllowedMethods, AllowedPatterns, AllowBracesOnProceduralOneLiners, BracesRequiredMethods.
 # SupportedStyles: line_count_based, semantic, braces_for_chaining, always_braces
 # ProceduralMethods: benchmark, bm, bmbm, create, each_with_object, measure, new, realtime, tap, with_object
 # FunctionalMethods: let, let!, subject, watch
-# IgnoredMethods: lambda, proc, it
+# AllowedMethods: lambda, proc, it
 Style/BlockDelimiters:
   Exclude:
     - 'app/views/catalog/index.rss.builder'
     - 'app/views/catalog/opensearch.xml.builder'
 
-# Offense count: 51
-# Cop supports --auto-correct.
+# Offense count: 56
+# This cop supports unsafe autocorrection (--autocorrect-all).
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: nested, compact
 Style/ClassAndModuleChildren:
   Enabled: false
 
 # Offense count: 6
+# This cop supports unsafe autocorrection (--autocorrect-all).
 Style/CommentedKeyword:
   Exclude:
     - 'spec/controllers/catalog_controller_spec.rb'
     - 'spec/services/blacklight/search_service_spec.rb'
 
 # Offense count: 1
-# Cop supports --auto-correct.
+# This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: EnforcedStyle, SingleLineConditionsOnly, IncludeTernaryExpressions.
 # SupportedStyles: assign_to_condition, assign_inside_condition
 Style/ConditionalAssignment:
   Exclude:
     - 'lib/blacklight/solr/response/spelling.rb'
 
-# Offense count: 105
+# Offense count: 127
+# Configuration parameters: AllowedConstants.
 Style/Documentation:
   Enabled: false
 
 # Offense count: 10
-# Cop supports --auto-correct.
+# This cop supports safe autocorrection (--autocorrect).
 Style/ExpandPathArguments:
   Exclude:
     - 'Gemfile'
@@ -541,15 +699,23 @@ Style/ExpandPathArguments:
     - 'lib/generators/blacklight/test_support_generator.rb'
     - 'lib/generators/blacklight/user_generator.rb'
 
-# Offense count: 16
-# Configuration parameters: EnforcedStyle.
+# Offense count: 1
+# This cop supports safe autocorrection (--autocorrect).
+Style/ExplicitBlockArgument:
+  Exclude:
+    - 'tasks/blacklight.rake'
+
+# Offense count: 17
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: MaxUnannotatedPlaceholdersAllowed, AllowedMethods, AllowedPatterns.
 # SupportedStyles: annotated, template, unannotated
+# AllowedMethods: redirect
 Style/FormatStringToken:
-  Exclude:
-    - 'app/helpers/blacklight/render_partials_helper_behavior.rb'
+  EnforcedStyle: template
 
-# Offense count: 8
-# Configuration parameters: MinBodyLength.
+# Offense count: 7
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: MinBodyLength, AllowConsecutiveConditionals.
 Style/GuardClause:
   Exclude:
     - 'app/controllers/concerns/blacklight/bookmarks.rb'
@@ -558,13 +724,40 @@ Style/GuardClause:
     - 'app/helpers/blacklight/catalog_helper_behavior.rb'
     - 'lib/blacklight/solr/search_builder_behavior.rb'
 
-# Offense count: 39
-# Cop supports --auto-correct.
+# Offense count: 1
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: braces, no_braces
+Style/HashAsLastArrayItem:
+  Exclude:
+    - 'spec/models/blacklight/solr/search_builder_spec.rb'
+
+# Offense count: 8
+# This cop supports unsafe autocorrection (--autocorrect-all).
+# Configuration parameters: AllowedReceivers.
+# AllowedReceivers: Thread.current
+Style/HashEachMethods:
+  Exclude:
+    - 'app/components/blacklight/advanced_search_form_component.rb'
+    - 'spec/controllers/catalog_controller_spec.rb'
+    - 'spec/models/blacklight/solr/response_spec.rb'
+    - 'spec/services/blacklight/search_service_spec.rb'
+
+# Offense count: 38
+# This cop supports safe autocorrection (--autocorrect).
 Style/IfUnlessModifier:
   Enabled: false
 
-# Offense count: 5
-# Cop supports --auto-correct.
+# Offense count: 4
+# This cop supports safe autocorrection (--autocorrect).
+Style/KeywordParametersOrder:
+  Exclude:
+    - 'app/components/blacklight/document/thumbnail_component.rb'
+    - 'app/components/blacklight/response/view_type_component.rb'
+    - 'app/components/blacklight/system/flash_message_component.rb'
+
+# Offense count: 6
+# This cop supports safe autocorrection (--autocorrect).
 Style/MultilineIfModifier:
   Exclude:
     - 'app/views/catalog/index.atom.builder'
@@ -572,12 +765,14 @@ Style/MultilineIfModifier:
     - 'lib/blacklight/solr/search_builder_behavior.rb'
 
 # Offense count: 1
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: AllowMethodComparison, ComparisonsThreshold.
 Style/MultipleComparison:
   Exclude:
     - 'lib/blacklight/configuration/context.rb'
 
 # Offense count: 2
-# Cop supports --auto-correct.
+# This cop supports unsafe autocorrection (--autocorrect-all).
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: literals, strict
 Style/MutableConstant:
@@ -585,12 +780,11 @@ Style/MutableConstant:
     - 'lib/blacklight/solr/request.rb'
 
 # Offense count: 9
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, IgnoredMethods.
+# This cop supports unsafe autocorrection (--autocorrect-all).
+# Configuration parameters: EnforcedStyle, AllowedMethods, AllowedPatterns.
 # SupportedStyles: predicate, comparison
 Style/NumericPredicate:
   Exclude:
-    - 'spec/**/*'
     - 'app/helpers/blacklight/catalog_helper_behavior.rb'
     - 'app/services/blacklight/search_service.rb'
     - 'lib/blacklight/search_builder.rb'
@@ -600,22 +794,43 @@ Style/NumericPredicate:
     - 'lib/railties/blacklight.rake'
 
 # Offense count: 3
-# Cop supports --auto-correct.
+# This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: AllowSafeAssignment, AllowInMultilineConditions.
 Style/ParenthesesAroundCondition:
   Exclude:
     - 'app/views/catalog/_document.atom.builder'
 
 # Offense count: 3
-# Cop supports --auto-correct.
+# This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: PreferredDelimiters.
 Style/PercentLiteralDelimiters:
   Exclude:
     - 'lib/blacklight/engine.rb'
     - 'lib/blacklight/solr/request.rb'
 
+# Offense count: 2
+# This cop supports safe autocorrection (--autocorrect).
+Style/RedundantBegin:
+  Exclude:
+    - 'lib/blacklight.rb'
+    - 'lib/blacklight/configuration.rb'
+
+# Offense count: 1
+# This cop supports safe autocorrection (--autocorrect).
+Style/RedundantParentheses:
+  Exclude:
+    - 'app/views/catalog/_document.atom.builder'
+
+# Offense count: 2
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: AllowMultipleReturnValues.
+Style/RedundantReturn:
+  Exclude:
+    - 'app/models/concerns/blacklight/document/email.rb'
+    - 'app/models/concerns/blacklight/document/sms.rb'
+
 # Offense count: 7
-# Cop supports --auto-correct.
+# This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: implicit, explicit
 Style/RescueStandardError:
@@ -625,9 +840,9 @@ Style/RescueStandardError:
     - 'lib/blacklight/configuration/fields.rb'
     - 'lib/railties/blacklight.rake'
 
-# Offense count: 12
-# Cop supports --auto-correct.
-# Configuration parameters: ConvertCodeThatCanStartToReturnNil, AllowedMethods.
+# Offense count: 11
+# This cop supports unsafe autocorrection (--autocorrect-all).
+# Configuration parameters: ConvertCodeThatCanStartToReturnNil, AllowedMethods, MaxChainLength.
 # AllowedMethods: present?, blank?, presence, try, try!
 Style/SafeNavigation:
   Exclude:
@@ -637,19 +852,40 @@ Style/SafeNavigation:
     - 'lib/blacklight.rb'
     - 'lib/blacklight/configuration/facet_field.rb'
     - 'lib/blacklight/configuration/search_field.rb'
-    - 'lib/blacklight/search_state.rb'
     - 'lib/blacklight/solr/search_builder_behavior.rb'
 
-# Offense count: 3
-# Cop supports --auto-correct.
+# Offense count: 6
+# This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: AllowAsExpressionSeparator.
 Style/Semicolon:
   Exclude:
     - 'spec/models/blacklight/solr/repository_spec.rb'
     - 'spec/views/catalog/_paginate_compact.html.erb_spec.rb'
 
-# Offense count: 31
-# Cop supports --auto-correct.
+# Offense count: 1
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: AllowModifier.
+Style/SoleNestedConditional:
+  Exclude:
+    - 'app/controllers/concerns/blacklight/controller.rb'
+
+# Offense count: 12
+# This cop supports unsafe autocorrection (--autocorrect-all).
+# Configuration parameters: Mode.
+Style/StringConcatenation:
+  Exclude:
+    - 'app/helpers/blacklight/blacklight_helper_behavior.rb'
+    - 'app/helpers/blacklight/render_constraints_helper_behavior.rb'
+    - 'lib/blacklight/configuration/fields.rb'
+    - 'lib/blacklight/solr/search_builder_behavior.rb'
+    - 'lib/railties/blacklight.rake'
+    - 'spec/features/search_results_spec.rb'
+    - 'spec/helpers/blacklight/url_helper_behavior_spec.rb'
+    - 'spec/models/blacklight/solr/response_spec.rb'
+    - 'spec/routing/catalog_routing_spec.rb'
+
+# Offense count: 42
+# This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: MinSize.
 # SupportedStyles: percent, brackets
 Style/SymbolArray: