blacklight 7.36.2 → 8.0.0.beta1
Sign up to get free protection for your applications and to get access to all the features.
- checksums.yaml +4 -4
- data/.env +2 -3
- data/.github/workflows/ruby.yml +33 -133
- data/.rubocop.yml +241 -2
- data/.rubocop_todo.yml +214 -270
- data/Gemfile +7 -10
- data/README.md +11 -3
- data/VERSION +1 -1
- data/app/assets/javascripts/blacklight/blacklight.esm.js +384 -0
- data/app/assets/javascripts/blacklight/blacklight.esm.js.map +1 -0
- data/app/assets/javascripts/blacklight/blacklight.js +374 -489
- data/app/assets/javascripts/blacklight/blacklight.js.map +1 -0
- data/app/assets/stylesheets/blacklight/_autocomplete.scss +25 -0
- data/app/assets/stylesheets/blacklight/_blacklight_base.scss +1 -1
- data/app/assets/stylesheets/blacklight/_bookmark.scss +16 -0
- data/app/assets/stylesheets/blacklight/_bootstrap_overrides.scss +8 -0
- data/app/assets/stylesheets/blacklight/_facets.scss +72 -44
- data/app/assets/stylesheets/blacklight/_header.scss +0 -15
- data/app/assets/stylesheets/blacklight/_icons.scss +0 -14
- data/app/assets/stylesheets/blacklight/_mixins.scss +20 -0
- data/app/assets/stylesheets/blacklight/_modal.scss +8 -2
- data/app/assets/stylesheets/blacklight/_search_form.scss +30 -3
- data/app/assets/stylesheets/blacklight/_search_history.scss +10 -1
- data/app/assets/stylesheets/blacklight/_search_results.scss +6 -2
- data/app/assets/stylesheets/blacklight/blacklight_defaults.scss +4 -1
- data/app/builders/blacklight/action_builder.rb +18 -9
- data/app/components/blacklight/advanced_search_form_component.html.erb +2 -2
- data/app/components/blacklight/advanced_search_form_component.rb +8 -10
- data/app/components/blacklight/constraints_component.rb +27 -37
- data/app/components/blacklight/document/action_component.rb +9 -9
- data/app/components/blacklight/document/actions_component.rb +2 -2
- data/app/components/blacklight/document/bookmark_component.html.erb +9 -0
- data/app/components/blacklight/document/bookmark_component.rb +4 -2
- data/app/components/blacklight/document/citation_component.rb +5 -3
- data/app/components/blacklight/document/group_component.rb +7 -3
- data/app/components/blacklight/document/sidebar_component.html.erb +2 -0
- data/app/components/blacklight/document/sidebar_component.rb +16 -0
- data/app/components/blacklight/document/thumbnail_component.html.erb +2 -7
- data/app/components/blacklight/document/thumbnail_component.rb +1 -9
- data/app/components/blacklight/document_component.html.erb +4 -0
- data/app/components/blacklight/document_component.rb +14 -53
- data/app/components/blacklight/document_metadata_component.html.erb +2 -4
- data/app/components/blacklight/document_metadata_component.rb +5 -10
- data/app/components/blacklight/document_title_component.rb +4 -1
- data/app/components/blacklight/facet_component.rb +1 -1
- data/app/components/blacklight/facet_field_checkboxes_component.html.erb +3 -3
- data/app/components/blacklight/facet_field_checkboxes_component.rb +1 -1
- data/app/components/blacklight/facet_field_component.html.erb +4 -4
- data/app/components/blacklight/facet_field_component.rb +9 -2
- data/app/components/blacklight/facet_field_list_component.html.erb +3 -3
- data/app/components/blacklight/facet_field_list_component.rb +37 -5
- data/app/components/blacklight/facet_field_no_layout_component.rb +0 -2
- data/app/components/blacklight/facet_item_component.rb +1 -43
- data/app/components/blacklight/facet_item_pivot_component.rb +21 -23
- data/app/components/blacklight/header_component.rb +1 -1
- data/app/components/blacklight/hidden_search_state_component.rb +1 -2
- data/app/components/blacklight/icons/legacy_icon_component.rb +30 -0
- data/app/components/blacklight/icons/list_component.rb +16 -0
- data/app/components/blacklight/icons/search_component.rb +16 -0
- data/app/components/blacklight/metadata_field_component.html.erb +2 -2
- data/app/components/blacklight/metadata_field_component.rb +24 -8
- data/app/components/blacklight/metadata_field_layout_component.rb +4 -25
- data/app/components/blacklight/response/facet_group_component.html.erb +3 -5
- data/app/components/blacklight/response/facet_group_component.rb +29 -8
- data/app/components/blacklight/response/pagination_component.html.erb +1 -1
- data/app/components/blacklight/response/pagination_component.rb +1 -5
- data/app/components/blacklight/response/sort_component.rb +1 -1
- data/app/components/blacklight/response/spellcheck_component.rb +17 -6
- data/app/components/blacklight/response/view_type_button_component.rb +2 -6
- data/app/components/blacklight/response/view_type_component.rb +3 -5
- data/app/components/blacklight/search/sidebar_component.html.erb +8 -0
- data/app/components/blacklight/search/sidebar_component.rb +17 -0
- data/app/components/blacklight/search_bar_component.html.erb +20 -15
- data/app/components/blacklight/search_bar_component.rb +2 -16
- data/app/components/blacklight/search_button_component.rb +3 -3
- data/app/components/blacklight/search_context_component.rb +43 -9
- data/app/components/blacklight/search_header_component.html.erb +2 -0
- data/app/components/blacklight/search_header_component.rb +6 -0
- data/app/components/blacklight/start_over_button_component.rb +5 -3
- data/app/components/blacklight/system/dropdown_component.rb +2 -2
- data/app/components/blacklight/system/flash_message_component.html.erb +3 -1
- data/app/components/blacklight/system/flash_message_component.rb +11 -2
- data/app/components/blacklight/system/modal_component.html.erb +1 -1
- data/app/components/blacklight/system/modal_component.rb +0 -2
- data/app/components/blacklight/top_navbar_component.html.erb +1 -1
- data/app/components/blacklight/top_navbar_component.rb +0 -4
- data/app/controllers/bookmarks_controller.rb +1 -0
- data/app/controllers/catalog_controller.rb +1 -0
- data/app/controllers/concerns/blacklight/bookmarks.rb +10 -9
- data/app/controllers/concerns/blacklight/catalog.rb +21 -83
- data/app/controllers/concerns/blacklight/controller.rb +3 -41
- data/app/controllers/concerns/blacklight/search_context.rb +25 -7
- data/app/controllers/concerns/blacklight/search_history.rb +2 -0
- data/app/controllers/concerns/blacklight/searchable.rb +12 -1
- data/app/controllers/concerns/blacklight/token_based_user.rb +13 -1
- data/app/controllers/search_history_controller.rb +1 -0
- data/app/helpers/blacklight/blacklight_helper_behavior.rb +12 -310
- data/app/helpers/blacklight/catalog_helper_behavior.rb +22 -137
- data/app/helpers/blacklight/component_helper_behavior.rb +2 -53
- data/app/helpers/blacklight/configuration_helper_behavior.rb +2 -117
- data/app/helpers/blacklight/facets_helper_behavior.rb +4 -321
- data/app/helpers/blacklight/icon_helper_behavior.rb +5 -4
- data/app/helpers/blacklight/layout_helper_behavior.rb +1 -0
- data/app/helpers/blacklight/render_partials_helper_behavior.rb +11 -31
- data/app/helpers/blacklight/url_helper_behavior.rb +13 -97
- data/app/helpers/blacklight_helper.rb +1 -0
- data/app/helpers/catalog_helper.rb +1 -0
- data/app/javascript/blacklight/bookmark_toggle.js +13 -19
- data/app/javascript/blacklight/button_focus.js +12 -10
- data/app/javascript/blacklight/checkbox_submit.js +68 -122
- data/app/javascript/blacklight/core.js +6 -5
- data/app/javascript/blacklight/index.js +13 -0
- data/app/javascript/blacklight/modal.js +99 -164
- data/app/javascript/blacklight/modalForm.js +60 -0
- data/app/javascript/blacklight/search_context.js +45 -55
- data/app/models/blacklight/facet_paginator.rb +3 -2
- data/app/models/blacklight/icon.rb +4 -2
- data/app/models/bookmark.rb +0 -2
- data/app/models/concerns/blacklight/configurable.rb +5 -4
- data/app/models/concerns/blacklight/document/active_model_shim.rb +1 -10
- data/app/models/concerns/blacklight/document/cache_key.rb +1 -0
- data/app/models/concerns/blacklight/document/dublin_core.rb +2 -1
- data/app/models/concerns/blacklight/document/email.rb +1 -0
- data/app/models/concerns/blacklight/document/export.rb +2 -1
- data/app/models/concerns/blacklight/document/extensions.rb +1 -0
- data/app/models/concerns/blacklight/document/schema_org.rb +1 -0
- data/app/models/concerns/blacklight/document/semantic_fields.rb +1 -0
- data/app/models/concerns/blacklight/document/sms.rb +1 -0
- data/app/models/concerns/blacklight/suggest/response.rb +1 -0
- data/app/models/concerns/blacklight/user.rb +17 -8
- data/app/models/record_mailer.rb +13 -12
- data/app/models/search.rb +1 -7
- data/app/models/solr_document.rb +1 -0
- data/app/presenters/blacklight/clause_presenter.rb +1 -1
- data/app/presenters/blacklight/document_presenter.rb +13 -21
- data/app/presenters/blacklight/facet_field_presenter.rb +39 -14
- data/app/presenters/blacklight/facet_grouped_item_presenter.rb +1 -5
- data/app/presenters/blacklight/facet_item_pivot_presenter.rb +60 -0
- data/app/presenters/blacklight/facet_item_presenter.rb +3 -9
- data/app/presenters/blacklight/field_presenter.rb +1 -0
- data/app/presenters/blacklight/index_presenter.rb +2 -40
- data/app/presenters/blacklight/json_presenter.rb +7 -5
- data/app/presenters/blacklight/rendering/link_to_facet.rb +2 -5
- data/app/presenters/blacklight/show_presenter.rb +1 -9
- data/app/presenters/blacklight/thumbnail_presenter.rb +1 -1
- data/app/services/blacklight/bookmarks_search_builder.rb +22 -0
- data/app/services/blacklight/field_retriever.rb +12 -21
- data/app/services/blacklight/search_service.rb +8 -7
- data/app/values/blacklight/types.rb +0 -4
- data/app/views/bookmarks/_clear_bookmarks_widget.html.erb +8 -1
- data/app/views/bookmarks/_tools.html.erb +7 -12
- data/app/views/catalog/_advanced_search_form.html.erb +0 -1
- data/app/views/catalog/_bookmark_control.html.erb +1 -1
- data/app/views/catalog/_citation.html.erb +1 -1
- data/app/views/catalog/_constraints.html.erb +1 -14
- data/app/views/catalog/_document.atom.builder +12 -14
- data/app/views/catalog/_document.html.erb +5 -3
- data/app/views/catalog/_document.rss.builder +2 -4
- data/app/views/catalog/_facet_layout.html.erb +2 -2
- data/app/views/catalog/_facets.html.erb +5 -4
- data/app/views/catalog/_home_text.html.erb +2 -14
- data/app/views/catalog/_search_form.html.erb +2 -2
- data/app/views/catalog/_search_header.html.erb +1 -2
- data/app/views/catalog/_search_results.html.erb +2 -2
- data/app/views/catalog/_search_sidebar.html.erb +5 -1
- data/app/views/catalog/_show_main_content.html.erb +11 -16
- data/app/views/catalog/_show_sidebar.html.erb +2 -2
- data/app/views/catalog/_show_tools.html.erb +8 -14
- data/app/views/catalog/_view_type_group.html.erb +1 -1
- data/app/views/catalog/email.html.erb +2 -2
- data/app/views/catalog/email_success.html.erb +5 -6
- data/app/views/catalog/facet.html.erb +7 -5
- data/app/views/catalog/index.atom.builder +12 -14
- data/app/views/catalog/index.html.erb +4 -1
- data/app/views/catalog/index.json.jbuilder +19 -19
- data/app/views/catalog/index.rss.builder +1 -1
- data/app/views/catalog/opensearch.xml.builder +1 -1
- data/app/views/catalog/sms.html.erb +2 -2
- data/app/views/catalog/sms_success.html.erb +5 -6
- data/app/views/catalog/suggest.html.erb +3 -0
- data/app/views/layouts/blacklight/base.html.erb +13 -2
- data/app/views/search_history/index.html.erb +6 -2
- data/app/views/shared/_modal.html.erb +3 -3
- data/blacklight.gemspec +8 -9
- data/config/importmap.rb +3 -0
- data/config/locales/blacklight.ar.yml +0 -1
- data/config/locales/blacklight.ca.yml +0 -1
- data/config/locales/blacklight.de.yml +0 -1
- data/config/locales/blacklight.en.yml +0 -2
- data/config/locales/blacklight.es.yml +0 -1
- data/config/locales/blacklight.fr.yml +0 -1
- data/config/locales/blacklight.hu.yml +0 -1
- data/config/locales/blacklight.it.yml +0 -1
- data/config/locales/blacklight.nl.yml +0 -1
- data/config/locales/blacklight.pt-BR.yml +0 -1
- data/config/locales/blacklight.sq.yml +0 -1
- data/config/locales/blacklight.zh.yml +0 -1
- data/config/routes.rb +3 -2
- data/db/migrate/20140202020201_create_searches.rb +1 -0
- data/db/migrate/20140202020202_create_bookmarks.rb +1 -0
- data/db/migrate/20140320000000_add_polymorphic_type_to_bookmarks.rb +1 -0
- data/docker-compose.yml +0 -1
- data/lib/blacklight/abstract_repository.rb +1 -0
- data/lib/blacklight/configuration/context.rb +4 -4
- data/lib/blacklight/configuration/display_field.rb +7 -9
- data/lib/blacklight/configuration/facet_field.rb +17 -11
- data/lib/blacklight/configuration/field.rb +1 -0
- data/lib/blacklight/configuration/fields.rb +12 -15
- data/lib/blacklight/configuration/index_field.rb +1 -0
- data/lib/blacklight/configuration/null_display_field.rb +17 -0
- data/lib/blacklight/configuration/search_field.rb +1 -0
- data/lib/blacklight/configuration/show_field.rb +1 -0
- data/lib/blacklight/configuration/sort_field.rb +1 -0
- data/lib/blacklight/configuration/tool_config.rb +1 -0
- data/lib/blacklight/configuration/view_config.rb +16 -6
- data/lib/blacklight/configuration.rb +294 -358
- data/lib/blacklight/engine.rb +8 -24
- data/lib/blacklight/exceptions.rb +2 -2
- data/lib/blacklight/nested_open_struct_with_hash_access.rb +6 -12
- data/lib/blacklight/open_struct_with_hash_access.rb +19 -17
- data/lib/blacklight/parameters.rb +7 -21
- data/lib/blacklight/routes/exportable.rb +1 -0
- data/lib/blacklight/routes/searchable.rb +2 -1
- data/lib/blacklight/routes.rb +1 -0
- data/lib/blacklight/search_builder.rb +10 -10
- data/lib/blacklight/search_state/filter_field.rb +8 -25
- data/lib/blacklight/search_state/pivot_filter_field.rb +144 -0
- data/lib/blacklight/search_state.rb +23 -79
- data/lib/blacklight/solr/document.rb +1 -0
- data/lib/blacklight/solr/facet_paginator.rb +1 -0
- data/lib/blacklight/solr/repository.rb +3 -14
- data/lib/blacklight/solr/request.rb +1 -0
- data/lib/blacklight/solr/response/facets.rb +21 -5
- data/lib/blacklight/solr/response/group.rb +1 -0
- data/lib/blacklight/solr/response/group_response.rb +1 -0
- data/lib/blacklight/solr/response/more_like_this.rb +1 -0
- data/lib/blacklight/solr/response/pagination_methods.rb +4 -3
- data/lib/blacklight/solr/response/params.rb +5 -4
- data/lib/blacklight/solr/response/response.rb +1 -0
- data/lib/blacklight/solr/response/spelling.rb +1 -0
- data/lib/blacklight/solr/response.rb +4 -3
- data/lib/blacklight/solr/search_builder_behavior.rb +17 -34
- data/lib/blacklight/solr.rb +1 -0
- data/lib/blacklight/version.rb +1 -0
- data/lib/blacklight.rb +7 -10
- data/lib/generators/blacklight/assets/importmap_generator.rb +55 -0
- data/lib/generators/blacklight/assets/propshaft_generator.rb +25 -0
- data/lib/generators/blacklight/assets/sprockets_generator.rb +66 -0
- data/lib/generators/blacklight/assets_generator.rb +13 -89
- data/lib/generators/blacklight/controller_generator.rb +3 -2
- data/lib/generators/blacklight/document_generator.rb +1 -0
- data/lib/generators/blacklight/install_generator.rb +4 -3
- data/lib/generators/blacklight/models_generator.rb +1 -0
- data/lib/generators/blacklight/search_builder_generator.rb +1 -0
- data/lib/generators/blacklight/solr_generator.rb +1 -1
- data/lib/generators/blacklight/templates/catalog_controller.rb +34 -8
- data/lib/generators/blacklight/templates/solr/conf/solrconfig.xml +0 -69
- data/lib/generators/blacklight/test_support_generator.rb +4 -2
- data/lib/generators/blacklight/user_generator.rb +7 -9
- data/lib/railties/blacklight.rake +6 -7
- data/package.json +10 -13
- data/rollup.config.js +27 -0
- data/spec/components/blacklight/constraints_component_spec.rb +17 -13
- data/spec/components/blacklight/document_component_spec.rb +23 -82
- data/spec/components/blacklight/facet_component_spec.rb +3 -18
- data/spec/components/blacklight/facet_field_checkboxes_component_spec.rb +1 -2
- data/spec/components/blacklight/facet_field_list_component_spec.rb +7 -6
- data/spec/components/blacklight/facet_item_pivot_component_spec.rb +10 -9
- data/spec/components/blacklight/response/view_type_component_spec.rb +66 -0
- data/spec/components/blacklight/search_bar_component_spec.rb +1 -1
- data/spec/components/blacklight/search_context_component_spec.rb +40 -0
- data/spec/controllers/blacklight/catalog/component_configuration_spec.rb +1 -6
- data/spec/controllers/blacklight/{base_spec.rb → catalog_spec.rb} +2 -2
- data/spec/controllers/bookmarks_controller_spec.rb +2 -3
- data/spec/controllers/catalog_controller_spec.rb +13 -135
- data/spec/features/advanced_search_spec.rb +0 -56
- data/spec/features/autocomplete_spec.rb +1 -1
- data/spec/features/axe_spec.rb +1 -6
- data/spec/features/bookmarks_spec.rb +1 -1
- data/spec/features/facets_spec.rb +1 -1
- data/spec/features/search_context_spec.rb +4 -10
- data/spec/features/search_results_spec.rb +0 -33
- data/spec/features/sitelinks_search_box.rb +13 -0
- data/spec/helpers/blacklight/configuration_helper_behavior_spec.rb +2 -138
- data/spec/helpers/blacklight/facets_helper_behavior_spec.rb +0 -387
- data/spec/helpers/blacklight/icon_helper_behavior_spec.rb +8 -0
- data/spec/helpers/blacklight/render_partials_helper_behavior_spec.rb +5 -7
- data/spec/helpers/blacklight/url_helper_behavior_spec.rb +9 -131
- data/spec/helpers/blacklight_helper_spec.rb +8 -252
- data/spec/helpers/catalog_helper_spec.rb +7 -118
- data/spec/i18n_spec.rb +1 -0
- data/spec/integration/generators/blacklight/solr_generator_spec.rb +1 -1
- data/spec/lib/blacklight/configuration/facet_field_spec.rb +27 -16
- data/spec/lib/blacklight/configuration/field_spec.rb +1 -1
- data/spec/lib/blacklight/configuration/view_config_spec.rb +1 -1
- data/spec/lib/blacklight/open_struct_with_hash_access_spec.rb +2 -2
- data/spec/lib/blacklight/parameters_spec.rb +1 -4
- data/spec/lib/blacklight/search_state/filter_field_spec.rb +4 -4
- data/spec/lib/blacklight/search_state/pivot_filter_field_spec.rb +117 -0
- data/spec/lib/blacklight/search_state_spec.rb +80 -198
- data/spec/lib/tasks/blacklight_task_spec.rb +1 -0
- data/spec/models/blacklight/configuration_spec.rb +17 -51
- data/spec/models/blacklight/document/active_model_shim_spec.rb +2 -2
- data/spec/models/blacklight/icon_spec.rb +31 -15
- data/spec/models/blacklight/search_builder_spec.rb +9 -9
- data/spec/models/blacklight/solr/document_spec.rb +3 -3
- data/spec/models/blacklight/solr/repository_spec.rb +0 -27
- data/spec/models/blacklight/solr/response/facets_spec.rb +27 -27
- data/spec/models/blacklight/solr/response/group_response_spec.rb +1 -0
- data/spec/models/blacklight/solr/response/group_spec.rb +1 -0
- data/spec/models/blacklight/solr/response_spec.rb +9 -2
- data/spec/models/blacklight/solr/search_builder_spec.rb +24 -31
- data/spec/models/blacklight/user_spec.rb +22 -0
- data/spec/presenters/blacklight/clause_presenter_spec.rb +1 -0
- data/spec/presenters/blacklight/document_presenter_spec.rb +2 -2
- data/spec/presenters/blacklight/facet_field_presenter_spec.rb +85 -12
- data/spec/presenters/blacklight/facet_grouped_item_presenter_spec.rb +1 -0
- data/spec/presenters/blacklight/facet_item_presenter_spec.rb +14 -13
- data/spec/presenters/blacklight/field_presenter_spec.rb +0 -14
- data/spec/presenters/blacklight/index_presenter_spec.rb +2 -4
- data/spec/presenters/blacklight/json_presenter_spec.rb +1 -0
- data/spec/presenters/blacklight/link_alternate_presenter_spec.rb +3 -2
- data/spec/presenters/blacklight/show_presenter_spec.rb +20 -29
- data/spec/presenters/thumbnail_presenter_spec.rb +1 -1
- data/spec/requests/load_suggestions_spec.rb +16 -0
- data/spec/routing/catalog_routing_spec.rb +2 -1
- data/spec/services/blacklight/search_service_spec.rb +31 -68
- data/spec/spec_helper.rb +6 -32
- data/spec/support/controller_level_helpers.rb +1 -2
- data/spec/support/features/search_helpers.rb +39 -0
- data/spec/support/features/session_helpers.rb +1 -0
- data/spec/support/features.rb +3 -0
- data/spec/support/view_component_capybara_test_helpers.rb +8 -0
- data/spec/test_app_templates/lib/generators/test_app_generator.rb +9 -2
- data/spec/views/catalog/_document.html.erb_spec.rb +3 -34
- data/spec/views/catalog/_facet_index_navigation.html.erb_spec.rb +1 -1
- data/spec/views/catalog/_search_header.erb_spec.rb +1 -0
- data/spec/views/catalog/_show_sidebar.erb_spec.rb +1 -0
- data/spec/views/catalog/_show_tools.html.erb_spec.rb +5 -66
- data/spec/views/catalog/_view_type_group.html.erb_spec.rb +17 -9
- data/spec/views/catalog/email_success.html.erb_spec.rb +2 -2
- data/spec/views/catalog/facet.html.erb_spec.rb +6 -3
- data/spec/views/catalog/index.atom.builder_spec.rb +18 -11
- data/spec/views/catalog/index.html.erb_spec.rb +5 -6
- data/spec/views/catalog/index.json.jbuilder_spec.rb +2 -2
- data/spec/views/catalog/show.html.erb_spec.rb +3 -25
- data/spec/views/catalog/sms_success.html.erb_spec.rb +2 -2
- data/tasks/blacklight.rake +6 -4
- metadata +81 -134
- data/.babelrc +0 -11
- data/app/assets/images/blacklight/list.svg +0 -1
- data/app/assets/images/blacklight/search.svg +0 -1
- data/app/assets/stylesheets/blacklight/_twitter_typeahead.scss +0 -37
- data/app/components/blacklight/content_areas_shim.rb +0 -13
- data/app/controllers/concerns/blacklight/base.rb +0 -12
- data/app/controllers/concerns/blacklight/default_component_configuration.rb +0 -64
- data/app/controllers/concerns/blacklight/facet.rb +0 -69
- data/app/controllers/concerns/blacklight/search_fields.rb +0 -46
- data/app/helpers/blacklight/hash_as_hidden_fields_helper_behavior.rb +0 -27
- data/app/helpers/blacklight/render_constraints_helper_behavior.rb +0 -188
- data/app/helpers/blacklight/search_history_constraints_helper_behavior.rb +0 -97
- data/app/helpers/blacklight/suggest_helper_behavior.rb +0 -13
- data/app/javascript/blacklight/autocomplete.js +0 -36
- data/app/javascript/blacklight/facet_load.js +0 -22
- data/app/presenters/blacklight/search_bar_presenter.rb +0 -47
- data/app/views/catalog/_constraints_element.html.erb +0 -14
- data/app/views/catalog/_document_action.html.erb +0 -5
- data/app/views/catalog/_facet_group.html.erb +0 -5
- data/app/views/catalog/_facet_limit.html.erb +0 -3
- data/app/views/catalog/_index.html.erb +0 -1
- data/app/views/catalog/_index_header.html.erb +0 -22
- data/app/views/catalog/_previous_next_doc.html.erb +0 -2
- data/app/views/catalog/_show.html.erb +0 -6
- data/app/views/catalog/_show_header.html.erb +0 -2
- data/app/views/catalog/_thumbnail.html.erb +0 -1
- data/lib/blacklight/deprecations/engine_configuration.rb +0 -66
- data/lib/blacklight/deprecations/search_state_normalization.rb +0 -52
- data/spec/components/blacklight/header_component_spec.rb +0 -20
- data/spec/controllers/blacklight/facet_spec.rb +0 -33
- data/spec/controllers/blacklight/search_fields_spec.rb +0 -62
- data/spec/features/citation_spec.rb +0 -10
- data/spec/features/sitelinks_search_box_spec.rb +0 -13
- data/spec/features/sms_spec.rb +0 -12
- data/spec/helpers/blacklight/hash_as_hidden_fields_behavior_spec.rb +0 -26
- data/spec/helpers/blacklight/render_constraints_helper_behavior_spec.rb +0 -92
- data/spec/helpers/blacklight/search_history_constraints_helper_behavior_spec.rb +0 -101
- data/spec/helpers/blacklight/suggest_helper_behavior_spec.rb +0 -48
- data/spec/lib/blacklight/engine_spec.rb +0 -41
- data/spec/presenters/blacklight/search_bar_presenter_spec.rb +0 -94
- data/spec/services/blacklight/field_retriever_spec.rb +0 -17
- data/spec/support/view_component_test_helpers.rb +0 -35
- data/spec/views/catalog/_constraints.html.erb_spec.rb +0 -33
- data/spec/views/catalog/_facet_group.html.erb_spec.rb +0 -84
- data/spec/views/catalog/_facets.html.erb_spec.rb +0 -15
- data/spec/views/catalog/_index.html.erb_spec.rb +0 -62
- data/spec/views/catalog/_index_header.html.erb_spec.rb +0 -35
- data/spec/views/catalog/_previous_next_doc.html.erb_spec.rb +0 -22
- data/spec/views/catalog/_show.html.erb_spec.rb +0 -62
- data/spec/views/catalog/_thumbnail.html.erb_spec.rb +0 -38
@@ -234,50 +234,50 @@ RSpec.describe Blacklight::SearchBuilder, api: true do
|
|
234
234
|
|
235
235
|
describe "#params_changed?" do
|
236
236
|
it "is false" do
|
237
|
-
expect(subject.send(:params_changed?)).to
|
237
|
+
expect(subject.send(:params_changed?)).to be false
|
238
238
|
end
|
239
239
|
|
240
240
|
it "is marked as changed when with() changes" do
|
241
241
|
subject.with(a: 1)
|
242
|
-
expect(subject.send(:params_changed?)).to
|
242
|
+
expect(subject.send(:params_changed?)).to be true
|
243
243
|
end
|
244
244
|
|
245
245
|
it "is marked as changed when where() changes" do
|
246
246
|
subject.where(a: 1)
|
247
|
-
expect(subject.send(:params_changed?)).to
|
247
|
+
expect(subject.send(:params_changed?)).to be true
|
248
248
|
end
|
249
249
|
|
250
250
|
it "is marked as changed when the processor chain changes" do
|
251
251
|
subject.append(:a)
|
252
|
-
expect(subject.send(:params_changed?)).to
|
252
|
+
expect(subject.send(:params_changed?)).to be true
|
253
253
|
end
|
254
254
|
|
255
255
|
it "is marked as changed when merged parameters are added" do
|
256
256
|
subject.merge(a: 1)
|
257
|
-
expect(subject.send(:params_changed?)).to
|
257
|
+
expect(subject.send(:params_changed?)).to be true
|
258
258
|
end
|
259
259
|
|
260
260
|
it "is marked as changed when reverse merged parameters are added" do
|
261
261
|
subject.reverse_merge(a: 1)
|
262
|
-
expect(subject.send(:params_changed?)).to
|
262
|
+
expect(subject.send(:params_changed?)).to be true
|
263
263
|
end
|
264
264
|
|
265
265
|
it "is marked as changed when pagination changes" do
|
266
266
|
expect(subject).to receive(:page=).with(1).and_call_original
|
267
267
|
subject.page(1)
|
268
|
-
expect(subject.send(:params_changed?)).to
|
268
|
+
expect(subject.send(:params_changed?)).to be true
|
269
269
|
end
|
270
270
|
|
271
271
|
it "is marked as changed when rows changes" do
|
272
272
|
expect(subject).to receive(:rows=).with(1).and_call_original
|
273
273
|
subject.rows(1)
|
274
|
-
expect(subject.send(:params_changed?)).to
|
274
|
+
expect(subject.send(:params_changed?)).to be true
|
275
275
|
end
|
276
276
|
|
277
277
|
it "is marked as changed when start offset changes" do
|
278
278
|
expect(subject).to receive(:start=).with(1).and_call_original
|
279
279
|
subject.start(1)
|
280
|
-
expect(subject.send(:params_changed?)).to
|
280
|
+
expect(subject.send(:params_changed?)).to be true
|
281
281
|
end
|
282
282
|
end
|
283
283
|
end
|
@@ -21,9 +21,9 @@ RSpec.describe "Blacklight::Solr::Document", api: true do
|
|
21
21
|
it 'creates a doc with hashy methods' do
|
22
22
|
doc = SolrDocument.new('id' => 'SP2514N', 'inStock' => true, 'manu' => 'Samsung Electronics Co. Ltd.', 'name' => 'Samsung SpinPoint P120 SP2514N - hard drive - 250 GB - ATA-133', 'popularity' => 6, 'price' => 92.0, 'sku' => 'SP2514N', 'timestamp' => '2009-03-20T14:42:49.795Z', 'cat' => ['electronics', 'hard drive'], 'spell' => ['Samsung SpinPoint P120 SP2514N - hard drive - 250 GB - ATA-133'], 'features' => ['7200RPM, 8MB cache, IDE Ultra ATA-133', 'NoiseGuard, SilentSeek technology, Fluid Dynamic Bearing (FDB) motor'])
|
23
23
|
|
24
|
-
expect(doc.has?(:cat, /^elec/)).to
|
25
|
-
expect(doc.has?(:cat, 'elec')).not_to
|
26
|
-
expect(doc.has?(:cat, 'electronics')).to
|
24
|
+
expect(doc.has?(:cat, /^elec/)).to be true
|
25
|
+
expect(doc.has?(:cat, 'elec')).not_to be true
|
26
|
+
expect(doc.has?(:cat, 'electronics')).to be true
|
27
27
|
|
28
28
|
expect(doc.fetch(:cat)).to eq ['electronics', 'hard drive']
|
29
29
|
expect(doc.fetch(:xyz, nil)).to be_nil
|
@@ -153,33 +153,6 @@ RSpec.describe Blacklight::Solr::Repository, api: true do
|
|
153
153
|
expect(JSON.parse(actual_params[:data]).with_indifferent_access).to include(query: { bool: {} })
|
154
154
|
expect(actual_params[:headers]).to include({ 'Content-Type' => 'application/json' })
|
155
155
|
end
|
156
|
-
|
157
|
-
context "without a json solr path configured" do
|
158
|
-
before do
|
159
|
-
blacklight_config.json_solr_path = nil
|
160
|
-
end
|
161
|
-
|
162
|
-
it "uses the default solr path" do
|
163
|
-
blacklight_config.solr_path = 'xyz'
|
164
|
-
allow(subject.connection).to receive(:send_and_receive) do |path|
|
165
|
-
expect(path).to eq 'xyz'
|
166
|
-
end
|
167
|
-
subject.search(input_params)
|
168
|
-
end
|
169
|
-
end
|
170
|
-
|
171
|
-
context "with a json solr path configured" do
|
172
|
-
before do
|
173
|
-
blacklight_config.json_solr_path = 'my-great-json'
|
174
|
-
end
|
175
|
-
|
176
|
-
it "uses the configured json_solr_path" do
|
177
|
-
allow(subject.connection).to receive(:send_and_receive) do |path|
|
178
|
-
expect(path).to eq 'my-great-json'
|
179
|
-
end
|
180
|
-
subject.search(input_params)
|
181
|
-
end
|
182
|
-
end
|
183
156
|
end
|
184
157
|
end
|
185
158
|
|
@@ -114,13 +114,13 @@ RSpec.describe Blacklight::Solr::Response::Facets, api: true do
|
|
114
114
|
|
115
115
|
it "defaults to count if no value is found and the default limit is used" do
|
116
116
|
expect(subject.aggregations['my_field'].sort).to eq 'count'
|
117
|
-
expect(subject.aggregations['my_field'].count?).to
|
117
|
+
expect(subject.aggregations['my_field'].count?).to be true
|
118
118
|
end
|
119
119
|
|
120
120
|
it "defaults to index if no value is found and the limit is unlimited" do
|
121
121
|
request_params['facet.limit'] = -1
|
122
122
|
expect(subject.aggregations['my_field'].sort).to eq 'index'
|
123
|
-
expect(subject.aggregations['my_field'].index?).to
|
123
|
+
expect(subject.aggregations['my_field'].index?).to be true
|
124
124
|
end
|
125
125
|
end
|
126
126
|
|
@@ -335,21 +335,21 @@ RSpec.describe Blacklight::Solr::Response::Facets, api: true do
|
|
335
335
|
let(:response) do
|
336
336
|
{
|
337
337
|
facets: {
|
338
|
-
|
339
|
-
|
340
|
-
|
338
|
+
count: 32,
|
339
|
+
categories: {
|
340
|
+
buckets: [
|
341
341
|
{
|
342
|
-
|
343
|
-
|
344
|
-
|
342
|
+
val: "electronics",
|
343
|
+
count: 12,
|
344
|
+
max_price: 60
|
345
345
|
},
|
346
346
|
{
|
347
|
-
|
348
|
-
|
347
|
+
val: "currency",
|
348
|
+
count: 4
|
349
349
|
},
|
350
350
|
{
|
351
|
-
|
352
|
-
|
351
|
+
val: "memory",
|
352
|
+
count: 3
|
353
353
|
}
|
354
354
|
]
|
355
355
|
}
|
@@ -375,25 +375,25 @@ RSpec.describe Blacklight::Solr::Response::Facets, api: true do
|
|
375
375
|
let(:response) do
|
376
376
|
{
|
377
377
|
facets: {
|
378
|
-
|
379
|
-
|
378
|
+
categories: {
|
379
|
+
buckets: [
|
380
380
|
{
|
381
|
-
|
382
|
-
|
383
|
-
|
384
|
-
|
385
|
-
|
386
|
-
|
381
|
+
val: "electronics",
|
382
|
+
count: 12,
|
383
|
+
top_manufacturer: {
|
384
|
+
buckets: [{
|
385
|
+
val: "corsair",
|
386
|
+
count: 3
|
387
387
|
}]
|
388
388
|
}
|
389
389
|
},
|
390
390
|
{
|
391
|
-
|
392
|
-
|
393
|
-
|
394
|
-
|
395
|
-
|
396
|
-
|
391
|
+
val: "currency",
|
392
|
+
count: 4,
|
393
|
+
top_manufacturer: {
|
394
|
+
buckets: [{
|
395
|
+
val: "boa",
|
396
|
+
count: 1
|
397
397
|
}]
|
398
398
|
}
|
399
399
|
}
|
@@ -413,7 +413,7 @@ RSpec.describe Blacklight::Solr::Response::Facets, api: true do
|
|
413
413
|
let(:response) do
|
414
414
|
{
|
415
415
|
facets: {
|
416
|
-
|
416
|
+
categories: {
|
417
417
|
"missing" => { "count" => 13 },
|
418
418
|
"buckets" => [{ "val" => "India", "count" => 2 }, { "val" => "Iran", "count" => 2 }]
|
419
419
|
}
|
@@ -43,7 +43,7 @@ RSpec.describe Blacklight::Solr::Response, api: true do
|
|
43
43
|
|
44
44
|
expected = "electronics - 14, memory - 3, card - 2, connector - 2, drive - 2, graphics - 2, hard - 2, monitor - 2, search - 2, software - 2"
|
45
45
|
received = first_facet.items.collect do |item|
|
46
|
-
item.value
|
46
|
+
"#{item.value} - #{item.hits}"
|
47
47
|
end.join(', ')
|
48
48
|
|
49
49
|
expect(received).to eq expected
|
@@ -60,12 +60,19 @@ RSpec.describe Blacklight::Solr::Response, api: true do
|
|
60
60
|
end
|
61
61
|
end
|
62
62
|
|
63
|
+
it 'provides a null-object for facets that are not in the response' do
|
64
|
+
expect(r.aggregations).not_to include :some_null_object
|
65
|
+
|
66
|
+
expect(r.aggregations[:some_null_object]).to be_a Blacklight::Solr::Response::FacetField
|
67
|
+
expect(r.aggregations[:some_null_object].items).to be_blank
|
68
|
+
end
|
69
|
+
|
63
70
|
it "provides kaminari pagination helpers" do
|
64
71
|
expect(r.limit_value).to eq(r.rows)
|
65
72
|
expect(r.offset_value).to eq(r.start)
|
66
73
|
expect(r.total_count).to eq(r.total)
|
67
74
|
expect(r.next_page).to eq(r.current_page + 1)
|
68
|
-
expect(r.prev_page).to
|
75
|
+
expect(r.prev_page).to be_nil
|
69
76
|
expect(r.entry_name(count: 1)).to eq 'entry'
|
70
77
|
expect(r.entry_name(count: 2)).to eq 'entries'
|
71
78
|
expect(r.size).to eq 26
|
@@ -3,8 +3,8 @@
|
|
3
3
|
RSpec.describe Blacklight::Solr::SearchBuilderBehavior, api: true do
|
4
4
|
subject { search_builder.with(user_params) }
|
5
5
|
|
6
|
-
let(:single_facet) { { format: 'Book' } }
|
7
|
-
let(:multi_facets) { { format: 'Book', language_ssim: 'Tibetan' } }
|
6
|
+
let(:single_facet) { { format: ['Book'] } }
|
7
|
+
let(:multi_facets) { { format: ['Book'], language_ssim: ['Tibetan'] } }
|
8
8
|
let(:mult_word_query) { 'tibetan history' }
|
9
9
|
let(:subject_search_params) { { commit: "search", search_field: "subject", action: "index", controller: "catalog", rows: "10", q: "wome" } }
|
10
10
|
|
@@ -73,7 +73,7 @@ RSpec.describe Blacklight::Solr::SearchBuilderBehavior, api: true do
|
|
73
73
|
expect(subject[:pf]).to eq ""
|
74
74
|
end
|
75
75
|
|
76
|
-
describe "should respect proper precedence of settings,
|
76
|
+
describe "should respect proper precedence of settings," do
|
77
77
|
it "does not put :search_field in produced params" do
|
78
78
|
expect(subject[:search_field]).to be_nil
|
79
79
|
end
|
@@ -108,7 +108,7 @@ RSpec.describe Blacklight::Solr::SearchBuilderBehavior, api: true do
|
|
108
108
|
end
|
109
109
|
|
110
110
|
it "generates a facet limit" do
|
111
|
-
expect(subject[:
|
111
|
+
expect(subject[:'f.subject_ssim.facet.limit']).to eq 21
|
112
112
|
end
|
113
113
|
|
114
114
|
context 'with a negative facet limit' do
|
@@ -117,7 +117,7 @@ RSpec.describe Blacklight::Solr::SearchBuilderBehavior, api: true do
|
|
117
117
|
end
|
118
118
|
|
119
119
|
it 'is negative' do
|
120
|
-
expect(subject[:
|
120
|
+
expect(subject[:'f.subject_ssim.facet.limit']).to eq -1
|
121
121
|
end
|
122
122
|
end
|
123
123
|
|
@@ -127,13 +127,13 @@ RSpec.describe Blacklight::Solr::SearchBuilderBehavior, api: true do
|
|
127
127
|
end
|
128
128
|
|
129
129
|
it 'is negative' do
|
130
|
-
expect(subject[:
|
130
|
+
expect(subject[:'f.subject_ssim.facet.limit']).to eq 0
|
131
131
|
end
|
132
132
|
end
|
133
133
|
|
134
134
|
it "handles no facet_limits in config" do
|
135
135
|
blacklight_config.facet_fields = {}
|
136
|
-
expect(subject).not_to have_key(:
|
136
|
+
expect(subject).not_to have_key(:'f.subject_ssim.facet.limit')
|
137
137
|
end
|
138
138
|
|
139
139
|
describe "with max per page enforced" do
|
@@ -178,7 +178,7 @@ RSpec.describe Blacklight::Solr::SearchBuilderBehavior, api: true do
|
|
178
178
|
|
179
179
|
it 'has default facet fields' do
|
180
180
|
# remove local params from the facet.field
|
181
|
-
expect(subject[:
|
181
|
+
expect(subject[:'facet.field'].map { |x| x.gsub(/\{![^}]+\}/, '') }).to match_array %w[format subject_ssim pub_date_ssim language_ssim lc_1letter_ssim subject_geo_ssim subject_era_ssim]
|
182
182
|
end
|
183
183
|
|
184
184
|
it "does not have a default qt" do
|
@@ -224,7 +224,7 @@ RSpec.describe Blacklight::Solr::SearchBuilderBehavior, api: true do
|
|
224
224
|
expect(subject["spellcheck.q"]).to be_blank
|
225
225
|
|
226
226
|
single_facet.each_value do |value|
|
227
|
-
|
227
|
+
value.each do |v|
|
228
228
|
expect(subject[:fq]).to include("{!term f=#{single_facet.keys[0]}}#{v}")
|
229
229
|
end
|
230
230
|
end
|
@@ -363,14 +363,14 @@ RSpec.describe Blacklight::Solr::SearchBuilderBehavior, api: true do
|
|
363
363
|
end
|
364
364
|
|
365
365
|
it "includes spellcheck.dictionary from field def solr_parameters" do
|
366
|
-
expect(subject[:
|
366
|
+
expect(subject[:'spellcheck.dictionary']).to eq "subject"
|
367
367
|
end
|
368
368
|
|
369
369
|
it "adds on :solr_local_parameters using Solr LocalParams style" do
|
370
370
|
# q == "{!pf=$subject_pf $qf=subject_qf} wome", make sure
|
371
371
|
# the LocalParams are really there
|
372
372
|
subject[:q] =~ /^\{!([^}]+)\}/
|
373
|
-
key_value_pairs = Regexp.last_match(1).split
|
373
|
+
key_value_pairs = Regexp.last_match(1).split
|
374
374
|
expect(key_value_pairs).to include("pf=$subject_pf")
|
375
375
|
expect(key_value_pairs).to include("qf=$subject_qf")
|
376
376
|
end
|
@@ -406,24 +406,6 @@ RSpec.describe Blacklight::Solr::SearchBuilderBehavior, api: true do
|
|
406
406
|
it 'includes addtional clause parameters for the field' do
|
407
407
|
expect(subject.dig(:json, :query, :bool, :must, 0, :edismax)).to include another: :parameter
|
408
408
|
end
|
409
|
-
|
410
|
-
context 'with an empty search' do
|
411
|
-
let(:subject_search_params) { { commit: "search", search_field: "subject", action: "index", controller: "catalog", rows: "10", q: nil } }
|
412
|
-
|
413
|
-
it 'does not add nil query value clauses to json query' do
|
414
|
-
expect(subject).not_to have_key :json
|
415
|
-
end
|
416
|
-
end
|
417
|
-
end
|
418
|
-
|
419
|
-
describe "overriding of qt parameter" do
|
420
|
-
let(:user_params) do
|
421
|
-
{ qt: 'overridden' }
|
422
|
-
end
|
423
|
-
|
424
|
-
it "returns the correct overriden parameter" do
|
425
|
-
expect(subject[:qt]).to eq "overridden"
|
426
|
-
end
|
427
409
|
end
|
428
410
|
|
429
411
|
describe "sorting" do
|
@@ -508,7 +490,7 @@ RSpec.describe Blacklight::Solr::SearchBuilderBehavior, api: true do
|
|
508
490
|
describe 'the search field query_builder config' do
|
509
491
|
let(:blacklight_config) do
|
510
492
|
Blacklight::Configuration.new do |config|
|
511
|
-
config.add_search_field('built_query', query_builder: ->(builder, *_args) { [builder.blacklight_params[:q].reverse, qq1: 'xyz'] })
|
493
|
+
config.add_search_field('built_query', query_builder: ->(builder, *_args) { [builder.blacklight_params[:q].reverse, { qq1: 'xyz' }] })
|
512
494
|
end
|
513
495
|
end
|
514
496
|
|
@@ -600,6 +582,17 @@ RSpec.describe Blacklight::Solr::SearchBuilderBehavior, api: true do
|
|
600
582
|
|
601
583
|
expect(solr_parameters[:fq]).to be_a_kind_of Array
|
602
584
|
end
|
585
|
+
|
586
|
+
context "facet not defined in config" do
|
587
|
+
let(:single_facet) { { unknown_facet_field: "foo" } }
|
588
|
+
let(:user_params) { { f: single_facet } }
|
589
|
+
|
590
|
+
it "does not add facet to solr_parameters" do
|
591
|
+
solr_parameters = Blacklight::Solr::Request.new
|
592
|
+
subject.add_facet_fq_to_solr(solr_parameters)
|
593
|
+
expect(solr_parameters[:fq]).to be_blank
|
594
|
+
end
|
595
|
+
end
|
603
596
|
end
|
604
597
|
|
605
598
|
describe "#add_solr_fields_to_query" do
|
@@ -751,7 +744,7 @@ RSpec.describe Blacklight::Solr::SearchBuilderBehavior, api: true do
|
|
751
744
|
end
|
752
745
|
|
753
746
|
it 'sets facets requested to facet_field argument' do
|
754
|
-
expect(solr_parameters[
|
747
|
+
expect(solr_parameters[:'facet.field']).to eq facet_field
|
755
748
|
end
|
756
749
|
|
757
750
|
it 'defaults offset to 0' do
|
@@ -45,4 +45,26 @@ RSpec.describe "Blacklight::User", api: true do
|
|
45
45
|
expect(subject.existing_bookmark_for(SolrDocument.new(id: 1))).to eq subject.bookmarks.first
|
46
46
|
end
|
47
47
|
end
|
48
|
+
|
49
|
+
describe '#to_s' do
|
50
|
+
it 'is the email by default' do
|
51
|
+
expect(subject.to_s).to eq subject.email
|
52
|
+
end
|
53
|
+
|
54
|
+
context 'when no email method is provided' do
|
55
|
+
let(:old_method) { subject.class.instance_method(:email) }
|
56
|
+
|
57
|
+
before do
|
58
|
+
subject.class.send(:undef_method, old_method.name)
|
59
|
+
end
|
60
|
+
|
61
|
+
after do
|
62
|
+
subject.class.send(:define_method, old_method.name, old_method)
|
63
|
+
end
|
64
|
+
|
65
|
+
it 'still provides a string' do
|
66
|
+
expect(subject.to_s).to be_a String
|
67
|
+
end
|
68
|
+
end
|
69
|
+
end
|
48
70
|
end
|
@@ -17,7 +17,7 @@ RSpec.describe Blacklight::DocumentPresenter do
|
|
17
17
|
describe '#fields_to_render' do
|
18
18
|
subject { presenter.fields_to_render.to_a }
|
19
19
|
|
20
|
-
let(:field_config) { Blacklight::Configuration::
|
20
|
+
let(:field_config) { Blacklight::Configuration::DisplayField.new(field: 'asdf') }
|
21
21
|
|
22
22
|
context 'when all of the fields have values' do
|
23
23
|
before do
|
@@ -30,7 +30,7 @@ RSpec.describe Blacklight::DocumentPresenter do
|
|
30
30
|
|
31
31
|
describe '#field_value' do
|
32
32
|
let(:field_presenter) { instance_double(Blacklight::FieldPresenter, render: 'xyz') }
|
33
|
-
let(:field_config) { Blacklight::Configuration::
|
33
|
+
let(:field_config) { Blacklight::Configuration::DisplayField.new }
|
34
34
|
let(:options) { { a: 1 } }
|
35
35
|
|
36
36
|
it 'calls the field presenter' do
|
@@ -1,4 +1,5 @@
|
|
1
1
|
# frozen_string_literal: true
|
2
|
+
|
2
3
|
require 'spec_helper'
|
3
4
|
|
4
5
|
RSpec.describe Blacklight::FacetFieldPresenter, type: :presenter do
|
@@ -44,11 +45,11 @@ RSpec.describe Blacklight::FacetFieldPresenter, type: :presenter do
|
|
44
45
|
describe '#active?' do
|
45
46
|
it "checks if any value is selected for a given facet" do
|
46
47
|
search_state.params[:f] = ActiveSupport::HashWithIndifferentAccess.new(key: [1])
|
47
|
-
expect(presenter.active?).to
|
48
|
+
expect(presenter.active?).to be true
|
48
49
|
end
|
49
50
|
|
50
51
|
it "is false if no value for facet is selected" do
|
51
|
-
expect(presenter.active?).to
|
52
|
+
expect(presenter.active?).to be false
|
52
53
|
end
|
53
54
|
end
|
54
55
|
|
@@ -59,12 +60,12 @@ RSpec.describe Blacklight::FacetFieldPresenter, type: :presenter do
|
|
59
60
|
end
|
60
61
|
|
61
62
|
it 'is true' do
|
62
|
-
expect(presenter.in_modal?).to
|
63
|
+
expect(presenter.in_modal?).to be true
|
63
64
|
end
|
64
65
|
end
|
65
66
|
|
66
67
|
it 'is false' do
|
67
|
-
expect(presenter.in_modal?).to
|
68
|
+
expect(presenter.in_modal?).to be false
|
68
69
|
end
|
69
70
|
end
|
70
71
|
|
@@ -72,7 +73,9 @@ RSpec.describe Blacklight::FacetFieldPresenter, type: :presenter do
|
|
72
73
|
let(:paginator) { Blacklight::FacetPaginator.new([{}, {}], limit: 1) }
|
73
74
|
|
74
75
|
before do
|
75
|
-
|
76
|
+
# rubocop:disable RSpec/SubjectStub
|
77
|
+
allow(presenter).to receive(:paginator).and_return(paginator)
|
78
|
+
# rubocop:enable RSpec/SubjectStub
|
76
79
|
end
|
77
80
|
|
78
81
|
context 'with no additional data' do
|
@@ -97,13 +100,6 @@ RSpec.describe Blacklight::FacetFieldPresenter, type: :presenter do
|
|
97
100
|
end
|
98
101
|
end
|
99
102
|
|
100
|
-
describe '#html_id' do
|
101
|
-
it 'gets the id from a helper' do
|
102
|
-
allow(view_context).to receive(:html_id).with('key').and_return('facet-key')
|
103
|
-
expect(presenter.html_id).to eq 'facet-key'
|
104
|
-
end
|
105
|
-
end
|
106
|
-
|
107
103
|
describe '#paginator' do
|
108
104
|
subject(:paginator) { presenter.paginator }
|
109
105
|
|
@@ -112,4 +108,81 @@ RSpec.describe Blacklight::FacetFieldPresenter, type: :presenter do
|
|
112
108
|
expect(paginator.total_count).to eq 0
|
113
109
|
end
|
114
110
|
end
|
111
|
+
|
112
|
+
describe "#facet_limit" do
|
113
|
+
subject(:facet_limit) { presenter.facet_limit }
|
114
|
+
|
115
|
+
let(:search_state) { Blacklight::SearchState.new({}, blacklight_config, controller) }
|
116
|
+
let(:blacklight_config) { CatalogController.blacklight_config }
|
117
|
+
let(:facet_field) { blacklight_config.facet_fields['subject_ssim'] }
|
118
|
+
let(:display_facet) do
|
119
|
+
instance_double(Blacklight::Solr::Response::Facets::FacetField, items: items, limit: nil, sort: :index, offset: 0, prefix: nil)
|
120
|
+
end
|
121
|
+
# let(:facet_field) { Blacklight::Configuration::FacetField.new(key: 'key') }
|
122
|
+
# let(:display_facet) do
|
123
|
+
# instance_double(Blacklight::Solr::Response::Facets::FacetField, items: items, sort: :index, offset: 0, prefix: nil)
|
124
|
+
# end
|
125
|
+
|
126
|
+
it "returns specified value for facet_field specified" do
|
127
|
+
expect(facet_limit).to eq facet_field.limit
|
128
|
+
end
|
129
|
+
|
130
|
+
describe "for 'true' configured values" do
|
131
|
+
let(:blacklight_config) do
|
132
|
+
Blacklight::Configuration.new do |config|
|
133
|
+
config.add_facet_field "language_facet", limit: true
|
134
|
+
end
|
135
|
+
end
|
136
|
+
let(:facet_field) { blacklight_config.facet_fields['language_facet'] }
|
137
|
+
|
138
|
+
context 'when the limit in the response is nil' do
|
139
|
+
let(:display_facet) do
|
140
|
+
instance_double(Blacklight::Solr::Response::Facets::FacetField, items: items, limit: nil, sort: :index, offset: 0, prefix: nil)
|
141
|
+
end
|
142
|
+
|
143
|
+
it "uses the config setting" do
|
144
|
+
blacklight_config.facet_fields['language_facet'].limit = 10
|
145
|
+
expect(facet_limit).to eq 10
|
146
|
+
end
|
147
|
+
end
|
148
|
+
|
149
|
+
context 'when the limit in the response is provided' do
|
150
|
+
let(:display_facet) do
|
151
|
+
instance_double(Blacklight::Solr::Response::Facets::FacetField, items: items, limit: 16, sort: :index, offset: 0, prefix: nil)
|
152
|
+
end
|
153
|
+
|
154
|
+
it "gets the limit from the facet field in @response" do
|
155
|
+
expect(facet_limit).to eq 15
|
156
|
+
end
|
157
|
+
end
|
158
|
+
|
159
|
+
context 'when not in the display_facet' do
|
160
|
+
let(:display_facet) { nil }
|
161
|
+
|
162
|
+
it "defaults to 10" do
|
163
|
+
expect(facet_limit).to eq 10
|
164
|
+
end
|
165
|
+
end
|
166
|
+
end
|
167
|
+
|
168
|
+
context 'for facet fields with a key that is different from the field name' do
|
169
|
+
before do
|
170
|
+
allow(controller).to receive(:blacklight_config).and_return(blacklight_config)
|
171
|
+
end
|
172
|
+
|
173
|
+
let(:blacklight_config) do
|
174
|
+
Blacklight::Configuration.new do |config|
|
175
|
+
config.add_facet_field 'some_key', field: 'x', limit: true
|
176
|
+
end
|
177
|
+
end
|
178
|
+
let(:facet_field) { blacklight_config.facet_fields['some_key'] }
|
179
|
+
let(:display_facet) do
|
180
|
+
instance_double(Blacklight::Solr::Response::Facets::FacetField, items: items, limit: 16, sort: :index, offset: 0, prefix: nil)
|
181
|
+
end
|
182
|
+
|
183
|
+
it 'gets the limit from the facet field in the @response' do
|
184
|
+
expect(facet_limit).to eq 15
|
185
|
+
end
|
186
|
+
end
|
187
|
+
end
|
115
188
|
end
|
@@ -1,4 +1,5 @@
|
|
1
1
|
# frozen_string_literal: true
|
2
|
+
|
2
3
|
require 'spec_helper'
|
3
4
|
|
4
5
|
RSpec.describe Blacklight::FacetItemPresenter, type: :presenter do
|
@@ -7,22 +8,22 @@ RSpec.describe Blacklight::FacetItemPresenter, type: :presenter do
|
|
7
8
|
end
|
8
9
|
|
9
10
|
let(:facet_item) { instance_double(Blacklight::Solr::Response::Facets::FacetItem) }
|
11
|
+
let(:filter_field) { instance_double(Blacklight::SearchState::FilterField, include?: true) }
|
10
12
|
let(:facet_config) { Blacklight::Configuration::FacetField.new(key: 'key') }
|
11
13
|
let(:facet_field) { instance_double(Blacklight::Solr::Response::Facets::FacetField) }
|
12
14
|
let(:view_context) { controller.view_context }
|
13
|
-
let(:search_state) { instance_double(Blacklight::SearchState) }
|
15
|
+
let(:search_state) { instance_double(Blacklight::SearchState, filter: filter_field) }
|
14
16
|
|
15
17
|
describe '#selected?' do
|
16
|
-
|
17
|
-
|
18
|
-
|
19
|
-
end
|
18
|
+
subject { presenter.selected? }
|
19
|
+
|
20
|
+
it { is_expected.to be true }
|
20
21
|
end
|
21
22
|
|
22
23
|
describe '#label' do
|
23
|
-
it "is the facet value for an ordinary facet" do
|
24
|
+
it "is the stringified facet value for an ordinary facet" do
|
24
25
|
allow(facet_config).to receive_messages(query: nil, date: nil, helper_method: nil, url_method: nil)
|
25
|
-
expect(presenter.label).to eq facet_item
|
26
|
+
expect(presenter.label).to eq facet_item.to_s
|
26
27
|
end
|
27
28
|
|
28
29
|
it "allows you to pass in a :helper_method argument to the configuration" do
|
@@ -63,9 +64,7 @@ RSpec.describe Blacklight::FacetItemPresenter, type: :presenter do
|
|
63
64
|
end
|
64
65
|
|
65
66
|
describe '#href' do
|
66
|
-
|
67
|
-
allow(search_state).to receive(:has_facet?).and_return(false)
|
68
|
-
end
|
67
|
+
let(:filter_field) { instance_double(Blacklight::SearchState::FilterField, include?: false) }
|
69
68
|
|
70
69
|
it 'is the url to apply the facet' do
|
71
70
|
allow(search_state).to receive(:add_facet_params_and_redirect).with('key', facet_item).and_return(f: 'x')
|
@@ -87,11 +86,13 @@ RSpec.describe Blacklight::FacetItemPresenter, type: :presenter do
|
|
87
86
|
end
|
88
87
|
|
89
88
|
context 'with a selected facet' do
|
90
|
-
|
91
|
-
|
92
|
-
|
89
|
+
let(:filter_field) { instance_double(Blacklight::SearchState::FilterField, include?: true, remove: {}) }
|
90
|
+
|
91
|
+
before do
|
93
92
|
allow(view_context).to receive(:search_action_path).with({}).and_return('/catalog')
|
93
|
+
end
|
94
94
|
|
95
|
+
it 'is the url to remove the facet' do
|
95
96
|
expect(presenter.href).to eq '/catalog'
|
96
97
|
end
|
97
98
|
end
|