blacklight 7.32.0 → 8.0.0.beta1

data/app/views/catalog/_index_header.html.erb

@@ -1,22 +0,0 @@
-<%# header bar for doc items in index view -%>
-<header class="documentHeader row">
-  <%# main title container for doc partial view
-      How many bootstrap columns need to be reserved
-      for bookmarks control depends on size.
-  -%>
-  <% document_actions = capture do %>
-    <% # bookmark functions for items/docs -%>
-    <%= render_index_doc_actions document, wrapping_class: "index-document-functions col-sm-3 col-lg-2" %>
-  <% end %>
-
-  <h3 class="index_title document-title-heading <%= document_actions.present? ? "col-sm-9 col-lg-10" : "col-md-12" %>">
-    <% if counter = document_counter_with_offset(document_counter) %>
-      <span class="document-counter">
-        <%= t('blacklight.search.documents.counter', counter: counter) %>
-      </span>
-    <% end %>
-    <%= link_to_document document, counter: counter %>
-  </h3>
-
-  <%= document_actions %>
-</header>

data/app/views/catalog/_previous_next_doc.html.erb

@@ -1,2 +0,0 @@
-<% Deprecation.warn(self, 'The partial _previous_next_doc.html.erb will be removed in 8.0. Render Blacklight::SearchContextComponent instead.') %>
-<%= render(Blacklight::SearchContextComponent.new(search_context: @search_context, search_session: search_session)) %>

data/app/views/catalog/_show.html.erb

@@ -1,6 +0,0 @@
-<%= render(
-  Blacklight::DocumentMetadataComponent.new(
-    fields: document_presenter(document).field_presenters,
-    show: true
-  )
-) %>

data/app/views/catalog/_show_header.html.erb

@@ -1,2 +0,0 @@
-<% # bookmark/folder functions -%>
-<%= Deprecation.silence(Blacklight::BlacklightHelperBehavior) { render_document_heading(document, :tag => :h1) } %>

data/app/views/catalog/_thumbnail.html.erb

@@ -1 +0,0 @@
-<%= render Blacklight::Document::ThumbnailComponent.new(presenter: document_presenter(document), counter: document_counter_with_offset(document_counter)) -%>

data/lib/blacklight/deprecations/engine_configuration.rb

@@ -1,66 +0,0 @@
-# frozen_string_literal: true
-
-module Blacklight
-  module Deprecations
-    module EngineConfiguration
-      # rubocop:disable Style/RedundantSelf, Style/HashSyntax
-      # @deprecated
-      def bookmarks_http_method
-        self.blacklight.bookmarks_http_method
-      end
-      deprecation_deprecate bookmarks_http_method: 'Moved to `blacklight.bookmarks_http_method`'
-
-      # @deprecated
-      def bookmarks_http_method=(val)
-        self.blacklight.bookmarks_http_method = val
-      end
-      deprecation_deprecate :'bookmarks_http_method=' => 'Moved to `blacklight.bookmarks_http_method=`'
-
-      # @deprecated
-      def email_regexp
-        self.blacklight.email_regexp
-      end
-      deprecation_deprecate email_regexp: 'Moved to `blacklight.email_regexp`'
-
-      # @deprecated
-      def email_regexp=(val)
-        self.blacklight.email_regexp = val
-      end
-      deprecation_deprecate :'email_regexp=' => 'Moved to `blacklight.email_regexp=`'
-
-      # @deprecated
-      def facet_missing_param
-        self.blacklight.facet_missing_param
-      end
-      deprecation_deprecate facet_missing_param: 'Moved to `blacklight.facet_missing_param`'
-
-      # @deprecated
-      def facet_missing_param=(val)
-        self.blacklight.facet_missing_param = val
-      end
-      deprecation_deprecate :'facet_missing_param=' => 'Moved to `blacklight.facet_missing_param=`'
-
-      # @deprecated
-      def sms_mappings
-        self.blacklight.sms_mappings
-      end
-      deprecation_deprecate sms_mappings: 'Moved to `blacklight.sms_mappings`'
-
-      # @deprecated
-      def sms_mappings=(val)
-        self.blacklight.sms_mappings = val
-      end
-      deprecation_deprecate :'sms_mappings=' => 'Moved to `blacklight.sms_mappings=`'
-      # rubocop:enable Style/RedundantSelf, Style/HashSyntax
-
-      def self.deprecate_in(object)
-        class << object
-          extend Deprecation
-          self.deprecation_horizon = 'blacklight 8.0'
-
-          include Blacklight::Deprecations::EngineConfiguration
-        end
-      end
-    end
-  end
-end

data/lib/blacklight/deprecations/search_state_normalization.rb

@@ -1,52 +0,0 @@
-# frozen_string_literal: true
-
-module Blacklight
-  module Deprecations
-    module SearchStateNormalization
-      extend ActiveSupport::Concern
-
-      class_methods do
-        def facet_params_need_normalization(facet_params)
-          Deprecation.warn(self, 'Calling `facet_params_need_normalization` on the Blacklight::SearchState ' \
-          'class is deprecated and will be removed in Blacklight 8. Delegate to #needs_normalization?(value_params) on the ' \
-          'filter fields of the search state object.')
-
-          facet_params.is_a?(Hash) && facet_params.values.any? { |x| x.is_a?(Hash) }
-        end
-
-        def normalize_facet_params(facet_params)
-          Deprecation.warn(self, 'Calling `normalize_facet_params` on the Blacklight::SearchState ' \
-          'class is deprecated and will be removed in Blacklight 8. Delegate to #normalize(value_params) on the ' \
-          'filter fields of the search state object.')
-
-          facet_params.transform_values { |value| value.is_a?(Hash) ? value.values : value }
-        end
-
-        def normalize_params(untrusted_params = {})
-          Deprecation.warn(self, 'Calling `normalize_params` on the Blacklight::SearchState ' \
-          'class is deprecated and will be removed in Blacklight 8. Call #normalize_params on the ' \
-          'search state object.')
-          params = untrusted_params
-
-          if params.respond_to?(:to_unsafe_h)
-            # This is the typical (not-ActionView::TestCase) code path.
-            params = params.to_unsafe_h
-            # In Rails 5 to_unsafe_h returns a HashWithIndifferentAccess, in Rails 4 it returns Hash
-            params = params.with_indifferent_access if params.instance_of? Hash
-          elsif params.is_a? Hash
-            # This is an ActionView::TestCase workaround for Rails 4.2.
-            params = params.dup.with_indifferent_access
-          else
-            params = params.dup.to_h.with_indifferent_access
-          end
-
-          # Normalize facet parameters mangled by facebook
-          params[:f] = normalize_facet_params(params[:f]) if facet_params_need_normalization(params[:f])
-          params[:f_inclusive] = normalize_facet_params(params[:f_inclusive]) if facet_params_need_normalization(params[:f_inclusive])
-
-          params
-        end
-      end
-    end
-  end
-end

data/spec/controllers/blacklight/facet_spec.rb

@@ -1,33 +0,0 @@
-# frozen_string_literal: true
-
-RSpec.describe Blacklight::Facet do
-  subject do
-    Class.new do
-      include Blacklight::Facet
-      attr_reader :blacklight_config
-
-      def initialize blacklight_config
-        @blacklight_config = blacklight_config
-      end
-    end.new(blacklight_config)
-  end
-
-  let(:blacklight_config) { Blacklight::Configuration.new }
-
-  describe "#facet_configuration_for_field" do
-    it "looks up fields by key" do
-      blacklight_config.add_facet_field 'a'
-      expect(subject.facet_configuration_for_field('a')).to eq blacklight_config.facet_fields['a']
-    end
-
-    it "looks up fields by field name" do
-      blacklight_config.add_facet_field 'a', field: 'b'
-      expect(subject.facet_configuration_for_field('b')).to eq blacklight_config.facet_fields['a']
-    end
-
-    it "supports both strings and symbols" do
-      blacklight_config.add_facet_field 'a', field: :b
-      expect(subject.facet_configuration_for_field('b')).to eq blacklight_config.facet_fields['a']
-    end
-  end
-end

data/spec/controllers/blacklight/search_fields_spec.rb

@@ -1,62 +0,0 @@
-# frozen_string_literal: true
-
-RSpec.describe Blacklight::SearchFields do
-  around { |test| Deprecation.silence(described_class) { test.call } }
-
-  class MockConfig
-    include Blacklight::SearchFields
-  end
-
-  before(:all) do
-    @config = Blacklight::Configuration.new do |config|
-      config.default_solr_params = { qt: 'search' }
-
-      config.add_search_field 'all_fields', label: 'All Fields'
-      config.add_search_field 'title', qt: 'title_search'
-      config.add_search_field 'author', qt: 'author_search'
-      config.add_search_field 'subject', qt: 'subject_search'
-      config.add_search_field 'no_display', qt: 'something', include_in_simple_select: false
-    end
-  end
-
-  before do
-    @search_field_obj = MockConfig.new
-    allow(@search_field_obj).to receive(:blacklight_config).and_return(@config)
-  end
-
-  it "returns search field list with calculated :label when needed" do
-    @search_field_obj.search_field_list.each do |hash|
-      expect(hash.label).not_to be_blank
-    end
-  end
-
-  describe "for unspecified :key" do
-    before do
-      @bad_config = MockConfig.new
-    end
-
-    it "raises exception on #search_field_list" do
-      expect do
-        allow(@bad_config).to receive(:blacklight_config).and_return(Blacklight::Configuration.new do |config|
-                                                                       config.add_search_field label: 'All Fields', qt: 'all_fields'
-                                                                       config.add_search_field 'title', qt: 'title_search'
-                                                                     end)
-      end.to raise_error ArgumentError
-    end
-  end
-
-  describe "for duplicate keys" do
-    before do
-      @bad_config = MockConfig.new
-    end
-
-    it "raises on #search_field_list" do
-      expect do
-        allow(@bad_config).to receive(:blacklight_config).and_return(Blacklight::Configuration.new do |config|
-                                                                       config.add_search_field 'my_key', label: 'All Fields'
-                                                                       config.add_search_field 'my_key', label: 'title'
-                                                                     end)
-      end.to raise_error RuntimeError
-    end
-  end
-end

data/spec/helpers/blacklight/hash_as_hidden_fields_behavior_spec.rb

@@ -1,26 +0,0 @@
-# frozen_string_literal: true
-
-RSpec.describe Blacklight::HashAsHiddenFieldsHelperBehavior do
-  around { |test| Deprecation.silence(described_class) { test.call } }
-
-  let(:params) do
-    { q: "query",
-      search_field: "search_field",
-      per_page: 10,
-      page: 5,
-      extra_arbitrary_key: "arbitrary_value",
-      f: { field1: %w[a b], field2: ["z"] } }
-  end
-  let(:generated) { helper.render_hash_as_hidden_fields(params) }
-
-  it "converts a hash with nested complex data to Rails-style hidden form fields" do
-    allow(Deprecation).to receive(:warn)
-    expect(generated).to have_selector("input[type='hidden'][name='q'][value='query']", visible: false)
-    expect(generated).to have_selector("input[type='hidden'][name='per_page'][value='10']", visible: false)
-    expect(generated).to have_selector("input[type='hidden'][name='page'][value='5']", visible: false)
-    expect(generated).to have_selector("input[type='hidden'][name='extra_arbitrary_key'][value='arbitrary_value']", visible: false)
-    expect(generated).to have_selector("input[type='hidden'][name='f[field2][]'][value='z']", visible: false)
-    expect(generated).to have_selector("input[type='hidden'][name='f[field1][]'][value='a']", visible: false)
-    expect(generated).to have_selector("input[type='hidden'][name='f[field1][]'][value='b']", visible: false)
-  end
-end

data/spec/helpers/blacklight/render_constraints_helper_behavior_spec.rb

@@ -1,92 +0,0 @@
-# frozen_string_literal: true
-
-RSpec.describe Blacklight::RenderConstraintsHelperBehavior do
-  around { |test| Deprecation.silence(described_class) { test.call } }
-
-  let(:config) do
-    Blacklight::Configuration.new do |config|
-      config.add_facet_field 'type'
-      config.add_search_field 'title'
-    end
-  end
-
-  before do
-    # the helper methods below infer paths from the current route
-    controller.request.path_parameters[:controller] = 'catalog'
-    allow(helper).to receive(:search_action_path) do |*args|
-      search_catalog_path *args
-    end
-
-    allow(helper).to receive(:blacklight_config).and_return(config)
-    allow(controller).to receive(:search_state_class).and_return(Blacklight::SearchState)
-  end
-
-  describe '#render_constraints_query' do
-    subject { helper.render_constraints_query(params) }
-
-    let(:my_engine) { double("Engine") }
-    let(:params) { ActionController::Parameters.new(q: 'foobar', f: { type: 'journal' }) }
-
-    it "has a link relative to the current url" do
-      expect(subject).to have_link 'Remove constraint', href: '/catalog?f%5Btype%5D%5B%5D=journal'
-    end
-  end
-
-  describe '#render_constraints_clauses' do
-    subject { helper.render_constraints_clauses(params) }
-
-    let(:my_engine) { double("Engine") }
-    let(:params) { ActionController::Parameters.new(clause: { "0": { field: 'title', query: 'nature' } }, f: { type: 'journal' }) }
-
-    it 'renders the clause constraint' do
-      expect(subject).to have_selector '.constraint-value', text: /Title\s+nature/
-    end
-
-    it "has a link relative to the current url" do
-      expect(subject).to have_link 'Remove constraint Title: nature', href: '/catalog?f%5Btype%5D%5B%5D=journal'
-    end
-  end
-
-  describe '#render_filter_element' do
-    subject { helper.render_filter_element('type', ['journal'], path) }
-
-    before do
-      allow(helper).to receive(:blacklight_config).and_return(config)
-      expect(helper).to receive(:facet_field_label).with('type').and_return("Item Type")
-    end
-
-    let(:params) { ActionController::Parameters.new q: 'biz' }
-    let(:path) { Blacklight::SearchState.new(params, config, controller) }
-
-    it "has a link relative to the current url" do
-      expect(subject).to have_link "Remove constraint Item Type: journal", href: "/catalog?q=biz"
-      expect(subject).to have_selector ".filter-name", text: 'Item Type'
-    end
-
-    context 'with string values' do
-      subject { helper.render_filter_element('type', 'journal', path) }
-
-      it "handles string values gracefully" do
-        expect(subject).to have_link "Remove constraint Item Type: journal", href: "/catalog?q=biz"
-      end
-    end
-
-    context 'with multivalued facets' do
-      subject { helper.render_filter_element('type', [%w[journal book]], path) }
-
-      it "handles such values gracefully" do
-        expect(subject).to have_link "Remove constraint Item Type: journal OR book", href: "/catalog?q=biz"
-      end
-    end
-  end
-
-  describe "#render_constraints_filters" do
-    subject { helper.render_constraints_filters(params) }
-
-    let(:params) { ActionController::Parameters.new f: { 'type' => [''] } }
-
-    it "renders nothing for empty facet limit param" do
-      expect(subject).to be_blank
-    end
-  end
-end

data/spec/helpers/blacklight/search_history_constraints_helper_behavior_spec.rb

@@ -1,108 +0,0 @@
-# frozen_string_literal: true
-
-RSpec.describe Blacklight::SearchHistoryConstraintsHelperBehavior do
-  around { |test| Deprecation.silence(described_class) { test.call } }
-
-  before(:all) do
-    @config = Blacklight::Configuration.new do |config|
-      config.add_search_field 'default_search_field', label: 'Default'
-
-      config.add_facet_field 'some_facet', label: 'Some'
-      config.add_facet_field 'other_facet', label: 'Other'
-      config.add_facet_field 'i18n_facet'
-
-      I18n.backend.store_translations(:en, blacklight: { search: { fields: { facet: { i18n_facet: 'English facet label' } } } })
-      I18n.backend.store_translations(:de, blacklight: { search: { fields: { facet: { i18n_facet: 'German facet label' } } } })
-    end
-  end
-
-  before do
-    allow(helper).to receive(:blacklight_config).and_return(@config)
-  end
-
-  describe "render_search_to_s_*" do
-    describe "render_search_to_s_element" do
-      it "renders basic element" do
-        response = helper.render_search_to_s_element("key", "value")
-        expect(response).to have_selector("span.constraint") do |span|
-          expect(span).to have_selector("span.filter-name", content: "key:")
-          expect(span).to have_selector("span.filter-value", content: "value")
-        end
-        expect(response).to be_html_safe
-      end
-
-      it "escapes them that need escaping" do
-        response = helper.render_search_to_s_element("key>", "value>")
-        expect(response).to have_selector("span.constraint") do |span|
-          expect(span).to have_selector("span.filter-name") do |s2|
-            # Note: nokogiri's gettext will unescape the inner html
-            # which seems to be what rspecs "contains" method calls on
-            # text nodes - thus the to_s inserted below.
-            expect(s2).to match(/key>:/)
-          end
-          expect(span).to have_selector("span.filter-value") do |s3|
-            expect(s3).to match(/value>/)
-          end
-        end
-        expect(response).to be_html_safe
-      end
-
-      it "does not escape with options set thus" do
-        response = helper.render_search_to_s_element("key>", "value>", escape_key: false, escape_value: false)
-        expect(response).to have_selector("span.constraint") do |span|
-          expect(span).to have_selector("span.filter-name", content: "key>:")
-          expect(span).to have_selector("span.filter-value", content: "value>")
-        end
-        expect(response).to be_html_safe
-      end
-    end
-
-    describe "render_search_to_s" do
-      before do
-        @params = { q: "history", f: { "some_facet" => %w[value1 value1], "other_facet" => ["other1"] } }
-      end
-
-      it "calls lesser methods" do
-        allow(helper).to receive(:blacklight_config).and_return(@config)
-        allow(helper).to receive(:default_search_field).and_return(Blacklight::Configuration::SearchField.new(key: 'default_search_field', display_label: 'Default'))
-        allow(helper).to receive(:label_for_search_field).with(nil).and_return('')
-        # API hooks expect this to be so
-        response = helper.render_search_to_s(@params)
-
-        expect(response).to include(helper.render_search_to_s_q(@params))
-        expect(response).to include(helper.render_search_to_s_filters(@params))
-        expect(response).to be_html_safe
-      end
-    end
-
-    describe "render_search_to_s_filters" do
-      it "renders a constraint for a selected facet in the config" do
-        response = helper.render_search_to_s_filters(f: { "some_facet" => %w[value1 value2] })
-        expect(response).to eq("<span class=\"constraint\"><span class=\"filter-name\">Some:</span><span class=\"filter-values\"><span class=\"filter-value\">value1</span><span class=\"filter-separator\"> and </span><span class=\"filter-value\">value2</span></span></span>")
-      end
-
-      it "renders a constraint for a selected facet not in the config" do
-        response = helper.render_search_to_s_filters(f: { "undefined_facet" => %w[value1 value2] })
-        expect(response).to eq("<span class=\"constraint\"><span class=\"filter-name\">#{'undefined_facet'.titleize}:</span><span class=\"filter-values\"><span class=\"filter-value\">value1</span><span class=\"filter-separator\"> and </span><span class=\"filter-value\">value2</span></span></span>")
-      end
-
-      context 'with I18n translations for selected facet' do
-        before do
-          @orig_locale = I18n.locale
-        end
-
-        after do
-          I18n.locale = @orig_locale
-        end
-
-        it 'renders the correct I18n label for a selected facet with I18n translations' do
-          { en: 'English facet label', de: 'German facet label' }.each do |locale, label|
-            I18n.locale = locale
-            response = helper.render_search_to_s_filters(f: { 'i18n_facet' => %w[value1 value2] })
-            expect(response).to include(label)
-          end
-        end
-      end
-    end
-  end
-end

data/spec/helpers/blacklight/suggest_helper_behavior_spec.rb

@@ -1,48 +0,0 @@
-# frozen_string_literal: true
-
-RSpec.describe Blacklight::SuggestHelperBehavior do
-  before do
-    allow(helper).to receive(:blacklight_config).and_return(blacklight_config)
-    expect(Deprecation).to receive(:warn)
-  end
-
-  describe '#autocomplete_enabled?' do
-    describe 'with autocomplete config' do
-      let(:blacklight_config) do
-        Blacklight::Configuration.new.configure do |config|
-          config.autocomplete_enabled = true
-          config.autocomplete_path = 'suggest'
-        end
-      end
-
-      it 'is enabled' do
-        expect(helper.autocomplete_enabled?).to be true
-      end
-    end
-
-    describe 'without disabled config' do
-      let(:blacklight_config) do
-        Blacklight::Configuration.new.configure do |config|
-          config.autocomplete_enabled = false
-          config.autocomplete_path = 'suggest'
-        end
-      end
-
-      it 'is disabled' do
-        expect(helper.autocomplete_enabled?).to be false
-      end
-    end
-
-    describe 'without path config' do
-      let(:blacklight_config) do
-        Blacklight::Configuration.new.configure do |config|
-          config.autocomplete_enabled = true
-        end
-      end
-
-      it 'is disabled' do
-        expect(helper.autocomplete_enabled?).to be false
-      end
-    end
-  end
-end

data/spec/lib/blacklight/engine_spec.rb

@@ -1,41 +0,0 @@
-# frozen_string_literal: true
-
-RSpec.describe Blacklight::Engine do
-  [:bookmarks_http_method, :email_regexp, :facet_missing_param, :sms_mappings].each do |dep_key|
-    describe "config.#{dep_key}" do
-      subject { described_class.config }
-
-      let(:unlikely_value) { 'unlikely value' }
-
-      it 'is deprecated' do
-        allow(Deprecation).to receive(:warn)
-        subject.send(dep_key)
-        expect(Deprecation).to have_received(:warn)
-      end
-
-      it 'delegates to config.blacklight' do
-        allow(subject.blacklight).to receive(dep_key).and_return(unlikely_value)
-        expect(subject.send(dep_key)).to eql(unlikely_value)
-      end
-    end
-
-    describe "config.#{dep_key}=" do
-      subject { described_class.config }
-
-      let(:unlikely_value) { 'unlikely value' }
-
-      it 'is deprecated' do
-        allow(Deprecation).to receive(:warn)
-        allow(subject.blacklight).to receive(:"#{dep_key}=").with(unlikely_value)
-        subject.send(:"#{dep_key}=", unlikely_value)
-        expect(Deprecation).to have_received(:warn)
-      end
-
-      it 'delegates to config.blacklight' do
-        allow(subject.blacklight).to receive(:"#{dep_key}=").with(unlikely_value)
-        subject.send(:"#{dep_key}=", unlikely_value)
-        expect(subject.blacklight).to have_received(:"#{dep_key}=").with(unlikely_value)
-      end
-    end
-  end
-end

data/spec/presenters/blacklight/search_bar_presenter_spec.rb

@@ -1,94 +0,0 @@
-# frozen_string_literal: true
-require 'spec_helper'
-
-RSpec.describe Blacklight::SearchBarPresenter do
-  let(:controller) { CatalogController.new }
-  let(:presenter) { described_class.new(controller, blacklight_config) }
-  let(:blacklight_config) { Blacklight::Configuration.new }
-
-  describe '#autocomplete_enabled?' do
-    subject { presenter.autocomplete_enabled? }
-
-    describe 'with autocomplete config' do
-      let(:blacklight_config) do
-        Blacklight::Configuration.new.configure do |config|
-          config.autocomplete_enabled = true
-          config.autocomplete_path = 'suggest'
-        end
-      end
-
-      it { is_expected.to be true }
-    end
-
-    describe 'without disabled config' do
-      let(:blacklight_config) do
-        Blacklight::Configuration.new.configure do |config|
-          config.autocomplete_enabled = false
-          config.autocomplete_path = 'suggest'
-        end
-      end
-
-      it { is_expected.to be false }
-    end
-
-    describe 'without path config' do
-      let(:blacklight_config) do
-        Blacklight::Configuration.new.configure do |config|
-          config.autocomplete_enabled = true
-        end
-      end
-
-      it { is_expected.to be false }
-    end
-  end
-
-  describe "#autofocus?" do
-    subject { presenter.autofocus? }
-
-    context "on a catalog-like index page without query or facet parameters" do
-      let(:blacklight_config) do
-        Blacklight::Configuration.new.configure do |config|
-          config.enable_search_bar_autofocus = true
-        end
-      end
-
-      before do
-        allow(controller).to receive(:action_name).and_return('index')
-        allow(controller).to receive(:has_search_parameters?).and_return(false)
-      end
-
-      it { is_expected.to be true }
-    end
-
-    context "when disabled in config" do
-      before do
-        allow(controller).to receive(:action_name).and_return('index')
-        allow(controller).to receive(:has_search_parameters?).and_return(false)
-      end
-
-      it { is_expected.to be false }
-    end
-
-    context "when not the catalog controller" do
-      let(:controller) { ApplicationController.new }
-
-      it { is_expected.to be false }
-    end
-
-    context "when on the catalog controller show page" do
-      before do
-        allow(controller).to receive(:action_name).and_return('show')
-      end
-
-      it { is_expected.to be false }
-    end
-
-    context "when search parameters are provided" do
-      before do
-        allow(controller).to receive(:has_search_parameters?).and_return(true)
-      end
-
-      it { is_expected.to be false }
-    end
-  end
-end