blacklight 7.11.1 → 7.13.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 74d6e5485343fa8fc02b71d94e374d2f2d0a49f05e9bbf2e2226fe02088213f4
-  data.tar.gz: d1894865278720fc03af712e6cb424eaa1f3c30aa0f71666be7a301052663562
+  metadata.gz: f57c80d2b77a3b8bd0d536f3800fad183aa43d5aec10b71f921dfb23cbb6b26c
+  data.tar.gz: 9748a16edba74f0a1f24b1d6813987196088e1d217dd621b6455ca235aec37be
 SHA512:
-  metadata.gz: 9d40718c50283de79a47a70e77c3cdd5e13a92edf1eb657d749c96f25fd473523a09f4d68e594adf3d2f5cb3a6e249d6ebd61bf7ec349a4bc97ffad8b213fc5e
-  data.tar.gz: d3732c39e9672c23943b01aef361d29fc7cfb3f1f9d6e243770b72cc6ac61677cee2f478ae8cf50120d51d3978eda85492d4f386a15820b04d6350bfac53219c
+  metadata.gz: af48c90bc958243c5177660307c059a974c647f27b1fd890061e6efbba253b68d4690e46547b488fee11fe92140db88d39051a0a666e656f478d89e9650fd541
+  data.tar.gz: '019a8e8383aff4582a98a74348c2b40cf7e57aa121213fbd43702c13ff66f2f30c455d43c06dfa0f26c39ebc74f9d34ff40f72b72ed30bdd180384f58deb25cb'

data/.github/workflows/ruby.yml

@@ -0,0 +1,89 @@
+# This workflow uses actions that are not certified by GitHub.
+# They are provided by a third-party and are governed by
+# separate terms of service, privacy policy, and support
+# documentation.
+# This workflow will download a prebuilt Ruby version, install dependencies and run tests with Rake
+# For more information see: https://github.com/marketplace/actions/setup-ruby-jruby-and-truffleruby
+
+name: CI
+
+on:
+  push:
+    branches: [ master ]
+  pull_request:
+    branches: [ master ]
+
+jobs:
+  lint:
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@v2
+    - name: Set up Ruby
+      uses: ruby/setup-ruby@v1
+      with:
+        ruby-version: 2.7
+    - name: Install dependencies
+      run: bundle install
+    - name: Run linter
+      run: bundle exec rake rubocop
+  test:
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        ruby: [2.6, 2.7]
+    steps:
+    - uses: actions/checkout@v2
+    - name: Set up Ruby
+      uses: ruby/setup-ruby@v1
+      with:
+        ruby-version: ${{ matrix.ruby }}
+    - name: Install dependencies
+      run: bundle install
+    - name: Run tests
+      run: bundle exec rake ci
+      env:
+        ENGINE_CART_RAILS_OPTIONS: '--skip-git --skip-listen --skip-spring --skip-keeps --skip-action-cable --skip-coffee --skip-test'
+  test_rails5:
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        ruby: [2.5, 2.6]
+    steps:
+    - uses: actions/checkout@v2
+    - name: Set up Ruby
+      uses: ruby/setup-ruby@v1
+      with:
+        ruby-version: ${{ matrix.ruby }}
+    - name: Install dependencies
+      run: bundle install
+      env:
+        RAILS_VERSION: 5.2.4.2
+    - name: Run tests
+      run: bundle exec rake ci
+      env:
+        RAILS_VERSION: 5.2.4.2
+        ENGINE_CART_RAILS_OPTIONS: '--skip-git --skip-listen --skip-spring --skip-keeps --skip-action-cable --skip-coffee --skip-test'
+  api_test:
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        ruby: [2.7]
+    steps:
+    - uses: actions/checkout@v2
+    - name: Set up Ruby
+      uses: ruby/setup-ruby@v1
+      with:
+        ruby-version: ${{ matrix.ruby }}
+    - name: Install dependencies
+      run: bundle install
+    - name: Run tests
+      run: bundle exec rake ci
+      env:
+        BLACKLIGHT_API_TEST: true
+        ENGINE_CART_RAILS_OPTIONS: '--api --skip-git --skip-bundle --skip-listen --skip-spring --skip-yarn --skip-keeps --skip-action-cable --skip-coffee --skip-test'
+  docker_build:
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@v2
+    - name: Build docker image
+      run: docker-compose build app

data/.rubocop.yml

@@ -29,6 +29,7 @@ Layout/IndentationConsistency:
 Metrics/BlockLength:
   Exclude:
     - "app/views/catalog/index.json.jbuilder"
+    - "app/views/catalog/_document.atom.builder"
     - "lib/railties/blacklight.rake"
     - "tasks/blacklight.rake"
     - "spec/**/*"
@@ -36,12 +37,19 @@ Metrics/BlockLength:
 Metrics/ClassLength:
   Exclude:
     - "lib/blacklight/configuration.rb"
+    - "lib/blacklight/search_builder.rb"
+    - "lib/blacklight/search_state.rb"
 
 Layout/LineLength:
   Max: 200
   Exclude:
     - 'spec/**/*'
 
+Metrics/ModuleLength:
+  Exclude:
+    - 'app/controllers/concerns/blacklight/catalog.rb'
+    - 'lib/blacklight/solr/search_builder_behavior.rb'
+
 Naming/HeredocDelimiterNaming:
   Enabled: false
 
@@ -57,6 +65,9 @@ Naming/PredicateName:
 Rails:
   Enabled: true
 
+Rails/ApplicationMailer:
+  Enabled: false
+
 # https://github.com/rubocop-hq/rubocop/issues/6439
 Style/AccessModifierDeclarations:
   Enabled: false

data/.solr_wrapper.yml

@@ -0,0 +1,5 @@
+# Place any default configuration for solr_wrapper here
+# port: 8983
+collection:
+  dir: lib/generators/blacklight/templates/solr/conf
+  name: blacklight-core

data/VERSION

@@ -1 +1 @@
-7.11.1
+7.13.2

data/app/builders/blacklight/action_builder.rb

@@ -4,6 +4,12 @@ module Blacklight
   # Dynamically creates methods on the given controller (typically CatalogController)
   # for handling configured show tools
   class ActionBuilder
+    # @param [Object] klass
+    # @param [String] name
+    # @param [Hash] opts
+    # @option opts [Symbol] callback
+    # @option opts [Symbol] validator
+    # @option opts [Boolean] define_method
     def initialize(klass, name, opts)
       @klass = klass
       @name = name

data/app/components/blacklight/constraint_component.html.erb

@@ -0,0 +1,5 @@
+<%= render(@layout.new(
+      classes: (Array(@classes) + ["filter-#{@facet_item_presenter.facet_config.key.parameterize}"]).join(' '),
+      label: @facet_item_presenter.field_label,
+      value: @facet_item_presenter.label,
+      remove_path: @facet_item_presenter.remove_href)) %>

data/app/components/blacklight/constraint_component.rb

@@ -0,0 +1,13 @@
+# frozen_string_literal: true
+
+module Blacklight
+  class ConstraintComponent < ::ViewComponent::Base
+    with_collection_parameter :facet_item_presenter
+
+    def initialize(facet_item_presenter:, classes: 'filter', layout: Blacklight::ConstraintLayoutComponent)
+      @facet_item_presenter = facet_item_presenter
+      @classes = classes
+      @layout = layout
+    end
+  end
+end

data/app/components/blacklight/constraint_layout_component.rb

@@ -2,11 +2,12 @@
 
 module Blacklight
   class ConstraintLayoutComponent < ::ViewComponent::Base
-    def initialize(value:, label: nil, remove_path: nil, classes: nil)
+    def initialize(value:, label: nil, remove_path: nil, classes: nil, search_state: nil)
       @value = value
       @label = label
       @remove_path = remove_path
       @classes = Array(classes).join(' ')
+      @search_state = search_state
     end
 
     def render?

data/app/components/blacklight/constraints_component.html.erb

@@ -0,0 +1,10 @@
+<%= content_tag :div, id: @id, class: @classes do %>
+  <h2 class="sr-only"><%= t('blacklight.search.search_constraints_header') %></h2>
+
+  <%= link_to t('blacklight.search.start_over'), start_over_path, class: "catalog_startOverLink btn btn-primary" %>
+
+  <span class="constraints-label sr-only"><%= t('blacklight.search.filters.title') %></span>
+  <%= query_constraints_area || query_constraints %>
+  <%= facet_constraints_area || facet_constraints %>
+  <%= additional_constraints %>
+<% end %>

data/app/components/blacklight/constraints_component.rb

@@ -0,0 +1,67 @@
+# frozen_string_literal: true
+
+module Blacklight
+  class ConstraintsComponent < ::ViewComponent::Base
+    with_content_areas :query_constraints_area, :facet_constraints_area, :additional_constraints
+
+    def initialize(search_state:,
+                   id: 'appliedParams', classes: 'clearfix constraints-container',
+                   query_constraint_component: Blacklight::ConstraintLayoutComponent, facet_constraint_component: Blacklight::ConstraintComponent)
+      @search_state = search_state
+      @query_constraint_component = query_constraint_component
+      @facet_constraint_component = facet_constraint_component
+      @id = id
+      @classes = classes
+    end
+
+    def query_constraints
+      return if @search_state.query_param.blank?
+
+      Deprecation.silence(Blacklight::RenderConstraintsHelperBehavior) do
+        @view_context.render(
+          @query_constraint_component.new(
+            search_state: @search_state,
+            value: @search_state.query_param,
+            label: @view_context.constraint_query_label(@search_state.params),
+            remove_path: @view_context.remove_constraint_url(@search_state),
+            classes: 'query'
+          )
+        )
+      end
+    end
+
+    def facet_constraints
+      @view_context.render(@facet_constraint_component.with_collection(facet_item_presenters))
+    end
+
+    def start_over_path
+      Deprecation.silence(Blacklight::UrlHelperBehavior) do
+        @view_context.start_over_path
+      end
+    end
+
+    def render?
+      Deprecation.silence(Blacklight::RenderConstraintsHelperBehavior) { @view_context.query_has_constraints? }
+    end
+
+    private
+
+    def facet_item_presenters
+      Deprecation.silence(Blacklight::SearchState) do
+        @search_state.filter_params.each_pair.flat_map do |facet, values|
+          facet_config = @view_context.facet_configuration_for_field(facet)
+
+          Array(values).map do |val|
+            next if val.blank? # skip empty string
+
+            facet_item_presenter(facet_config, val, facet)
+          end
+        end
+      end
+    end
+
+    def facet_item_presenter(facet_config, facet_item, facet_field)
+      Blacklight::FacetItemPresenter.new(facet_item, facet_config, @view_context, facet_field)
+    end
+  end
+end

data/app/components/blacklight/document/action_component.html.erb

@@ -0,0 +1,9 @@
+<% if using_default_document_action? %>
+  <%= link_to label,
+              url,
+              id: @id,
+              class: 'nav-link',
+              data: {}.merge(({ blacklight_modal: "trigger" } if @action.modal != false) || {}) %>
+<% else %>
+  <%= @view_context.render(partial: @action.partial || @action.name.to_s, locals: { document: @document, document_action_config: @action }.merge(@options)) %>
+<% end %>

data/app/components/blacklight/document/action_component.rb

@@ -0,0 +1,38 @@
+# frozen_string_literal: true
+
+module Blacklight
+  module Document
+    # Render a bookmark widget to bookmark / unbookmark a document
+    class ActionComponent < ::ViewComponent::Base
+      with_collection_parameter :action
+
+      # @param [Blacklight::Document] document
+      def initialize(document:, action:, options: {}, url_opts: {}, id: nil)
+        @document = document
+        @action = action
+        @options = options
+        @url_opts = url_opts
+        @id = id || @action.fetch(:id, "#{@action.name}Link")
+      end
+
+      def using_default_document_action?
+        return true if @action.component
+        return false unless @action.partial == 'document_action'
+
+        @view_context.partial_from_blacklight?(@action.partial)
+      end
+
+      def label
+        Deprecation.silence(Blacklight::ComponentHelperBehavior) do
+          @view_context.document_action_label(@action.name, @action)
+        end
+      end
+
+      def url
+        Deprecation.silence(Blacklight::ComponentHelperBehavior) do
+          @view_context.document_action_path(@action, @url_opts.merge(({ id: @document } if @document) || {}))
+        end
+      end
+    end
+  end
+end

data/app/components/blacklight/document/actions_component.html.erb

@@ -0,0 +1,13 @@
+<%= content_tag @tag, class: @classes do %>
+  <% @actions.each do |action| %>
+    <% result = capture { @view_context.render((action.component || Blacklight::Document::ActionComponent).new(action: action, document: @document, options: @options, url_opts: @url_opts)) } %>
+
+    <% if @wrapping_tag %>
+      <%= content_tag(@wrapping_tag, class: Array(@wrapping_classes) + [action.key]) do %>
+        <%= result %>
+      <% end %>
+    <% else %>
+      <%= result %>
+    <% end %>
+  <% end %>
+<% end %>

data/app/components/blacklight/document/actions_component.rb

@@ -0,0 +1,26 @@
+# frozen_string_literal: true
+
+module Blacklight
+  module Document
+    # Render a bookmark widget to bookmark / unbookmark a document
+    class ActionsComponent < ::ViewComponent::Base
+      # @param [Blacklight::Document] document
+      # rubocop:disable Metrics/ParameterLists
+      def initialize(document: nil, actions: [], options: {}, url_opts: nil, tag: :div, classes: 'index-document-functions', wrapping_tag: nil, wrapping_classes: nil)
+        @document = document
+        @actions = actions
+        @tag = tag
+        @classes = classes
+        @options = options
+        @url_opts = url_opts
+        @wrapping_tag = wrapping_tag
+        @wrapping_classes = wrapping_classes
+      end
+      # rubocop:enable Metrics/ParameterLists
+
+      def render?
+        @actions.any?
+      end
+    end
+  end
+end

data/app/components/blacklight/document/bookmark_component.html.erb

@@ -1,7 +1,7 @@
 <%-
 # the data-doc-id attribute is used by our JS that converts to a checkbox/label.
 -%>
-<%= form_tag(@bookmark_path,
+<%= form_tag(bookmark_path,
              method:  bookmarked? ? :delete : :put,
              class: "bookmark-toggle",
              data: {

data/app/components/blacklight/document/bookmark_component.rb

@@ -2,7 +2,11 @@
 
 module Blacklight
   module Document
+    # Render a bookmark widget to bookmark / unbookmark a document
     class BookmarkComponent < ::ViewComponent::Base
+      # @param [Blacklight::Document] document
+      # @param [Boolean] checked
+      # @param [Object] bookmark_path the rails route to use for bookmarks
       def initialize(document:, checked: nil, bookmark_path: nil)
         @document = document
         @checked = checked
@@ -14,6 +18,10 @@ module Blacklight
 
         @view_context.bookmarked? @document
       end
+
+      def bookmark_path
+        @bookmark_path || @view_context.bookmark_path(@document)
+      end
     end
   end
 end

data/app/components/blacklight/document/citation_component.html.erb

@@ -1,9 +1,11 @@
 <div>
   <h1 class="modal-title"><%= title %></h1>
 
-  <%= @formats.each do |i18n_key, citation_method| %>
+  <% @formats.each do |i18n_key, citation_method| %>
     <h2><%= t(i18n_key) %></h2>
     <%= @document.send(citation_method).html_safe %>
-    <% unless @formats.keys.last === i18n_key %><br/><br/><% end %>
+    <% unless @formats.keys.last === i18n_key %>
+      <br/><br/>
+    <% end %>
   <% end %>
 </div>

data/app/components/blacklight/document/citation_component.rb

@@ -2,6 +2,7 @@
 
 module Blacklight
   module Document
+    # Render citations for the document
     class CitationComponent < ::ViewComponent::Base
       DEFAULT_FORMATS = {
         'blacklight.citation.mla': :export_as_mla_citation_txt,
@@ -11,13 +12,19 @@ module Blacklight
 
       with_collection_parameter :document
 
+      # @param [Blacklight::Document] document
+      # @param [Hash<String => Symbol>] map of citation format names (suspiciously, i18n keys
+      #   for them) to document methods that return the formatted citation.
       def initialize(document:, formats: DEFAULT_FORMATS)
         @document = document
         @formats = formats.select { |_k, v| @document.respond_to?(v) }
       end
 
+      # @return [String]
       def title
-        @view_context.document_heading(@document)
+        Deprecation.silence(Blacklight::BlacklightHelperBehavior) do
+          @view_context.document_heading(@document)
+        end
       end
     end
   end