blacklight 7.0.0 → 7.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 85a532b997b308e09d4a8a2e9d32dad2875f6a5a9b47f3b02fcdff79bd237b2e
-  data.tar.gz: d103e0ede5a6c2bfb658ff7ec3dfe049d63aa261d3f8ba2e6f41273702c465cf
+  metadata.gz: 05d5576219e73622cf05af970590c5492d1e7f18a2b1a3654fb26de71d424b64
+  data.tar.gz: 94a2e2b0b64d07b4fe0083df1e7658130c6d9dfba7c3acae4ee5b930a1ceb74c
 SHA512:
-  metadata.gz: dfe1f7f5c84c9643861c8bf0e471190a0f364439c88ed19bc94ec66b52f18bc70092415016759d0118eb8372470fd85d56c775529732c46dbfbf52f0c7d83dbb
-  data.tar.gz: 212410aeded08255f08403d19fea41311426441d442d18dd9f54d451641eae9c93d03f016ca2dbda56aff5a70333ff08ae162bf4b5ca6980bf068666ffc8e636
+  metadata.gz: 9d8fbf65bfad8b2d4dfac62bb3048dfdebca06f4752b6b66bfbfce218afa1b5deef6b7865896056760c1f7265e7d5968ffa3d52511ce49d54004a118191261b9
+  data.tar.gz: f1921d4f36915aa5761788ae8a80ddb1836777c2a6db8613d01987930af30ac8d2a273ccea62ecdbcb502c3716747a4ea551a64cc02b3cda7e1ade71067ddbb2

data/.jshintrc

@@ -1,4 +1,5 @@
 {
+  "asi": true,
   "browser": true,
   "jquery": true,
   "node": true,
@@ -15,6 +16,7 @@
   "unused": true,
   "eqnull": true,
   "predef": [
-    "Blacklight"
+    "Blacklight",
+    "Rails"
   ]
 }

data/.rubocop_todo.yml

@@ -1,12 +1,13 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2018-10-31 21:34:01 -0500 using RuboCop version 0.60.0.
+# on 2019-09-11 10:59:32 -0500 using RuboCop version 0.63.1.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
 # Offense count: 4
+# Cop supports --auto-correct.
 Capybara/CurrentPathExpectation:
   Exclude:
     - 'spec/features/alternate_controller_spec.rb'
@@ -68,11 +69,10 @@ Layout/LeadingCommentSpace:
     - 'app/models/concerns/blacklight/document/export.rb'
     - 'app/views/catalog/_document.atom.builder'
 
-# Offense count: 2
+# Offense count: 1
 # Cop supports --auto-correct.
 Layout/MultilineBlockLayout:
   Exclude:
-    - 'lib/generators/blacklight/install_generator.rb'
     - 'lib/generators/blacklight/test_support_generator.rb'
 
 # Offense count: 2
@@ -126,14 +126,12 @@ Layout/SpaceInsideParens:
     - 'app/views/catalog/_document.rss.builder'
     - 'app/views/catalog/index.atom.builder'
 
-# Offense count: 27
+# Offense count: 1
 # Cop supports --auto-correct.
 # Configuration parameters: AllowInHeredoc.
 Layout/TrailingWhitespace:
   Exclude:
-    - 'app/views/catalog/_document.atom.builder'
     - 'app/views/catalog/_document.rss.builder'
-    - 'app/views/catalog/index.atom.builder'
 
 # Offense count: 1
 Lint/AmbiguousBlockAssociation:
@@ -151,7 +149,7 @@ Lint/AmbiguousOperator:
     - 'spec/models/blacklight/solr/search_builder_spec.rb'
     - 'spec/services/blacklight/search_service_spec.rb'
 
-# Offense count: 58
+# Offense count: 55
 Lint/AmbiguousRegexpLiteral:
   Exclude:
     - 'spec/controllers/catalog_controller_spec.rb'
@@ -187,7 +185,7 @@ Lint/UselessComparison:
   Exclude:
     - 'spec/models/blacklight/document/active_model_shim_spec.rb'
 
-# Offense count: 57
+# Offense count: 58
 Metrics/AbcSize:
   Max: 49
 
@@ -211,7 +209,7 @@ Metrics/ClassLength:
 Metrics/CyclomaticComplexity:
   Max: 12
 
-# Offense count: 46
+# Offense count: 48
 # Configuration parameters: CountComments, ExcludedMethods.
 Metrics/MethodLength:
   Max: 35
@@ -219,7 +217,7 @@ Metrics/MethodLength:
 # Offense count: 8
 # Configuration parameters: CountComments.
 Metrics/ModuleLength:
-  Max: 215
+  Max: 210
 
 # Offense count: 1
 # Configuration parameters: CountKeywordArgs.
@@ -247,15 +245,15 @@ Naming/UncommunicativeMethodParamName:
   Exclude:
     - 'app/models/blacklight/facet_paginator.rb'
     - 'app/models/concerns/blacklight/document.rb'
-    - 'app/models/concerns/blacklight/solr/document.rb'
     - 'app/presenters/blacklight/rendering/link_to_facet.rb'
     - 'lib/blacklight/nested_open_struct_with_hash_access.rb'
     - 'lib/blacklight/search_state.rb'
+    - 'lib/blacklight/solr/document.rb'
     - 'lib/blacklight/solr/search_builder_behavior.rb'
     - 'spec/features/search_context_spec.rb'
     - 'spec/features/search_results_spec.rb'
 
-# Offense count: 15
+# Offense count: 16
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: snake_case, normalcase, non_integer
 Naming/VariableNumber:
@@ -271,11 +269,10 @@ Performance/TimesMap:
   Exclude:
     - 'spec/views/catalog/index.atom.builder_spec.rb'
 
-# Offense count: 3
+# Offense count: 2
 Performance/UnfreezeString:
   Exclude:
     - 'lib/generators/blacklight/install_generator.rb'
-    - 'spec/helpers/blacklight/url_helper_behavior_spec.rb'
     - 'spec/helpers/blacklight_helper_spec.rb'
 
 # Offense count: 9
@@ -293,7 +290,7 @@ RSpec/BeforeAfterAll:
     - 'spec/models/blacklight/document/sms_spec.rb'
     - 'spec/models/blacklight/solr/document_spec.rb'
 
-# Offense count: 70
+# Offense count: 71
 # Configuration parameters: Prefixes.
 # Prefixes: when, with, without
 RSpec/ContextWording:
@@ -309,7 +306,7 @@ RSpec/EmptyExampleGroup:
   Exclude:
     - 'spec/models/blacklight/solr/search_builder_spec.rb'
 
-# Offense count: 126
+# Offense count: 127
 # Configuration parameters: Max.
 RSpec/ExampleLength:
   Enabled: false
@@ -333,7 +330,7 @@ RSpec/FilePath:
     - 'spec/presenters/pipeline_spec.rb'
     - 'spec/presenters/thumbnail_presenter_spec.rb'
 
-# Offense count: 194
+# Offense count: 196
 # Configuration parameters: AssignmentOnly.
 RSpec/InstanceVariable:
   Enabled: false
@@ -345,6 +342,18 @@ RSpec/IteratedExpectation:
     - 'spec/models/blacklight/solr/response/group_spec.rb'
     - 'spec/models/blacklight/solr/response_spec.rb'
 
+# Offense count: 17
+RSpec/LeakyConstantDeclaration:
+  Exclude:
+    - 'spec/controllers/blacklight/search_fields_spec.rb'
+    - 'spec/controllers/bookmarks_controller_spec.rb'
+    - 'spec/controllers/catalog_controller_spec.rb'
+    - 'spec/models/blacklight/configurable_spec.rb'
+    - 'spec/models/blacklight/document/active_model_shim_spec.rb'
+    - 'spec/models/blacklight/document_spec.rb'
+    - 'spec/models/blacklight/solr/document_spec.rb'
+    - 'spec/presenters/blacklight/show_presenter_spec.rb'
+
 # Offense count: 8
 RSpec/MessageChain:
   Exclude:
@@ -352,18 +361,33 @@ RSpec/MessageChain:
     - 'spec/presenters/blacklight/show_presenter_spec.rb'
     - 'spec/views/shared/_user_util_links.html.erb_spec.rb'
 
-# Offense count: 62
-# Configuration parameters: .
+# Offense count: 67
+# Configuration parameters: EnforcedStyle.
 # SupportedStyles: have_received, receive
 RSpec/MessageSpies:
-  Enabled: false
+  Exclude:
+    - 'spec/controllers/catalog_controller_spec.rb'
+    - 'spec/helpers/blacklight/configuration_helper_behavior_spec.rb'
+    - 'spec/helpers/blacklight/facets_helper_behavior_spec.rb'
+    - 'spec/helpers/blacklight/render_constraints_helper_behavior_spec.rb'
+    - 'spec/helpers/blacklight/suggest_helper_behavior_spec.rb'
+    - 'spec/helpers/blacklight/url_helper_behavior_spec.rb'
+    - 'spec/helpers/blacklight_helper_spec.rb'
+    - 'spec/helpers/catalog_helper_spec.rb'
+    - 'spec/lib/blacklight/configuration/facet_field_spec.rb'
+    - 'spec/models/blacklight/search_builder_spec.rb'
+    - 'spec/models/blacklight/suggest_search_spec.rb'
+    - 'spec/presenters/blacklight/index_presenter_spec.rb'
+    - 'spec/presenters/blacklight/show_presenter_spec.rb'
+    - 'spec/presenters/thumbnail_presenter_spec.rb'
 
-# Offense count: 339
+# Offense count: 346
 # Configuration parameters: AggregateFailuresByDefault.
 RSpec/MultipleExpectations:
   Max: 16
 
-# Offense count: 326
+# Offense count: 332
+# Configuration parameters: IgnoreSharedExamples.
 RSpec/NamedSubject:
   Enabled: false
 
@@ -392,13 +416,14 @@ RSpec/ScatteredLet:
     - 'spec/models/blacklight/solr/search_builder_spec.rb'
     - 'spec/views/catalog/index.atom.builder_spec.rb'
 
-# Offense count: 4
+# Offense count: 10
 RSpec/SubjectStub:
   Exclude:
     - 'spec/lib/blacklight/search_state_spec.rb'
+    - 'spec/models/blacklight/search_builder_spec.rb'
     - 'spec/services/blacklight/search_service_spec.rb'
 
-# Offense count: 117
+# Offense count: 119
 # Configuration parameters: IgnoreNameless, IgnoreSymbolicNames.
 RSpec/VerifiedDoubles:
   Enabled: false
@@ -408,13 +433,6 @@ RSpec/VoidExpect:
   Exclude:
     - 'spec/lib/blacklight/configuration/facet_field_spec.rb'
 
-# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: NilOrEmpty, NotPresent, UnlessPresent.
-Rails/Blank:
-  Exclude:
-    - 'lib/blacklight/solr/search_builder_behavior.rb'
-
 # Offense count: 4
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: strict, flexible
@@ -422,18 +440,6 @@ Rails/Date:
   Exclude:
     - 'spec/models/search_spec.rb'
 
-# Offense count: 13
-# Cop supports --auto-correct.
-# Configuration parameters: NotNilAndNotEmpty, NotBlank, UnlessBlank.
-Rails/Present:
-  Exclude:
-    - 'app/controllers/concerns/blacklight/catalog.rb'
-    - 'app/helpers/blacklight/component_helper_behavior.rb'
-    - 'app/helpers/blacklight/facets_helper_behavior.rb'
-    - 'app/models/concerns/blacklight/document/email.rb'
-    - 'app/models/concerns/blacklight/document/sms.rb'
-    - 'lib/blacklight/solr/search_builder_behavior.rb'
-
 # Offense count: 1
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: strict, flexible
@@ -481,7 +487,7 @@ Style/BracesAroundHashParameters:
     - 'lib/blacklight/solr/response/facets.rb'
     - 'lib/generators/blacklight/test_support_generator.rb'
 
-# Offense count: 50
+# Offense count: 51
 # Cop supports --auto-correct.
 # Configuration parameters: AutoCorrect, EnforcedStyle.
 # SupportedStyles: nested, compact
@@ -502,13 +508,7 @@ Style/ConditionalAssignment:
   Exclude:
     - 'lib/blacklight/solr/response/spelling.rb'
 
-# Offense count: 1
-# Configuration parameters: AllowCoercion.
-Style/DateTime:
-  Exclude:
-    - 'spec/models/blacklight/solr/search_builder_spec.rb'
-
-# Offense count: 93
+# Offense count: 94
 Style/Documentation:
   Enabled: false
 
@@ -548,15 +548,7 @@ Style/GuardClause:
     - 'app/helpers/blacklight/catalog_helper_behavior.rb'
     - 'lib/blacklight/solr/search_builder_behavior.rb'
 
-# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, UseHashRocketsWithSymbolValues, PreferHashRocketsForNonAlnumEndingSymbols.
-# SupportedStyles: ruby19, hash_rockets, no_mixed_keys, ruby19_no_mixed_keys
-Style/HashSyntax:
-  Exclude:
-    - 'app/helpers/blacklight/url_helper_behavior.rb'
-
-# Offense count: 39
+# Offense count: 40
 # Cop supports --auto-correct.
 Style/IfUnlessModifier:
   Enabled: false
@@ -595,9 +587,9 @@ Style/NumericPredicate:
   Exclude:
     - 'spec/**/*'
     - 'app/helpers/blacklight/catalog_helper_behavior.rb'
-    - 'app/models/blacklight/solr/facet_paginator.rb'
     - 'app/services/blacklight/search_service.rb'
     - 'lib/blacklight/search_builder.rb'
+    - 'lib/blacklight/solr/facet_paginator.rb'
     - 'lib/blacklight/solr/response/facets.rb'
     - 'lib/blacklight/solr/search_builder_behavior.rb'
     - 'lib/railties/blacklight.rake'
@@ -652,7 +644,7 @@ Style/Semicolon:
     - 'spec/models/blacklight/solr/repository_spec.rb'
     - 'spec/views/catalog/_paginate_compact.html.erb_spec.rb'
 
-# Offense count: 32
+# Offense count: 31
 # Cop supports --auto-correct.
 # Configuration parameters: MinSize.
 # SupportedStyles: percent, brackets

data/.travis.yml

@@ -1,4 +1,4 @@
-dist: trusty
+dist: bionic
 addons:
   chrome: stable
 language: ruby
@@ -8,25 +8,26 @@ notifications:
 
 matrix:
   include:
-    - rvm: 2.5.3
-      env: "RAILS_VERSION=5.1.6"
-    - rvm: 2.4.5
-      env: "RAILS_VERSION=5.2.1"
-    - rvm: 2.5.3
-      env: "RAILS_VERSION=5.2.1 BLACKLIGHT_API_TEST=true ENGINE_CART_RAILS_OPTIONS=\"--api --skip-git --skip-bundle --skip-listen --skip-spring --skip-yarn --skip-keeps --skip-action-cable --skip-coffee --skip-test\""
-    - rvm: 2.4.5
-      env: "RAILS_VERSION=5.1.6"
-    - rvm: 2.3.8
-      env: "RAILS_VERSION=5.2.1"
-    - rvm: jruby-9.2.0.0
-      env: "RAILS_VERSION=5.1.6 JRUBY_OPTS=\"-J-Xms512m -J-Xmx1024m\""
+    - rvm: 2.6.5
+      env: "RAILS_VERSION=6.0.0 ENGINE_CART_RAILS_OPTIONS=\"--skip-webpack-install\""
+    - rvm: 2.6.5
+      env: "RAILS_VERSION=5.2.3"
+    - rvm: 2.5.7
+      env: "RAILS_VERSION=5.1.7"
+    - rvm: 2.5.7
+      env: "RAILS_VERSION=5.2.3 BLACKLIGHT_API_TEST=true ENGINE_CART_RAILS_OPTIONS=\"--api --skip-git --skip-bundle --skip-listen --skip-spring --skip-yarn --skip-keeps --skip-action-cable --skip-coffee --skip-test\""
+    - rvm: 2.4.9
+      env: "RAILS_VERSION=5.1.7"
+    - rvm: jruby-9.2.8.0
+      env: "RAILS_VERSION=5.1.7 JRUBY_OPTS=\"-J-Xms512m -J-Xmx1024m\""
   allow_failures:
-    - rvm: jruby-9.2.0.0
+    - rvm: jruby-9.2.8.0
   fast_finish: true
 
 before_install:
-  - gem update --system
-  - gem install bundler
+  - docker pull solr:7
+  - docker run -d -p 8983:8983 -v $PWD/lib/generators/blacklight/templates/solr/conf:/myconfig solr:7 solr-create -c blacklight-core -d /myconfig
+  - docker ps -a
   - google-chrome-stable --headless --disable-gpu --no-sandbox --remote-debugging-port=9222 http://localhost &
 
 notifications:
@@ -36,10 +37,10 @@ notifications:
 
 global_env:
   - NOKOGIRI_USE_SYSTEM_LIBRARIES=true
-  - ENGINE_CART_RAILS_OPTIONS='--skip-git --skip-bundle --skip-listen --skip-spring --skip-yarn --skip-keeps --skip-action-cable --skip-coffee --skip-test'
+  - ENGINE_CART_RAILS_OPTIONS='--skip-git --skip-listen --skip-spring --skip-keeps --skip-action-cable --skip-coffee --skip-test'
   - CC_TEST_REPORTER_ID=5042c7358c96b0b926088a4cda3e132fffe7a66ce8047cdb1dc6f0b4b6676b79
 
-jdk: oraclejdk9
+jdk: openjdk11
 
 before_script:
   - curl -L https://codeclimate.com/downloads/test-reporter/test-reporter-latest-linux-amd64 > ./cc-test-reporter

data/CONTRIBUTING.md

@@ -0,0 +1,50 @@
+# Contributing to Blacklight
+
+Blacklight is a collaborative, open source project produced by developers from many diverse  organizations. The Blacklight developers want to create an out-of-the-box framework that is easy to install and get started with, both as a service to the community and in the interests of our own institutions in creating a sustainable project and product.
+
+Development is largely motivated by the needs of each developer’s organization, and we work on the shared project together so we can benefit from the community’s development efforts, experiences building discovery systems, and shared problem solving.
+
+We always welcome contributions from the community, especially to add new features, address bugs or defects, and clarify existing code for future developers.
+
+## Adding a ticket
+Let us know you're interested in working on a feature by filing a ticket in our [issue tracker](https://github.com/projectblacklight/blacklight/issues).
+
+## Making Your Changes
+
+* Fork the project
+* Start a feature/bugfix branch
+* Commit and push until you are happy with your contribution
+* Make sure to add tests for it. This is important so we don't break it in a future version unintentionally.
+* After making your changes, be sure to run the [Blacklight tests](https://github.com/projectblacklight/blacklight/wiki/testing) to make sure everything works.
+* Submit your change as a [Pull Request](https://help.github.com/en/articles/about-pull-requests).
+
+## Pull Requests and Code Review
+- Pull requests must be reviewed and approved by one non-author with write-permissions
+- If additional code changes are made after approval, another approval (from the same or another qualified person) is required.
+- A reviewer who has approved a PR but has not merged it should provide a comment (e.g. "This looks good, I'm just waiting for Travis to build", "This is a breaking change. I would like at least one more reviewer.")
+- An approved PR may be merged by the reviewer, the author, or another committer
+- Additional discussion and feedback by non-maintainers is heartily encouraged.
+
+## Support
+If you are interested in working on the Blacklight plugin, but want guidance or support, please send an email to our [Blacklight-development mailing list](http://groups.google.com/group/blacklight-development) and we'll be glad to help. The #blacklight channel on [code4lib Slack](https://code4lib.org/irc/) is another active forum for informal discussion and troubleshooting.
+
+## Becoming a Committer
+
+Anyone can contribute to Blacklight using pull requests, the issue tracker, and being active on the mailing list and IRC channels. Being a contributor means that you take an active interest in the project and contribute regularly in some way, ranging from asking sensible questions (which documents the project and provides feedback to developers) to providing new features as patches.
+
+If you become a valuable contributor to the project you may be invited to become a committer.  Blacklight code contributors become committers after being sponsored by one of the current active committers.  The committers will take an Apache-style (+1/0/-1) vote to elevate them, and then a formal invitation will be extended to the contributor.
+
+Committers should be:
+
+- technically adept
+- constructive, positive members of the Blacklight software community
+- committed to producing useful, practical code for the community
+
+You're expected to:
+
+- contribute patches and new functionality to Blacklight and other shared development efforts (RSolr, Blacklight plugins, etc)
+- actively participate in technical discussions on the email list, IRC, and github
+- answer user support questions via the various channels
+- review pull requests from fellow committers and the community
+- test-drive new release candidates against your own institution's Blacklight applications
+- participate in regular committer meetings, usually in the form of conference calls, to coordinate development & direction

data/Gemfile

@@ -34,6 +34,8 @@ else
   end
 
   case ENV['RAILS_VERSION']
+  when /^5.[12]/, /^6.0/
+    gem 'sass-rails', '~> 5.0'
   when /^4.2/
     gem 'responders', '~> 2.0'
     gem 'sass-rails', '>= 5.0'

data/VERSION

@@ -1 +1 @@
-7.0.0
+7.4.0