blacklight 6.24.0 → 7.0.0.rc1

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (393) hide show
  1. checksums.yaml +4 -4
  2. data/.gitignore +1 -0
  3. data/.npmignore +23 -0
  4. data/.rubocop.yml +15 -3
  5. data/.rubocop_todo.yml +242 -379
  6. data/.solr_wrapper.yml +1 -1
  7. data/.travis.yml +20 -24
  8. data/Gemfile +1 -4
  9. data/README.md +21 -4
  10. data/Rakefile +1 -2
  11. data/VERSION +1 -1
  12. data/app/assets/images/blacklight/list.svg +1 -0
  13. data/app/assets/images/blacklight/search.svg +1 -0
  14. data/app/assets/javascripts/blacklight/blacklight.js +496 -56
  15. data/app/assets/stylesheets/blacklight/_balanced_list.scss +7 -12
  16. data/app/assets/stylesheets/blacklight/_blacklight_base.scss +3 -1
  17. data/app/assets/stylesheets/blacklight/_bookmark.scss +1 -13
  18. data/app/assets/stylesheets/blacklight/_bootstrap_overrides.scss +27 -0
  19. data/app/assets/stylesheets/blacklight/_constraints.scss +17 -25
  20. data/app/assets/stylesheets/blacklight/_controls.scss +8 -16
  21. data/app/assets/stylesheets/blacklight/_facets.scss +74 -92
  22. data/app/assets/stylesheets/blacklight/_header.scss +35 -48
  23. data/app/assets/stylesheets/blacklight/_icons.scss +29 -0
  24. data/app/assets/stylesheets/blacklight/_layout.scss +0 -10
  25. data/app/assets/stylesheets/blacklight/_mixins.scss +15 -0
  26. data/app/assets/stylesheets/blacklight/_modal.scss +9 -17
  27. data/app/assets/stylesheets/blacklight/_pagination.scss +2 -17
  28. data/app/assets/stylesheets/blacklight/_search_history.scss +5 -13
  29. data/app/assets/stylesheets/blacklight/_search_results.scss +9 -8
  30. data/app/assets/stylesheets/blacklight/_twitter_typeahead.scss +1 -2
  31. data/app/builders/blacklight/action_builder.rb +56 -0
  32. data/app/controllers/bookmarks_controller.rb +2 -2
  33. data/app/controllers/catalog_controller.rb +2 -2
  34. data/app/controllers/concerns/blacklight/base.rb +0 -33
  35. data/app/controllers/concerns/blacklight/bookmarks.rb +20 -37
  36. data/app/controllers/concerns/blacklight/catalog.rb +254 -213
  37. data/app/controllers/concerns/blacklight/controller.rb +117 -133
  38. data/app/controllers/concerns/blacklight/default_component_configuration.rb +12 -43
  39. data/app/controllers/concerns/blacklight/search_context.rb +10 -14
  40. data/app/controllers/concerns/blacklight/search_fields.rb +4 -14
  41. data/app/controllers/concerns/blacklight/token_based_user.rb +6 -10
  42. data/app/helpers/blacklight/blacklight_helper_behavior.rb +32 -118
  43. data/app/helpers/blacklight/catalog_helper_behavior.rb +94 -88
  44. data/app/helpers/blacklight/component_helper_behavior.rb +19 -19
  45. data/app/helpers/blacklight/configuration_helper_behavior.rb +25 -54
  46. data/app/helpers/blacklight/facets_helper_behavior.rb +40 -39
  47. data/app/helpers/blacklight/hash_as_hidden_fields_helper_behavior.rb +9 -11
  48. data/app/helpers/blacklight/icon_helper_behavior.rb +16 -0
  49. data/app/helpers/blacklight/layout_helper_behavior.rb +3 -10
  50. data/app/helpers/blacklight/render_constraints_helper_behavior.rb +6 -6
  51. data/app/helpers/blacklight/render_partials_helper_behavior.rb +195 -0
  52. data/app/helpers/blacklight/search_history_constraints_helper_behavior.rb +18 -11
  53. data/app/helpers/blacklight/suggest_helper_behavior.rb +1 -0
  54. data/app/helpers/blacklight/url_helper_behavior.rb +21 -27
  55. data/app/{assets/javascripts → javascript}/blacklight/autocomplete.js +3 -2
  56. data/app/javascript/blacklight/autofocus.js +20 -0
  57. data/app/javascript/blacklight/bookmark_toggle.js +25 -0
  58. data/app/javascript/blacklight/checkbox_submit.js +133 -0
  59. data/app/{assets/javascripts → javascript}/blacklight/collapsable.js +1 -1
  60. data/app/javascript/blacklight/core.js +39 -0
  61. data/app/{assets/javascripts → javascript}/blacklight/facet_load.js +6 -6
  62. data/app/{assets/javascripts/blacklight/ajax_modal.js → javascript/blacklight/modal.js} +63 -63
  63. data/app/{assets/javascripts → javascript}/blacklight/search_context.js +10 -2
  64. data/app/models/blacklight/facet_paginator.rb +3 -3
  65. data/app/models/blacklight/icon.rb +53 -0
  66. data/app/models/blacklight/solr/facet_paginator.rb +3 -3
  67. data/app/models/blacklight/suggest_search.rb +15 -4
  68. data/app/models/bookmark.rb +4 -9
  69. data/app/models/concerns/blacklight/configurable.rb +13 -13
  70. data/app/models/concerns/blacklight/document.rb +8 -42
  71. data/app/models/concerns/blacklight/document/active_model_shim.rb +8 -11
  72. data/app/models/concerns/blacklight/document/cache_key.rb +1 -1
  73. data/app/models/concerns/blacklight/document/dublin_core.rb +2 -2
  74. data/app/models/concerns/blacklight/document/email.rb +1 -1
  75. data/app/models/concerns/blacklight/document/extensions.rb +5 -5
  76. data/app/models/concerns/blacklight/document/semantic_fields.rb +9 -9
  77. data/app/models/concerns/blacklight/document/sms.rb +1 -1
  78. data/app/models/concerns/blacklight/solr/document.rb +7 -8
  79. data/app/models/concerns/blacklight/suggest/response.rb +3 -5
  80. data/app/models/concerns/blacklight/user.rb +6 -6
  81. data/app/models/record_mailer.rb +5 -6
  82. data/app/models/search.rb +4 -7
  83. data/app/presenters/blacklight/field_presenter.rb +5 -5
  84. data/app/presenters/blacklight/index_presenter.rb +34 -71
  85. data/app/presenters/blacklight/json_presenter.rb +7 -4
  86. data/app/presenters/blacklight/link_alternate_presenter.rb +1 -1
  87. data/app/presenters/blacklight/rendering/abstract_step.rb +5 -5
  88. data/app/presenters/blacklight/rendering/helper_method.rb +8 -8
  89. data/app/presenters/blacklight/rendering/join.rb +3 -3
  90. data/app/presenters/blacklight/rendering/link_to_facet.rb +19 -19
  91. data/app/presenters/blacklight/rendering/microdata.rb +3 -3
  92. data/app/presenters/blacklight/rendering/pipeline.rb +5 -5
  93. data/app/presenters/blacklight/search_bar_presenter.rb +37 -0
  94. data/app/presenters/blacklight/show_presenter.rb +20 -69
  95. data/app/presenters/blacklight/thumbnail_presenter.rb +72 -0
  96. data/app/services/blacklight/document_factory.rb +11 -0
  97. data/app/services/blacklight/field_retriever.rb +24 -24
  98. data/app/services/blacklight/search_service.rb +154 -0
  99. data/app/views/blacklight/nav/_bookmark.html.erb +2 -2
  100. data/app/views/blacklight/nav/_search_history.html.erb +1 -1
  101. data/app/views/bookmarks/_tools.html.erb +2 -2
  102. data/app/views/bookmarks/index.html.erb +2 -2
  103. data/app/views/catalog/_bookmark_control.html.erb +26 -10
  104. data/app/views/catalog/_citation.html.erb +18 -23
  105. data/app/views/catalog/_constraints.html.erb +5 -8
  106. data/app/views/catalog/_constraints_element.html.erb +6 -6
  107. data/app/views/catalog/{_document_default.atom.builder → _document.atom.builder} +2 -2
  108. data/app/views/catalog/_document.html.erb +5 -3
  109. data/app/views/catalog/{_document_default.rss.builder → _document.rss.builder} +0 -0
  110. data/app/views/catalog/_document_action.html.erb +2 -1
  111. data/app/views/catalog/_email_form.html.erb +8 -4
  112. data/app/views/catalog/_facet_index_navigation.html.erb +3 -3
  113. data/app/views/catalog/_facet_layout.html.erb +5 -7
  114. data/app/views/catalog/_facet_limit.html.erb +3 -2
  115. data/app/views/catalog/_facet_pagination.html.erb +10 -10
  116. data/app/views/catalog/_facet_pivot.html.erb +2 -2
  117. data/app/views/catalog/_facets.html.erb +8 -12
  118. data/app/views/catalog/{_group_default.html.erb → _group.html.erb} +0 -0
  119. data/app/views/catalog/_home_text.html.erb +32 -36
  120. data/app/views/catalog/_index.html.erb +12 -0
  121. data/app/views/catalog/{_index_header_default.html.erb → _index_header.html.erb} +2 -2
  122. data/app/views/catalog/_per_page_widget.html.erb +6 -7
  123. data/app/views/catalog/_previous_next_doc.html.erb +6 -14
  124. data/app/views/catalog/_search_form.html.erb +12 -8
  125. data/app/views/catalog/_search_header.html.erb +0 -3
  126. data/app/views/catalog/_search_results.html.erb +4 -0
  127. data/app/views/catalog/_show.html.erb +10 -0
  128. data/app/views/catalog/{_show_header_default.html.erb → _show_header.html.erb} +0 -0
  129. data/app/views/catalog/_show_main_content.html.erb +4 -4
  130. data/app/views/catalog/_show_sidebar.html.erb +3 -3
  131. data/app/views/catalog/_show_tools.html.erb +9 -11
  132. data/app/views/catalog/_sms_form.html.erb +8 -4
  133. data/app/views/catalog/_sort_and_per_page.html.erb +3 -3
  134. data/app/views/catalog/_sort_widget.html.erb +7 -7
  135. data/app/views/catalog/_thumbnail.html.erb +5 -0
  136. data/app/views/catalog/_view_type_group.html.erb +2 -2
  137. data/app/views/catalog/citation.html.erb +1 -1
  138. data/app/views/catalog/citation.js.erb +9 -1
  139. data/app/views/catalog/email.html.erb +5 -5
  140. data/app/views/catalog/email_success.html.erb +11 -9
  141. data/app/views/catalog/facet.html.erb +5 -6
  142. data/app/views/catalog/index.atom.builder +10 -15
  143. data/app/views/catalog/index.html.erb +9 -11
  144. data/app/views/catalog/index.json.jbuilder +65 -3
  145. data/app/views/catalog/index.rss.builder +5 -5
  146. data/app/views/catalog/opensearch.xml.builder +10 -10
  147. data/app/views/catalog/show.html.erb +11 -6
  148. data/app/views/catalog/sms.html.erb +2 -3
  149. data/app/views/catalog/sms_success.html.erb +11 -10
  150. data/app/views/kaminari/blacklight/_first_page.html.erb +2 -2
  151. data/app/views/kaminari/blacklight/_gap.html.erb +2 -2
  152. data/app/views/kaminari/blacklight/_last_page.html.erb +2 -2
  153. data/app/views/kaminari/blacklight/_next_page.html.erb +4 -4
  154. data/app/views/kaminari/blacklight/_page.html.erb +3 -3
  155. data/app/views/kaminari/blacklight/_prev_page.html.erb +4 -4
  156. data/app/views/kaminari/blacklight_compact/_paginator.html.erb +4 -4
  157. data/app/views/layouts/blacklight.html.erb +14 -41
  158. data/app/views/layouts/blacklight/base.html.erb +43 -0
  159. data/app/views/layouts/catalog_result.html.erb +11 -0
  160. data/app/views/search_history/index.html.erb +16 -21
  161. data/app/views/{_flash_msg.html.erb → shared/_flash_msg.html.erb} +0 -0
  162. data/app/views/shared/_header_navbar.html.erb +8 -13
  163. data/app/views/shared/_modal.html.erb +6 -0
  164. data/app/views/shared/_user_util_links.html.erb +22 -0
  165. data/blacklight.gemspec +10 -11
  166. data/config/locales/blacklight.de.yml +0 -30
  167. data/config/locales/blacklight.en.yml +1 -27
  168. data/config/locales/blacklight.es.yml +0 -30
  169. data/config/locales/blacklight.fr.yml +0 -30
  170. data/config/locales/blacklight.hu.yml +210 -0
  171. data/config/locales/blacklight.it.yml +0 -30
  172. data/config/locales/blacklight.nl.yml +210 -0
  173. data/config/locales/blacklight.pt-BR.yml +6 -32
  174. data/config/locales/blacklight.sq.yml +1 -28
  175. data/config/locales/blacklight.zh.yml +0 -25
  176. data/config/routes.rb +3 -10
  177. data/db/migrate/20140202020202_create_bookmarks.rb +0 -1
  178. data/db/migrate/20140320000000_add_polymorphic_type_to_bookmarks.rb +1 -1
  179. data/lib/blacklight.rb +4 -5
  180. data/lib/blacklight/abstract_repository.rb +9 -21
  181. data/lib/blacklight/configuration.rb +82 -89
  182. data/lib/blacklight/configuration/context.rb +1 -1
  183. data/lib/blacklight/configuration/facet_field.rb +16 -9
  184. data/lib/blacklight/configuration/field.rb +32 -3
  185. data/lib/blacklight/configuration/fields.rb +41 -48
  186. data/lib/blacklight/configuration/search_field.rb +2 -2
  187. data/lib/blacklight/configuration/sort_field.rb +2 -2
  188. data/lib/blacklight/configuration/view_config.rb +4 -0
  189. data/lib/blacklight/engine.rb +6 -10
  190. data/lib/blacklight/exceptions.rb +4 -7
  191. data/lib/blacklight/nested_open_struct_with_hash_access.rb +107 -0
  192. data/lib/blacklight/open_struct_with_hash_access.rb +49 -0
  193. data/lib/blacklight/parameters.rb +1 -1
  194. data/lib/blacklight/routes/searchable.rb +1 -0
  195. data/lib/blacklight/search_builder.rb +26 -35
  196. data/lib/blacklight/search_state.rb +8 -8
  197. data/lib/blacklight/solr/repository.rb +3 -36
  198. data/lib/blacklight/solr/request.rb +1 -1
  199. data/lib/blacklight/solr/response.rb +29 -30
  200. data/lib/blacklight/solr/response/facets.rb +29 -31
  201. data/lib/blacklight/solr/response/group.rb +3 -3
  202. data/lib/blacklight/solr/response/group_response.rb +1 -1
  203. data/lib/blacklight/solr/response/more_like_this.rb +2 -2
  204. data/lib/blacklight/solr/response/response.rb +2 -2
  205. data/lib/blacklight/solr/response/spelling.rb +3 -3
  206. data/lib/blacklight/solr/search_builder_behavior.rb +25 -29
  207. data/lib/blacklight/version.rb +1 -1
  208. data/lib/generators/blacklight/assets_generator.rb +8 -8
  209. data/lib/generators/blacklight/controller_generator.rb +4 -5
  210. data/lib/generators/blacklight/document_generator.rb +1 -1
  211. data/lib/generators/blacklight/install_generator.rb +18 -21
  212. data/lib/generators/blacklight/search_builder_generator.rb +1 -1
  213. data/lib/generators/blacklight/{solr5_generator.rb → solr_generator.rb} +4 -6
  214. data/lib/generators/blacklight/templates/.solr_wrapper.yml +5 -0
  215. data/lib/generators/blacklight/templates/blacklight.scss +0 -2
  216. data/lib/generators/blacklight/templates/catalog_controller.rb +52 -51
  217. data/{solr → lib/generators/blacklight/templates/solr}/conf/_rest_managed.json +0 -0
  218. data/{solr → lib/generators/blacklight/templates/solr}/conf/admin-extra.html +0 -0
  219. data/{solr → lib/generators/blacklight/templates/solr}/conf/elevate.xml +0 -0
  220. data/{solr → lib/generators/blacklight/templates/solr}/conf/mapping-ISOLatin1Accent.txt +0 -0
  221. data/{solr → lib/generators/blacklight/templates/solr}/conf/protwords.txt +0 -0
  222. data/lib/generators/blacklight/templates/solr/conf/schema.xml +390 -0
  223. data/{solr → lib/generators/blacklight/templates/solr}/conf/scripts.conf +0 -0
  224. data/lib/generators/blacklight/templates/solr/conf/solrconfig.xml +195 -0
  225. data/{solr → lib/generators/blacklight/templates/solr}/conf/spellings.txt +0 -0
  226. data/{solr → lib/generators/blacklight/templates/solr}/conf/stopwords.txt +0 -0
  227. data/{solr → lib/generators/blacklight/templates/solr}/conf/stopwords_en.txt +0 -0
  228. data/{solr → lib/generators/blacklight/templates/solr}/conf/synonyms.txt +0 -0
  229. data/{solr → lib/generators/blacklight/templates/solr}/conf/xslt/example.xsl +0 -0
  230. data/{solr → lib/generators/blacklight/templates/solr}/conf/xslt/example_atom.xsl +0 -0
  231. data/{solr → lib/generators/blacklight/templates/solr}/conf/xslt/example_rss.xsl +0 -0
  232. data/{solr → lib/generators/blacklight/templates/solr}/conf/xslt/luke.xsl +0 -0
  233. data/lib/generators/blacklight/test_support_generator.rb +10 -10
  234. data/lib/generators/blacklight/user_generator.rb +3 -6
  235. data/lib/railties/blacklight.rake +19 -14
  236. data/package-lock.json +2057 -0
  237. data/package.json +28 -0
  238. data/spec/controllers/alternate_controller_spec.rb +1 -1
  239. data/spec/controllers/application_controller_spec.rb +1 -1
  240. data/spec/controllers/blacklight/base_spec.rb +1 -1
  241. data/spec/controllers/blacklight/catalog/component_configuration_spec.rb +11 -7
  242. data/spec/controllers/blacklight/facet_spec.rb +1 -1
  243. data/spec/controllers/blacklight/search_fields_spec.rb +1 -13
  244. data/spec/controllers/bookmarks_controller_spec.rb +1 -36
  245. data/spec/controllers/catalog_controller_spec.rb +153 -53
  246. data/spec/controllers/search_history_controller_spec.rb +2 -2
  247. data/spec/features/alternate_controller_spec.rb +1 -1
  248. data/spec/features/autocomplete_spec.rb +2 -2
  249. data/spec/features/bookmarks_spec.rb +10 -10
  250. data/spec/features/did_you_mean_spec.rb +3 -9
  251. data/spec/features/facets_spec.rb +11 -11
  252. data/spec/features/record_view_spec.rb +1 -6
  253. data/spec/features/search_context_spec.rb +2 -2
  254. data/spec/features/search_filters_spec.rb +41 -41
  255. data/spec/features/search_formats_spec.rb +1 -1
  256. data/spec/features/search_history_spec.rb +1 -26
  257. data/spec/features/search_pagination_spec.rb +1 -1
  258. data/spec/features/search_results_spec.rb +3 -4
  259. data/spec/features/search_sort_spec.rb +2 -2
  260. data/spec/features/search_spec.rb +5 -10
  261. data/{solr → spec/fixtures}/sample_solr_documents.yml +688 -688
  262. data/spec/helpers/{configuration_helper_spec.rb → blacklight/configuration_helper_behavior_spec.rb} +70 -65
  263. data/spec/helpers/{facets_helper_spec.rb → blacklight/facets_helper_behavior_spec.rb} +7 -8
  264. data/spec/helpers/{hash_as_hidden_fields_spec.rb → blacklight/hash_as_hidden_fields_behavior_spec.rb} +1 -1
  265. data/spec/helpers/blacklight/icon_helper_behavior_spec.rb +8 -0
  266. data/spec/helpers/{layout_helper_spec.rb → blacklight/layout_helper_behavior_spec.rb} +5 -15
  267. data/spec/helpers/{render_constraints_helper_spec.rb → blacklight/render_constraints_helper_behavior_spec.rb} +2 -3
  268. data/spec/helpers/blacklight/render_partials_helper_behavior_spec.rb +80 -0
  269. data/spec/helpers/{search_history_constraints_helper_spec.rb → blacklight/search_history_constraints_helper_behavior_spec.rb} +9 -9
  270. data/spec/helpers/{suggest_helper_spec.rb → blacklight/suggest_helper_behavior_spec.rb} +4 -2
  271. data/spec/helpers/{url_helper_spec.rb → blacklight/url_helper_behavior_spec.rb} +11 -15
  272. data/spec/helpers/blacklight_helper_spec.rb +36 -141
  273. data/spec/helpers/catalog_helper_spec.rb +37 -56
  274. data/spec/integration/generators/blacklight/{solr5_generator_spec.rb → solr_generator_spec.rb} +3 -3
  275. data/spec/lib/blacklight/configuration/facet_field_spec.rb +11 -0
  276. data/spec/lib/blacklight/configuration/field_spec.rb +12 -0
  277. data/spec/lib/blacklight/nested_open_struct_with_hash_access_spec.rb +17 -0
  278. data/spec/lib/blacklight/open_struct_with_hash_access_spec.rb +153 -0
  279. data/spec/lib/blacklight/parameters_spec.rb +1 -1
  280. data/spec/lib/blacklight/search_state_spec.rb +2 -2
  281. data/spec/lib/blacklight_spec.rb +1 -1
  282. data/spec/lib/tasks/blacklight_task_spec.rb +1 -1
  283. data/spec/models/blacklight/configurable_spec.rb +15 -16
  284. data/spec/models/blacklight/configuration/context_spec.rb +1 -1
  285. data/spec/models/blacklight/configuration_spec.rb +146 -135
  286. data/spec/models/blacklight/document/active_model_shim_spec.rb +11 -1
  287. data/spec/models/blacklight/document/cache_key_spec.rb +1 -1
  288. data/spec/models/blacklight/document/dublin_core_spec.rb +5 -5
  289. data/spec/models/blacklight/document/email_spec.rb +3 -3
  290. data/spec/models/blacklight/document/sms_spec.rb +3 -3
  291. data/spec/models/blacklight/document_spec.rb +3 -16
  292. data/spec/models/blacklight/facet_paginator_spec.rb +1 -1
  293. data/spec/models/blacklight/icon_spec.rb +34 -0
  294. data/spec/models/blacklight/search_builder_spec.rb +33 -27
  295. data/spec/models/blacklight/solr/document_spec.rb +18 -7
  296. data/spec/models/blacklight/solr/facet_paginator_spec.rb +1 -1
  297. data/spec/models/blacklight/solr/repository_spec.rb +32 -27
  298. data/spec/models/blacklight/solr/request_spec.rb +1 -1
  299. data/spec/models/blacklight/solr/response/facets_spec.rb +1 -1
  300. data/spec/models/blacklight/solr/response/group_response_spec.rb +1 -1
  301. data/spec/models/blacklight/solr/response/group_spec.rb +1 -1
  302. data/spec/models/blacklight/solr/response_spec.rb +9 -6
  303. data/spec/models/blacklight/solr/search_builder_spec.rb +35 -48
  304. data/spec/models/blacklight/suggest/response_spec.rb +4 -5
  305. data/spec/models/blacklight/suggest_search_spec.rb +14 -7
  306. data/spec/models/blacklight/user_spec.rb +1 -1
  307. data/spec/models/bookmark_spec.rb +1 -1
  308. data/spec/models/record_mailer_spec.rb +2 -2
  309. data/spec/models/search_spec.rb +1 -1
  310. data/spec/models/solr_document_spec.rb +3 -3
  311. data/spec/presenters/blacklight/search_bar_presenter_spec.rb +72 -0
  312. data/spec/presenters/index_presenter_spec.rb +70 -143
  313. data/spec/presenters/pipeline_spec.rb +4 -4
  314. data/spec/presenters/show_presenter_spec.rb +83 -145
  315. data/spec/presenters/thumbnail_presenter_spec.rb +171 -0
  316. data/spec/routing/catalog_routing_spec.rb +1 -17
  317. data/spec/services/blacklight/search_service_spec.rb +446 -0
  318. data/spec/spec_helper.rb +22 -9
  319. data/spec/test_app_templates/Gemfile.extra +2 -5
  320. data/spec/test_app_templates/lib/generators/test_app_generator.rb +1 -1
  321. data/spec/views/catalog/_constraints.html.erb_spec.rb +1 -3
  322. data/spec/views/catalog/_constraints_element.html.erb_spec.rb +8 -8
  323. data/spec/views/catalog/_document.html.erb_spec.rb +7 -7
  324. data/spec/views/catalog/_document_list.html.erb_spec.rb +1 -1
  325. data/spec/views/catalog/_facet_index_navigation.html.erb_spec.rb +1 -1
  326. data/spec/views/catalog/_facet_layout.html.erb_spec.rb +6 -6
  327. data/spec/views/catalog/_facets.html.erb_spec.rb +2 -2
  328. data/spec/views/catalog/{_index_default.erb_spec.rb → _index.html.erb_spec.rb} +1 -1
  329. data/spec/views/catalog/{_index_header_default.html.erb_spec.rb → _index_header.html.erb_spec.rb} +4 -4
  330. data/spec/views/catalog/_paginate_compact.html.erb_spec.rb +4 -27
  331. data/spec/views/catalog/_search_header.erb_spec.rb +1 -3
  332. data/spec/views/catalog/{_show_default.erb_spec.rb → _show.html.erb_spec.rb} +1 -1
  333. data/spec/views/catalog/_show_sidebar.erb_spec.rb +3 -3
  334. data/spec/views/catalog/_show_tools.html.erb_spec.rb +3 -3
  335. data/spec/views/catalog/_sort_and_per_page.html.erb_spec.rb +1 -1
  336. data/spec/views/catalog/{_thumbnail_default.erb_spec.rb → _thumbnail.html.erb_spec.rb} +3 -3
  337. data/spec/views/catalog/_view_type_group.html.erb_spec.rb +5 -1
  338. data/spec/views/catalog/email_success.html.erb_spec.rb +9 -0
  339. data/spec/views/catalog/facet.html.erb_spec.rb +1 -1
  340. data/spec/views/catalog/facet.json.jbuilder_spec.rb +1 -1
  341. data/spec/views/catalog/index.atom.builder_spec.rb +2 -2
  342. data/spec/views/catalog/index.html.erb_spec.rb +4 -7
  343. data/spec/views/catalog/index.json.jbuilder_spec.rb +66 -21
  344. data/spec/views/catalog/opensearch.xml.builder_spec.rb +1 -1
  345. data/spec/views/catalog/show.html.erb_spec.rb +2 -2
  346. data/spec/views/catalog/sms_success.html.erb_spec.rb +9 -0
  347. data/spec/views/{_user_util_links.html.erb_spec.rb → shared/_user_util_links.html.erb_spec.rb} +4 -4
  348. data/tasks/blacklight.rake +10 -8
  349. data/template.demo.rb +1 -11
  350. metadata +171 -189
  351. data/app/assets/javascripts/blacklight/autofocus.js +0 -16
  352. data/app/assets/javascripts/blacklight/bookmark_toggle.js +0 -23
  353. data/app/assets/javascripts/blacklight/checkbox_submit.js +0 -139
  354. data/app/assets/javascripts/blacklight/core.js +0 -30
  355. data/app/controllers/concerns/blacklight/request_builders.rb +0 -77
  356. data/app/controllers/concerns/blacklight/saved_searches.rb +0 -70
  357. data/app/controllers/concerns/blacklight/search_helper.rb +0 -161
  358. data/app/controllers/concerns/blacklight/suggest.rb +0 -25
  359. data/app/controllers/saved_searches_controller.rb +0 -4
  360. data/app/controllers/suggest_controller.rb +0 -4
  361. data/app/helpers/blacklight/deprecated_url_helper_behavior.rb +0 -57
  362. data/app/helpers/blacklight/render_partials_helper.rb +0 -205
  363. data/app/helpers/blacklight_configuration_helper.rb +0 -4
  364. data/app/helpers/blacklight_url_helper.rb +0 -4
  365. data/app/helpers/component_helper.rb +0 -4
  366. data/app/helpers/facets_helper.rb +0 -4
  367. data/app/helpers/hash_as_hidden_fields_helper.rb +0 -4
  368. data/app/helpers/layout_helper.rb +0 -4
  369. data/app/helpers/render_constraints_helper.rb +0 -4
  370. data/app/helpers/search_history_constraints_helper.rb +0 -4
  371. data/app/helpers/suggest_helper.rb +0 -4
  372. data/app/models/concerns/blacklight/solr/document/more_like_this.rb +0 -6
  373. data/app/presenters/blacklight/document_presenter.rb +0 -153
  374. data/app/views/_user_util_links.html.erb +0 -26
  375. data/app/views/blacklight/nav/_saved_searches.html.erb +0 -1
  376. data/app/views/catalog/_index_default.html.erb +0 -12
  377. data/app/views/catalog/_show_default.html.erb +0 -10
  378. data/app/views/catalog/_thumbnail_default.html.erb +0 -5
  379. data/app/views/saved_searches/index.html.erb +0 -32
  380. data/app/views/shared/_ajax_modal.html.erb +0 -6
  381. data/lib/blacklight/utils.rb +0 -183
  382. data/lib/generators/blacklight/solr4_generator.rb +0 -31
  383. data/solr/conf/schema.xml +0 -627
  384. data/solr/conf/solrconfig.xml +0 -411
  385. data/spec/controllers/blacklight/search_helper_spec.rb +0 -489
  386. data/spec/controllers/saved_searches_controller_spec.rb +0 -32
  387. data/spec/controllers/suggest_controller_spec.rb +0 -17
  388. data/spec/features/saved_searches_spec.rb +0 -47
  389. data/spec/helpers/deprecated_url_helper_behavior_spec.rb +0 -101
  390. data/spec/lib/blacklight/utils_spec.rb +0 -167
  391. data/spec/models/blacklight/solr/document/more_like_this_spec.rb +0 -18
  392. data/spec/presenters/document_presenter_spec.rb +0 -438
  393. data/spec/support/backport_test.rb +0 -14
checksums.yaml CHANGED
@@ -1,7 +1,7 @@
1
1
  ---
2
2
  SHA256:
3
- metadata.gz: 57d198c6aed6d4e2cca7c1945904e4b13139ba1788acd6363d427aa30d436c14
4
- data.tar.gz: 92364314b9bbb7fcb9afc3f229a641afcd05ba43e1df4b19c8512e0e256523f9
3
+ metadata.gz: 01a2639c62ba9f670604f54a906e793a9a183149e572d46e613507553468211c
4
+ data.tar.gz: f87ddb57e26cce7061ee95de773dc1d25b88afbf03d6f299ce2cb869224d94d8
5
5
  SHA512:
6
- metadata.gz: 11048e0150ec7619375f56771faf38d1bdd0797f0f19cf67c8d8926f9f1e26adab9caf1a0f4fae084be28807aa0ab4e7320c149f688181f49eea8dedfd73d7c7
7
- data.tar.gz: ece97e66b4d5a6c1f91b5ea9491811d06983435e592936e973de5e253fcf8405351b601999480340384ef229affa3e703b261a628a41286975b20a83e789ea2e
6
+ metadata.gz: c5197a4917e13eb8026577584b0908115a5aed7a4b2cd800018256830fe7ca2956a3585a7dd1bed9781d29c3278a85156de3ee84c6602d260b5e98530bf82317
7
+ data.tar.gz: 7a362f1d8c0d630d24211cfed184b6574876450d6af2bde8fee02c9f1d55954a186946773d7f96b8a31badc54dca2dd1b4bbb9aa1f127f80749971b4f8d3b896
data/.gitignore CHANGED
@@ -16,3 +16,4 @@ pkg/*
16
16
  .internal_test_app
17
17
  .vagrant
18
18
  /spec/examples.txt
19
+ node_modules/*
data/.npmignore ADDED
@@ -0,0 +1,23 @@
1
+ .*
2
+ Gemfile
3
+ Rakefile
4
+ Vagrantfile
5
+ app/assets/images
6
+ app/controllers
7
+ app/helpers
8
+ app/models
9
+ app/presenters
10
+ app/services
11
+ app/views
12
+ blacklight.gemspec
13
+ config/locales
14
+ config/routes.rb
15
+ coverage
16
+ db
17
+ lib
18
+ pkg
19
+ provision.sh
20
+ solr
21
+ spec
22
+ tasks
23
+ template.demo.rb
data/.rubocop.yml CHANGED
@@ -13,21 +13,30 @@ AllCops:
13
13
  Rails:
14
14
  Enabled: true
15
15
 
16
+ Metrics/BlockLength:
17
+ Exclude:
18
+ - "lib/railties/blacklight.rake"
19
+ - "tasks/blacklight.rake"
20
+
21
+ Metrics/ClassLength:
22
+ Exclude:
23
+ - "lib/blacklight/configuration.rb"
24
+
16
25
  Metrics/LineLength:
17
26
  Max: 200
18
27
 
19
28
  Style/StringLiterals:
20
29
  Enabled: false
21
30
 
22
- Style/IndentationConsistency:
23
- Enabled: false
31
+ Layout/IndentationConsistency:
32
+ EnforcedStyle: normal
24
33
 
25
34
  Rails/OutputSafety:
26
35
  Enabled: false
27
36
 
28
37
  Style/MethodMissing:
29
38
  Exclude:
30
- - 'lib/blacklight/utils.rb'
39
+ - 'lib/blacklight/nested_open_struct_with_hash_access.rb'
31
40
 
32
41
  # engine_cart block includes conditional, not duplication
33
42
  Bundler/DuplicatedGem:
@@ -38,3 +47,6 @@ Bundler/DuplicatedGem:
38
47
  Bundler/OrderedGems:
39
48
  Exclude:
40
49
  - 'Gemfile'
50
+
51
+ Naming/HeredocDelimiterNaming:
52
+ Enabled: false
data/.rubocop_todo.yml CHANGED
@@ -1,157 +1,257 @@
1
1
  # This configuration was generated by
2
2
  # `rubocop --auto-gen-config`
3
- # on 2017-03-03 12:59:32 -0800 using RuboCop version 0.47.1.
3
+ # on 2018-03-28 15:21:19 -0700 using RuboCop version 0.54.0.
4
4
  # The point is for the user to remove these configuration records
5
5
  # one by one as the offenses are removed from the code base.
6
6
  # Note that changes in the inspected code, or installation of new
7
7
  # versions of RuboCop, may require this file to be generated again.
8
8
 
9
- # Offense count: 19
9
+ # Offense count: 2
10
+ # Cop supports --auto-correct.
11
+ # Configuration parameters: EnforcedStyle, IndentationWidth.
12
+ # SupportedStyles: with_first_parameter, with_fixed_indentation
13
+ Layout/AlignParameters:
14
+ Exclude:
15
+ - 'app/views/catalog/_document.atom.builder'
16
+
17
+ # Offense count: 8
10
18
  # Cop supports --auto-correct.
11
- # Configuration parameters: EnforcedStyleAlignWith, SupportedStylesAlignWith, AutoCorrect.
12
- # SupportedStylesAlignWith: keyword, variable, start_of_line
13
- Lint/EndAlignment:
19
+ # Configuration parameters: EnforcedStyle, IndentOneStep, IndentationWidth.
20
+ # SupportedStyles: case, end
21
+ Layout/CaseIndentation:
14
22
  Exclude:
15
- - 'app/controllers/concerns/blacklight/token_based_user.rb'
16
23
  - 'app/helpers/blacklight/catalog_helper_behavior.rb'
17
- - 'app/helpers/blacklight/deprecated_url_helper_behavior.rb'
18
- - 'app/helpers/blacklight/facets_helper_behavior.rb'
19
- - 'app/helpers/blacklight/render_partials_helper.rb'
20
- - 'app/helpers/blacklight/url_helper_behavior.rb'
21
- - 'app/models/concerns/blacklight/configurable.rb'
22
24
  - 'app/presenters/blacklight/index_presenter.rb'
23
25
  - 'lib/blacklight/configuration/fields.rb'
24
- - 'lib/blacklight/search_builder.rb'
25
- - 'lib/blacklight/solr/response/facets.rb'
26
- - 'lib/blacklight/solr/search_builder_behavior.rb'
27
26
 
28
- # Offense count: 26
27
+ # Offense count: 2
29
28
  # Cop supports --auto-correct.
30
- # Configuration parameters: IgnoreEmptyBlocks, AllowUnusedKeywordArguments.
31
- Lint/UnusedBlockArgument:
29
+ Layout/ClosingParenthesisIndentation:
32
30
  Exclude:
33
- - 'app/controllers/concerns/blacklight/search_context.rb'
34
- - 'app/helpers/blacklight/configuration_helper_behavior.rb'
35
- - 'app/models/concerns/blacklight/document/dublin_core.rb'
36
- - 'lib/blacklight/configuration/fields.rb'
37
- - 'lib/blacklight/engine.rb'
38
- - 'lib/blacklight/parameters.rb'
39
- - 'lib/blacklight/solr/response/facets.rb'
40
- - 'lib/blacklight/solr/search_builder_behavior.rb'
41
- - 'lib/railties/blacklight.rake'
42
- - 'tasks/blacklight.rake'
31
+ - 'app/views/catalog/index.atom.builder'
43
32
 
44
- # Offense count: 19
33
+ # Offense count: 95
45
34
  # Cop supports --auto-correct.
46
- # Configuration parameters: AllowUnusedKeywordArguments, IgnoreEmptyMethods.
47
- Lint/UnusedMethodArgument:
35
+ Layout/EmptyLineAfterMagicComment:
36
+ Enabled: false
37
+
38
+ # Offense count: 8
39
+ # Cop supports --auto-correct.
40
+ # Configuration parameters: AllowForAlignment, ForceEqualSignAlignment.
41
+ Layout/ExtraSpacing:
48
42
  Exclude:
49
- - 'app/helpers/blacklight/blacklight_helper_behavior.rb'
50
43
  - 'app/helpers/blacklight/catalog_helper_behavior.rb'
51
- - 'app/helpers/blacklight/component_helper_behavior.rb'
52
- - 'app/helpers/blacklight/configuration_helper_behavior.rb'
53
- - 'app/helpers/blacklight/deprecated_url_helper_behavior.rb'
44
+ - 'app/models/concerns/blacklight/document/dublin_core.rb'
45
+ - 'app/models/record_mailer.rb'
46
+ - 'app/views/catalog/index.atom.builder'
47
+ - 'config/routes.rb'
48
+
49
+ # Offense count: 2
50
+ # Cop supports --auto-correct.
51
+ # Configuration parameters: EnforcedStyle, IndentationWidth.
52
+ # SupportedStyles: special_inside_parentheses, consistent, align_braces
53
+ Layout/IndentHash:
54
+ Exclude:
55
+ - 'lib/blacklight/configuration.rb'
56
+
57
+ # Offense count: 6
58
+ # Cop supports --auto-correct.
59
+ Layout/LeadingCommentSpace:
60
+ Exclude:
61
+ - 'app/models/blacklight/facet_paginator.rb'
62
+ - 'app/models/concerns/blacklight/configurable.rb'
63
+ - 'app/models/concerns/blacklight/document/export.rb'
64
+ - 'app/views/catalog/_document.atom.builder'
65
+
66
+ # Offense count: 2
67
+ # Cop supports --auto-correct.
68
+ Layout/MultilineBlockLayout:
69
+ Exclude:
70
+ - 'lib/generators/blacklight/install_generator.rb'
71
+ - 'lib/generators/blacklight/test_support_generator.rb'
72
+
73
+ # Offense count: 2
74
+ # Cop supports --auto-correct.
75
+ # Configuration parameters: EnforcedStyle.
76
+ # SupportedStyles: symmetrical, new_line, same_line
77
+ Layout/MultilineMethodCallBraceLayout:
78
+ Exclude:
79
+ - 'app/views/catalog/index.atom.builder'
80
+
81
+ # Offense count: 9
82
+ # Cop supports --auto-correct.
83
+ # Configuration parameters: EnforcedStyle, IndentationWidth.
84
+ # SupportedStyles: aligned, indented, indented_relative_to_receiver
85
+ Layout/MultilineMethodCallIndentation:
86
+ Exclude:
87
+ - 'lib/blacklight/search_builder.rb'
88
+
89
+ # Offense count: 11
90
+ # Cop supports --auto-correct.
91
+ # Configuration parameters: EnforcedStyle, IndentationWidth.
92
+ # SupportedStyles: aligned, indented
93
+ Layout/MultilineOperationIndentation:
94
+ Exclude:
54
95
  - 'app/helpers/blacklight/facets_helper_behavior.rb'
55
- - 'app/helpers/blacklight/render_partials_helper.rb'
56
96
  - 'app/helpers/blacklight/search_history_constraints_helper_behavior.rb'
57
- - 'app/models/concerns/blacklight/document.rb'
58
- - 'lib/blacklight/abstract_repository.rb'
59
- - 'lib/blacklight/configuration/field.rb'
60
- - 'lib/blacklight/search_builder.rb'
97
+ - 'lib/blacklight/configuration/context.rb'
61
98
  - 'lib/blacklight/search_state.rb'
99
+ - 'lib/blacklight/solr/search_builder_behavior.rb'
62
100
 
63
- # Offense count: 9
101
+ # Offense count: 2
102
+ # Cop supports --auto-correct.
103
+ Layout/SpaceAfterComma:
104
+ Exclude:
105
+ - 'app/views/catalog/index.atom.builder'
106
+ - 'app/views/catalog/opensearch.xml.builder'
107
+
108
+ # Offense count: 1
109
+ # Cop supports --auto-correct.
110
+ # Configuration parameters: AllowForAlignment.
111
+ Layout/SpaceAroundOperators:
112
+ Exclude:
113
+ - 'app/views/catalog/index.atom.builder'
114
+
115
+ # Offense count: 1
116
+ # Cop supports --auto-correct.
117
+ # Configuration parameters: AllowForAlignment.
118
+ Layout/SpaceBeforeFirstArg:
119
+ Exclude:
120
+ - 'app/views/catalog/index.atom.builder'
121
+
122
+ # Offense count: 7
123
+ # Cop supports --auto-correct.
124
+ Layout/SpaceInsideParens:
125
+ Exclude:
126
+ - 'app/views/catalog/_document.rss.builder'
127
+ - 'app/views/catalog/index.atom.builder'
128
+
129
+ # Offense count: 27
130
+ # Cop supports --auto-correct.
131
+ Layout/TrailingWhitespace:
132
+ Exclude:
133
+ - 'app/views/catalog/_document.atom.builder'
134
+ - 'app/views/catalog/_document.rss.builder'
135
+ - 'app/views/catalog/index.atom.builder'
136
+
137
+ # Offense count: 1
138
+ Lint/AmbiguousBlockAssociation:
139
+ Exclude:
140
+ - 'lib/blacklight/solr/search_builder_behavior.rb'
141
+
142
+ # Offense count: 6
64
143
  Lint/UselessAssignment:
65
144
  Exclude:
66
145
  - 'app/controllers/concerns/blacklight/search_context.rb'
67
- - 'app/helpers/blacklight/deprecated_url_helper_behavior.rb'
68
146
  - 'app/helpers/blacklight/facets_helper_behavior.rb'
69
147
  - 'app/models/bookmark.rb'
70
148
  - 'lib/blacklight/routes/exportable.rb'
71
149
  - 'lib/blacklight/routes/searchable.rb'
72
- - 'lib/blacklight/solr/response/spelling.rb'
73
150
  - 'lib/railties/blacklight.rake'
74
151
 
75
- # Offense count: 62
152
+ # Offense count: 56
76
153
  Metrics/AbcSize:
77
154
  Max: 53
78
155
 
79
- # Offense count: 4
156
+ # Offense count: 3
80
157
  # Configuration parameters: CountComments, ExcludedMethods.
81
158
  Metrics/BlockLength:
82
- Max: 94
159
+ Max: 42
83
160
 
84
161
  # Offense count: 1
85
162
  # Configuration parameters: CountBlocks.
86
163
  Metrics/BlockNesting:
87
164
  Max: 4
88
165
 
166
+ # Offense count: 3
89
167
  # Configuration parameters: CountComments.
90
168
  Metrics/ClassLength:
91
- Max: 100
92
- Exclude:
93
- - 'lib/blacklight/configuration.rb'
94
- - 'lib/blacklight/search_builder.rb'
95
- - 'lib/blacklight/search_state.rb'
169
+ Max: 189
96
170
 
97
- # Offense count: 20
171
+ # Offense count: 19
98
172
  Metrics/CyclomaticComplexity:
99
173
  Max: 12
100
174
 
101
- # Offense count: 53
175
+ # Offense count: 44
102
176
  # Configuration parameters: CountComments.
103
177
  Metrics/MethodLength:
104
- Max: 52
105
- Exclude:
106
- - 'lib/blacklight/configuration.rb'
178
+ Max: 39
107
179
 
108
- # Offense count: 9
180
+ # Offense count: 7
109
181
  # Configuration parameters: CountComments.
110
182
  Metrics/ModuleLength:
111
- Max: 211
112
- Exclude:
113
- - 'lib/blacklight/solr/search_builder_behavior.rb'
183
+ Max: 209
114
184
 
115
185
  # Offense count: 1
116
186
  # Configuration parameters: CountKeywordArgs.
117
187
  Metrics/ParameterLists:
118
188
  Max: 6
119
189
 
120
- # Offense count: 18
190
+ # Offense count: 16
121
191
  Metrics/PerceivedComplexity:
122
192
  Max: 14
123
193
 
124
- # Offense count: 2
125
- Rails/FilePath:
194
+ # Offense count: 4
195
+ Naming/MemoizedInstanceVariableName:
196
+ Exclude:
197
+ - 'app/helpers/blacklight/blacklight_helper_behavior.rb'
198
+ - 'app/helpers/blacklight/render_partials_helper_behavior.rb'
199
+ - 'app/models/concerns/blacklight/document/semantic_fields.rb'
200
+ - 'lib/blacklight/solr/response.rb'
201
+
202
+ # Offense count: 8
203
+ # Configuration parameters: NamePrefix, NamePrefixBlacklist, NameWhitelist, MethodDefinitionMacros.
204
+ # NamePrefix: is_, has_, have_
205
+ # NamePrefixBlacklist: is_, has_, have_
206
+ # NameWhitelist: is_a?
207
+ # MethodDefinitionMacros: define_method, define_singleton_method
208
+ Naming/PredicateName:
126
209
  Exclude:
210
+ - 'spec/**/*'
127
211
  - 'app/controllers/concerns/blacklight/catalog.rb'
212
+ - 'app/controllers/concerns/blacklight/controller.rb'
213
+ - 'app/helpers/blacklight/catalog_helper_behavior.rb'
214
+ - 'app/helpers/blacklight/configuration_helper_behavior.rb'
215
+ - 'app/helpers/blacklight/facets_helper_behavior.rb'
216
+ - 'app/models/concerns/blacklight/document.rb'
217
+ - 'app/models/concerns/blacklight/solr/document.rb'
218
+ - 'lib/generators/blacklight/assets_generator.rb'
128
219
 
129
- # Offense count: 1
130
- # Configuration parameters: Blacklist.
131
- # Blacklist: decrement!, decrement_counter, increment!, increment_counter, toggle!, touch, update_all, update_attribute, update_column, update_columns, update_counters
132
- Rails/SkipsModelValidations:
220
+ # Offense count: 12
221
+ # Configuration parameters: MinNameLength, AllowNamesEndingInNumbers, AllowedNames, ForbiddenNames.
222
+ # AllowedNames: io, id, to
223
+ Naming/UncommunicativeMethodParamName:
133
224
  Exclude:
134
- - 'app/controllers/concerns/blacklight/saved_searches.rb'
225
+ - 'app/models/blacklight/facet_paginator.rb'
226
+ - 'app/models/concerns/blacklight/document.rb'
227
+ - 'app/models/concerns/blacklight/solr/document.rb'
228
+ - 'app/presenters/blacklight/rendering/link_to_facet.rb'
229
+ - 'lib/blacklight/nested_open_struct_with_hash_access.rb'
230
+ - 'lib/blacklight/search_state.rb'
231
+ - 'lib/blacklight/solr/search_builder_behavior.rb'
135
232
 
136
- # Offense count: 2
233
+ # Offense count: 1
137
234
  # Cop supports --auto-correct.
138
- Security/YAMLLoad:
235
+ # Configuration parameters: NilOrEmpty, NotPresent, UnlessPresent.
236
+ Rails/Blank:
139
237
  Exclude:
140
- - 'lib/blacklight.rb'
141
- - 'lib/railties/blacklight.rake'
238
+ - 'lib/blacklight/solr/search_builder_behavior.rb'
142
239
 
143
- # Offense count: 2
240
+ # Offense count: 13
144
241
  # Cop supports --auto-correct.
145
- # Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth.
146
- # SupportedStyles: outdent, indent
147
- Style/AccessModifierIndentation:
242
+ # Configuration parameters: NotNilAndNotEmpty, NotBlank, UnlessBlank.
243
+ Rails/Present:
148
244
  Exclude:
149
245
  - 'app/controllers/concerns/blacklight/catalog.rb'
150
- - 'app/controllers/concerns/blacklight/controller.rb'
246
+ - 'app/helpers/blacklight/component_helper_behavior.rb'
247
+ - 'app/helpers/blacklight/facets_helper_behavior.rb'
248
+ - 'app/models/concerns/blacklight/document/email.rb'
249
+ - 'app/models/concerns/blacklight/document/sms.rb'
250
+ - 'lib/blacklight/solr/search_builder_behavior.rb'
151
251
 
152
252
  # Offense count: 9
153
253
  # Cop supports --auto-correct.
154
- # Configuration parameters: EnforcedStyle, SupportedStyles.
254
+ # Configuration parameters: EnforcedStyle.
155
255
  # SupportedStyles: prefer_alias, prefer_alias_method
156
256
  Style/Alias:
157
257
  Exclude:
@@ -162,27 +262,21 @@ Style/Alias:
162
262
  - 'lib/blacklight/solr/response.rb'
163
263
  - 'lib/blacklight/solr/response/group_response.rb'
164
264
 
165
- # Offense count: 6
265
+ # Offense count: 3
166
266
  # Cop supports --auto-correct.
167
- # Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth.
168
- # SupportedStyles: with_first_parameter, with_fixed_indentation
169
- Style/AlignParameters:
267
+ # Configuration parameters: EnforcedStyle, ProceduralMethods, FunctionalMethods, IgnoredMethods.
268
+ # SupportedStyles: line_count_based, semantic, braces_for_chaining
269
+ # ProceduralMethods: benchmark, bm, bmbm, create, each_with_object, measure, new, realtime, tap, with_object
270
+ # FunctionalMethods: let, let!, subject, watch
271
+ # IgnoredMethods: lambda, proc, it
272
+ Style/BlockDelimiters:
170
273
  Exclude:
171
- - 'app/helpers/blacklight/render_constraints_helper_behavior.rb'
172
- - 'app/helpers/blacklight/search_history_constraints_helper_behavior.rb'
173
- - 'lib/blacklight/configuration.rb'
174
- - 'lib/generators/blacklight/solr4_generator.rb'
175
-
176
- # Offense count: 64
177
- # Cop supports --auto-correct.
178
- # Configuration parameters: EnforcedStyle, SupportedStyles.
179
- # SupportedStyles: always, conditionals
180
- Style/AndOr:
181
- Enabled: false
274
+ - 'app/views/catalog/index.rss.builder'
275
+ - 'app/views/catalog/opensearch.xml.builder'
182
276
 
183
277
  # Offense count: 3
184
278
  # Cop supports --auto-correct.
185
- # Configuration parameters: EnforcedStyle, SupportedStyles.
279
+ # Configuration parameters: EnforcedStyle.
186
280
  # SupportedStyles: braces, no_braces, context_dependent
187
281
  Style/BracesAroundHashParameters:
188
282
  Exclude:
@@ -190,199 +284,85 @@ Style/BracesAroundHashParameters:
190
284
  - 'lib/blacklight/solr/response/facets.rb'
191
285
  - 'lib/generators/blacklight/test_support_generator.rb'
192
286
 
193
- # Offense count: 13
287
+ # Offense count: 50
194
288
  # Cop supports --auto-correct.
195
- # Configuration parameters: EnforcedStyle, SupportedStyles, IndentOneStep, IndentationWidth.
196
- # SupportedStyles: case, end
197
- Style/CaseIndentation:
198
- Exclude:
199
- - 'app/helpers/blacklight/catalog_helper_behavior.rb'
200
- - 'app/helpers/blacklight/deprecated_url_helper_behavior.rb'
201
- - 'app/presenters/blacklight/index_presenter.rb'
202
- - 'lib/blacklight/configuration/fields.rb'
203
- - 'lib/blacklight/search_builder.rb'
204
-
205
- # Offense count: 51
206
- # Configuration parameters: EnforcedStyle, SupportedStyles.
289
+ # Configuration parameters: AutoCorrect, EnforcedStyle.
207
290
  # SupportedStyles: nested, compact
208
291
  Style/ClassAndModuleChildren:
209
292
  Enabled: false
210
293
 
211
- # Offense count: 2
294
+ # Offense count: 1
212
295
  # Cop supports --auto-correct.
213
- # Configuration parameters: EnforcedStyle, SupportedStyles, SingleLineConditionsOnly, IncludeTernaryExpressions.
296
+ # Configuration parameters: EnforcedStyle, SingleLineConditionsOnly, IncludeTernaryExpressions.
214
297
  # SupportedStyles: assign_to_condition, assign_inside_condition
215
298
  Style/ConditionalAssignment:
216
299
  Exclude:
217
300
  - 'lib/blacklight/solr/response/spelling.rb'
218
301
 
219
- # Offense count: 104
302
+ # Offense count: 91
220
303
  Style/Documentation:
221
304
  Enabled: false
222
305
 
223
- # Offense count: 7
224
- # Cop supports --auto-correct.
225
- # Configuration parameters: EnforcedStyle, SupportedStyles.
226
- # SupportedStyles: leading, trailing
227
- Style/DotPosition:
228
- Exclude:
229
- - 'app/controllers/concerns/blacklight/search_helper.rb'
230
- - 'lib/blacklight/search_builder.rb'
231
-
232
306
  # Offense count: 1
233
307
  Style/DoubleNegation:
234
308
  Exclude:
235
309
  - 'lib/blacklight/search_builder.rb'
236
310
 
237
- # Offense count: 16
238
- # Cop supports --auto-correct.
239
- Style/ElseAlignment:
240
- Exclude:
241
- - 'app/helpers/blacklight/catalog_helper_behavior.rb'
242
- - 'app/helpers/blacklight/facets_helper_behavior.rb'
243
- - 'app/helpers/blacklight/url_helper_behavior.rb'
244
- - 'app/models/concerns/blacklight/configurable.rb'
245
- - 'lib/blacklight/search_builder.rb'
246
- - 'lib/blacklight/solr/response/facets.rb'
247
- - 'lib/blacklight/solr/search_builder_behavior.rb'
248
-
249
- # Offense count: 20
311
+ # Offense count: 9
250
312
  # Cop supports --auto-correct.
251
- # Configuration parameters: AllowForAlignment, ForceEqualSignAlignment.
252
- Style/ExtraSpacing:
313
+ Style/ExpandPathArguments:
253
314
  Exclude:
254
- - 'app/helpers/blacklight/catalog_helper_behavior.rb'
255
- - 'app/helpers/blacklight/configuration_helper_behavior.rb'
256
- - 'app/models/concerns/blacklight/document/dublin_core.rb'
257
- - 'app/models/record_mailer.rb'
258
- - 'config/routes.rb'
315
+ - 'Gemfile'
316
+ - 'lib/generators/blacklight/assets_generator.rb'
259
317
  - 'lib/generators/blacklight/controller_generator.rb'
260
318
  - 'lib/generators/blacklight/document_generator.rb'
261
319
  - 'lib/generators/blacklight/install_generator.rb'
320
+ - 'lib/generators/blacklight/models_generator.rb'
262
321
  - 'lib/generators/blacklight/search_builder_generator.rb'
263
- - 'lib/railties/blacklight.rake'
264
- - 'tasks/blacklight.rake'
322
+ - 'lib/generators/blacklight/test_support_generator.rb'
323
+ - 'lib/generators/blacklight/user_generator.rb'
265
324
 
266
- # Offense count: 2
267
- # Configuration parameters: EnforcedStyle, SupportedStyles.
268
- # SupportedStyles: format, sprintf, percent
269
- Style/FormatString:
325
+ # Offense count: 16
326
+ # Configuration parameters: EnforcedStyle.
327
+ # SupportedStyles: annotated, template, unannotated
328
+ Style/FormatStringToken:
270
329
  Exclude:
271
- - 'app/helpers/blacklight/render_partials_helper.rb'
330
+ - 'app/helpers/blacklight/render_partials_helper_behavior.rb'
272
331
 
273
- # Offense count: 10
332
+ # Offense count: 8
274
333
  # Configuration parameters: MinBodyLength.
275
334
  Style/GuardClause:
276
335
  Exclude:
277
- - 'app/controllers/concerns/blacklight/base.rb'
278
336
  - 'app/controllers/concerns/blacklight/bookmarks.rb'
279
337
  - 'app/controllers/concerns/blacklight/catalog.rb'
280
338
  - 'app/controllers/concerns/blacklight/search_context.rb'
281
339
  - 'app/helpers/blacklight/catalog_helper_behavior.rb'
282
340
  - 'lib/blacklight/solr/search_builder_behavior.rb'
283
341
 
284
- # Offense count: 111
342
+ # Offense count: 33
285
343
  # Cop supports --auto-correct.
286
- # Configuration parameters: EnforcedStyle, SupportedStyles, UseHashRocketsWithSymbolValues, PreferHashRocketsForNonAlnumEndingSymbols.
287
- # SupportedStyles: ruby19, hash_rockets, no_mixed_keys, ruby19_no_mixed_keys
288
- Style/HashSyntax:
289
- Enabled: false
290
-
291
- # Offense count: 15
292
- # Cop supports --auto-correct.
293
- # Configuration parameters: MaxLineLength.
294
344
  Style/IfUnlessModifier:
295
- Exclude:
296
- - 'app/controllers/concerns/blacklight/controller.rb'
297
- - 'app/controllers/concerns/blacklight/request_builders.rb'
298
- - 'app/controllers/concerns/blacklight/token_based_user.rb'
299
- - 'app/helpers/blacklight/catalog_helper_behavior.rb'
300
- - 'app/helpers/blacklight/url_helper_behavior.rb'
301
- - 'app/models/blacklight/facet_paginator.rb'
302
- - 'lib/blacklight/configuration/fields.rb'
303
- - 'lib/blacklight/search_state.rb'
304
- - 'lib/generators/blacklight/install_generator.rb'
305
- - 'lib/railties/blacklight.rake'
306
-
307
- # Offense count: 2
308
- # Cop supports --auto-correct.
309
- # Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth.
310
- # SupportedStyles: special_inside_parentheses, consistent, align_braces
311
- Style/IndentHash:
312
- Exclude:
313
- - 'lib/blacklight/configuration.rb'
314
-
315
- # Offense count: 23
316
- # Cop supports --auto-correct.
317
- # Configuration parameters: Width.
318
- Style/IndentationWidth:
319
- Exclude:
320
- - 'app/controllers/concerns/blacklight/bookmarks.rb'
321
- - 'app/controllers/concerns/blacklight/search_fields.rb'
322
- - 'app/controllers/concerns/blacklight/token_based_user.rb'
323
- - 'app/helpers/blacklight/catalog_helper_behavior.rb'
324
- - 'app/helpers/blacklight/facets_helper_behavior.rb'
325
- - 'app/helpers/blacklight/render_constraints_helper_behavior.rb'
326
- - 'app/helpers/blacklight/render_partials_helper.rb'
327
- - 'app/helpers/blacklight/url_helper_behavior.rb'
328
- - 'app/models/concerns/blacklight/configurable.rb'
329
- - 'lib/blacklight/search_builder.rb'
330
- - 'lib/blacklight/solr/response/facets.rb'
331
- - 'lib/blacklight/solr/search_builder_behavior.rb'
332
- - 'lib/generators/blacklight/assets_generator.rb'
333
-
334
- # Offense count: 9
335
- # Cop supports --auto-correct.
336
- Style/LeadingCommentSpace:
337
- Exclude:
338
- - 'app/models/blacklight/facet_paginator.rb'
339
- - 'app/models/concerns/blacklight/configurable.rb'
340
- - 'app/models/concerns/blacklight/document/export.rb'
341
- - 'lib/blacklight/configuration.rb'
342
- - 'lib/blacklight/solr/response/spelling.rb'
345
+ Enabled: false
343
346
 
344
- # Offense count: 125
347
+ # Offense count: 116
345
348
  # Cop supports --auto-correct.
346
- # Configuration parameters: EnforcedStyle, SupportedStyles.
349
+ # Configuration parameters: EnforcedStyle.
347
350
  # SupportedStyles: require_parentheses, require_no_parentheses, require_no_parentheses_except_multiline
348
351
  Style/MethodDefParentheses:
349
352
  Enabled: false
350
353
 
351
- # Offense count: 2
352
- # Cop supports --auto-correct.
353
- Style/MultilineBlockLayout:
354
- Exclude:
355
- - 'lib/generators/blacklight/install_generator.rb'
356
- - 'lib/generators/blacklight/test_support_generator.rb'
357
-
358
- # Offense count: 3
354
+ # Offense count: 5
359
355
  # Cop supports --auto-correct.
360
356
  Style/MultilineIfModifier:
361
357
  Exclude:
358
+ - 'app/views/catalog/index.atom.builder'
362
359
  - 'lib/blacklight/solr/response/facets.rb'
363
360
  - 'lib/blacklight/solr/search_builder_behavior.rb'
364
361
 
365
- # Offense count: 13
366
- # Cop supports --auto-correct.
367
- # Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth.
368
- # SupportedStyles: aligned, indented, indented_relative_to_receiver
369
- Style/MultilineMethodCallIndentation:
370
- Exclude:
371
- - 'app/controllers/concerns/blacklight/search_helper.rb'
372
- - 'lib/blacklight/search_builder.rb'
373
-
374
- # Offense count: 12
375
- # Cop supports --auto-correct.
376
- # Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth.
377
- # SupportedStyles: aligned, indented
378
- Style/MultilineOperationIndentation:
362
+ # Offense count: 1
363
+ Style/MultipleComparison:
379
364
  Exclude:
380
- - 'app/controllers/concerns/blacklight/default_component_configuration.rb'
381
- - 'app/helpers/blacklight/facets_helper_behavior.rb'
382
- - 'app/helpers/blacklight/search_history_constraints_helper_behavior.rb'
383
365
  - 'lib/blacklight/configuration/context.rb'
384
- - 'lib/blacklight/search_state.rb'
385
- - 'lib/blacklight/solr/search_builder_behavior.rb'
386
366
 
387
367
  # Offense count: 2
388
368
  # Cop supports --auto-correct.
@@ -390,167 +370,50 @@ Style/MutableConstant:
390
370
  Exclude:
391
371
  - 'lib/blacklight/solr/request.rb'
392
372
 
393
- # Offense count: 8
394
- # Configuration parameters: NamePrefix, NamePrefixBlacklist, NameWhitelist.
395
- # NamePrefix: is_, has_, have_
396
- # NamePrefixBlacklist: is_, has_, have_
397
- # NameWhitelist: is_a?
398
- Style/PredicateName:
399
- Exclude:
400
- - 'spec/**/*'
401
- - 'app/controllers/concerns/blacklight/catalog.rb'
402
- - 'app/controllers/concerns/blacklight/controller.rb'
403
- - 'app/helpers/blacklight/catalog_helper_behavior.rb'
404
- - 'app/helpers/blacklight/configuration_helper_behavior.rb'
405
- - 'app/helpers/blacklight/facets_helper_behavior.rb'
406
- - 'app/models/concerns/blacklight/document.rb'
407
- - 'app/models/concerns/blacklight/solr/document.rb'
408
- - 'lib/generators/blacklight/assets_generator.rb'
409
-
410
- # Offense count: 43
411
- # Cop supports --auto-correct.
412
- Style/RedundantSelf:
413
- Enabled: false
414
-
415
- # Offense count: 17
416
- # Cop supports --auto-correct.
417
- Style/SpaceAfterComma:
418
- Exclude:
419
- - 'app/controllers/concerns/blacklight/search_context.rb'
420
- - 'app/helpers/blacklight/configuration_helper_behavior.rb'
421
- - 'app/helpers/blacklight/facets_helper_behavior.rb'
422
- - 'app/helpers/blacklight/render_constraints_helper_behavior.rb'
423
- - 'app/models/concerns/blacklight/document/dublin_core.rb'
424
- - 'lib/blacklight/configuration/fields.rb'
425
- - 'lib/blacklight/parameters.rb'
426
- - 'lib/blacklight/solr/response/facets.rb'
427
- - 'lib/blacklight/solr/search_builder_behavior.rb'
428
- - 'lib/blacklight/utils.rb'
429
-
430
373
  # Offense count: 3
431
374
  # Cop supports --auto-correct.
432
- # Configuration parameters: EnforcedStyleInsidePipes, SupportedStylesInsidePipes.
433
- # SupportedStylesInsidePipes: space, no_space
434
- Style/SpaceAroundBlockParameters:
375
+ # Configuration parameters: AllowSafeAssignment.
376
+ Style/ParenthesesAroundCondition:
435
377
  Exclude:
436
- - 'app/controllers/concerns/blacklight/catalog.rb'
437
- - 'app/models/concerns/blacklight/document/extensions.rb'
378
+ - 'app/views/catalog/_document.atom.builder'
438
379
 
439
- # Offense count: 26
380
+ # Offense count: 5
440
381
  # Cop supports --auto-correct.
441
- # Configuration parameters: EnforcedStyle, SupportedStyles.
442
- # SupportedStyles: space, no_space
443
- Style/SpaceAroundEqualsInParameterDefault:
382
+ # Configuration parameters: PreferredDelimiters.
383
+ Style/PercentLiteralDelimiters:
444
384
  Exclude:
445
- - 'app/controllers/concerns/blacklight/search_helper.rb'
446
- - 'app/helpers/blacklight/blacklight_helper_behavior.rb'
447
- - 'app/helpers/blacklight/component_helper_behavior.rb'
448
- - 'app/helpers/blacklight/configuration_helper_behavior.rb'
449
- - 'app/helpers/blacklight/facets_helper_behavior.rb'
450
- - 'app/helpers/blacklight/url_helper_behavior.rb'
451
- - 'app/models/concerns/blacklight/document.rb'
452
- - 'app/presenters/blacklight/document_presenter.rb'
453
- - 'app/presenters/blacklight/index_presenter.rb'
454
- - 'app/presenters/blacklight/show_presenter.rb'
455
- - 'lib/blacklight/search_state.rb'
456
-
457
- # Offense count: 11
458
- # Cop supports --auto-correct.
459
- # Configuration parameters: AllowForAlignment.
460
- Style/SpaceAroundOperators:
461
- Exclude:
462
- - 'app/controllers/concerns/blacklight/request_builders.rb'
463
- - 'app/helpers/blacklight/blacklight_helper_behavior.rb'
464
- - 'app/helpers/blacklight/facets_helper_behavior.rb'
465
- - 'app/helpers/blacklight/search_history_constraints_helper_behavior.rb'
466
- - 'app/helpers/blacklight/url_helper_behavior.rb'
467
- - 'lib/blacklight/solr/repository.rb'
468
- - 'lib/blacklight/solr/response/spelling.rb'
469
- - 'tasks/blacklight.rake'
470
-
471
- # Offense count: 1
472
- # Cop supports --auto-correct.
473
- # Configuration parameters: EnforcedStyle, SupportedStyles.
474
- # SupportedStyles: space, no_space
475
- Style/SpaceBeforeBlockBraces:
476
- Exclude:
477
- - 'lib/blacklight/solr/response.rb'
478
-
479
- # Offense count: 15
480
- # Cop supports --auto-correct.
481
- Style/SpaceBeforeComma:
482
- Exclude:
483
- - 'app/helpers/blacklight/search_history_constraints_helper_behavior.rb'
484
- - 'lib/generators/blacklight/controller_generator.rb'
485
- - 'lib/generators/blacklight/document_generator.rb'
486
- - 'lib/generators/blacklight/install_generator.rb'
487
- - 'lib/generators/blacklight/search_builder_generator.rb'
488
- - 'lib/generators/blacklight/user_generator.rb'
489
-
490
- # Offense count: 3
491
- # Cop supports --auto-correct.
492
- # Configuration parameters: AllowForAlignment.
493
- Style/SpaceBeforeFirstArg:
494
- Exclude:
495
- - 'lib/generators/blacklight/controller_generator.rb'
496
- - 'lib/generators/blacklight/document_generator.rb'
497
- - 'lib/generators/blacklight/search_builder_generator.rb'
385
+ - 'lib/blacklight/configuration.rb'
386
+ - 'lib/blacklight/engine.rb'
387
+ - 'lib/blacklight/solr/request.rb'
498
388
 
499
- # Offense count: 15
389
+ # Offense count: 2
500
390
  # Cop supports --auto-correct.
501
- # Configuration parameters: EnforcedStyle, SupportedStyles, EnforcedStyleForEmptyBraces, SupportedStylesForEmptyBraces, SpaceBeforeBlockParameters.
502
- # SupportedStyles: space, no_space
503
- # SupportedStylesForEmptyBraces: space, no_space
504
- Style/SpaceInsideBlockBraces:
391
+ # Configuration parameters: EnforcedStyle, AllowInnerSlashes.
392
+ # SupportedStyles: slashes, percent_r, mixed
393
+ Style/RegexpLiteral:
505
394
  Exclude:
506
- - 'app/controllers/concerns/blacklight/bookmarks.rb'
507
- - 'app/controllers/concerns/blacklight/controller.rb'
508
- - 'app/controllers/concerns/blacklight/search_helper.rb'
509
- - 'app/helpers/blacklight/catalog_helper_behavior.rb'
510
- - 'app/helpers/blacklight/facets_helper_behavior.rb'
511
- - 'lib/blacklight/search_builder.rb'
512
- - 'lib/blacklight/solr/request.rb'
513
- - 'lib/blacklight/solr/response.rb'
514
- - 'lib/blacklight/solr/response/group.rb'
395
+ - 'app/views/catalog/_document.atom.builder'
515
396
 
516
- # Offense count: 8
397
+ # Offense count: 7
517
398
  # Cop supports --auto-correct.
518
- Style/SpaceInsideBrackets:
399
+ # Configuration parameters: EnforcedStyle.
400
+ # SupportedStyles: implicit, explicit
401
+ Style/RescueStandardError:
519
402
  Exclude:
403
+ - 'app/models/record_mailer.rb'
404
+ - 'lib/blacklight.rb'
520
405
  - 'lib/blacklight/configuration/fields.rb'
406
+ - 'lib/railties/blacklight.rake'
521
407
 
522
- # Offense count: 18
408
+ # Offense count: 14
523
409
  # Cop supports --auto-correct.
524
- # Configuration parameters: EnforcedStyle, SupportedStyles, EnforcedStyleForEmptyBraces, SupportedStylesForEmptyBraces.
525
- # SupportedStyles: space, no_space, compact
526
- # SupportedStylesForEmptyBraces: space, no_space
527
- Style/SpaceInsideHashLiteralBraces:
528
- Exclude:
529
- - 'app/controllers/concerns/blacklight/bookmarks.rb'
530
- - 'app/controllers/concerns/blacklight/catalog.rb'
531
- - 'app/controllers/concerns/blacklight/search_context.rb'
532
- - 'app/helpers/blacklight/render_constraints_helper_behavior.rb'
533
- - 'app/helpers/blacklight/url_helper_behavior.rb'
534
- - 'app/models/concerns/blacklight/document/extensions.rb'
535
- - 'lib/blacklight/configuration.rb'
536
- - 'lib/blacklight/solr/repository.rb'
410
+ # Configuration parameters: MinSize.
411
+ # SupportedStyles: percent, brackets
412
+ Style/SymbolArray:
413
+ EnforcedStyle: brackets
537
414
 
538
- # Offense count: 18
415
+ # Offense count: 1
539
416
  # Cop supports --auto-correct.
540
- Style/SpaceInsideParens:
417
+ Style/UnneededInterpolation:
541
418
  Exclude:
542
- - 'app/controllers/concerns/blacklight/search_context.rb'
543
- - 'app/helpers/blacklight/catalog_helper_behavior.rb'
544
- - 'app/helpers/blacklight/facets_helper_behavior.rb'
545
- - 'app/helpers/blacklight/search_history_constraints_helper_behavior.rb'
546
- - 'app/helpers/blacklight/url_helper_behavior.rb'
547
- - 'app/models/concerns/blacklight/document/dublin_core.rb'
548
- - 'app/models/concerns/blacklight/document/extensions.rb'
549
- - 'app/models/record_mailer.rb'
550
- - 'lib/blacklight/search_state.rb'
551
- - 'lib/blacklight/solr/search_builder_behavior.rb'
552
-
553
- # Offense count: 199
554
- # Cop supports --auto-correct.
555
- Style/TrailingWhitespace:
556
- Enabled: false
419
+ - 'app/views/catalog/opensearch.xml.builder'