blacklight 6.0.2 → 6.1.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (62) hide show
  1. checksums.yaml +4 -4
  2. data/.rubocop.yml +6 -6
  3. data/.rubocop_todo.yml +448 -87
  4. data/.travis.yml +1 -1
  5. data/VERSION +1 -1
  6. data/app/controllers/concerns/blacklight/bookmarks.rb +8 -8
  7. data/app/controllers/concerns/blacklight/catalog.rb +5 -5
  8. data/app/controllers/concerns/blacklight/controller.rb +5 -5
  9. data/app/controllers/concerns/blacklight/saved_searches.rb +4 -2
  10. data/app/controllers/concerns/blacklight/search_context.rb +3 -0
  11. data/app/controllers/concerns/blacklight/token_based_user.rb +1 -1
  12. data/app/helpers/blacklight/blacklight_helper_behavior.rb +3 -3
  13. data/app/helpers/blacklight/catalog_helper_behavior.rb +20 -9
  14. data/app/helpers/blacklight/configuration_helper_behavior.rb +1 -1
  15. data/app/helpers/blacklight/deprecated_url_helper_behavior.rb +1 -1
  16. data/app/helpers/blacklight/facets_helper_behavior.rb +2 -2
  17. data/app/helpers/blacklight/hash_as_hidden_fields_helper_behavior.rb +1 -1
  18. data/app/helpers/blacklight/render_constraints_helper_behavior.rb +18 -8
  19. data/app/helpers/blacklight/render_partials_helper.rb +15 -3
  20. data/app/models/concerns/blacklight/configurable.rb +4 -8
  21. data/app/models/concerns/blacklight/document.rb +3 -3
  22. data/app/models/concerns/blacklight/document/dublin_core.rb +1 -1
  23. data/app/models/concerns/blacklight/document/extensions.rb +1 -1
  24. data/app/models/concerns/blacklight/user.rb +1 -1
  25. data/app/models/record_mailer.rb +6 -1
  26. data/app/models/search.rb +2 -2
  27. data/blacklight.gemspec +5 -2
  28. data/config/locales/blacklight.de.yml +1 -0
  29. data/config/locales/blacklight.en.yml +1 -0
  30. data/config/locales/blacklight.es.yml +1 -0
  31. data/config/locales/blacklight.fr.yml +1 -0
  32. data/config/locales/blacklight.it.yml +1 -0
  33. data/config/locales/blacklight.pt-BR.yml +1 -0
  34. data/lib/blacklight.rb +2 -2
  35. data/lib/blacklight/abstract_repository.rb +2 -2
  36. data/lib/blacklight/configuration/field.rb +1 -1
  37. data/lib/blacklight/configuration/search_field.rb +1 -1
  38. data/lib/blacklight/configuration/sort_field.rb +1 -1
  39. data/lib/blacklight/search_builder.rb +8 -4
  40. data/lib/blacklight/search_state.rb +3 -3
  41. data/lib/blacklight/solr/repository.rb +3 -3
  42. data/lib/blacklight/solr/request.rb +2 -2
  43. data/lib/blacklight/solr/response.rb +1 -1
  44. data/lib/blacklight/solr/response/spelling.rb +1 -1
  45. data/lib/blacklight/solr/search_builder_behavior.rb +7 -7
  46. data/lib/blacklight/utils.rb +5 -5
  47. data/lib/generators/blacklight/assets_generator.rb +1 -1
  48. data/lib/generators/blacklight/controller_generator.rb +13 -15
  49. data/lib/generators/blacklight/document_generator.rb +5 -4
  50. data/lib/generators/blacklight/install_generator.rb +24 -27
  51. data/lib/generators/blacklight/models_generator.rb +18 -16
  52. data/lib/generators/blacklight/search_builder_generator.rb +4 -4
  53. data/lib/generators/blacklight/solr4_generator.rb +14 -9
  54. data/lib/generators/blacklight/solr5_generator.rb +1 -1
  55. data/lib/generators/blacklight/templates/{blacklight.css.scss → blacklight.scss} +0 -0
  56. data/lib/generators/blacklight/templates/solr_document.rb +6 -8
  57. data/lib/generators/blacklight/test_support_generator.rb +5 -3
  58. data/lib/generators/blacklight/user_generator.rb +18 -12
  59. data/lib/railties/blacklight.rake +2 -2
  60. data/tasks/blacklight.rake +1 -3
  61. metadata +17 -10
  62. data/.rubocop_hound.yml +0 -1063
checksums.yaml CHANGED
@@ -1,7 +1,7 @@
1
1
  ---
2
2
  SHA1:
3
- metadata.gz: 5963608c415b8842869d7eed4bf5e5c085eacfb1
4
- data.tar.gz: 3e87f351736a2c550d5b044495f4887016c5d086
3
+ metadata.gz: 10118d3a200e5152de30c6f1738a5ce717e41802
4
+ data.tar.gz: 36743744db251f2c367347d538f9a4414422e33e
5
5
  SHA512:
6
- metadata.gz: d29ad4a070c192929e7f3b5bec0743796ec56ce01dc8380eafbe13c79a33aba3c1e79a09893e7acb748786cd455445696fc658e5308c4fe77f98a1b57f4177f5
7
- data.tar.gz: d17df306da1fcc106a4254d7b0509653b5944f3b469f980ab795e22f7d8a741200511808f31d1983a27c5533fb3090ce49e8045ca1ec4d06417195214d37e6d1
6
+ metadata.gz: 42344240b708f4b0a48c8d8837b4a2aef285fb2a5cbdbb5b73d7585db3cea3a6f43d11f87ce2fda62ecd543fba5f08540759d489188ab3ffc85e6c23da9afadd
7
+ data.tar.gz: cd6920cc46fc9823f9953debe129d8fa9a21dadcb1dd3e19a8c9b0c281c274bc084a2902e1ed54a85fa9186970c9294fcba153e584c56992b7b596828db7eede
data/.rubocop.yml CHANGED
@@ -1,16 +1,16 @@
1
1
  inherit_from:
2
- - .rubocop_hound.yml
3
2
  - .rubocop_todo.yml
4
3
 
5
4
  AllCops:
6
5
  Exclude:
7
6
  - "lib/generators/blacklight/templates/**/*"
8
7
  - "spec/**/*"
9
- RunRailsCops: true
8
+
9
+ Rails:
10
+ Enabled: true
10
11
 
11
12
  Metrics/LineLength:
12
- Enabled: false
13
+ Max: 200
13
14
 
14
- # Offense count: 61
15
- Metrics/AbcSize:
16
- Max: 59
15
+ Style/StringLiterals:
16
+ Enabled: false
data/.rubocop_todo.yml CHANGED
@@ -1,258 +1,619 @@
1
- # This configuration was generated by `rubocop --auto-gen-config`
2
- # on 2015-04-13 15:13:47 -0700 using RuboCop version 0.30.0.
1
+ # This configuration was generated by
2
+ # `rubocop --auto-gen-config`
3
+ # on 2016-03-04 09:27:52 -0800 using RuboCop version 0.37.2.
3
4
  # The point is for the user to remove these configuration records
4
5
  # one by one as the offenses are removed from the code base.
5
6
  # Note that changes in the inspected code, or installation of new
6
7
  # versions of RuboCop, may require this file to be generated again.
7
8
 
8
- # Offense count: 19
9
- # Configuration parameters: AlignWith, SupportedStyles.
9
+ # Offense count: 24
10
+ # Cop supports --auto-correct.
11
+ # Configuration parameters: AlignWith, SupportedStyles, AutoCorrect.
12
+ # SupportedStyles: keyword, variable, start_of_line
10
13
  Lint/EndAlignment:
11
14
  Enabled: false
12
15
 
13
- # Offense count: 37
16
+ # Offense count: 30
14
17
  # Cop supports --auto-correct.
18
+ # Configuration parameters: IgnoreEmptyBlocks.
15
19
  Lint/UnusedBlockArgument:
16
- Enabled: false
17
-
18
- # Offense count: 25
19
- # Cop supports --auto-correct.
20
+ Exclude:
21
+ - 'app/controllers/concerns/blacklight/search_context.rb'
22
+ - 'app/helpers/blacklight/configuration_helper_behavior.rb'
23
+ - 'app/models/concerns/blacklight/document/dublin_core.rb'
24
+ - 'lib/blacklight/configuration.rb'
25
+ - 'lib/blacklight/configuration/fields.rb'
26
+ - 'lib/blacklight/engine.rb'
27
+ - 'lib/blacklight/parameters.rb'
28
+ - 'lib/blacklight/solr/response/facets.rb'
29
+ - 'lib/blacklight/solr/search_builder_behavior.rb'
30
+ - 'lib/railties/blacklight.rake'
31
+ - 'tasks/blacklight.rake'
32
+
33
+ # Offense count: 21
34
+ # Cop supports --auto-correct.
35
+ # Configuration parameters: AllowUnusedKeywordArguments, IgnoreEmptyMethods.
20
36
  Lint/UnusedMethodArgument:
21
- Enabled: false
37
+ Exclude:
38
+ - 'app/controllers/concerns/blacklight/default_component_configuration.rb'
39
+ - 'app/helpers/blacklight/blacklight_helper_behavior.rb'
40
+ - 'app/helpers/blacklight/catalog_helper_behavior.rb'
41
+ - 'app/helpers/blacklight/component_helper_behavior.rb'
42
+ - 'app/helpers/blacklight/configuration_helper_behavior.rb'
43
+ - 'app/helpers/blacklight/deprecated_url_helper_behavior.rb'
44
+ - 'app/helpers/blacklight/facets_helper_behavior.rb'
45
+ - 'app/helpers/blacklight/render_partials_helper.rb'
46
+ - 'app/helpers/blacklight/search_history_constraints_helper_behavior.rb'
47
+ - 'app/models/concerns/blacklight/document.rb'
48
+ - 'lib/blacklight/abstract_repository.rb'
49
+ - 'lib/blacklight/configuration/field.rb'
50
+ - 'lib/blacklight/search_builder.rb'
51
+ - 'lib/blacklight/search_state.rb'
22
52
 
23
- # Offense count: 5
53
+ # Offense count: 9
24
54
  Lint/UselessAssignment:
25
- Enabled: false
55
+ Exclude:
56
+ - 'app/controllers/concerns/blacklight/search_context.rb'
57
+ - 'app/helpers/blacklight/deprecated_url_helper_behavior.rb'
58
+ - 'app/helpers/blacklight/facets_helper_behavior.rb'
59
+ - 'app/models/bookmark.rb'
60
+ - 'lib/blacklight/routes/exportable.rb'
61
+ - 'lib/blacklight/routes/searchable.rb'
62
+ - 'lib/blacklight/solr/response/spelling.rb'
63
+ - 'lib/railties/blacklight.rake'
64
+
65
+ # Offense count: 58
66
+ Metrics/AbcSize:
67
+ Max: 54
26
68
 
27
- # Offense count: 10
69
+ # Offense count: 1
70
+ Metrics/BlockNesting:
71
+ Max: 4
72
+
73
+ # Offense count: 3
74
+ # Configuration parameters: CountComments.
75
+ Metrics/ClassLength:
76
+ Max: 193
77
+
78
+ # Offense count: 22
79
+ Metrics/CyclomaticComplexity:
80
+ Max: 19
81
+
82
+ # Offense count: 63
83
+ # Configuration parameters: CountComments.
84
+ Metrics/MethodLength:
85
+ Max: 50
86
+
87
+ # Offense count: 9
28
88
  # Configuration parameters: CountComments.
29
89
  Metrics/ModuleLength:
30
- Max: 212
90
+ Max: 218
91
+
92
+ # Offense count: 20
93
+ Metrics/PerceivedComplexity:
94
+ Max: 22
95
+
96
+ # Offense count: 6
97
+ # Cop supports --auto-correct.
98
+ Rails/Delegate:
99
+ Exclude:
100
+ - 'app/controllers/concerns/blacklight/controller.rb'
101
+ - 'app/controllers/concerns/blacklight/request_builders.rb'
102
+ - 'app/controllers/concerns/blacklight/search_helper.rb'
103
+ - 'app/helpers/blacklight/deprecated_url_helper_behavior.rb'
104
+ - 'app/models/concerns/blacklight/document.rb'
105
+ - 'lib/blacklight/search_builder.rb'
31
106
 
32
107
  # Offense count: 2
33
108
  # Cop supports --auto-correct.
34
- # Configuration parameters: EnforcedStyle, SupportedStyles.
109
+ # Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth.
110
+ # SupportedStyles: outdent, indent
35
111
  Style/AccessModifierIndentation:
36
112
  Enabled: false
37
113
 
38
114
  # Offense count: 9
39
115
  # Cop supports --auto-correct.
40
116
  # Configuration parameters: EnforcedStyle, SupportedStyles.
117
+ # SupportedStyles: prefer_alias, prefer_alias_method
118
+ Style/Alias:
119
+ Exclude:
120
+ - 'app/models/concerns/blacklight/document.rb'
121
+ - 'app/models/concerns/blacklight/document/dublin_core.rb'
122
+ - 'lib/blacklight/configuration.rb'
123
+ - 'lib/blacklight/search_builder.rb'
124
+ - 'lib/blacklight/solr/response.rb'
125
+ - 'lib/blacklight/solr/response/group_response.rb'
126
+
127
+ # Offense count: 7
128
+ # Cop supports --auto-correct.
129
+ # Configuration parameters: EnforcedStyle, SupportedStyles.
130
+ # SupportedStyles: with_first_parameter, with_fixed_indentation
41
131
  Style/AlignParameters:
42
- Enabled: false
132
+ Exclude:
133
+ - 'app/helpers/blacklight/render_constraints_helper_behavior.rb'
134
+ - 'app/helpers/blacklight/search_history_constraints_helper_behavior.rb'
135
+ - 'lib/blacklight/configuration.rb'
136
+ - 'lib/generators/blacklight/solr4_generator.rb'
43
137
 
44
- # Offense count: 87
138
+ # Offense count: 73
45
139
  # Cop supports --auto-correct.
46
140
  # Configuration parameters: EnforcedStyle, SupportedStyles.
141
+ # SupportedStyles: always, conditionals
47
142
  Style/AndOr:
48
143
  Enabled: false
49
144
 
50
145
  # Offense count: 3
51
146
  # Cop supports --auto-correct.
52
147
  # Configuration parameters: EnforcedStyle, SupportedStyles.
148
+ # SupportedStyles: braces, no_braces, context_dependent
53
149
  Style/BracesAroundHashParameters:
150
+ Exclude:
151
+ - 'lib/blacklight/solr/repository.rb'
152
+ - 'lib/blacklight/solr/response/facets.rb'
153
+ - 'lib/generators/blacklight/test_support_generator.rb'
154
+
155
+ # Offense count: 8
156
+ Style/CaseEquality:
157
+ Exclude:
158
+ - 'app/helpers/blacklight/catalog_helper_behavior.rb'
159
+ - 'app/helpers/blacklight/facets_helper_behavior.rb'
160
+ - 'app/presenters/blacklight/document_presenter.rb'
161
+ - 'lib/blacklight/configuration/context.rb'
162
+ - 'lib/blacklight/configuration/fields.rb'
163
+ - 'lib/blacklight/search_builder.rb'
164
+
165
+ # Offense count: 23
166
+ # Cop supports --auto-correct.
167
+ # Configuration parameters: IndentWhenRelativeTo, SupportedStyles, IndentOneStep, IndentationWidth.
168
+ # SupportedStyles: case, end
169
+ Style/CaseIndentation:
54
170
  Enabled: false
55
171
 
56
- # Offense count: 25
57
- # Configuration parameters: IndentWhenRelativeTo, SupportedStyles, IndentOneStep.
58
- Style/CaseIndentation:
172
+ # Offense count: 50
173
+ # Configuration parameters: EnforcedStyle, SupportedStyles.
174
+ # SupportedStyles: nested, compact
175
+ Style/ClassAndModuleChildren:
59
176
  Enabled: false
60
177
 
61
- # Offense count: 5
178
+ # Offense count: 4
62
179
  # Cop supports --auto-correct.
63
180
  Style/ClosingParenthesisIndentation:
64
- Enabled: false
181
+ Exclude:
182
+ - 'app/helpers/blacklight/facets_helper_behavior.rb'
183
+ - 'app/helpers/blacklight/render_constraints_helper_behavior.rb'
184
+ - 'app/helpers/blacklight/search_history_constraints_helper_behavior.rb'
185
+ - 'lib/blacklight/configuration.rb'
65
186
 
66
- # Offense count: 19
187
+ # Offense count: 2
67
188
  # Cop supports --auto-correct.
68
- # Configuration parameters: PreferredMethods.
69
- Style/CollectionMethods:
189
+ # Configuration parameters: SingleLineConditionsOnly.
190
+ Style/ConditionalAssignment:
191
+ Exclude:
192
+ - 'lib/blacklight/solr/response/spelling.rb'
193
+
194
+ # Offense count: 52
195
+ Style/Documentation:
70
196
  Enabled: false
71
197
 
72
- # Offense count: 7
198
+ # Offense count: 9
73
199
  # Cop supports --auto-correct.
74
200
  # Configuration parameters: EnforcedStyle, SupportedStyles.
201
+ # SupportedStyles: leading, trailing
75
202
  Style/DotPosition:
76
203
  Enabled: false
77
204
 
78
- # Offense count: 24
205
+ # Offense count: 1
206
+ Style/DoubleNegation:
207
+ Exclude:
208
+ - 'lib/blacklight/search_builder.rb'
209
+
210
+ # Offense count: 21
79
211
  # Cop supports --auto-correct.
80
212
  Style/ElseAlignment:
81
- Enabled: false
213
+ Exclude:
214
+ - 'app/controllers/concerns/blacklight/search_context.rb'
215
+ - 'app/helpers/blacklight/catalog_helper_behavior.rb'
216
+ - 'app/helpers/blacklight/facets_helper_behavior.rb'
217
+ - 'app/helpers/blacklight/url_helper_behavior.rb'
218
+ - 'app/models/concerns/blacklight/configurable.rb'
219
+ - 'app/presenters/blacklight/document_presenter.rb'
220
+ - 'lib/blacklight/search_builder.rb'
221
+ - 'lib/blacklight/solr/response/facets.rb'
222
+ - 'lib/blacklight/solr/search_builder_behavior.rb'
82
223
 
83
- # Offense count: 19
224
+ # Offense count: 12
84
225
  # Cop supports --auto-correct.
85
226
  Style/EmptyLines:
86
- Enabled: false
227
+ Exclude:
228
+ - 'Vagrantfile'
229
+ - 'app/controllers/concerns/blacklight/bookmarks.rb'
230
+ - 'app/controllers/concerns/blacklight/catalog.rb'
231
+ - 'app/controllers/concerns/blacklight/controller.rb'
232
+ - 'app/helpers/blacklight/facets_helper_behavior.rb'
233
+ - 'app/helpers/blacklight/render_partials_helper.rb'
234
+ - 'app/presenters/blacklight/json_presenter.rb'
235
+ - 'lib/blacklight/solr/search_builder_behavior.rb'
236
+ - 'lib/blacklight/utils.rb'
237
+ - 'lib/generators/blacklight/models_generator.rb'
238
+ - 'lib/generators/blacklight/test_support_generator.rb'
87
239
 
88
- # Offense count: 13
240
+ # Offense count: 10
89
241
  # Cop supports --auto-correct.
90
242
  Style/EmptyLinesAroundAccessModifier:
91
- Enabled: false
243
+ Exclude:
244
+ - 'app/controllers/concerns/blacklight/bookmarks.rb'
245
+ - 'app/controllers/concerns/blacklight/catalog.rb'
246
+ - 'app/helpers/blacklight/render_partials_helper.rb'
247
+ - 'lib/blacklight/abstract_repository.rb'
248
+ - 'lib/blacklight/configuration/fields.rb'
249
+ - 'lib/blacklight/search_builder.rb'
250
+ - 'lib/blacklight/solr/response/facets.rb'
251
+ - 'lib/blacklight/utils.rb'
92
252
 
93
- # Offense count: 4
253
+ # Offense count: 5
94
254
  # Cop supports --auto-correct.
95
255
  # Configuration parameters: EnforcedStyle, SupportedStyles.
256
+ # SupportedStyles: empty_lines, no_empty_lines
96
257
  Style/EmptyLinesAroundBlockBody:
97
- Enabled: false
258
+ Exclude:
259
+ - 'Vagrantfile'
260
+ - 'app/controllers/concerns/blacklight/controller.rb'
261
+ - 'app/controllers/concerns/blacklight/search_context.rb'
262
+ - 'app/controllers/concerns/blacklight/token_based_user.rb'
263
+ - 'lib/generators/blacklight/install_generator.rb'
98
264
 
99
265
  # Offense count: 22
100
266
  # Cop supports --auto-correct.
101
267
  # Configuration parameters: EnforcedStyle, SupportedStyles.
268
+ # SupportedStyles: empty_lines, no_empty_lines
102
269
  Style/EmptyLinesAroundClassBody:
103
270
  Enabled: false
104
271
 
105
- # Offense count: 15
272
+ # Offense count: 9
106
273
  # Cop supports --auto-correct.
107
274
  Style/EmptyLinesAroundMethodBody:
108
- Enabled: false
275
+ Exclude:
276
+ - 'app/controllers/concerns/blacklight/base.rb'
277
+ - 'app/controllers/concerns/blacklight/search_context.rb'
278
+ - 'lib/blacklight/configuration.rb'
279
+ - 'lib/blacklight/solr/response/group_response.rb'
280
+ - 'lib/blacklight/solr/search_builder_behavior.rb'
281
+ - 'lib/generators/blacklight/assets_generator.rb'
282
+ - 'lib/generators/blacklight/install_generator.rb'
109
283
 
110
- # Offense count: 35
284
+ # Offense count: 33
111
285
  # Cop supports --auto-correct.
112
286
  # Configuration parameters: EnforcedStyle, SupportedStyles.
287
+ # SupportedStyles: empty_lines, no_empty_lines
113
288
  Style/EmptyLinesAroundModuleBody:
114
289
  Enabled: false
115
290
 
116
- # Offense count: 99
291
+ # Offense count: 27
117
292
  # Cop supports --auto-correct.
293
+ # Configuration parameters: AllowForAlignment, ForceEqualSignAlignment.
118
294
  Style/ExtraSpacing:
119
- Enabled: false
295
+ Exclude:
296
+ - 'app/helpers/blacklight/catalog_helper_behavior.rb'
297
+ - 'app/helpers/blacklight/configuration_helper_behavior.rb'
298
+ - 'app/models/concerns/blacklight/document/dublin_core.rb'
299
+ - 'app/models/concerns/blacklight/document/export.rb'
300
+ - 'app/models/record_mailer.rb'
301
+ - 'blacklight.gemspec'
302
+ - 'config/routes.rb'
303
+ - 'db/migrate/20140202020201_create_searches.rb'
304
+ - 'lib/blacklight/configuration.rb'
305
+ - 'lib/generators/blacklight/controller_generator.rb'
306
+ - 'lib/generators/blacklight/document_generator.rb'
307
+ - 'lib/generators/blacklight/install_generator.rb'
308
+ - 'lib/generators/blacklight/search_builder_generator.rb'
309
+ - 'lib/railties/blacklight.rake'
310
+ - 'tasks/blacklight.rake'
120
311
 
121
- # Offense count: 161
312
+ # Offense count: 10
313
+ # Configuration parameters: MinBodyLength.
314
+ Style/GuardClause:
315
+ Exclude:
316
+ - 'app/controllers/concerns/blacklight/base.rb'
317
+ - 'app/controllers/concerns/blacklight/bookmarks.rb'
318
+ - 'app/controllers/concerns/blacklight/catalog.rb'
319
+ - 'app/controllers/concerns/blacklight/search_context.rb'
320
+ - 'app/helpers/blacklight/catalog_helper_behavior.rb'
321
+ - 'lib/blacklight/solr/search_builder_behavior.rb'
322
+
323
+ # Offense count: 121
122
324
  # Cop supports --auto-correct.
123
325
  # Configuration parameters: EnforcedStyle, SupportedStyles, UseHashRocketsWithSymbolValues.
326
+ # SupportedStyles: ruby19, ruby19_no_mixed_keys, hash_rockets
124
327
  Style/HashSyntax:
125
328
  Enabled: false
126
329
 
127
- # Offense count: 4
330
+ # Offense count: 1
331
+ Style/IfInsideElse:
332
+ Exclude:
333
+ - 'app/controllers/concerns/blacklight/bookmarks.rb'
334
+
335
+ # Offense count: 19
128
336
  # Cop supports --auto-correct.
129
- # Configuration parameters: EnforcedStyle, SupportedStyles.
337
+ # Configuration parameters: MaxLineLength.
338
+ Style/IfUnlessModifier:
339
+ Exclude:
340
+ - 'app/controllers/concerns/blacklight/controller.rb'
341
+ - 'app/controllers/concerns/blacklight/request_builders.rb'
342
+ - 'app/controllers/concerns/blacklight/search_helper.rb'
343
+ - 'app/controllers/concerns/blacklight/token_based_user.rb'
344
+ - 'app/helpers/blacklight/catalog_helper_behavior.rb'
345
+ - 'app/helpers/blacklight/url_helper_behavior.rb'
346
+ - 'app/models/blacklight/facet_paginator.rb'
347
+ - 'app/models/search.rb'
348
+ - 'lib/blacklight/configuration.rb'
349
+ - 'lib/blacklight/configuration/fields.rb'
350
+ - 'lib/blacklight/search_state.rb'
351
+ - 'lib/blacklight/solr/search_builder_behavior.rb'
352
+ - 'lib/generators/blacklight/install_generator.rb'
353
+ - 'lib/railties/blacklight.rake'
354
+
355
+ # Offense count: 2
356
+ # Cop supports --auto-correct.
357
+ # Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth.
358
+ # SupportedStyles: special_inside_parentheses, consistent, align_braces
130
359
  Style/IndentHash:
131
360
  Enabled: false
132
361
 
133
- # Offense count: 61
362
+ # Offense count: 54
134
363
  # Cop supports --auto-correct.
135
364
  # Configuration parameters: EnforcedStyle, SupportedStyles.
365
+ # SupportedStyles: normal, rails
136
366
  Style/IndentationConsistency:
137
- Enabled: false
138
-
139
- # Offense count: 27
367
+ Exclude:
368
+ - 'app/controllers/concerns/blacklight/catalog.rb'
369
+ - 'app/controllers/concerns/blacklight/controller.rb'
370
+ - 'app/controllers/concerns/blacklight/saved_searches.rb'
371
+ - 'app/controllers/concerns/blacklight/search_helper.rb'
372
+ - 'app/helpers/blacklight/catalog_helper_behavior.rb'
373
+ - 'app/helpers/blacklight/render_partials_helper.rb'
374
+ - 'app/presenters/blacklight/document_presenter.rb'
375
+ - 'lib/blacklight/abstract_repository.rb'
376
+ - 'lib/blacklight/configuration.rb'
377
+ - 'lib/blacklight/solr/repository.rb'
378
+ - 'lib/blacklight/solr/response.rb'
379
+ - 'lib/blacklight/solr/response/spelling.rb'
380
+
381
+ # Offense count: 26
140
382
  # Cop supports --auto-correct.
141
383
  # Configuration parameters: Width.
142
384
  Style/IndentationWidth:
143
- Enabled: false
385
+ Exclude:
386
+ - 'app/controllers/concerns/blacklight/bookmarks.rb'
387
+ - 'app/controllers/concerns/blacklight/search_context.rb'
388
+ - 'app/controllers/concerns/blacklight/search_fields.rb'
389
+ - 'app/controllers/concerns/blacklight/token_based_user.rb'
390
+ - 'app/helpers/blacklight/catalog_helper_behavior.rb'
391
+ - 'app/helpers/blacklight/facets_helper_behavior.rb'
392
+ - 'app/helpers/blacklight/render_constraints_helper_behavior.rb'
393
+ - 'app/helpers/blacklight/render_partials_helper.rb'
394
+ - 'app/helpers/blacklight/url_helper_behavior.rb'
395
+ - 'app/models/concerns/blacklight/configurable.rb'
396
+ - 'app/presenters/blacklight/document_presenter.rb'
397
+ - 'lib/blacklight/search_builder.rb'
398
+ - 'lib/blacklight/solr/response/facets.rb'
399
+ - 'lib/blacklight/solr/search_builder_behavior.rb'
400
+ - 'lib/generators/blacklight/assets_generator.rb'
144
401
 
145
- # Offense count: 13
402
+ # Offense count: 9
146
403
  # Cop supports --auto-correct.
147
404
  Style/LeadingCommentSpace:
148
- Enabled: false
405
+ Exclude:
406
+ - 'app/models/blacklight/facet_paginator.rb'
407
+ - 'app/models/concerns/blacklight/configurable.rb'
408
+ - 'app/models/concerns/blacklight/document/export.rb'
409
+ - 'lib/blacklight/configuration.rb'
410
+ - 'lib/blacklight/solr/response/spelling.rb'
149
411
 
150
- # Offense count: 177
412
+ # Offense count: 146
151
413
  # Cop supports --auto-correct.
152
414
  # Configuration parameters: EnforcedStyle, SupportedStyles.
415
+ # SupportedStyles: require_parentheses, require_no_parentheses, require_no_parentheses_except_multiline
153
416
  Style/MethodDefParentheses:
154
417
  Enabled: false
155
418
 
156
- # Offense count: 3
419
+ # Offense count: 2
157
420
  # Cop supports --auto-correct.
158
421
  Style/MultilineBlockLayout:
422
+ Exclude:
423
+ - 'lib/generators/blacklight/install_generator.rb'
424
+ - 'lib/generators/blacklight/test_support_generator.rb'
425
+
426
+ # Offense count: 13
427
+ # Cop supports --auto-correct.
428
+ # Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth.
429
+ # SupportedStyles: aligned, indented
430
+ Style/MultilineMethodCallIndentation:
159
431
  Enabled: false
160
432
 
161
- # Offense count: 36
433
+ # Offense count: 12
162
434
  # Cop supports --auto-correct.
163
- # Configuration parameters: EnforcedStyle, SupportedStyles.
435
+ # Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth.
436
+ # SupportedStyles: aligned, indented
164
437
  Style/MultilineOperationIndentation:
165
438
  Enabled: false
166
439
 
167
- # Offense count: 3
440
+ # Offense count: 2
168
441
  # Cop supports --auto-correct.
169
- # Configuration parameters: AllowSafeAssignment.
170
- Style/ParenthesesAroundCondition:
171
- Enabled: false
442
+ Style/MutableConstant:
443
+ Exclude:
444
+ - 'lib/blacklight/solr/request.rb'
172
445
 
173
- # Offense count: 6
446
+ # Offense count: 4
447
+ # Cop supports --auto-correct.
448
+ # Configuration parameters: EnforcedStyle, MinBodyLength, SupportedStyles.
449
+ # SupportedStyles: skip_modifier_ifs, always
450
+ Style/Next:
451
+ Exclude:
452
+ - 'lib/blacklight/solr/response/facets.rb'
453
+ - 'lib/blacklight/solr/search_builder_behavior.rb'
454
+
455
+ # Offense count: 8
456
+ # Configuration parameters: NamePrefix, NamePrefixBlacklist, NameWhitelist.
457
+ # NamePrefix: is_, has_, have_
458
+ # NamePrefixBlacklist: is_, has_, have_
459
+ # NameWhitelist: is_a?
460
+ Style/PredicateName:
461
+ Exclude:
462
+ - 'app/controllers/concerns/blacklight/catalog.rb'
463
+ - 'app/controllers/concerns/blacklight/controller.rb'
464
+ - 'app/helpers/blacklight/catalog_helper_behavior.rb'
465
+ - 'app/helpers/blacklight/configuration_helper_behavior.rb'
466
+ - 'app/helpers/blacklight/facets_helper_behavior.rb'
467
+ - 'app/models/concerns/blacklight/document.rb'
468
+ - 'app/models/concerns/blacklight/solr/document.rb'
469
+ - 'lib/generators/blacklight/assets_generator.rb'
470
+
471
+ # Offense count: 4
174
472
  # Cop supports --auto-correct.
175
473
  # Configuration parameters: AllowMultipleReturnValues.
176
474
  Style/RedundantReturn:
177
- Enabled: false
475
+ Exclude:
476
+ - 'app/helpers/blacklight/blacklight_helper_behavior.rb'
477
+ - 'app/helpers/blacklight/facets_helper_behavior.rb'
478
+ - 'lib/blacklight.rb'
479
+ - 'lib/blacklight/solr/search_builder_behavior.rb'
178
480
 
179
- # Offense count: 44
481
+ # Offense count: 42
180
482
  # Cop supports --auto-correct.
181
483
  Style/RedundantSelf:
182
484
  Enabled: false
183
485
 
184
- # Offense count: 1
185
- Style/RescueModifier:
186
- Enabled: false
187
-
188
- # Offense count: 10
189
- # Cop supports --auto-correct.
190
- Style/SingleSpaceBeforeFirstArg:
191
- Enabled: false
192
-
193
- # Offense count: 30
486
+ # Offense count: 24
194
487
  # Cop supports --auto-correct.
195
488
  Style/SpaceAfterComma:
196
- Enabled: false
489
+ Exclude:
490
+ - 'app/controllers/concerns/blacklight/search_context.rb'
491
+ - 'app/helpers/blacklight/configuration_helper_behavior.rb'
492
+ - 'app/helpers/blacklight/facets_helper_behavior.rb'
493
+ - 'app/helpers/blacklight/render_constraints_helper_behavior.rb'
494
+ - 'app/models/concerns/blacklight/document/dublin_core.rb'
495
+ - 'lib/blacklight/configuration.rb'
496
+ - 'lib/blacklight/configuration/fields.rb'
497
+ - 'lib/blacklight/parameters.rb'
498
+ - 'lib/blacklight/solr/response/facets.rb'
499
+ - 'lib/blacklight/solr/search_builder_behavior.rb'
500
+ - 'lib/blacklight/utils.rb'
197
501
 
198
502
  # Offense count: 3
199
503
  # Cop supports --auto-correct.
200
504
  # Configuration parameters: EnforcedStyleInsidePipes, SupportedStyles.
505
+ # SupportedStyles: space, no_space
201
506
  Style/SpaceAroundBlockParameters:
202
- Enabled: false
507
+ Exclude:
508
+ - 'app/controllers/concerns/blacklight/catalog.rb'
509
+ - 'app/models/concerns/blacklight/document/extensions.rb'
203
510
 
204
- # Offense count: 42
511
+ # Offense count: 28
205
512
  # Cop supports --auto-correct.
206
513
  # Configuration parameters: EnforcedStyle, SupportedStyles.
514
+ # SupportedStyles: space, no_space
207
515
  Style/SpaceAroundEqualsInParameterDefault:
208
516
  Enabled: false
209
517
 
210
- # Offense count: 24
518
+ # Offense count: 17
211
519
  # Cop supports --auto-correct.
212
- # Configuration parameters: MultiSpaceAllowedForOperators.
520
+ # Configuration parameters: AllowForAlignment.
213
521
  Style/SpaceAroundOperators:
214
- Enabled: false
522
+ Exclude:
523
+ - 'Gemfile'
524
+ - 'app/controllers/concerns/blacklight/request_builders.rb'
525
+ - 'app/helpers/blacklight/blacklight_helper_behavior.rb'
526
+ - 'app/helpers/blacklight/facets_helper_behavior.rb'
527
+ - 'app/helpers/blacklight/render_constraints_helper_behavior.rb'
528
+ - 'app/helpers/blacklight/search_history_constraints_helper_behavior.rb'
529
+ - 'app/helpers/blacklight/url_helper_behavior.rb'
530
+ - 'app/models/concerns/blacklight/document/export.rb'
531
+ - 'db/migrate/20140202020202_create_bookmarks.rb'
532
+ - 'lib/blacklight/configuration.rb'
533
+ - 'lib/blacklight/solr/repository.rb'
534
+ - 'lib/blacklight/solr/response/spelling.rb'
535
+ - 'tasks/blacklight.rake'
215
536
 
216
- # Offense count: 2
537
+ # Offense count: 1
217
538
  # Cop supports --auto-correct.
218
539
  # Configuration parameters: EnforcedStyle, SupportedStyles.
540
+ # SupportedStyles: space, no_space
219
541
  Style/SpaceBeforeBlockBraces:
220
542
  Enabled: false
221
543
 
222
- # Offense count: 16
544
+ # Offense count: 15
223
545
  # Cop supports --auto-correct.
224
546
  Style/SpaceBeforeComma:
225
- Enabled: false
547
+ Exclude:
548
+ - 'app/helpers/blacklight/search_history_constraints_helper_behavior.rb'
549
+ - 'lib/generators/blacklight/controller_generator.rb'
550
+ - 'lib/generators/blacklight/document_generator.rb'
551
+ - 'lib/generators/blacklight/install_generator.rb'
552
+ - 'lib/generators/blacklight/search_builder_generator.rb'
553
+ - 'lib/generators/blacklight/user_generator.rb'
226
554
 
227
- # Offense count: 12
555
+ # Offense count: 4
556
+ # Cop supports --auto-correct.
557
+ # Configuration parameters: AllowForAlignment.
558
+ Style/SpaceBeforeFirstArg:
559
+ Exclude:
560
+ - 'db/migrate/20140202020201_create_searches.rb'
561
+ - 'lib/generators/blacklight/controller_generator.rb'
562
+ - 'lib/generators/blacklight/document_generator.rb'
563
+ - 'lib/generators/blacklight/search_builder_generator.rb'
564
+
565
+ # Offense count: 14
228
566
  # Cop supports --auto-correct.
229
567
  # Configuration parameters: EnforcedStyle, SupportedStyles, EnforcedStyleForEmptyBraces, SpaceBeforeBlockParameters.
568
+ # SupportedStyles: space, no_space
230
569
  Style/SpaceInsideBlockBraces:
231
570
  Enabled: false
232
571
 
233
- # Offense count: 14
572
+ # Offense count: 8
234
573
  # Cop supports --auto-correct.
235
574
  Style/SpaceInsideBrackets:
236
- Enabled: false
575
+ Exclude:
576
+ - 'lib/blacklight/configuration/fields.rb'
237
577
 
238
- # Offense count: 32
578
+ # Offense count: 18
239
579
  # Cop supports --auto-correct.
240
580
  # Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces, SupportedStyles.
581
+ # SupportedStyles: space, no_space
241
582
  Style/SpaceInsideHashLiteralBraces:
242
583
  Enabled: false
243
584
 
244
- # Offense count: 29
585
+ # Offense count: 19
245
586
  # Cop supports --auto-correct.
246
587
  Style/SpaceInsideParens:
247
- Enabled: false
588
+ Exclude:
589
+ - 'app/controllers/concerns/blacklight/search_context.rb'
590
+ - 'app/helpers/blacklight/catalog_helper_behavior.rb'
591
+ - 'app/helpers/blacklight/facets_helper_behavior.rb'
592
+ - 'app/helpers/blacklight/render_constraints_helper_behavior.rb'
593
+ - 'app/helpers/blacklight/search_history_constraints_helper_behavior.rb'
594
+ - 'app/helpers/blacklight/url_helper_behavior.rb'
595
+ - 'app/models/concerns/blacklight/document/dublin_core.rb'
596
+ - 'app/models/concerns/blacklight/document/extensions.rb'
597
+ - 'app/models/record_mailer.rb'
598
+ - 'lib/blacklight/search_state.rb'
599
+ - 'lib/blacklight/solr/search_builder_behavior.rb'
248
600
 
249
- # Offense count: 7
601
+ # Offense count: 4
250
602
  # Cop supports --auto-correct.
251
603
  # Configuration parameters: EnforcedStyle, SupportedStyles.
604
+ # SupportedStyles: single_quotes, double_quotes
252
605
  Style/StringLiteralsInInterpolation:
253
606
  Enabled: false
254
607
 
255
- # Offense count: 347
608
+ # Offense count: 242
256
609
  # Cop supports --auto-correct.
257
610
  Style/TrailingWhitespace:
258
611
  Enabled: false
612
+
613
+ # Offense count: 1
614
+ # Cop supports --auto-correct.
615
+ # Configuration parameters: ExactNameMatch, AllowPredicates, AllowDSLWriters, IgnoreClassMethods, Whitelist.
616
+ # Whitelist: to_ary, to_a, to_c, to_enum, to_h, to_hash, to_i, to_int, to_io, to_open, to_path, to_proc, to_r, to_regexp, to_str, to_s, to_sym
617
+ Style/TrivialAccessors:
618
+ Exclude:
619
+ - 'lib/blacklight/search_builder.rb'