blacklight 5.0.0.pre4 → 5.0.0

data/spec/helpers/configuration_helper_spec.rb

@@ -0,0 +1,61 @@
+require 'spec_helper'
+
+describe BlacklightConfigurationHelper do
+  let(:blacklight_config) { Blacklight::Configuration.new }
+  let(:config_value) { double() }
+
+  before :each do
+    helper.stub(blacklight_config: blacklight_config)
+  end
+
+  describe "#index_fields" do
+    it "should pass through the configuration" do
+      blacklight_config.stub(index_fields: config_value)
+      expect(helper.index_fields).to eq config_value
+    end
+  end
+
+  describe "#sort_fields" do
+    it "should convert the sort fields to select-ready values" do
+      blacklight_config.stub(sort_fields: { 'a' => double(key: 'a', label: 'a'), 'b' => double(key: 'b', label: 'b'),  })
+      expect(helper.sort_fields).to eq [['a', 'a'], ['b', 'b']]
+    end
+  end
+
+  describe "#document_show_fields" do
+    it "should pass through the configuration" do
+      blacklight_config.stub(show_fields: config_value)
+      expect(helper.document_show_fields).to eq config_value
+    end
+  end
+
+  describe "#default_document_index_view_type" do
+    it "should be the first configured index view" do
+      blacklight_config.stub(view: { 'a' => true, 'b' => true})
+      expect(helper.default_document_index_view_type).to eq 'a'
+    end
+  end
+
+  describe "#has_alternative_views?" do
+    subject { helper.has_alternative_views?}
+    describe "with a single view defined" do
+      it { should be_false }
+    end
+
+    describe "with multiple views defined" do
+      before do
+        blacklight_config.view.abc
+        blacklight_config.view.xyz
+      end
+
+      it { should be_true }
+    end
+  end
+
+  describe "#spell_check_max" do
+    it "should pass through the configuration" do
+      blacklight_config.stub(spell_max: config_value)
+      expect(helper.spell_check_max).to eq config_value
+    end
+  end
+end

data/spec/helpers/url_helper_spec.rb

@@ -225,6 +225,13 @@ describe BlacklightHelper do
       @document = SolrDocument.new('id'=>'123456')
       expect(link_to_document(@document,:label=>"Some crazy long label...")).to_not match(/title=/)
     end
+
+    it "should  work with integer ids" do
+      data = {'id'=> 123456 }
+      @document = SolrDocument.new(data)
+      expect(link_to_document(@document)).to have_selector("a")
+    end
+
   end
 
   describe "link_to_previous_search" do

data/spec/lib/blacklight/solr/document_spec.rb

@@ -44,6 +44,14 @@ describe "Blacklight::Solr::Document" do
         @document = MockDocument.new :id => 'asdf', :my_unique_key => '1234'
         expect(@document.id).to eq '1234'
       end
+
+    end
+
+    describe "#to_param" do
+      it "should be a string" do
+        @document = MockDocument.new :id => 1234
+        expect(@document.to_param).to eq '1234'
+      end
     end
 
     context "Extendability" do

data/spec/views/catalog/_constraints_element.html.erb_spec.rb

@@ -52,7 +52,7 @@ describe "catalog/_constraints_element.html.erb" do
 
   describe "with no escaping" do
     before do
-      render( :partial => "catalog/constraints_element", :locals => {:label => "<span class='custom_label'>my label</span>", :value => "<span class='custom_value'>my value</span>", :options => {:escape_label => false, :escape_value => false}} )
+      render( :partial => "catalog/constraints_element", :locals => {:label => "<span class='custom_label'>my label</span>".html_safe, :value => "<span class='custom_value'>my value</span>".html_safe} )
     end
     it "should not escape key and value" do
       expect(rendered).to have_selector("span.appliedFilter.constraint span.filterName span.custom_label")

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: blacklight
 version: !ruby/object:Gem::Version
-  version: 5.0.0.pre4
+  version: 5.0.0
 platform: ruby
 authors:
 - Jonathan Rochkind
@@ -17,7 +17,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-02-02 00:00:00.000000000 Z
+date: 2014-02-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -245,11 +245,13 @@ files:
 - app/controllers/search_history_controller.rb
 - app/helpers/blacklight/blacklight_helper_behavior.rb
 - app/helpers/blacklight/catalog_helper_behavior.rb
+- app/helpers/blacklight/configuration_helper_behavior.rb
 - app/helpers/blacklight/facets_helper_behavior.rb
 - app/helpers/blacklight/hash_as_hidden_fields_helper_behavior.rb
 - app/helpers/blacklight/render_constraints_helper_behavior.rb
 - app/helpers/blacklight/search_history_constraints_helper_behavior.rb
 - app/helpers/blacklight/url_helper_behavior.rb
+- app/helpers/blacklight_configuration_helper.rb
 - app/helpers/blacklight_helper.rb
 - app/helpers/blacklight_url_helper.rb
 - app/helpers/catalog_helper.rb
@@ -389,6 +391,7 @@ files:
 - lib/generators/blacklight/models_generator.rb
 - lib/generators/blacklight/templates/alternate_controller.rb
 - lib/generators/blacklight/templates/blacklight.css.scss
+- lib/generators/blacklight/templates/blacklight.en.yml
 - lib/generators/blacklight/templates/catalog_controller.rb
 - lib/generators/blacklight/templates/config/jetty.yml
 - lib/generators/blacklight/templates/config/solr.yml
@@ -416,6 +419,7 @@ files:
 - spec/features/search_spec.rb
 - spec/helpers/blacklight_helper_spec.rb
 - spec/helpers/catalog_helper_spec.rb
+- spec/helpers/configuration_helper_spec.rb
 - spec/helpers/facets_helper_spec.rb
 - spec/helpers/hash_as_hidden_fields_spec.rb
 - spec/helpers/render_constraints_helper_spec.rb
@@ -488,9 +492,9 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">"
+  - - ">="
     - !ruby/object:Gem::Version
-      version: 1.3.1
+      version: '0'
 requirements: []
 rubyforge_project: 
 rubygems_version: 2.2.0
@@ -519,6 +523,7 @@ test_files:
 - spec/features/search_spec.rb
 - spec/helpers/blacklight_helper_spec.rb
 - spec/helpers/catalog_helper_spec.rb
+- spec/helpers/configuration_helper_spec.rb
 - spec/helpers/facets_helper_spec.rb
 - spec/helpers/hash_as_hidden_fields_spec.rb
 - spec/helpers/render_constraints_helper_spec.rb