blacklight-spotlight 5.3.1 → 6.0.0.rc1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 63542249524bfb5d425f34738792bd6a39348c44ca2775cbfa616bfa07e3447b
-  data.tar.gz: 595f004850b722dc40b80eec95c48b468919e8bf5e16dba3a9db67de34c71917
+  metadata.gz: 95ee8daf3a842b8230c41db5a322202457a2b6d5d6e59c86966d724915ef885d
+  data.tar.gz: fe5a12e8ecd14c9ee515d5c784e783ebc7861895ff1a07fe2c629e4c9ef1e989
 SHA512:
-  metadata.gz: 15d0995ce4bf7f333ea22b83c11fea882cb506e16f148f515d50ed5381ae06cc089361374ec0e816a66cad99a0a9afed8f814714494c1d1d6d51db1602b80f0f
-  data.tar.gz: 2e10d19b13ec49477ea5f8bab9c3dc805fba064a0d955c0986af869cbd62e37ca6d4e3a49c98cdf6eafd63c758444274531e8bd4d3cf21a94eebcbb77c9bd68c
+  metadata.gz: b2caff642a657a1f1d4c2cd2a3848325a11586840b8f2eda71dbf14b324710b5ae1d268f61c2ea4f23167ecffd5b72887e5c2c27e8d95ef287d3542b74bf9551
+  data.tar.gz: e1d5cbfc083e0f6c7f583cac20c64fb069076d4cd954c8a9d8c92cbfbb8baed7c527cad635e35aac9573871a31b22538111ee624509a244b45e1f9a85eac8a27

data/README.md

@@ -11,7 +11,7 @@ If you have questions or are interested in contributing, please reach out to the
 
 ## Requirements
 
-- [Ruby](https://www.ruby-lang.org/) 3.2+
+- [Ruby](https://www.ruby-lang.org/) 3.3+
 - [Ruby on Rails](https://rubyonrails.org/) 7.1+
 - Java (11 or greater) *for Solr*
 - [ImageMagick](http://www.imagemagick.org/script/index.php) if using riiif (current default for `config.iiif_service`)
@@ -107,7 +107,13 @@ You only need to update `package.json` and prepare/publish the JavaScript packag
 3. Run `npm i --package-lock-only` to update the version in `package-lock.json`
 4. Commit the changes e.g. `git commit -am "Bump version to X.X.X"`
 5. Push the release to rubygems and GitHub: `bundle exec rake release`
-6. Run `npm publish` to push the JavaScript package to https://npmjs.org/package/spotlight-frontend
+6. Log in to npm: `npm login`
+7. You can test the release by running `npm publish --dry-run`. Check the console output to make sure the version number looks correct.
+8. Run `npm publish` to push the JavaScript package to https://npmjs.org/package/spotlight-frontend
+
+For a prerelease (e.g. `6.0.0.rc1` in `version.rb` and `6.0.0-rc.1` in `package.json`), publish with `npm publish --tag next` so the `latest` tag stays on the current stable release.
+
+For a release from a backport branch (e.g. `release-5.x`), publish with `npm publish --tag release-5.x` so it doesn't replace the `latest` tag.
 
 See [Updating the JavaScript bundle](#updating-the-javascript-bundle) above for more details.
 
@@ -115,7 +121,8 @@ See [Updating the JavaScript bundle](#updating-the-javascript-bundle) above for
 
 ### Branches
 
-* The `main` branch is for development of the 5.x series.
+* The `main` branch is for development of the 6.x series.
+* The `5.x` series is on the [release-5.x](https://github.com/projectblacklight/spotlight/tree/release-5.x) branch for backports of features and bug fixes.
 * The `4.x` series is on the [release-4.x](https://github.com/projectblacklight/spotlight/tree/release-4.x) branch for backports of features and bug fixes.
 
 ### Tooling
@@ -193,6 +200,15 @@ The `spec:prepare` task generates css assets for use by the tests. You can delet
 
 Once you are set up, you can also run `rubocop` to enforce consistent coding style.
 
+#### External IIIF resources in JavaScript feature specs
+
+JavaScript feature specs run in a real browser, so WebMock can't intercept the requests it makes. To keep these specs from depending on external IIIF servers:
+
+* The test browser doesn't load images.
+* IIIF manifests are served from fixtures. When a document has a fixture at `spec/fixtures/iiif_manifests/<document_id>.json`, its autocomplete response points at that fixture instead of the live manifest (see `spec/support/iiif_manifest_fixtures.rb`). If a JavaScript spec selects a document that loads its manifest, add a fixture by saving the manifest from the document's `iiif_manifest_url_ssi` URL.
+
+IIIF image `info.json` requests, such as the ones the cropper makes, still go to the image server named in the manifest.
+
 
 ### Individual commands
 
@@ -263,7 +279,7 @@ A brief orientation to this codebase
 #### Frontend Asset Structure
 - **Source JavaScript:** Resides in `app/javascript/spotlight/` (e.g., admin widgets, custom field behaviors).
 - **Core Orchestration:** `app/javascript/spotlight/index.js` listens to page loads and instantiates class components (e.g., `new AddAnother().connect()`).
-- **Standard:** Spotlight prefers standard, modern JavaScript (ES6+) and is migrating away from jQuery dependencies.
+- **Standard:** Spotlight prefers standard, modern JavaScript (ES6+) and does not depend on jQuery.
 
 ## Spotlight Community
 

data/Rakefile

@@ -33,8 +33,6 @@ require 'spotlight/version'
 
 # Build with our opinionated defaults if none are provided.
 rails_options = ENV.fetch('ENGINE_CART_RAILS_OPTIONS', '')
-rails_options = "#{rails_options} -a propshaft" unless rails_options.match?(/-a\s|--asset-pipeline/)
-rails_options = "#{rails_options} -j importmap" unless rails_options.match?(/-j\s|--javascript/)
 rails_options = "#{rails_options} --css bootstrap" unless rails_options.match?(/--css/)
 ENV['ENGINE_CART_RAILS_OPTIONS'] = rails_options
 
@@ -73,6 +71,7 @@ task :ci do
     Rake::Task['spotlight:fixtures'].invoke
     within_test_app do
       system 'bin/rake spec:prepare'
+      abort 'Error running spec:prepare' unless $?.success?
     end
 
     # run the tests