blacklight-spotlight 4.5.0 → 4.6.0

data/app/assets/javascripts/spotlight/spotlight.js

@@ -4058,54 +4058,51 @@
 
   class BlacklightConfiguration {
     connect() {
-      // Add Select/Deselect all button behavior
+      // Add Select/Deselect all input behavior
       this.addCheckboxToggleBehavior();
       this.addEnableToggleBehavior();
     }
     
-    // Add Select/Deselect all button behavior
+    // Add Select/Deselect all behavior for metadata field names for a given view e.g. Item details. 
     addCheckboxToggleBehavior() {
       $("[data-behavior='metadata-select']").each(function(){
-        var button = $(this);
-        var parentCell = button.parents("th");
+        var selectCheckbox = $(this);
+        var parentCell = selectCheckbox.parents("th");
         var table = parentCell.closest("table");
         var columnRows = $("tr td:nth-child(" + (parentCell.index() + 1) + ")", table);
         var checkboxes = $("input[type='checkbox']", columnRows);
-        swapSelectAllButtonText(button, columnRows);
-        // Add the check/uncheck behavior to the button
-        // and swap the button text if necessary
-        button.on('click', function(e){
-          e.preventDefault();
+        updateSelectAllInput(selectCheckbox, columnRows);
+        // Add the check/uncheck behavior to the select/deselect all checkbox
+        selectCheckbox.on('click', function(e){
           var allChecked = allCheckboxesChecked(columnRows);
           columnRows.each(function(){
             $("input[type='checkbox']", $(this)).prop('checked', !allChecked);
-            swapSelectAllButtonText(button, columnRows);
           });
         });
-        // Swap button text when a checkbox value changes
+        // When a single checkbox is selected/unselected, the "All" checkbox should be updated accordingly.
         checkboxes.each(function(){
           $(this).on('change', function(){
-            swapSelectAllButtonText(button, columnRows);
+            updateSelectAllInput(selectCheckbox, columnRows);
           });
-        });
+        }); 
       });
+
       // Check number of checkboxes against the number of checked
       // checkboxes to determine if all of them are checked or not
       function allCheckboxesChecked(elements) {
         return ($("input[type='checkbox']", elements).length == $("input[type='checkbox']:checked", elements).length)
       }
-      // Swap the button text to "Deselect all"
-      // when all the checkboxes are checked and
-      // "Select all" when any are unchecked
-      function swapSelectAllButtonText(button, elements) {
+
+      // Check or uncheck the "All" checkbox for each view column, e.g. Item details, List, etc.
+      function updateSelectAllInput(checkbox, elements) {
         if ( allCheckboxesChecked(elements) ) {
-          button.text(button.data('deselect-text'));
+          checkbox.prop('checked', true);
         } else {
-          button.text(button.data('select-text'));
+          checkbox.prop('checked', false);
         }
       }
     }
-
+      
     addEnableToggleBehavior() {
       $("[data-behavior='enable-feature']").each(function(){
         var checkbox = $(this);
@@ -6978,8 +6975,8 @@
           </div>
           <div class="col-md-4">
             <input name="${this.zpr_key}" type="hidden" value="false" />
-            <input name="${this.zpr_key}" id="${this.formId(this.zpr_key)}" data-key=${this.zpr_key}" type="checkbox" value="true" />
-            <label for="${this.formId(this.zpr_key)}">${ i18n.t("blocks:solr_documents:zpr:title")}</label>
+            <input name="${this.zpr_key}" id="${this.formId(this.zpr_key)}" data-key="${this.zpr_key}" type="checkbox" value="true" />
+            <label for="${this.formId(this.zpr_key)}">${i18n.t("blocks:solr_documents:zpr:title")}</label>
           </div>
         </div>
         ${this.text_area()}