blacklight-spotlight 3.4.0 → 3.4.2.1

data/spec/helpers/spotlight/main_app_helpers_spec.rb

@@ -1,101 +0,0 @@
-# frozen_string_literal: true
-
-describe Spotlight::MainAppHelpers, type: :helper do
-  describe '#show_contact_form?' do
-    subject { helper }
-
-    let(:exhibit) { FactoryBot.create :exhibit }
-    let(:exhibit_with_contacts) { FactoryBot.create :exhibit }
-
-    context 'with an exhibit with confirmed contacts' do
-      before do
-        exhibit_with_contacts.contact_emails.create(email: 'cabeer@stanford.edu').tap do |e|
-          if e.respond_to? :confirm
-            e.confirm
-          else
-            e.confirm!
-          end
-        end
-      end
-
-      before { allow(helper).to receive_messages current_exhibit: exhibit_with_contacts }
-
-      its(:show_contact_form?) { is_expected.to be_truthy }
-    end
-
-    context 'with an exhibit with only unconfirmed contacts' do
-      before { exhibit_with_contacts.contact_emails.build email: 'cabeer@stanford.edu' }
-
-      before { allow(helper).to receive_messages current_exhibit: exhibit_with_contacts }
-
-      its(:show_contact_form?) { is_expected.to be_falsey }
-    end
-
-    context 'with an exhibit without contacts' do
-      before { allow(helper).to receive_messages current_exhibit: exhibit }
-
-      its(:show_contact_form?) { is_expected.to be_falsey }
-    end
-
-    context 'outside the context of an exhibit' do
-      before { allow(helper).to receive_messages current_exhibit: nil }
-
-      its(:show_contact_form?) { is_expected.to be_falsey }
-    end
-
-    context 'with a default contact address' do
-      before { allow(Spotlight::Engine.config).to receive_messages default_contact_email: 'root@localhost' }
-
-      before { allow(helper).to receive_messages current_exhibit: exhibit }
-
-      its(:show_contact_form?) { is_expected.to be_truthy }
-    end
-  end
-
-  describe '#exhibit_stylesheet_link_tag' do
-    let(:exhibit) { FactoryBot.create(:exhibit) }
-
-    before do
-      allow(helper).to receive_messages(current_exhibit: exhibit)
-    end
-
-    context 'without an exhibit context' do
-      let(:exhibit) { nil }
-
-      it 'uses the standard stylesheet' do
-        expect(helper.exhibit_stylesheet_link_tag('application')).to eq helper.stylesheet_link_tag('application')
-      end
-    end
-
-    context 'for an exhibit without a selected theme' do
-      before do
-        exhibit.update(theme: nil)
-      end
-
-      it 'uses the standard stylesheet' do
-        expect(helper.exhibit_stylesheet_link_tag('application')).to eq helper.stylesheet_link_tag('application')
-      end
-    end
-
-    context 'for an exhibit with an invalid theme' do
-      before do
-        exhibit.update(theme: 'garbage')
-      end
-
-      it 'uses the standard stylesheet' do
-        expect(helper.exhibit_stylesheet_link_tag('application')).to eq helper.stylesheet_link_tag('application')
-      end
-    end
-
-    context 'for a themed exhibit' do
-      before do
-        allow(Spotlight::Engine.config).to receive(:exhibit_themes).and_return(%w[default modern])
-        exhibit.update(theme: 'modern')
-      end
-
-      it 'uses a suffixed stylesheet name' do
-        expect(helper.exhibit_stylesheet_link_tag('application')).to eq helper.stylesheet_link_tag('application_modern')
-      end
-    end
-  end
-end

data/spec/helpers/spotlight/masthead_helper_spec.rb

@@ -1,51 +0,0 @@
-# frozen_string_literal: true
-
-describe Spotlight::MastheadHelper, type: :helper do
-  let(:exhibit) { FactoryBot.create(:exhibit) }
-  let(:site) { Spotlight::Site.instance }
-
-  before do
-    allow(helper).to receive(:current_exhibit).and_return(nil)
-    allow(helper).to receive(:current_site).and_return(site)
-  end
-
-  describe '#masthead_heading_content' do
-    context 'when there is a current exhibit' do
-      before { allow(helper).to receive(:current_exhibit).and_return(exhibit) }
-
-      it { expect(helper.masthead_heading_content).to eq exhibit.title }
-    end
-
-    context 'when there is no current exhibit' do
-      it { expect(helper.masthead_heading_content).to eq 'Blacklight' } # the application_name
-    end
-  end
-
-  describe '#masthead_subheading_content' do
-    context 'when there is a current exhibit' do
-      before { allow(helper).to receive(:current_exhibit).and_return(exhibit) }
-
-      context 'when the exhibit has a subtitle' do
-        before { exhibit.subtitle = 'MastheadHelper Spec Exhibit' }
-
-        it { expect(helper.masthead_subheading_content).to eq 'MastheadHelper Spec Exhibit' }
-      end
-
-      context 'when the exhibit does not have a subtitle' do
-        it { expect(helper.masthead_subheading_content).to be_nil }
-      end
-    end
-
-    context 'when there is no current exhibit' do
-      context 'when the site has a subtitle' do
-        before { site.subtitle = "The site's subtitle" }
-
-        it { expect(helper.masthead_subheading_content).to eq "The site's subtitle" }
-      end
-
-      context 'when the site does not have a subtitle' do
-        it { expect(helper.masthead_subheading_content).to be_nil }
-      end
-    end
-  end
-end

data/spec/helpers/spotlight/meta_helper_spec.rb

@@ -1,33 +0,0 @@
-# frozen_string_literal: true
-
-describe Spotlight::MetaHelper, type: :helper do
-  describe '#add_exhibit_meta_content' do
-    let(:current_exhibit) { FactoryBot.create(:exhibit) }
-
-    before do
-      allow(helper).to receive_messages(current_exhibit: current_exhibit)
-      allow(helper).to receive(:site_title).and_return('some title')
-      current_exhibit.subtitle = 'xyz'
-      current_exhibit.description = 'abc'
-      TopHat.current['twitter_card'] = nil
-      TopHat.current['opengraph'] = nil
-    end
-
-    it 'generates a twitter card for the exhibit' do
-      allow(helper).to receive(:exhibit_root_url).and_return('some/url')
-      allow(current_exhibit).to receive(:thumbnail).and_return(double(iiif_url: 'https://test.host/images/7777/full/400,300/0/default.jpg'))
-
-      helper.add_exhibit_meta_content
-
-      card = helper.twitter_card
-      expect(card).to have_css "meta[name='twitter:card'][value='summary']", visible: false
-      expect(card).to have_css "meta[name='twitter:url'][value='some/url']", visible: false
-      expect(card).to have_css "meta[name='twitter:title'][value='#{current_exhibit.title}']", visible: false
-      expect(card).to have_css "meta[name='twitter:description'][value='#{current_exhibit.subtitle}']", visible: false
-      expect(card).to have_css "meta[name='twitter:image'][value='https://test.host/images/7777/full/400,300/0/default.jpg']", visible: false
-
-      graph = helper.opengraph
-      expect(graph).to have_css "meta[property='og:site_name'][content='some title']", visible: false
-    end
-  end
-end

data/spec/helpers/spotlight/navbar_helper_spec.rb

@@ -1,24 +0,0 @@
-# frozen_string_literal: true
-
-describe Spotlight::NavbarHelper, type: :helper do
-  describe '#should_render_search_bar?' do
-    before do
-      allow(helper).to receive_messages(current_exhibit: nil)
-      allow(helper).to receive_messages(exhibit_masthead?: true)
-    end
-
-    it 'returns false when there is no exhibit context' do
-      expect(helper).not_to be_should_render_spotlight_search_bar
-    end
-
-    it 'returns true if searchable' do
-      allow(helper).to receive_messages(current_exhibit: double(searchable?: true))
-      expect(helper).to be_should_render_spotlight_search_bar
-    end
-
-    it 'returns false if currently under an "Exhibity" browse category' do
-      allow(helper).to receive_messages(exhibit_masthead?: false)
-      expect(helper).not_to be_should_render_spotlight_search_bar
-    end
-  end
-end

data/spec/helpers/spotlight/pages_helper_spec.rb

@@ -1,123 +0,0 @@
-# frozen_string_literal: true
-
-describe Spotlight::PagesHelper, type: :helper do
-  let(:blacklight_config) { Blacklight::Configuration.new { |config| config.show.title_field = :abc } }
-  let(:titled_document) { blacklight_config.document_model.new(abc: 'value') }
-  let(:untitled_document) { blacklight_config.document_model.new(id: '1234') }
-  let!(:current_exhibit) { FactoryBot.create(:exhibit) }
-  let!(:home_page) { current_exhibit.home_page }
-  let!(:search) { FactoryBot.create(:search, exhibit: current_exhibit, query_params: { 'q' => 'query' }, published: true) }
-
-  before do
-    allow(helper).to receive_messages(blacklight_config: blacklight_config)
-  end
-
-  describe 'disable_save_pages_button?' do
-    it 'returns true if there are no pages and we are on the about pages page' do
-      expect(helper).to receive(:page_collection_name).and_return('about_pages')
-      assign(:pages, [])
-      expect(helper).to be_disable_save_pages_button
-    end
-
-    it 'returns false if there are about pages' do
-      expect(helper).to receive(:page_collection_name).and_return('about_pages')
-      assign(:pages, [{}])
-      expect(helper).not_to be_disable_save_pages_button
-    end
-
-    it 'returns false if on the feature pages page' do
-      expect(helper).to receive(:page_collection_name).and_return('feature_pages')
-      assign(:pages, [])
-      expect(helper).not_to be_disable_save_pages_button
-    end
-  end
-
-  describe 'get_search_widget_search_results' do
-    let(:good) do
-      content = { type: 'xyz', data: { 'item' => { search.slug => { id: search.slug, display: 'true' } } } }
-      SirTrevorRails::Blocks::SearchResultsBlock.new(content, home_page)
-    end
-
-    let(:bad) do
-      content = { type: 'xyz', data: { 'item' => { 'garbage' => { id: 'missing', display: 'true' } } } }
-      SirTrevorRails::Blocks::SearchResultsBlock.new(content, home_page)
-    end
-
-    let(:search_result) { [double('response'), double('documents')] }
-
-    it 'returns the results for a given search browse category' do
-      expect(helper).to receive(:search_results).with({ 'q' => 'query' }).and_return(search_result)
-      expect(helper.get_search_widget_search_results(good)).to eq search_result
-    end
-
-    it "returns an empty array when requesting a search that doesn't exist" do
-      expect(helper.get_search_widget_search_results(bad)).to be_empty
-    end
-  end
-
-  describe 'nestable helpers' do
-    describe 'nestable data attributes' do
-      it 'returns the appropriate attributes for feature pages' do
-        expect(helper.nestable_data_attributes('feature_pages')).to eq "data-max-depth='2' data-expand-btn-HTML='' data-collapse-btn-HTML=''"
-      end
-
-      it 'returns the appropriate attributes for about pages' do
-        expect(helper.nestable_data_attributes('about_pages')).to eq "data-max-depth='1'"
-      end
-
-      it 'returns a blank string if the type is not valid' do
-        expect(helper.nestable_data_attributes('something_else')).to eq ''
-      end
-    end
-
-    describe 'nestable data attributes hash' do
-      it 'returns the appropriate hash for feature pages' do
-        expect(helper.nestable_data_attributes_hash('feature_pages')).to eq('data-max-depth' => '2',
-                                                                            'data-expand-btn-HTML' => '',
-                                                                            'data-collapse-btn-HTML' => '')
-      end
-
-      it 'returns the appropriate hash for about pages' do
-        expect(helper.nestable_data_attributes_hash('about_pages')).to eq 'data-max-depth' => '1'
-      end
-
-      it 'returns an empty hash if the type is not valid' do
-        expect(helper.nestable_data_attributes_hash('something_else')).to eq({})
-      end
-    end
-  end
-
-  describe '#sir_trevor_markdown' do
-    it 'handles nil input' do
-      expect(helper.sir_trevor_markdown(nil)).to be_blank
-    end
-
-    it 'retains paragraphs' do
-      expect(helper.sir_trevor_markdown('<p>First Line</p><p>Second Line</p>').chomp).to match(%r{<p>First Line</p>\s*<p>Second Line</p>})
-    end
-
-    it 'replaces line breaks with paragraphs' do
-      expect(helper.sir_trevor_markdown('First Line<br>Second Line').chomp).to match(%r{<p>First Line</p>\s*<p>Second Line</p>})
-    end
-  end
-
-  describe '#content_editor_class' do
-    context 'a sir-trevor backed page with a custom class' do
-      it 'has a custom class' do
-        expect(helper.content_editor_class(Spotlight::Page.new)).to eq 'js-st-instance'
-      end
-    end
-
-    context 'a sir-trevor backed page with a derived class' do
-      it 'derives a css class name from the editor type' do
-        expect(helper.content_editor_class(Spotlight::Page.new(content_type: 'Something::Custom'))).to eq 'js-something-custom-instance'
-      end
-    end
-  end
-
-  describe '#render_contact_email_address' do
-    it 'adds soft breaks in appropriate places' do
-      expect(helper.render_contact_email_address('local.part@example.com')).to have_css 'wbr', count: 3, visible: false
-    end
-  end
-end

data/spec/helpers/spotlight/roles_helper_spec.rb

@@ -1,7 +0,0 @@
-# frozen_string_literal: true
-
-describe Spotlight::RolesHelper, type: :helper do
-  it 'is a list of options' do
-    expect(helper.roles_for_select).to eq('Admin' => 'admin', 'Curator' => 'curator', 'Viewer' => 'viewer')
-  end
-end

data/spec/helpers/spotlight/search_configurations_helper_spec.rb

@@ -1,23 +0,0 @@
-# frozen_string_literal: true
-
-describe Spotlight::SearchConfigurationsHelper, type: :helper do
-  describe '#translate_sort_fields' do
-    let(:sort_config) do
-      Blacklight::OpenStructWithHashAccess.new(sort: 'score asc, sort_title_ssi desc')
-    end
-
-    it 'translates sort fields' do
-      expect(translate_sort_fields(sort_config)).to eq 'relevancy score ascending and title descending'
-    end
-
-    it 'humanizes untranslatable sort fields' do
-      sort_config.sort = 'some_other_field desc'
-      expect(translate_sort_fields(sort_config)).to eq 'some other field descending'
-    end
-
-    it 'supports explicit sort descriptions' do
-      sort_config.sort_description = 'xyz'
-      expect(translate_sort_fields(sort_config)).to eq 'xyz'
-    end
-  end
-end

data/spec/helpers/spotlight/title_helper_spec.rb

@@ -1,64 +0,0 @@
-# frozen_string_literal: true
-
-describe Spotlight::TitleHelper, type: :helper do
-  before do
-    allow(helper).to receive_messages(application_name: 'Application')
-  end
-
-  describe '#page_title' do
-    it 'sets the @page_title ivar' do
-      helper.page_title('Section', 'Title')
-      title = helper.instance_variable_get(:@page_title)
-      expect(title).to eq 'Section - Title | Application'
-    end
-
-    it 'renders the section title and the page title' do
-      title = helper.page_title('Section', 'Title')
-      expect(title).to have_selector 'h1', text: 'Section'
-      expect(title).to have_selector 'h1 small', text: 'Title'
-    end
-
-    it 'renders just the section title if that was all that was provided' do
-      allow(helper).to receive(:t).and_call_original
-      allow(helper).to receive(:t).with(:'.header', default: '').and_return('')
-
-      title = helper.page_title('Section')
-
-      expect(title).to have_selector 'h1', text: 'Section'
-      expect(title).not_to have_selector 'h1 small'
-
-      title = helper.instance_variable_get(:@page_title)
-      expect(title).to eq 'Section | Application'
-    end
-  end
-
-  describe '#set_html_page_title' do
-    it 'assigns the @page_title ivar' do
-      allow(helper).to receive_messages(application_name: 'B')
-      helper.set_html_page_title 'A'
-      title = helper.instance_variable_get(:@page_title)
-      expect(title).to eq 'A | B'
-    end
-
-    it 'strips out any HTML tags' do
-      allow(helper).to receive_messages(application_name: 'B')
-      expect(helper.set_html_page_title('<b>text</b> should not include HTML')).to eq 'text should not include HTML | B'
-    end
-  end
-
-  describe '#curation_page_title' do
-    it 'renders a page title in the curation section' do
-      title = helper.curation_page_title 'Some title'
-      expect(title).to have_selector 'h1', text: 'Curation'
-      expect(title).to have_selector 'h1 small', text: 'Some title'
-    end
-  end
-
-  describe '#configuration_page_title' do
-    it 'renders a page title in the configuration section' do
-      title = helper.configuration_page_title 'Some title'
-      expect(title).to have_selector 'h1', text: 'Configuration'
-      expect(title).to have_selector 'h1 small', text: 'Some title'
-    end
-  end
-end

data/spec/helpers/spotlight/translations_helper_spec.rb

@@ -1,16 +0,0 @@
-# frozen_string_literal: true
-
-RSpec.describe Spotlight::TranslationsHelper do
-  describe '#non_custom_metadata_fields' do
-    let(:exhibit) { FactoryBot.create(:exhibit) }
-    let!(:custom_field) { FactoryBot.create(:custom_field, exhibit: exhibit) }
-
-    before { allow(helper).to receive(:current_exhibit).and_return(exhibit) }
-
-    it "is an array of the current exhibit's metadata fields with the custom fields removed" do
-      expect(exhibit.blacklight_config.show_fields.keys).to include custom_field.field
-
-      expect(helper.non_custom_metadata_fields.keys).not_to include custom_field.field
-    end
-  end
-end

data/spec/i18n_spec.rb

@@ -1,27 +0,0 @@
-# frozen_string_literal: true
-
-require 'i18n/tasks'
-
-RSpec.describe 'I18n' do
-  let(:i18n) { I18n::Tasks::BaseTask.new }
-  let(:missing_keys) { i18n.missing_keys }
-  let(:unused_keys) { i18n.unused_keys }
-
-  xit 'does not have missing keys' do
-    expect(missing_keys).to be_empty,
-                            "Missing #{missing_keys.leaves.count} i18n keys, run `i18n-tasks missing' to show them"
-  end
-
-  xit 'does not have unused keys' do
-    expect(unused_keys).to be_empty,
-                           "#{unused_keys.leaves.count} unused i18n keys, run `i18n-tasks unused' to show them"
-  end
-
-  it 'files are normalized' do
-    non_normalized = i18n.non_normalized_paths
-    error_message = "The following files need to be normalized:\n" \
-                    "#{non_normalized.map { |path| "  #{path}" }.join("\n")}\n" \
-                    'Please run `i18n-tasks normalize` to fix'
-    expect(non_normalized).to be_empty, error_message
-  end
-end

data/spec/jobs/spotlight/add_tags_job_spec.rb

@@ -1,34 +0,0 @@
-# frozen_string_literal: true
-
-describe Spotlight::AddTagsJob do
-  subject { described_class.new(solr_params: solr_params, exhibit: exhibit, tags: tags) }
-
-  let(:solr_params) { { q: 'map' } }
-  let(:exhibit) { FactoryBot.create(:exhibit) }
-  let(:tags) { 'hello,world' }
-
-  before do
-    allow(Spotlight::Engine.config).to receive_messages(bulk_actions_batch_size: 5)
-  end
-
-  it 'adds tags to SolrDocumentSidecar objects' do
-    subject.perform_now
-    response = exhibit.blacklight_config.repository.search(solr_params.merge('rows' => 999_999_999))
-    expect(response.total).to eq 55
-    expect(Spotlight::JobTracker.last).to have_attributes(
-      status: 'completed',
-      total: 55,
-      progress: 55,
-      job_class: 'Spotlight::AddTagsJob'
-    )
-    response.documents.each do |document|
-      expect(document.sidecar(exhibit).all_tags_list).to include('hello', 'world')
-      exhibit.tag(document.sidecar(exhibit), with: [], on: :tags)
-    end
-    exhibit.owned_tags.destroy_all
-    response.documents.each do |document|
-      document.sidecar(exhibit).destroy
-      document.reindex
-    end
-  end
-end

data/spec/jobs/spotlight/add_uploads_from_csv_spec.rb

@@ -1,58 +0,0 @@
-# frozen_string_literal: true
-
-describe Spotlight::AddUploadsFromCsv do
-  subject(:job) { described_class.new(data, exhibit, user) }
-
-  let(:exhibit) { FactoryBot.create(:exhibit) }
-  let(:user) { FactoryBot.create(:exhibit_curator, exhibit: exhibit) }
-  let(:data) do
-    [
-      { 'url' => 'x' },
-      { 'url' => 'y' },
-      { 'url' => '~' }
-    ]
-  end
-
-  let(:resource_x) { instance_double(Spotlight::Resource) }
-  let(:resource_y) { instance_double(Spotlight::Resource) }
-
-  before do
-    allow(Spotlight::IndexingCompleteMailer).to receive(:documents_indexed).and_return(double(deliver_now: true))
-  end
-
-  context 'with empty data' do
-    let(:data) { [] }
-
-    it 'sends the user an email after the indexing job is complete' do
-      expect(Spotlight::IndexingCompleteMailer).to receive(:documents_indexed).and_return(double(deliver_now: true))
-      job.perform_now
-    end
-  end
-
-  it 'creates uploaded resources for each row of data' do
-    upload = FactoryBot.create(:uploaded_resource)
-    expect(Spotlight::Resources::Upload).to receive(:new).exactly(3).times.and_return(upload)
-
-    expect(upload).to receive(:build_upload).with(remote_image_url: 'x').and_call_original
-    expect(upload).to receive(:build_upload).with(remote_image_url: 'y').and_call_original
-    expect(upload).not_to receive(:build_upload).with(remote_image_url: '~')
-    expect(upload).to receive(:save_and_index).at_least(:once)
-
-    job.perform_now
-  end
-
-  context 'with errors' do
-    it 'collects errors uploaded resources for each row of data' do
-      allow(Spotlight::IndexingCompleteMailer).to receive(:documents_indexed).and_return(double(deliver_now: true))
-      job.perform_now
-      expect(Spotlight::IndexingCompleteMailer).to have_received(:documents_indexed).with(
-        data, exhibit, user,
-        indexed_count: 1,
-        errors: {
-          1 => array_including(match(Regexp.union(/relative URI: x/, /URI scheme '' not in whitelist:/))),
-          2 => array_including(match(/Upload is invalid/))
-        }
-      )
-    end
-  end
-end

data/spec/jobs/spotlight/change_visibility_job_spec.rb

@@ -1,30 +0,0 @@
-# frozen_string_literal: true
-
-describe Spotlight::ChangeVisibilityJob do
-  subject { described_class.new(solr_params: solr_params, exhibit: exhibit, visibility: visibility) }
-
-  let(:solr_params) { { q: 'map' } }
-  let(:exhibit) { FactoryBot.create(:exhibit) }
-  let(:visibility) { 'private' }
-
-  before do
-    allow(Spotlight::Engine.config).to receive_messages(bulk_actions_batch_size: 5)
-  end
-
-  it 'sets the items based off of the visibility' do
-    subject.perform_now
-    response = exhibit.blacklight_config.repository.search(solr_params.merge('rows' => 999_999_999))
-    expect(response.total).to eq 55
-    expect(Spotlight::JobTracker.last).to have_attributes(
-      status: 'completed',
-      total: 55,
-      progress: 55,
-      job_class: 'Spotlight::ChangeVisibilityJob'
-    )
-    response.documents.each do |document|
-      expect(document.private?(exhibit)).to be true
-      document.make_public!(exhibit)
-      document.reindex
-    end
-  end
-end

data/spec/jobs/spotlight/default_thumbnail_job_spec.rb

@@ -1,14 +0,0 @@
-# frozen_string_literal: true
-
-describe Spotlight::DefaultThumbnailJob do
-  subject { described_class.new(thumbnailable) }
-
-  let(:thumbnailable) { double('Thumbnailable') }
-
-  it 'calls #set_default_thumbnail on the object passed in and saves' do
-    expect(thumbnailable).to receive(:set_default_thumbnail)
-    expect(thumbnailable).to receive(:save)
-
-    subject.perform_now
-  end
-end