blacklight-spotlight 3.0.0.rc3 → 3.0.1

data/spec/models/spotlight/reindexing_log_entry_spec.rb

@@ -1,129 +0,0 @@
-# frozen_string_literal: true
-
-describe Spotlight::ReindexingLogEntry, type: :model do
-  subject { FactoryBot.build(:reindexing_log_entry) }
-
-  describe 'scope' do
-    before do
-      (0..10).to_a.each { FactoryBot.create(:recent_reindexing_log_entry) }
-      FactoryBot.create(:unstarted_reindexing_log_entry)
-      (0..10).to_a.each { FactoryBot.create(:recent_reindexing_log_entry) }
-    end
-
-    let(:sorted_log_entry_list) do
-      unstarted_entries = described_class.where(start_time: nil).to_a
-      started_entries = described_class.where.not(start_time: nil).to_a.sort_by(&:start_time).reverse
-      unstarted_entries + started_entries # null start times should be first
-    end
-
-    context 'default' do
-      it 'sorts by start_time in descending order' do
-        default_log_entry_list = described_class.all.to_a
-        expect(default_log_entry_list).to eq sorted_log_entry_list
-      end
-    end
-
-    context 'recent' do
-      it 'returns the most recent 5 entries (sorted by start_time descending)' do
-        recent_log_entry_list = described_class.recent.to_a
-        expect(recent_log_entry_list).to eq sorted_log_entry_list[0..4]
-      end
-    end
-  end
-
-  describe '#duration' do
-    context 'when end_time is present' do
-      it 'is calculated as difference between end_time and start_time' do
-        expect(subject.duration).to eq 300
-      end
-    end
-
-    context 'when end_time is not present' do
-      subject { FactoryBot.build(:in_progress_reindexing_log_entry) }
-
-      it 'is nil' do
-        expect(subject.duration).to be nil
-      end
-    end
-  end
-
-  describe 'state updating methods' do
-    describe '#in_progress!' do
-      subject { FactoryBot.build(:unstarted_reindexing_log_entry) }
-
-      context 'executes normally' do
-        it 'sets start_time and job_status' do
-          lower_time_bound = Time.zone.now
-          subject.in_progress!
-          upper_time_bound = Time.zone.now
-
-          expect(subject.start_time).to be_between(lower_time_bound, upper_time_bound)
-          expect(subject.job_status).to eq 'in_progress'
-        end
-      end
-
-      context 'encounters an unexpected error' do
-        it "traps the exception and logs an error so that the caller doesn't have to deal with it" do
-          expect(subject).to receive(:'start_time=').and_raise StandardError.new # try to blow up the in_progress! call
-          expect(Rails.logger).to receive(:error) do |arg|
-            expect(arg).to match(/^unexpected error updating log entry to :in_progress from \[".*reindexing_log_entry.rb/)
-          end
-
-          expect { subject.in_progress! }.not_to raise_error
-        end
-      end
-    end
-
-    describe '#succeeded!' do
-      subject { FactoryBot.build(:in_progress_reindexing_log_entry) }
-
-      context 'executes normally' do
-        it 'sets end_time and job_status' do
-          lower_time_bound = Time.zone.now
-          subject.succeeded!
-          upper_time_bound = Time.zone.now
-
-          expect(subject.end_time).to be_between(lower_time_bound, upper_time_bound)
-          expect(subject.job_status).to eq 'succeeded'
-        end
-      end
-
-      context 'encounters an unexpected error' do
-        it "traps the exception and logs an error so that the caller doesn't have to deal with it" do
-          expect(subject).to receive(:'end_time=').and_raise StandardError.new # try to blow up the succeeded! call
-          expect(Rails.logger).to receive(:error) do |arg|
-            expect(arg).to match(/^unexpected error updating log entry to :succeeded from \[".*reindexing_log_entry.rb/)
-          end
-
-          expect { subject.succeeded! }.not_to raise_error
-        end
-      end
-    end
-
-    describe '#failed!' do
-      subject { FactoryBot.build(:in_progress_reindexing_log_entry) }
-
-      context 'executes normally' do
-        it 'sets end_time and job_status' do
-          lower_time_bound = Time.zone.now
-          subject.failed!
-          upper_time_bound = Time.zone.now
-
-          expect(subject.end_time).to be_between(lower_time_bound, upper_time_bound)
-          expect(subject.job_status).to eq 'failed'
-        end
-      end
-
-      context 'encounters an unexpected error' do
-        it "traps the exception and logs an error so that the caller doesn't have to deal with it" do
-          expect(subject).to receive(:'end_time=').and_raise StandardError.new # try to blow up the failed! call
-          expect(Rails.logger).to receive(:error) do |arg|
-            expect(arg).to match(/^unexpected error updating log entry to :failed from \[".*reindexing_log_entry.rb/)
-          end
-
-          expect { subject.failed! }.not_to raise_error
-        end
-      end
-    end
-  end
-end

data/spec/models/spotlight/resources/open_graph_spec.rb

@@ -1,65 +0,0 @@
-# frozen_string_literal: true
-
-describe Spotlight::Resources::OpenGraph, type: :model do
-  class TestDocBuilder < Spotlight::SolrDocumentBuilder
-    def to_solr
-      super.merge(resource.opengraph_properties)
-    end
-  end
-
-  class TestResource < Spotlight::Resource
-    self.document_builder_class = TestDocBuilder
-    include Spotlight::Resources::OpenGraph
-  end
-
-  subject { TestResource.new url: 'info:url' }
-
-  let(:exhibit) { double(solr_data: {}, blacklight_config: Blacklight::Configuration.new) }
-
-  describe '#to_solr' do
-    before do
-      allow(subject).to receive_messages id: 15, opengraph_properties: {}, exhibit: exhibit, persisted?: true
-    end
-
-    let(:solr_doc) { subject.document_builder.to_solr }
-
-    it 'includes this record id' do
-      expect(solr_doc).to include spotlight_resource_id_ssim: subject.to_global_id.to_s
-    end
-
-    it 'includes opengraph properties' do
-      allow(subject).to receive_messages opengraph_properties: { a: 1, b: 2 }
-
-      expect(solr_doc).to include a: 1, b: 2
-    end
-  end
-
-  describe '#opengraph_properties' do
-    it 'maps opengraph properties to solr fields' do
-      allow(subject).to receive_messages opengraph: { 'og_title' => 'title', 'og_description' => 'description' }
-      expect(subject.opengraph_properties).to include 'og_title_tesim' => 'title', 'og_description_tesim' => 'description'
-    end
-  end
-
-  describe '#opengraph' do
-    let(:body) do
-      Nokogiri::HTML.parse <<-EOF
-        <html><head>
-        <meta property="og:title" content="The Ground Truth: The Human Cost of War"/>
-        <meta property="og:description" content="The Ground Truth: The Human Cost of War is our soldiers' perspective of the Iraq War"/>
-        <meta property="og:type" content="video.movie"/>
-        <meta property="og:site_name" content="Internet Archive"/>
-        <meta property="og:video" content="https://archive.org/download/Ground_Truth/GroundTruth1_bb_512kb.mp4"/>
-        <meta property="og:video:width" content="320"/>
-        <meta property="og:video:height" content="240"/>
-        </head></html>
-      EOF
-    end
-
-    it 'extracts opengraph <meta> tags' do
-      allow(subject).to receive_messages(body: body)
-      expect(subject.opengraph).to include 'og:title', 'og:description', 'og:type', 'og:type', 'og:site_name', 'og:video', 'og:video:width', 'og:video:height'
-      expect(subject.opengraph['og:title']).to eq 'The Ground Truth: The Human Cost of War'
-    end
-  end
-end

data/spec/services/spotlight/solr_document_builder_spec.rb

@@ -1,66 +0,0 @@
-# frozen_string_literal: true
-
-describe Spotlight::SolrDocumentBuilder do
-  let(:exhibit) { FactoryBot.create(:exhibit) }
-  let(:doc_builder) { described_class.new(resource) }
-  let(:resource) { Spotlight::Resource.new }
-
-  describe '#to_solr' do
-    subject { doc_builder.send(:to_solr) }
-
-    before do
-      allow(resource).to receive(:exhibit).and_return(exhibit)
-      allow(resource).to receive_messages(type: 'Spotlight::Resource::Something', id: 15, persisted?: true)
-    end
-
-    it 'includes a reference to the resource' do
-      expect(subject).to include spotlight_resource_id_ssim: resource.to_global_id.to_s
-    end
-  end
-
-  describe '#documents_to_index' do
-    context 'when the document belongs to more than one exhibit' do
-      subject { resource.document_builder }
-
-      let(:doc) { SolrDocument.new(id: 'abc123') }
-      let(:resource) { FactoryBot.create(:resource) }
-      let(:resource_alt) { FactoryBot.create(:resource) }
-
-      before do
-        allow(Spotlight::Engine.config).to receive(:filter_resources_by_exhibit).and_return(true)
-        allow(resource.document_builder).to receive(:to_solr).and_return(id: 'abc123')
-        allow(resource_alt.document_builder).to receive(:to_solr).and_return(id: 'abc123')
-        resource_alt.document_builder.documents_to_index.first
-      end
-
-      it 'has filter data for both exhibits' do
-        result = resource.document_builder.documents_to_index.first
-        expect(result).to include "spotlight_exhibit_slug_#{resource.exhibit.slug}_bsi"
-        expect(result).to include "spotlight_exhibit_slug_#{resource_alt.exhibit.slug}_bsi"
-      end
-
-      it 'has a field with both exhibit slugs listed' do
-        result = resource.document_builder.documents_to_index.first
-        expect(result).to include 'spotlight_exhibit_slugs_ssim' => match_array([resource.exhibit.slug, resource_alt.exhibit.slug])
-      end
-
-      it 'creates a sidecar resource for the document' do
-        resource.document_builder.documents_to_index.first
-
-        expect(Spotlight::SolrDocumentSidecar.where(document_id: 'abc123', document_type: 'SolrDocument').size).to eq 2
-        sidecar = resource.solr_document_sidecars.find_by(document_id: 'abc123', document_type: 'SolrDocument')
-        expect(sidecar.exhibit).to eq resource.exhibit
-        expect(sidecar.resource).to eq resource
-      end
-
-      context 'without a persisted resource' do
-        let(:resource) { FactoryBot.build(:resource, exhibit: exhibit) }
-
-        it 'does not implicitly persist the resource' do
-          resource.document_builder.documents_to_index.first
-          expect(resource).not_to be_persisted
-        end
-      end
-    end
-  end
-end