blacklight-spotlight 3.0.0.rc2 → 3.0.0.rc3

data/spec/factories/group.rb

@@ -0,0 +1,17 @@
+# frozen_string_literal: true
+
+FactoryBot.define do
+  factory :group, class: 'Spotlight::Group' do
+    exhibit
+
+    factory :group_with_searches do
+      transient do
+        searches_count { 5 }
+      end
+    end
+
+    after(:create) do |group, evaluator|
+      create_list(:search, evaluator.searches_count, groups: [group]) if evaluator.respond_to?(:searches_count)
+    end
+  end
+end

data/spec/factories/searches.rb

@@ -7,6 +7,16 @@ FactoryBot.define do
     sequence(:slug) { |n| "Search#{n}" }
 
     after(:build) { |search| search.thumbnail = FactoryBot.create(:featured_image) }
+
+    factory :search_with_groups do
+      transient do
+        groups_count { 2 }
+      end
+    end
+
+    after(:create) do |search, evaluator|
+      create_list(:group, evaluator.groups_count, searches: [search]) if evaluator.respond_to?(:groups_count)
+    end
   end
 
   factory :published_search, parent: :search do

data/spec/features/browse_category_admin_spec.rb

@@ -48,6 +48,38 @@ describe 'Browse Category Administration', type: :feature do
       end
     end
 
+    describe 'with a group present' do
+      let!(:group) { FactoryBot.create(:group, exhibit: exhibit, title: 'Good group') }
+
+      it 'enables group selection' do
+        visit spotlight.edit_exhibit_search_path(exhibit, search)
+        click_link 'Group'
+        expect(page).to have_content 'You can add this browse category'
+
+        within '#search-group' do
+          expect(find('input[type="checkbox"]')).not_to be_checked
+          check 'Good group'
+        end
+
+        click_button 'Save changes'
+        expect(page).to have_content('The browse category was successfully updated.')
+        visit spotlight.edit_exhibit_search_path(exhibit, search)
+        click_link 'Group'
+
+        within '#search-group' do
+          expect(find('input[type="checkbox"]')).to be_checked
+        end
+      end
+    end
+
+    describe 'without a group present' do
+      it 'displays no group help text' do
+        visit spotlight.edit_exhibit_search_path(exhibit, search)
+        click_link 'Group'
+        expect(page).to have_content 'You cannot add this browse category'
+      end
+    end
+
     it 'attaches a masthead image' do
       visit spotlight.edit_exhibit_search_path exhibit, search
 
@@ -63,7 +95,7 @@ describe 'Browse Category Administration', type: :feature do
 
       click_button 'Save changes'
 
-      expect(page).to have_content('The search was successfully updated.')
+      expect(page).to have_content('The browse category was successfully updated.')
 
       search.reload
 
@@ -83,7 +115,7 @@ describe 'Browse Category Administration', type: :feature do
 
       click_button 'Save changes'
 
-      expect(page).to have_content('The search was successfully updated.')
+      expect(page).to have_content('The browse category was successfully updated.')
 
       search.reload
 
@@ -97,7 +129,7 @@ describe 'Browse Category Administration', type: :feature do
       check 'Search box'
 
       click_button 'Save changes'
-      expect(page).to have_content('The search was successfully updated.')
+      expect(page).to have_content('The browse category was successfully updated.')
       search.reload
 
       expect(search.search_box).to eq true
@@ -109,7 +141,7 @@ describe 'Browse Category Administration', type: :feature do
 
       click_button 'Save changes'
 
-      expect(page).to have_content('The search was successfully updated.')
+      expect(page).to have_content('The browse category was successfully updated.')
 
       search.reload
 

data/spec/features/browse_category_navigation_spec.rb

@@ -0,0 +1,44 @@
+# frozen_string_literal: true
+
+describe 'Browse pages' do
+  let(:exhibit) { FactoryBot.create(:exhibit) }
+  let!(:search) { FactoryBot.create(:search, title: 'Some Saved Search', exhibit: exhibit, published: true) }
+  let!(:search_2) { FactoryBot.create(:search, title: 'Some Other Saved Search', exhibit: exhibit, published: true) }
+  let!(:group) { FactoryBot.create(:group, title: 'Awesome group', exhibit: exhibit, published: true, searches: [search]) }
+
+  describe 'landing page' do
+    before do
+      visit spotlight.exhibit_browse_index_path(exhibit)
+    end
+
+    it 'displays all categories and tabs for each group' do
+      within '.browse-group-navigation' do
+        expect(page).to have_css 'li.nav-item a.nav-link.active', text: 'All'
+        expect(page).to have_css 'li.nav-item a.nav-link', count: exhibit.groups.count + 1
+      end
+      within '.browse-landing' do
+        expect(page).to have_css '.category', count: 2
+      end
+    end
+
+    it 'filters browse categories when navigated' do
+      within '.browse-group-navigation' do
+        click_link group.title
+        expect(page).to have_css 'li.nav-item a.nav-link.active', text: group.title
+      end
+      within '.browse-landing' do
+        expect(page).to have_css '.category', count: 1
+      end
+    end
+
+    it 'clicking through from the context of a category provides the breadcrums' do
+      within '.browse-group-navigation' do
+        click_link group.title
+        expect(page).to have_css 'li.nav-item a.nav-link.active', text: group.title
+      end
+      click_link 'Some Saved Search'
+      expect(page).to have_css 'ul.breadcrumb li.breadcrumb-item', count: 4
+      expect(page).to have_css 'li.breadcrumb-item', text: 'Awesome group'
+    end
+  end
+end

data/spec/features/browse_category_spec.rb

@@ -100,7 +100,7 @@ describe 'Browse pages' do
       it 'uses the appropriate view config' do
         visit spotlight.exhibit_browse_path(exhibit, search)
 
-        expect(page).to have_css('#documents.gallery .document', count: 1)
+        expect(page).to have_css('#documents.documents-gallery .document', count: 1)
 
         within '.document' do
           expect(page).not_to have_css('dt')
@@ -113,7 +113,7 @@ describe 'Browse pages' do
       it 'renders the gallery view' do
         visit spotlight.exhibit_browse_path(exhibit, search)
         expect(page).to have_selector '.view-type-gallery.active'
-        expect(page).to have_selector '#documents.gallery'
+        expect(page).to have_selector '#documents.documents-gallery'
       end
     end
 

data/spec/features/exhibits/translation_editing_spec.rb

@@ -378,6 +378,55 @@ describe 'Translation editing', type: :feature do
     end
   end
 
+  describe 'Browse groups' do
+    before do
+      FactoryBot.create(:group, exhibit: exhibit, title: 'Browse Group 1')
+      FactoryBot.create(:group, exhibit: exhibit, title: 'Browse Group 2')
+
+      visit spotlight.edit_exhibit_translations_path(exhibit, language: 'fr')
+    end
+
+    it 'has a title browse group' do
+      within '#groups' do
+        expect(page).to have_css('input[type="text"]', count: 2)
+
+        expect(page).to have_field 'Browse Group 1'
+        expect(page).to have_field 'Browse Group 2'
+      end
+    end
+
+    it 'redirects to the same form tab' do
+      click_link 'Browse categories'
+      within('#groups', visible: true) do
+        fill_in 'Browse Group 1', with: 'parcourir le groupe 1'
+        click_button 'Save changes'
+      end
+
+      expect(page).to have_css '.nav-pills .nav-link.active', text: 'French'
+      expect(page).to have_css '.nav-tabs .nav-link.active', text: 'Browse groups'
+    end
+
+    it 'persists changes', js: true do
+      click_link 'Browse groups'
+
+      within('#groups', visible: true) do
+        fill_in 'Browse Group 1', with: 'parcourir le groupe 1'
+
+        click_button 'Save changes'
+      end
+
+      expect(page).to have_css('.flash_messages', text: 'The exhibit was successfully updated.')
+
+      expect(exhibit.groups.first.title).to eq 'Browse Group 1'
+
+      I18n.locale = :fr
+      Translation.current_exhibit = exhibit
+      expect(exhibit.groups.first.title).to eq 'parcourir le groupe 1'
+      I18n.locale = I18n.default_locale
+      Translation.current_exhibit = nil
+    end
+  end
+
   describe 'home page translation table entry' do
     let(:feature_page) { FactoryBot.create(:feature_page, exhibit: exhibit) }
     let(:about_page) { FactoryBot.create(:about_page, exhibit: exhibit) }

data/spec/features/home_page_spec.rb

@@ -32,7 +32,7 @@ describe 'Home page', type: :feature, versioning: true do
   end
 
   it 'redirects back to the correct home page URL after updating (no format param to interfere w/ faceting)' do
-    visit spotlight.exhibit_home_page_path(exhibit.home_page)
+    visit spotlight.exhibit_home_page_path(exhibit)
 
     click_link 'Edit'
     click_button 'Save changes'
@@ -41,7 +41,7 @@ describe 'Home page', type: :feature, versioning: true do
   end
 
   it 'has working facet links' do
-    visit spotlight.exhibit_home_page_path(exhibit.home_page)
+    visit spotlight.exhibit_home_page_path(exhibit)
     click_button 'Genre'
     click_link 'map'
     expect(page).to have_content exhibit.title
@@ -49,7 +49,7 @@ describe 'Home page', type: :feature, versioning: true do
   end
 
   it 'has a search box' do
-    visit spotlight.exhibit_home_page_path(exhibit.home_page)
+    visit spotlight.exhibit_home_page_path(exhibit)
     fill_in 'q', with: 'query'
     click_button 'Search'
 
@@ -62,7 +62,7 @@ describe 'Home page', type: :feature, versioning: true do
     TopHat.current['opengraph'] = nil
     Spotlight::Site.instance.update(title: 'some title')
 
-    visit spotlight.exhibit_home_page_path(exhibit.home_page)
+    visit spotlight.exhibit_home_page_path(exhibit)
 
     expect(page).to have_css "meta[name='twitter:card'][value='summary']", visible: false
     expect(page).to have_css "meta[name='twitter:url'][value='#{spotlight.exhibit_root_url(exhibit)}']", visible: false

data/spec/features/javascript/about_page_admin_spec.rb

@@ -12,7 +12,7 @@ describe 'About Pages Adminstration', js: true do
 
     click_link 'About pages'
 
-    add_new_page_via_button('My New Page')
+    add_new_via_button('My New Page')
 
     expect(page).to have_content 'The about page was created.'
     expect(page).to have_css('li.dd-item')

data/spec/features/javascript/block_controls_spec.rb

@@ -12,7 +12,7 @@ describe 'Block controls' do
 
     click_link 'Feature pages'
 
-    add_new_page_via_button('My New Feature Page')
+    add_new_via_button('My New Feature Page')
 
     expect(page).to have_css('h3', text: 'My New Feature Page')
 

data/spec/features/javascript/blocks/browse_group_categories_block_spec.rb

@@ -0,0 +1,64 @@
+# frozen_string_literal: true
+
+describe 'Browse Group Categories', type: :feature, js: true do
+  let(:exhibit) { FactoryBot.create(:exhibit) }
+  let(:exhibit_curator) { FactoryBot.create(:exhibit_curator, exhibit: exhibit) }
+
+  let(:feature_page) { FactoryBot.create(:feature_page, exhibit: exhibit) }
+  let(:search1) { FactoryBot.create(:published_search, exhibit: exhibit, title: 'All of the good dogs') }
+  let(:search2) { FactoryBot.create(:published_search, exhibit: exhibit, title: 'All of the good cats') }
+  let(:search3) { FactoryBot.create(:published_search, exhibit: exhibit, title: 'All of the good birds') }
+  let(:search4) { FactoryBot.create(:published_search, exhibit: exhibit, title: 'All of the good pigs') }
+  let(:search5) { FactoryBot.create(:published_search, exhibit: exhibit, title: 'All of the good tigers') }
+  let(:search6) { FactoryBot.create(:published_search, exhibit: exhibit, title: 'All of the good ferrets') }
+  let(:search7) { FactoryBot.create(:search, exhibit: exhibit, title: 'All of the good turtles') }
+  let!(:group) { FactoryBot.create(:group, exhibit: exhibit, searches: [search1, search2, search3, search4, search5, search6], title: 'Pets', published: true) }
+  let!(:group2) { FactoryBot.create(:group, exhibit: exhibit, searches: [search1, search2], title: 'Good animals', published: true) }
+
+  before do
+    login_as exhibit_curator
+
+    visit spotlight.edit_exhibit_feature_page_path(exhibit, feature_page)
+    add_widget 'browse_group_categories'
+  end
+
+  it 'allows a curator to select a caption to display' do
+    fill_in_prefetched_typeahead_field with: 'Pets', wait_for: '[data-type="browse_group_categories"] [data-browse-groups-fetched]'
+    within '.dd-list' do
+      expect(page).to have_css '.title', text: 'Pets'
+    end
+
+    save_page
+
+    expect(page).to have_css 'h2', text: 'Pets'
+  end
+
+  it 'can navigate using arrows' do
+    fill_in_prefetched_typeahead_field with: 'Pets', wait_for: '[data-type="browse_group_categories"] [data-browse-groups-fetched]'
+    within '.dd-list' do
+      expect(page).to have_css '.title', text: 'Pets'
+    end
+
+    save_page
+
+    expect(page).to have_css 'h2', text: 'Pets'
+
+    expect(page).to have_css '.category-title', text: 'All of the good dogs'
+    expect(page).not_to have_css '.category-title', text: 'All of the good tigers'
+    find('[data-controls="next"]').click
+    expect(page).not_to have_css '.category-title', text: 'All of the good dogs'
+    expect(page).to have_css '.category-title', text: 'All of the good tigers'
+  end
+
+  it 'only published searches are displayed' do
+    fill_in_prefetched_typeahead_field with: 'Pets', wait_for: '[data-type="browse_group_categories"] [data-browse-groups-fetched]'
+    within '.dd-list' do
+      expect(page).to have_css '.title', text: 'Pets'
+    end
+
+    save_page
+
+    expect(page).to have_css 'h2', text: 'Pets'
+    expect(page).to have_css '.box.category-1', count: 6, visible: false
+  end
+end

data/spec/features/javascript/browse_group_admin_spec.rb

@@ -0,0 +1,45 @@
+# frozen_string_literal: true
+
+describe 'Browse Group Adminstration', js: true do
+  let(:exhibit) { FactoryBot.create(:exhibit) }
+  let(:exhibit_curator) { FactoryBot.create(:exhibit_curator, exhibit: exhibit) }
+  let!(:group1) do
+    FactoryBot.create(
+      :group,
+      title: 'Good group 1',
+      exhibit: exhibit
+    )
+  end
+
+  before { login_as exhibit_curator }
+
+  it 'is able to create new groups' do
+    visit spotlight.exhibit_searches_path(exhibit, anchor: 'browse-groups')
+
+    add_new_via_button('My New Group')
+
+    expect(page).to have_content 'The browse group was created.'
+    expect(page).to have_css('li.dd-item')
+    expect(page).to have_css('h4', text: 'My New Group')
+  end
+
+  it 'updates the page titles' do
+    visit spotlight.exhibit_searches_path(exhibit, anchor: 'browse-groups')
+
+    within("[data-id='#{group1.id}']") do
+      within('h4') do
+        expect(page).to have_content('Good group 1')
+        expect(page).to have_css('.title-field', visible: false)
+        click_link('Good group 1')
+        expect(page).to have_css('.title-field', visible: true)
+        find('.title-field').set('New good group 1')
+      end
+    end
+    click_button('Save changes')
+    within("[data-id='#{group1.id}']") do
+      within('h4') do
+        expect(page).to have_content('New good group 1')
+      end
+    end
+  end
+end

data/spec/features/javascript/edit_in_place_spec.rb

@@ -12,7 +12,7 @@ describe 'Edit in place', type: :feature, js: true do
 
       click_link 'Feature pages'
 
-      add_new_page_via_button('My New Feature Page')
+      add_new_via_button('My New Feature Page')
 
       expect(page).to have_css('h3', text: 'My New Feature Page')
 
@@ -38,7 +38,7 @@ describe 'Edit in place', type: :feature, js: true do
 
       click_link 'Feature pages'
 
-      add_new_page_via_button('My New Feature Page')
+      add_new_via_button('My New Feature Page')
 
       expect(page).to have_css('h3', text: 'My New Feature Page')
 

data/spec/features/javascript/feature_page_admin_spec.rb

@@ -26,7 +26,7 @@ describe 'Feature Pages Adminstration', js: true do
 
     click_link 'Feature pages'
 
-    add_new_page_via_button('My New Page')
+    add_new_via_button('My New Page')
 
     expect(page).to have_content 'The feature page was created.'
     expect(page).to have_css('li.dd-item')

data/spec/helpers/spotlight/crud_link_helpers_spec.rb

@@ -104,7 +104,7 @@ describe Spotlight::CrudLinkHelpers, type: :helper do
   describe '#action_default_value' do
     it 'attempts i18n lookups for models' do
       expect(I18n).to receive(:t).with(:'helpers.action.spotlight/feature_page.edit',
-                                       model: some_model.class.model_name.human,
+                                       model: some_model.class.model_name.human.downcase,
                                        default: [:'helpers.action.edit', 'Edit Feature page'])
       expect(helper.send(:action_default_value, some_model))
     end
@@ -112,14 +112,14 @@ describe Spotlight::CrudLinkHelpers, type: :helper do
     it 'attempts i18n lookups for unpersisted models' do
       some_model = Spotlight::FeaturePage.new
       expect(I18n).to receive(:t).with(:'helpers.action.spotlight/feature_page.create',
-                                       model: some_model.class.model_name.human,
+                                       model: some_model.class.model_name.human.downcase,
                                        default: [:'helpers.action.create', 'Create Feature page'])
       expect(helper.send(:action_default_value, some_model))
     end
 
     it 'attempts i18n lookups for models with an explicit action' do
       expect(I18n).to receive(:t).with(:'helpers.action.spotlight/feature_page.custom_action',
-                                       model: some_model.class.model_name.human,
+                                       model: some_model.class.model_name.human.downcase,
                                        default: [:'helpers.action.custom_action', 'Custom action Feature page'])
       expect(helper.send(:action_default_value, some_model, :custom_action))
     end