blacklight-spotlight 3.0.0.alpha.9 → 3.0.0.rc4

data/spec/features/exhibits/translation_editing_spec.rb

@@ -148,7 +148,7 @@ describe 'Translation editing', type: :feature do
         before do
           within '.translation-edit-form #general' do
             fill_in 'Home', with: 'Maison'
-            fill_in 'Search Results', with: 'Résultats de la recherche'
+            fill_in 'Search results', with: 'Résultats de la recherche'
             click_button 'Save changes'
           end
         end
@@ -310,7 +310,7 @@ describe 'Translation editing', type: :feature do
         click_link 'Search field labels'
 
         within('#search_fields', visible: true) do
-          fill_in 'Relevance', with: 'French Relevance'
+          fill_in 'relevance', with: 'French Relevance'
           click_button 'Save changes'
         end
 
@@ -330,10 +330,10 @@ describe 'Translation editing', type: :feature do
 
     it 'has a title and description for every browse category' do
       within '#browse' do
-        expect(page).to have_css('input[type="text"]', count: 2)
+        expect(page).to have_css('input[type="text"]', count: 4)
         expect(page).to have_css('textarea', count: 2)
 
-        expect(page).to have_field 'All Exhibit Items'
+        expect(page).to have_field 'All exhibit items'
         expect(page).to have_field 'Browse Category 1'
         expect(page).to have_css('.form-text', text: 'All items in this exhibit.')
       end
@@ -342,7 +342,7 @@ describe 'Translation editing', type: :feature do
     it 'redirects to the same form tab' do
       click_link 'Browse categories'
       within('#browse', visible: true) do
-        fill_in 'All Exhibit Items', with: "Tous les objets d'exposition"
+        fill_in 'All exhibit items', with: "Tous les objets d'exposition"
         click_button 'Save changes'
       end
 
@@ -354,7 +354,7 @@ describe 'Translation editing', type: :feature do
       click_link 'Browse categories'
 
       within('#browse', visible: true) do
-        fill_in 'All Exhibit Items', with: "Tous les objets d'exposition"
+        fill_in 'All exhibit items', with: "Tous les objets d'exposition"
 
         first('.translation-description-toggle').click
 
@@ -366,7 +366,7 @@ describe 'Translation editing', type: :feature do
 
       expect(page).to have_css('.flash_messages', text: 'The exhibit was successfully updated.')
 
-      expect(exhibit.searches.first.title).to eq 'All Exhibit Items'
+      expect(exhibit.searches.first.title).to eq 'All exhibit items'
       expect(exhibit.searches.first.long_description).to eq 'All items in this exhibit.'
 
       I18n.locale = :fr
@@ -378,6 +378,55 @@ describe 'Translation editing', type: :feature do
     end
   end
 
+  describe 'Browse groups' do
+    before do
+      FactoryBot.create(:group, exhibit: exhibit, title: 'Browse Group 1')
+      FactoryBot.create(:group, exhibit: exhibit, title: 'Browse Group 2')
+
+      visit spotlight.edit_exhibit_translations_path(exhibit, language: 'fr')
+    end
+
+    it 'has a title browse group' do
+      within '#groups' do
+        expect(page).to have_css('input[type="text"]', count: 2)
+
+        expect(page).to have_field 'Browse Group 1'
+        expect(page).to have_field 'Browse Group 2'
+      end
+    end
+
+    it 'redirects to the same form tab' do
+      click_link 'Browse categories'
+      within('#groups', visible: true) do
+        fill_in 'Browse Group 1', with: 'parcourir le groupe 1'
+        click_button 'Save changes'
+      end
+
+      expect(page).to have_css '.nav-pills .nav-link.active', text: 'French'
+      expect(page).to have_css '.nav-tabs .nav-link.active', text: 'Browse groups'
+    end
+
+    it 'persists changes', js: true do
+      click_link 'Browse groups'
+
+      within('#groups', visible: true) do
+        fill_in 'Browse Group 1', with: 'parcourir le groupe 1'
+
+        click_button 'Save changes'
+      end
+
+      expect(page).to have_css('.flash_messages', text: 'The exhibit was successfully updated.')
+
+      expect(exhibit.groups.first.title).to eq 'Browse Group 1'
+
+      I18n.locale = :fr
+      Translation.current_exhibit = exhibit
+      expect(exhibit.groups.first.title).to eq 'parcourir le groupe 1'
+      I18n.locale = I18n.default_locale
+      Translation.current_exhibit = nil
+    end
+  end
+
   describe 'home page translation table entry' do
     let(:feature_page) { FactoryBot.create(:feature_page, exhibit: exhibit) }
     let(:about_page) { FactoryBot.create(:about_page, exhibit: exhibit) }
@@ -407,7 +456,7 @@ describe 'Translation editing', type: :feature do
       visit spotlight.edit_exhibit_translations_path(exhibit, language: 'fr')
       expect(page).to have_link('General 1/8')
       expect(page).to have_link('Search field labels 0/16')
-      expect(page).to have_link('Browse categories 0/2')
+      expect(page).to have_link('Browse categories 0/3')
       expect(page).to have_link('Metadata field labels 0/17')
     end
   end

data/spec/features/home_page_spec.rb

@@ -10,7 +10,7 @@ describe 'Home page', type: :feature, versioning: true do
     visit spotlight.exhibit_dashboard_path(exhibit)
     click_link 'Feature pages'
     expect(page).to have_selector 'h2', text: 'Homepage'
-    expect(page).to have_selector 'h3.card-title', text: 'Exhibit Home'
+    expect(page).to have_selector 'h3.card-title', text: 'Exhibit home'
   end
 
   it 'allows users to edit the home page title' do
@@ -31,8 +31,17 @@ describe 'Home page', type: :feature, versioning: true do
     expect(page).to have_selector '.card-title a', text: 'New Home Page Title'
   end
 
+  it 'redirects back to the correct home page URL after updating (no format param to interfere w/ faceting)' do
+    visit spotlight.exhibit_home_page_path(exhibit)
+
+    click_link 'Edit'
+    click_button 'Save changes'
+
+    expect(page.current_url).to eq spotlight.exhibit_home_page_url(exhibit)
+  end
+
   it 'has working facet links' do
-    visit spotlight.exhibit_home_page_path(exhibit.home_page)
+    visit spotlight.exhibit_home_page_path(exhibit)
     click_button 'Genre'
     click_link 'map'
     expect(page).to have_content exhibit.title
@@ -40,7 +49,7 @@ describe 'Home page', type: :feature, versioning: true do
   end
 
   it 'has a search box' do
-    visit spotlight.exhibit_home_page_path(exhibit.home_page)
+    visit spotlight.exhibit_home_page_path(exhibit)
     fill_in 'q', with: 'query'
     click_button 'Search'
 
@@ -53,7 +62,7 @@ describe 'Home page', type: :feature, versioning: true do
     TopHat.current['opengraph'] = nil
     Spotlight::Site.instance.update(title: 'some title')
 
-    visit spotlight.exhibit_home_page_path(exhibit.home_page)
+    visit spotlight.exhibit_home_page_path(exhibit)
 
     expect(page).to have_css "meta[name='twitter:card'][value='summary']", visible: false
     expect(page).to have_css "meta[name='twitter:url'][value='#{spotlight.exhibit_root_url(exhibit)}']", visible: false

data/spec/features/item_admin_spec.rb

@@ -30,12 +30,12 @@ describe 'Item Administration', type: :feature do
     it 'has a public/private toggle' do
       visit spotlight.admin_exhibit_catalog_path(exhibit)
       item = first('tr[itemscope]')
-      expect(item).to have_button 'Make Private'
-      item.click_button 'Make Private'
+      expect(item).to have_button 'Make private'
+      item.click_button 'Make private'
 
       item = first('tr[itemscope]')
-      expect(item).to have_button 'Make Public'
-      item.click_button 'Make Public'
+      expect(item).to have_button 'Make public'
+      item.click_button 'Make public'
     end
 
     it "toggles the 'blacklight-private' label", js: true, default_max_wait_time: 5 do

data/spec/features/javascript/about_page_admin_spec.rb

@@ -12,7 +12,7 @@ describe 'About Pages Adminstration', js: true do
 
     click_link 'About pages'
 
-    add_new_page_via_button('My New Page')
+    add_new_via_button('My New Page')
 
     expect(page).to have_content 'The about page was created.'
     expect(page).to have_css('li.dd-item')

data/spec/features/javascript/block_controls_spec.rb

@@ -12,7 +12,7 @@ describe 'Block controls' do
 
     click_link 'Feature pages'
 
-    add_new_page_via_button('My New Feature Page')
+    add_new_via_button('My New Feature Page')
 
     expect(page).to have_css('h3', text: 'My New Feature Page')
 
@@ -27,10 +27,12 @@ describe 'Block controls' do
 
     within('.spotlight-block-controls') do
       expect(page).to have_css('.st-controls-group', count: 2)
+
       within(first('.st-controls-group')) do
         expect(page).to have_content 'Standard widgets'
         expect(page).to have_css('.st-block-controls__button')
       end
+
       within(all('.st-controls-group').last) do
         expect(page).to have_content 'Exhibit item widgets'
         expect(page).to have_css('.st-block-controls__button')

data/spec/features/javascript/blocks/browse_group_categories_block_spec.rb

@@ -0,0 +1,64 @@
+# frozen_string_literal: true
+
+describe 'Browse Group Categories', type: :feature, js: true do
+  let(:exhibit) { FactoryBot.create(:exhibit) }
+  let(:exhibit_curator) { FactoryBot.create(:exhibit_curator, exhibit: exhibit) }
+
+  let(:feature_page) { FactoryBot.create(:feature_page, exhibit: exhibit) }
+  let(:search1) { FactoryBot.create(:published_search, exhibit: exhibit, title: 'All of the good dogs') }
+  let(:search2) { FactoryBot.create(:published_search, exhibit: exhibit, title: 'All of the good cats') }
+  let(:search3) { FactoryBot.create(:published_search, exhibit: exhibit, title: 'All of the good birds') }
+  let(:search4) { FactoryBot.create(:published_search, exhibit: exhibit, title: 'All of the good pigs') }
+  let(:search5) { FactoryBot.create(:published_search, exhibit: exhibit, title: 'All of the good tigers') }
+  let(:search6) { FactoryBot.create(:published_search, exhibit: exhibit, title: 'All of the good ferrets') }
+  let(:search7) { FactoryBot.create(:search, exhibit: exhibit, title: 'All of the good turtles') }
+  let!(:group) { FactoryBot.create(:group, exhibit: exhibit, searches: [search1, search2, search3, search4, search5, search6], title: 'Pets', published: true) }
+  let!(:group2) { FactoryBot.create(:group, exhibit: exhibit, searches: [search1, search2], title: 'Good animals', published: true) }
+
+  before do
+    login_as exhibit_curator
+
+    visit spotlight.edit_exhibit_feature_page_path(exhibit, feature_page)
+    add_widget 'browse_group_categories'
+  end
+
+  it 'allows a curator to select a caption to display' do
+    fill_in_prefetched_typeahead_field with: 'Pets', wait_for: '[data-type="browse_group_categories"] [data-browse-groups-fetched]'
+    within '.dd-list' do
+      expect(page).to have_css '.title', text: 'Pets'
+    end
+
+    save_page
+
+    expect(page).to have_css 'h2', text: 'Pets'
+  end
+
+  it 'can navigate using arrows' do
+    fill_in_prefetched_typeahead_field with: 'Pets', wait_for: '[data-type="browse_group_categories"] [data-browse-groups-fetched]'
+    within '.dd-list' do
+      expect(page).to have_css '.title', text: 'Pets'
+    end
+
+    save_page
+
+    expect(page).to have_css 'h2', text: 'Pets'
+
+    expect(page).to have_css '.category-title', text: 'All of the good dogs'
+    expect(page).not_to have_css '.category-title', text: 'All of the good tigers'
+    find('[data-controls="next"]').click
+    expect(page).not_to have_css '.category-title', text: 'All of the good dogs'
+    expect(page).to have_css '.category-title', text: 'All of the good tigers'
+  end
+
+  it 'only published searches are displayed' do
+    fill_in_prefetched_typeahead_field with: 'Pets', wait_for: '[data-type="browse_group_categories"] [data-browse-groups-fetched]'
+    within '.dd-list' do
+      expect(page).to have_css '.title', text: 'Pets'
+    end
+
+    save_page
+
+    expect(page).to have_css 'h2', text: 'Pets'
+    expect(page).to have_css '.box.category-1', count: 6, visible: false
+  end
+end

data/spec/features/javascript/blocks/uploaded_items_block_spec.rb

@@ -26,6 +26,7 @@ describe 'Uploaded Items Block', feature: true, js: true, versioning: true do
     within('.dd-list') do
       expect(page).to have_css('.card-title', text: '800x600.png')
       fill_in 'Caption', with: 'Some caption text'
+      fill_in 'Link URL', with: 'https://example.com/'
     end
 
     attach_file('uploaded_item_url', fixture_file2)
@@ -41,8 +42,10 @@ describe 'Uploaded Items Block', feature: true, js: true, versioning: true do
     expect(page).to have_css('p', text: text)
 
     within('.uploaded-items-block') do
-      expect(page).to have_css('img[alt=""]', count: 2)
+      expect(page).to have_css('img[alt=""]', count: 1)
+      expect(page).to have_css('img[alt="Some caption text"]', count: 1)
       expect(page).to have_css '.caption', text: 'Some caption text'
+      expect(page).to have_link 'Some caption text', href: 'https://example.com/'
     end
   end
 

data/spec/features/javascript/browse_group_admin_spec.rb

@@ -0,0 +1,45 @@
+# frozen_string_literal: true
+
+describe 'Browse Group Adminstration', js: true do
+  let(:exhibit) { FactoryBot.create(:exhibit) }
+  let(:exhibit_curator) { FactoryBot.create(:exhibit_curator, exhibit: exhibit) }
+  let!(:group1) do
+    FactoryBot.create(
+      :group,
+      title: 'Good group 1',
+      exhibit: exhibit
+    )
+  end
+
+  before { login_as exhibit_curator }
+
+  it 'is able to create new groups' do
+    visit spotlight.exhibit_searches_path(exhibit, anchor: 'browse-groups')
+
+    add_new_via_button('My New Group')
+
+    expect(page).to have_content 'The browse group was created.'
+    expect(page).to have_css('li.dd-item')
+    expect(page).to have_css('h4', text: 'My New Group')
+  end
+
+  it 'updates the page titles' do
+    visit spotlight.exhibit_searches_path(exhibit, anchor: 'browse-groups')
+
+    within("[data-id='#{group1.id}']") do
+      within('h4') do
+        expect(page).to have_content('Good group 1')
+        expect(page).to have_css('.title-field', visible: false)
+        click_link('Good group 1')
+        expect(page).to have_css('.title-field', visible: true)
+        find('.title-field').set('New good group 1')
+      end
+    end
+    click_button('Save changes')
+    within("[data-id='#{group1.id}']") do
+      within('h4') do
+        expect(page).to have_content('New good group 1')
+      end
+    end
+  end
+end

data/spec/features/javascript/edit_in_place_spec.rb

@@ -12,7 +12,7 @@ describe 'Edit in place', type: :feature, js: true do
 
       click_link 'Feature pages'
 
-      add_new_page_via_button('My New Feature Page')
+      add_new_via_button('My New Feature Page')
 
       expect(page).to have_css('h3', text: 'My New Feature Page')
 
@@ -38,7 +38,7 @@ describe 'Edit in place', type: :feature, js: true do
 
       click_link 'Feature pages'
 
-      add_new_page_via_button('My New Feature Page')
+      add_new_via_button('My New Feature Page')
 
       expect(page).to have_css('h3', text: 'My New Feature Page')
 
@@ -73,7 +73,7 @@ describe 'Edit in place', type: :feature, js: true do
       within('#nested-navigation') do
         expect(page).to have_css("#exhibit_main_navigations_attributes_0_label[type='hidden']", visible: false)
         expect(page).not_to have_css("#exhibit_main_navigations_attributes_0_label[type='text']")
-        click_link('Curated Features')
+        click_link('Curated features')
         expect(page).not_to have_css("#exhibit_main_navigations_attributes_0_label[type='hidden']")
         expect(page).to have_css("#exhibit_main_navigations_attributes_0_label[type='text']")
         fill_in 'exhibit_main_navigations_attributes_0_label', with: 'My Page Label'

data/spec/features/javascript/feature_page_admin_spec.rb

@@ -26,7 +26,7 @@ describe 'Feature Pages Adminstration', js: true do
 
     click_link 'Feature pages'
 
-    add_new_page_via_button('My New Page')
+    add_new_via_button('My New Page')
 
     expect(page).to have_content 'The feature page was created.'
     expect(page).to have_css('li.dd-item')

data/spec/features/javascript/reindex_monitor_spec.rb

@@ -8,7 +8,7 @@ describe 'Reindex Monitor', js: true, default_max_wait_time: 10 do
   let(:exhibit_curator) { FactoryBot.create(:exhibit_curator, exhibit: exhibit) }
 
   before do
-    FactoryBot.create(:in_progress_reindexing_log_entry, exhibit: exhibit, items_reindexed_estimate: 5)
+    exhibit.job_trackers.create(resource: exhibit, status: 'completed', job_class: 'Spotlight::ReindexExhibitJob')
     login_as exhibit_curator
     visit spotlight.admin_exhibit_catalog_path(exhibit)
   end

data/spec/features/javascript/search_config_admin_spec.rb

@@ -120,7 +120,7 @@ describe 'Search Configuration Administration', js: true do
       within('#nested-sort-fields') do
         expect(page).to have_css("#blacklight_configuration_sort_fields_title_label[type='hidden']", visible: false)
         expect(page).not_to have_css("#blacklight_configuration_sort_fields_title_label[type='text']")
-        click_link('Title')
+        click_link('title')
         expect(page).not_to have_css("#blacklight_configuration_sort_fields_title_label[type='hidden']")
         expect(page).to have_css("#blacklight_configuration_sort_fields_title_label[type='text']")
         fill_in 'blacklight_configuration_sort_fields_title_label', with: 'My Title Label'

data/spec/features/report_a_problem_spec.rb

@@ -27,15 +27,16 @@ describe 'Report a Problem', type: :feature do
 
       click_on 'Feedback'
 
-      expect(page).to have_css('h2', text: 'Contact Us', visible: true)
+      expect(page).to have_css('h2', text: 'Contact us', visible: true)
     end
 
     it 'accepts a problem report', js: true do
       visit spotlight.exhibit_solr_document_path(exhibit, id: 'dq287tq6352')
       click_on 'Feedback'
+      expect(page).to have_css('.alert-primary', text: '/dq287tq6352')
       expect(find('#contact_form_current_url', visible: false).value).to end_with spotlight.exhibit_solr_document_path(exhibit, id: 'dq287tq6352')
-      fill_in 'Name', with: 'Some Body'
-      fill_in 'Email', with: 'test@example.com'
+      fill_in 'Your name', with: 'Some Body'
+      fill_in 'Your email', with: 'test@example.com'
       fill_in 'Message', with: 'This is my problem report'
 
       expect do
@@ -47,8 +48,8 @@ describe 'Report a Problem', type: :feature do
       visit spotlight.exhibit_solr_document_path(exhibit, id: 'dq287tq6352')
       click_on 'Feedback'
       expect(find('#contact_form_current_url', visible: false).value).to end_with spotlight.exhibit_solr_document_path(exhibit, id: 'dq287tq6352')
-      fill_in 'Name', with: 'Some Body'
-      fill_in 'Email', with: 'test@example.com'
+      fill_in 'Your name', with: 'Some Body'
+      fill_in 'Your email', with: 'test@example.com'
       page.evaluate_script("$('#contact_form_#{honeypot_field_name}').val('possible_spam@spam.com')")
       fill_in 'Message', with: 'This is my problem report'
 

data/spec/features/site_users_management_spec.rb

@@ -44,13 +44,13 @@ describe 'Site users management', js: true do
 
     expect(page).to have_css(:td, text: 'not-an-admin@example.com')
 
-    expect(page).to have_css(:a, text: 'Remove from admin role', count: 4)
+    expect(page).to have_css(:a, text: 'Remove from admin role', count: 2)
     within(all('table tbody tr:not([data-edit-for])').last) do
       click_link 'Remove from admin role'
     end
 
     expect(page).to have_content 'User removed from site adminstrator role'
-    expect(page).to have_css(:a, text: 'Remove from admin role', count: 2)
+    expect(page).to have_css(:a, text: 'Remove from admin role', count: 0)
   end
 
   it 'sends an invitation email to users who do not exist' do
@@ -68,7 +68,7 @@ describe 'Site users management', js: true do
     click_link 'Add new administrator'
 
     expect(page).to have_css('td', text: user.email)
-    # There are two users, the original site admin and our admin user so only one button
-    expect(page).to have_css(:a, text: 'Remove from admin role', count: 2)
+    # There is just our admin user so no button
+    expect(page).to have_css(:a, text: 'Remove from admin role', count: 0)
   end
 end