blacklight-spotlight 3.0.0.alpha.8 → 3.0.0.rc3

data/spec/features/home_page_spec.rb

@@ -10,7 +10,7 @@ describe 'Home page', type: :feature, versioning: true do
     visit spotlight.exhibit_dashboard_path(exhibit)
     click_link 'Feature pages'
     expect(page).to have_selector 'h2', text: 'Homepage'
-    expect(page).to have_selector 'h3.card-title', text: 'Exhibit Home'
+    expect(page).to have_selector 'h3.card-title', text: 'Exhibit home'
   end
 
   it 'allows users to edit the home page title' do
@@ -31,8 +31,17 @@ describe 'Home page', type: :feature, versioning: true do
     expect(page).to have_selector '.card-title a', text: 'New Home Page Title'
   end
 
+  it 'redirects back to the correct home page URL after updating (no format param to interfere w/ faceting)' do
+    visit spotlight.exhibit_home_page_path(exhibit)
+
+    click_link 'Edit'
+    click_button 'Save changes'
+
+    expect(page.current_url).to eq spotlight.exhibit_home_page_url(exhibit)
+  end
+
   it 'has working facet links' do
-    visit spotlight.exhibit_home_page_path(exhibit.home_page)
+    visit spotlight.exhibit_home_page_path(exhibit)
     click_button 'Genre'
     click_link 'map'
     expect(page).to have_content exhibit.title
@@ -40,7 +49,7 @@ describe 'Home page', type: :feature, versioning: true do
   end
 
   it 'has a search box' do
-    visit spotlight.exhibit_home_page_path(exhibit.home_page)
+    visit spotlight.exhibit_home_page_path(exhibit)
     fill_in 'q', with: 'query'
     click_button 'Search'
 
@@ -53,7 +62,7 @@ describe 'Home page', type: :feature, versioning: true do
     TopHat.current['opengraph'] = nil
     Spotlight::Site.instance.update(title: 'some title')
 
-    visit spotlight.exhibit_home_page_path(exhibit.home_page)
+    visit spotlight.exhibit_home_page_path(exhibit)
 
     expect(page).to have_css "meta[name='twitter:card'][value='summary']", visible: false
     expect(page).to have_css "meta[name='twitter:url'][value='#{spotlight.exhibit_root_url(exhibit)}']", visible: false

data/spec/features/item_admin_spec.rb

@@ -30,12 +30,12 @@ describe 'Item Administration', type: :feature do
     it 'has a public/private toggle' do
       visit spotlight.admin_exhibit_catalog_path(exhibit)
       item = first('tr[itemscope]')
-      expect(item).to have_button 'Make Private'
-      item.click_button 'Make Private'
+      expect(item).to have_button 'Make private'
+      item.click_button 'Make private'
 
       item = first('tr[itemscope]')
-      expect(item).to have_button 'Make Public'
-      item.click_button 'Make Public'
+      expect(item).to have_button 'Make public'
+      item.click_button 'Make public'
     end
 
     it "toggles the 'blacklight-private' label", js: true, default_max_wait_time: 5 do

data/spec/features/javascript/about_page_admin_spec.rb

@@ -12,7 +12,7 @@ describe 'About Pages Adminstration', js: true do
 
     click_link 'About pages'
 
-    add_new_page_via_button('My New Page')
+    add_new_via_button('My New Page')
 
     expect(page).to have_content 'The about page was created.'
     expect(page).to have_css('li.dd-item')

data/spec/features/javascript/block_controls_spec.rb

@@ -12,7 +12,7 @@ describe 'Block controls' do
 
     click_link 'Feature pages'
 
-    add_new_page_via_button('My New Feature Page')
+    add_new_via_button('My New Feature Page')
 
     expect(page).to have_css('h3', text: 'My New Feature Page')
 
@@ -27,10 +27,12 @@ describe 'Block controls' do
 
     within('.spotlight-block-controls') do
       expect(page).to have_css('.st-controls-group', count: 2)
+
       within(first('.st-controls-group')) do
         expect(page).to have_content 'Standard widgets'
         expect(page).to have_css('.st-block-controls__button')
       end
+
       within(all('.st-controls-group').last) do
         expect(page).to have_content 'Exhibit item widgets'
         expect(page).to have_css('.st-block-controls__button')

data/spec/features/javascript/blocks/browse_group_categories_block_spec.rb

@@ -0,0 +1,64 @@
+# frozen_string_literal: true
+
+describe 'Browse Group Categories', type: :feature, js: true do
+  let(:exhibit) { FactoryBot.create(:exhibit) }
+  let(:exhibit_curator) { FactoryBot.create(:exhibit_curator, exhibit: exhibit) }
+
+  let(:feature_page) { FactoryBot.create(:feature_page, exhibit: exhibit) }
+  let(:search1) { FactoryBot.create(:published_search, exhibit: exhibit, title: 'All of the good dogs') }
+  let(:search2) { FactoryBot.create(:published_search, exhibit: exhibit, title: 'All of the good cats') }
+  let(:search3) { FactoryBot.create(:published_search, exhibit: exhibit, title: 'All of the good birds') }
+  let(:search4) { FactoryBot.create(:published_search, exhibit: exhibit, title: 'All of the good pigs') }
+  let(:search5) { FactoryBot.create(:published_search, exhibit: exhibit, title: 'All of the good tigers') }
+  let(:search6) { FactoryBot.create(:published_search, exhibit: exhibit, title: 'All of the good ferrets') }
+  let(:search7) { FactoryBot.create(:search, exhibit: exhibit, title: 'All of the good turtles') }
+  let!(:group) { FactoryBot.create(:group, exhibit: exhibit, searches: [search1, search2, search3, search4, search5, search6], title: 'Pets', published: true) }
+  let!(:group2) { FactoryBot.create(:group, exhibit: exhibit, searches: [search1, search2], title: 'Good animals', published: true) }
+
+  before do
+    login_as exhibit_curator
+
+    visit spotlight.edit_exhibit_feature_page_path(exhibit, feature_page)
+    add_widget 'browse_group_categories'
+  end
+
+  it 'allows a curator to select a caption to display' do
+    fill_in_prefetched_typeahead_field with: 'Pets', wait_for: '[data-type="browse_group_categories"] [data-browse-groups-fetched]'
+    within '.dd-list' do
+      expect(page).to have_css '.title', text: 'Pets'
+    end
+
+    save_page
+
+    expect(page).to have_css 'h2', text: 'Pets'
+  end
+
+  it 'can navigate using arrows' do
+    fill_in_prefetched_typeahead_field with: 'Pets', wait_for: '[data-type="browse_group_categories"] [data-browse-groups-fetched]'
+    within '.dd-list' do
+      expect(page).to have_css '.title', text: 'Pets'
+    end
+
+    save_page
+
+    expect(page).to have_css 'h2', text: 'Pets'
+
+    expect(page).to have_css '.category-title', text: 'All of the good dogs'
+    expect(page).not_to have_css '.category-title', text: 'All of the good tigers'
+    find('[data-controls="next"]').click
+    expect(page).not_to have_css '.category-title', text: 'All of the good dogs'
+    expect(page).to have_css '.category-title', text: 'All of the good tigers'
+  end
+
+  it 'only published searches are displayed' do
+    fill_in_prefetched_typeahead_field with: 'Pets', wait_for: '[data-type="browse_group_categories"] [data-browse-groups-fetched]'
+    within '.dd-list' do
+      expect(page).to have_css '.title', text: 'Pets'
+    end
+
+    save_page
+
+    expect(page).to have_css 'h2', text: 'Pets'
+    expect(page).to have_css '.box.category-1', count: 6, visible: false
+  end
+end

data/spec/features/javascript/blocks/uploaded_items_block_spec.rb

@@ -26,6 +26,7 @@ describe 'Uploaded Items Block', feature: true, js: true, versioning: true do
     within('.dd-list') do
       expect(page).to have_css('.card-title', text: '800x600.png')
       fill_in 'Caption', with: 'Some caption text'
+      fill_in 'Link URL', with: 'https://example.com/'
     end
 
     attach_file('uploaded_item_url', fixture_file2)
@@ -41,8 +42,10 @@ describe 'Uploaded Items Block', feature: true, js: true, versioning: true do
     expect(page).to have_css('p', text: text)
 
     within('.uploaded-items-block') do
-      expect(page).to have_css('img[alt=""]', count: 2)
+      expect(page).to have_css('img[alt=""]', count: 1)
+      expect(page).to have_css('img[alt="Some caption text"]', count: 1)
       expect(page).to have_css '.caption', text: 'Some caption text'
+      expect(page).to have_link 'Some caption text', href: 'https://example.com/'
     end
   end
 

data/spec/features/javascript/browse_group_admin_spec.rb

@@ -0,0 +1,45 @@
+# frozen_string_literal: true
+
+describe 'Browse Group Adminstration', js: true do
+  let(:exhibit) { FactoryBot.create(:exhibit) }
+  let(:exhibit_curator) { FactoryBot.create(:exhibit_curator, exhibit: exhibit) }
+  let!(:group1) do
+    FactoryBot.create(
+      :group,
+      title: 'Good group 1',
+      exhibit: exhibit
+    )
+  end
+
+  before { login_as exhibit_curator }
+
+  it 'is able to create new groups' do
+    visit spotlight.exhibit_searches_path(exhibit, anchor: 'browse-groups')
+
+    add_new_via_button('My New Group')
+
+    expect(page).to have_content 'The browse group was created.'
+    expect(page).to have_css('li.dd-item')
+    expect(page).to have_css('h4', text: 'My New Group')
+  end
+
+  it 'updates the page titles' do
+    visit spotlight.exhibit_searches_path(exhibit, anchor: 'browse-groups')
+
+    within("[data-id='#{group1.id}']") do
+      within('h4') do
+        expect(page).to have_content('Good group 1')
+        expect(page).to have_css('.title-field', visible: false)
+        click_link('Good group 1')
+        expect(page).to have_css('.title-field', visible: true)
+        find('.title-field').set('New good group 1')
+      end
+    end
+    click_button('Save changes')
+    within("[data-id='#{group1.id}']") do
+      within('h4') do
+        expect(page).to have_content('New good group 1')
+      end
+    end
+  end
+end

data/spec/features/javascript/edit_in_place_spec.rb

@@ -12,7 +12,7 @@ describe 'Edit in place', type: :feature, js: true do
 
       click_link 'Feature pages'
 
-      add_new_page_via_button('My New Feature Page')
+      add_new_via_button('My New Feature Page')
 
       expect(page).to have_css('h3', text: 'My New Feature Page')
 
@@ -38,7 +38,7 @@ describe 'Edit in place', type: :feature, js: true do
 
       click_link 'Feature pages'
 
-      add_new_page_via_button('My New Feature Page')
+      add_new_via_button('My New Feature Page')
 
       expect(page).to have_css('h3', text: 'My New Feature Page')
 
@@ -73,7 +73,7 @@ describe 'Edit in place', type: :feature, js: true do
       within('#nested-navigation') do
         expect(page).to have_css("#exhibit_main_navigations_attributes_0_label[type='hidden']", visible: false)
         expect(page).not_to have_css("#exhibit_main_navigations_attributes_0_label[type='text']")
-        click_link('Curated Features')
+        click_link('Curated features')
         expect(page).not_to have_css("#exhibit_main_navigations_attributes_0_label[type='hidden']")
         expect(page).to have_css("#exhibit_main_navigations_attributes_0_label[type='text']")
         fill_in 'exhibit_main_navigations_attributes_0_label', with: 'My Page Label'

data/spec/features/javascript/feature_page_admin_spec.rb

@@ -26,7 +26,7 @@ describe 'Feature Pages Adminstration', js: true do
 
     click_link 'Feature pages'
 
-    add_new_page_via_button('My New Page')
+    add_new_via_button('My New Page')
 
     expect(page).to have_content 'The feature page was created.'
     expect(page).to have_css('li.dd-item')

data/spec/features/javascript/search_config_admin_spec.rb

@@ -120,7 +120,7 @@ describe 'Search Configuration Administration', js: true do
       within('#nested-sort-fields') do
         expect(page).to have_css("#blacklight_configuration_sort_fields_title_label[type='hidden']", visible: false)
         expect(page).not_to have_css("#blacklight_configuration_sort_fields_title_label[type='text']")
-        click_link('Title')
+        click_link('title')
         expect(page).not_to have_css("#blacklight_configuration_sort_fields_title_label[type='hidden']")
         expect(page).to have_css("#blacklight_configuration_sort_fields_title_label[type='text']")
         fill_in 'blacklight_configuration_sort_fields_title_label', with: 'My Title Label'

data/spec/features/report_a_problem_spec.rb

@@ -27,15 +27,16 @@ describe 'Report a Problem', type: :feature do
 
       click_on 'Feedback'
 
-      expect(page).to have_css('h2', text: 'Contact Us', visible: true)
+      expect(page).to have_css('h2', text: 'Contact us', visible: true)
     end
 
     it 'accepts a problem report', js: true do
       visit spotlight.exhibit_solr_document_path(exhibit, id: 'dq287tq6352')
       click_on 'Feedback'
+      expect(page).to have_css('.alert-primary', text: '/dq287tq6352')
       expect(find('#contact_form_current_url', visible: false).value).to end_with spotlight.exhibit_solr_document_path(exhibit, id: 'dq287tq6352')
-      fill_in 'Name', with: 'Some Body'
-      fill_in 'Email', with: 'test@example.com'
+      fill_in 'Your name', with: 'Some Body'
+      fill_in 'Your email', with: 'test@example.com'
       fill_in 'Message', with: 'This is my problem report'
 
       expect do
@@ -47,8 +48,8 @@ describe 'Report a Problem', type: :feature do
       visit spotlight.exhibit_solr_document_path(exhibit, id: 'dq287tq6352')
       click_on 'Feedback'
       expect(find('#contact_form_current_url', visible: false).value).to end_with spotlight.exhibit_solr_document_path(exhibit, id: 'dq287tq6352')
-      fill_in 'Name', with: 'Some Body'
-      fill_in 'Email', with: 'test@example.com'
+      fill_in 'Your name', with: 'Some Body'
+      fill_in 'Your email', with: 'test@example.com'
       page.evaluate_script("$('#contact_form_#{honeypot_field_name}').val('possible_spam@spam.com')")
       fill_in 'Message', with: 'This is my problem report'
 

data/spec/helpers/spotlight/crud_link_helpers_spec.rb

@@ -104,7 +104,7 @@ describe Spotlight::CrudLinkHelpers, type: :helper do
   describe '#action_default_value' do
     it 'attempts i18n lookups for models' do
       expect(I18n).to receive(:t).with(:'helpers.action.spotlight/feature_page.edit',
-                                       model: some_model.class.model_name.human,
+                                       model: some_model.class.model_name.human.downcase,
                                        default: [:'helpers.action.edit', 'Edit Feature page'])
       expect(helper.send(:action_default_value, some_model))
     end
@@ -112,14 +112,14 @@ describe Spotlight::CrudLinkHelpers, type: :helper do
     it 'attempts i18n lookups for unpersisted models' do
       some_model = Spotlight::FeaturePage.new
       expect(I18n).to receive(:t).with(:'helpers.action.spotlight/feature_page.create',
-                                       model: some_model.class.model_name.human,
+                                       model: some_model.class.model_name.human.downcase,
                                        default: [:'helpers.action.create', 'Create Feature page'])
       expect(helper.send(:action_default_value, some_model))
     end
 
     it 'attempts i18n lookups for models with an explicit action' do
       expect(I18n).to receive(:t).with(:'helpers.action.spotlight/feature_page.custom_action',
-                                       model: some_model.class.model_name.human,
+                                       model: some_model.class.model_name.human.downcase,
                                        default: [:'helpers.action.custom_action', 'Custom action Feature page'])
       expect(helper.send(:action_default_value, some_model, :custom_action))
     end

data/spec/helpers/spotlight/pages_helper_spec.rb

@@ -109,13 +109,13 @@ describe Spotlight::PagesHelper, type: :helper do
   end
 
   describe '#content_editor_class' do
-    context 'with a sir-trevor backed page' do
+    context 'a sir-trevor backed page with a custom class' do
       it 'has a custom class' do
         expect(helper.content_editor_class(Spotlight::Page.new)).to eq 'js-st-instance'
       end
     end
 
-    context 'with a sir-trevor backed page' do
+    context 'a sir-trevor backed page with a derived class' do
       it 'derives a css class name from the editor type' do
         expect(helper.content_editor_class(Spotlight::Page.new(content_type: 'Something::Custom'))).to eq 'js-something-custom-instance'
       end

data/spec/i18n_spec.rb

@@ -2,7 +2,6 @@
 
 require 'i18n/tasks'
 
-# rubocop:disable RSpec/DescribeClass
 RSpec.describe 'I18n' do
   let(:i18n) { I18n::Tasks::BaseTask.new }
   let(:missing_keys) { i18n.missing_keys }
@@ -26,4 +25,3 @@ RSpec.describe 'I18n' do
     expect(non_normalized).to be_empty, error_message
   end
 end
-# rubocop:enable RSpec/DescribeClass

data/spec/jobs/spotlight/add_uploads_from_csv_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-describe Spotlight::AddUploadsFromCSV do
+describe Spotlight::AddUploadsFromCsv do
   subject(:job) { described_class.new(data, exhibit, user) }
 
   let(:exhibit) { FactoryBot.create(:exhibit) }
@@ -40,4 +40,16 @@ describe Spotlight::AddUploadsFromCSV do
 
     job.perform_now
   end
+
+  context 'with errors' do
+    it 'collects errors uploaded resources for each row of data' do
+      allow(Spotlight::IndexingCompleteMailer).to receive(:documents_indexed).and_return(double(deliver_now: true))
+      job.perform_now
+      expect(Spotlight::IndexingCompleteMailer).to have_received(:documents_indexed).with(
+        data, exhibit, user,
+        indexed_count: 1,
+        errors: { 1 => array_including(match(/relative URI: x/)), 2 => array_including(match(/Upload is invalid/)) }
+      )
+    end
+  end
 end

data/spec/mailers/spotlight/indexing_complete_mailer_spec.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 describe Spotlight::IndexingCompleteMailer do
-  subject { described_class.documents_indexed [1, 2, 3], exhibit, user }
+  subject { described_class.documents_indexed [1, 2, 3], exhibit, user, indexed_count: 3 }
 
   let(:user) { double(email: 'test@example.com') }
   let(:exhibit) { double(title: 'Exhibit title') }
@@ -29,4 +29,14 @@ describe Spotlight::IndexingCompleteMailer do
   it 'includes the exhibit title' do
     expect(subject.body.encoded).to match exhibit.title
   end
+
+  context 'with errors' do
+    subject { described_class.documents_indexed [], exhibit, user, indexed_count: 0, errors: { 1 => ['missing title'], 20 => ['whatever'] } }
+
+    it 'includes some errors' do
+      expect(subject.body.encoded).to match 'Errors'
+      expect(subject.body.encoded).to match 'Row 1: missing title'
+      expect(subject.body.encoded).to match 'Row 20: whatever'
+    end
+  end
 end

data/spec/models/sir_trevor_rails/blocks/browse_group_categories_block_spec.rb

@@ -0,0 +1,41 @@
+# frozen_string_literal: true
+
+describe SirTrevorRails::Blocks::BrowseGroupCategoriesBlock do
+  subject { described_class.new({ type: '', data: block_data }, page) }
+
+  let!(:exhibit) { FactoryBot.create(:exhibit) }
+  let!(:page) { FactoryBot.create(:feature_page, exhibit: exhibit) }
+  let!(:group1) { FactoryBot.create(:group, exhibit: exhibit, title: 'abc123', published: true) }
+  let!(:group2) { FactoryBot.create(:group, exhibit: exhibit, title: 'xyz321', published: true) }
+
+  let(:block_data) { {} }
+
+  describe '#groups' do
+    it 'is the array of items with display set to true' do
+      block_data[:item] = {
+        '0': { id: 'abc123', display: 'true', weight: '2' },
+        '1': { id: 'xyz321', display: 'true', weight: '1' }
+      }
+      expect(subject.groups.length).to eq 2
+      expect(subject.groups.first.title).to eq 'xyz321'
+    end
+  end
+
+  describe '#groups?' do
+    it 'is the array of items with display set to true' do
+      block_data[:item] = {}
+      expect(subject.be_groups).to be_falsy
+    end
+  end
+
+  describe '#display_item_counts?' do
+    it do
+      expect(subject).not_to be_display_item_counts
+    end
+
+    it do
+      block_data['display-item-counts'] = 'true'
+      expect(subject).to be_display_item_counts
+    end
+  end
+end