blacklight-spotlight 3.0.0.alpha.3 → 3.0.0.alpha.4

data/app/views/spotlight/custom_fields/_form.html.erb

@@ -1,4 +1,4 @@
-<%= bootstrap_form_for @custom_field.new_record? ? [current_exhibit, @custom_field] : [@custom_field.exhibit, @custom_field], layout: :horizontal, label_col: 'col-md-3', control_col: 'col-sm-5', html: {class: 'col-md-9', id: 'edit-search'} do |f| %>
+<%= bootstrap_form_for @custom_field.new_record? ? [current_exhibit, @custom_field] : [@custom_field.exhibit, @custom_field], layout: :horizontal, label_col: 'col-md-3', control_col: 'col-sm-9', html: {class: 'col-md-9', id: 'edit-search'} do |f| %>
 
   <%= f.text_field :label %>
   <%= f.text_area :short_description %>
@@ -15,7 +15,7 @@
 
   <div class="form-actions">
     <div class="primary-actions">
-      <%= link_to t(:"cancel"), edit_exhibit_metadata_configuration_path(current_exhibit), class: "btn btn-link" %>
+      <%= link_to t(:"cancel"), edit_exhibit_metadata_configuration_path(current_exhibit) %>
       <%= f.submit nil, class: 'btn btn-primary' %>
     </div>
   </div>

data/app/views/spotlight/custom_fields/form_group/_text.html.erb

@@ -5,7 +5,7 @@
 
 <div class="form-group <%= "row" if inline %>">
   <% Array(value || '').each_with_index do |v, index| %>
-    <%= f.label field.slug, field.label, namespace: "f#{index}", class: "control-label #{label_col if inline} #{'sr-only' if index > 0}" %>
+    <%= f.label field.slug, field.label, namespace: "f#{index}", class: "col-form-label #{label_col if inline} #{'sr-only' if index > 0}" %>
     <div class="mb-3 <%= control_col if inline %>">
       <%= f.text_area_without_bootstrap field.slug, namespace: "f#{index}",multiple: field.is_multiple?, value: v, class: "form-control field-#{field.slug}", readonly: field.readonly_field? %>
     </div>
@@ -13,7 +13,7 @@
 
   <% if field.is_multiple? && !field.readonly_field? %>
     <%= content_tag :template, id: "spotlight-field-template-#{field.slug}" do %>
-      <%= f.label field.slug, field.label, class: "control-label #{label_col if inline} sr-only" %>
+      <%= f.label field.slug, field.label, class: "col-form-label #{label_col if inline} sr-only" %>
       <div class="mb-3 <%= "#{offset_col} #{control_col}" if inline %>">
         <%= f.text_area_without_bootstrap field.slug, multiple: field.is_multiple?, value: nil, class: "form-control field-#{field.slug}" %>
       </div>

data/app/views/spotlight/custom_fields/form_group/_vocab.html.erb

@@ -5,7 +5,7 @@
 
 <div class="form-group <%= "row" if inline %>">
   <% Array(value || '').each_with_index do |v, index| %>
-    <%= f.label field.slug, field.label, namespace: "f#{index}", class: "control-label #{label_col if inline} #{'sr-only' if index > 0}" %>
+    <%= f.label field.slug, field.label, namespace: "f#{index}", class: "col-form-label #{label_col if inline} #{'sr-only' if index > 0}" %>
     <div class="mb-3 <%= control_col if inline %>">
       <%= f.text_field_without_bootstrap field.slug, namespace: "f#{index}", multiple: field.is_multiple?, value: v, class: "form-control field-#{field.slug}", readonly: field.readonly_field? %>
     </div>
@@ -13,7 +13,7 @@
 
   <% if field.is_multiple? && !field.readonly_field? %>
     <%= content_tag :template, id: "spotlight-field-template-#{field.slug}" do %>
-      <%= f.label field.slug, field.label, class: "control-label #{label_col if inline} sr-only" %>
+      <%= f.label field.slug, field.label, class: "col-form-label #{label_col if inline} sr-only" %>
       <div class="mb-3 <%= "#{offset_col} #{control_col}" if inline %>">
         <%= f.text_field_without_bootstrap field.slug, multiple: field.is_multiple?, value: nil, class: "form-control field-#{field.slug}" %>
       </div>

data/app/views/spotlight/custom_search_fields/_form.html.erb

@@ -6,7 +6,7 @@
 
   <div class="form-actions">
     <div class="primary-actions">
-      <%= link_to t(:"cancel"), edit_exhibit_search_configuration_path(current_exhibit), class: "btn btn-link" %>
+      <%= link_to t(:"cancel"), edit_exhibit_search_configuration_path(current_exhibit) %>
       <%= f.submit nil, class: 'btn btn-primary' %>
     </div>
   </div>

data/app/views/spotlight/dashboards/_page.html.erb

@@ -3,11 +3,11 @@
     <h4 class="h5 mb-0"><%= page.title %></h4>
     <div class="page-links pt-0">
       <% if page.is_a?(Spotlight::HomePage) %>
-          <%= link_to action_default_value(page, :view), current_exhibit, :class => 'btn btn-link' %> &middot;
-          <%= exhibit_edit_link page, edit_exhibit_home_page_path(page.exhibit), :class => 'btn btn-link', data: { turbolinks: false } %>
+          <%= link_to action_default_value(page, :view), current_exhibit %> &middot;
+          <%= exhibit_edit_link page, edit_exhibit_home_page_path(page.exhibit), data: { turbolinks: false } %>
       <% else %>
-        <%= exhibit_view_link page, :class => 'btn btn-link' %> &middot;
-        <%= exhibit_edit_link page, :class => 'btn btn-link', data: { turbolinks: false } %>
+        <%= exhibit_view_link page %> &middot;
+        <%= exhibit_edit_link page, data: { turbolinks: false } %>
       <% end %>
     </div>
   </td>

data/app/views/spotlight/exhibits/_exhibit_card_back.html.erb

@@ -11,8 +11,8 @@
     <p class="description">
       <%= truncated_description = exhibit.description.truncate(168, omission: '', separator: ' ') %>
       <% if exhibit.description.length > 168 %>
-        <%= content_tag(:span,"&hellip;".html_safe, class: "d-sm-block d-md-block") %>
-        <span class="d-sm-none d-md-none">
+        <%= content_tag(:span,"&hellip;".html_safe, class: "d-none d-sm-inline d-xl-none") %>
+        <span class="d-inline d-sm-none d-xl-inline">
           <%= exhibit.description.slice(truncated_description.length, exhibit.description.length) %>
         </span>
       <% end %>

data/app/views/spotlight/feature_pages/_header.html.erb

@@ -12,8 +12,8 @@
           </h3>
         </div>
         <div class="page-links">
-          <%= exhibit_view_link page, exhibit_root_path(page.exhibit), class: 'btn btn-link' %> &middot;
-          <%= exhibit_edit_link page, edit_exhibit_home_page_path(page.exhibit), class: 'btn btn-link', data: { turbolinks: false } %>
+          <%= exhibit_view_link page, exhibit_root_path(page.exhibit) %> &middot;
+          <%= exhibit_edit_link page, edit_exhibit_home_page_path(page.exhibit), data: { turbolinks: false } %>
         </div>
       </div>
     </div>

data/app/views/spotlight/metadata_configurations/edit.html.erb

@@ -55,8 +55,8 @@
             <td>
               <div class="field-label"><%= field.label %></div>
               <div class="actions">
-                <%= exhibit_edit_link field, class: 'btn btn-link' %> &middot;
-                <%= exhibit_delete_link field, class: 'btn btn-link' %>
+                <%= exhibit_edit_link field %> &middot;
+                <%= exhibit_delete_link field %>
               </div>
             </td>
             <td class="field-description">

data/app/views/spotlight/pages/_form.html.erb

@@ -61,7 +61,7 @@
 
   <div class="form-actions">
     <div class="primary-actions">
-      <%= link_to(t('cancel'), :back, class: "btn btn-link", data: (@page.lock && @page.lock.current_session? ? { lock: url_for([spotlight, @page.exhibit, @page.lock]) } : {})) %>
+      <%= link_to(t('cancel'), :back, data: (@page.lock && @page.lock.current_session? ? { lock: url_for([spotlight, @page.exhibit, @page.lock]) } : {})) %>
       <%= f.submit class: 'btn btn-primary' %>
     </div>
   </div>

data/app/views/spotlight/pages/_page.html.erb

@@ -18,9 +18,9 @@
       </div>
 
       <div class="page-links">
-        <%= exhibit_view_link page, :class => 'btn btn-link' %> &middot;
-        <%= exhibit_edit_link page, :class => 'btn btn-link', data: { turbolinks: false } %> &middot;
-        <%= exhibit_delete_link page, :class => 'btn btn-link' %>
+        <%= exhibit_view_link page %> &middot;
+        <%= exhibit_edit_link page, data: { turbolinks: false } %> &middot;
+        <%= exhibit_delete_link page %>
       </div>
       <%- if page.feature_page? -%>
         <%= f.hidden_field :parent_page_id, data: {property: "parent_page"} %>

data/app/views/spotlight/roles/index.html.erb

@@ -18,7 +18,7 @@
           <td></td>
           <td colspan=2>
             <div class="form-actions d-flex justify-content-end">
-              <%= cancel_link r.object, '#', class: 'btn btn-link', data: {behavior: 'cancel-edit' } %>
+              <%= cancel_link r.object, '#', class: 'btn-sizing', data: {behavior: 'cancel-edit' } %>
               <%=f.submit nil, class: 'btn btn-primary'%>
             </div>
           </td>
@@ -43,7 +43,7 @@
           </td>
           <td colspan=2>
             <div class="form-actions d-flex justify-content-end">
-              <%= cancel_link r.object, '#', class: 'btn btn-link', data: {behavior: 'cancel-edit' } %>
+              <%= cancel_link r.object, '#', class: 'btn-sizing', data: {behavior: 'cancel-edit' } %>
               <%=f.submit nil, class: 'btn btn-primary'%>
             </div>
           </td>

data/app/views/spotlight/search_configurations/_facet_metadata.html.erb

@@ -6,9 +6,4 @@
   <% else %>
     <%= content_tag :span, t(:'.value_count', count: metadata[:value_count]) %>
   <% end %>
-  <% if metadata[:terms].any? %>
-    <%= content_tag("span", class: 'btn-with-tooltip', data: {container: 'body', toggle: 'tooltip', placement: 'top', title: metadata[:terms].join(" • ")}) do %>
-      <%= blacklight_icon('info') %>
-    <% end %>
-  <% end %>
 <% end %>

data/app/views/spotlight/search_configurations/_facets.html.erb

@@ -21,13 +21,13 @@
                   </h3>
                 </div>
                 <div class="d-flex">
-                  <div class="facet-metadata">
+                  <div class="facet-metadata mr-3">
                     <%= render partial: 'facet_metadata', locals: { metadata: metadata } %>
                   </div>
                   <div class="">
-                    <a class="btn btn-link collapse-toggle collapsed" role="button" data-toggle="collapse" href="#<%= key.parameterize %>_facet_options" aria-expanded="false" aria-controls="<%= key.parameterize %>_facet_options">
+                    <button class="btn btn-link collapse-toggle collapsed" type="button" data-toggle="collapse" data-target="#<%= key.parameterize %>_facet_options" aria-expanded="false" aria-controls="<%= key.parameterize %>_facet_options">
                       Options
-                    </a>
+                    </button>
                     <span class="collapse-chevron">❯</span>
                   </div>
                 </div>

data/app/views/spotlight/search_configurations/_search_fields.html.erb

@@ -63,8 +63,8 @@
           <td>
             <div class="field-label"><%= field.label %></div>
             <div class="actions">
-              <%= exhibit_edit_link field, class: 'btn btn-link' %> &middot;
-              <%= exhibit_delete_link field, class: 'btn btn-link' %>
+              <%= exhibit_edit_link field %> &middot;
+              <%= exhibit_delete_link field %>
             </div>
           </td>
           <td class="field-description">

data/app/views/spotlight/searches/_form.html.erb

@@ -40,7 +40,7 @@
         <% end %>
         <% unless @search.query_params.blank? %>
           <div class="form-group row">
-            <label class="col-md-2 col-sm-2 form-control-label"><%= t(:".query_params") %></label>
+            <label class="col-md-2 col-sm-2 col-form-label"><%= t(:".query_params") %></label>
             <div class="col-md-7 col-sm-7">
               <div class="appliedParams card card-body bg-light d-block">
                 <%= render_constraints(@search.query_params) %>
@@ -68,7 +68,7 @@
 
   <div class="form-actions">
     <div class="primary-actions">
-      <%= cancel_link @search,exhibit_searches_path(@exhibit), class: 'btn btn-link' %>
+      <%= cancel_link @search,exhibit_searches_path(@exhibit), class: 'btn-sizing' %>
       <%= f.submit nil, class: 'btn btn-primary' %>
     </div>
   </div>

data/app/views/spotlight/shared/_report_a_problem.html.erb

@@ -14,7 +14,7 @@
       <%= f.hidden_field :current_url %>
       <div class="form-actions">
         <div class="primary-actions">
-        <%= link_to t(:'helpers.action.cancel'), '#', class: 'btn btn-link', data: { 'behavior' => 'cancel-link' } %>
+        <%= link_to t(:'helpers.action.cancel'), '#', class: 'btn-sizing', data: { 'behavior' => 'cancel-link' } %>
         <%= f.submit nil, class: 'btn btn-primary' %>
         </div>
       </div>

data/app/views/spotlight/sir_trevor/blocks/_oembed_block.html.erb

@@ -1,4 +1,4 @@
-<div class="content-block item-text row d-block">
+<div class="content-block item-text row d-block clearfix">
   <div class="<%= 'col-md-6' if oembed_block.text? %> col-12 <%= oembed_block.content_align == 'right' ? 'float-right' : 'float-left' %> oembed-block">
     <%= render_oembed_tag oembed_block.url %>
   </div>

data/app/views/spotlight/sir_trevor/blocks/_quote_block.html.erb

@@ -1,6 +1,6 @@
 <div class="st__content-block st__content-block--quote">
   <div class="quote">
-    <blockquote>
+    <blockquote class="blockquote">
       <div class="quote__content">
         <% if quote_block.format == :html %>
             <%= sir_trevor_format quote_block.text, format: quote_block.format %>
@@ -10,9 +10,9 @@
       </div>
 
       <% if quote_block.cite.present? %>
-        <div class="quote__cite">
-          <cite class="quote__cite-text">&ndash; <%= quote_block.cite %></cite>
-        </div>
+        <footer class="quote__cite blockquote-footer">
+          <cite class="quote__cite-text"><%= quote_block.cite %></cite>
+        </footer>
       <% end %>
     </blockquote>
   </div>

data/app/views/spotlight/sir_trevor/blocks/_solr_documents_block.html.erb

@@ -1,6 +1,6 @@
 <% solr_documents_block.with_solr_helper(self) %>
 
-<div class="content-block items-block row d-block">
+<div class="content-block items-block row d-block clearfix">
   <% if solr_documents_block.documents? %>
 
     <div class="items-col spotlight-flexbox <%= solr_documents_block.text? ? "col-md-6" : "col-md-12" %> <%= solr_documents_block.content_align == 'right' ? 'float-right' : 'float-left' %>">

data/app/views/spotlight/sir_trevor/blocks/_solr_documents_embed_block.html.erb

@@ -1,6 +1,6 @@
 <% solr_documents_embed_block.with_solr_helper(self) %>
 
-<div class="content-block items-block row d-block">
+<div class="content-block items-block row d-block clearfix">
 
   <% if solr_documents_embed_block.documents? %>
     <div class="items-col <%= solr_documents_embed_block.text? ? "col-md-6" : "col-md-12" %> <%= solr_documents_embed_block.content_align == 'right' ? 'float-right' : 'float-left' %>">

data/app/views/spotlight/sir_trevor/blocks/_solr_documents_grid_block.html.erb

@@ -1,5 +1,5 @@
 <% solr_documents_grid_block.with_solr_helper(self) %>
-<div class="content-block item-grid-block row d-block">
+<div class="content-block item-grid-block row d-block clearfix">
   <div class="items-col align-content-start justify-content-between flex-wrap <%= solr_documents_grid_block.text? ? 'col-md-9' : 'col-md-12' %> <%= solr_documents_grid_block.content_align == 'right' ? 'float-right' : 'float-left' %>">
     <% if solr_documents_grid_block.documents? %>
         <% solr_documents_grid_block.each_document.each_with_index do |(block_options, document), index| %>

data/app/views/spotlight/sir_trevor/blocks/_uploaded_items_block.html.erb

@@ -1,4 +1,4 @@
-<div class="content-block item-text row d-block">
+<div class="content-block item-text row d-block clearfix">
   <div class="items-col spotlight-flexbox <%= 'col-md-6' if uploaded_items_block.text? %> col-12 <%= uploaded_items_block.content_align == 'right'  ? 'float-right' : 'float-left'  %> uploaded-items-block">
     <% if uploaded_items_block.files.present? %>
       <% uploaded_items_block.files.each do |file| %>

data/app/views/spotlight/translations/_search_fields.html.erb

@@ -74,7 +74,7 @@
         <%= f.fields_for :translations, translation do |translation_fields| %>
           <%= translation_fields.hidden_field :key %>
           <%= translation_fields.hidden_field :locale %>
-          <div data-translation-progress-item='true' class='form-group translation-form'>
+          <div data-translation-progress-item='true' class='row form-group translation-form'>
             <%= translation_fields.label :value, t("spotlight.search.fields.sort.#{key}", locale: I18n.default_locale), class: 'col-form-label col-12 col-sm-2' %>
             <div class='col-11 col-sm-9 card card-body panel-translation'>
               <%= translation_fields.text_field_without_bootstrap :value, class: 'form-control' %>

data/app/views/spotlight/translations/edit.html.erb

@@ -6,7 +6,7 @@
   <%= curation_page_title t('spotlight.exhibits.translations.title') %>
 
   <div class='text-center'>
-    <ul class='nav nav-pills inline-block'>
+    <ul class='nav nav-pills'>
       <% current_exhibit.available_locales.each do |language| %>
         <li role="presentation" class="nav-item">
           <%= link_to spotlight.edit_exhibit_translations_path(current_exhibit, language: language), class: "nav-link #{'active' if @language == language}" do %>

data/lib/generators/spotlight/install_generator.rb

@@ -64,7 +64,9 @@ module Spotlight
 
     def add_helper
       copy_file 'spotlight_helper.rb', 'app/helpers/spotlight_helper.rb'
-      inject_into_class 'app/helpers/application_helper.rb', ApplicationHelper, '  include SpotlightHelper'
+      inject_into_file 'app/helpers/application_helper.rb', after: 'module ApplicationHelper' do
+        "\n  include SpotlightHelper"
+      end
     end
 
     def add_model_mixin
@@ -107,8 +109,10 @@ module Spotlight
     end
 
     def add_oembed
-      gem 'blacklight-oembed', '>= 0.1', github: 'sul-dlss/blacklight-oembed'
+      gem 'blacklight-oembed', '~> 1.0'
+      Bundler.with_clean_env { run 'bundle install' }
       generate 'blacklight_oembed:install'
+      copy_file 'config/initializers/oembed.rb'
     end
 
     def add_mailer_defaults

data/lib/generators/spotlight/templates/config/initializers/oembed.rb

@@ -0,0 +1,4 @@
+# frozen_string_literal: true
+
+require 'oembed'
+OEmbed::Providers.register_all

data/lib/spotlight/engine.rb

@@ -53,15 +53,10 @@ module Spotlight
       require 'cancan'
       require 'bootstrap_form'
       require 'acts-as-taggable-on'
-      require 'oembed'
 
       Mime::Type.register 'application/solr+json', :solr_json
     end
 
-    initializer 'oembed.initialize' do
-      OEmbed::Providers.register_all
-    end
-
     initializer 'spotlight.factories', after: 'factory_bot.set_factory_paths' do
       FactoryBot.definition_file_paths << File.expand_path('../../spec/factories', __dir__) if defined?(FactoryBot)
     end

data/lib/spotlight/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Spotlight
-  VERSION = '3.0.0.alpha.3'
+  VERSION = '3.0.0.alpha.4'
 end

data/spec/controllers/spotlight/translations_controller_spec.rb

@@ -23,6 +23,14 @@ describe Spotlight::TranslationsController do
         expect(response).to render_template(:edit)
         expect(response).to be_successful
       end
+
+      it 'shows the breadcrumbs' do
+        expect(controller).to receive(:add_breadcrumb).with('Home', exhibit)
+        expect(controller).to receive(:add_breadcrumb).with('Curation', exhibit_dashboard_path(exhibit))
+        expect(controller).to receive(:add_breadcrumb).with('Translations')
+        get :edit, params: { exhibit_id: exhibit }
+        expect(response).to be_successful
+      end
     end
   end
 

data/spec/examples.txt

@@ -920,10 +920,9 @@ example_id
 ./spec/models/spotlight/featured_image_spec.rb[1:2:3]                                           | passed  | 0.00887 seconds |
 ./spec/models/spotlight/featured_image_spec.rb[1:3:1]                                           | passed  | 0.0062 seconds  |
 ./spec/models/spotlight/featured_image_spec.rb[1:3:2]                                           | passed  | 0.00653 seconds |
-./spec/models/spotlight/field_metadata_spec.rb[1:1:1]                                           | passed  | 0.03288 seconds |
-./spec/models/spotlight/field_metadata_spec.rb[1:1:2]                                           | passed  | 0.03303 seconds |
-./spec/models/spotlight/field_metadata_spec.rb[1:1:3]                                           | passed  | 0.03557 seconds |
-./spec/models/spotlight/field_metadata_spec.rb[1:1:4:1]                                         | passed  | 0.03324 seconds |
+./spec/models/spotlight/field_metadata_spec.rb[1:1:1]                                           | passed  | 0.67522 seconds |
+./spec/models/spotlight/field_metadata_spec.rb[1:1:2]                                           | passed  | 0.04106 seconds |
+./spec/models/spotlight/field_metadata_spec.rb[1:1:3:1]                                         | passed  | 0.04338 seconds |
 ./spec/models/spotlight/filter_spec.rb[1:1:1]                                                   | passed  | 0.00736 seconds |
 ./spec/models/spotlight/filter_spec.rb[1:2:1]                                                   | passed  | 0.01274 seconds |
 ./spec/models/spotlight/home_page_spec.rb[1:1]                                                  | passed  | 0.0074 seconds  |
@@ -1335,9 +1334,9 @@ example_id
 ./spec/views/spotlight/resources/_external_resources_form.html.erb_spec.rb[1:1]                 | passed  | 0.02178 seconds |
 ./spec/views/spotlight/resources/new.html.erb_spec.rb[1:1]                                      | passed  | 0.04266 seconds |
 ./spec/views/spotlight/roles/index.html.erb_spec.rb[1:1]                                        | passed  | 0.28461 seconds |
-./spec/views/spotlight/search_configurations/_facet_metadata.html.erb_spec.rb[1:1:1]            | passed  | 0.00845 seconds |
-./spec/views/spotlight/search_configurations/_facet_metadata.html.erb_spec.rb[1:2:1]            | passed  | 0.00983 seconds |
-./spec/views/spotlight/search_configurations/_facet_metadata.html.erb_spec.rb[1:3:1]            | passed  | 0.00867 seconds |
+./spec/views/spotlight/search_configurations/_facet_metadata.html.erb_spec.rb[1:1:1]            | passed  | 0.0101 seconds  |
+./spec/views/spotlight/search_configurations/_facet_metadata.html.erb_spec.rb[1:2:1]            | passed  | 0.3658 seconds  |
+./spec/views/spotlight/search_configurations/_facet_metadata.html.erb_spec.rb[1:3:1]            | passed  | 0.01568 seconds |
 ./spec/views/spotlight/search_configurations/_facets.html.erb_spec.rb[1:1]                      | passed  | 0.14315 seconds |
 ./spec/views/spotlight/search_configurations/_facets.html.erb_spec.rb[1:2]                      | passed  | 0.07287 seconds |
 ./spec/views/spotlight/search_configurations/_facets.html.erb_spec.rb[1:3]                      | passed  | 0.05832 seconds |

data/spec/features/javascript/search_config_admin_spec.rb

@@ -74,7 +74,7 @@ describe 'Search Configuration Administration', js: true do
       click_link 'Facets'
 
       within '.facet-config-genre_ssim' do
-        click_link 'Options'
+        click_button 'Options'
         expect(find(:css, '#blacklight_configuration_facet_fields_genre_ssim_sort_count')).to be_checked
 
         choose 'Value'

data/spec/helpers/spotlight/pages_helper_spec.rb

@@ -121,4 +121,10 @@ describe Spotlight::PagesHelper, type: :helper do
       end
     end
   end
+
+  describe '#render_contact_email_address' do
+    it 'adds soft breaks in appropriate places' do
+      expect(helper.render_contact_email_address('local.part@example.com')).to have_css 'wbr', count: 3, visible: false
+    end
+  end
 end

data/spec/models/spotlight/field_metadata_spec.rb

@@ -48,17 +48,10 @@ describe Spotlight::FieldMetadata do
       expect(subject.field('some_key')[:value_count]).to eq 3
     end
 
-    it 'gets a list of top terms' do
-      expect(subject.field('a')[:terms]).to match_array %w[a b c]
-      expect(subject.field('b')[:terms]).to match_array %w[b]
-      expect(subject.field('some_key')[:terms]).to match_array [7, 8, 9]
-    end
-
     context 'for a missing field' do
       it 'has reasonable default values' do
         expect(subject.field('d')[:document_count]).to eq 0
         expect(subject.field('d')[:value_count]).to eq 0
-        expect(subject.field('d')[:terms]).to be_empty
       end
     end
   end

data/spec/test_app_templates/Gemfile.extra

@@ -1,4 +1,3 @@
 gem 'blacklight', '~> 7.0'
-gem 'blacklight-oembed', '>= 0.1', github: 'sul-dlss/blacklight-oembed'
 gem 'sprockets', '< 4'
 gem 'thor', '~> 0.20'