blacklight-spotlight 3.0.0.alpha.2 → 3.0.0.alpha.3

data/app/views/spotlight/sir_trevor/blocks/_solr_documents_features_block.html.erb

@@ -12,11 +12,11 @@
               <% doc_presenter = index_presenter(document) %>
               <div class="carousel-item <%= 'active' if index == 0 %>" data-id="<%= document.id %>">
                 <% if block_options[:full_image_url].present? %>
-                  <%= link_to_document(document, image_tag(block_options[:full_image_url]), counter: -1) %>
+                  <%= link_to_document(document, image_tag(block_options[:full_image_url], alt: doc_presenter.heading), counter: -1) %>
                 <% elsif block_options[:iiif_tilesource_base].present?  %>
-                  <%= link_to_document(document, image_tag(block_options[:iiif_tilesource_base] + '/full/!800,800/0/default.jpg'), counter: -1) %>
+                  <%= link_to_document(document, image_tag(block_options[:iiif_tilesource_base] + '/full/!800,800/0/default.jpg', alt: doc_presenter.heading), counter: -1) %>
                 <% elsif has_thumbnail? document %>
-                  <%= render_thumbnail_tag(document, {}, document_counter: -1) %>
+                  <%= render_thumbnail_tag(document, { alt: doc_presenter.heading }, document_counter: -1) %>
                 <% end %>
               </div>
 

data/app/views/spotlight/sir_trevor/blocks/_solr_documents_grid_block.html.erb

@@ -1,15 +1,16 @@
 <% solr_documents_grid_block.with_solr_helper(self) %>
-<div class="content-block item-grid-block row <%= 'flex-row-reverse' if solr_documents_grid_block.content_align == 'right' %>">
-  <div class="items-col <%= solr_documents_grid_block.text? ? 'col-md-9' : 'col-md-12' %>">
+<div class="content-block item-grid-block row d-block">
+  <div class="items-col align-content-start justify-content-between flex-wrap <%= solr_documents_grid_block.text? ? 'col-md-9' : 'col-md-12' %> <%= solr_documents_grid_block.content_align == 'right' ? 'float-right' : 'float-left' %>">
     <% if solr_documents_grid_block.documents? %>
         <% solr_documents_grid_block.each_document.each_with_index do |(block_options, document), index| %>
+          <% doc_presenter = index_presenter(document) %>
           <div class="box item-<%= index %>" data-id="<%= document.id %>">
             <% if block_options[:thumbnail_image_url].present? %>
-              <%= link_to_document(document, image_tag(block_options[:thumbnail_image_url], class: 'img-thumbnail'), counter: -1) %>
+              <%= link_to_document(document, image_tag(block_options[:thumbnail_image_url], class: 'img-thumbnail', alt: doc_presenter.heading), counter: -1) %>
             <% elsif block_options[:iiif_tilesource_base].present?  %>
-              <%= link_to_document(document, image_tag(block_options[:iiif_tilesource_base] + '/full/!400,400/0/default.jpg', class: 'img-thumbnail'), counter: -1) %>
+              <%= link_to_document(document, image_tag(block_options[:iiif_tilesource_base] + '/full/!400,400/0/default.jpg', class: 'img-thumbnail', alt: doc_presenter.heading), counter: -1) %>
             <% elsif has_thumbnail? document %>
-              <%= render_thumbnail_tag(document, { class: 'img-thumbnail'}, document_counter: -1) %>
+              <%= render_thumbnail_tag(document, { class: 'img-thumbnail', alt: doc_presenter.heading }, document_counter: -1) %>
             <% end %>
           </div>
         <% end %>
@@ -18,7 +19,7 @@
 
 
   <% if solr_documents_grid_block.text? %>
-    <div class="text-col col-md-3">
+    <div class="text-col col-md-3 mw-100">
       <% unless solr_documents_grid_block.title.blank? %>
         <h3><%= solr_documents_grid_block.title %></h3>
       <% end %>

data/app/views/spotlight/sir_trevor/blocks/_uploaded_items_block.html.erb

@@ -1,10 +1,10 @@
-<div class="content-block item-text row <%= 'flex-row-reverse' if uploaded_items_block.content_align == 'right' %>">
-  <div class="items-col spotlight-flexbox <%= 'col-md-6' if uploaded_items_block.text? %> col-12 uploaded-items-block">
+<div class="content-block item-text row d-block">
+  <div class="items-col spotlight-flexbox <%= 'col-md-6' if uploaded_items_block.text? %> col-12 <%= uploaded_items_block.content_align == 'right'  ? 'float-right' : 'float-left'  %> uploaded-items-block">
     <% if uploaded_items_block.files.present? %>
       <% uploaded_items_block.files.each do |file| %>
         <div class="box" data-id="<%= file[:id] %>">
           <div class="contents">
-            <img class="img-thumbnail" src='<%= file[:url] %>' alt='<%= file[:title] %>' />
+            <img class="img-thumbnail" src='<%= file[:url] %>' alt='' />
             <% if file[:caption].present? %>
               <div class="caption">
                 <%= file[:caption] %>
@@ -17,7 +17,7 @@
   </div>
 
   <% if uploaded_items_block.text? %>
-    <div class="text-col col-md-6">
+    <div class="text-col col-md-6 mw-100">
       <%= content_tag(:h3, uploaded_items_block.title) if uploaded_items_block.title.present? %>
       <%= sir_trevor_markdown uploaded_items_block.text %>
     </div>

data/config/locales/spotlight.en.yml

@@ -27,7 +27,7 @@ en:
   drag: Drag
   helpers:
     action:
-      add_another: Add another
+      add_another: Add another value
       cancel: Cancel
       destroy: Delete
       destroy_are_you_sure: Are you sure you want to delete this %{model}?
@@ -207,9 +207,9 @@ en:
           heading: Exhibit thumbnail
           help: You can select and crop an image to visually represent this exhibit.
     application_name: "%{exhibit} - %{application_name}"
+    breadcrumb:
+      label: Breadcrumb
     browse:
-      index:
-        header: Browse Exhibit
       search:
         item_count:
           one: "%{count} item"
@@ -363,6 +363,8 @@ en:
       solr_document_activity:
         header: Recently Updated Items
         no_documents: There are no documents in this exhibit
+    exhibitnavbar:
+      label: Exhibit navigation
     exhibits:
       breadcrumb: Home
       confirmation_status:
@@ -374,6 +376,7 @@ en:
         email_delete_button: Delete contact
         email_delete_confirmation: Delete contact email address?
         email_delete_error: 'Problem deleting contact email:'
+        email_input_aria_label: Contact email %{index}
       delete:
         heading: Delete exhibit
         warning_html: This action is irreversible. Be sure to back up the exhibit settings and content using the %{export_link} feature before proceeding.
@@ -744,8 +747,9 @@ en:
           help_secondary: To create a browse category-specific masthead, you should use an image that is at least 120 pixels tall and 1200 pixels wide. For best results use an image at least 1800 pixels wide. You can crop larger images using the cropping tool below.
         query_params: Search parameters
         search_box:
+          checkbox_label: Display
           help_block: Displays a search box that enables users to search within the browse category results
-          label: Display search box
+          label: Search box
         search_description: Description
         search_masthead: Masthead
         search_thumbnail: Thumbnail
@@ -754,7 +758,7 @@ en:
       index:
         categories_header: Browse Categories
         header: Browse
-        instructions: Use the Save search button on a search results page to create a new browse category. Select the categories you want to be displayed on the browse landing page. Drag and drop categories to change the order in which they appear on that page."
+        instructions: Use the Save search button on a search results page to create a new browse category. Select the categories you want to be displayed on the browse landing page. Drag and drop categories to change the order in which they appear on that page.
         no_saved_searches: You can save search results while in curation mode to create browse categories, which will be displayed here.
         not_searchable_html: This exhibit is not currently searchable. To perform searches that can be saved as additional browse categories, temporarily turn on the Display search box option in the Options section of the Configuration > %{href} page.
         title: Curation - Browse
@@ -764,6 +768,8 @@ en:
           other: "%{count} items"
         missing_description_html: "%{link} to add a description."
     shared:
+      exhibit_sidebar:
+        header: Administration menu
       report_a_problem:
         honeypot_field_explanation: Ignore this text box. It is used to detect spammers. If you enter anything into this text box, your message will not be sent.
         title: Contact Us
@@ -806,6 +812,8 @@ en:
         no_tags: No items in this exhibit have been tagged. You can add tags to an item on the Item Details page while in curation mode.
         taggings:
           count: Items tagged
+    topbar:
+      label: Utilities
     versions:
       redo: Redo changes
       undo: Undo changes

data/config/locales/spotlight.es.yml

@@ -0,0 +1,40 @@
+---
+es:
+  about_pages:
+    contacts:
+      header: Contacto
+  activemodel:
+    attributes:
+      spotlight/contact_form:
+        email: Correo electrónico
+        message: Mensage
+        name: Nombre
+  browse:
+    search:
+      item_count:
+        one: "%{count} registros"
+        other: "%{count} registros"
+    search_box:
+      label: Buscar en esta categoría
+      placeholder: Buscar
+      reset: Limpiar
+      submit: Buscar en esta categoría
+      success:
+        expand_html: También puede buscar todos los elementos recuperados %{browse_query}.
+        result_number_html: Su búsqueda coincide con %{search_size} de elementos de las %{parent_search_count} en esta  categoría.
+      zero_results:
+        expand_html: Puede %{clear_search_url} borrar su búsqueda o interntar otra que busque en todos los elementos %{browse_query}.
+        result_number: No se encuentran registos con esta búsqueda.
+  header_links:
+    contact: Comentarios
+  helpers:
+    action:
+      cancel: Cancelar
+    submit:
+      contact_form:
+        create: Enviar
+        created: Gracias. Hemos recibido sus comentarios.
+  shared:
+    report_a_problem:
+      honeypot_field_explanation: No escribir en espacio. Es para detectar "spam." Si escribe algo el mensaje no se enviará.
+      title: Contacto

data/config/locales/spotlight.pt-BR.yml

@@ -0,0 +1,25 @@
+pt-BR:
+  activemodel:
+    attributes:
+      spotlight/contact_form:
+        email: Email
+        message: Mensagem
+        name: Nome
+  cancel: Cancelar
+  helpers:
+    action:
+      cancel: Cancelar
+    submit:
+      contact_form:
+        create: Enviar
+        created: Obrigado. Seu comentário foi enviado.
+  spotlight:
+    about_pages:
+      contacts:
+        header: Contatos
+    header_links:
+      contact: Comentários
+    shared:
+      report_a_problem:
+        honeypot_field_explanation: Ignore esta caixa de texto. É usado para detectar spammer. Se você digitar algo nessa caixa de texto, sua mensagem não será enviada.
+        title: Contate-Nos

data/config/routes.rb

@@ -8,7 +8,7 @@ Spotlight::Engine.routes.draw do
   resources :mastheads, controller: :featured_images, only: :create
   resources :featured_images, only: :create
 
-  resource :site, only: [:edit, :update] do
+  resource :site, only: %i[edit update] do
     collection do
       get '/tags', to: 'sites#tags'
     end
@@ -16,7 +16,7 @@ Spotlight::Engine.routes.draw do
 
   get '/exhibits/edit', to: 'sites#edit_exhibits', as: 'edit_site_exhibits'
 
-  resources :admin_users, only: [:index, :create, :update, :destroy]
+  resources :admin_users, only: %i[index create update destroy]
 
   resources :exhibits, path: '/', except: [:show] do
     member do
@@ -28,17 +28,17 @@ Spotlight::Engine.routes.draw do
 
     resources :contact_email, only: [:destroy], defaults: { format: :json }
     resources :attachments, only: :create
-    resource :contact_form, path: 'contact', only: [:new, :create]
+    resource :contact_form, path: 'contact', only: %i[new create]
     resource :blacklight_configuration, only: [:update]
 
-    resource :appearance, only: [:edit, :update]
+    resource :appearance, only: %i[edit update]
 
-    resource :metadata_configuration, only: [:show, :edit, :update]
-    resource :search_configuration, only: [:show, :edit, :update]
+    resource :metadata_configuration, only: %i[show edit update]
+    resource :search_configuration, only: %i[show edit update]
     resource :view_configuration, only: [:show]
 
-    resources :filters, only: [:create, :update]
-    resources :languages, only: [:create, :destroy]
+    resources :filters, only: %i[create update]
+    resources :languages, only: %i[create destroy]
 
     concern :searchable, Blacklight::Routes::Searchable.new
 
@@ -99,10 +99,10 @@ Spotlight::Engine.routes.draw do
         get :autocomplete
       end
     end
-    resources :browse, only: [:index, :show]
-    resources :tags, only: [:index, :destroy]
+    resources :browse, only: %i[index show]
+    resources :tags, only: %i[index destroy]
 
-    resources :contacts, only: [:edit, :update, :destroy]
+    resources :contacts, only: %i[edit update destroy]
 
     resources :pages, only: [:update_all] do
       collection do
@@ -115,7 +115,7 @@ Spotlight::Engine.routes.draw do
       end
       collection do
         patch 'contacts' => 'about_pages#update_contacts'
-        resources :contacts, only: [:new, :create]
+        resources :contacts, only: %i[new create]
         patch :update_all
       end
     end
@@ -137,13 +137,13 @@ Spotlight::Engine.routes.draw do
 
     resources :lock, only: [:destroy]
 
-    resources :roles, path: 'users', only: [:index, :create, :destroy] do
+    resources :roles, path: 'users', only: %i[index create destroy] do
       collection do
         patch :update_all
       end
     end
     post 'solr/update' => 'solr#update'
-    resource :translations, only: [:edit, :update]
+    resource :translations, only: %i[edit update]
   end
 
   get '/:exhibit_id' => 'home_pages#show', as: :exhibit_root

data/lib/generators/spotlight/install_generator.rb

@@ -6,7 +6,7 @@ module Spotlight
   ##
   # spotlight:install generator
   class Install < Rails::Generators::Base
-    source_root File.expand_path('../templates', __FILE__)
+    source_root File.expand_path('templates', __dir__)
     class_option :solr_update_class, type: :string, default: 'Spotlight::SolrDocument::AtomicUpdates'
     class_option :mailer_default_url_host, type: :string, default: '' # e.g. localhost:3000
 

data/lib/generators/spotlight/scaffold_resource_generator.rb

@@ -6,7 +6,7 @@ require 'rails/generators'
 module Spotlight
   # spotlight:scaffold_resource generator
   class ScaffoldResource < Rails::Generators::NamedBase
-    source_root File.expand_path('../templates', __FILE__)
+    source_root File.expand_path('templates', __dir__)
     def create_document_builder
       create_file "app/services/#{file_name}_builder.rb", <<-FILE.strip_heredoc
         class #{class_name}Builder < Spotlight::SolrDocumentBuilder

data/lib/generators/spotlight/templates/config/initializers/translation.rb

@@ -11,11 +11,11 @@ if Translation.table_exists?
   # turn on the ActiveRecord backend, uncomment the following lines.
 
   I18n.backend = I18n::Backend::ActiveRecord.new
-  I18n::Backend::ActiveRecord.send(:include, I18n::Backend::Memoize)
-  Translation.send(:include, Spotlight::CustomTranslationExtension)
-  I18n::Backend::Simple.send(:include, I18n::Backend::Memoize)
-  I18n::Backend::Simple.send(:include, I18n::Backend::Pluralization)
-  I18n::Backend::Simple.send(:include, I18n::Backend::Fallbacks)
+  I18n::Backend::ActiveRecord.include I18n::Backend::Memoize
+  Translation.include Spotlight::CustomTranslationExtension
+  I18n::Backend::Simple.include I18n::Backend::Memoize
+  I18n::Backend::Simple.include I18n::Backend::Pluralization
+  I18n::Backend::Simple.include I18n::Backend::Fallbacks
 
   I18n.backend = I18n::Backend::Chain.new(I18n.backend, I18n::Backend::Simple.new)
 end

data/lib/spotlight/engine.rb

@@ -7,7 +7,6 @@ require 'devise'
 require 'devise_invitable'
 
 require 'blacklight'
-require 'blacklight/oembed'
 require 'autoprefixer-rails'
 require 'friendly_id'
 require 'tophat'
@@ -21,7 +20,7 @@ require 'riiif'
 module Spotlight
   ##
   # Spotlight::Engine
-  # rubocop:disable ClassLength
+  # rubocop:disable Metrics/ClassLength
   class Engine < ::Rails::Engine
     isolate_namespace Spotlight
     # Breadcrumbs on rails must be required outside of an initializer or it doesn't get loaded.
@@ -42,13 +41,13 @@ module Spotlight
     require 'sprockets/es6'
     require 'almond-rails'
 
-    config.assets.precompile += %w(spotlight/fallback/*.png)
+    config.assets.precompile += %w[spotlight/fallback/*.png]
 
-    config.autoload_paths += %W(
+    config.autoload_paths += %W[
       #{config.root}/app/builders
       #{config.root}/app/controllers/concerns
       #{config.root}/app/models/concerns
-    )
+    ]
 
     initializer 'spotlight.initialize' do
       require 'cancan'
@@ -64,11 +63,11 @@ module Spotlight
     end
 
     initializer 'spotlight.factories', after: 'factory_bot.set_factory_paths' do
-      FactoryBot.definition_file_paths << File.expand_path('../../../spec/factories', __FILE__) if defined?(FactoryBot)
+      FactoryBot.definition_file_paths << File.expand_path('../../spec/factories', __dir__) if defined?(FactoryBot)
     end
 
     initializer 'spotlight.assets.precompile' do |app|
-      app.config.assets.precompile += %w(spotlight/default_thumbnail.jpg spotlight/default_browse_thumbnail.jpg)
+      app.config.assets.precompile += %w[spotlight/default_thumbnail.jpg spotlight/default_browse_thumbnail.jpg]
 
       Sprockets::ES6.configuration = { 'modules' => 'amd', 'moduleIds' => true }
       # When we upgrade to Sprockets 4, we can ditch sprockets-es6 and config AMD
@@ -93,7 +92,7 @@ module Spotlight
     config.catalog_controller_class = '::CatalogController'
     config.default_blacklight_config = nil
 
-    config.exhibit_main_navigation = [:curated_features, :browse, :about]
+    config.exhibit_main_navigation = %i[curated_features browse about]
 
     config.resource_partials = [
       'spotlight/resources/external_resources_form',
@@ -114,7 +113,7 @@ module Spotlight
     config.writable_index = true
 
     # The allowed file extensions for uploading non-repository items.
-    config.allowed_upload_extensions = %w(jpg jpeg png)
+    config.allowed_upload_extensions = %w[jpg jpeg png]
 
     # Suffixes for spotlight-created solr fields
     config.solr_fields = OpenStruct.new
@@ -241,16 +240,18 @@ module Spotlight
     end
 
     # make blacklight configuration play nice with bootstrap_form
+    # rubocop:disable Lint/SendWithMixinArgument
     Blacklight::OpenStructWithHashAccess.send(:extend, ActiveModel::Translation)
+    # rubocop:enable Lint/SendWithMixinArgument
 
     config.exhibit_themes = ['default']
 
     config.default_page_content_type = 'SirTrevor'
-    config.sir_trevor_widgets = %w(
+    config.sir_trevor_widgets = %w[
       Heading Text List Quote Iframe Video Oembed Rule UploadedItems Browse LinkToSearch
       FeaturedPages SolrDocuments SolrDocumentsCarousel SolrDocumentsEmbed
       SolrDocumentsFeatures SolrDocumentsGrid SearchResults
-    )
+    ]
 
     config.routes = OpenStruct.new
     config.routes.solr_documents = {}

data/lib/spotlight/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Spotlight
-  VERSION = '3.0.0.alpha.2'
+  VERSION = '3.0.0.alpha.3'
 end

data/lib/tasks/spotlight_tasks.rake

@@ -67,7 +67,7 @@ namespace :spotlight do
       require 'migration/iiif'
       Migration::IIIF.run args[:hostname]
     else
-      STDERR.puts "\nUsage: rake spotlight:migrate_to_iiif[hostname]\n\n  Example: rake spotlight:migrate_to_iiif[https://exhibits.stanford.edu]\n\n"
+      warn "\nUsage: rake spotlight:migrate_to_iiif[hostname]\n\n  Example: rake spotlight:migrate_to_iiif[https://exhibits.stanford.edu]\n\n"
     end
   end
 
@@ -82,7 +82,7 @@ namespace :spotlight do
       puts 'User not found. Enter a password to create the user.'
       u.password = prompt_for_password
     end
-  rescue => e
+  rescue StandardError => e
     puts e
     retry
   end

data/spec/controllers/application_controller_spec.rb

@@ -3,6 +3,7 @@
 describe ApplicationController, type: :controller do
   routes { Spotlight::Engine.routes }
   let(:exhibit) { FactoryBot.create(:exhibit) }
+
   it { is_expected.to be_a_kind_of Spotlight::Controller }
 
   describe 'exhibit-specific routing' do

data/spec/controllers/spotlight/about_pages_controller_spec.rb

@@ -3,12 +3,14 @@
 describe Spotlight::AboutPagesController, type: :controller, versioning: true do
   routes { Spotlight::Engine.routes }
   let(:valid_attributes) { { 'title' => 'MyString', thumbnail: { iiif_url: '' } } }
+
   after do
     I18n.locale = I18n.default_locale
   end
 
   describe 'when not logged in' do
     let(:exhibit) { FactoryBot.create(:exhibit) }
+
     describe 'POST update_all' do
       it 'is not allowed' do
         post :update_all, params: { exhibit_id: exhibit }
@@ -30,11 +32,13 @@ describe Spotlight::AboutPagesController, type: :controller, versioning: true do
   describe 'when signed in as a curator' do
     let(:exhibit) { FactoryBot.create(:exhibit) }
     let(:user) { FactoryBot.create(:exhibit_curator, exhibit: exhibit) }
+
     before { sign_in user }
 
     describe 'GET show' do
       let(:page) { FactoryBot.create(:about_page, weight: 0, exhibit: exhibit) }
       let(:page2) { FactoryBot.create(:about_page, weight: 5, exhibit: exhibit) }
+
       describe 'on the main about page' do
         it 'is successful' do
           expect(controller).to receive(:add_breadcrumb).with('Home', exhibit_root_path(exhibit))
@@ -104,6 +108,7 @@ describe Spotlight::AboutPagesController, type: :controller, versioning: true do
     describe 'GET edit' do
       let!(:page) { FactoryBot.create(:about_page, weight: 0, exhibit: exhibit) }
       let!(:page2) { FactoryBot.create(:about_page, weight: 5, exhibit: exhibit) }
+
       describe 'on the main about page' do
         it 'is successful' do
           expect(controller).to receive(:add_breadcrumb).with('Home', exhibit_root_path(exhibit))
@@ -128,6 +133,7 @@ describe Spotlight::AboutPagesController, type: :controller, versioning: true do
 
     describe 'GET index' do
       let!(:page) { FactoryBot.create(:about_page, exhibit: exhibit) }
+
       it 'is successful' do
         expect(controller).to receive(:add_breadcrumb).with('Home', exhibit_root_path(exhibit))
         expect(controller).to receive(:add_breadcrumb).with('Curation', exhibit_dashboard_path(exhibit))
@@ -149,6 +155,7 @@ describe Spotlight::AboutPagesController, type: :controller, versioning: true do
 
     describe 'PUT update' do
       let!(:page) { FactoryBot.create(:about_page, exhibit: exhibit) }
+
       it 'redirects to the about page' do
         put :update, params: { id: page, exhibit_id: page.exhibit.id, about_page: valid_attributes }
         page.reload
@@ -161,6 +168,7 @@ describe Spotlight::AboutPagesController, type: :controller, versioning: true do
       let!(:page1) { FactoryBot.create(:about_page, exhibit: exhibit) }
       let!(:page2) { FactoryBot.create(:about_page, exhibit: exhibit, published: true) }
       let!(:page3) { FactoryBot.create(:about_page, exhibit: exhibit, published: true) }
+
       before { request.env['HTTP_REFERER'] = 'http://example.com' }
 
       it 'updates whether they are on the landing page' do
@@ -185,6 +193,7 @@ describe Spotlight::AboutPagesController, type: :controller, versioning: true do
     describe 'PATCH update_contacts' do
       let!(:contact1) { FactoryBot.create(:contact, name: 'Aphra Behn', exhibit: exhibit) }
       let!(:contact2) { FactoryBot.create(:contact, exhibit: exhibit) }
+
       it 'updates contacts' do
         patch :update_contacts, params: {
           exhibit_id: exhibit,
@@ -202,6 +211,7 @@ describe Spotlight::AboutPagesController, type: :controller, versioning: true do
         expect(contact1.reload.weight).to eq 1
         expect(contact2.reload.weight).to eq 2
       end
+
       it 'shows index on failure' do
         expect_any_instance_of(Spotlight::Exhibit).to receive(:update).and_return(false)
         patch :update_contacts, params: {