blacklight-spotlight 2.0.2 → 2.1.0

data/spec/features/about_page_spec.rb

@@ -19,8 +19,10 @@ describe 'About page', type: :feature, versioning: true do
       end
     end
   end
+
   describe 'page options' do
     before { login_as exhibit_curator }
+
     describe 'publish' do
       it 'is updatable from the edit page' do
         expect(unpublished_page).not_to be_published

data/spec/features/add_contacts_spec.rb

@@ -3,6 +3,7 @@ describe 'Add a contact to an exhibit', type: :feature do
   let(:exhibit) { FactoryBot.create(:exhibit) }
   let!(:about_page) { FactoryBot.create(:about_page, exhibit: exhibit) }
   before { login_as curator }
+
   it 'displays a newly added contact in the sidebar' do
     visit spotlight.exhibit_about_pages_path(exhibit)
     click_link 'Add contact'

data/spec/features/browse_category_admin_spec.rb

@@ -3,12 +3,14 @@ describe 'Browse Category Administration', type: :feature do
   let(:curator) { FactoryBot.create(:exhibit_curator, exhibit: exhibit) }
   let!(:search) { FactoryBot.create(:search, exhibit: exhibit, query_params: { f: { 'genre_ssim' => ['Value'] } }) }
   before { login_as curator }
+
   describe 'index' do
     it 'has searches' do
       visit spotlight.exhibit_searches_path(exhibit)
       expect(page).to have_css('.panel .search .title', text: search.title)
     end
   end
+
   describe 'create' do
     it 'creates a new browse category with the current search parameters', js: true do
       visit spotlight.search_exhibit_catalog_path(exhibit, q: 'xyz')
@@ -30,6 +32,7 @@ describe 'Browse Category Administration', type: :feature do
       expect(search.reload.query_params).to eq 'q' => 'xyz'
     end
   end
+
   describe 'edit' do
     it 'displays an edit form' do
       visit spotlight.edit_exhibit_search_path(exhibit, search)
@@ -109,6 +112,7 @@ describe 'Browse Category Administration', type: :feature do
       expect(search.default_index_view_type).to eq 'list'
     end
   end
+
   describe 'destroy' do
     it 'destroys a tag' do
       skip('TODO: Allow searches to be destroyed without javascript')

data/spec/features/edit_contact_spec.rb

@@ -4,6 +4,7 @@ describe 'Add a contact to an exhibit', type: :feature do
   let!(:about_page) { FactoryBot.create(:about_page, exhibit: exhibit) }
   let!(:contact) { FactoryBot.create(:contact, name: 'Marcus Aurelius', exhibit: exhibit) }
   before { login_as curator }
+
   it 'displays a newly added contact in the sidebar' do
     visit spotlight.exhibit_about_pages_path(exhibit)
 

data/spec/features/exhibit_masthead_spec.rb

@@ -3,6 +3,7 @@ describe 'Add and update the site masthead', type: :feature do
   let(:user) { FactoryBot.create(:exhibit_admin, exhibit: exhibit) }
 
   before { login_as user }
+
   it 'updates exhibit masthead options' do
     visit spotlight.exhibit_dashboard_path(exhibit)
 

data/spec/features/exhibit_themes_spec.rb

@@ -3,6 +3,7 @@ describe 'Update the site theme', type: :feature do
   let(:user) { FactoryBot.create(:exhibit_admin, exhibit: exhibit) }
 
   before { login_as user }
+
   it 'updates the exhibit theme' do
     visit spotlight.edit_exhibit_appearance_path(exhibit)
 

data/spec/features/exhibits/add_tags_spec.rb

@@ -1,4 +1,3 @@
-
 describe 'Add tags to an item in an exhibit', type: :feature do
   let(:exhibit) { FactoryBot.create(:exhibit) }
   let(:curator) { FactoryBot.create(:exhibit_curator, exhibit: exhibit) }

data/spec/features/exhibits/custom_metadata_fields_spec.rb

@@ -1,4 +1,3 @@
-
 describe 'Adding custom metadata fields', type: :feature do
   let(:exhibit) { FactoryBot.create(:exhibit) }
   let(:admin) { FactoryBot.create(:exhibit_admin, exhibit: exhibit) }

data/spec/features/exhibits/edit_metadata_fields_spec.rb

@@ -1,4 +1,3 @@
-
 describe 'Editing metadata fields', type: :feature do
   let(:exhibit) { FactoryBot.create(:exhibit) }
   let(:admin) { FactoryBot.create(:exhibit_admin, exhibit: exhibit) }

data/spec/features/exhibits/language_create_edit_spec.rb

@@ -5,6 +5,7 @@ describe 'Language', type: :feature do
     login_as admin
     visit spotlight.edit_exhibit_path(exhibit)
   end
+
   describe 'creation' do
     it 'successfully adds languages' do
       within '#language' do
@@ -18,6 +19,7 @@ describe 'Language', type: :feature do
       end
     end
   end
+
   describe 'making public' do
     it 'successfully updates the language' do
       within '#language' do
@@ -33,6 +35,7 @@ describe 'Language', type: :feature do
       expect(exhibit.languages.last).to be_public
     end
   end
+
   describe 'deleting' do
     it 'successfully updates the language' do
       within '#language' do

data/spec/features/exhibits/translation_editing_spec.rb

@@ -8,6 +8,7 @@ describe 'Translation editing', type: :feature do
     FactoryBot.create(:language, exhibit: exhibit, locale: 'fr')
     login_as admin
   end
+
   describe 'general' do
     before do
       visit spotlight.edit_exhibit_translations_path(exhibit, language: 'fr')
@@ -39,6 +40,7 @@ describe 'Translation editing', type: :feature do
         end
       end
     end
+
     describe 'main menu' do
       it 'adds translations to exhibit navbar' do
         within '.translation-edit-form #general' do
@@ -76,6 +78,7 @@ describe 'Translation editing', type: :feature do
           click_button 'Save changes'
         end
       end
+
       it 'adds translations to user-facing breadcrumbs' do
         expect(page).to have_css '.flash_messages', text: 'The exhibit was successfully updated.'
         visit spotlight.exhibit_browse_index_path(exhibit, locale: 'fr')
@@ -122,6 +125,7 @@ describe 'Translation editing', type: :feature do
             click_button 'Save changes'
           end
         end
+
         it 'adds breadcrumbs to pages' do
           visit spotlight.exhibit_about_page_path(about_page2.exhibit, about_page2, locale: 'fr')
           expect(page).to have_breadcrumbs 'Maison', 'Sur', about_page2.title
@@ -141,6 +145,7 @@ describe 'Translation editing', type: :feature do
             click_button 'Save changes'
           end
         end
+
         it 'adds breadcrumbs user facing catalog' do
           visit spotlight.search_exhibit_catalog_path(exhibit, q: '*', locale: 'fr')
           expect(page).to have_breadcrumbs 'Maison', 'Résultats de la recherche'
@@ -387,6 +392,7 @@ describe 'Translation editing', type: :feature do
     before do
       FactoryBot.create(:translation, exhibit: exhibit, locale: 'fr', key: "#{exhibit.slug}.title", value: 'Titre')
     end
+
     it 'counts existing and total available translations' do
       visit spotlight.edit_exhibit_translations_path(exhibit, language: 'fr')
       expect(page).to have_link('General 1/8')

data/spec/features/feature_page_spec.rb

@@ -32,6 +32,7 @@ describe 'Feature page', type: :feature, versioning: true do
     end
     describe 'when configured to display' do
       before { parent_feature_page.update display_sidebar: true }
+
       after { parent_feature_page.update display_sidebar: false }
 
       it 'is present' do
@@ -48,8 +49,10 @@ describe 'Feature page', type: :feature, versioning: true do
         end
       end
     end
+
     describe 'when configured to not display' do
       before { parent_feature_page.update display_sidebar: false }
+
       context 'with a child page' do
         it 'is present anyway' do
           visit spotlight.exhibit_feature_page_path(parent_feature_page.exhibit, parent_feature_page)
@@ -60,6 +63,7 @@ describe 'Feature page', type: :feature, versioning: true do
 
       context 'with an unpublished child page' do
         before { child_feature_page.update published: false }
+
         it 'does not be present' do
           visit spotlight.exhibit_feature_page_path(parent_feature_page.exhibit, parent_feature_page)
           expect(page).not_to have_css('#sidebar')
@@ -68,8 +72,10 @@ describe 'Feature page', type: :feature, versioning: true do
       end
     end
   end
+
   describe 'page options' do
     before { login_as exhibit_curator }
+
     describe 'publish' do
       let!(:unpublished_page) { FactoryBot.create(:feature_page, published: false, exhibit: exhibit) }
       it 'is updatable from the edit page' do
@@ -87,9 +93,11 @@ describe 'Feature page', type: :feature, versioning: true do
         expect(find('#feature_page_published')).to be_checked
       end
     end
+
     describe 'display_sidebar' do
       let!(:feature_page) { FactoryBot.create(:feature_page, display_sidebar: false, exhibit: exhibit) }
       before { feature_page.update display_sidebar: false }
+
       it 'is updatable from the edit page' do
         expect(feature_page.display_sidebar?).to be_falsey
 
@@ -109,6 +117,7 @@ describe 'Feature page', type: :feature, versioning: true do
 
   describe 'page locking' do
     before { login_as exhibit_curator }
+
     let!(:feature_page) { FactoryBot.create(:feature_page, display_sidebar: false, exhibit: exhibit) }
 
     it 'shows a lock message if someone is currently editing the page' do

data/spec/features/home_page_spec.rb

@@ -2,6 +2,7 @@ describe 'Home page', type: :feature, versioning: true do
   let(:exhibit) { FactoryBot.create(:exhibit) }
   let(:exhibit_curator) { FactoryBot.create(:exhibit_curator, exhibit: exhibit) }
   before { login_as exhibit_curator }
+
   it 'exists by default on exhibits' do
     visit spotlight.exhibit_dashboard_path(exhibit)
     click_link 'Feature pages'
@@ -79,6 +80,7 @@ describe 'Home page', type: :feature, versioning: true do
       exhibit.home_page.display_sidebar = false
       exhibit.home_page.save
     end
+
     it 'does not display the facet sidebar' do
       visit spotlight.exhibit_home_page_path(exhibit)
       expect(page).not_to have_css('#sidebar')

data/spec/features/javascript/blocks/featured_browse_categories_block_spec.rb

@@ -1,4 +1,3 @@
-
 describe 'Featured Browse Category Block', type: :feature, js: true do
   let(:exhibit) { FactoryBot.create(:exhibit) }
   let(:exhibit_curator) { FactoryBot.create(:exhibit_curator, exhibit: exhibit) }

data/spec/features/javascript/blocks/featured_pages_block_spec.rb

@@ -1,4 +1,3 @@
-
 describe 'Featured Pages Blocks', type: :feature, js: true do
   let(:exhibit) { FactoryBot.create(:exhibit) }
   let!(:feature_page1) do

data/spec/features/javascript/blocks/search_result_block_spec.rb

@@ -1,4 +1,3 @@
-
 describe 'Search Result Block', type: :feature, js: true do
   let(:exhibit) { FactoryBot.create(:exhibit) }
   let(:exhibit_curator) { FactoryBot.create(:exhibit_curator, exhibit: exhibit) }

data/spec/features/javascript/edit_in_place_spec.rb

@@ -2,6 +2,7 @@ describe 'Edit in place', type: :feature, js: true do
   let(:exhibit) { FactoryBot.create(:exhibit) }
   let(:admin) { FactoryBot.create(:exhibit_admin, exhibit: exhibit) }
   before { login_as admin }
+
   describe 'Feature Pages' do
     it 'updates the label' do
       visit spotlight.exhibit_dashboard_path(exhibit)
@@ -26,7 +27,34 @@ describe 'Edit in place', type: :feature, js: true do
       expect(page).to have_css('h3', text: 'My Newer Feature Page')
       expect(page).to_not have_css('h3', text: 'My New Feature Page')
     end
+
+    it 'rejects blank values' do
+      visit spotlight.exhibit_dashboard_path(exhibit)
+
+      click_link 'Feature pages'
+
+      add_new_page_via_button('My New Feature Page')
+
+      expect(page).to have_css('h3', text: 'My New Feature Page')
+
+      within('.feature_pages_admin') do
+        expect(page).to have_css('#exhibit_feature_pages_attributes_0_title[type="hidden"]', visible: false)
+        expect(page).not_to have_css('#exhibit_feature_pages_attributes_0_title[type="text"]')
+        click_link('My New Feature Page')
+        expect(page).not_to have_css('#exhibit_feature_pages_attributes_0_title[type="hidden"]')
+        expect(page).to have_css('#exhibit_feature_pages_attributes_0_title[type="text"]')
+        fill_in 'exhibit_feature_pages_attributes_0_title', with: ''
+        # blur out of the now-emptytitle field
+        field = page.find_field('exhibit_feature_pages_attributes_0_title')
+        field.native.send_keys :tab
+
+        expect(page).to have_css('#exhibit_feature_pages_attributes_0_title[type="hidden"]', visible: false)
+        expect(page).not_to have_css('#exhibit_feature_pages_attributes_0_title[type="text"]')
+        expect(page).to have_css('h3', text: 'My New Feature Page')
+      end
+    end
   end
+
   describe 'Main navigation' do
     it 'updates the label' do
       visit spotlight.exhibit_dashboard_path(exhibit)

data/spec/features/javascript/metadata_admin_spec.rb

@@ -2,6 +2,7 @@ feature 'Metadata Administration', js: true do
   let(:exhibit) { FactoryBot.create(:exhibit) }
   let(:admin) { FactoryBot.create(:exhibit_admin, exhibit: exhibit) }
   before { login_as admin }
+
   describe 'Select/Deselect all button' do
     it 'deselects all checkboxes when all are selected' do
       visit spotlight.edit_exhibit_metadata_configuration_path exhibit

data/spec/features/slideshow_spec.rb

@@ -6,6 +6,7 @@ describe 'Slideshow', type: :feature, js: true do
     login_as user
     exhibit.blacklight_configuration.update(document_index_view_types: %w(list gallery slideshow))
   end
+
   it 'has slideshow' do
     visit spotlight.search_exhibit_catalog_path(exhibit, f: { genre_ssim: ['map'] })
     expect(page).to have_content 'You searched for:'

data/spec/features/translation_scope_spec.rb

@@ -9,6 +9,7 @@ describe 'Translations scope setting', type: :feature do
       FactoryBot.create(:translation, exhibit: exhibit)
       FactoryBot.create(:translation, exhibit: other_exhibit)
     end
+
     it 'default scope of Translation should be limited to current exhibit' do
       visit spotlight.exhibit_path(exhibit)
       expect(Translation.all.count).to eq 1

data/spec/helpers/spotlight/application_helper_spec.rb

@@ -78,6 +78,7 @@ describe Spotlight::ApplicationHelper, type: :helper do
         expect(helper.selected_search_block_views(block)).to eq %w(a d)
       end
     end
+
     describe 'blacklight_view_config_for_search_block' do
       let(:sir_trevor_block) do
         SirTrevorRails::Block.new({ type: 'xyz', data: { view: %w(list gallery) } }, 'parent')
@@ -93,6 +94,7 @@ describe Spotlight::ApplicationHelper, type: :helper do
       before do
         allow(helper).to receive_messages(blacklight_config: config)
       end
+
       it 'returns a blacklight configuration object that has reduced the views to those that are configured in the block' do
         new_config = helper.blacklight_view_config_for_search_block(sir_trevor_block)
         expect(new_config.keys).to eq [:list, :gallery]
@@ -109,6 +111,7 @@ describe Spotlight::ApplicationHelper, type: :helper do
         config.index.display_type_field = :some_field
       end)
     end
+
     it 'returns blacklight-private when the document is private' do
       allow(document).to receive(:private?).with(current_exhibit).and_return(true)
       expect(helper.render_document_class(document)).to include 'blacklight-private'

data/spec/helpers/spotlight/languages_helper_spec.rb

@@ -63,6 +63,7 @@ describe Spotlight::LanguagesHelper, type: :helper do
         expect(helper.default_language?).to eq true
       end
     end
+
     context 'when using a different locale' do
       it do
         expect(helper).to receive_messages(params: { locale: :it })

data/spec/helpers/spotlight/main_app_helpers_spec.rb

@@ -1,4 +1,3 @@
-
 describe Spotlight::MainAppHelpers, type: :helper do
   describe '#show_contact_form?' do
     subject { helper }
@@ -14,29 +13,37 @@ describe Spotlight::MainAppHelpers, type: :helper do
           end
         end
       end
+
       before { allow(helper).to receive_messages current_exhibit: exhibit_with_contacts }
+
       its(:show_contact_form?) { should be_truthy }
     end
 
     context 'with an exhibit with only unconfirmed contacts' do
       before { exhibit_with_contacts.contact_emails.build email: 'cabeer@stanford.edu' }
+
       before { allow(helper).to receive_messages current_exhibit: exhibit_with_contacts }
+
       its(:show_contact_form?) { should be_falsey }
     end
 
     context 'with an exhibit without contacts' do
       before { allow(helper).to receive_messages current_exhibit: exhibit }
+
       its(:show_contact_form?) { should be_falsey }
     end
 
     context 'outside the context of an exhibit' do
       before { allow(helper).to receive_messages current_exhibit: nil }
+
       its(:show_contact_form?) { should be_falsey }
     end
 
     context 'with a default contact address' do
       before { allow(Spotlight::Engine.config).to receive_messages default_contact_email: 'root@localhost' }
+
       before { allow(helper).to receive_messages current_exhibit: exhibit }
+
       its(:show_contact_form?) { should be_truthy }
     end
   end

data/spec/helpers/spotlight/navbar_helper_spec.rb

@@ -4,6 +4,7 @@ describe Spotlight::NavbarHelper, type: :helper do
       allow(helper).to receive_messages(current_exhibit: nil)
       allow(helper).to receive_messages(exhibit_masthead?: true)
     end
+
     it 'returns false when there is no exhibit context' do
       expect(helper.should_render_spotlight_search_bar?).to be_falsey
     end

data/spec/helpers/spotlight/pages_helper_spec.rb

@@ -77,6 +77,7 @@ describe Spotlight::PagesHelper, type: :helper do
         expect(helper.nestable_data_attributes('something_else')).to eq ''
       end
     end
+
     describe 'nestable data attributes hash' do
       it 'returns the appropriate hash for feature pages' do
         expect(helper.nestable_data_attributes_hash('feature_pages')).to eq('data-max-depth' => '2',

data/spec/jobs/spotlight/default_thumbnail_job_spec.rb

@@ -1,4 +1,3 @@
-
 describe Spotlight::DefaultThumbnailJob do
   let(:thumbnailable) { double('Thumbnailable') }
   subject { described_class.new(thumbnailable) }

data/spec/jobs/spotlight/reindex_job_spec.rb

@@ -1,4 +1,3 @@
-
 describe Spotlight::ReindexJob do
   let(:exhibit) { FactoryBot.create(:exhibit) }
   let(:resource) { FactoryBot.create(:resource) }

data/spec/jobs/spotlight/rename_sidecar_field_job_spec.rb

@@ -1,4 +1,3 @@
-
 describe Spotlight::RenameSidecarFieldJob do
   include ActiveJob::TestHelper
 

data/spec/lib/migration/page_language_spec.rb

@@ -11,6 +11,7 @@ RSpec.describe Migration::PageLanguage do
       slug.save
       slug.reload
     end
+
     it 'sets the scope to the default locale' do
       expect(slug.scope).not_to include(',locale:en')
       subject.run

data/spec/lib/spotlight/controller_spec.rb

@@ -1,4 +1,3 @@
-
 describe Spotlight::Controller do
   class MockController < ActionController::Base
     include Spotlight::Controller
@@ -92,6 +91,7 @@ describe Spotlight::Controller do
     before do
       allow(subject).to receive(:current_exhibit).and_return(exhibit)
     end
+
     it 'adds the current exhibit context to the route' do
       expect(subject.spotlight).to receive(:facet_exhibit_catalog_url).with(exhibit, id: 'some_field', q: 'xyz')
       subject.exhibit_search_facet_url(id: 'some_field')