blacklight-spotlight 0.1.0 → 0.2.0

data/spec/models/spotlight/resources/csv_spec.rb

@@ -1,9 +1,9 @@
 require 'spec_helper'
 
-describe Spotlight::Resources::Csv do
+describe Spotlight::Resources::Csv, :type => :model do
   let(:exhibit) { FactoryGirl.create :exhibit }
   before do
-    Spotlight::SolrDocument.stub(visibility_field: 'public_bsi')
+    allow(Spotlight::SolrDocument).to receive_messages(visibility_field: 'public_bsi')
   end
 
   describe "#to_solr" do
@@ -19,8 +19,8 @@ describe Spotlight::Resources::Csv do
     end
 
     before do
-      subject.stub(csv: csv)
-      subject.stub(label_to_field: label_to_field)
+      allow(subject).to receive_messages(csv: csv)
+      allow(subject).to receive_messages(label_to_field: label_to_field)
     end
 
     it "should map csv headers to solr fields" do
@@ -45,7 +45,7 @@ describe Spotlight::Resources::Csv do
     end
 
     before do
-      subject.stub(exhibit: double(blacklight_config: blacklight_config))
+      allow(subject).to receive_messages(exhibit: double(blacklight_config: blacklight_config))
     end
     it "should include an id and title" do
       expect(subject.label_to_field).to include "id" => "id", "Title" => "my_title_field", "Public" => 'public_bsi'
@@ -62,8 +62,8 @@ describe Spotlight::Resources::Csv do
 
   describe "#csv" do
     it "should load the uploaded file as CSV" do
-      subject.stub(url: double(path: "/abc"))
-      File.should_receive(:open).with("/abc", "r").and_return(StringIO.new "a,b\n1,2")
+      allow(subject).to receive_messages(url: double(path: "/abc"))
+      expect(File).to receive(:open).with("/abc", "r").and_return(StringIO.new "a,b\n1,2")
       csv = subject.csv
       expect(csv).to be_a_kind_of CSV
       expect(csv).to have(1).row
@@ -84,7 +84,7 @@ describe Spotlight::Resources::Csv do
     end
 
     before do
-      subject.stub(reindex: true)
+      allow(subject).to receive_messages(reindex: true)
       subject.exhibit = exhibit
       subject.url = csv_data
     end

data/spec/models/spotlight/resources/open_graph_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe Spotlight::Resources::OpenGraph do
+describe Spotlight::Resources::OpenGraph, :type => :model do
   class TestResource < Spotlight::Resource
     include Spotlight::Resources::Web
     include Spotlight::Resources::OpenGraph
@@ -11,7 +11,7 @@ describe Spotlight::Resources::OpenGraph do
   describe "#to_solr" do
 
     before do
-      subject.stub id: 15, opengraph_properties: {}
+      allow(subject).to receive_messages id: 15, opengraph_properties: {}
     end
 
     let(:solr_doc) { subject.to_solr }
@@ -21,7 +21,7 @@ describe Spotlight::Resources::OpenGraph do
     end
 
     it "should include opengraph properties" do
-      subject.stub opengraph_properties: { a: 1, b: 2}
+      allow(subject).to receive_messages opengraph_properties: { a: 1, b: 2}
 
       expect(solr_doc).to include a: 1, b: 2
     end
@@ -30,7 +30,7 @@ describe Spotlight::Resources::OpenGraph do
 
   describe "#opengraph_properties" do
     it "should map opengraph properties to solr fields" do
-      subject.stub opengraph: { "og_title" => "title", "og_description" => "description"}
+      allow(subject).to receive_messages opengraph: { "og_title" => "title", "og_description" => "description"}
       expect(subject.opengraph_properties).to include "og_title_tesim" => "title", "og_description_tesim" => "description"
     end
   end
@@ -50,7 +50,7 @@ describe Spotlight::Resources::OpenGraph do
       EOF
     end
     it "should extract opengraph <meta> tags" do
-      subject.stub(body: body)
+      allow(subject).to receive_messages(body: body)
       expect(subject.opengraph).to include "og:title", "og:description", "og:type", "og:type", "og:site_name", "og:video", "og:video:width", "og:video:height"
       expect(subject.opengraph["og:title"]).to eq "The Ground Truth: The Human Cost of War"
     end

data/spec/models/spotlight/resources/upload_spec.rb

@@ -0,0 +1,57 @@
+require 'spec_helper'
+
+describe Spotlight::Resources::Upload, :type => :model do
+  let!(:exhibit) { FactoryGirl.create :exhibit }
+  let!(:custom_field) { FactoryGirl.create :custom_field, exhibit: exhibit }
+  before do
+    subject.exhibit = exhibit
+  end
+  describe '#to_solr' do
+    before do
+      subject.id = "1"
+      subject.data = {
+        title: "Title Data",
+        description: "Description Data",
+        attribution: "Attribution Data",
+        date: "Date Data",
+        custom_field.field => "Custom Field Data"
+      }
+      allow(subject).to receive(:url).and_return(stub_model(Spotlight::ItemUploader))
+      allow(subject.url.file).to receive(:file).and_return(File.expand_path(File.join('..', 'fixtures', '800x600.png'), Rails.root))
+      allow(subject.exhibit).to receive(:blacklight_config).and_return(
+        Blacklight::Configuration.new do |config|
+          config.index.title_field = :configured_title_field
+          config.index.full_image_field = :configured_full_image_field
+          config.index.thumbnail_field = :configured_thumbnail_field
+          config.index.square_image_field = :configured_square_field
+        end
+      )
+    end
+    it 'should have the exhibit id and the upload id as the solr id' do
+      expect(subject.to_solr[:id]).to eq "#{subject.exhibit.id}-#{subject.id}"
+    end
+    it 'should have a title field using the exhibit specific blacklight_config' do
+      expect(subject.to_solr[:configured_title_field]).to eq 'Title Data'
+    end
+    it 'should have the other additional configured fields' do
+      expect(subject.to_solr[Spotlight::Engine.config.uploaded_description_field]).to eq "Description Data"
+      expect(subject.to_solr[Spotlight::Engine.config.uploaded_attribution_field]).to eq "Attribution Data"
+      expect(subject.to_solr[Spotlight::Engine.config.uploaded_date_field]).to eq "Date Data"
+    end
+    it 'should have a spotlight_resource_type field' do
+      expect(subject.to_solr[:spotlight_resource_type_ssm]).to eq 'spotlight/resources/uploads'
+    end
+    it 'should have the various image fields' do
+      expect(subject.to_solr).to have_key :configured_full_image_field
+      expect(subject.to_solr).to have_key :configured_thumbnail_field
+      expect(subject.to_solr).to have_key :configured_square_field
+    end
+    it 'should have the full image dimensions fields' do
+      expect(subject.to_solr[:spotlight_full_image_height_ssm]).to eq 600
+      expect(subject.to_solr[:spotlight_full_image_width_ssm]).to eq 800
+    end
+    it 'should have fields representing exhibit specific custom fields' do
+      expect(subject.to_solr[custom_field.field]).to eq "Custom Field Data"
+    end
+  end
+end

data/spec/models/spotlight/resources/web_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe Spotlight::Resources::Web do
+describe Spotlight::Resources::Web, :type => :model do
 
   class TestResource < Spotlight::Resource
     include Spotlight::Resources::Web
@@ -13,7 +13,7 @@ describe Spotlight::Resources::Web do
 
   describe "#harvest!" do
     it "should cache the body and headers in the data" do
-      Spotlight::Resources::Web.stub(fetch: double(body: "xyz", headers: {a: 1}))
+      allow(Spotlight::Resources::Web).to receive_messages(fetch: double(body: "xyz", headers: {a: 1}))
       subject.harvest!
       expect(subject.data[:body]).to eq "xyz"
       expect(subject.data[:headers]).to eq a: 1
@@ -22,7 +22,7 @@ describe Spotlight::Resources::Web do
 
   describe "#body" do
     it "should return the body DOM" do
-      Spotlight::Resources::Web.stub(fetch: double(body: "<html />", headers: {a: 1}))
+      allow(Spotlight::Resources::Web).to receive_messages(fetch: double(body: "<html />", headers: {a: 1}))
       expect(subject.body).to be_a_kind_of(Nokogiri::HTML::Document)
     end
   end

data/spec/models/spotlight/role_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe Spotlight::Role do
+describe Spotlight::Role, :type => :model do
   describe "validations" do
     subject { Spotlight::Role.new(args) }
     describe "with nothing" do

data/spec/models/spotlight/search_spec.rb

@@ -1,32 +1,32 @@
 require 'spec_helper'
 
-describe Spotlight::Search do
+describe Spotlight::Search, :type => :model do
 
   before do
     subject.query_params = {"f"=>{"genre_sim"=>["map"]}}
     subject.exhibit = FactoryGirl.create(:exhibit)
   end
 
-  it { should be_a Spotlight::Catalog::AccessControlsEnforcement }
+  it { is_expected.to be_a Spotlight::Catalog::AccessControlsEnforcement }
 
   it "should have a default feature image" do
-    subject.stub(images: [['dq287tq6352', 'title', 'image_url']])
-    subject.stub(:featured_item_id).and_return("dq287tq6352")
+    allow(subject).to receive_messages(images: [['dq287tq6352', 'title', 'image_url']])
+    allow(subject).to receive(:featured_item_id).and_return("dq287tq6352")
     subject.save
     expect(subject.featured_image).to eq "https://stacks.stanford.edu/image/dq287tq6352/dq287tq6352_05_0001_thumb"
   end
 
   it "should handle blank and nil featured_image_ids" do
-    subject.stub(:featured_item_id).and_return("")
+    allow(subject).to receive(:featured_item_id).and_return("")
     subject.save
     expect(subject.featured_item).to be_nil
-    subject.stub(:featured_item_id).and_return(nil)
+    allow(subject).to receive(:featured_item_id).and_return(nil)
     subject.save
     expect(subject.featured_item).to be_nil
   end
 
   it "should #default_featured_iamge should not thrown an error when no images are present" do
-    subject.stub(images: nil)
+    allow(subject).to receive_messages(images: nil)
     expect(subject.default_featured_item_id).to be_nil
   end
 
@@ -35,7 +35,7 @@ describe Spotlight::Search do
   end
 
   it "should have images" do
-    subject.images.size.should == 55
+    expect(subject.images.size).to eq(55)
     expect(subject.images.map(&:last)).to include "https://stacks.stanford.edu/image/dq287tq6352/dq287tq6352_05_0001_thumb", "https://stacks.stanford.edu/image/jp266yb7109/jp266yb7109_05_0001_thumb"
   end
 

data/spec/models/spotlight/solr_document_atomic_updates_spec.rb

@@ -1,28 +1,28 @@
 require 'spec_helper'
 
-describe Spotlight::SolrDocument::AtomicUpdates do
+describe Spotlight::SolrDocument::AtomicUpdates, :type => :model do
   let(:blacklight_solr) { double }
   subject do
     ::SolrDocument.new.extend(Spotlight::SolrDocument::AtomicUpdates)
   end
 
   before do
-    subject.stub(blacklight_solr: blacklight_solr)
+    allow(subject).to receive_messages(blacklight_solr: blacklight_solr)
   end
 
   describe "#reindex" do
     before do
-      subject.stub(to_solr: { id: 'doc_id', a: 1, b: 2 })
+      allow(subject).to receive_messages(to_solr: { id: 'doc_id', a: 1, b: 2 })
     end
 
     it "should send an atomic update request" do
-      blacklight_solr.should_receive(:update).with(params: { commitWithin: 500 }, data: [{id: 'doc_id', a: { set: 1 }, b: { set: 2 }}].to_json, headers: { 'Content-Type' => 'application/json'})
+      expect(blacklight_solr).to receive(:update).with(params: { commitWithin: 500 }, data: [{id: 'doc_id', a: { set: 1 }, b: { set: 2 }}].to_json, headers: { 'Content-Type' => 'application/json'})
       subject.reindex
     end
 
     it "should cowardly refuse to index a document if the only value is an id" do
-      subject.stub(to_solr: { id: 'doc_id' })
-      blacklight_solr.should_not_receive(:update)
+      allow(subject).to receive_messages(to_solr: { id: 'doc_id' })
+      expect(blacklight_solr).not_to receive(:update)
       subject.reindex
     end
   end

data/spec/models/spotlight/solr_document_sidecar_spec.rb

@@ -1,10 +1,10 @@
 require 'spec_helper'
 
-describe Spotlight::SolrDocumentSidecar do
+describe Spotlight::SolrDocumentSidecar, :type => :model do
   let(:exhibit) { FactoryGirl.create(:exhibit) }
   before do
-    subject.stub exhibit: exhibit
-    subject.stub solr_document_id: 'doc_id'
+    allow(subject).to receive_messages exhibit: exhibit
+    allow(subject).to receive_messages solr_document_id: 'doc_id'
   end
 
   describe "#to_solr" do

data/spec/models/spotlight/solr_document_uploaded_resource_spec.rb

@@ -0,0 +1,48 @@
+require 'spec_helper'
+
+describe Spotlight::SolrDocument::UploadedResource, :type => :model do
+  let(:valid_resource) { ::SolrDocument.new(id: '123', full_image_url_ssm: ["http://example.com/png.png"], spotlight_full_image_height_ssm: ["1400"], spotlight_full_image_width_ssm: ["1000"], spotlight_resource_type_ssm: ["spotlight/resources/uploads"]) }
+  describe 'SolrDocument.use_extension' do
+    it 'should not include the uploaded resource extension when there is no full image field' do
+      expect(::SolrDocument.new(id: '123', spotlight_resource_type_ssm: ["spotlight/resources/uploads"])).to_not be_a_kind_of(Spotlight::SolrDocument::UploadedResource)
+    end
+    it 'should not include the uploaded resource extension when the spotlight resource type is not correct' do
+      expect(::SolrDocument.new(id: '123', full_image_url_ssm: ["http://example.com/png.png"], spotlight_resource_type_ssm: ["not-correct"])).to_not be_a_kind_of(Spotlight::SolrDocument::UploadedResource)
+    end
+    it 'should include the uploaded resource extension when the correct fields are present with the correct data' do
+      expect(valid_resource).to be_a_kind_of(Spotlight::SolrDocument::UploadedResource)
+    end
+  end
+  describe 'to_openseadragon' do
+    let(:subject) { valid_resource.to_openseadragon }
+    it 'should include hashes for each full_image_url_ssm' do
+      expect(subject).to be_an Array
+      expect(subject.length).to eq 1
+      expect(subject.first.keys.length).to eq 1
+    end
+    it 'the hashes key should be a LegacyImagePyramidTileSource object' do
+      expect(subject.first.keys.first).to be_a(Spotlight::SolrDocument::UploadedResource::LegacyImagePyramidTileSource)
+    end
+    describe 'LegacyImagePyramidTileSource' do
+      let(:subject) { valid_resource.to_openseadragon.first.keys.first.to_tilesource }
+      it 'should be a hash' do
+        expect(subject).to be_a Hash
+      end
+      it 'should be a legacy image pyramid type' do
+        expect(subject[:type]).to eq 'legacy-image-pyramid'
+      end
+      describe 'levels' do
+        it 'should include one level' do
+          expect(subject[:levels].length).to eq 1
+        end
+        it 'should include the image url' do
+          expect(subject[:levels].first[:url]).to eq "http://example.com/png.png"
+        end
+        it 'should include the height and width from the document' do
+          expect(subject[:levels].first[:height]).to eq "1400"
+          expect(subject[:levels].first[:width]).to eq "1000"
+        end
+      end
+    end
+  end
+end

data/spec/routing/spotlight/exhibit_catalog_spec.rb

@@ -1,12 +1,12 @@
 require "spec_helper"
 
 module Spotlight
-  describe "Catalog controller" do
+  describe "Catalog controller", :type => :routing do
     describe "routing" do
       routes { Spotlight::Engine.routes }
 
       it "routes to #edit" do
-        get("/1/catalog/dq287tq6352/edit").should route_to("spotlight/catalog#edit", exhibit_id: '1', id: 'dq287tq6352')
+        expect(get("/1/catalog/dq287tq6352/edit")).to route_to("spotlight/catalog#edit", exhibit_id: '1', id: 'dq287tq6352')
       end
     end
   end

data/spec/routing/spotlight/pages_routing_spec.rb

@@ -1,43 +1,43 @@
 require "spec_helper"
 
 module Spotlight
-  describe "FeaturePagesController and AboutPagesController" do
+  describe "FeaturePagesController and AboutPagesController", :type => :routing do
     describe "routing" do
       routes { Spotlight::Engine.routes }
 
       it "routes to #index" do
-        get("/1/feature").should route_to("spotlight/feature_pages#index", exhibit_id: '1')
-        get("/1/about").should   route_to("spotlight/about_pages#index",   exhibit_id: '1')
+        expect(get("/1/feature")).to route_to("spotlight/feature_pages#index", exhibit_id: '1')
+        expect(get("/1/about")).to   route_to("spotlight/about_pages#index",   exhibit_id: '1')
       end
 
       it "routes to #new" do
-        get("/1/feature/new").should route_to("spotlight/feature_pages#new", exhibit_id: '1')
-        get("/1/about/new").should   route_to("spotlight/about_pages#new",   exhibit_id: '1')
+        expect(get("/1/feature/new")).to route_to("spotlight/feature_pages#new", exhibit_id: '1')
+        expect(get("/1/about/new")).to   route_to("spotlight/about_pages#new",   exhibit_id: '1')
       end
 
       it "routes to #show" do
-        get("/1/feature/2").should route_to("spotlight/feature_pages#show", id: "2", exhibit_id: "1")
-        get("/1/about/2").should   route_to("spotlight/about_pages#show",   id: "2", exhibit_id: "1")
+        expect(get("/1/feature/2")).to route_to("spotlight/feature_pages#show", id: "2", exhibit_id: "1")
+        expect(get("/1/about/2")).to   route_to("spotlight/about_pages#show",   id: "2", exhibit_id: "1")
       end
 
       it "routes to #edit" do
-        get("/1/feature/2/edit").should route_to("spotlight/feature_pages#edit", id: "2", exhibit_id: "1")
-        get("/1/about/2/edit").should   route_to("spotlight/about_pages#edit",   id: "2", exhibit_id: "1")
+        expect(get("/1/feature/2/edit")).to route_to("spotlight/feature_pages#edit", id: "2", exhibit_id: "1")
+        expect(get("/1/about/2/edit")).to   route_to("spotlight/about_pages#edit",   id: "2", exhibit_id: "1")
       end
 
       it "routes to #create" do
-        post("/1/feature").should route_to("spotlight/feature_pages#create", exhibit_id: '1')
-        post("/1/about").should   route_to("spotlight/about_pages#create",   exhibit_id: '1')
+        expect(post("/1/feature")).to route_to("spotlight/feature_pages#create", exhibit_id: '1')
+        expect(post("/1/about")).to   route_to("spotlight/about_pages#create",   exhibit_id: '1')
       end
 
       it "routes to #update" do
-        put("/1/feature/2").should route_to("spotlight/feature_pages#update", id: "2", exhibit_id: "1")
-        put("/1/about/2").should   route_to("spotlight/about_pages#update",   id: "2", exhibit_id: "1")
+        expect(put("/1/feature/2")).to route_to("spotlight/feature_pages#update", id: "2", exhibit_id: "1")
+        expect(put("/1/about/2")).to   route_to("spotlight/about_pages#update",   id: "2", exhibit_id: "1")
       end
 
       it "routes to #destroy" do
-        delete("/1/feature/2").should route_to("spotlight/feature_pages#destroy", id: "2", exhibit_id: "1")
-        delete("/1/about/2").should   route_to("spotlight/about_pages#destroy",   id: "2", exhibit_id: "1")
+        expect(delete("/1/feature/2")).to route_to("spotlight/feature_pages#destroy", id: "2", exhibit_id: "1")
+        expect(delete("/1/about/2")).to   route_to("spotlight/about_pages#destroy",   id: "2", exhibit_id: "1")
       end
 
     end

data/spec/serializers/spotlight/exhibit_export_serializer_spec.rb

@@ -9,6 +9,7 @@ describe Spotlight::ExhibitExportSerializer do
     expect(subject).to_not have_key 'id'
     expect(subject).to_not have_key 'slug'
     expect(subject).to_not have_key 'name'
+    expect(subject).to_not have_key 'default'
   end
 
   it "should have search attributes" do
@@ -59,4 +60,13 @@ describe Spotlight::ExhibitExportSerializer do
     expect(subject["attachments_attributes"]).to have(source_exhibit.attachments.count).items
   end
 
+  it "should have resources" do
+    expect(subject["resources_attributes"]).to have(source_exhibit.resources.count).items
+  end
+
+  it "should have tags" do
+    source_exhibit.tag(SolrDocument.new(id: 1), with: "xyz", on: :tags)
+    expect(subject["owned_taggings_attributes"]).to have(source_exhibit.owned_taggings.count).items
+  end
+
 end

data/spec/spec_helper.rb

@@ -10,10 +10,11 @@ require 'rspec/collection_matchers'
 require 'rspec/its'
 require 'rspec/rails'
 require 'rspec/active_model/mocks'
-require 'rspec/autorun'
+
 require 'capybara/poltergeist'
 Capybara.javascript_driver = :poltergeist
-Capybara.default_wait_time = 5
+Capybara.default_wait_time = 10
+
 
 if ENV["COVERAGE"] or ENV["CI"]
   require 'simplecov'
@@ -33,6 +34,8 @@ Dir["./spec/support/**/*.rb"].sort.each {|f| require f}
 FactoryGirl.definition_file_paths = [File.expand_path("../factories", __FILE__)]
 FactoryGirl.find_definitions
 
+FIXTURES_PATH = File.expand_path("../fixtures", __FILE__);
+
 
 RSpec.configure do |config|
   config.infer_spec_type_from_file_location!
@@ -46,6 +49,9 @@ RSpec.configure do |config|
       DatabaseCleaner.strategy = :truncation
     end
     DatabaseCleaner.start
+
+    # The first user is automatically granted admin privileges; we don't want that behavior for many of our tests
+    User.create email: 'initial+admin@example.com', password: 'password', password_confirmation: 'password'
   end
 
   config.after do