blacklight-oembed 1.0.1 → 1.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d61aec782640e66703f01c71dfcf3e7fd88445498ba35cc0edb1d69b6c2ca1c6
-  data.tar.gz: 83f98a2143e5b2461fc0dbd057a7719c59053b758eae8e78b5d0f792d66191f2
+  metadata.gz: 5305c4c047c7deeee34c98b2d3197e69d584a6ca7308cb0d80ebebf81d666b9d
+  data.tar.gz: 695d6b4f7dce7c1b516f54653332f9c8b5bbe295c6151eff90be47da2f368fdf
 SHA512:
-  metadata.gz: d945fc6e2b2f3802559876266251c908c8f6fc77e477952f6ba98179b84696295396cc34774bf6d4a50f253954519be973cca580f1d8575ebb8f8986c7c733af
-  data.tar.gz: 4e5382c7b4f9ae02b32a974a4999058a8884494e89634d99bc093f5f07b84b5c8507fca3eb1eb2a4a80c5ece241ec58cc15e2e0dcf25f035fb9c1cbfe6fb165c
+  metadata.gz: 044130e650ac8243abe3f5390d1bdd7b93f94130ecc0a17b1504a071738c8ffbaf6f9cb9979c6e8ec114da60b38d5a657c819c9e536f0af5acb8538e1a09f6b4
+  data.tar.gz: de08d089681ea0fdec9f7446ba702f8f63b32c9e6758fa9f1446cbdb660ffc029abf17fd053e1f4e535036f90776655270e1b8cb00622051f92c18373e4d40c4

data/.github/workflows/ruby.yml

@@ -0,0 +1,35 @@
+name: CI
+
+on:
+  push:
+    branches: [ main ]
+  pull_request:
+    branches: [ main ]
+
+jobs:
+  test:
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        ruby: [2.7, '3.0']
+        rails_version: ['6.1.7', '7.0.4']
+        blacklight_version: ['~> 7.0']
+        include:
+        - ruby: '3.1'
+          rails_version: '7.0.4'
+        - ruby: '3.1'
+          rails_version: '7.0.4'
+          blacklight_version: 'github'
+    env:
+      RAILS_VERSION: ${{ matrix.rails_version }}
+      BLACKLIGHT_VERSION: ${{ matrix.blacklight_version }}
+    steps:
+    - uses: actions/checkout@v2
+    - name: Set up Ruby ${{ matrix.ruby }}
+      uses: ruby/setup-ruby@v1
+      with:
+        ruby-version: ${{ matrix.ruby }}
+    - name: Install dependencies with Rails ${{ matrix.rails_version }}
+      run: bundle install
+    - name: Run tests
+      run: bundle exec rake

data/app/controllers/blacklight/oembed/embed_controller.rb

@@ -7,9 +7,9 @@ module Blacklight::Oembed
 
     private
 
-    def get_embed_content(url, add_params)
+    ruby2_keywords def get_embed_content(url, add_params = {})
       begin
-        OEmbed::Providers.get(url, **add_params.transform_values { |v| URI.encode(v) }).html.html_safe
+        OEmbed::Providers.get(url, add_params.transform_values { |v| CGI.escape(v) }).html.html_safe
       rescue OEmbed::NotFound
         response.status = 400
         ""

data/blacklight-oembed.gemspec

@@ -18,12 +18,12 @@ Gem::Specification.new do |spec|
   spec.require_paths = ["lib"]
 
   spec.add_dependency "rails"
-  spec.add_dependency 'blacklight', '~> 7.0'
+  spec.add_dependency 'blacklight', '>= 7.0', '< 9'
   spec.add_dependency "ruby-oembed"
 
   spec.add_development_dependency "bundler", ">= 1.5"
   spec.add_development_dependency "rake"
-  spec.add_development_dependency "rspec-rails", "~> 3.1"
+  spec.add_development_dependency "rspec-rails", "~> 6"
   spec.add_development_dependency "rspec-its"
   spec.add_development_dependency "rspec-activemodel-mocks"
   spec.add_development_dependency "rspec-collection_matchers"

data/lib/blacklight/oembed/version.rb

@@ -1,5 +1,5 @@
 module Blacklight
   module Oembed
-    VERSION = '1.0.1'
+    VERSION = '1.1.1'
   end
 end

data/solr/conf/solrconfig.xml

@@ -18,6 +18,7 @@
 
   <!-- solr lib dirs -->
   <lib dir="${solr.install.dir:../../../..}/contrib/analysis-extras/lib" />
+  <lib dir="${solr.install.dir:../../../..}/modules/analysis-extras/lib" />
   <lib dir="${solr.install.dir:../../../..}/contrib/analysis-extras/lucene-libs" />
 
   <dataDir>${solr.data.dir:}</dataDir>

data/spec/controllers/embed_controller_spec.rb

@@ -30,13 +30,13 @@ describe Blacklight::Oembed::EmbedController do
     end
 
     it 'passes along configured additional keys' do
-      allow(OEmbed::Providers).to receive(:get).with('http://some/uri', canvas_index: '5').and_return oembed_obj
+      allow(OEmbed::Providers).to receive(:get).with('http://some/uri', { canvas_index: '5' }).and_return oembed_obj
       get :show, params: { url: 'http://some/uri', canvas_index: '5' }
       expect(response.status).to eq 200
     end
 
     it 'URI encodes data from additional keys' do
-      allow(OEmbed::Providers).to receive(:get).with('http://some/uri', suggested_search: 'ep%C3%A9e').and_return oembed_obj
+      allow(OEmbed::Providers).to receive(:get).with('http://some/uri', { suggested_search: 'ep%C3%A9e' }).and_return oembed_obj
       get :show, params: { url: 'http://some/uri', suggested_search: 'epée' }
       expect(response.status).to eq 200
     end

data/spec/test_app_templates/Gemfile.extra

@@ -0,0 +1,5 @@
+if ENV['BLACKLIGHT_VERSION'] == 'github'
+  gem 'blacklight', github: 'projectblacklight/blacklight'
+elsif ENV['BLACKLIGHT_VERSION'] && !ENV['BLACKLIGHT_VERSION'].empty?
+  gem 'blacklight', ENV['BLACKLIGHT_VERSION']
+end

data/spec/test_app_templates/lib/generators/test_app_generator.rb

@@ -3,15 +3,21 @@ require 'rails/generators'
 class TestAppGenerator < Rails::Generators::Base
   source_root File.expand_path("../../../../test_app_templates", __FILE__)
 
-  def remove_index 
+  def remove_index
     remove_file "public/index.html"
   end
 
   def run_blacklight_generator
-    say_status("warning", "GENERATING BL", :yellow)       
+    say_status("warning", "GENERATING BL", :yellow)
+
+    if ENV['BLACKLIGHT_VERSION'] == 'github'
+      gem 'blacklight', github: 'projectblacklight/blacklight'
+    elsif ENV['BLACKLIGHT_VERSION'].present?
+      gem 'blacklight', ENV['BLACKLIGHT_VERSION']
+    end
 
     Bundler.with_clean_env do
-      run "bundle install"
+      run "bundle update"
     end
 
     generate 'blacklight:install'
@@ -21,4 +27,4 @@ class TestAppGenerator < Rails::Generators::Base
     generate 'blacklight_oembed:install'
   end
 
-end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: blacklight-oembed
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.1.1
 platform: ruby
 authors:
 - Chris Beer
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-05-21 00:00:00.000000000 Z
+date: 2022-12-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -28,16 +28,22 @@ dependencies:
   name: blacklight
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '7.0'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '9'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '7.0'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '9'
 - !ruby/object:Gem::Dependency
   name: ruby-oembed
   requirement: !ruby/object:Gem::Requirement
@@ -86,14 +92,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.1'
+        version: '6'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.1'
+        version: '6'
 - !ruby/object:Gem::Dependency
   name: rspec-its
   requirement: !ruby/object:Gem::Requirement
@@ -192,15 +198,15 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: 1.5.0
-description: 
+description:
 email:
 - cabeer@stanford.edu
 executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/workflows/ruby.yml"
 - ".gitignore"
-- ".travis.yml"
 - Gemfile
 - LICENSE
 - README.md
@@ -247,7 +253,7 @@ homepage: https://github.com/sul-dlss/blacklight-oembed
 licenses:
 - Apache 2.0
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -262,8 +268,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.2
-signing_key: 
+rubygems_version: 3.3.7
+signing_key:
 specification_version: 4
 summary: Oembed display for Blacklight
 test_files:

data/.travis.yml

@@ -1,10 +0,0 @@
-notifications:
-  email: false
-
-rvm:
-  - 2.6.3
-
-env:
-  global:
-    - NOKOGIRI_USE_SYSTEM_LIBRARIES=true
-    - RAILS_VERSION=5.2.3