blacklight-oembed 0.2.0 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: c83a7f422815420859e82c0093226852c3b5a64e
-  data.tar.gz: ae6b4939e1e3b0c014b035790e3900da36c79c16
+SHA256:
+  metadata.gz: 4fe96157b6f6dd72911293afced519e74b4c39e7188f79c2c12834364f4e5b18
+  data.tar.gz: d6ee6dbba7baa58134947c201f216246b23e197fd78573f6705df9e3608675c3
 SHA512:
-  metadata.gz: 54cdaa19c1360b734d11095331ddf6a6b80016caeba9a87c6e2fa85ba4450a3cd3728d16ee41bc414ef7e4b8d4c5479aabb38d46fbeca8f7db7a0e395e531824
-  data.tar.gz: 2f06ae881e04618a07ccaeb41b455be3f4b729bb60c38ea9fe5125db24ab9172c9771db71937027ff417fbf9e5622115c3a34d0ba086171cbfb652bedc26c316
+  metadata.gz: af4c4475ee693b7e3a111137c46bfc38caa484f00bb25e3cf3e1e2a18a47e286c9943fa40f43a786d739241231b7c2210d01feb20af8b2e9c243d904d1a889a3
+  data.tar.gz: 207f064e2d30c1fd00d156c10b26387e32f0736e599c17e52a7100aec31b30727fd5969686e93157062ba25c59756ff54291703052612bc350c286777a7ebb57

data/.travis.yml

@@ -2,7 +2,7 @@ notifications:
   email: false
 
 rvm:
-  - 2.4.2
+  - 2.5.3
 
 env:
   global:

data/app/controllers/blacklight/oembed/embed_controller.rb

@@ -9,7 +9,7 @@ module Blacklight::Oembed
 
     def get_embed_content(url, add_params)
       begin
-        OEmbed::Providers.get(url, **add_params).html.html_safe
+        OEmbed::Providers.get(url, **add_params.transform_values { |v| URI.encode(v) }).html.html_safe
       rescue OEmbed::NotFound
         response.status = 400
         ""

data/blacklight-oembed.gemspec

@@ -22,14 +22,14 @@ Gem::Specification.new do |spec|
   spec.add_dependency "bootstrap-sass", "~> 3.0"
   spec.add_dependency "ruby-oembed"
 
-  spec.add_development_dependency "bundler", "~> 1.5"
+  spec.add_development_dependency "bundler", ">= 1.5"
   spec.add_development_dependency "rake"
   spec.add_development_dependency "rspec-rails", "~> 3.1"
   spec.add_development_dependency "rspec-its"
   spec.add_development_dependency "rspec-activemodel-mocks"
   spec.add_development_dependency "rspec-collection_matchers"
   spec.add_development_dependency "solr_wrapper"
-  spec.add_development_dependency "engine_cart", "~> 0.8"
+  spec.add_development_dependency "engine_cart", "~> 2.0"
   spec.add_development_dependency "capybara"
   spec.add_development_dependency "poltergeist", ">= 1.5.0"
 end

data/lib/blacklight/oembed/version.rb

@@ -1,5 +1,5 @@
 module Blacklight
   module Oembed
-    VERSION = '0.2.0'
+    VERSION = '0.3.0'
   end
 end

data/solr/conf/schema.xml

@@ -308,7 +308,6 @@
       <analyzer>
         <tokenizer class="solr.StandardTokenizerFactory"/>
         <filter class="solr.StopFilterFactory" ignoreCase="true" words="stopwords.txt"/>
-        <filter class="solr.StandardFilterFactory"/>
         <filter class="solr.LowerCaseFilterFactory"/>
         <filter class="solr.RemoveDuplicatesTokenFilterFactory"/>
       </analyzer>
@@ -317,7 +316,6 @@
     <fieldType class="solr.TextField" name="textSuggest" positionIncrementGap="100">
        <analyzer>
           <tokenizer class="solr.KeywordTokenizerFactory"/>
-          <filter class="solr.StandardFilterFactory"/>
           <filter class="solr.LowerCaseFilterFactory"/>
           <filter class="solr.RemoveDuplicatesTokenFilterFactory"/>
        </analyzer>

data/spec/controllers/embed_controller_spec.rb

@@ -8,7 +8,7 @@ describe Blacklight::Oembed::EmbedController do
 
     before do
       Blacklight::Oembed::Engine.config.render_helper = :render_oembed_tag_embed
-      Blacklight::Oembed::Engine.config.additional_params = [:canvas_index]
+      Blacklight::Oembed::Engine.config.additional_params = [:canvas_index, :suggested_search]
     end
 
     let :oembed_obj do
@@ -34,5 +34,11 @@ describe Blacklight::Oembed::EmbedController do
       get :show, params: { url: 'http://some/uri', canvas_index: '5' }
       expect(response.status).to eq 200
     end
+
+    it 'URI encodes data from additional keys' do
+      allow(OEmbed::Providers).to receive(:get).with('http://some/uri', suggested_search: 'ep%C3%A9e').and_return oembed_obj
+      get :show, params: { url: 'http://some/uri', suggested_search: 'epée' }
+      expect(response.status).to eq 200
+    end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: blacklight-oembed
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.3.0
 platform: ruby
 authors:
 - Chris Beer
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-12-05 00:00:00.000000000 Z
+date: 2019-07-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -76,14 +76,14 @@ dependencies:
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '1.5'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '1.5'
 - !ruby/object:Gem::Dependency
@@ -176,14 +176,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.8'
+        version: '2.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.8'
+        version: '2.0'
 - !ruby/object:Gem::Dependency
   name: capybara
   requirement: !ruby/object:Gem::Requirement
@@ -280,8 +280,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.6.14
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: Oembed display for Blacklight