blacklight-marc 8.1.1 → 8.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 483538c623aaace602da20c35e7b3fc349ac18e06ffe4277ac9a14f14eff237e
-  data.tar.gz: cfbc11131199f2895db722e609a23dfa4cec8be8e27781f542076931988aaf5c
+  metadata.gz: 892b3e164a4e741d7cefba50dfc8a2193edf2b0a7bc66adf05a5c4e58e1c482e
+  data.tar.gz: cf42c3ae6f2e43c46a2d111d2f057f31cfae5a7c21df216744a83230ef0b588c
 SHA512:
-  metadata.gz: bc6f9437f9c3a53fe810cf7f1fe1a831e7d6c1de22e9ab04927a0702163e4ef474c4868f322ce8bf2374a4a36fd4354a748a26788001e73b46bbe7dd8e85fe9d
-  data.tar.gz: 41943dec1aef4930cfb7ee783dadb6ba63d097882486547f292bb14c2e1f088685f17080a60483f2f08080878ebd61020d48a4ca739a1d0b247ee6f00ad270e6
+  metadata.gz: 610b71ad440c2bef34899c5d1463b1de5559e169dc0d620948852dd0d54ed1c99213cfdabcf21616b94c95c9b0a0206a92f231ae6df31eb6c85b1f4b03ba68a3
+  data.tar.gz: 46c85f6dc456b7151a06d800c3a841246e5e46b0acc705e0201b307fbf77121a8926ee1a9df60435c0f21d0d489d4749937fa61def7daccbe4764c57c9c8dd27

data/Gemfile

@@ -9,8 +9,8 @@ end
 gemspec path: File.expand_path('..', __FILE__)
 
 # BEGIN ENGINE_CART BLOCK
-# engine_cart: 1.0.1
-# engine_cart stanza: 0.10.0
+# engine_cart: 2.6.0
+# engine_cart stanza: 2.5.0
 # the below comes from engine_cart, a gem used to test this Rails engine gem in the context of a Rails app.
 file = File.expand_path('Gemfile', ENV['ENGINE_CART_DESTINATION'] || ENV['RAILS_ROOT'] || File.expand_path('.internal_test_app', File.dirname(__FILE__)))
 if File.exist?(file)
@@ -30,20 +30,16 @@ else
     else
       gem 'rails', ENV['RAILS_VERSION']
     end
-  end
 
-  case ENV['RAILS_VERSION']
-  when /^6.0/
-    gem 'sass-rails', '>= 6'
-    gem 'webpacker', '~> 4.0'
-  when /^5.[12]/
-    gem 'sass-rails', '~> 5.0'
-  when /^4.2/
-    gem 'responders', '~> 2.0'
-    gem 'sass-rails', '>= 5.0'
-    gem 'coffee-rails', '~> 4.1.0'
-  when /^4.[01]/
-    gem 'sass-rails', '< 5.0'
+    case ENV['RAILS_VERSION']
+    when /^6.0/
+      gem 'sass-rails', '>= 6'
+      gem 'webpacker', '~> 4.0'
+    when /^5.[12]/
+      gem 'sass-rails', '~> 5.0'
+      gem 'sprockets', '~> 3.7'
+      gem 'thor', '~> 0.20'
+    end
   end
 end
 # END ENGINE_CART BLOCK

data/app/helpers/blacklight_marc_helper.rb

@@ -1,8 +1,6 @@
 module BlacklightMarcHelper
-
-  # This method should move to BlacklightMarc in Blacklight 6.x
   def refworks_export_url params = {}, *_
-    "http://www.refworks.com/express/expressimport.asp?vendor=#{CGI.escape(params[:vendor] || application_name)}&filter=#{CGI.escape(params[:filter] || "MARC Format")}&encoding=65001" + (("&url=#{CGI.escape(params[:url])}" if params[:url]) || "")
+    "https://www.refworks.com/express/expressimport.asp?vendor=#{CGI.escape(params[:vendor] || application_name)}&filter=#{CGI.escape(params[:filter] || "MARC Format")}&encoding=65001" + (("&url=#{CGI.escape(params[:url])}" if params[:url]) || "")
   end
 
   def refworks_solr_document_path opts = {}, *_

data/app/models/concerns/blacklight/marc/document_export.rb

@@ -561,6 +561,7 @@ module Blacklight::Marc::DocumentExport
 
   def abbreviate_name(name)
     name_parts = name.split(", ")
+    return "" if name_parts.empty?
     first_name_parts = name_parts.last.split(" ")
     temp_name = name_parts.first + ", " + first_name_parts.first[0,1] + "."
     first_name_parts.shift
@@ -570,7 +571,7 @@ module Blacklight::Marc::DocumentExport
 
   def name_reverse(name)
     name = clean_end_punctuation(name)
-    return name unless name =~ /,/
+    return name if name == ", " || !(name =~ /,/)
     temp_name = name.split(", ")
     return temp_name.last + " " + temp_name.first
   end

data/lib/blacklight/marc/version.rb

@@ -1,5 +1,5 @@
 module Blacklight
   module Marc
-    VERSION = '8.1.1'
+    VERSION = '8.1.3'
   end
 end

data/spec/models/concerns/blacklight/marc/document_export_spec.rb

@@ -26,6 +26,19 @@ class MockClass264
   end
 end
 
+class MockClassInvalid700
+  include Blacklight::Marc::DocumentExport
+
+  def to_marc
+    fields = [
+      { "100" => { "subfields" => [{ "a" => "Borja, Ronaldo I." }]}},
+      { "245" => { "ind1" => " ", "ind2" => " ", "subfields" => [{ "a" => "Plasticity : ", "b" => "modeling & computation /", "c" => "Ronaldo I. Borja." }] } },
+      { "700" => { "ind1" => " ", "ind2" => " ", "subfields" => [{ "a" => ", ." }] } }
+    ]
+    MARC::Record.new_from_hash('fields' => fields)
+  end
+end
+
 RSpec.describe Blacklight::Marc::DocumentExport do
   describe 'export citiations from 260 field' do
     it 'exports citations in apa format' do
@@ -60,4 +73,21 @@ RSpec.describe Blacklight::Marc::DocumentExport do
       expect(MockClass264.new.export_as_chicago_citation_txt).to include('Berlin: Springer,')
     end
   end
+
+  describe 'when the 700 only has punctuation and spaces' do
+    it 'exports citations in apa format' do
+      expect(MockClassInvalid700.new.export_as_apa_citation_txt).to include('Borja, R. I')
+      expect(MockClassInvalid700.new.export_as_apa_citation_txt).to include('Plasticity')
+    end
+
+    it 'exports citations in mla format' do
+      expect(MockClassInvalid700.new.export_as_mla_citation_txt).to include('Borja, Ronaldo I')
+      expect(MockClassInvalid700.new.export_as_mla_citation_txt).to include('Plasticity')
+    end
+
+    it 'exports citations in Chicago format' do
+      expect(MockClassInvalid700.new.export_as_chicago_citation_txt).to include('Borja, Ronaldo I')
+      expect(MockClassInvalid700.new.export_as_chicago_citation_txt).to include('Plasticity')
+    end
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: blacklight-marc
 version: !ruby/object:Gem::Version
-  version: 8.1.1
+  version: 8.1.3
 platform: ruby
 authors:
 - Justin Coyne
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2024-02-05 00:00:00.000000000 Z
+date: 2024-03-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: blacklight
@@ -331,7 +331,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.5.4
+rubygems_version: 3.5.6
 signing_key:
 specification_version: 4
 summary: MARC support for Blacklight