blacklight-gallery 3.4.0 → 4.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2c352955a6ff3422f81258dd566cfe58114da0c93f65241e70ae093ee3a76dfb
-  data.tar.gz: 58707632ea6223e59985771c6cb79f5cfa3a2e410e44cb5f02a631ed24f2c7be
+  metadata.gz: 67559224cded645a3d4cdcbacf6d2ee5caa94d6168ebf320e15c317eac00cac6
+  data.tar.gz: 34f56fb978b1db760dc813fc85e5b99cae783b872924824bddeffeccdc09827a
 SHA512:
-  metadata.gz: b3220d3e51e3a178532a61678631b3d4dba3b0d38042a0bc4b9a62e447daefce4afa3833b4d2d0cce41442088af8004b4791e1e54e2bd42f2dfdfdfa600a7c51
-  data.tar.gz: dda77c2f7e9e80bb37e4783b6559e53cc0acaa6a403e3b17f66fc8a5db3501f01cc2c9f3844747809bf54f1f8e37648b3099102a428e6d169cd30045090f2b15
+  metadata.gz: c62a4b9c3cfeba14ee254cb07d6359adbc1b012c13ea8c061760ddf083b27da2c4867dba951100c2af0362e56441635c2099014695bd69a3c525cee22ead8e92
+  data.tar.gz: acf86862e45f1c2537d4047b7d8cc31cc849cb8cedd9678de5aea58a6dd35e018b9641b487a4995be160d8115ae46270f9eb58754e2b977b358e9efce61b3d55

data/.github/workflows/ruby.yml

@@ -11,26 +11,15 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        rails_version: [6.1.1]
-        ruby: [2.7, '3.0']
-    env:
-      RAILS_VERSION: ${{ matrix.rails_version }}
-    steps:
-    - uses: actions/checkout@v2
-    - name: Set up Ruby ${{ matrix.ruby }}
-      uses: ruby/setup-ruby@v1
-      with:
-        ruby-version: ${{ matrix.ruby }}
-    - name: Install dependencies with Rails ${{ matrix.rails_version }}
-      run: bundle install
-    - name: Run tests
-      run: bundle exec rake
-  test_rails52:
-    runs-on: ubuntu-latest
-    strategy:
-      matrix:
-        rails_version: [5.2.4.4, 6.0.3.4]
-        ruby: [2.7]
+        rails_version: [6.1.4.6]
+        ruby: ['2.7', '3.0']
+        include:
+          - rails_version: 7.0.2.2
+            ruby: '3.0'
+          - rails_version: 5.2.4.4
+            ruby: '2.7'
+          - rails_version: 6.0.3.4
+            ruby: '2.7'
     env:
       RAILS_VERSION: ${{ matrix.rails_version }}
     steps:

data/README.md

@@ -1,5 +1,5 @@
 # Blacklight::Gallery
-[![Gem Version](https://badge.fury.io/rb/blacklight-gallery.svg)](http://badge.fury.io/rb/blacklight-gallery)  [![Build Status](https://travis-ci.org/projectblacklight/blacklight-gallery.svg?branch=master)](https://travis-ci.org/projectblacklight/blacklight-gallery)
+[![Gem Version](https://badge.fury.io/rb/blacklight-gallery.svg)](http://badge.fury.io/rb/blacklight-gallery) [![CI](https://github.com/projectblacklight/blacklight-gallery/actions/workflows/ruby.yml/badge.svg)](https://github.com/projectblacklight/blacklight-gallery/actions/workflows/ruby.yml)
 
 Gallery views for Blacklight search results
 

data/app/assets/stylesheets/blacklight_gallery/_gallery.scss

@@ -2,9 +2,7 @@
   .document {
     border-bottom: none;
     display: flex;
-
     min-height: 250px;
-    -webkit-flex: 1 0 250px;
   }
 
   .caption {

data/app/assets/stylesheets/blacklight_gallery/_slideshow.scss

@@ -85,10 +85,16 @@ $gray-dark: #343a40 !default;
 
   .caption {
     font-size: 1rem;
-    color: $gray-light;
     margin: 10px auto;
     min-width: 200px;
     max-width: 50%;
+    a {
+      color: $gray-light;
+      text-decoration: underline;
+      &:hover, &:focus {
+        color: #ffffff;
+      }
+    }
   }
 
   .counter {

data/app/components/blacklight/gallery/slideshow_component.html.erb

@@ -2,7 +2,7 @@
   <div class="frame">
       <%= slideshow_tag %>
       <div class="caption">
-        <%= presenter.heading %>
+        <%= helpers.link_to_document(presenter.document, presenter.heading, counter: @counter) %>
       </div>
 
       <span class="counter">

data/app/components/blacklight/gallery/slideshow_component.rb

@@ -20,11 +20,11 @@ module Blacklight
           method_name = view_config.slideshow_method
           @view_context.send(method_name, @document, image_options)
         elsif view_config.slideshow_field
-          url = slideshow_image_url
-
-          image_tag url, image_options if url.present?
+          return if slideshow_image_url.blank?
+          image = image_tag slideshow_image_url, image_options
+          helpers.link_to_document(@document, image)
         elsif presenter.thumbnail.exists?
-          presenter.thumbnail.thumbnail_tag(image_options, url_options.reverse_merge(suppress_link: true))
+          presenter.thumbnail.thumbnail_tag(image_options)
         end
       end
 

data/app/helpers/blacklight/openseadragon_helper.rb

@@ -1,7 +1,24 @@
 module Blacklight
   module OpenseadragonHelper
+    # Somewhat arbitrary number; the only important thing is that
+    # it is bigger than the number of embedded viewers on a page
+    ID_COUNTER_MAX = (2**20) - 1
+
+    # Mint a (sufficiently) unique identifier, so we can associate
+    # the expand/collapse control with labels
+    def self.mint_id
+      @id_counter = ((@id_counter || 0) + 1) % ID_COUNTER_MAX
+
+      # We convert the ID to hex for markup compactness
+      @id_counter.to_s(16)
+    end
+
     def osd_container_class
       "col-md-6"
     end
+
+    def osd_html_id_prefix
+      "osd-#{Blacklight::OpenseadragonHelper.mint_id}".to_param
+    end
   end
-end
+end

data/app/views/catalog/_openseadragon_default.html.erb

@@ -1,13 +1,16 @@
-<% image = document.to_openseadragon(blacklight_config.view_config(:show)) %>
+<%
+  image = document.to_openseadragon(blacklight_config.view_config(:show))
+  id_prefix = osd_html_id_prefix
+%>
 <%
   osd_config = {
     crossOriginPolicy: false,
-    zoomInButton:     "osd-zoom-in",
-    zoomOutButton:    "osd-zoom-out",
-    homeButton:       "osd-home",
-    fullPageButton:   "osd-full-page",
-    nextButton:       "osd-next",
-    previousButton:   "osd-previous"
+    zoomInButton:     "#{id_prefix}-zoom-in",
+    zoomOutButton:    "#{id_prefix}-zoom-out",
+    homeButton:       "#{id_prefix}-home",
+    fullPageButton:   "#{id_prefix}-full-page",
+    nextButton:       "#{id_prefix}-next",
+    previousButton:   "#{id_prefix}-previous"
   }
 
   osd_config_referencestrip = {
@@ -26,16 +29,16 @@
       <div class="col-md-6 pagination">
         <% if count > 1 %>
           <% osd_config = osd_config_referencestrip.merge(osd_config) %>
-            <a id="osd-previous"><%= blacklight_icon('chevron_left') %></a>
-            <span id="osd-page">1</span>  of <%= count %>
-            <a id="osd-next"><%= blacklight_icon('chevron_right') %></a>
+            <a id="<%= id_prefix %>-previous"><%= blacklight_icon('chevron_left') %></a>
+            <span id="<%= id_prefix %>-page">1</span>  of <%= count %>
+            <a id="<%= id_prefix %>-next"><%= blacklight_icon('chevron_right') %></a>
         <% end %>
       </div>
       <div class="col-md-6 controls">
-        <a id="osd-zoom-in"><%= blacklight_icon('add_circle') %></a>
-        <a id="osd-zoom-out"><%= blacklight_icon('remove_circle') %></a>
-        <a id="osd-home"><%= blacklight_icon('resize_small') %></a>
-        <a id="osd-full-page"><%= blacklight_icon('custom_fullscreen') %></a>
+        <a id="<%= id_prefix %>-zoom-in"><%= blacklight_icon('add_circle') %></a>
+        <a id="<%= id_prefix %>-zoom-out"><%= blacklight_icon('remove_circle') %></a>
+        <a id="<%= id_prefix %>-home"><%= blacklight_icon('resize_small') %></a>
+        <a id="<%= id_prefix %>-full-page"><%= blacklight_icon('custom_fullscreen') %></a>
       </div>
     </div>
     <%= openseadragon_picture_tag image, class: 'osd-image row', data: { openseadragon: osd_config } %>

data/blacklight-gallery.gemspec

@@ -17,7 +17,7 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
 
-  spec.add_dependency "rails", '>= 5.1', '< 7'
+  spec.add_dependency "rails", '>= 5.1', '< 8'
   spec.add_dependency 'blacklight', '~> 7.17'
 
   spec.add_development_dependency "rake"

data/config/locales/blacklight-gallery.de.yml

@@ -0,0 +1,15 @@
+de:
+  blacklight:
+    search:
+      view:
+        gallery: "Bildergalerie"
+        slideshow: "Diashow"
+        masonry: "Masonry"
+  blacklight_gallery:
+    catalog:
+      grid_slideshow:
+        missing_image: 'fehlend'
+      document_slideshow:
+        header: "Um Bilder als Diashow anzuzeigen, klicken Sie ein Bild"
+      modal_slideshow:
+        counter: "%{counter} von %{count}"

data/lib/blacklight/gallery/version.rb

@@ -1,5 +1,5 @@
 module Blacklight
   module Gallery
-    VERSION = "3.4.0"
+    VERSION = "4.0.1"
   end
 end

data/lib/generators/blacklight_gallery/install_generator.rb

@@ -16,10 +16,9 @@ module BlacklightGallery
 
     def configuration
       inject_into_file 'app/controllers/catalog_controller.rb', after: "configure_blacklight do |config|" do
-        "\n    config.view.gallery.document_component = Blacklight::Gallery::DocumentComponent" \
-        "\n    # config.view.gallery.classes = 'row-cols-2 row-cols-md-3'" \
-        "\n    config.view.masonry.document_component = Blacklight::Gallery::DocumentComponent" \
-        "\n    config.view.slideshow.document_component = Blacklight::Gallery::SlideshowComponent" \
+        "\n    config.view.gallery(document_component: Blacklight::Gallery::DocumentComponent)" \
+        "\n    config.view.masonry(document_component: Blacklight::Gallery::DocumentComponent)" \
+        "\n    config.view.slideshow(document_component: Blacklight::Gallery::SlideshowComponent)" \
         "\n    config.show.tile_source_field = :content_metadata_image_iiif_info_ssm" \
         "\n    config.show.partials.insert(1, :openseadragon)"
       end

data/spec/components/blacklight/gallery/slideshow_component_spec.rb

@@ -15,20 +15,30 @@ RSpec.describe Blacklight::Gallery::SlideshowComponent, type: :component do
     Capybara::Node::Simple.new(render)
   end
 
-  let(:blacklight_config) { Blacklight::Configuration.new }
+  let(:document) do
+    SolrDocument.new(
+      id: 'x',
+    )
+  end
+
   let(:presenter) { Blacklight::IndexPresenter.new(document, view_context, blacklight_config) }
 
   before do
+    allow(view_context).to receive(:current_search_session).and_return(nil)
+    allow(view_context).to receive(:search_session).and_return({})
     allow(view_context).to receive(:blacklight_config).and_return(blacklight_config)
   end
 
   describe '#slideshow_tag' do
     subject { rendered }
 
-    let(:document) { SolrDocument.new({}) }
-
     context 'with a slideshow method' do
-      let(:blacklight_config) { Blacklight::Configuration.new.tap { |config| config.index.slideshow_method = :xyz } }
+      let(:blacklight_config) do
+        Blacklight::Configuration.new.tap do |config|
+          config.index.slideshow_method = :xyz
+          config.track_search_session = false
+        end
+      end
 
       it 'calls the provided slideshow method' do
         expect(view_context).to receive_messages(xyz: 'some-slideshow')
@@ -41,26 +51,39 @@ RSpec.describe Blacklight::Gallery::SlideshowComponent, type: :component do
       end
     end
 
-    context 'with a field' do
-      let(:blacklight_config) { Blacklight::Configuration.new.tap { |config| config.index.slideshow_field = :xyz } }
-      let(:document) { SolrDocument.new({ xyz: 'http://example.com/some.jpg' }) }
+    context 'with a slideshow field' do
+      let(:blacklight_config) do
+        Blacklight::Configuration.new.tap do |config|
+          config.index.slideshow_field = :xyz 
+          config.track_search_session = false
+        end
+      end
+      let(:document) { SolrDocument.new({ xyz: 'http://example.com/some.jpg', id: 'x' }) }
 
       it { is_expected.to have_selector 'img[src="http://example.com/some.jpg"]' }
 
       context 'without data in the field' do
-        let(:document) { SolrDocument.new({}) }
+        let(:document) { SolrDocument.new({id: 'x'}) }
 
         it { is_expected.not_to have_selector 'img' }
       end
     end
 
-    context 'with nothing configured' do
+    context 'with no view_config' do
+      let(:blacklight_config) { Blacklight::Configuration.new.tap { |config| 
+        config.track_search_session = false
+      } }
       it { is_expected.not_to have_selector 'img' }
     end
 
     context 'falling back to a thumbnail' do
-      let(:blacklight_config) { Blacklight::Configuration.new.tap { |config| config.index.thumbnail_field = :xyz } }
-      let(:document) { SolrDocument.new({ xyz: 'http://example.com/thumb.jpg' }) }
+      let(:blacklight_config) do
+        Blacklight::Configuration.new.tap do |config|
+          config.index.thumbnail_field = :xyz 
+          config.track_search_session = false
+        end
+      end
+      let(:document) { SolrDocument.new({ xyz: 'http://example.com/thumb.jpg', id: 'x' }) }
 
       it { is_expected.to have_selector 'img[src="http://example.com/thumb.jpg"]' }
     end

data/spec/test_app_templates/Gemfile.extra

@@ -1 +0,0 @@
-gem 'sprockets', '< 4'

data/spec/views/catalog/_document_slideshow.html.erb_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe "catalog/_document_slideshow.html.erb", :type => :view do
+describe "catalog/_document_slideshow", :type => :view do
   let(:blacklight_config) do
     Blacklight::Configuration.new do |config|
       config.track_search_session = false

data/spec/views/catalog/_openseadragon_default.html.erb_spec.rb

@@ -3,7 +3,7 @@ require 'spec_helper'
 describe "catalog/openseadragon_default" do
   let(:document) { SolrDocument.new }
   let(:blacklight_config) { Blacklight::Configuration.new }
-  let(:p) { "catalog/openseadragon_default.html.erb" }
+  let(:p) { "catalog/openseadragon_default" }
 
   before do
     allow(view).to receive_messages(blacklight_config: blacklight_config, openseadragon_picture_tag: "<img />")
@@ -14,9 +14,9 @@ describe "catalog/openseadragon_default" do
     render partial: p, locals: { document: document }
     expect(rendered).to have_selector ".openseadragon-container"
   end
-  
+
   it "should support passing a container class" do
     render partial: p, locals: { document: document, osd_container_class: "custom-container" }
     expect(rendered).to have_selector ".custom-container"
   end
-end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: blacklight-gallery
 version: !ruby/object:Gem::Version
-  version: 3.4.0
+  version: 4.0.1
 platform: ruby
 authors:
 - Chris Beer
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-02-04 00:00:00.000000000 Z
+date: 2022-06-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -19,7 +19,7 @@ dependencies:
         version: '5.1'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '7'
+        version: '8'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -29,7 +29,7 @@ dependencies:
         version: '5.1'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '7'
+        version: '8'
 - !ruby/object:Gem::Dependency
   name: blacklight
   requirement: !ruby/object:Gem::Requirement
@@ -262,6 +262,7 @@ files:
 - app/views/catalog/_slideshow_modal.html.erb
 - blacklight-gallery.gemspec
 - config/locales/blacklight-gallery.ar.yml
+- config/locales/blacklight-gallery.de.yml
 - config/locales/blacklight-gallery.en.yml
 - config/locales/blacklight-gallery.es.yml
 - config/locales/blacklight-gallery.fr.yml