blacklight-access_controls 0.5.0 → 0.5.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: df1f39af20b67cfc2e2c67c604b555349db0974f
-  data.tar.gz: fff1a1c47059217f4469cc263407787f12a66cd4
+  metadata.gz: 9848df97495a043646fee764f7dda99465041821
+  data.tar.gz: ba6e8f65ea7ed2c7968867b6b6e218b934e73379
 SHA512:
-  metadata.gz: 4744d9de092e65196a7a3a7be04981496fff4277eb2fb48cfad7efb14ae2b6878c14562cd40149e95b812c2b7c28e8c97e6ac56ea92600281a6482bdbe541fb3
-  data.tar.gz: a42057263e9c5cd3fe599f4f833b0a18b0a26891fd0f31f64bd4d38ce39ec7043d0a6c590a9543477ff67e2e5cf00488c321c309b8e4364b93e3fc1be32926e4
+  metadata.gz: c8530328e2494fc97e1646af356c6112437d192c2fcd7e7524cf728dc0442af1501dd06e5719a1a326d9fbc6bf92d74a57c798007418aaa944d229788270643a
+  data.tar.gz: 3979b92c05c708de3f47ab486abdeda3e383ad50369cdb3d04210c69e8bc701d328cc94ec042ecd409b4068828739a21c1d1affccf3f750beece6b552aa9b5a6

data/VERSION

@@ -1 +1 @@
-0.5.0
+0.5.1

data/lib/blacklight/access_controls/enforcement.rb

@@ -70,7 +70,7 @@ module Blacklight
         # for groups
         permission_types.map do |type|
           field = solr_field_for(type, 'group')
-          groups = ability.user_groups.map { |g| escape_value(g) }
+          groups = ability.user_groups
           # The parens are required to properly OR the cases together.
           "({!terms f=#{field}}#{groups.join(',')})"
         end

data/spec/unit/enforcement_spec.rb

@@ -47,8 +47,8 @@ describe Blacklight::AccessControls::Enforcement do
       end
 
       it "searches for my groups" do
-        expect(@solr_parameters[:fq].first).to match(%r{\{!terms f=discover_access_group_ssim\}public,faculty,africana\\-faculty,registered})
-        expect(@solr_parameters[:fq].first).to match(%r{\{!terms f=read_access_group_ssim\}public,faculty,africana\\-faculty,registered})
+        expect(@solr_parameters[:fq].first).to match(%r{\{!terms f=discover_access_group_ssim\}public,faculty,africana-faculty,registered})
+        expect(@solr_parameters[:fq].first).to match(%r{\{!terms f=read_access_group_ssim\}public,faculty,africana-faculty,registered})
       end
 
       it "searches for my user key" do
@@ -106,27 +106,27 @@ describe Blacklight::AccessControls::Enforcement do
     context 'slashes in the group names' do
       let(:groups) { ["abc/123","cde/567"] }
 
-      it "should escape slashes" do
-        expect(@solr_parameters[:fq].first).to match(%r{\{!terms f=discover_access_group_ssim\}public,abc\\/123,cde\\/567,registered})
-        expect(@solr_parameters[:fq].first).to match(%r{\{!terms f=read_access_group_ssim\}public,abc\\/123,cde\\/567,registered})
+      it "doesn't escape slashes" do
+        expect(@solr_parameters[:fq].first).to match(%r{\{!terms f=discover_access_group_ssim\}public,abc/123,cde/567,registered})
+        expect(@solr_parameters[:fq].first).to match(%r{\{!terms f=read_access_group_ssim\}public,abc/123,cde/567,registered})
       end
     end
 
     context 'spaces in the group names' do
       let(:groups) { ["abc 123","cd/e 567"] }
 
-      it "escapes spaces in group names" do
-        expect(@solr_parameters[:fq].first).to match(%r{\{!terms f=discover_access_group_ssim\}public,abc\\ 123,cd\\/e\\ 567,registered})
-        expect(@solr_parameters[:fq].first).to match(%r{\{!terms f=read_access_group_ssim\}public,abc\\ 123,cd\\/e\\ 567,registered})
+      it "doesn't escape spaces in group names" do
+        expect(@solr_parameters[:fq].first).to match(%r{\{!terms f=discover_access_group_ssim\}public,abc 123,cd/e 567,registered})
+        expect(@solr_parameters[:fq].first).to match(%r{\{!terms f=read_access_group_ssim\}public,abc 123,cd/e 567,registered})
       end
     end
 
     context 'colons in the groups names' do
       let(:groups) { ["abc:123","cde:567"] }
 
-      it "should escape colons" do
-        expect(@solr_parameters[:fq].first).to match(%r{\{!terms f=discover_access_group_ssim\}public,abc\\:123,cde\\:567,registered})
-        expect(@solr_parameters[:fq].first).to match(%r{\{!terms f=read_access_group_ssim\}public,abc\\:123,cde\\:567,registered})
+      it "doesn't escape colons" do
+        expect(@solr_parameters[:fq].first).to match(%r{\{!terms f=discover_access_group_ssim\}public,abc:123,cde:567,registered})
+        expect(@solr_parameters[:fq].first).to match(%r{\{!terms f=read_access_group_ssim\}public,abc:123,cde:567,registered})
       end
     end
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: blacklight-access_controls
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 0.5.1
 platform: ruby
 authors:
 - Chris Beer