blackbeard 0.0.4.0 → 0.0.5.0

data/spec/cohort_metric_spec.rb

@@ -0,0 +1,26 @@
+require File.expand_path(File.dirname(__FILE__) + '/spec_helper')
+
+module Blackbeard
+  describe CohortMetric do
+    let(:metric) { Metric.create(:total, "one-total") }
+    let(:cohort) { Cohort.create(:example) }
+    let(:cohort_metric){ CohortMetric.new( cohort, metric) }
+    let(:metric_data) { cohort_metric.metric_data }
+
+    describe "add" do
+      let(:context) { double(:unique_identifier => 'uid', :controller => double, :user => double) }
+
+      it "should increment metric data" do
+        cohort.should_receive(:hour_id_for_participant).with('uid').and_return("2014010101")
+        metric_data.should_receive(:add_at).with("2014010101","uid",1)
+        cohort_metric.add(context, 1)
+      end
+
+      it "should not increment non participants" do
+        cohort.should_receive(:hour_id_for_participant).with('uid').and_return(nil)
+        metric_data.should_not_receive(:add_at).with("2014010101","uid",1)
+        cohort_metric.add(context, 1)
+      end
+    end
+  end
+end

data/spec/cohort_spec.rb

@@ -0,0 +1,31 @@
+require File.expand_path(File.dirname(__FILE__) + '/spec_helper')
+
+module Blackbeard
+  describe Cohort do
+    let(:uid){ "an id" }
+    let(:hour){ Time.new(2014,3,5,1) }
+    let(:cohort) { Cohort.new(:happy) }
+    let(:cohort_data) { CohortData.new(cohort) }
+
+    describe "add" do
+      let(:context){ double :unique_identifier => uid }
+      before :each do
+        cohort.stub(:data).and_return(cohort_data)
+      end
+
+      it "should save the cohort if its new" do
+        cohort.should_receive(:save)
+        cohort.add(context)
+      end
+      it "should call add_with_force if forced used" do
+        cohort_data.should_receive(:add_with_force).with(uid, hour).and_return(true)
+        cohort.add(context, hour, true).should be_true
+      end
+      it "should call add_without_force if not forced used" do
+        cohort_data.should_receive(:add_without_force).with(uid, hour).and_return(true)
+        cohort.add(context, hour).should be_true
+      end
+    end
+
+  end
+end

data/spec/context_spec.rb

@@ -9,6 +9,7 @@ module Blackbeard
     let(:total_metric) { Metric.create(:total, :things) }
     let(:unique_metric) { Metric.create(:unique, :things) }
     let(:test) { Test.create(:example_test) }
+    let(:cohort) { Cohort.create(:joined) }
 
     describe "#add_total" do
       it "should call add on the total metric" do
@@ -26,6 +27,14 @@ module Blackbeard
       end
     end
 
+    describe "#add_to_cohort" do
+      it "should call add on the cohort" do
+        pirate.should_receive(:cohort).with("joined"){ cohort }
+        cohort.should_receive(:add).with(context, nil, false)
+        context.add_to_cohort(:joined)
+      end
+    end
+
     describe "#ab_test" do
       before :each do
         pirate.should_receive(:test).with(test.id).and_return(test)
@@ -94,7 +103,6 @@ module Blackbeard
         inactive_feature.should_receive(:active_for?).with(context).and_return(false)
         context.feature_active?(:inactive_feature).should be_false
       end
-
     end
 
   end

data/spec/dashboard/cohorts_spec.rb

@@ -0,0 +1,43 @@
+require File.expand_path(File.dirname(__FILE__) + './../spec_helper')
+
+require 'rack/test'
+require 'blackbeard/dashboard'
+
+module Blackbeard
+  describe Dashboard do
+    include Rack::Test::Methods
+
+    let(:app) { Dashboard }
+
+    describe "get /cohorts" do
+      it "should list all the groups" do
+        Cohort.create("jostling")
+        get "/cohorts"
+
+        last_response.should be_ok
+        last_response.body.should include('cohorts')
+      end
+    end
+
+    describe "get /cohorts/:id" do
+      it "should show a metric" do
+        cohort = Cohort.create("jostling")
+        get "/cohorts/#{cohort.id}"
+
+        last_response.should be_ok
+        last_response.body.should include("jostling")
+      end
+    end
+
+    describe "post /cohorts/:id" do
+      it "should update the cohort" do
+        cohort = Cohort.create("jostling")
+        post "/cohorts/#{cohort.id}", :name => 'hello'
+
+        last_response.should be_ok
+        Cohort.find("jostling").name.should == 'hello'
+      end
+    end
+
+  end
+end

data/spec/dashboard/groups_spec.rb

@@ -9,13 +9,6 @@ module Blackbeard
 
     let(:app) { Dashboard }
 
-    describe "get /" do
-      it "should redirect" do
-        get "/"
-        last_response.should be_ok
-      end
-    end
-
     describe "get /groups" do
       it "should list all the groups" do
         Group.create("jostling")

data/spec/dashboard/metrics_spec.rb

@@ -27,6 +27,27 @@ module Blackbeard
         last_response.should be_ok
         last_response.body.should include("jostling")
       end
+
+      it "should show a metric with a group" do
+        metric = Metric.create("total", "jostling")
+        group = Group.create(:example)
+        metric.add_group(group)
+        get "/metrics/#{metric.type}/#{metric.type_id}", :group_id => group.id
+
+        last_response.should be_ok
+        last_response.body.should include("jostling")
+      end
+
+      it "should show a metric with a cohort" do
+        metric = Metric.create("total", "jostling")
+        cohort = Cohort.create(:example)
+        metric.add_cohort(cohort)
+        get "/metrics/#{metric.type}/#{metric.type_id}", :cohort_id => cohort.id
+
+        last_response.should be_ok
+        last_response.body.should include("jostling")
+      end
+
     end
 
     describe "post /metrics/:type/:type_id" do
@@ -53,5 +74,19 @@ module Blackbeard
     end
 
 
+    describe "post /metrics/:type/:type_id/cohorts" do
+      it "should add a cohort to the metric" do
+        metric = Metric.create("total", "jostling")
+        cohort = Cohort.create("admin")
+        post "/metrics/#{metric.type}/#{metric.type_id}/cohorts", :cohort_id => cohort.id
+
+        last_response.should be_redirect
+        follow_redirect!
+        last_request.url.should == "http://example.org/metrics/#{metric.type}/#{metric.type_id}?cohort_id=#{cohort.id}"
+        metric.has_cohort?(cohort).should be_true
+      end
+    end
+
+
   end
 end

data/spec/group_metric_spec.rb

@@ -0,0 +1,26 @@
+require File.expand_path(File.dirname(__FILE__) + '/spec_helper')
+
+module Blackbeard
+  describe GroupMetric do
+    let(:metric) { Metric.create(:total, "one-total") }
+    let(:group) { Group.create(:example) }
+    let(:metric_data) { group_metric.metric_data }
+    # let(:group_metric_data) { metric.metric_data(group) }
+    let(:group_metric){ GroupMetric.new( group, metric) }
+    describe "add" do
+      let(:context) { double(:unique_identifier => 'uid', :controller => double, :user => double) }
+
+      it "should increment metric data" do
+        group.stub(:segment_for).and_return("segment")
+        metric_data.should_receive(:add).with("uid",1, "segment")
+        group_metric.add(context, 1)
+      end
+
+      it "should not increment nil segments" do
+        group.stub(:segment_for).and_return(nil)
+        metric_data.should_not_receive(:add).with("uid",1, "segment")
+        group_metric.add(context, 1)
+      end
+    end
+  end
+end

data/spec/metric_data/base_spec.rb

@@ -27,22 +27,6 @@ module Blackbeard
         end
       end
 
-      describe "recent_hours" do
-        let(:start_at) { Time.new(2014,1,1,12,0,0) }
-
-        it "should return results for recent hours" do
-          metric_data.recent_hours(3, start_at).should have(3).metric_hours
-        end
-      end
-
-      describe "recent_days" do
-        let(:start_on) { Date.new(2014,1,3) }
-
-        it "should return results for recent days" do
-          metric_data.recent_days(3, start_on).should have(3).metric_days
-        end
-      end
-
       describe "hour_keys_for_day" do
         it "should return 1 key for every hour from morning to night" do
             keys_for_day = metric_data.hour_keys_for_day(Date.new(2014,1,1))

data/spec/metric_data/uid_generator_spec.rb

@@ -0,0 +1,40 @@
+require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
+
+module Blackbeard
+  module MetricData
+
+    describe UidGenerator do
+      let(:metric) { Blackbeard::Metric.new(:total, "one-total") }
+      let(:metric2) { Blackbeard::Metric.new(:total, "two-total") }
+      let(:metric_data) { metric.metric_data }
+      let(:metric_data2) { metric2.metric_data }
+
+      context "already existing uid" do
+        it "should return the existing uid" do
+          UidGenerator.new(metric_data).uid.should == UidGenerator.new(metric_data).uid
+        end
+      end
+      context "new metric_data" do
+        it "should increment to the next uid" do
+          uid = UidGenerator.new(metric_data).uid
+          UidGenerator.new(metric_data2).uid.to_i.should == uid.to_i + 1
+        end
+      end
+
+      describe "lookup field" do
+        context "with a cohort" do
+          it "should return the field unique to cohort" do
+            metric.save
+            cohort = Cohort.create(:example_cohort)
+            cohort_metric = CohortMetric.new(cohort, metric)
+            metric.add_cohort(cohort)
+            gen1 = UidGenerator.new(cohort_metric.metric_data)
+            gen2 = UidGenerator.new(metric.metric_data)
+            gen1.send(:lookup_field).should_not == gen2.send(:lookup_field)
+          end
+        end
+      end
+    end
+
+  end
+end

data/spec/metric_spec.rb

@@ -3,9 +3,7 @@ require File.expand_path(File.dirname(__FILE__) + '/spec_helper')
 module Blackbeard
   describe Metric do
     let(:metric) { Metric.create(:total, "one-total") }
-    let(:group) { Group.create(:example) }
     let(:metric_data) { metric.metric_data }
-    let(:group_metric_data) { metric.metric_data(group) }
 
     describe "self.all" do
       before :each do
@@ -20,31 +18,31 @@ module Blackbeard
 
     describe "add" do
       let(:context) { double(:unique_identifier => 'uid', :controller => double, :user => double) }
-      before :each do
-        metric.stub(:groups).and_return([group])
-      end
 
       it "should increment metric data" do
         metric_data.should_receive(:add).with("uid",1)
         metric.add(context, 1)
       end
 
-      it "should increment metric data for each group" do
-        group.stub(:segment_for).and_return("segment")
-        group_metric_data.should_receive(:add).with("uid", 1, "segment" )
+      it "should call add on all group metrics" do
+        group_metric = double
+        metric.should_receive(:group_metrics).and_return([group_metric])
+        group_metric.should_receive(:add).with(context, 1)
         metric.add(context, 1)
       end
 
-      it "should not increment nil segments" do
-        group.stub(:segment_for).and_return(nil)
-        group_metric_data.should_not_receive(:add)
+      it "should call add on all cohort metrics" do
+        cohort_metric = double
+        metric.should_receive(:cohort_metrics).and_return([cohort_metric])
+        cohort_metric.should_receive(:add).with(context, 1)
         metric.add(context, 1)
       end
+
     end
 
     describe "addable_groups" do
+      let!(:group) { Group.create(:example) }
       it "should include the groups not added" do
-        group # to initialize it
         metric.addable_groups.map{|g| g.id }.should include(group.id)
       end
 
@@ -54,5 +52,18 @@ module Blackbeard
       end
     end
 
+    describe "addable_cohorts" do
+      let!(:cohort){ Cohort.create(:example)}
+
+      it "should include the groups not added" do
+        metric.addable_cohorts.map{|g| g.id }.should include(cohort.id)
+      end
+
+      it "should not include the group added" do
+        metric.add_cohort(cohort)
+        metric.addable_cohorts.map{|c| c.id }.should_not include(cohort.id)
+      end
+    end
+
   end
 end

data/spec/pirate_spec.rb

@@ -21,6 +21,11 @@ describe Blackbeard::Pirate do
       4.times{ pirate.feature(name) }
     end
 
+    it "should get cohorts once" do
+      Blackbeard::Cohort.should_receive(:find_or_create).with(name).once.and_return(double)
+      4.times{ pirate.cohort(name) }
+    end
+
   end
 
   describe "#context" do
@@ -45,10 +50,14 @@ describe Blackbeard::Pirate do
         expect{ pirate.ab_test(:example, :on => 1, :off => 2) }.to_not raise_error
       end
 
-      it "active? should not raise error" do
+      it "feature_active? should not raise error" do
         expect{ pirate.feature_active?(:example) }.to_not raise_error
       end
 
+      it "add_to_cohort should not raise error" do
+        expect{ pirate.add_to_cohort(:example) }.to_not raise_error
+      end
+
     end
     context "with context set" do
       let(:user){ double }
@@ -73,6 +82,18 @@ describe Blackbeard::Pirate do
         set_context.should_receive(:feature_active?).with(:example_feature).and_return(false)
         pirate.feature_active?(:example_feature)
       end
+
+      it "should delegate add_to_cohort" do
+        timestamp = double
+        set_context.should_receive(:add_to_cohort).with(:example, timestamp).and_return(true)
+        pirate.add_to_cohort(:example, timestamp)
+      end
+
+      it "should delegate add_to_cohort!" do
+        timestamp = double
+        set_context.should_receive(:add_to_cohort!).with(:example, timestamp).and_return(true)
+        pirate.add_to_cohort!(:example, timestamp)
+      end
     end
   end
 

data/spec/redis_store_spec.rb

@@ -14,9 +14,9 @@ module Blackbeard
         db.hash_get('a_hash', 'hello').should == 'world'
       end
 
-      it "should multi set" do
+      it "should multi set and get" do
         db.hash_multi_set('a_hash', {:one => 'two', :three => 'four'})
-        db.hash_get('a_hash','three').should == 'four'
+        db.hash_multi_get('a_hash',['three','one']).should == ['four','two']
       end
 
       it "should not raise error on multi set with empty hash" do
@@ -52,6 +52,12 @@ module Blackbeard
         db.hash_get('a_hash', 'field').should == "3.5"
       end
 
+      it "should increment by int" do
+        db.hash_increment_by('a_hash', 'field', 1)
+        db.hash_increment_by('a_hash', 'field', 2.5)
+        db.hash_get('a_hash', 'field').should == "3"
+      end
+
       it "should determine if key exists" do
         expect{
           db.hash_set('a_hash', 'field', 'exists')

data/spec/storable_spec.rb

@@ -108,6 +108,9 @@ module Blackbeard
             new_record.save
           }.to change{ new_record.new_record }.from(true).to(false)
       end
+      it "should return true" do
+        new_record.save.should be_true
+      end
     end
 
     describe "master_key" do