biz 1.6.0 → 1.6.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e3d348e477f526c87601d6b59362fbb9e17b2dba
-  data.tar.gz: 83019f10ea87e74a41f317dd388dbe9d7ee204b6
+  metadata.gz: b83065efe295ea89da135b593191120dc58bcf6d
+  data.tar.gz: 97b8e746410d76e35145b0e41920a0ba04801e9d
 SHA512:
-  metadata.gz: c1c66c64493a052cc7d99aef3268cedb1691bbacde44f7cc731345a397e61627a7d589c789b071b7696add9585392ddbbe449cb61a185247e97a14bf6b8e055f
-  data.tar.gz: 523a4308dbda6e8e37d24d62474f70ed783b2d10ef65caabbb0047b0e21d3283d53d6b9678dff21ea46879968fd31d938aa74a272276c764b4dc6d2eb686421a
+  metadata.gz: 5e8f3d0ae0c724ade11514895b7ce160d6303b76679bafb38d2ff6daf03b469f0dd47789696a4e58009f1ef2608d96f63af5abeee888b7fe5954d305927e4e58
+  data.tar.gz: 63c26133dd00077646bf011d34e22f5b869498c30ba13327e224bf2023c23e3d332e3a59ccd0424b39ea2be1256fda39ab347358a1681fd4c7d9441601759eaa

data/README.md

@@ -138,7 +138,21 @@ Biz.periods
 #  #<Biz::TimeSegment start_time=2015-04-27 20:36:57 UTC end_time=2015-04-28 00:00:00 UTC>]
 ```
 
-## Schedule Intersection
+#### Day calculation semantics
+
+Unlike seconds, minutes, or hours, a "day" is an ambiguous concept, particularly
+in relation to the vast number of potential schedule configurations. Because of
+that, day calculations are implemented with the principle of making the logic as
+straightforward as possible while knowing not all use cases will be satisfied
+out of the box.
+
+Here's the logic that's followed:
+
+> Find the next day that contains business hours. Starting from the same minute
+> on that day as the specified time, look forward (or back) to find the next
+> moment in time that is in business hours.
+
+## Schedule intersection
 
 An intersection of two schedules can be found using `&`:
 
@@ -222,10 +236,10 @@ Biz::Schedule.new do |config|
 end
 ```
 
-## Core Extensions
+## Core extensions
 
-Optional extensions to core classes (`Date`, `Fixnum`, and `Time`) are available
-for additional expressiveness:
+Optional extensions to core classes (`Date`, `Integer`, and `Time`) are
+available for additional expressiveness:
 
 ```ruby
 require 'biz/core_ext'

data/lib/biz/calculation/active.rb

@@ -8,9 +8,9 @@ module Biz
       end
 
       def result
-        schedule.intervals.any?   { |interval| interval.contains?(time) } &&
-          schedule.breaks.none?   { |break_| break_.contains?(time) } &&
-          schedule.holidays.none? { |holiday| holiday.contains?(time) }
+        schedule.intervals.any?      { |interval| interval.contains?(time) } \
+          && schedule.breaks.none?   { |brake| brake.contains?(time) } \
+          && schedule.holidays.none? { |holiday| holiday.contains?(time) }
       end
 
       protected

data/lib/biz/calculation/on_break.rb

@@ -8,7 +8,7 @@ module Biz
       end
 
       def result
-        schedule.breaks.any? { |break_| break_.contains?(time) }
+        schedule.breaks.any? { |brake| brake.contains?(time) }
       end
 
       protected

data/lib/biz/core_ext.rb

@@ -4,9 +4,9 @@ module Biz
 end
 
 require 'biz/core_ext/date'
-require 'biz/core_ext/fixnum'
+require 'biz/core_ext/integer'
 require 'biz/core_ext/time'
 
-Date.class_eval   do include Biz::CoreExt::Date   end
-Fixnum.class_eval do include Biz::CoreExt::Fixnum end
-Time.class_eval   do include Biz::CoreExt::Time   end
+Date.class_eval    do include Biz::CoreExt::Date    end
+Integer.class_eval do include Biz::CoreExt::Integer end
+Time.class_eval    do include Biz::CoreExt::Time    end

data/lib/biz/core_ext/{fixnum.rb → integer.rb}

@@ -1,6 +1,6 @@
 module Biz
   module CoreExt
-    module Fixnum
+    module Integer
       Calculation::ForDuration.units.each do |unit|
         define_method("business_#{unit}") { Biz.time(self, unit) }
       end

data/lib/biz/day_of_week.rb

@@ -13,6 +13,8 @@ module Biz
       ALL.fetch(SYMBOLS.index(symbol))
     end
 
+    attr_reader :wday
+
     def initialize(wday)
       @wday = Integer(wday)
     end
@@ -55,10 +57,6 @@ module Biz
       wday <=> other.wday
     end
 
-    protected
-
-    attr_reader :wday
-
     ALL = (0..6).map(&method(:new)).freeze
 
     private_constant :SYMBOLS,

data/lib/biz/day_time.rb

@@ -51,9 +51,7 @@ module Biz
     def initialize(day_second)
       @day_second = Integer(day_second)
 
-      unless VALID_SECONDS.cover?(@day_second)
-        fail ArgumentError, 'second not within a day'
-      end
+      fail ArgumentError, 'second not within a day' unless valid_second?
     end
 
     attr_reader :day_second
@@ -88,6 +86,12 @@ module Biz
       day_second <=> other.day_second
     end
 
+    private
+
+    def valid_second?
+      VALID_SECONDS.cover?(day_second)
+    end
+
     MIDNIGHT = from_hour(0)
     ENDNIGHT = from_hour(24)
 

data/lib/biz/periods/abstract.rb

@@ -1,14 +1,12 @@
 module Biz
   module Periods
-    class Abstract < Enumerator::Lazy
-
-      extend Forwardable
+    class Abstract < SimpleDelegator
 
       def initialize(schedule, origin)
         @schedule = schedule
         @origin   = origin
 
-        super(periods) do |yielder, period| yielder << period end
+        super(periods)
       end
 
       def timeline

data/lib/biz/version.rb

@@ -1,3 +1,3 @@
 module Biz
-  VERSION = '1.6.0'.freeze
+  VERSION = '1.6.1'.freeze
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: biz
 version: !ruby/object:Gem::Version
-  version: 1.6.0
+  version: 1.6.1
 platform: ruby
 authors:
 - Craig Little
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-06-13 00:00:00.000000000 Z
+date: 2017-01-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: clavius
@@ -45,14 +45,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '11.0'
+        version: '12.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '11.0'
+        version: '12.0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -86,7 +86,7 @@ files:
 - lib/biz/configuration.rb
 - lib/biz/core_ext.rb
 - lib/biz/core_ext/date.rb
-- lib/biz/core_ext/fixnum.rb
+- lib/biz/core_ext/integer.rb
 - lib/biz/core_ext/time.rb
 - lib/biz/date.rb
 - lib/biz/dates.rb
@@ -128,7 +128,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '2.0'
+      version: '2.1'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
@@ -136,7 +136,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.1
+rubygems_version: 2.6.8
 signing_key: 
 specification_version: 4
 summary: Business hours calculations